[jira] [Commented] (JCLOUDS-1334) Guava 23.0 incompatibility: missing SimpleTimeLimiter constructor
[ https://issues.apache.org/jira/browse/JCLOUDS-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144476#comment-17144476 ] ASF subversion and git services commented on JCLOUDS-1334: -- Commit 62767a14610fc1c97c440dbd5ee0f02b276a1069 in jclouds's branch refs/heads/master from Andrew Gaul [ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=62767a1 ] JCLOUDS-1333: JCLOUDS-1334: JCLOUDS-1470: Require Java 8 and Guava 22 This allows compatibility with Guava 29. Also unwind some older workarounds. > Guava 23.0 incompatibility: missing SimpleTimeLimiter constructor > - > > Key: JCLOUDS-1334 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1334 > Project: jclouds > Issue Type: Bug > Components: jclouds-core >Reporter: Tim Peierls >Assignee: Andrew Gaul >Priority: Minor > Labels: guava > Fix For: 2.1.0 > > Original Estimate: 24h > Remaining Estimate: 24h > > With Guava 23, the public constructor for SimpleTimeLimiter, which was > deprecated in Guava 22.0, has been removed. This constructor is used by > JClouds' ExecutorServiceModule and by some tests. > Tests won't be compiled under Guava 23, so that's not a concern, but anyone > running JClouds with Guava 23 will get a runtime error when > ExecutorServiceModule is loaded. > Easiest fix is to use reflection to call SimpleTimeLimiter.create (introduced > in Guava 22.0) if possible, and fall back to the constructor otherwise. > This was noticed after the resolution of JCLOUDS-1225, which brought > compatibility to Guava 22.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (JCLOUDS-1334) Guava 23.0 incompatibility: missing SimpleTimeLimiter constructor
[ https://issues.apache.org/jira/browse/JCLOUDS-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142990#comment-16142990 ] ASF subversion and git services commented on JCLOUDS-1334: -- Commit e08acc6ed6b2761b6063f9ae105ee9f4077ef418 in jclouds's branch refs/heads/master from [~tpeierls] [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=e08acc6 ] JCLOUDS-1334: Guava 23 compatiblity Reflective creation of SimpleTimeLimiter to allow compatibility with Guava 23.0. SimpleTimeLimiter.create(ExecutorService) was introduced in Guava 22.0 to replace the SimpleTimeLimiter(ExecutorService) constructor, which was deprecated in Guava 22.0 and removed in Guava 23.0. > Guava 23.0 incompatibility: missing SimpleTimeLimiter constructor > - > > Key: JCLOUDS-1334 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1334 > Project: jclouds > Issue Type: Bug > Components: jclouds-core >Reporter: Tim Peierls >Priority: Minor > Labels: guava > Fix For: 2.1.0 > > Original Estimate: 24h > Remaining Estimate: 24h > > With Guava 23, the public constructor for SimpleTimeLimiter, which was > deprecated in Guava 22.0, has been removed. This constructor is used by > JClouds' ExecutorServiceModule and by some tests. > Tests won't be compiled under Guava 23, so that's not a concern, but anyone > running JClouds with Guava 23 will get a runtime error when > ExecutorServiceModule is loaded. > Easiest fix is to use reflection to call SimpleTimeLimiter.create (introduced > in Guava 22.0) if possible, and fall back to the constructor otherwise. > This was noticed after the resolution of JCLOUDS-1225, which brought > compatibility to Guava 22.0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
