Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2020-06-24 Thread Andrew Gaul
Closed #1197.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1197#event-3479849597

Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2020-06-24 Thread Andrew Gaul
Superseded by apache/jclouds#75.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1197#issuecomment-649141949

Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2018-05-21 Thread Andrea Turli
see also https://github.com/jclouds/jclouds-karaf/pull/108

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1197#issuecomment-390654763

Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2018-05-18 Thread Ignasi Barrera
That's fantastic. Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1197#issuecomment-390352688

Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2018-05-18 Thread Andrea Turli
I'm trying to build jclouds-karaf but it requires some other additional changes 
on top of yours above

I'll try to make it work and open a PR to jclouds-karaf connected to this one

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1197#issuecomment-390302985

Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2018-05-01 Thread Ignasi Barrera
@demobox @neykov @andreaturli ping?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1197#issuecomment-385681398

Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2018-04-18 Thread Ignasi Barrera
I've build jclouds and labs with this change then tried to build jcloud-karaf, 
but I get the following error:

```bash
[WARNING] Feature resolution failed for [jclouds-all-blobstore/2.2.0.SNAPSHOT]
Message: Unable to resolve root: missing requirement [root] osgi.identity; 
osgi.identity=jclouds-all-blobstore; type=karaf.feature; 
version=2.2.0.SNAPSHOT; 
filter:="(&(osgi.identity=jclouds-all-blobstore)(type=karaf.feature)(version>=2.2.0.SNAPSHOT))"
   [caused by: Unable to resolve jclouds-all-blobstore/2.2.0.SNAPSHOT: missing 
requirement [jclouds-all-blobstore/2.2.0.SNAPSHOT] osgi.identity; 
osgi.identity=jclouds-api-openstack-swift; type=karaf.feature; 
version="[2.2.0.SNAPSHOT,2.2.0.SNAPSHOT]"
   [caused by: Unable to resolve jclouds-api-openstack-swift/2.2.0.SNAPSHOT: 
missing requirement [jclouds-api-openstack-swift/2.2.0.SNAPSHOT] osgi.identity; 
osgi.identity=jclouds-blobstore; type=karaf.feature; 
version="[2.2.0.SNAPSHOT,2.2.0.SNAPSHOT]"
   [caused by: Unable to resolve jclouds-blobstore/2.2.0.SNAPSHOT: missing 
requirement [jclouds-blobstore/2.2.0.SNAPSHOT] osgi.identity; 
osgi.identity=jclouds-blobstore; type=osgi.bundle; 
version="[2.2.0.SNAPSHOT,2.2.0.SNAPSHOT]"; resolution:=mandatory
   [caused by: Unable to resolve jclouds-blobstore/2.2.0.SNAPSHOT: missing 
requirement [jclouds-blobstore/2.2.0.SNAPSHOT] osgi.wiring.package; 
filter:="(&(osgi.wiring.package=com.google.common.base)(version>=21.0.0)(!(version>=25.0.0)))"
   [caused by: Unable to resolve com.google.guava/21.0.0: missing requirement 
[com.google.guava/21.0.0] osgi.ee; 
filter:="(&(osgi.ee=JavaSE)(version=1.8))"]
```

This is the change I've applied in jclouds-karaf to require Java 8 and Guva 
21.0 too:

```diff
diff --git a/pom.xml b/pom.xml
index 768cd0a..89203c2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -102,6 +102,7 @@ limitations under the License.
 **/.checkstyle
 **/target/**
 .repository/**
+.java-version
 
 
 **/src/main/resources/**/*.txt
@@ -149,8 +150,8 @@ limitations under the License.
 maven-compiler-plugin
 ${maven-compiler-plugin.version}
 
-  1.6
-  1.6
+  ${jdk.version}
+  ${jdk.version}
 
   
   
@@ -183,14 +184,14 @@ limitations under the License.
   
 
   
-1.7
+1.8
 1.0_5
 1.51
 3.0
 1.8.0
 2.4.4
 2.5
-18.0
+21.0
 10.0
 3.0
 4.3.4
```

it looks like ti cannot resolve the Guava 21 bundle but I can't see what is 
missing in the configuration.
@demobox @neykov could you have a look?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1197#issuecomment-382319204

Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2018-04-16 Thread Ignasi Barrera
LGTM. Before merging, though I'd like to make some tests with jclouds-karaf and 
see that it and the jclouds-cli projects still work as expected with Java 8, or 
at least come with a concrete upgrade plan for them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1197#issuecomment-381547602