Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
[jclouds-pull-requests-java-6 #116](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/116/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57817439
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
[jclouds-pull-requests-java-6 #117](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/117/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57817531
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
[jclouds-pull-requests #1205](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1205/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57824864
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
[jclouds-pull-requests #1206](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1206/) ABORTED --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57829889
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
import org.jclouds.s3.reference.S3Headers; -import com.google.common.collect.ImmutableSet; -import com.google.common.reflect.TypeToken; -import com.google.inject.Module; +import static org.jclouds.Constants.PROPERTY_RELAX_HOSTNAME; +import static org.jclouds.aws.reference.AWSConstants.PROPERTY_AUTH_TAG; +import static org.jclouds.aws.reference.AWSConstants.PROPERTY_HEADER_TAG; +import static org.jclouds.blobstore.reference.BlobStoreConstants.PROPERTY_BLOBSTORE_DIRECTORY_SUFFIX; +import static org.jclouds.blobstore.reference.BlobStoreConstants.PROPERTY_USER_METADATA_PREFIX; +import static org.jclouds.reflect.Reflection2.typeToken; +import static org.jclouds.s3.reference.S3Constants.PROPERTY_S3_SERVICE_PATH; +import static org.jclouds.s3.reference.S3Constants.PROPERTY_S3_VIRTUAL_HOST_BUCKETS; Static imports at the top of the file please. :) Here is the standard format for ordering imports: - `static` - `java` - `javax` - `org` - `com` --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538/files#r18408829
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
- ListenableFutureVoid enableBucketLogging( -@Bucket @EndpointParam(parser = AssignCorrectHostnameForBucket.class) @BinderParam(BindAsHostPrefixIfConfigured.class) @ParamValidators(BucketNameValidator.class) String bucketName, -@BinderParam(BindBucketLoggingToXmlPayload.class) BucketLogging logging); - - /** -* @see S3Client#putBucketLogging -*/ - @Named(PutBucketLogging) - @PUT - @Path(/) - @QueryParams(keys = logging) - @Produces(MediaType.TEXT_XML) - ListenableFutureVoid disableBucketLogging( -@Bucket @EndpointParam(parser = AssignCorrectHostnameForBucket.class) @BinderParam(BindNoBucketLoggingToXmlPayload.class) @ParamValidators(BucketNameValidator.class) String bucketName); - -} Its so rewarding when these can be removed! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538/files#r18408871
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
import org.jclouds.s3.reference.S3Headers; -import com.google.common.collect.ImmutableSet; -import com.google.common.reflect.TypeToken; -import com.google.inject.Module; +import static org.jclouds.Constants.PROPERTY_RELAX_HOSTNAME; +import static org.jclouds.aws.reference.AWSConstants.PROPERTY_AUTH_TAG; +import static org.jclouds.aws.reference.AWSConstants.PROPERTY_HEADER_TAG; +import static org.jclouds.blobstore.reference.BlobStoreConstants.PROPERTY_BLOBSTORE_DIRECTORY_SUFFIX; +import static org.jclouds.blobstore.reference.BlobStoreConstants.PROPERTY_USER_METADATA_PREFIX; +import static org.jclouds.reflect.Reflection2.typeToken; +import static org.jclouds.s3.reference.S3Constants.PROPERTY_S3_SERVICE_PATH; +import static org.jclouds.s3.reference.S3Constants.PROPERTY_S3_VIRTUAL_HOST_BUCKETS; sure --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538/files#r18408897
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
/**
* Provides access to S3 via their REST API.
- * p/
- * All commands return a Future of the result from S3. Any exceptions
incurred during
- * processing will be backend in an {@link ExecutionException} as documented
in
- * {@link Future#get()}.
- *
+ *
* @see a
href=http://docs.amazonwebservices.com/AmazonS3/2006-03-01/RESTAPI.html; /
External doc links should be removed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/538/files#r18408896
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
/**
* Retrieves the {@link
org.jclouds.s3.domain.internal.BucketListObjectMetadata metadata} of
-* the object associated with the key or
-* {@link
org.jclouds.s3.domain.internal.BucketListObjectMetadata#NOT_FOUND} if not
+* the object associated with the key or null if not
* available.
Pull available up to previous line?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/538/files#r18408946
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
/**
* Retrieves the {@link
org.jclouds.s3.domain.internal.BucketListObjectMetadata metadata} of
-* the object associated with the key or
-* {@link
org.jclouds.s3.domain.internal.BucketListObjectMetadata#NOT_FOUND} if not
+* the object associated with the key or null if not
* available.
sure.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/538/files#r18409040
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
/**
* Provides access to S3 via their REST API.
- * p/
- * All commands return a Future of the result from S3. Any exceptions
incurred during
- * processing will be backend in an {@link ExecutionException} as documented
in
- * {@link Future#get()}.
- *
+ *
* @see a
href=http://docs.amazonwebservices.com/AmazonS3/2006-03-01/RESTAPI.html; /
will do.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/538/files#r18409026
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
*/ - S3Object getObject(String bucketName, String key, GetOptions... options); + @Named(GetObject) [minor] FWIW `@Named(apiName:methodName)` has been an effective naming convention. In this case: `@Named(s3:getObject)` --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538/files#r18409383
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
@@ -26,7 +26,4 @@ @Override S3BlobStore getBlobStore(); - - @Override - S3AsyncBlobStore getAsyncBlobStore(); Nice! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538/files#r18411399
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
public abstract class BaseS3ClientExpectTest extends
BaseRestClientExpectTestS3Client {
protected static final String CONSTANT_DATE = 2009-11-08T15:54:08.897Z;
- @ConfiguresRestClient
- private static final class TestS3RestClientModule extends
S3RestClientModuleS3Client, S3AsyncClient {
+ @ConfiguresRestClient
I take it that this will go the way of the dodo once all of the `*Client`
classes are converted to `*Api`? Meaning, we will primarily use
`@ConfiguresHttpApi` moving forward.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/538/files#r18412131
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
}
private void addGrantsToACL(AccessControlList acl) {
String ownerId = acl.getOwner().getId();
acl.addPermission(GroupGranteeURI.ALL_USERS, Permission.READ);
- acl.addPermission(new
EmailAddressGrantee(StubS3AsyncClient.TEST_ACL_EMAIL), Permission.READ_ACP);
+ acl.addPermission(new EmailAddressGrantee(TEST_ACL_EMAIL),
Permission.READ_ACP);
static import `Permission.READ_ACP` to follow style of `TEST_ACL_EMAIL`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/538/files#r18412282
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
[jclouds » jclouds #1686](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1686/) ABORTED [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57837219
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
+import org.jclouds.blobstore.domain.StorageMetadata;
+import org.jclouds.blobstore.options.CreateContainerOptions;
+import org.jclouds.blobstore.options.GetOptions;
+import org.jclouds.blobstore.options.ListContainerOptions;
+import org.jclouds.blobstore.options.PutOptions;
+import org.jclouds.domain.Location;
+
+import com.google.common.collect.ForwardingObject;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+
+/**
+ * Adapter that allows you to reuse an existing {@link BlobStore} to
implement
+ * the deprecated {@link AsyncBlobStore} interface.
+ *
+ * @deprecated will be removed in jclouds 1.7, as async interfaces are no
longer
In an effort to be mindful of deprecation warnings, this should be updated to
`2.0`.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/538/files#r18412485
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
+import org.jclouds.blobstore.options.PutOptions;
+import org.jclouds.domain.Location;
+
+import com.google.common.collect.ForwardingObject;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+
+/**
+ * Adapter that allows you to reuse an existing {@link BlobStore} to
implement
+ * the deprecated {@link AsyncBlobStore} interface.
+ *
+ * @deprecated will be removed in jclouds 1.7, as async interfaces are no
longer
+ * supported. Please use {@link BlobStore}
+ */
+@Deprecated
+public class SubmissionAsyncBlobStore extends ForwardingObject implements
AsyncBlobStore {
I argue that we should move this class into the `blobstore` project so that
`openstack-swift` can use it as well. WDYT?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/538/files#r18412680
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
+1 Looks good based on the other conversions I have done. Just a few minor comments, thanks @adriancole ! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57838532
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
[jclouds » jclouds #1687](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1687/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57845969
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
addressed all feedback and re-ran live tests. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57851980
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
[jclouds-pull-requests-java-6 #118](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/118/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57852319
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
[jclouds » jclouds #1688](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1688/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57861528
Re: [jclouds] JCLOUDS-150 add SubmissionAsyncBlobStore; unasync s3 and aws-s3 (#538)
[jclouds-pull-requests #1207](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1207/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/538#issuecomment-57863034
