Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Thomas Manville]

@zack-shoylev If I understand you correctly, you're saying we should remove 
line 72, right?
@demobox I'll make that expect more specific.
@andrewgaul I'll add some more tests.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36561072

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Andrew Phillips]

 I'll make that expect more specific.

Thanks, @tdmanv!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36561864

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[CloudBees pull request builder plugin]

[jclouds-java-7-pull-requests 
#1100](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1100/) 
FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36572064

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[BuildHive]

[jclouds » jclouds 
#878](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/878/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36575735

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[CloudBees pull request builder plugin]

[jclouds-pull-requests 
#630](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/630/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36576758

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[CloudBees pull request builder plugin]

[jclouds-pull-requests 
#633](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/633/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36578840

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Andrew Gaul]

I ran the Swift unit tests and cloudfiles-us live tests locally, squashed 
commit, and pushed to master and 1.7.x.  Thank you for your contribution 
@tdmanv!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36580061

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Andrew Gaul]

Closed #306.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[BuildHive]

[jclouds » jclouds 
#880](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/880/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36581888

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[CloudBees pull request builder plugin]

[jclouds-java-7-pull-requests 
#1103](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1103/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36582153

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Andrew Phillips]

 @@ -54,13 +56,14 @@ public void test401ShouldRetry() {
expectLastCall();
  

 expect(response.getPayload()).andReturn(Payloads.newStringPayload(token 
 expired, please renew)).anyTimes();
 +  expect(command.incrementFailureCount()).andReturn(0).anyTimes();

This does not seem realistic? `incrementFailureCount()` returns the new failure 
count, so should not return 0, and certainly not `anyTimes()`..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306/files#r10195225

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Andrew Phillips]

Do we need a test to actually see if the command is correctly retried on a 408?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36431159

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Andrew Gaul]

@jdaggett I have credentials for several Swift providers and none of them seem 
to use the openstack-keystone/Keystone 2.0 functionality.  If someone finds 
such a provider we can add this functionality in a subsequent commit, otherwise 
let's just patch known issues and move forward with the newer openstack-labs 
provider.

@tdmanv @demobox I do not understand the modifications to 
```RetryOnRenewTest.test401ShouldRetry```.  Do we need something like 
```RetryOnRenewTest.test408ShouldRetry```?  Then we can merge this commit.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36444525

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Zack Shoylev]

@andrewgaul I might be wrong but the fail count for authentication retries uses 
retryCountMap; the count increment here should not affect it. 
Also the (sadly complex) logic for authentication retries seems to be missing 
in v1_1 (the retry handler affected in this PR)?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36413983

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Andrew Gaul]

:+1: tested commit locally.

@zack-shoylev could you take a look at this since it increases the failure 
counter you added in 578a77d6313ce0945f8d29e82103e09787622c58?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36281263

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Jeremy Daggett]

@andrewgaul Does this also need to be adapted to the openstack-keystone 
[RetryOnRenew](https://github.com/jclouds/jclouds/blob/master/apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/handlers/RetryOnRenew.java)
 ?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36282247

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[BuildHive]

[jclouds » jclouds 
#872](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/872/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36284833

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[CloudBees pull request builder plugin]

[jclouds-java-7-pull-requests 
#1095](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1095/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36285936

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[CloudBees pull request builder plugin]

[jclouds-pull-requests 
#625](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/625/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36286123

Re: [jclouds] JCLOUDS-342: Retry on HTTP 408 for swift (#306)

[Andrew Gaul]

@jaggett Sorry I misunderstood, thought you were referring to the new labs 
openstack-swift provider.  I guess we could make similar changes to 
openstack-keystone.  Do any of the public providers use the newer Keystone 
implementation?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/306#issuecomment-36288408