Re: [jclouds] fix usermetadata check on OS X (#648)

2015-01-20 Thread Andrew Gaul 
Closed #648.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#event-222046415

Re: [jclouds] fix usermetadata check on OS X (#648)

2015-01-20 Thread Jeremy Daggett 
@kahing Thanks again! Can you please address the comment from @andrewgaul 
above? Once that looks good, we should get it merged.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70753228

Re: [jclouds] fix usermetadata check on OS X (#648)

2015-01-20 Thread Jeremy Daggett 
@kahing Well, that was strange... I had a git remote problem with your repo and 
now that it is sorted out, `master` is happy again on OS X! +1

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70752052

Re: [jclouds] fix usermetadata check on OS X (#648)

2015-01-20 Thread Ka-Hing Cheung 
@jdaggett I just did a `mvn clean install` with xattrs disabled and 
TestUtils.isMacOSX() return true, and everything passed. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70746966

Re: [jclouds] fix usermetadata check on OS X (#648)

2015-01-20 Thread Jeremy Daggett 
@kahing I just run `mvn clean install` :smile: 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70743082

Re: [jclouds] fix usermetadata check on OS X (#648)

2015-01-20 Thread Ka-Hing Cheung 
@jdaggett how did you run the test? I don't have OS X but locally I verified 
with disabling xattrs and faking TestUtils.isMacOSX() to always return true.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70741593

Re: [jclouds] fix usermetadata check on OS X (#648)

2015-01-20 Thread Jeremy Daggett 
@kahing Hi! I cherry-picked this commit, built again, and have the following 2 
test failures in the `BaseBlobIntegrationTest.testPut()` method:
```
Failed tests:
  
FilesystemBlobIntegrationTest>BaseBlobIntegrationTest.testPutByteSource:531->BaseBlobIntegrationTest.testPut:584
Expecting:
 <{}>
to be equal to:
 <{"key1"="value1", "key2"="value2"}>
but was not.
  
FilesystemBlobIntegrationTest>BaseBlobIntegrationTest.testPutInputStream:539->BaseBlobIntegrationTest.testPut:584
Expecting:
 <{}>
to be equal to:
 <{"key1"="value1", "key2"="value2"}>
but was not.
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70729396

Re: [jclouds] fix usermetadata check on OS X (#648)

2015-01-20 Thread Andrew Gaul 
> @@ -555,6 +555,14 @@ public void testPutMultipartInputStream() throws 
> Exception {
>testPut(payload, new ByteSourcePayload(byteSource), length, new 
> PutOptions().multipart(true));
> }
>  
> +   /* Java on OS X does not support extended attributes, which the 
> filesystem backend
> +* uses to implement user metadata */
> +   private void checkUserMetadata(Blob blob, Map 
> userMetadata1, Map userMetadata2) {
> +  if ("filesystem".equals(blob.getMetadata().getProviderId()) && 
> !TestUtils.isMacOSX()) {

Can you make this method protected and override it in 
`FilesystemBlobIntegrationTest`?  We follow this pattern for other attributes 
like system metadata.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648/files#r23253661

Re: [jclouds] fix usermetadata check on OS X (#648)

2015-01-20 Thread Jeremy Daggett 
@kahing I will pull the changes over later this morning and let you know, 
thanks! :+1: 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70680769