Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread CloudBees pull request builder plugin 
[jclouds-site-pull-requests 
#214](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/214/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36940746

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread jclouds-commentator 
  Go to 
http://8b52767bd942c3450ef4-adcd3eff2d683d2a83bb6954fe53c79b.r35.cf1.rackcdn.com/
 to review your changes.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36940967

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Ignasi Barrera 
+1!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36941377

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Andrew Phillips 
 @@ -1,5 +1,7 @@
  #!/bin/sh
  
 +set -o errexit

[minor] Shorten to [`set -e`](http://unixhelp.ed.ac.uk/CGI/man-cgi?sh)?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63/files#r10369173

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Andrew Phillips 
One minor comment, but otherwise +1 - looks good to me. Thanks, @andrewgaul!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36956505

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Andrew Gaul 
 @@ -1,5 +1,7 @@
  #!/bin/sh
  
 +set -o errexit

Strongly prefer verbose shell options!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63/files#r10370516

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Andrew Gaul 
Pushed to master.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36959754

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Andrew Gaul 
Closed #63.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63

Re: [jclouds-site] Exit on failed commands (#63)

2014-03-06 Thread Everett Toews 
 @@ -1,5 +1,7 @@
  #!/bin/sh
  
 +set -o errexit

+1 to verbose shell options

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63/files#r10371334