[GitHub] libcloud pull request: Use libcloud unittest

2016-01-08 Thread relaxdiego
GitHub user relaxdiego opened a pull request:

https://github.com/apache/libcloud/pull/677

Use libcloud unittest

This changeset includes two patches:

1. Modify Dimension Data tests again to use `libcloud.test.unittest` which 
contains logic for deciding the appropriate package version that works across 
Python versions. This allows us to use assertRaises as a context manager which 
makes the test cleaner.

2. Add an entry in `docs/development.rst` to recommend using 
`libcloud.test.unittest`. This is based on a suggestion from @Kami in PR #674.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/relaxdiego/libcloud use_libcloud_unittest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/libcloud/pull/677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #677


commit 3940caf6b2a086b2232e7fa39911c7f6f20eeb93
Author: Mark S. Maglana 
Date:   2016-01-07T17:36:53Z

Multiple improvements to the Dimension Data tests

- Use libcloud.test.unittest instead of the system unittest to ensure
  that newer unittest features are available in older version of Python

- Update all other Dimension Data test cases to use self.assertRaises
  instead of try...except blocks so that, should a regression happen,
  the tests will provide a more helpful message than 'False is not True'

commit 3f020a406d0d65b38dc649d1ecfb4a2e0c443314
Author: Mark S. Maglana 
Date:   2016-01-08T00:50:44Z

Recommend libcloud.test.unittest as the unit testing package




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] libcloud pull request: Use libcloud unittest

2016-01-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/libcloud/pull/677


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---