[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger
ruhulmus commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046521980 > @ruhulmus If this is an example for people, showing them how to use Async logging, then what would be the best place so that people can easily find it? Maybe in the docs? What does it add that the existing docs are missing? (And would it be an idea to improve the existing docs, if that is the case.) Ok Sure, Then I will move into the right sections and can make a details doc. so anyone can better understand. The main reason to share it within the community, it's an important use case for log4j2, especially in java based projects. Thanks for your feedback :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LOG4J2-3409) workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng
[ https://issues.apache.org/jira/browse/LOG4J2-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495312#comment-17495312 ] Ralph Goers commented on LOG4J2-3409: - Turns out Matt is right. 1.19.13 is the last version of jackson-mapper-asl. Flume 1.10.0 won't be using that. So there is no way to fix it in log4j without a new Flume release. > workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng > -- > > Key: LOG4J2-3409 > URL: https://issues.apache.org/jira/browse/LOG4J2-3409 > Project: Log4j 2 > Issue Type: Bug > Components: Flume Appender >Affects Versions: 2.17.1 > Environment: java 11 >Reporter: alexander kravchik >Priority: Major > > Dear colleagues, > we are using log4j2 with flume-ng appender. > The below vulnerabilities are found in the dependent > jackson-mapper-asl-1.9.13.jar : > cve-2019-10202 > cve-2019-10172 > etc... > Please advise if this will be fixed and planned ETA in case it is already > fixed > Thanks , > Sasha -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (LOG4J2-3304) SpringEnvironmentHolder getEnvironment always return null
[ https://issues.apache.org/jira/browse/LOG4J2-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-3304. - Fix Version/s: 2.17.2 Resolution: Fixed The PR has been merged. Thanks! Please verify and close this. > SpringEnvironmentHolder getEnvironment always return null > - > > Key: LOG4J2-3304 > URL: https://issues.apache.org/jira/browse/LOG4J2-3304 > Project: Log4j 2 > Issue Type: Bug > Components: API, Spring >Affects Versions: 2.17.1 >Reporter: francis >Priority: Major > Fix For: 2.17.2 > > > I am using SpringLookup and SpringProfileArbiter for conditional > configuration, but it doesn't work. I debugged into SpringEnvironmentHolder > and found that the getEnvironment method always returns null. Then I found > the root cause is that when the factoryClassName is present and load > successfully, the LogManagerStatus is not set in the static block of > LogManager. It could be a bug, please take a look -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (LOG4J2-3304) SpringEnvironmentHolder getEnvironment always return null
[ https://issues.apache.org/jira/browse/LOG4J2-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495297#comment-17495297 ] ASF subversion and git services commented on LOG4J2-3304: - Commit af0d269b13f777992db00ef1829b827900a4e8d6 in logging-log4j2's branch refs/heads/master from Ralph Goers [ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=af0d269 ] LOG4J2-3304 - Mark LogManager as initialized when a LoggerFactory is specified > SpringEnvironmentHolder getEnvironment always return null > - > > Key: LOG4J2-3304 > URL: https://issues.apache.org/jira/browse/LOG4J2-3304 > Project: Log4j 2 > Issue Type: Bug > Components: API, Spring >Affects Versions: 2.17.1 >Reporter: francis >Priority: Major > > I am using SpringLookup and SpringProfileArbiter for conditional > configuration, but it doesn't work. I debugged into SpringEnvironmentHolder > and found that the getEnvironment method always returns null. Then I found > the root cause is that when the factoryClassName is present and load > successfully, the LogManagerStatus is not set in the static block of > LogManager. It could be a bug, please take a look -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (LOG4J2-3304) SpringEnvironmentHolder getEnvironment always return null
[ https://issues.apache.org/jira/browse/LOG4J2-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495298#comment-17495298 ] ASF subversion and git services commented on LOG4J2-3304: - Commit 9cc2967a4f900862d6999bf9eb971af9e056 in logging-log4j2's branch refs/heads/master from Ralph Goers [ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=9cc2967 ] LOG4J2-3304 - Mark LogManager as initialized when a LoggerFactory is specified > SpringEnvironmentHolder getEnvironment always return null > - > > Key: LOG4J2-3304 > URL: https://issues.apache.org/jira/browse/LOG4J2-3304 > Project: Log4j 2 > Issue Type: Bug > Components: API, Spring >Affects Versions: 2.17.1 >Reporter: francis >Priority: Major > > I am using SpringLookup and SpringProfileArbiter for conditional > configuration, but it doesn't work. I debugged into SpringEnvironmentHolder > and found that the getEnvironment method always returns null. Then I found > the root cause is that when the factoryClassName is present and load > successfully, the LogManagerStatus is not set in the static block of > LogManager. It could be a bug, please take a look -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (LOG4J2-3304) SpringEnvironmentHolder getEnvironment always return null
[ https://issues.apache.org/jira/browse/LOG4J2-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495266#comment-17495266 ] ASF subversion and git services commented on LOG4J2-3304: - Commit ef178a272235615f161c4e75faa4f3d947547681 in logging-log4j2's branch refs/heads/dependabot/maven/org.apache.felix-maven-bundle-plugin-5.1.4 from Ralph Goers [ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=ef178a2 ] LOG4J2-3304 - Create test that verifies this fix > SpringEnvironmentHolder getEnvironment always return null > - > > Key: LOG4J2-3304 > URL: https://issues.apache.org/jira/browse/LOG4J2-3304 > Project: Log4j 2 > Issue Type: Bug > Components: API, Spring >Affects Versions: 2.17.1 >Reporter: francis >Priority: Major > > I am using SpringLookup and SpringProfileArbiter for conditional > configuration, but it doesn't work. I debugged into SpringEnvironmentHolder > and found that the getEnvironment method always returns null. Then I found > the root cause is that when the factoryClassName is present and load > successfully, the LogManagerStatus is not set in the static block of > LogManager. It could be a bug, please take a look -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (LOG4J2-3304) SpringEnvironmentHolder getEnvironment always return null
[ https://issues.apache.org/jira/browse/LOG4J2-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495265#comment-17495265 ] ASF subversion and git services commented on LOG4J2-3304: - Commit 8e89ecd4a94e2f600423564c8381f8a0f9b12fe6 in logging-log4j2's branch refs/heads/dependabot/maven/org.apache.felix-maven-bundle-plugin-5.1.4 from Francis [ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=8e89ecd ] LOG4J2-3304 - Fix issue that the initialize status of LogManager is not set when factoryClassName is present and instantiate successfully (#676) > SpringEnvironmentHolder getEnvironment always return null > - > > Key: LOG4J2-3304 > URL: https://issues.apache.org/jira/browse/LOG4J2-3304 > Project: Log4j 2 > Issue Type: Bug > Components: API, Spring >Affects Versions: 2.17.1 >Reporter: francis >Priority: Major > > I am using SpringLookup and SpringProfileArbiter for conditional > configuration, but it doesn't work. I debugged into SpringEnvironmentHolder > and found that the getEnvironment method always returns null. Then I found > the root cause is that when the factoryClassName is present and load > successfully, the LogManagerStatus is not set in the static block of > LogManager. It could be a bug, please take a look -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (LOG4J2-3304) SpringEnvironmentHolder getEnvironment always return null
[ https://issues.apache.org/jira/browse/LOG4J2-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495267#comment-17495267 ] ASF subversion and git services commented on LOG4J2-3304: - Commit d6c8ab0863c551cdf0f8a5b1966ab45e3cddf572 in logging-log4j2's branch refs/heads/dependabot/maven/org.apache.felix-maven-bundle-plugin-5.1.4 from Ralph Goers [ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=d6c8ab0 ] LOG4J2-3304 - Mark LogManager as initialized when a LoggerFactory is specified > SpringEnvironmentHolder getEnvironment always return null > - > > Key: LOG4J2-3304 > URL: https://issues.apache.org/jira/browse/LOG4J2-3304 > Project: Log4j 2 > Issue Type: Bug > Components: API, Spring >Affects Versions: 2.17.1 >Reporter: francis >Priority: Major > > I am using SpringLookup and SpringProfileArbiter for conditional > configuration, but it doesn't work. I debugged into SpringEnvironmentHolder > and found that the getEnvironment method always returns null. Then I found > the root cause is that when the factoryClassName is present and load > successfully, the LogManagerStatus is not set in the static block of > LogManager. It could be a bug, please take a look -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [logging-log4j2] garydgregory commented on pull request #754: Bump maven-bundle-plugin from 3.5.0 to 5.1.4
garydgregory commented on pull request #754: URL: https://github.com/apache/logging-log4j2/pull/754#issuecomment-1046366117 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LOG4J2-3304) SpringEnvironmentHolder getEnvironment always return null
[ https://issues.apache.org/jira/browse/LOG4J2-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495247#comment-17495247 ] ASF subversion and git services commented on LOG4J2-3304: - Commit d6c8ab0863c551cdf0f8a5b1966ab45e3cddf572 in logging-log4j2's branch refs/heads/release-2.x from Ralph Goers [ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=d6c8ab0 ] LOG4J2-3304 - Mark LogManager as initialized when a LoggerFactory is specified > SpringEnvironmentHolder getEnvironment always return null > - > > Key: LOG4J2-3304 > URL: https://issues.apache.org/jira/browse/LOG4J2-3304 > Project: Log4j 2 > Issue Type: Bug > Components: API, Spring >Affects Versions: 2.17.1 >Reporter: francis >Priority: Major > > I am using SpringLookup and SpringProfileArbiter for conditional > configuration, but it doesn't work. I debugged into SpringEnvironmentHolder > and found that the getEnvironment method always returns null. Then I found > the root cause is that when the factoryClassName is present and load > successfully, the LogManagerStatus is not set in the static block of > LogManager. It could be a bug, please take a look -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (LOG4J2-3304) SpringEnvironmentHolder getEnvironment always return null
[ https://issues.apache.org/jira/browse/LOG4J2-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495246#comment-17495246 ] ASF subversion and git services commented on LOG4J2-3304: - Commit ef178a272235615f161c4e75faa4f3d947547681 in logging-log4j2's branch refs/heads/release-2.x from Ralph Goers [ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=ef178a2 ] LOG4J2-3304 - Create test that verifies this fix > SpringEnvironmentHolder getEnvironment always return null > - > > Key: LOG4J2-3304 > URL: https://issues.apache.org/jira/browse/LOG4J2-3304 > Project: Log4j 2 > Issue Type: Bug > Components: API, Spring >Affects Versions: 2.17.1 >Reporter: francis >Priority: Major > > I am using SpringLookup and SpringProfileArbiter for conditional > configuration, but it doesn't work. I debugged into SpringEnvironmentHolder > and found that the getEnvironment method always returns null. Then I found > the root cause is that when the factoryClassName is present and load > successfully, the LogManagerStatus is not set in the static block of > LogManager. It could be a bug, please take a look -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (LOG4J2-3304) SpringEnvironmentHolder getEnvironment always return null
[ https://issues.apache.org/jira/browse/LOG4J2-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495244#comment-17495244 ] ASF subversion and git services commented on LOG4J2-3304: - Commit 8e89ecd4a94e2f600423564c8381f8a0f9b12fe6 in logging-log4j2's branch refs/heads/release-2.x from Francis [ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=8e89ecd ] LOG4J2-3304 - Fix issue that the initialize status of LogManager is not set when factoryClassName is present and instantiate successfully (#676) > SpringEnvironmentHolder getEnvironment always return null > - > > Key: LOG4J2-3304 > URL: https://issues.apache.org/jira/browse/LOG4J2-3304 > Project: Log4j 2 > Issue Type: Bug > Components: API, Spring >Affects Versions: 2.17.1 >Reporter: francis >Priority: Major > > I am using SpringLookup and SpringProfileArbiter for conditional > configuration, but it doesn't work. I debugged into SpringEnvironmentHolder > and found that the getEnvironment method always returns null. Then I found > the root cause is that when the factoryClassName is present and load > successfully, the LogManagerStatus is not set in the static block of > LogManager. It could be a bug, please take a look -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [logging-log4j2] rgoers merged pull request #676: LOG4J2-3304 - Fix issue that the initialize status of LogManager is not set when factoryClassName is present and instantiate successfully
rgoers merged pull request #676: URL: https://github.com/apache/logging-log4j2/pull/676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] remkop commented on pull request #763: Added java logging with Asynchronous logger
remkop commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046326417 @ruhulmus If this is an example for people, showing them how to use Async logging, then what would be the best place so that people can easily find it? Maybe in the docs? What does it add that the existing docs are missing? (And would it be an idea to improve the existing docs, if that is the case.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LOG4J2-3409) workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng
[ https://issues.apache.org/jira/browse/LOG4J2-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495239#comment-17495239 ] Ralph Goers commented on LOG4J2-3409: - It should not require a new release of Flume. We control the dependencies so we can upgrade it. I will take care of that. That said, I am also working on getting a Flume release out and will get back to that once I get Log4j 2.17.2 released. > workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng > -- > > Key: LOG4J2-3409 > URL: https://issues.apache.org/jira/browse/LOG4J2-3409 > Project: Log4j 2 > Issue Type: Bug > Components: Flume Appender >Affects Versions: 2.17.1 > Environment: java 11 >Reporter: alexander kravchik >Priority: Major > > Dear colleagues, > we are using log4j2 with flume-ng appender. > The below vulnerabilities are found in the dependent > jackson-mapper-asl-1.9.13.jar : > cve-2019-10202 > cve-2019-10172 > etc... > Please advise if this will be fixed and planned ETA in case it is already > fixed > Thanks , > Sasha -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [logging-log4j2] dependabot[bot] closed pull request #694: Bump kubernetes-client from 4.6.1 to 5.11.2
dependabot[bot] closed pull request #694: URL: https://github.com/apache/logging-log4j2/pull/694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #694: Bump kubernetes-client from 4.6.1 to 5.11.2
dependabot[bot] commented on pull request #694: URL: https://github.com/apache/logging-log4j2/pull/694#issuecomment-1046323253 Superseded by #766. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #766: Bump kubernetes-client from 4.6.1 to 5.12.1
dependabot[bot] opened a new pull request #766: URL: https://github.com/apache/logging-log4j2/pull/766 Bumps [kubernetes-client](https://github.com/fabric8io/kubernetes-client) from 4.6.1 to 5.12.1. Release notes Sourced from https://github.com/fabric8io/kubernetes-client/releases";>kubernetes-client's releases. 5.12.1 (2022-02-04) Bugs Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3786";>#3786: Deserialize WatchEvents using the specific object type Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3776";>#3776: VerticalPodAutoscaler cannot load yaml with "controlledResources" Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3796";>#3796: Limit usage of YAML Serializer Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3772";>#3772: edit() should not be allowed as a NonNamespaceOperation Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3477";>#3477: Handle exit code status messages with pod uploads 5.12.0 (2022-01-24) Bugs Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3683";>#3683: Handle JsonNode fields by adding x-kubernetes-preserve-unknown-fields Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3697";>#3697: addresses response that aren't closed by interceptors that issue new requests Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3255";>#3255: adding basic crud mock resourceVersion support - the field will be set and updated, but not utilized by list/watch queries Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3568";>#3568: Pod file upload fails if the path is / Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3588";>#3588: openshift-server-mock is not listed in dependencyManagement in main pom Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3648";>#3648: Serialization.unmarshal fails to deserialize YAML with single document in presence of document delimiter(---) Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3679";>#3679: output additionalProperties field with correct value type for map-like fields (CRD Generator) Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3671";>#3671: HTTP(s) Proxy port is not defaulted or validated Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3712";>#3712: properly return the full resource name for resources with empty group Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3761";>#3761: Extension Jar packages don't contain the META-INF/jandex.idx index file Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3763";>#3763: A Java Long should generate a field of type integer in the CRD Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3769";>#3769: Fix for ClassCastException from SchemaFrom Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3756";>#3756 prevent modifications by standard operations to user objects Improvements Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3674";>#3674: allows the connect and websocket timeouts to apply to watches instead of a hardcoded timeout Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3651";>#3651: Introduce SchemaFrom annotation as escape hatch (CRD Generator) Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3587";>#3587: adding inform support for limit/batch fetching Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3734";>#3734: extract static finalizer validation method Dependency Upgrade Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3637";>#3637: Update Fabric8 Kubernetes Model to v1.23.0 Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3670";>#3670: Point CamelK Extension model to latest released version v1.7.0 Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3725";>#3725: Bump sundrio to v0.50.3 New Features Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3721";>#3721: Add support for uploading file via InputStream Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3234";>#3234: Allow specifying specific localhost while port-forwarding Fix https://github-redirect.dependabot.com/fabric8io/kubernetes-client/issues/3506";>#3506: Add support for Open Cluster Management extension 5.11.2 (2022-01-05) Bugs Fix https://github-redirect.dependabot.c
[GitHub] [logging-log4j2] garydgregory commented on pull request #694: Bump kubernetes-client from 4.6.1 to 5.11.2
garydgregory commented on pull request #694: URL: https://github.com/apache/logging-log4j2/pull/694#issuecomment-1046321832 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #750: Bump liquibase-core from 3.5.5 to 3.10.3
garydgregory commented on pull request #750: URL: https://github.com/apache/logging-log4j2/pull/750#issuecomment-1046321673 Looks like Liquibase broke binary compatibility, lovely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] garydgregory merged pull request #765: Bump json-unit from 2.28.0 to 2.32.0
garydgregory merged pull request #765: URL: https://github.com/apache/logging-log4j2/pull/765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on a change in pull request #763: Added java logging with Asynchronous logger
ruhulmus commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810682543
##
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
++ Updated the package and Class name.
And the configuration of Async logging is done here:
[log4j-java-maven/src/main/resources/log4j2-async.xml](https://github.com/apache/logging-log4j2/pull/763/files/b7adc73375a7c886f90d9ab87f8904270d878bf0#diff-5290387af67800f016c88f9f5db1faa8d37d91ad09bb44019b0506c711ce1ad5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on a change in pull request #763: Added java logging with Asynchronous logger
ruhulmus commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810682543
##
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
++ Updated the package and Class name.
And the configuration of Async logging is done here:
[log4j-java-maven/src/main/resources/log4j2-async.xml](https://github.com/apache/logging-log4j2/pull/763/files/b7adc73375a7c886f90d9ab87f8904270d878bf0#diff-ee17432c0d86feb0074d792a5ff699f2259f58ee17bc2fb7752e8dc30efc8c58)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on a change in pull request #763: Added java logging with Asynchronous logger
ruhulmus commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810682543
##
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
++ Updated the package and Class name.
And the configuration of Async logging is done here :
log4j-java-maven/src/main/resources/log4j2-async.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on a change in pull request #763: Added java logging with Asynchronous logger
ruhulmus commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810682543
##
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
++ Updated the package and Class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (LOG4J2-3393) JSON template layout performance regression
[
https://issues.apache.org/jira/browse/LOG4J2-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495233#comment-17495233
]
ASF subversion and git services commented on LOG4J2-3393:
-
Commit 37edca9583b0630a0d26dc287efb60f08fa2710b in logging-log4j2's branch
refs/heads/LOG4J2-3393 from Volkan Yazici
[ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=37edca9 ]
LOG4J2-3393 Avoid StringBuilderEncoder thread-local allocation in
JsonTemplateLayout.
> JSON template layout performance regression
> ---
>
> Key: LOG4J2-3393
> URL: https://issues.apache.org/jira/browse/LOG4J2-3393
> Project: Log4j 2
> Issue Type: Improvement
> Components: JsonTemplateLayout
>Affects Versions: 2.17.1
>Reporter: Volkan Yazici
>Assignee: Volkan Yazici
>Priority: Major
>
> JTL performance is used to be on par with \{{log4j2-ecs-layout}}, though this
> is not the case anymore, there is a slight degradation. This story aims to
> investigate what is going on and fix it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (LOG4J2-3409) workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng
[ https://issues.apache.org/jira/browse/LOG4J2-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495232#comment-17495232 ] Matt Sicker commented on LOG4J2-3409: - I think this requires a new release of Flume first. See [https://issues.apache.org/jira/projects/FLUME] for their issue tracker. > workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng > -- > > Key: LOG4J2-3409 > URL: https://issues.apache.org/jira/browse/LOG4J2-3409 > Project: Log4j 2 > Issue Type: Bug > Components: Flume Appender >Affects Versions: 2.17.1 > Environment: java 11 >Reporter: alexander kravchik >Priority: Major > > Dear colleagues, > we are using log4j2 with flume-ng appender. > The below vulnerabilities are found in the dependent > jackson-mapper-asl-1.9.13.jar : > cve-2019-10202 > cve-2019-10172 > etc... > Please advise if this will be fixed and planned ETA in case it is already > fixed > Thanks , > Sasha -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [logging-log4j2] ruhulmus commented on a change in pull request #763: Added java logging with Asynchronous logger
ruhulmus commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810680609
##
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
OK, the package name is just an example name (I just make a demo name
for it ).
I have made 2 classes (Main and Error class)
Both classes are used for logging.
The Main class is responsible for Debug logging and the Error Class is
mainly used for error logging.
If you think it's confusing I can rename the package and class name for a
better understanding. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #764: Adds Log4j 1.x global threshold
ppkarwasz commented on a change in pull request #764:
URL: https://github.com/apache/logging-log4j2/pull/764#discussion_r810680613
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationParser.java
##
@@ -103,6 +107,18 @@
if (Boolean.parseBoolean(debugValue)) {
builder.setStatusLevel(Level.DEBUG);
}
+// if log4j.reset=true then reset hierarchy
+final String reset = getLog4jValue("reset");
+if (reset != null && OptionConverter.toBoolean(reset, false)) {
Review comment:
Looking at the Log4j 1.2 code, neither `Log4j1ConfigurationParser` nor
any `Configuration` class should check the _"log4j.reset"_ key. This should be
done in `PropertyConfigurator#configure` to decide whether to replace the old
configuration or to make a `CompositeConfiguration` out of them.
Looking at [this SO question](https://stackoverflow.com/q/71087714/11748454)
I have the impression that calling `PropertyConfigurator#configure` multiple
times without resetting the old config, was a common practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [logging-log4j2] dependabot[bot] closed pull request #747: Bump json-unit from 2.28.0 to 2.31.0
dependabot[bot] closed pull request #747: URL: https://github.com/apache/logging-log4j2/pull/747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] dependabot[bot] opened a new pull request #765: Bump json-unit from 2.28.0 to 2.32.0
dependabot[bot] opened a new pull request #765: URL: https://github.com/apache/logging-log4j2/pull/765 Bumps [json-unit](https://github.com/lukas-krecan/JsonUnit) from 2.28.0 to 2.32.0. Commits https://github.com/lukas-krecan/JsonUnit/commit/7642142bb34292ea1e87a731a0a481866184c5f0";>7642142 [maven-release-plugin] prepare release json-unit-parent-2.32.0 https://github.com/lukas-krecan/JsonUnit/commit/d9274fee8e88ccb01ff6e2f74f0a96817d625e6d";>d9274fe Deprecate usages of InstanceOfAssertFactory https://github.com/lukas-krecan/JsonUnit/commit/5f946bd7d19a5e694e462cbfcae41799f5e4bdff";>5f946bd https://github-redirect.dependabot.com/lukas-krecan/JsonUnit/issues/474";>#474 Fix JsonListAssert.elments https://github.com/lukas-krecan/JsonUnit/commit/80815bbaa29d87fa8ce4f3ae0198431c88c5d088";>80815bb Merge pull request https://github-redirect.dependabot.com/lukas-krecan/JsonUnit/issues/475";>#475 from lukas-krecan/dependabot/maven/org.apache.maven.p... https://github.com/lukas-krecan/JsonUnit/commit/3f74954e7be50f82462dd585c7f9264b896c69bc";>3f74954 Bump maven-compiler-plugin from 3.9.0 to 3.10.0 https://github.com/lukas-krecan/JsonUnit/commit/04bf942e8bed520b9c5877390b514c6312c7cd1f";>04bf942 Merge pull request https://github-redirect.dependabot.com/lukas-krecan/JsonUnit/issues/471";>#471 from lukas-krecan/dependabot/maven/slf4j.version-1.7.36 https://github.com/lukas-krecan/JsonUnit/commit/751d64072db57e44738fe7b701464ebe6b5a585c";>751d640 Merge pull request https://github-redirect.dependabot.com/lukas-krecan/JsonUnit/issues/472";>#472 from lukas-krecan/dependabot/maven/org.apache.maven.p... https://github.com/lukas-krecan/JsonUnit/commit/dc157df83de58fd1d3555eb3ea5f6c223bdb213b";>dc157df Merge pull request https://github-redirect.dependabot.com/lukas-krecan/JsonUnit/issues/473";>#473 from lukas-krecan/dependabot/maven/com.google.code.gs... https://github.com/lukas-krecan/JsonUnit/commit/de1c4178e17ad91d9fa2eb0bbc1081ab8afe685b";>de1c417 Bump gson from 2.8.9 to 2.9.0 https://github.com/lukas-krecan/JsonUnit/commit/1d01091cec55957adc51f733db0fdf920756ecbf";>1d01091 Bump maven-javadoc-plugin from 3.3.1 to 3.3.2 Additional commits viewable in https://github.com/lukas-krecan/JsonUnit/compare/json-unit-parent-2.28.0...json-unit-parent-2.32.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] dependabot[bot] commented on pull request #747: Bump json-unit from 2.28.0 to 2.31.0
dependabot[bot] commented on pull request #747: URL: https://github.com/apache/logging-log4j2/pull/747#issuecomment-1046313127 Superseded by #765. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #763: Added java logging with Asynchronous logger
garydgregory commented on a change in pull request #763:
URL: https://github.com/apache/logging-log4j2/pull/763#discussion_r810678883
##
File path: log4j-java-maven/src/main/java/com/log4j2/Error.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache license, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the license for the specific language governing permissions and
+ * limitations under the license.
+ */
+package com.log4j2;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+public class Error {
Review comment:
What is the point of this class?
FTR: No Javadoc. Wrong package anyway.
It feels like there is a disconnect between what should be an example and
your expectations. -1 unless someone can explain why we need this class or this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus edited a comment on pull request #763: Added java logging with Asynchronous logger
ruhulmus edited a comment on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046311284 > Hello @ruhulmus This looks like an example app and configuration. I do not see why it belongs in the Log4j runtime. What am I missing? Here, logs are running Asynchronously using Log4j on the java maven project. Async logger is one of Log4j2's strong points. And it belongs in the Log4j runtime. This mechanism increased the logging performance and provide lower logging latency and higher throughput. I hope now it's bit clear :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #747: Bump json-unit from 2.28.0 to 2.31.0
garydgregory commented on pull request #747: URL: https://github.com/apache/logging-log4j2/pull/747#issuecomment-1046311508 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger
ruhulmus commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046311284 > Hello @ruhulmus This looks like an example app and configuration. I do not see why it belongs in the Log4j runtime. What am I missing? Here, logs are running Asynchronously using Log4j on the java maven project. Async logger is one of Log4j2's strong points. And it belongs in the Log4j runtime. This mechanism increased the logging performance and provide lower logging latency and higher throughput. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #764: Adds Log4j 1.x global threshold
ppkarwasz commented on a change in pull request #764:
URL: https://github.com/apache/logging-log4j2/pull/764#discussion_r810676890
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationParser.java
##
@@ -103,6 +107,18 @@
if (Boolean.parseBoolean(debugValue)) {
builder.setStatusLevel(Level.DEBUG);
}
+// if log4j.reset=true then reset hierarchy
+final String reset = getLog4jValue("reset");
+if (reset != null && OptionConverter.toBoolean(reset, false)) {
Review comment:
Yes, you are right. I copy-pasted the "reset" part from the
`PropertiesConfiguration`, without checking exactly what it does. I'll remove
it for now (besides the `XmlConfiguration` does not recognize this option).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #764: Adds Log4j 1.x global threshold
garydgregory commented on a change in pull request #764:
URL: https://github.com/apache/logging-log4j2/pull/764#discussion_r810672064
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/config/Log4j1ConfigurationParser.java
##
@@ -103,6 +107,18 @@
if (Boolean.parseBoolean(debugValue)) {
builder.setStatusLevel(Level.DEBUG);
}
+// if log4j.reset=true then reset hierarchy
+final String reset = getLog4jValue("reset");
+if (reset != null && OptionConverter.toBoolean(reset, false)) {
Review comment:
I do not see this reset setting tested in this PR. Did I miss it? Also,
elsewhere we call the reset API from a doConfigure() method, it seems odd to
call it here. Is it then called twice or should this call be moved to the site
when the configuration is actually applied? @rgoers WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz closed pull request #711: Adds test for the XmlLayoutBuilder
ppkarwasz closed pull request #711: URL: https://github.com/apache/logging-log4j2/pull/711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz opened a new pull request #764: Adds Log4j 1.x global threshold
ppkarwasz opened a new pull request #764: URL: https://github.com/apache/logging-log4j2/pull/764 The `log4j.threshold` configuration key was not translated into its Log4j 2.x equivalent global filter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4net] BipulRaman opened a new pull request #80: Link Correction.
BipulRaman opened a new pull request #80: URL: https://github.com/apache/logging-log4net/pull/80 Link Correction made in ReadMe markdown file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #763: Added java logging with Asynchronous logger
garydgregory commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046265712 Hello @ruhulmus This looks like an example app and configuration. I do not see why it belongs in the Log4j runtime. What am I missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LOG4J2-3409) workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng
alexander kravchik created LOG4J2-3409: -- Summary: workaround for jackson-mapper-asl-1.9.13.jar security vulnerability @ flume-ng Key: LOG4J2-3409 URL: https://issues.apache.org/jira/browse/LOG4J2-3409 Project: Log4j 2 Issue Type: Bug Components: Flume Appender Affects Versions: 2.17.1 Environment: java 11 Reporter: alexander kravchik Dear colleagues, we are using log4j2 with flume-ng appender. The below vulnerabilities are found in the dependent jackson-mapper-asl-1.9.13.jar : cve-2019-10202 cve-2019-10172 etc... Please advise if this will be fixed and planned ETA in case it is already fixed Thanks , Sasha -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [logging-log4j2] garydgregory merged pull request #746: Bump de.flapdoodle.embed.mongo from 3.2.8 to 3.3.1
garydgregory merged pull request #746: URL: https://github.com/apache/logging-log4j2/pull/746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus commented on pull request #763: Added java logging with Asynchronous logger
ruhulmus commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046217637 > @ruhulmus Please describe what is the goal of this PR. It does not seem to fit in the project. Why a new module and so on? None of the files have the proper Apache license header as well. Thanks for your feedback. The goal of this PR is mainly to add Asynchronous Loggers for Low-Latency Logging into Java maven-based project. here is the link: https://logging.apache.org/log4j/2.x/manual/async.html N.B : Already Added Apache license in the headers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #763: Added java logging with Asynchronous logger
garydgregory commented on pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763#issuecomment-1046214567 @ruhulmus Please describe what is the goal of this PR. It does not seem to fit in the project. Why a new module and so on? None of the files have the proper Apache license header as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] ruhulmus opened a new pull request #763: Added java logging with Asynchronous logger
ruhulmus opened a new pull request #763: URL: https://github.com/apache/logging-log4j2/pull/763 log4j2 logging using java 8 and maven 3 Implement Asynchronous Loggers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LOG4J2-3304) SpringEnvironmentHolder getEnvironment always return null
[ https://issues.apache.org/jira/browse/LOG4J2-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495104#comment-17495104 ] Ralph Goers commented on LOG4J2-3304: - This patch will cause LogManager to be set to initialized even if no providers could be located. I believe setInitialized needs to also be called in an else block to fix this. > SpringEnvironmentHolder getEnvironment always return null > - > > Key: LOG4J2-3304 > URL: https://issues.apache.org/jira/browse/LOG4J2-3304 > Project: Log4j 2 > Issue Type: Bug > Components: API, Spring >Affects Versions: 2.17.1 >Reporter: francis >Priority: Major > > I am using SpringLookup and SpringProfileArbiter for conditional > configuration, but it doesn't work. I debugged into SpringEnvironmentHolder > and found that the getEnvironment method always returns null. Then I found > the root cause is that when the factoryClassName is present and load > successfully, the LogManagerStatus is not set in the static block of > LogManager. It could be a bug, please take a look -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [logging-log4j2] ppkarwasz commented on pull request #762: Trim property values
ppkarwasz commented on pull request #762: URL: https://github.com/apache/logging-log4j2/pull/762#issuecomment-1046188788 @garydgregory: I tested the `Log4j1ConfigurationConverter` with a configuration full of spaces and it worked correctly, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz closed pull request #762: Trim property values
ppkarwasz closed pull request #762: URL: https://github.com/apache/logging-log4j2/pull/762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (LOG4J2-3329) OOM Issue: RollingFile with custom layout and timebased rolling policy
[ https://issues.apache.org/jira/browse/LOG4J2-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495100#comment-17495100 ] Ralph Goers commented on LOG4J2-3329: - There is not enough information to determine the problem. All the stack trace shows that an OutOfMemory Error occurred somewhere in the called Appender and was properly handled by AppenderControl. We would need a test project that demonstrates the problem to debug this. > OOM Issue: RollingFile with custom layout and timebased rolling policy > -- > > Key: LOG4J2-3329 > URL: https://issues.apache.org/jira/browse/LOG4J2-3329 > Project: Log4j 2 > Issue Type: Bug > Components: Appenders, Layouts >Affects Versions: 2.17.1 > Environment: CERTIFICATION >Reporter: Geet S >Assignee: Ralph Goers >Priority: Blocker > > I have used Java log4j2 programmatically and created custom appender of type > RollingFile with custom layout and TimeBasedTriggeringPolicy (interval 1800) > . We see below issue for one component and this does not happen for all. > We are using OpenJDK 1.8 with Embedded Jetty server 9. > *Error: java.lang.OutOfMemoryError: GC overhead limit exceeded* > +*Exception Trace 1:*+ > 2022-01-11 22:14:53,338 JobPublishingTask - 25 of 30 ERROR An exception > occurred processing Appender CustomAppender > org.apache.logging.log4j.core.appender.AppenderLoggingException: > java.lang.OutOfMemoryError: GC overhead limit exceeded > at > org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:165) > at > org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:134) > at > org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:125) > at > org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:89) > at > org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:542) > at > org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:500) > at > org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:483) > at > org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:417) > at > org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:82) > at org.apache.logging.log4j.core.Logger.log(Logger.java:161) > at > org.apache.logging.log4j.spi.AbstractLogger.tryLogMessage(AbstractLogger.java:2205) > at > org.apache.logging.log4j.spi.AbstractLogger.logMessageTrackRecursion(AbstractLogger.java:2159) > at > org.apache.logging.log4j.spi.AbstractLogger.logMessageSafely(AbstractLogger.java:2142) > at > org.apache.logging.log4j.spi.AbstractLogger.logMessage(AbstractLogger.java:1994) > at > org.apache.logging.log4j.spi.AbstractLogger.logIfEnabled(AbstractLogger.java:1852) > at org.apache.logging.log4j.spi.AbstractLogger.log(AbstractLogger.java:1642) > +*Exception Trace 2:*+ > 2022-01-01 09:00:51,554 JobPublishingTaskDLSQS - 15 of 30 ERROR An exception > occurred processing Appender CustomAppender > org.apache.logging.log4j.core.appender.AppenderLoggingException: > java.lang.OutOfMemoryError: GC overhead limit exceeded at > org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:165) > at > org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:134) > at > org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:125) > at > org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:89) > at > org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:542) > at > org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:500) > at > org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:483) > at > org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:417) > at > org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:82) > at org.apache.logging.log4j.core.Logger.log(Logger.java:161) at > org.apache.logging.log4j.spi.AbstractLogger.tryLogMessage(AbstractLogger.java:2205) > at > org.apache.logging.log4j.spi.AbstractLogger.logMessageTrackRecursion(AbstractLogger.java:2159) > at > org.apache.logging.log4j.spi.AbstractLogger.logMessageSafely(AbstractLogger.java:2142) > at > org.apache.logging.log4j.spi.AbstractLogger.logMessage(AbstractLogger.java:1994) > at > org.apache.logging.log4j.spi.AbstractLogger.logIfEnabled(AbstractLogger.java:1852) > at org.apache.logging.log4j.spi.AbstractLogger.log(AbstractLogger.j
[jira] [Resolved] (LOG4J2-3331) After upgrading version 2.13, the className and lineNumber cannot be obtained
[ https://issues.apache.org/jira/browse/LOG4J2-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-3331. - Resolution: Information Provided Resolving as information provided. > After upgrading version 2.13, the className and lineNumber cannot be obtained > - > > Key: LOG4J2-3331 > URL: https://issues.apache.org/jira/browse/LOG4J2-3331 > Project: Log4j 2 > Issue Type: Bug > Components: Core >Affects Versions: 2.13.1, 2.17.0 >Reporter: Ning Ning Han >Priority: Major > Attachments: image-2022-01-12-23-34-25-594.png > > > I upgraded the version of log4j to 2.13, which caused a problem as follows： > 2022-01-12 23:29:09,846 Log4j2-TF-4-AsyncLoggerConfig-2 ERROR An exception > occurred processing Appender Console java.lang.NullPointerException > at > com.test.lego.common.log.MyStandardLayout.toSerializable(MyStandardLayout.java:91) > at > com.test.lego.common.log.MyStandardLayout.toSerializable(MyStandardLayout.java:26) > at > org.apache.logging.log4j.core.layout.AbstractStringLayout.toByteArray(AbstractStringLayout.java:308) > at > org.apache.logging.log4j.core.layout.AbstractLayout.encode(AbstractLayout.java:210) > at > org.apache.logging.log4j.core.layout.AbstractLayout.encode(AbstractLayout.java:37) > at > org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.directEncodeEvent(AbstractOutputStreamAppender.java:197) > at > org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.tryAppend(AbstractOutputStreamAppender.java:190) > at > org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.append(AbstractOutputStreamAppender.java:181) > at > org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156) > at > org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:129) > at > org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:120) > at > org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:84) > at > org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:543) > at > org.apache.logging.log4j.core.async.AsyncLoggerConfig.callAppenders(AsyncLoggerConfig.java:127) > at > org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:502) > at > org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:485) > at > org.apache.logging.log4j.core.async.AsyncLoggerConfig.log(AsyncLoggerConfig.java:121) > at > org.apache.logging.log4j.core.async.AsyncLoggerConfig.logToAsyncLoggerConfigsOnCurrentThread(AsyncLoggerConfig.java:169) > at > org.apache.logging.log4j.core.async.AsyncLoggerConfigDisruptor$Log4jEventWrapperHandler.onEvent(AsyncLoggerConfigDisruptor.java:111) > at > org.apache.logging.log4j.core.async.AsyncLoggerConfigDisruptor$Log4jEventWrapperHandler.onEvent(AsyncLoggerConfigDisruptor.java:97) > at > com.lmax.disruptor.BatchEventProcessor.processEvents(BatchEventProcessor.java:169) > at > com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:126) > at java.lang.Thread.run(Thread.java:748) > > key code of the MyStandardLayout : > !image-2022-01-12-23-34-25-594.png! > event.getSource is null > > This problem occurs in versions greater than 2.12 > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (LOG4J2-3334) Configurator.setLevel adding an incomplete LoggerConfig
[
https://issues.apache.org/jira/browse/LOG4J2-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495098#comment-17495098
]
ASF subversion and git services commented on LOG4J2-3334:
-
Commit f11dc6df9ae6367d96b73aed77e6e8c84e4cb4c7 in logging-log4j2's branch
refs/heads/master from Ralph Goers
[ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=f11dc6d ]
LOG4J2-3334 - Create test to try to verify the problem
> Configurator.setLevel adding an incomplete LoggerConfig
> ---
>
> Key: LOG4J2-3334
> URL: https://issues.apache.org/jira/browse/LOG4J2-3334
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.17.1
>Reporter: Mircea Lemnaru
>Priority: Major
>
> I am trying to set the log levels for my application programatically and I
> was using the method: *Configurator.setLevel*
>
> {code:java}
> private static boolean setLevel(final String loggerName, final Level level,
> final Configuration config) {
> boolean set;
> LoggerConfig loggerConfig = config.getLoggerConfig(loggerName);
> if (!loggerName.equals(loggerConfig.getName())) {
> // TODO Should additivity be inherited?
> loggerConfig = new LoggerConfig(loggerName, level, true);
> config.addLogger(loggerName, loggerConfig);
> loggerConfig.setLevel(level);
> set = true;
> } else {
> set = setLevel(loggerConfig, level);
> }
> return set;
> } {code}
> In my applicationI have the following loggers structure:
>
> *com.myapp.service* -> set on TRACE from XML config
> Then I have the class: com.myapp.service.common.ServiceUtils with a logger
> defined for it like this: {{Logger log =
> LogManager.getLogger(this.getClass());}}
> And in this class, a bunch of log statements on *TRACE*
> Then I am trying to set the log level to *INFO* for the whole
> com.myapp.service.common package. To suppress the *TRACE* logs for example.
> If I do this , Configurator will do the following:
> # will try to fetch a LoggerConfig for the *common* package
> # because there is nothing defined for that package only for the parent ...
> it will return the config for that package
> # because the names differ it will create a new LogConfig with the new
> logger name and level but {color:#FF}without any appenders or appenders
> refs{color}
> # then it will add this to the config and reload loggers
> At this moment the logs from the end class are not printed anymore.
> Now , I again set the level for com.myapp.service.common logger , but this
> time to {*}TRACE{*}. In order to re-enable the logs.
> Still , I can't see anything in the logs.
> After investigating it seems that adding the LoggerConfig without the
> appenders copied from parent , is causing this behaviour.
> If for example I change the setLevel method to also add the appender refs and
> appenders when creating the LoggerConfig object , everything is good and
> logging works as expected.
> Thank you
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
