[GitHub] [logging-log4j2] ramananravi commented on pull request #671: add support for FileSize in TB

2021-12-30 Thread GitBox


ramananravi commented on pull request #671:
URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1003021312


   > @ramananravi, we think there are a few more places in the code where a 
similar improvement might be handy. Mind creating a JIRA ticket for this 
change, please?
   
   @vy here's the jira ticket for reference:
   https://issues.apache.org/jira/browse/LOG4J2-3303
   
   Please let me know if there's something you want me to add as part of this 
PR. Thanks in advance. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [logging-log4j2] ramananravi commented on pull request #671: add support for FileSize in TB

2021-12-27 Thread GitBox


ramananravi commented on pull request #671:
URL: https://github.com/apache/logging-log4j2/pull/671#issuecomment-1001690144


   Currently the default value of 'exceeds' attribute of 
'IfAccumulatedFileSize' is Long.MAX_VALUE, which is considerably larger than 
1000 TB itself. Hence adding support for specifying 'exceeds' parameter in TB 
(TeraBytes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org