[GitHub] [logging-log4j2] remkop commented on issue #283: LOG4J-2635: Fix java.version check in ThreadNameCachingStrategy

2019-06-21 Thread GitBox
remkop commented on issue #283: LOG4J-2635: Fix java.version check in 
ThreadNameCachingStrategy
URL: https://github.com/apache/logging-log4j2/pull/283#issuecomment-504393658
 
 
   Makes sense. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [logging-log4j2] remkop commented on issue #283: LOG4J-2635: Fix java.version check in ThreadNameCachingStrategy

2019-06-21 Thread GitBox
remkop commented on issue #283: LOG4J-2635: Fix java.version check in 
ThreadNameCachingStrategy
URL: https://github.com/apache/logging-log4j2/pull/283#issuecomment-504383978
 
 
   @fgunbin if these are only locally used I would prefer not to define them in 
`Constants` but just define them locally. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services