Re: [PR] Support for ZSTD Compression (logging-log4j2)
anuragagarwal561994 commented on PR #1514: URL: https://github.com/apache/logging-log4j2/pull/1514#issuecomment-1758017705 Thanks @vy can finally remove a tech debt from our projects :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for ZSTD Compression (logging-log4j2)
vy commented on PR #1514: URL: https://github.com/apache/logging-log4j2/pull/1514#issuecomment-1757782564 @anuragagarwal561994, I have merged this. Thanks for the contribution. This will be available in the `2.21.0` release that should come out sometime this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for ZSTD Compression (logging-log4j2)
vy merged PR #1514: URL: https://github.com/apache/logging-log4j2/pull/1514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support for ZSTD Compression (logging-log4j2)
anuragagarwal561994 commented on PR #1514: URL: https://github.com/apache/logging-log4j2/pull/1514#issuecomment-1590915095 @vy you can check the MR here, just a suggestion `commons-compress` provides `CompressorStreamFactory` which provides constants for all the compressions available. Do you think instead of writing and changing comments everywhere we can use this constants instead and remove comments to be more verbose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
