[GitHub] tzezula opened a new pull request #500: COS Synchronization is performed at the end of initial scan.
tzezula opened a new pull request #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500 COS Synchronization in J2SEProject is delayed to the end of the initial scan. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] junichi11 commented on issue #495: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project
junichi11 commented on issue #495: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project URL: https://github.com/apache/incubator-netbeans/pull/495#issuecomment-381588362 @jlahoda Could you please review it? I can be wrong something. Copied incJavaSpecVersion(), minor() and major() from PlatformUiSupport. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan.
JaroslavTulach commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500#discussion_r181717798 ## File path: java.preprocessorbridge/src/org/netbeans/modules/java/preprocessorbridge/spi/CompileOnSaveAction.java ## @@ -281,12 +284,36 @@ public static Context update( @NonNull final Iterable updated, @NonNull final Iterable deleted, @NullAllowed final Consumer> firer) { +return update(srcRoot, isCopyResources, false, cacheRoot, updated, deleted, firer); +} + +/** + * Creates context for update operation. + * @param srcRoot the root + * @param isCopyResources true for resource update + * @param isAllFilesIndexing true for all files indexing + * @param cacheRoot the cache root + * @param updated the changed files + * @param deleted the deleted files + * @param firer the fire callback + * @return the {@link Context} for update operation + * @since 1.50 + */ +@NonNull +public static Context update( Review comment: OK. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan.
JaroslavTulach commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500#discussion_r181717847 ## File path: java.preprocessorbridge/src/org/netbeans/modules/java/preprocessorbridge/spi/CompileOnSaveAction.java ## @@ -378,6 +405,15 @@ public static URL getTargetURL(@NonNull URL srcRoot) { return result; } + +/** + * Returns true if the action represents an all files indexing. + * @return true for all files indexing + * @since 1.50 + */ +public boolean isAllFilesIndexing() { Review comment: OK. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jglick opened a new pull request #501: Silly use of Boolean
jglick opened a new pull request #501: Silly use of Boolean URL: https://github.com/apache/incubator-netbeans/pull/501 Originally posted in [bug #208411](https://netbeans.org/bugzilla/show_bug.cgi?id=208411) but never evaluated: just a minor code simplification. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jglick commented on issue #501: Silly use of Boolean
jglick commented on issue #501: Silly use of Boolean URL: https://github.com/apache/incubator-netbeans/pull/501#issuecomment-381607536 Note that I get five test failures in this module, but the same is true in `master`. I guess the Travis build is not yet running tests, so we need to that manually, ick. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jglick commented on issue #500: COS Synchronization is performed at the end of initial scan.
jglick commented on issue #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500#issuecomment-381608523 So this change only applies to Ant-based projects? Does anyone still use those any more?? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jglick opened a new pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly
jglick opened a new pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly URL: https://github.com/apache/incubator-netbeans/pull/502 Submitted around a year ago as the fix for [bug #270552](https://netbeans.org/bugzilla/show_bug.cgi?id=270552). I have been running with this patch since. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jglick opened a new pull request #503: #270005: increase the default indexing sleep delay during builds to 15s, and make it configurable
jglick opened a new pull request #503: #270005: increase the default indexing sleep delay during builds to 15s, and make it configurable URL: https://github.com/apache/incubator-netbeans/pull/503 Fix for [bug #270005](https://netbeans.org/bugzilla/show_bug.cgi?id=270005). I have been running with this patch for over a year. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jglick opened a new pull request #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation
jglick opened a new pull request #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation URL: https://github.com/apache/incubator-netbeans/pull/504 Related to [#227791](https://netbeans.org/bugzilla/show_bug.cgi?id=227791) and linked issues. This is a robustness fix: in NetBeans currently, when the built-in compiler gets confused during classpath scanning and writes out broken class files due to various subtle bugs, as happens pretty frequently in my experience on big complex projects, CoS-mode execution (e.g., running of individual unit tests in quick mode) is broken because the test JVM loads bytecode full of errors (“uncompilable source code” etc.). This is irritating because the errors are almost always from classes deep in the dependency tree and unrelated to what you are actually editing and testing, yet the problem blocks you from using CoS mode and so you must fall back to much slower full builds. With this patch, NetBeans will just trust the external build tool preferentially, based on `*.class` timestamp. Thus, if you notice some error during a CoS test case run which was caused by an IDE problem, you have a simple workaround: just do a command-line rebuild of the module containing the class mentioned in the error. You can still make edits to unrelated (source or test) files and rerun the test to pick up those changes. I have been running with this patch for over a year and it seems to work well; I no longer curse in frustration at nbjavac bugs, just note them and move on. `java.source.base` is giving me 29 test failures after 20m (!) run time, but I picked one at random and confirmed that it was also failing in `master`, so at least that one is not a regression. When was the last time `mvn -f whatever.module test` actually worked? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] tzezula commented on issue #500: COS Synchronization is performed at the end of initial scan.
tzezula commented on issue #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500#issuecomment-381664573 @jglick : Yes, just Ant based projects. We are using them as a wrapper for mx GraalVM projects. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jlahoda commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan.
jlahoda commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500#discussion_r181871244 ## File path: java.j2seproject/src/org/netbeans/modules/java/j2seproject/J2SEActionProvider.java ## @@ -703,7 +713,12 @@ private Boolean performUpdate(@NonNull final Context ctx) { ex.getMessage() }); } -}); +}; +if (ctx.isAllFilesIndexing()) { Review comment: Here I wonder: should the work be deferred always? For short scans, that should be only a small delay (right?) and for big scans, wouldn't it be preferable to do whatever is necessary after the scan is finished? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jlahoda commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan.
jlahoda commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan. URL: https://github.com/apache/incubator-netbeans/pull/500#discussion_r181870454 ## File path: java.j2seproject/src/org/netbeans/modules/java/j2seproject/J2SEActionProvider.java ## @@ -883,8 +898,43 @@ private static String relativize( start++; } return file.getAbsolutePath().substring(start); -} - +} + +private void enqueueDeferred(final Runnable work) { +boolean addGuard = false; +synchronized (this) { +this.deferred.offer(work); +if (deferredGuard == 0) { + addGuard = true; +deferredGuard = 1; +} +} +if (addGuard) { +final JavaSource js = createSource(); +synchronized (this) { +if (deferredGuard == 1) { +try { +js.runWhenScanFinished((cc) -> drainDeferred(), true); Review comment: Should deferredGuard be set to 2 here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jlahoda opened a new pull request #505: [NETBEANS-615] When nb-javac is not installed, don't let CoS run, but…
jlahoda opened a new pull request #505: [NETBEANS-615] When nb-javac is not installed, don't let CoS run, but… URL: https://github.com/apache/incubator-netbeans/pull/505 … rather suggest installing nb-javac or disabling CoS. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] eirikbakke opened a new pull request #506: [NETBEANS-673] Add support for MariaDB JDBC driver in Add Connection wizard
eirikbakke opened a new pull request #506: [NETBEANS-673] Add support for MariaDB JDBC driver in Add Connection wizard URL: https://github.com/apache/incubator-netbeans/pull/506 See https://issues.apache.org/jira/browse/NETBEANS-673 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jtulach commented on issue #498: don't create moe project unless selected
jtulach commented on issue #498: don't create moe project unless selected URL: https://github.com/apache/incubator-netbeans/pull/498#issuecomment-381838786 The change looks good to me and thanks for the test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach commented on issue #501: Silly use of Boolean
JaroslavTulach commented on issue #501: Silly use of Boolean URL: https://github.com/apache/incubator-netbeans/pull/501#issuecomment-381849389 Čau Jesse. The platform tests are executed by [jenkins](https://builds.apache.org/job/incubator-netbeans-linux/) builds. Nobody runs all the (non-platform) module tests continuously, however. It would be excellent if you can/want to set more test runs up somewhere. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach closed pull request #501: Silly use of Boolean
JaroslavTulach closed pull request #501: Silly use of Boolean URL: https://github.com/apache/incubator-netbeans/pull/501 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java b/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java index 4a3caae00..45c89c3b4 100644 --- a/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java +++ b/maven/src/org/netbeans/modules/maven/queries/ShadePluginDetector.java @@ -62,8 +62,8 @@ private boolean calculateValue() { if (PluginPropertyUtils.getPluginVersion(nbmp.getMavenProject(), Constants.GROUP_APACHE_PLUGINS, "maven-shade-plugin") == null) { return true; } -Boolean toret = Boolean.valueOf(PluginPropertyUtils.getPluginProperty(project, Constants.GROUP_APACHE_PLUGINS, "maven-shade-plugin", "shadedArtifactAttached", "shade", null)); -if (toret == Boolean.FALSE) { +boolean toret = Boolean.parseBoolean(PluginPropertyUtils.getPluginProperty(project, Constants.GROUP_APACHE_PLUGINS, "maven-shade-plugin", "shadedArtifactAttached", "shade", null)); +if (!toret) { if (pr != null) { pr.addReport(PROBLEM_REPORT); } This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach closed pull request #498: don't create moe project unless selected
JaroslavTulach closed pull request #498: don't create moe project unless selected URL: https://github.com/apache/incubator-netbeans/pull/498 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/maven.htmlui/src/org/netbeans/modules/maven/htmlui/DukeScriptWizard.java b/maven.htmlui/src/org/netbeans/modules/maven/htmlui/DukeScriptWizard.java index 809188fae..7b3fdead2 100644 --- a/maven.htmlui/src/org/netbeans/modules/maven/htmlui/DukeScriptWizard.java +++ b/maven.htmlui/src/org/netbeans/modules/maven/htmlui/DukeScriptWizard.java @@ -55,7 +55,6 @@ @Property(name = "nbInstallationDefined", type = boolean.class), }) public class DukeScriptWizard { - @TemplateRegistration( position = 133, page = "dukeScriptWizard.html", @@ -65,6 +64,7 @@ iconBase = "org/netbeans/modules/maven/htmlui/DukeHTML.png", description = "description.html" ) + @Messages("DukeScriptWizard_displayName=Java Frontend Application") public static WizardData javafxWebViewAppWizard() { WizardData data = new WizardData(); @@ -95,7 +95,7 @@ static void init(WizardData data, "knockout4j-archetype", "com.dukescript.archetype", true, -"0.20", +"0.23", "Basic DukeScript Template", "Default skeletal application", null ); @@ -105,11 +105,20 @@ static void init(WizardData data, "crud4j-archetype", "com.dukescript.archetype", false, -"0.20", +"0.23", "DukeScript CRUD Template", "Client-Server Application demonstrating communication and reuse of DataModels", null ); data.getArchetypes().add(crudArch); +final ArchetypeData visArch = new ArchetypeData( +"visual-archetype", +"com.dukescript.archetype", +false, +"0.23", +"DukeScript Visual Archetype", "A sample application demonstrating Canvas, Charts & Maps", +null +); +data.getArchetypes().add(visArch); data.setIosMoe(true); String srvPath = Boolean.getBoolean("staging.archetypes") ? "stage" : "archetypes"; data.loadArchetypes(srvPath); @@ -156,15 +165,15 @@ static String androidpath(boolean android) { } @ComputedProperty -static String iospath(boolean iosRoboVM) { -return iosRoboVM ? "client-ios" : null; +static String iospath(boolean ios, boolean iosRoboVM) { + return ios && iosRoboVM ? "client-ios" : null; } @ComputedProperty -static String moepath(boolean iosMoe) { -return iosMoe ? "client-moe" : null; +static String moepath(boolean ios, boolean iosMoe) { + return ios && iosMoe ? "client-moe" : null; } - + @ComputedProperty static String netbeanspath(boolean netbeans) { return netbeans ? "client-netbeans" : null; diff --git a/maven.htmlui/test/unit/src/org/netbeans/modules/maven/htmlui/WizardDataTest.java b/maven.htmlui/test/unit/src/org/netbeans/modules/maven/htmlui/WizardDataTest.java new file mode 100644 index 0..56aeed74f --- /dev/null +++ b/maven.htmlui/test/unit/src/org/netbeans/modules/maven/htmlui/WizardDataTest.java @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.maven.htmlui; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNull; +import org.junit.Before; +import org.junit.Test; + +public class WizardDataTest { +private WizardData wd; + +@Before +public void setupModel() { +wd = new WizardData(); +wd.setIosMoe(false); +wd.setIos(false); +wd.setIosRoboVM(false); +} + + +@Test +public void moeOnlyEnabledIfIosEnabled() { +assertNull("No moe path", wd.g
[GitHub] JaroslavTulach commented on a change in pull request #503: #270005: increase the default indexing sleep delay during builds to 15s, and make it configurable
JaroslavTulach commented on a change in pull request #503: #270005: increase the default indexing sleep delay during builds to 15s, and make it configurable URL: https://github.com/apache/incubator-netbeans/pull/503#discussion_r181956454 ## File path: maven/src/org/netbeans/modules/maven/execute/AbstractOutputHandler.java ## @@ -66,7 +66,7 @@ private IndexingBridge.Lock protectedMode; // #211005 private final Object protectedModeLock = new Object(); private RequestProcessor.Task sleepTask; -private static final int SLEEP_DELAY = 5000; +private static final int SLEEP_DELAY = Integer.getInteger(AbstractOutputHandler.class.getName() + ".SLEEP_DELAY", 15000); // #270005 Review comment: This property shall be documented in `arch.xml` document - `` - at least that used to be our habit before switching to Apache. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach commented on a change in pull request #505: [NETBEANS-615] When nb-javac is not installed, don't let CoS run, but…
JaroslavTulach commented on a change in pull request #505: [NETBEANS-615] When nb-javac is not installed, don't let CoS run, but… URL: https://github.com/apache/incubator-netbeans/pull/505#discussion_r181956914 ## File path: java.source.base/src/org/netbeans/modules/java/source/indexing/JavaCustomIndexer.java ## @@ -130,6 +130,7 @@ private static final String APT_SOURCE_OUTPUT = "apSrcOut"; //NOI18N private static final Pattern ANONYMOUS = Pattern.compile("\\$[0-9]"); //NOI18N private static final ClassPath EMPTY = ClassPathSupport.createClassPath(new URL[0]); +private static final String PROP_NB_JAVAC = "nb-javac.installed"; //NOI18N Review comment: Wild, terrible hack. Wouldn't it be more constructive to record version of `javac` that is used for indexing and if the version changes (due to `nbjavac` being installed or due to change of `JDK` etc.) reparse? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach closed pull request #499: [NETBEANS-656] Switch docs URL from netbeans.org to netbeans.apache.org.
JaroslavTulach closed pull request #499: [NETBEANS-656] Switch docs URL from netbeans.org to netbeans.apache.org. URL: https://github.com/apache/incubator-netbeans/pull/499 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/utilities/src/org/netbeans/modules/utilities/netbeans-kb.url b/utilities/src/org/netbeans/modules/utilities/netbeans-kb.url index da9af8f20..dcead0b32 100644 --- a/utilities/src/org/netbeans/modules/utilities/netbeans-kb.url +++ b/utilities/src/org/netbeans/modules/utilities/netbeans-kb.url @@ -1 +1 @@ -http://www.netbeans.org/kb/index.html \ No newline at end of file +https://netbeans.apache.org/help/index.html \ No newline at end of file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach commented on issue #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation
JaroslavTulach commented on issue #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation URL: https://github.com/apache/incubator-netbeans/pull/504#issuecomment-381851991 Robustness is needed. Btw. @jlahoda provided me with a patch that works the other way around: e.g. it can adopt the existing `.class` files internally. That would be useful enhancement as well. If this change doesn't clash with the future *copy instead of parse* enhancement, let's go for it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jtulach commented on issue #506: [NETBEANS-673] Add support for MariaDB JDBC driver in Add Connection wizard
jtulach commented on issue #506: [NETBEANS-673] Add support for MariaDB JDBC driver in Add Connection wizard URL: https://github.com/apache/incubator-netbeans/pull/506#issuecomment-381852562 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach closed pull request #497: Using Log.error(..., Error) instead of log.error(..., String, ...) wh…
JaroslavTulach closed pull request #497: Using Log.error(..., Error) instead of log.error(..., String, ...) wh… URL: https://github.com/apache/incubator-netbeans/pull/497 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavadocEnter.java b/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavadocEnter.java index fb92f4216..0f98e47bb 100644 --- a/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavadocEnter.java +++ b/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavadocEnter.java @@ -28,6 +28,7 @@ import com.sun.tools.javac.tree.TreeInfo; import com.sun.tools.javac.util.Context; import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition; +import com.sun.tools.javac.util.JCDiagnostic.Error; import com.sun.tools.javadoc.main.JavadocEnter; import com.sun.tools.javadoc.main.Messager; import org.netbeans.lib.nbjavac.services.NBTreeMaker.IndexedClassDecl; @@ -68,7 +69,7 @@ protected NBJavadocEnter(Context context) { @Override protected void duplicateClass(DiagnosticPosition pos, ClassSymbol c) { -messager.error(pos, "duplicate.class", c.fullname); +messager.error(pos, new Error("compiler", "duplicate.class", c.fullname)); } @Override This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly
JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly URL: https://github.com/apache/incubator-netbeans/pull/502#discussion_r181958387 ## File path: maven/src/org/netbeans/modules/maven/queries/RepositoryMavenCPProvider.java ## @@ -179,7 +179,7 @@ private ClassPathImplementation createCompileCPI(MavenProject project, File bina items.add(ClassPathSupport.createResource(FileUtil.urlForArchiveOrDir(binary))); if (project != null) { for (Artifact s : project.getCompileArtifacts()) { -File file = s.getFile(); +File file = s.getFile(); // TODO perhaps needs patching Review comment: I guess you should make your mind. There is nobody to answer that TODO question otherwise. Or am I wrong @mkleint? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly
JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly URL: https://github.com/apache/incubator-netbeans/pull/502#discussion_r181958178 ## File path: maven/src/org/netbeans/modules/maven/nodes/DependencyNode.java ## @@ -785,6 +785,7 @@ private Project getDependencyProject() { return null; } URI uri = org.openide.util.Utilities.toURI(art.getFile()); +// TODO should be patched, along with other uses of Artifact.getFile among nodes Review comment: What are your plans with these TODOs, @jglick? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly
JaroslavTulach commented on a change in pull request #502: #270552: AbstractProjectClassPathImpl subtypes generally need to process Artifact.file to handle timestamped snapshots properly URL: https://github.com/apache/incubator-netbeans/pull/502#discussion_r181958801 ## File path: maven/src/org/netbeans/modules/maven/classpath/AbstractProjectClassPathImpl.java ## @@ -206,4 +211,33 @@ public void removePropertyChangeListener(PropertyChangeListener propertyChangeLi return project.hashCode() ^ getClass().hashCode(); } +/** + * Like {@link Artifact#getFile} but when a timestamped snapshot is locally downloaded, uses that instead. + */ +protected static File getFile(Artifact art) { +File f = art.getFile(); +if (f != null) { +if (art.isSnapshot() && !art.getVersion().equals(art.getBaseVersion())) { +String name = f.getName(); +int dot = name.lastIndexOf(/* DefaultRepositoryLayout.GROUP_SEPARATOR */'.'); +if (dot > 0 && name.substring(0, dot).endsWith(art.getBaseVersion())) { +File f2 = new File(f.getParentFile(), name.substring(0, dot - art.getBaseVersion().length()) + art.getVersion() + name.substring(dot)); +if (f2.isFile()) { Review comment: An illustrative test for this behavior might be beneficial for future maintenance. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach closed pull request #496: [NETBEANS-649] Missing source level 9 and 10 in a NetBeans module project
JaroslavTulach closed pull request #496: [NETBEANS-649] Missing source level 9 and 10 in a NetBeans module project URL: https://github.com/apache/incubator-netbeans/pull/496 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/apisupport.ant/src/org/netbeans/modules/apisupport/project/ui/customizer/SingleModuleProperties.java b/apisupport.ant/src/org/netbeans/modules/apisupport/project/ui/customizer/SingleModuleProperties.java index 874fb77be..529974b3f 100644 --- a/apisupport.ant/src/org/netbeans/modules/apisupport/project/ui/customizer/SingleModuleProperties.java +++ b/apisupport.ant/src/org/netbeans/modules/apisupport/project/ui/customizer/SingleModuleProperties.java @@ -116,7 +116,7 @@ public static final String SPEC_VERSION_BASE = "spec.version.base"; // NOI18N /** @see "#66278" */ public static final String JAVAC_COMPILERARGS = "javac.compilerargs"; // NOI18N -static final String[] SOURCE_LEVELS = {"1.4", "1.5", "1.6", "1.7", "1.8"}; // NOI18N +static final String[] SOURCE_LEVELS = {"1.4", "1.5", "1.6", "1.7", "1.8", "9", "10"}; // NOI18N private final static Map DEFAULTS; private static final Logger LOG = Logger.getLogger(SingleModuleProperties.class.getName()); This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] JaroslavTulach commented on issue #492: [NETBEANS-602] Improved support for getting the name from Multi-Release jars
JaroslavTulach commented on issue #492: [NETBEANS-602] Improved support for getting the name from Multi-Release jars URL: https://github.com/apache/incubator-netbeans/pull/492#issuecomment-381854918 CC @tzezula, @dbalek , @sdedic. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists