[GitHub] JaroslavTulach commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan.

2018-04-16 Thread GitBox
JaroslavTulach commented on a change in pull request #500: COS Synchronization 
is performed at the end of initial scan.
URL: https://github.com/apache/incubator-netbeans/pull/500#discussion_r181717847
 
 

 ##
 File path: 
java.preprocessorbridge/src/org/netbeans/modules/java/preprocessorbridge/spi/CompileOnSaveAction.java
 ##
 @@ -378,6 +405,15 @@ public static URL getTargetURL(@NonNull URL srcRoot) {
 
 return result;
 }
+
+/**
+ * Returns true if the action represents an all files indexing.
+ * @return true for all files indexing
+ * @since 1.50
+ */
+public boolean isAllFilesIndexing() {
 
 Review comment:
   OK.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



[GitHub] JaroslavTulach commented on a change in pull request #500: COS Synchronization is performed at the end of initial scan.

2018-04-16 Thread GitBox
JaroslavTulach commented on a change in pull request #500: COS Synchronization 
is performed at the end of initial scan.
URL: https://github.com/apache/incubator-netbeans/pull/500#discussion_r181717798
 
 

 ##
 File path: 
java.preprocessorbridge/src/org/netbeans/modules/java/preprocessorbridge/spi/CompileOnSaveAction.java
 ##
 @@ -281,12 +284,36 @@ public static Context update(
 @NonNull final Iterable updated,
 @NonNull final Iterable deleted,
 @NullAllowed final Consumer> firer) {
+return update(srcRoot, isCopyResources, false, cacheRoot, updated, 
deleted, firer);
+}
+
+/**
+ * Creates context for update operation.
+ * @param srcRoot the root
+ * @param isCopyResources true for resource update
+ * @param isAllFilesIndexing true for all files indexing
+ * @param cacheRoot the cache root
+ * @param updated the changed files
+ * @param deleted the deleted files
+ * @param firer the fire callback
+ * @return the {@link Context} for update operation
+ * @since 1.50
+ */
+@NonNull
+public static Context update(
 
 Review comment:
   OK.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists