[jira] [Commented] (OFBIZ-9393) UtilMisc.toMap(), toList() and toSet() refactoring taking Varargs for creating the wanted data structure
[ https://issues.apache.org/jira/browse/OFBIZ-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058249#comment-16058249 ] Michael Brohl commented on OFBIZ-9393: -- Maybe we should just deprecate the old methods instead of removing them? In this way users who used this API in custom code have a chance to migrate their code without being forced in the next update. > UtilMisc.toMap(), toList() and toSet() refactoring taking Varargs for > creating the wanted data structure > > > Key: OFBIZ-9393 > URL: https://issues.apache.org/jira/browse/OFBIZ-9393 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Martin Becker >Priority: Trivial > Attachments: OFBIZ-9393_UtilMiscOverloadedRefactoring.patch > > > This patch removes a number of outdated methods that took a fixed number of > objects to create a data structure, such as a linked list. Since the code is > outdated and inflexible, this patch removes these methods and added methods > to create the given data structure via a variable amount of arguments. This > approach also ensures that no other code needs a refactoring. In addition the > method populateMap() was removed which was private and was only used by the > multiple outdated toMap() functions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9305) change debug.properties property value cause ofbiz can't start
[ https://issues.apache.org/jira/browse/OFBIZ-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057298#comment-16057298 ] Jacopo Cappellato commented on OFBIZ-9305: -- Thank you William! This issue has been fixed in trunk with revision 1799417 and in 16.03 with revision 1799419 > change debug.properties property value cause ofbiz can't start > -- > > Key: OFBIZ-9305 > URL: https://issues.apache.org/jira/browse/OFBIZ-9305 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: 16.11.01, 16.11.02 > Environment: windows 10 x64. >Reporter: William Wang >Assignee: Jacopo Cappellato > Fix For: 16.11.03 > > Attachments: > TEST-org.apache.ofbiz.entity.util.EntitySaxReaderTests.xml > > > change apache-ofbiz-16.11.01\framework\base\config\debug.properties > print.verbose=false to print.verbose=true > restart ofbiz with command line:gradlew.bat ofbiz get error happend; > {code} > org.apache.ofbiz.base.util.UtilCodecTests > testCheckStringForHtmlStrictNone > STANDARD_OUT > 11:07:31.743 [Test worker] ERROR org.apache.ofbiz.base.util.UtilCodec - > Canonicalization (format consistency, character escaping that is mixed or > double, etc) error for attribute named [double-encoding], String > [%2%353Cscript]: org.apache.ofbiz.base.util.UtilCodec$IntrusionException: > Input validation failure > org.apache.ofbiz.entity.util.EntitySaxReaderTests > parse STANDARD_OUT > 11:07:42.509 [Test worker] ERROR > org.apache.ofbiz.entity.util.EntitySaxReader - An error occurred saving the > data, rolling back transaction (true) > java.lang.NullPointerException > at > org.apache.ofbiz.entity.util.EntitySaxReader.endElement(EntitySaxReader.java:404) > ~[main/:?] > at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at javax.xml.parsers.SAXParser.parse(SAXParser.java:195) > ~[?:1.8.0_121] > at > org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:225) > [main/:?] > at > org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:186) > [main/:?] > at > org.apache.ofbiz.entity.util.EntitySaxReaderTests.parse(EntitySaxReaderTests.java:62) > [test/:?] > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > ~[?:1.8.0_121] > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > ~[?:1.8.0_121] > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > ~[?:1.8.0_121] > at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121] > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > [junit-dep-4.10.jar:?] > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > [junit-dep-4.10.jar:?] > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > [junit-dep-4.10.jar:?] > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) > [junit-dep-4.10.jar:?] > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) > [junit-dep-4.10.jar:?] > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
[jira] [Updated] (OFBIZ-9305) change debug.properties property value cause ofbiz can't start
[ https://issues.apache.org/jira/browse/OFBIZ-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-9305: - Fix Version/s: 16.11.03 > change debug.properties property value cause ofbiz can't start > -- > > Key: OFBIZ-9305 > URL: https://issues.apache.org/jira/browse/OFBIZ-9305 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: 16.11.01, 16.11.02 > Environment: windows 10 x64. >Reporter: William Wang >Assignee: Jacopo Cappellato > Fix For: 16.11.03 > > Attachments: > TEST-org.apache.ofbiz.entity.util.EntitySaxReaderTests.xml > > > change apache-ofbiz-16.11.01\framework\base\config\debug.properties > print.verbose=false to print.verbose=true > restart ofbiz with command line:gradlew.bat ofbiz get error happend; > {code} > org.apache.ofbiz.base.util.UtilCodecTests > testCheckStringForHtmlStrictNone > STANDARD_OUT > 11:07:31.743 [Test worker] ERROR org.apache.ofbiz.base.util.UtilCodec - > Canonicalization (format consistency, character escaping that is mixed or > double, etc) error for attribute named [double-encoding], String > [%2%353Cscript]: org.apache.ofbiz.base.util.UtilCodec$IntrusionException: > Input validation failure > org.apache.ofbiz.entity.util.EntitySaxReaderTests > parse STANDARD_OUT > 11:07:42.509 [Test worker] ERROR > org.apache.ofbiz.entity.util.EntitySaxReader - An error occurred saving the > data, rolling back transaction (true) > java.lang.NullPointerException > at > org.apache.ofbiz.entity.util.EntitySaxReader.endElement(EntitySaxReader.java:404) > ~[main/:?] > at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at javax.xml.parsers.SAXParser.parse(SAXParser.java:195) > ~[?:1.8.0_121] > at > org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:225) > [main/:?] > at > org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:186) > [main/:?] > at > org.apache.ofbiz.entity.util.EntitySaxReaderTests.parse(EntitySaxReaderTests.java:62) > [test/:?] > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > ~[?:1.8.0_121] > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > ~[?:1.8.0_121] > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > ~[?:1.8.0_121] > at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121] > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > [junit-dep-4.10.jar:?] > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > [junit-dep-4.10.jar:?] > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > [junit-dep-4.10.jar:?] > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) > [junit-dep-4.10.jar:?] > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) > [junit-dep-4.10.jar:?] > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) >
[jira] [Assigned] (OFBIZ-9305) change debug.properties property value cause ofbiz can't start
[ https://issues.apache.org/jira/browse/OFBIZ-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-9305: Assignee: Jacopo Cappellato > change debug.properties property value cause ofbiz can't start > -- > > Key: OFBIZ-9305 > URL: https://issues.apache.org/jira/browse/OFBIZ-9305 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: 16.11.01, 16.11.02 > Environment: windows 10 x64. >Reporter: William Wang >Assignee: Jacopo Cappellato > Attachments: > TEST-org.apache.ofbiz.entity.util.EntitySaxReaderTests.xml > > > change apache-ofbiz-16.11.01\framework\base\config\debug.properties > print.verbose=false to print.verbose=true > restart ofbiz with command line:gradlew.bat ofbiz get error happend; > {code} > org.apache.ofbiz.base.util.UtilCodecTests > testCheckStringForHtmlStrictNone > STANDARD_OUT > 11:07:31.743 [Test worker] ERROR org.apache.ofbiz.base.util.UtilCodec - > Canonicalization (format consistency, character escaping that is mixed or > double, etc) error for attribute named [double-encoding], String > [%2%353Cscript]: org.apache.ofbiz.base.util.UtilCodec$IntrusionException: > Input validation failure > org.apache.ofbiz.entity.util.EntitySaxReaderTests > parse STANDARD_OUT > 11:07:42.509 [Test worker] ERROR > org.apache.ofbiz.entity.util.EntitySaxReader - An error occurred saving the > data, rolling back transaction (true) > java.lang.NullPointerException > at > org.apache.ofbiz.entity.util.EntitySaxReader.endElement(EntitySaxReader.java:404) > ~[main/:?] > at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at javax.xml.parsers.SAXParser.parse(SAXParser.java:195) > ~[?:1.8.0_121] > at > org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:225) > [main/:?] > at > org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:186) > [main/:?] > at > org.apache.ofbiz.entity.util.EntitySaxReaderTests.parse(EntitySaxReaderTests.java:62) > [test/:?] > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > ~[?:1.8.0_121] > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > ~[?:1.8.0_121] > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > ~[?:1.8.0_121] > at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121] > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > [junit-dep-4.10.jar:?] > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > [junit-dep-4.10.jar:?] > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > [junit-dep-4.10.jar:?] > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) > [junit-dep-4.10.jar:?] > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) > [junit-dep-4.10.jar:?] > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) > [junit-dep-4.10.jar:?] > at
[jira] [Updated] (OFBIZ-9305) change debug.properties property value cause ofbiz can't start
[ https://issues.apache.org/jira/browse/OFBIZ-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-9305: - Affects Version/s: 16.11.02 > change debug.properties property value cause ofbiz can't start > -- > > Key: OFBIZ-9305 > URL: https://issues.apache.org/jira/browse/OFBIZ-9305 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: 16.11.01, 16.11.02 > Environment: windows 10 x64. >Reporter: William Wang > Attachments: > TEST-org.apache.ofbiz.entity.util.EntitySaxReaderTests.xml > > > change apache-ofbiz-16.11.01\framework\base\config\debug.properties > print.verbose=false to print.verbose=true > restart ofbiz with command line:gradlew.bat ofbiz get error happend; > {code} > org.apache.ofbiz.base.util.UtilCodecTests > testCheckStringForHtmlStrictNone > STANDARD_OUT > 11:07:31.743 [Test worker] ERROR org.apache.ofbiz.base.util.UtilCodec - > Canonicalization (format consistency, character escaping that is mixed or > double, etc) error for attribute named [double-encoding], String > [%2%353Cscript]: org.apache.ofbiz.base.util.UtilCodec$IntrusionException: > Input validation failure > org.apache.ofbiz.entity.util.EntitySaxReaderTests > parse STANDARD_OUT > 11:07:42.509 [Test worker] ERROR > org.apache.ofbiz.entity.util.EntitySaxReader - An error occurred saving the > data, rolling back transaction (true) > java.lang.NullPointerException > at > org.apache.ofbiz.entity.util.EntitySaxReader.endElement(EntitySaxReader.java:404) > ~[main/:?] > at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown > Source) ~[xercesImpl-2.9.1.jar:?] > at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source) > ~[xercesImpl-2.9.1.jar:?] > at javax.xml.parsers.SAXParser.parse(SAXParser.java:195) > ~[?:1.8.0_121] > at > org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:225) > [main/:?] > at > org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:186) > [main/:?] > at > org.apache.ofbiz.entity.util.EntitySaxReaderTests.parse(EntitySaxReaderTests.java:62) > [test/:?] > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > ~[?:1.8.0_121] > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > ~[?:1.8.0_121] > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > ~[?:1.8.0_121] > at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121] > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > [junit-dep-4.10.jar:?] > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > [junit-dep-4.10.jar:?] > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > [junit-dep-4.10.jar:?] > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) > [junit-dep-4.10.jar:?] > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) > [junit-dep-4.10.jar:?] > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) > [junit-dep-4.10.jar:?] > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) > [junit-dep-4.10.jar:?] > at