[jira] [Assigned] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters

2017-07-22 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-9376:


Assignee: Nicolas Malin

> Add shipmentId list to quickshippurchaseorder return parameters
> ---
>
> Key: OFBIZ-9376
> URL: https://issues.apache.org/jira/browse/OFBIZ-9376
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: quickShipPurchaseOrder.patch
>
>
> The method " quickshippurchaseorder " allows to create a reception for every 
> ship group of a purchasing order. This method works correctly but it does not 
> return id of the receptions which it creates. The purpose of this patch is to 
> modify the service so that it returns the list of the receptions which it 
> creates
> To test this patch:
>  - Create a purchase order with several ships groups
>   - approve it
>  - from webtools execute the service " quickshippurchaseorder " with the 
> parameters: order Id: reference of order facilityId: WebStoreWarehouse
> results :
> The service returns the parameter shipmentIds



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters

2017-07-22 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097418#comment-16097418
 ] 

Nicolas Malin commented on OFBIZ-9376:
--

Hi Pierre, after apply you patch :
{code}
junit.framework.AssertionFailedError: ERROR: Could not complete the Test create 
an order using a configurable service product 
[file:/home/mnicolas/workspace/apache-svn/ofbiz-trunk-commit/applications/order/minilang/test/ShoppingCartTests.xml#testCreateOrderConfigurableServiceProduct]
 process [problem invoking the [quickShipEntireOrder] service with the map 
named [quickShipEntireOrderMap] containing 
[{userLogin=[GenericEntity:UserLogin][createdStamp,2017-07-22 
21:52:03.109(java.sql.Timestamp)][createdTxStamp,2017-07-22 
21:52:02.849(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2017-07-22
 21:52:14.374(java.sql.Timestamp)][lastUpdatedTxStamp,2017-07-22 
21:52:13.936(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
 orderId=WSCO10043, locale=en}]: Outgoing result (in runSync : 
quickShipEntireOrder) does not match expected requirements (Unknown parameter 
found: [quickShipEntireOrder.shipmentIds])]
{code}

Maybe they missing something ;)

> Add shipmentId list to quickshippurchaseorder return parameters
> ---
>
> Key: OFBIZ-9376
> URL: https://issues.apache.org/jira/browse/OFBIZ-9376
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Attachments: quickShipPurchaseOrder.patch
>
>
> The method " quickshippurchaseorder " allows to create a reception for every 
> ship group of a purchasing order. This method works correctly but it does not 
> return id of the receptions which it creates. The purpose of this patch is to 
> modify the service so that it returns the list of the receptions which it 
> creates
> To test this patch:
>  - Create a purchase order with several ships groups
>   - approve it
>  - from webtools execute the service " quickshippurchaseorder " with the 
> parameters: order Id: reference of order facilityId: WebStoreWarehouse
> results :
> The service returns the parameter shipmentIds



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9520) Unable to create user specific Invoice Term Id.

2017-07-22 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097407#comment-16097407
 ] 

Pierre Smits commented on OFBIZ-9520:
-

Hi [~akshay.modak],

You're patch seem to be heading into the right direction, but when an invoice 
is beyond the create stage it should not be possible to change the terms.

Thanks.

> Unable to create user specific Invoice Term Id.
> ---
>
> Key: OFBIZ-9520
> URL: https://issues.apache.org/jira/browse/OFBIZ-9520
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Akshay Modak
>Assignee: Akshay Modak
> Attachments: OFBIZ-9520.patch
>
>
> Steps to regenerate --
> 1. Login to accounting component.
> 2. Navigate to Invoice Terms screen.
> 3. Now try to input custom invoice term id and proceed to create.
> 4. Invoice Term will be created, but with sequenced id instead of with the 
> user specific invoice term id input by the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9520) Unable to create user specific Invoice Term Id.

2017-07-22 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097406#comment-16097406
 ] 

Pierre Smits commented on OFBIZ-9520:
-

So the easiest solution is to not allow the user to put his version of a term 
ID in, but just let the service assign it automatically.

> Unable to create user specific Invoice Term Id.
> ---
>
> Key: OFBIZ-9520
> URL: https://issues.apache.org/jira/browse/OFBIZ-9520
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Akshay Modak
>Assignee: Akshay Modak
> Attachments: OFBIZ-9520.patch
>
>
> Steps to regenerate --
> 1. Login to accounting component.
> 2. Navigate to Invoice Terms screen.
> 3. Now try to input custom invoice term id and proceed to create.
> 4. Invoice Term will be created, but with sequenced id instead of with the 
> user specific invoice term id input by the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8717) OFBIZ-7471: Improve all the service level error messages for missing required field for webtools component

2017-07-22 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097402#comment-16097402
 ] 

Nicolas Malin commented on OFBIZ-8717:
--

Ok I did it :
https://lists.apache.org/thread.html/56ded9051d9653ad8c7a985265c1a81eade4fe64c63425b7478350bf@%3Cdev.ofbiz.apache.org%3E


> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for webtools component
> --
>
> Key: OFBIZ-8717
> URL: https://issues.apache.org/jira/browse/OFBIZ-8717
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: 16.11.01
>Reporter: Jagpreet Kaur
>Assignee: Ritesh Kumar
>Priority: Minor
> Attachments: OFBIZ-8717.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8717) OFBIZ-7471: Improve all the service level error messages for missing required field for webtools component

2017-07-22 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097396#comment-16097396
 ] 

Nicolas Malin commented on OFBIZ-8717:
--

Hello, nice work, but before commit this I want start a thread related to 
service label in general. Please Wait :)

> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for webtools component
> --
>
> Key: OFBIZ-8717
> URL: https://issues.apache.org/jira/browse/OFBIZ-8717
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: 16.11.01
>Reporter: Jagpreet Kaur
>Assignee: Ritesh Kumar
>Priority: Minor
> Attachments: OFBIZ-8717.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9517) Error while Stock Move

2017-07-22 Thread Padmavati Rawat (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097365#comment-16097365
 ] 

Padmavati Rawat commented on OFBIZ-9517:


Tried to generate this issue once again, but unable to regenerate the issue. 
Thanks Priya for verifying. So, closing the ticket.

> Error while Stock Move
> --
>
> Key: OFBIZ-9517
> URL: https://issues.apache.org/jira/browse/OFBIZ-9517
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: priya sharma
>
> Steps:
> 1. Go to Facility Tab
> 2. Select Web Store Warehouse.
> 3. Navigate to Move Stock.
> 4. The error is shown on screen. See error log below.
> {code:java}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://product/widget/facility/FacilityScreens.xml#PickMoveStock]: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://product/widget/facility/CommonScreens.xml#CommonFacilityDecorator]:
>  org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null (The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null) (Error rendering 
> screen 
> [component://product/widget/facility/CommonScreens.xml#CommonFacilityDecorator]:
>  org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null (The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9517) Error while Stock Move

2017-07-22 Thread Padmavati Rawat (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Padmavati Rawat closed OFBIZ-9517.
--
Resolution: Cannot Reproduce

> Error while Stock Move
> --
>
> Key: OFBIZ-9517
> URL: https://issues.apache.org/jira/browse/OFBIZ-9517
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: priya sharma
>
> Steps:
> 1. Go to Facility Tab
> 2. Select Web Store Warehouse.
> 3. Navigate to Move Stock.
> 4. The error is shown on screen. See error log below.
> {code:java}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://product/widget/facility/FacilityScreens.xml#PickMoveStock]: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://product/widget/facility/CommonScreens.xml#CommonFacilityDecorator]:
>  org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null (The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null) (Error rendering 
> screen 
> [component://product/widget/facility/CommonScreens.xml#CommonFacilityDecorator]:
>  org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null (The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8843) Improvements in CommEventContentAssoc entity definition and services

2017-07-22 Thread Devanshu Vyas (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097346#comment-16097346
 ] 

Devanshu Vyas commented on OFBIZ-8843:
--

I have deleted the patch I uploaded a few minutes back. I will create a new 
patch and upload it soon.
Sorry, the confusion.

> Improvements in CommEventContentAssoc entity definition and services
> 
>
> Key: OFBIZ-8843
> URL: https://issues.apache.org/jira/browse/OFBIZ-8843
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-8843.patch
>
>
> Required improvements;
> - All is good with entity definition .
> - Add crud services using entity-auto (services_commevent.xml). Also remove 
> the existing services from ContentServices.xml. 
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As existing workflows are implemented to delete the records so use the 
> delete action for the same.
> - Need to convert Update and Delete services. Create can not be converted due 
> to some conditional code. Keep the existing services names as is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9520) Unable to create user specific Invoice Term Id.

2017-07-22 Thread Akshay Modak (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akshay Modak updated OFBIZ-9520:

Attachment: OFBIZ-9520.patch

> Unable to create user specific Invoice Term Id.
> ---
>
> Key: OFBIZ-9520
> URL: https://issues.apache.org/jira/browse/OFBIZ-9520
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Akshay Modak
>Assignee: Akshay Modak
> Attachments: OFBIZ-9520.patch
>
>
> Steps to regenerate --
> 1. Login to accounting component.
> 2. Navigate to Invoice Terms screen.
> 3. Now try to input custom invoice term id and proceed to create.
> 4. Invoice Term will be created, but with sequenced id instead of with the 
> user specific invoice term id input by the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8843) Improvements in CommEventContentAssoc entity definition and services

2017-07-22 Thread Devanshu Vyas (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devanshu Vyas updated OFBIZ-8843:
-
Attachment: (was: OFBIZ-8843.patch)

> Improvements in CommEventContentAssoc entity definition and services
> 
>
> Key: OFBIZ-8843
> URL: https://issues.apache.org/jira/browse/OFBIZ-8843
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-8843.patch
>
>
> Required improvements;
> - All is good with entity definition .
> - Add crud services using entity-auto (services_commevent.xml). Also remove 
> the existing services from ContentServices.xml. 
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As existing workflows are implemented to delete the records so use the 
> delete action for the same.
> - Need to convert Update and Delete services. Create can not be converted due 
> to some conditional code. Keep the existing services names as is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9290) Have the ability to edit/remove terms of an invoice

2017-07-22 Thread Akshay Modak (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akshay Modak updated OFBIZ-9290:

Attachment: OFBIZ-9290.patch

> Have the ability to edit/remove terms of an invoice
> ---
>
> Key: OFBIZ-9290
> URL: https://issues.apache.org/jira/browse/OFBIZ-9290
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
> Attachments: OFBIZ-9290.patch
>
>
> Currently the user has the ability to add terms to an invoice, but doesn't 
> have the functions to edit or remove existing terms.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Saurabh Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097308#comment-16097308
 ] 

Saurabh Dixit edited comment on OFBIZ-9501 at 7/22/17 2:14 PM:
---

Provided patch to move data from content component to datamodel component. In 
the patch we have moved the data which only belongs to content. For now leaving 
other data in the file.

Also I noticed that DataResource and ElectronicText exists in the seed data. On 
exploring I came to know that the data is for rendering the subcontent. Please 
suggest if we should consider it as demo or it is fine to have such data in 
seed/type data file.
Reference: OFBIZ-9501-003.patch


was (Author: saurabh.dixit):
Attached the third patch in the sequence for review. Moved data from content 
component under applications to datamodel component. Although, I'm not sure if 
we should move some of them to demo instead of seed, like DataResource and its 
associated ElectronicText for rendering standard sub content?

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9365) Screen rendering error on Content Advanced Search page

2017-07-22 Thread Sonal Patwari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sonal Patwari reassigned OFBIZ-9365:


Assignee: Sonal Patwari  (was: Aditya Sharma)

> Screen rendering error on Content Advanced Search page
> --
>
> Key: OFBIZ-9365
> URL: https://issues.apache.org/jira/browse/OFBIZ-9365
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Aditya Sharma
>Assignee: Sonal Patwari
>Priority: Trivial
> Attachments: screenshot-1.png
>
>
> Steps to reproduce:
> 1. Go to Content component 
> (https://demo-trunk.ofbiz.apache.org/content/control/main)
> 2. Click on Content from 
> submenu.(https://demo-trunk.ofbiz.apache.org/content/control/findContent)
> 3. Click on the Advanced Search button 
> (https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions).
> 4. Provide Content Id and click on Find button.
> It gives a ScreenRenderException.
> The error only occurs when Content Id is provided to refine the search.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Prakhar Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097334#comment-16097334
 ] 

Prakhar Kumar commented on OFBIZ-9501:
--

Thanks [~taher] and [~rishisolankii] for reviewing the patch and providing 
inputs. I have updated the patch with the suggested changes. I will check for 
the possibility and dependencies to move same in the Project component and will 
submit a separate patch for that. 

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8843) Improvements in CommEventContentAssoc entity definition and services

2017-07-22 Thread Devanshu Vyas (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devanshu Vyas updated OFBIZ-8843:
-
Attachment: OFBIZ-8843.patch

Renamed the service name and description to use expire instead of remove.

> Improvements in CommEventContentAssoc entity definition and services
> 
>
> Key: OFBIZ-8843
> URL: https://issues.apache.org/jira/browse/OFBIZ-8843
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-8843.patch, OFBIZ-8843.patch
>
>
> Required improvements;
> - All is good with entity definition .
> - Add crud services using entity-auto (services_commevent.xml). Also remove 
> the existing services from ContentServices.xml. 
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As existing workflows are implemented to delete the records so use the 
> delete action for the same.
> - Need to convert Update and Delete services. Create can not be converted due 
> to some conditional code. Keep the existing services names as is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9329) User should be notified with success message on successful completion of any action

2017-07-22 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9329:
-
Description: 
On performing any action, user should be notified with the success message if 
the action has been performed successfully.

Listing actions with no alert messages delivered on success and will be 
creating sub-tickets for the same.

Ecommerce:
1. Subscribe to Newsletter: OFBIZ-9320
2. Add to Cart: OFBIZ-9521
3. Create/Update Shopping List: OFBIZ-9522
4. Last Categories > Clear: 

Order Manager:
1. Update Quote: OFBIZ-9519
2. remove Quote Role:
3. Send Report by Mail from View Quote: OFBIZ-9321

 

  was:
On performing any action, user should be notified with the success message if 
the action has been performed successfully.

Listing actions with no alert messages delivered on success and will be 
creating sub-tickets for the same.

Ecommerce:
1. Subscribe to Newsletter: OFBIZ-9320
2. Add to Cart: OFBIZ-9521
3. Create/Update Shopping List:
4. Last Categories > Clear: 

Order Manager:
1. Update Quote: OFBIZ-9519
2. remove Quote Role:
3. Send Report by Mail from View Quote: OFBIZ-9321

 


> User should be notified with success message on successful completion of any 
> action
> ---
>
> Key: OFBIZ-9329
> URL: https://issues.apache.org/jira/browse/OFBIZ-9329
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>
> On performing any action, user should be notified with the success message if 
> the action has been performed successfully.
> Listing actions with no alert messages delivered on success and will be 
> creating sub-tickets for the same.
> Ecommerce:
> 1. Subscribe to Newsletter: OFBIZ-9320
> 2. Add to Cart: OFBIZ-9521
> 3. Create/Update Shopping List: OFBIZ-9522
> 4. Last Categories > Clear: 
> Order Manager:
> 1. Update Quote: OFBIZ-9519
> 2. remove Quote Role:
> 3. Send Report by Mail from View Quote: OFBIZ-9321
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9522) User should be notified with success message on creating shopping list in ecommerce component

2017-07-22 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-9522:


 Summary: User should be notified with success message on creating 
shopping list in ecommerce component
 Key: OFBIZ-9522
 URL: https://issues.apache.org/jira/browse/OFBIZ-9522
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Aditya Sharma
Priority: Trivial


Steps to regenerate:
1. Login to Ecommerce component 
(https://demo-trunk.ofbiz.apache.org/ecommerce/control/main).
2. Go to 
Shoppinglists.(https://localhost:8443/ecommerce/control/editShoppingList).
3. Click on Create new.
4. Fill all required fields and Click Save button
No success message on the successful action.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9462) On create order, the page shows orderview screen, but Url does not change. It shows processorder.

2017-07-22 Thread Lalit Kushwah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097294#comment-16097294
 ] 

Lalit Kushwah edited comment on OFBIZ-9462 at 7/22/17 1:49 PM:
---

I have tested the patch with OFBiz-16.11.We can backport to this.


was (Author: lalit.kushwah):
I have tested the patch with OFBiz-14.11.We can backport to this.

> On create order, the page shows orderview screen, but Url does not change. It 
> shows processorder.
> -
>
> Key: OFBIZ-9462
> URL: https://issues.apache.org/jira/browse/OFBIZ-9462
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Arun Patidar
>Priority: Minor
>  Labels: backport-needed
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9462.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Prakhar Kumar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prakhar Kumar updated OFBIZ-9501:
-
Attachment: OFBIZ-9501-002.patch

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-8273) Improvements in Lot entity definition and services

2017-07-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-8273.
---
   Resolution: Fixed
 Assignee: Arun Patidar
Fix Version/s: Upcoming Release

Committed changes at rev: 1802694

Thanks Rishi Solanki and Devanshu Vyas  for your contribution.

> Improvements in Lot entity definition and services
> --
>
> Key: OFBIZ-8273
> URL: https://issues.apache.org/jira/browse/OFBIZ-8273
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-8273.patch
>
>
> Required improvements;
>  - All is good with entity definition .
>  - Add CRUD services using entity-auto. Make sure PK is optional while create 
> service, so that can be generated from OFBiz sequence generator.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.
> Note: Require to change the delegator calls in ProductionRunServices.java and 
> InventoryServices.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9329) User should be notified with success message on successful completion of any action

2017-07-22 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9329:
-
Description: 
On performing any action, user should be notified with the success message if 
the action has been performed successfully.

Listing actions with no alert messages delivered on success and will be 
creating sub-tickets for the same.

Ecommerce:
1. Subscribe to Newsletter: OFBIZ-9320
2. Add to Cart: OFBIZ-9521
3. Create/Update Shopping List:
4. Last Categories > Clear: 

Order Manager:
1. Update Quote: OFBIZ-9519
2. remove Quote Role:
3. Send Report by Mail from View Quote: OFBIZ-9321

 

  was:
On performing any action, user should be notified with the success message if 
the action has been performed successfully.

Listing actions with no alert messages delivered on success and will be 
creating sub-tickets for the same.

Ecommerce:
1. Subscribe to Newsletter: OFBIZ-9320
2. Add to Cart: 
3. Create/Update Shopping List:
4. Last Categories > Clear: 

Order Manager:
1. Update Quote: OFBIZ-9519
2. remove Quote Role:
3. Send Report by Mail from View Quote: OFBIZ-9321

 


> User should be notified with success message on successful completion of any 
> action
> ---
>
> Key: OFBIZ-9329
> URL: https://issues.apache.org/jira/browse/OFBIZ-9329
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>
> On performing any action, user should be notified with the success message if 
> the action has been performed successfully.
> Listing actions with no alert messages delivered on success and will be 
> creating sub-tickets for the same.
> Ecommerce:
> 1. Subscribe to Newsletter: OFBIZ-9320
> 2. Add to Cart: OFBIZ-9521
> 3. Create/Update Shopping List:
> 4. Last Categories > Clear: 
> Order Manager:
> 1. Update Quote: OFBIZ-9519
> 2. remove Quote Role:
> 3. Send Report by Mail from View Quote: OFBIZ-9321
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9521) User should be notified with success message on add to cart action in ecommerce component

2017-07-22 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-9521:


 Summary: User should be notified with success message on add to 
cart action in ecommerce component
 Key: OFBIZ-9521
 URL: https://issues.apache.org/jira/browse/OFBIZ-9521
 Project: OFBiz
  Issue Type: Sub-task
  Components: ecommerce
Affects Versions: Trunk
Reporter: Aditya Sharma
Priority: Trivial


Steps to regenerate:
1. Go to Ecommerce component 
(https://demo-trunk.ofbiz.apache.org/ecommerce/control/main).
2. Click Add To Cart for any product.
No success message on successful action.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9519) User should be notified with success message on Update Quote page

2017-07-22 Thread Sonal Patwari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sonal Patwari updated OFBIZ-9519:
-
Attachment: OFBIZ-9519.patch

Provided patch in the attachment.
Solution : Created a new uiLabel to print success message and returned it as 
success message from 'updateQuote' service.

> User should be notified with success message on Update Quote page
> -
>
> Key: OFBIZ-9519
> URL: https://issues.apache.org/jira/browse/OFBIZ-9519
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Sonal Patwari
>Priority: Minor
> Attachments: OFBIZ-9519.patch
>
>
> Steps to regenerate:
> 1. Go to Order component (https://localhost:8443/ordermgr/control/main)
> 2. Click on Quotes submenu (directing to 
> https://localhost:8443/ordermgr/control/FindQuote)
> 3. Click on Find button.
> 4. Click on any quoteId (directing to 
> https://localhost:8443/ordermgr/control/ViewQuote?quoteId=CQ0001)
> 5. Click on Quote link from the submenu 
> (https://localhost:8443/ordermgr/control/EditQuote?quoteId=CQ0001)
> 6. Make changes and Click on Submit button.
> No success message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9517) Error while Stock Move

2017-07-22 Thread priya sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097320#comment-16097320
 ] 

priya sharma commented on OFBIZ-9517:
-

Unable to regenerate the issue with the steps mentioned above.
Hence we can close this ticket.

> Error while Stock Move
> --
>
> Key: OFBIZ-9517
> URL: https://issues.apache.org/jira/browse/OFBIZ-9517
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: priya sharma
>
> Steps:
> 1. Go to Facility Tab
> 2. Select Web Store Warehouse.
> 3. Navigate to Move Stock.
> 4. The error is shown on screen. See error log below.
> {code:java}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://product/widget/facility/FacilityScreens.xml#PickMoveStock]: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://product/widget/facility/CommonScreens.xml#CommonFacilityDecorator]:
>  org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null (The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null) (Error rendering 
> screen 
> [component://product/widget/facility/CommonScreens.xml#CommonFacilityDecorator]:
>  org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null (The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9496) MySql Database related warning related to DATETIME filed

2017-07-22 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097317#comment-16097317
 ] 

Deepak Dixit commented on OFBIZ-9496:
-

Slightly modified patch has been committed at ofbiz framework trunk at r#1802693
- Removed formatting
- Use OR instead of AND while checking DATETIME/TIME field.


> MySql Database related warning related to DATETIME filed
> 
>
> Key: OFBIZ-9496
> URL: https://issues.apache.org/jira/browse/OFBIZ-9496
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9496.patch
>
>
> Here are the following warnings that we are getting for all the datetime 
> related filed.
> this is due to incorrect handling of database filed type comparison in 
> DatabaseUtil.java
> {code}
> 2017-07-18 12:30:19,137 |OFBiz-batch-2|DatabaseUtil  
> |W| Column [LAST_UPDATED_TX_STAMP] of table [RUNTIME_DATA] of entity 
> [RuntimeData] has a column size of [19] in the database, but is defined to 
> have a column size of [3] in the entity definition.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-7275) Adding condition in price rule on 'Role Type' showing incorrect result

2017-07-22 Thread Pranay Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey resolved OFBIZ-7275.
--
Resolution: Fixed

Patch committed to trunk at r1802690 and R16.11 at r1802691 and r1802692.

Thanks [~aditi17] for reporting and providing the patch.

> Adding condition in price rule on 'Role Type' showing incorrect result
> --
>
> Key: OFBIZ-7275
> URL: https://issues.apache.org/jira/browse/OFBIZ-7275
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditi Patidar
>Assignee: Pranay Pandey
>Priority: Minor
> Attachments: OFBIZ-7275.patch, OFBIZ-7275.png
>
>
> Steps to regenerate issue:
> 1. Create a price rule or open an existing one.
> 2. Add a condition, select input 'Role Type', operator 'Is' and select the 
> value 'Customer'.
> Expected Result: For added condition value should be 'Customer'.
> Actual Result: It's showing value 'Ship-To Customer'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-7275) Adding condition in price rule on 'Role Type' showing incorrect result

2017-07-22 Thread Pranay Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey closed OFBIZ-7275.


> Adding condition in price rule on 'Role Type' showing incorrect result
> --
>
> Key: OFBIZ-7275
> URL: https://issues.apache.org/jira/browse/OFBIZ-7275
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditi Patidar
>Assignee: Pranay Pandey
>Priority: Minor
> Attachments: OFBIZ-7275.patch, OFBIZ-7275.png
>
>
> Steps to regenerate issue:
> 1. Create a price rule or open an existing one.
> 2. Add a condition, select input 'Role Type', operator 'Is' and select the 
> value 'Customer'.
> Expected Result: For added condition value should be 'Customer'.
> Actual Result: It's showing value 'Ship-To Customer'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9489) Add new Rule Based Number Format for Indian Number System in International Components for Unicode (ICU) OFBiz usage.

2017-07-22 Thread Pradhan Yash Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma reassigned OFBIZ-9489:
--

Assignee: Pradhan Yash Sharma

> Add new Rule Based Number Format for Indian Number System in International 
> Components for Unicode (ICU) OFBiz usage.
> 
>
> Key: OFBIZ-9489
> URL: https://issues.apache.org/jira/browse/OFBIZ-9489
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: 16.11.03
>Reporter: Pradhan Yash Sharma
>Assignee: Pradhan Yash Sharma
>Priority: Minor
> Attachments: OFBIZ-9489.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9489) Add new Rule Based Number Format for Indian Number System in International Components for Unicode (ICU) OFBiz usage.

2017-07-22 Thread Pradhan Yash Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradhan Yash Sharma updated OFBIZ-9489:
---
Attachment: OFBIZ-9489.patch

> Add new Rule Based Number Format for Indian Number System in International 
> Components for Unicode (ICU) OFBiz usage.
> 
>
> Key: OFBIZ-9489
> URL: https://issues.apache.org/jira/browse/OFBIZ-9489
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: 16.11.03
>Reporter: Pradhan Yash Sharma
>Assignee: Pradhan Yash Sharma
>Priority: Minor
> Attachments: OFBIZ-9489.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9496) MySql Database related warning related to DATETIME filed

2017-07-22 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-9496:
---

Assignee: Deepak Dixit

> MySql Database related warning related to DATETIME filed
> 
>
> Key: OFBIZ-9496
> URL: https://issues.apache.org/jira/browse/OFBIZ-9496
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9496.patch
>
>
> Here are the following warnings that we are getting for all the datetime 
> related filed.
> this is due to incorrect handling of database filed type comparison in 
> DatabaseUtil.java
> {code}
> 2017-07-18 12:30:19,137 |OFBiz-batch-2|DatabaseUtil  
> |W| Column [LAST_UPDATED_TX_STAMP] of table [RUNTIME_DATA] of entity 
> [RuntimeData] has a column size of [19] in the database, but is defined to 
> have a column size of [3] in the entity definition.
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-7275) Adding condition in price rule on 'Role Type' showing incorrect result

2017-07-22 Thread Pranay Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey updated OFBIZ-7275:
-
Summary: Adding condition in price rule on 'Role Type' showing incorrect 
result  (was: Adding condition in price rule on 'Role Type' shown incorrect 
result)

> Adding condition in price rule on 'Role Type' showing incorrect result
> --
>
> Key: OFBIZ-7275
> URL: https://issues.apache.org/jira/browse/OFBIZ-7275
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditi Patidar
>Assignee: Pranay Pandey
>Priority: Minor
> Attachments: OFBIZ-7275.patch, OFBIZ-7275.png
>
>
> Steps to regenerate issue:
> 1. Create a price rule or open an existing one.
> 2. Add a condition, select input 'Role Type', operator 'Is' and select the 
> value 'Customer'.
> Expected Result: For added condition value should be 'Customer'.
> Actual Result: It's showing value 'Ship-To Customer'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread sourabh jain (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097311#comment-16097311
 ] 

sourabh jain commented on OFBIZ-9501:
-

Moved product type data from product component to datamodel component. Attached 
fourth patch in the sequence for review. 

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9468) UI issue in ATP/QOH table on Create Purchase Order screen

2017-07-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-9468.
-
   Resolution: Fixed
Fix Version/s: (was: Upcoming Release)
   16.11.04

Back ported at rev: 1802689.

Thanks Prasheel for your contribution.

> UI issue in ATP/QOH table on Create Purchase Order screen
> -
>
> Key: OFBIZ-9468
> URL: https://issues.apache.org/jira/browse/OFBIZ-9468
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Assignee: Arun Patidar
>Priority: Minor
>  Labels: backport-needed
> Fix For: 16.11.04
>
> Attachments: atp-qoh-table-issue.png, OFBIZ-9468.patch
>
>
> *Steps to regenerate -*
> 1. Go to "Order" component.
> 2. Click on [ Order Entry ] menu button.
> 3. Fill the details in "Purchase Order" section and click on continue.
> 4. Fill the required order details and click on continue.
> 5. Open the product lookup table and select a product.
> 6. Click on [ Atp/Qoh ] button.
> The issue generated is-
> The table showing ATP and QOH is not in proper format.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Saurabh Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097308#comment-16097308
 ] 

Saurabh Dixit commented on OFBIZ-9501:
--

Attached the third patch in the sequence for review. Moved data from content 
component under applications to datamodel component. Although, I'm not sure if 
we should move some of them to demo instead of seed, like DataResource and its 
associated ElectronicText for rendering standard sub content?

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9456) Required check missing for Routing Task Name on Add Routing Task page

2017-07-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-9456.
-
   Resolution: Fixed
Fix Version/s: (was: Upcoming Release)
   16.11.04

Back ported changes at rev: 1802687.

> Required check missing for Routing Task Name on Add Routing Task page
> -
>
> Key: OFBIZ-9456
> URL: https://issues.apache.org/jira/browse/OFBIZ-9456
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Reporter: Aditya Sharma
>Assignee: Arun Patidar
>Priority: Trivial
>  Labels: backport-needed
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9456.patch, screenshot-1.png
>
>
> Steps to reproduce:
> 1. Log in to Manufacturing component 
> (https://demo-trunk.ofbiz.apache.org/manufacturing/control/main)
> 2. Go to the Routing Task tab. 
> (https://demo-trunk.ofbiz.apache.org/manufacturing/control/FindRoutingTask)
> 3. Click on New Routing Task 
> button.(https://demo-trunk.ofbiz.apache.org/manufacturing/control/EditRoutingTask)
> 4. Click Create button on Add Routing Task page.
> No required validation so an error message from the service.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9462) On create order, the page shows orderview screen, but Url does not change. It shows processorder.

2017-07-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-9462.
-
   Resolution: Fixed
Fix Version/s: (was: Upcoming Release)
   16.11.04

Back ported to 16.11 release at rev: 1802686.

Thanks Lalit for verifying.

> On create order, the page shows orderview screen, but Url does not change. It 
> shows processorder.
> -
>
> Key: OFBIZ-9462
> URL: https://issues.apache.org/jira/browse/OFBIZ-9462
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Arun Patidar
>Priority: Minor
>  Labels: backport-needed
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9462.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread sourabh jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

sourabh jain updated OFBIZ-9501:

Attachment: OFBIZ-9051-004.patch

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-7275) Adding condition in price rule on 'Role Type' shown incorrect result

2017-07-22 Thread Pranay Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey updated OFBIZ-7275:
-
Affects Version/s: Release Branch 16.11

> Adding condition in price rule on 'Role Type' shown incorrect result
> 
>
> Key: OFBIZ-7275
> URL: https://issues.apache.org/jira/browse/OFBIZ-7275
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditi Patidar
>Assignee: Pranay Pandey
>Priority: Minor
> Attachments: OFBIZ-7275.patch, OFBIZ-7275.png
>
>
> Steps to regenerate issue:
> 1. Create a price rule or open an existing one.
> 2. Add a condition, select input 'Role Type', operator 'Is' and select the 
> value 'Customer'.
> Expected Result: For added condition value should be 'Customer'.
> Actual Result: It's showing value 'Ship-To Customer'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8487) Content : Remove unused imports from groovy files for code optimization.

2017-07-22 Thread Pradeep Choudhary (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097304#comment-16097304
 ] 

Pradeep Choudhary commented on OFBIZ-8487:
--

Sure Sir, I will review the patch again and will update it.

> Content : Remove unused imports from groovy files for code optimization.
> 
>
> Key: OFBIZ-8487
> URL: https://issues.apache.org/jira/browse/OFBIZ-8487
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-8487.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Prakhar Kumar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prakhar Kumar updated OFBIZ-9501:
-
Attachment: (was: OFBIZ-9501-002.patch)

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9518) Wrong success message after creating lead in sfa component

2017-07-22 Thread Parakh Maheshwari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Parakh Maheshwari reassigned OFBIZ-9518:


Assignee: Parakh Maheshwari

> Wrong success message after creating lead in sfa component
> --
>
> Key: OFBIZ-9518
> URL: https://issues.apache.org/jira/browse/OFBIZ-9518
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Jagpreet Kaur
>Assignee: Parakh Maheshwari
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. Click on "Create New" 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/NewLead].
> 4. Fill the required details and click on "Save" button.
> After the successful creation, it displays success message "Party Role 
> created successfully." instead it should be "Lead created successfully."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9329) User should be notified with success message on successful completion of any action

2017-07-22 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9329:
-
Description: 
On performing any action, user should be notified with the success message if 
the action has been performed successfully.

Listing actions with no alert messages delivered on success and will be 
creating sub-tickets for the same.

Ecommerce:
1. Subscribe to Newsletter: OFBIZ-9320
2. Add to Cart: 
3. Create/Update Shopping List:
4. Last Categories > Clear: 

Order Manager:
1. Update Quote: OFBIZ-9519
2. remove Quote Role:
3. Send Report by Mail from View Quote: OFBIZ-9321

 

  was:
On performing any action, user should be notified with the success message if 
the action has been performed successfully.

Listing actions with no alert messages delivered on success and will be 
creating sub-tickets for the same.

Ecommerce:
1. Subscribe to Newsletter: OFBIZ-9320
2. Add to Cart: 
3. Create/Update Shopping List:
4. Last Categories > Clear: 

Order Manager:
1. Update Quote:
2. remove Quote Role:
3. Send Report by Mail from View Quote: OFBIZ-9321

 


> User should be notified with success message on successful completion of any 
> action
> ---
>
> Key: OFBIZ-9329
> URL: https://issues.apache.org/jira/browse/OFBIZ-9329
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>
> On performing any action, user should be notified with the success message if 
> the action has been performed successfully.
> Listing actions with no alert messages delivered on success and will be 
> creating sub-tickets for the same.
> Ecommerce:
> 1. Subscribe to Newsletter: OFBIZ-9320
> 2. Add to Cart: 
> 3. Create/Update Shopping List:
> 4. Last Categories > Clear: 
> Order Manager:
> 1. Update Quote: OFBIZ-9519
> 2. remove Quote Role:
> 3. Send Report by Mail from View Quote: OFBIZ-9321
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9520) Unable to create user specific Invoice Term Id.

2017-07-22 Thread Akshay Modak (JIRA)
Akshay Modak created OFBIZ-9520:
---

 Summary: Unable to create user specific Invoice Term Id.
 Key: OFBIZ-9520
 URL: https://issues.apache.org/jira/browse/OFBIZ-9520
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Reporter: Akshay Modak
Assignee: Akshay Modak


Steps to regenerate --

1. Login to accounting component.
2. Navigate to Invoice Terms screen.
3. Now try to input custom invoice term id and proceed to create.
4. Invoice Term will be created, but with sequenced id instead of with the user 
specific invoice term id input by the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9517) Error while Stock Move

2017-07-22 Thread priya sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

priya sharma reassigned OFBIZ-9517:
---

Assignee: priya sharma

> Error while Stock Move
> --
>
> Key: OFBIZ-9517
> URL: https://issues.apache.org/jira/browse/OFBIZ-9517
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: priya sharma
>
> Steps:
> 1. Go to Facility Tab
> 2. Select Web Store Warehouse.
> 3. Navigate to Move Stock.
> 4. The error is shown on screen. See error log below.
> {code:java}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://product/widget/facility/FacilityScreens.xml#PickMoveStock]: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://product/widget/facility/CommonScreens.xml#CommonFacilityDecorator]:
>  org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null (The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null) (Error rendering 
> screen 
> [component://product/widget/facility/CommonScreens.xml#CommonFacilityDecorator]:
>  org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null (The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [findStockMovesNeeded]: Cannot compare: r-value is null))
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9476) UI issue in payment lookup.

2017-07-22 Thread Ashish Vijaywargiya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-9476:
--

Assignee: Ashish Vijaywargiya  (was: Pallavi Goyal)

> UI issue in payment lookup.
> ---
>
> Key: OFBIZ-9476
> URL: https://issues.apache.org/jira/browse/OFBIZ-9476
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9476.patch, payment-lookup-ui-issue.png
>
>
> *Steps to regenerate -*
> 1. Go to "Accounting - AR" component.
> 2. Click on [ Invoices ] menu tab.
> 3. Open any invoice whose status is not "Paid" or "Ready for posting".
> 4. Click on [ Applications ] sub-menu tab.
> 5. Open the "Payment Lookup".
> Actual - The column headers of List Payments table are not in format and 
> therefore the list of payments is also not displayed.
> Expected - The columns should be in proper tabular format and the list should 
> be displayed upon find.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9468) UI issue in ATP/QOH table on Create Purchase Order screen

2017-07-22 Thread Prasheel Soni (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097299#comment-16097299
 ] 

Prasheel Soni commented on OFBIZ-9468:
--

We can backport changes to OFBIZ 16.11. I have verified the provided patch.

> UI issue in ATP/QOH table on Create Purchase Order screen
> -
>
> Key: OFBIZ-9468
> URL: https://issues.apache.org/jira/browse/OFBIZ-9468
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Assignee: Arun Patidar
>Priority: Minor
>  Labels: backport-needed
> Fix For: Upcoming Release
>
> Attachments: atp-qoh-table-issue.png, OFBIZ-9468.patch
>
>
> *Steps to regenerate -*
> 1. Go to "Order" component.
> 2. Click on [ Order Entry ] menu button.
> 3. Fill the details in "Purchase Order" section and click on continue.
> 4. Fill the required order details and click on continue.
> 5. Open the product lookup table and select a product.
> 6. Click on [ Atp/Qoh ] button.
> The issue generated is-
> The table showing ATP and QOH is not in proper format.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9519) User should be notified with success message on Update Quote page

2017-07-22 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-9519:


 Summary: User should be notified with success message on Update 
Quote page
 Key: OFBIZ-9519
 URL: https://issues.apache.org/jira/browse/OFBIZ-9519
 Project: OFBiz
  Issue Type: Sub-task
  Components: order
Affects Versions: Trunk
Reporter: Aditya Sharma
Assignee: Sonal Patwari
Priority: Minor


Steps to regenerate:
1. Go to Order component (https://localhost:8443/ordermgr/control/main)
2. Click on Quotes submenu (directing to 
https://localhost:8443/ordermgr/control/FindQuote)
3. Click on Find button.
4. Click on any quoteId (directing to 
https://localhost:8443/ordermgr/control/ViewQuote?quoteId=CQ0001)
5. Click on Quote link from the submenu 
(https://localhost:8443/ordermgr/control/EditQuote?quoteId=CQ0001)
6. Make changes and Click on Submit button.
No success message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8718) OFBIZ-7471: Improve all the service level error messages for missing required field for SpecialPurpose/ebay component

2017-07-22 Thread Anushi Gupta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anushi Gupta updated OFBIZ-8718:

Attachment: OFBIZ-8718.patch

Attaching patch for this issue.

> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for SpecialPurpose/ebay component
> -
>
> Key: OFBIZ-8718
> URL: https://issues.apache.org/jira/browse/OFBIZ-8718
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: 16.11.01
>Reporter: Jagpreet Kaur
>Priority: Minor
> Attachments: OFBIZ-8718.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9447) Improve groovy DSL : resolve automatic pk field for entity one

2017-07-22 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097297#comment-16097297
 ] 

Deepak Dixit commented on OFBIZ-9447:
-

Thanks Nicolas :)

> Improve groovy DSL : resolve automatic pk field for entity one
> --
>
> Key: OFBIZ-9447
> URL: https://issues.apache.org/jira/browse/OFBIZ-9447
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9447.patch, OFBIZ-9447-sol1.patch, 
> OFBIZ-9447-sol2.patch
>
>
> Like the element entity-one on mini-lang that can resolve automatically the 
> pk field from context, I propose like explain on the thread 
> https://lists.apache.org/thread.html/5d2c0ac2e0e6a3a8ce13050e9b2d573e82adabbf0067428d087e48c1@%3Cdev.ofbiz.apache.org%3E
>  to use the following syntax :
> {code}
> GenericValue product = from('Product').where(context).queryOne()
> {code}
> This issue provides two solution to extend the EntityQuery class linked to 
> the from groovy dsl syntax



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9516) User should be notified with success message on Creating New Routing

2017-07-22 Thread Sonal Patwari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sonal Patwari updated OFBIZ-9516:
-
Attachment: OFBIZ-9516.patch

Provided patch in the attachment.
Solution : Created a new uiLabel to print success message and returned it as 
success message from 'createWorkEffort' service.

> User should be notified with success message on Creating New Routing
> 
>
> Key: OFBIZ-9516
> URL: https://issues.apache.org/jira/browse/OFBIZ-9516
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Sonal Patwari
>Priority: Trivial
> Attachments: OFBIZ-9516.patch
>
>
> Steps to regenerate:
> 1. Go to Manufacturing component 
> (https://localhost:8443/manufacturing/control/main)
> 2. Click on Routing sub menu 
> (https://localhost:8443/manufacturing/control/FindRouting)
> 3. Click on New Routing 
> button.(https://localhost:8443/manufacturing/control/EditRouting)
> 4. Fill required fields and Click Submit button.
> 7. On success, the user should be notified with success message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9447) Improve groovy DSL : resolve automatic pk field for entity one

2017-07-22 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-9447.

Resolution: Fixed

> Improve groovy DSL : resolve automatic pk field for entity one
> --
>
> Key: OFBIZ-9447
> URL: https://issues.apache.org/jira/browse/OFBIZ-9447
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9447.patch, OFBIZ-9447-sol1.patch, 
> OFBIZ-9447-sol2.patch
>
>
> Like the element entity-one on mini-lang that can resolve automatically the 
> pk field from context, I propose like explain on the thread 
> https://lists.apache.org/thread.html/5d2c0ac2e0e6a3a8ce13050e9b2d573e82adabbf0067428d087e48c1@%3Cdev.ofbiz.apache.org%3E
>  to use the following syntax :
> {code}
> GenericValue product = from('Product').where(context).queryOne()
> {code}
> This issue provides two solution to extend the EntityQuery class linked to 
> the from groovy dsl syntax



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9447) Improve groovy DSL : resolve automatic pk field for entity one

2017-07-22 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097295#comment-16097295
 ] 

Nicolas Malin commented on OFBIZ-9447:
--

Hey! GG Deepak!
I committed your patch on trunk at 1802684
Thanks a lots.
(PS: GG is an abbreviation for Good Game for Gamer :))

> Improve groovy DSL : resolve automatic pk field for entity one
> --
>
> Key: OFBIZ-9447
> URL: https://issues.apache.org/jira/browse/OFBIZ-9447
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9447.patch, OFBIZ-9447-sol1.patch, 
> OFBIZ-9447-sol2.patch
>
>
> Like the element entity-one on mini-lang that can resolve automatically the 
> pk field from context, I propose like explain on the thread 
> https://lists.apache.org/thread.html/5d2c0ac2e0e6a3a8ce13050e9b2d573e82adabbf0067428d087e48c1@%3Cdev.ofbiz.apache.org%3E
>  to use the following syntax :
> {code}
> GenericValue product = from('Product').where(context).queryOne()
> {code}
> This issue provides two solution to extend the EntityQuery class linked to 
> the from groovy dsl syntax



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9462) On create order, the page shows orderview screen, but Url does not change. It shows processorder.

2017-07-22 Thread Lalit Kushwah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097294#comment-16097294
 ] 

Lalit Kushwah commented on OFBIZ-9462:
--

I have tested the patch with OFBiz-14.11.We can backport to this.

> On create order, the page shows orderview screen, but Url does not change. It 
> shows processorder.
> -
>
> Key: OFBIZ-9462
> URL: https://issues.apache.org/jira/browse/OFBIZ-9462
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Arun Patidar
>Priority: Minor
>  Labels: backport-needed
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9462.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9518) Wrong success message after creating lead in sfa component

2017-07-22 Thread Jagpreet Kaur (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jagpreet Kaur updated OFBIZ-9518:
-
Attachment: screenshot-1.png

> Wrong success message after creating lead in sfa component
> --
>
> Key: OFBIZ-9518
> URL: https://issues.apache.org/jira/browse/OFBIZ-9518
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Jagpreet Kaur
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. Click on "Create New" 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/NewLead].
> 4. Fill the required details and click on "Save" button.
> After the successful creation, it displays success message "Party Role 
> created successfully." instead it should be "Lead created successfully."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9253) Order contact mechs are not copied over while re-ordering an order

2017-07-22 Thread Ashish Vijaywargiya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-9253.
--
   Resolution: Fixed
Fix Version/s: Upcoming Release

Thanks Suraj for the contribution.
Your changes are committed in trunk at r1802683.

> Order contact mechs are not copied over while re-ordering an order
> --
>
> Key: OFBIZ-9253
> URL: https://issues.apache.org/jira/browse/OFBIZ-9253
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Suraj Khurana
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9253.patch
>
>
> Place an order and click on create as new order button on order detail page.
> All the information is properly copied over to that order but email contact 
> mechs are not copied to newly created order.
> If a user has added those emails in previous order, then they should also be 
> copied over while re-ordering.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9513) Not able to change Portal Page Sequence on preferences section of SFA Component

2017-07-22 Thread Praveen Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma reassigned OFBIZ-9513:
-

Assignee: Praveen Sharma

> Not able to change Portal Page Sequence on preferences section of SFA 
> Component
> ---
>
> Key: OFBIZ-9513
> URL: https://issues.apache.org/jira/browse/OFBIZ-9513
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Parakh Maheshwari
>Assignee: Praveen Sharma
> Attachments: screenshot-1.png
>
>
> Here are the steps to generate the issue:
> 1.Navigate to  
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main?externalLoginKey=ELa07b118d-1e90-421a-adae-f7ab0b5bbe22].
> 2.Click on Preferences link in 
> sub-menu.[https://demo-trunk.ofbiz.apache.org/sfa/control/ManagePortalPages?parentPortalPageId=SFA_MAIN].
> 3.If there is a single portal page, then create more than one page to 
> generate the issue.
> 4.Click on the green arrow button on any page to change its sequence, It show 
> error message on screen.
> Note All the arrow buttons are not working (whether It is single step down or 
> multiple step down or up button)
> I am also attaching the screenshot for the same. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9518) Wrong success message after creating lead in sfa component

2017-07-22 Thread Jagpreet Kaur (JIRA)
Jagpreet Kaur created OFBIZ-9518:


 Summary: Wrong success message after creating lead in sfa component
 Key: OFBIZ-9518
 URL: https://issues.apache.org/jira/browse/OFBIZ-9518
 Project: OFBiz
  Issue Type: Bug
  Components: marketing
Reporter: Jagpreet Kaur


Steps to regenerate:
1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
2. Click on the Lead link in sub menu 
[https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
3. Click on "Create New" 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/NewLead].
4. Fill the required details and click on "Save" button.

After the successful creation, it displays success message "Party Role created 
successfully." instead it should be "Lead created successfully."




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9253) Order contact mechs are not copied over while re-ordering an order

2017-07-22 Thread Ashish Vijaywargiya (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097289#comment-16097289
 ] 

Ashish Vijaywargiya commented on OFBIZ-9253:


Hello Suraj,

The suggestions from Pierre can be a good improvement. For now, I am committing 
this patch. I request you to create a new Jira issue for the mentioned comment 
so that we can take care of the improvements in near future.

> Order contact mechs are not copied over while re-ordering an order
> --
>
> Key: OFBIZ-9253
> URL: https://issues.apache.org/jira/browse/OFBIZ-9253
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Suraj Khurana
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Attachments: OFBIZ-9253.patch
>
>
> Place an order and click on create as new order button on order detail page.
> All the information is properly copied over to that order but email contact 
> mechs are not copied to newly created order.
> If a user has added those emails in previous order, then they should also be 
> copied over while re-ordering.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9378) set auto completion only in lookup field

2017-07-22 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-9378.

   Resolution: Implemented
Fix Version/s: Upcoming Release

It's ok for me, I change juste autocompletion-only by none to have a good 
relation between the name and the display result.

It's in trunk at revision 1802682

> set auto completion only in lookup field
> 
>
> Key: OFBIZ-9378
> URL: https://issues.apache.org/jira/browse/OFBIZ-9378
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: lookup-autocompletion-only.patch
>
>
>  The puspose of this patch is to allow to generate only the auto-completion 
> on a lookup and to remove lookup icon. Indeed, often the auto-completion is 
> sufficient and the lookup of search is not used. By putting as value " 
> autocompletion-only " in the attribute "presentation" of the tag " lookup ", 
> only the auto-completion is active.
> 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9378) set auto completion only in lookup field

2017-07-22 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-9378:


Assignee: Nicolas Malin

> set auto completion only in lookup field
> 
>
> Key: OFBIZ-9378
> URL: https://issues.apache.org/jira/browse/OFBIZ-9378
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: lookup-autocompletion-only.patch
>
>
>  The puspose of this patch is to allow to generate only the auto-completion 
> on a lookup and to remove lookup icon. Indeed, often the auto-completion is 
> sufficient and the lookup of search is not used. By putting as value " 
> autocompletion-only " in the attribute "presentation" of the tag " lookup ", 
> only the auto-completion is active.
> 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9281) Code Improvement on Product Config

2017-07-22 Thread Ashish Vijaywargiya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-9281.
--
   Resolution: Fixed
Fix Version/s: Upcoming Release

Thanks Suraj for the contribution.
Changes are committed in trunk at r1802681.

> Code Improvement on Product Config
> --
>
> Key: OFBIZ-9281
> URL: https://issues.apache.org/jira/browse/OFBIZ-9281
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9281.patch
>
>
> I noticed a couple of code improvements on product config current code. Here 
> is the reference:
> - In ProductConfigWorker.fillProductConfigWrapper() method, currently, we 
> only check parameters map, while it is possible in a business environment 
> that user can submit required fields values in request attributes as well. So 
> here getCombinedMap method can be used to make it more efficient.
> - While calling constructor of ConfigOption (ConfigOption(ConfigOption co)), 
> some private members should also be copied, like componentOptions etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

2017-07-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9459:

Fix Version/s: (was: Upcoming Release)
   16.11.04

> Wrong screen redirection after adding note on Lead profile screen
> -
>
> Key: OFBIZ-9459
> URL: https://issues.apache.org/jira/browse/OFBIZ-9459
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Jagpreet Kaur
>Assignee: Arun Patidar
>  Labels: backport-needed
> Fix For: 16.11.04
>
> Attachments: Create Note.png, OFBIZ-9459.patch, Screenredirection.png
>
>
> 1) Go to SFA component.
> 2) Click on Leads tab 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads].
> 3) Choose any partyId from All Lead list, you will be navigated to Lead 
> profile. 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=LEAD&partyId=DemoLead]
> 4) Click on "Create New" button in the Notes section.
> 5) Add the Note content.
> 6) Click on "Save Button".
> View redirection should be profile but it shows the blank screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9517) Error while Stock Move

2017-07-22 Thread Padmavati Rawat (JIRA)
Padmavati Rawat created OFBIZ-9517:
--

 Summary: Error while Stock Move
 Key: OFBIZ-9517
 URL: https://issues.apache.org/jira/browse/OFBIZ-9517
 Project: OFBiz
  Issue Type: Bug
Affects Versions: Trunk
Reporter: Padmavati Rawat


Steps:
1. Go to Facility Tab
2. Select Web Store Warehouse.
3. Navigate to Move Stock.
4. The error is shown on screen. See error log below.


{code:java}
ERROR rendering error page [/error/error.jsp], but here is the error text: 
org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://product/widget/facility/FacilityScreens.xml#PickMoveStock]: 
org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://product/widget/facility/CommonScreens.xml#CommonFacilityDecorator]:
 org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
transaction is marked for rollback, not beginning a new transaction and 
aborting current operation; the rollbackOnly was caused by: Error in Service 
[findStockMovesNeeded]: Cannot compare: r-value is null (The current 
transaction is marked for rollback, not beginning a new transaction and 
aborting current operation; the rollbackOnly was caused by: Error in Service 
[findStockMovesNeeded]: Cannot compare: r-value is null) (Error rendering 
screen 
[component://product/widget/facility/CommonScreens.xml#CommonFacilityDecorator]:
 org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
transaction is marked for rollback, not beginning a new transaction and 
aborting current operation; the rollbackOnly was caused by: Error in Service 
[findStockMovesNeeded]: Cannot compare: r-value is null (The current 
transaction is marked for rollback, not beginning a new transaction and 
aborting current operation; the rollbackOnly was caused by: Error in Service 
[findStockMovesNeeded]: Cannot compare: r-value is null))
{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

2017-07-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-9459.
-
Resolution: Fixed

Back ported in 16.11 at rev: 1802679.

Thanks Prasheel for your contribution.

> Wrong screen redirection after adding note on Lead profile screen
> -
>
> Key: OFBIZ-9459
> URL: https://issues.apache.org/jira/browse/OFBIZ-9459
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Jagpreet Kaur
>Assignee: Arun Patidar
>  Labels: backport-needed
> Fix For: Upcoming Release
>
> Attachments: Create Note.png, OFBIZ-9459.patch, Screenredirection.png
>
>
> 1) Go to SFA component.
> 2) Click on Leads tab 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads].
> 3) Choose any partyId from All Lead list, you will be navigated to Lead 
> profile. 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=LEAD&partyId=DemoLead]
> 4) Click on "Create New" button in the Notes section.
> 5) Add the Note content.
> 6) Click on "Save Button".
> View redirection should be profile but it shows the blank screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

2017-07-22 Thread Prasheel Soni (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097284#comment-16097284
 ] 

Prasheel Soni commented on OFBIZ-9459:
--

We can backport changes to OFBIZ 16.11. I have verified the provided patch.

> Wrong screen redirection after adding note on Lead profile screen
> -
>
> Key: OFBIZ-9459
> URL: https://issues.apache.org/jira/browse/OFBIZ-9459
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Jagpreet Kaur
>Assignee: Arun Patidar
>  Labels: backport-needed
> Fix For: Upcoming Release
>
> Attachments: Create Note.png, OFBIZ-9459.patch, Screenredirection.png
>
>
> 1) Go to SFA component.
> 2) Click on Leads tab 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads].
> 3) Choose any partyId from All Lead list, you will be navigated to Lead 
> profile. 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=LEAD&partyId=DemoLead]
> 4) Click on "Create New" button in the Notes section.
> 5) Add the Note content.
> 6) Click on "Save Button".
> View redirection should be profile but it shows the blank screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9512) Profile link for Lead not working properly for "My Leads" in SFA component

2017-07-22 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9512:
-
Attachment: OFBIZ-9512.patch

Combined patch for all the 5 issues.
For Issue 4 & 5 passed roleTypeId as parameter for the link.

> Profile link for Lead not working properly for "My Leads" in SFA component
> --
>
> Key: OFBIZ-9512
> URL: https://issues.apache.org/jira/browse/OFBIZ-9512
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Jagpreet Kaur
>Assignee: Aditya Sharma
> Attachments: Issue2.jpeg, OFBIZ-9512.patch, OFBIZ-9512.patch, 
> OFBIZ-9512.patch, screenshot-1.png
>
>
> #Issue1
> Steps to reproduce:
> 1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> Profile page shows no information.
> #Issue2
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Contacts link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindContacts].
> 3. In "Find SFA Contacts" section, click on "My Contacts" button.
> 4. Click on partyId link of any Contact 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?partyId=DemoCustomer].
> Profile page shows no information.
> #Issue 3
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> 5. Click on "Show Old" button. 
> Profile page shows no information.
> Note: #Issue 3 can be regenerated in whole sfa component party profile 
> screens.
> #Issue 4
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Accounts link in sub menu 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindAccounts].
> 3. In "All Accounts" section, Click on partyId link 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=ACCOUNT&partyId=Company].
> 4. In the sub-menu, click on "Profile".
> Profile page shows no information.
> #Issue 5
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Opportunities link in sub menu 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity].
> 3. In the "Find Results" section, click on Lead/Account partyId.
> Profile page shows no information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9512) Profile link for Lead not working properly for "My Leads" in SFA component

2017-07-22 Thread Jagpreet Kaur (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097279#comment-16097279
 ] 

Jagpreet Kaur edited comment on OFBIZ-9512 at 7/22/17 12:03 PM:


Thank you, Devanshu. The reason for creating them all under the same issue is, 
they have same code fix under different forms.


was (Author: jagpreet kaur):
Thank you, Devanshu. The reason for creating them all under the same issue is, 
they all have same code fix under different forms.

> Profile link for Lead not working properly for "My Leads" in SFA component
> --
>
> Key: OFBIZ-9512
> URL: https://issues.apache.org/jira/browse/OFBIZ-9512
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Jagpreet Kaur
>Assignee: Aditya Sharma
> Attachments: Issue2.jpeg, OFBIZ-9512.patch, OFBIZ-9512.patch, 
> screenshot-1.png
>
>
> #Issue1
> Steps to reproduce:
> 1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> Profile page shows no information.
> #Issue2
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Contacts link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindContacts].
> 3. In "Find SFA Contacts" section, click on "My Contacts" button.
> 4. Click on partyId link of any Contact 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?partyId=DemoCustomer].
> Profile page shows no information.
> #Issue 3
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> 5. Click on "Show Old" button. 
> Profile page shows no information.
> Note: #Issue 3 can be regenerated in whole sfa component party profile 
> screens.
> #Issue 4
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Accounts link in sub menu 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindAccounts].
> 3. In "All Accounts" section, Click on partyId link 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=ACCOUNT&partyId=Company].
> 4. In the sub-menu, click on "Profile".
> Profile page shows no information.
> #Issue 5
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Opportunities link in sub menu 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity].
> 3. In the "Find Results" section, click on Lead/Account partyId.
> Profile page shows no information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9512) Profile link for Lead not working properly for "My Leads" in SFA component

2017-07-22 Thread Jagpreet Kaur (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097279#comment-16097279
 ] 

Jagpreet Kaur commented on OFBIZ-9512:
--

Thank you, Devanshu. The reason for creating them all under the same issue is, 
they all have same code fix under different forms.

> Profile link for Lead not working properly for "My Leads" in SFA component
> --
>
> Key: OFBIZ-9512
> URL: https://issues.apache.org/jira/browse/OFBIZ-9512
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Jagpreet Kaur
>Assignee: Aditya Sharma
> Attachments: Issue2.jpeg, OFBIZ-9512.patch, OFBIZ-9512.patch, 
> screenshot-1.png
>
>
> #Issue1
> Steps to reproduce:
> 1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> Profile page shows no information.
> #Issue2
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Contacts link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindContacts].
> 3. In "Find SFA Contacts" section, click on "My Contacts" button.
> 4. Click on partyId link of any Contact 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?partyId=DemoCustomer].
> Profile page shows no information.
> #Issue 3
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> 5. Click on "Show Old" button. 
> Profile page shows no information.
> Note: #Issue 3 can be regenerated in whole sfa component party profile 
> screens.
> #Issue 4
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Accounts link in sub menu 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindAccounts].
> 3. In "All Accounts" section, Click on partyId link 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=ACCOUNT&partyId=Company].
> 4. In the sub-menu, click on "Profile".
> Profile page shows no information.
> #Issue 5
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Opportunities link in sub menu 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity].
> 3. In the "Find Results" section, click on Lead/Account partyId.
> Profile page shows no information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8487) Content : Remove unused imports from groovy files for code optimization.

2017-07-22 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097278#comment-16097278
 ] 

Deepak Dixit commented on OFBIZ-8487:
-

Hi [~pradeep.choudhary1994]

Did you get a chance to review unused import?

As in applications/content/groovyScripts/website/WebSiteCMSMetaInfo.groovy file 
 following import is still unused
import org.apache.ofbiz.entity.*

Could you please review again?


> Content : Remove unused imports from groovy files for code optimization.
> 
>
> Key: OFBIZ-8487
> URL: https://issues.apache.org/jira/browse/OFBIZ-8487
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-8487.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9516) User should be notified with success message on Creating New Routing

2017-07-22 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-9516:


 Summary: User should be notified with success message on Creating 
New Routing
 Key: OFBIZ-9516
 URL: https://issues.apache.org/jira/browse/OFBIZ-9516
 Project: OFBiz
  Issue Type: Sub-task
  Components: manufacturing
Affects Versions: Trunk
Reporter: Aditya Sharma
Assignee: Sonal Patwari
Priority: Trivial


Steps to regenerate:
1. Go to Manufacturing component 
(https://localhost:8443/manufacturing/control/main)
2. Click on Routing sub menu 
(https://localhost:8443/manufacturing/control/FindRouting)
3. Click on New Routing 
button.(https://localhost:8443/manufacturing/control/EditRouting)
4. Fill required fields and Click Submit button.
7. On success, the user should be notified with success message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (OFBIZ-9447) Improve groovy DSL : resolve automatic pk field for entity one

2017-07-22 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reopened OFBIZ-9447:
-

> Improve groovy DSL : resolve automatic pk field for entity one
> --
>
> Key: OFBIZ-9447
> URL: https://issues.apache.org/jira/browse/OFBIZ-9447
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9447.patch, OFBIZ-9447-sol1.patch, 
> OFBIZ-9447-sol2.patch
>
>
> Like the element entity-one on mini-lang that can resolve automatically the 
> pk field from context, I propose like explain on the thread 
> https://lists.apache.org/thread.html/5d2c0ac2e0e6a3a8ce13050e9b2d573e82adabbf0067428d087e48c1@%3Cdev.ofbiz.apache.org%3E
>  to use the following syntax :
> {code}
> GenericValue product = from('Product').where(context).queryOne()
> {code}
> This issue provides two solution to extend the EntityQuery class linked to 
> the from groovy dsl syntax



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9470) Missing productId in input field after Atp/Qoh button is clicked on create PO screen

2017-07-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-9470.
-
   Resolution: Fixed
Fix Version/s: (was: Upcoming Release)
   16.11.04

Back ported changes at rev: 1802678

Thanks Prasheel for your contribution.

> Missing productId in input field after Atp/Qoh button is clicked on create PO 
> screen
> 
>
> Key: OFBIZ-9470
> URL: https://issues.apache.org/jira/browse/OFBIZ-9470
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Assignee: Arun Patidar
>Priority: Minor
>  Labels: backport
> Fix For: 16.11.04
>
> Attachments: missing-productId.png, OFBIZ-9470.patch
>
>
> *Steps to regenerate -*
> 1. Go to "Order" component.
> 2. Click on [ Order Entry ] menu button.
> 3. Fill the details in "Purchase Order" section and click on continue.
> 4. Fill the required order details and click on continue.
> 5. Open the product lookup table and select a product.
> 6. Click on [ Atp/Qoh ] button.
> The issue generated is -
> The productId vanishes from the input field.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9447) Improve groovy DSL : resolve automatic pk field for entity one

2017-07-22 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097276#comment-16097276
 ] 

Taher Alkhateeb commented on OFBIZ-9447:


A, much better, +1

> Improve groovy DSL : resolve automatic pk field for entity one
> --
>
> Key: OFBIZ-9447
> URL: https://issues.apache.org/jira/browse/OFBIZ-9447
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9447.patch, OFBIZ-9447-sol1.patch, 
> OFBIZ-9447-sol2.patch
>
>
> Like the element entity-one on mini-lang that can resolve automatically the 
> pk field from context, I propose like explain on the thread 
> https://lists.apache.org/thread.html/5d2c0ac2e0e6a3a8ce13050e9b2d573e82adabbf0067428d087e48c1@%3Cdev.ofbiz.apache.org%3E
>  to use the following syntax :
> {code}
> GenericValue product = from('Product').where(context).queryOne()
> {code}
> This issue provides two solution to extend the EntityQuery class linked to 
> the from groovy dsl syntax



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8487) Content : Remove unused imports from groovy files for code optimization.

2017-07-22 Thread Pradeep Choudhary (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097275#comment-16097275
 ] 

Pradeep Choudhary commented on OFBIZ-8487:
--

Hello [~deepak.dixit],
I reviewed the patch and attached updated patch by creating it from the root 
folder.
Thanks.

> Content : Remove unused imports from groovy files for code optimization.
> 
>
> Key: OFBIZ-8487
> URL: https://issues.apache.org/jira/browse/OFBIZ-8487
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-8487.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9447) Improve groovy DSL : resolve automatic pk field for entity one

2017-07-22 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9447:

Attachment: OFBIZ-9447.patch

Here is the patch that include code improvement only.
Instead of iterating fileds, used GenericPk class object to get the PK fileds 
from parameters/fieldMap.



> Improve groovy DSL : resolve automatic pk field for entity one
> --
>
> Key: OFBIZ-9447
> URL: https://issues.apache.org/jira/browse/OFBIZ-9447
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9447.patch, OFBIZ-9447-sol1.patch, 
> OFBIZ-9447-sol2.patch
>
>
> Like the element entity-one on mini-lang that can resolve automatically the 
> pk field from context, I propose like explain on the thread 
> https://lists.apache.org/thread.html/5d2c0ac2e0e6a3a8ce13050e9b2d573e82adabbf0067428d087e48c1@%3Cdev.ofbiz.apache.org%3E
>  to use the following syntax :
> {code}
> GenericValue product = from('Product').where(context).queryOne()
> {code}
> This issue provides two solution to extend the EntityQuery class linked to 
> the from groovy dsl syntax



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8273) Improvements in Lot entity definition and services

2017-07-22 Thread Devanshu Vyas (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devanshu Vyas updated OFBIZ-8273:
-
Attachment: OFBIZ-8273.patch

Uploaded patch CRUD service definition and related changes.

> Improvements in Lot entity definition and services
> --
>
> Key: OFBIZ-8273
> URL: https://issues.apache.org/jira/browse/OFBIZ-8273
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-8273.patch
>
>
> Required improvements;
>  - All is good with entity definition .
>  - Add CRUD services using entity-auto. Make sure PK is optional while create 
> service, so that can be generated from OFBiz sequence generator.
>  - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
>  - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.
> Note: Require to change the delegator calls in ProductionRunServices.java and 
> InventoryServices.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9455) Required check missing for supplier product id and last price on Add Product Supplier page

2017-07-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-9455.
-
   Resolution: Fixed
Fix Version/s: (was: Upcoming Release)
   16.11.04

Back ported changes at rev: 1802677

Thanks Lalit for verifying.

> Required check missing for supplier product id and last price on Add Product 
> Supplier page
> --
>
> Key: OFBIZ-9455
> URL: https://issues.apache.org/jira/browse/OFBIZ-9455
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Reporter: Aditya Sharma
>Assignee: Arun Patidar
>Priority: Trivial
>  Labels: backport-needed
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9455.patch, screenshot-1.png
>
>
> Steps to reproduce:
> 1. Log in to Catalog component 
> (https://demo-trunk.ofbiz.apache.org/catalog/control/main)
> 2. Go to the Products tab. 
> (https://demo-trunk.ofbiz.apache.org/catalog/control/FindProduct)
> 3. Find a product and click on id link. 
> (https://demo-trunk.ofbiz.apache.org/catalog/control/EditProduct?productId=WG-9943).
> 4. Click on Suppliers 
> subtab.(https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductSuppliers?productId=WG-9943)
> 5. Click Create button on Add Product Supplier form.
> No required validation so an error message from the service.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097270#comment-16097270
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

[~taher] Thanks for your review and input. Agree with your point, we should try 
to move this data to project component. [~prakhar.kumar] could you please 
remove the data Taher suggested and upload the patch again. After that check 
for the possibility and dependencies to move same in the Project component. And 
submit separate patch for that. Thanks!

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch, OFBIZ-9501-002.patch, 
> OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9470) Missing productId in input field after Atp/Qoh button is clicked on create PO screen

2017-07-22 Thread Prasheel Soni (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097266#comment-16097266
 ] 

Prasheel Soni commented on OFBIZ-9470:
--

We can backport changes to OFBIZ 16.11. I have verified the provided patch.

> Missing productId in input field after Atp/Qoh button is clicked on create PO 
> screen
> 
>
> Key: OFBIZ-9470
> URL: https://issues.apache.org/jira/browse/OFBIZ-9470
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Assignee: Arun Patidar
>Priority: Minor
>  Labels: backport
> Fix For: Upcoming Release
>
> Attachments: missing-productId.png, OFBIZ-9470.patch
>
>
> *Steps to regenerate -*
> 1. Go to "Order" component.
> 2. Click on [ Order Entry ] menu button.
> 3. Fill the details in "Purchase Order" section and click on continue.
> 4. Fill the required order details and click on continue.
> 5. Open the product lookup table and select a product.
> 6. Click on [ Atp/Qoh ] button.
> The issue generated is -
> The productId vanishes from the input field.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9455) Required check missing for supplier product id and last price on Add Product Supplier page

2017-07-22 Thread Lalit Kushwah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097265#comment-16097265
 ] 

Lalit Kushwah commented on OFBIZ-9455:
--

We can backport the changes to OFBiz-16.11.I have verified with the provided 
patch.

> Required check missing for supplier product id and last price on Add Product 
> Supplier page
> --
>
> Key: OFBIZ-9455
> URL: https://issues.apache.org/jira/browse/OFBIZ-9455
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Reporter: Aditya Sharma
>Assignee: Arun Patidar
>Priority: Trivial
>  Labels: backport-needed
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9455.patch, screenshot-1.png
>
>
> Steps to reproduce:
> 1. Log in to Catalog component 
> (https://demo-trunk.ofbiz.apache.org/catalog/control/main)
> 2. Go to the Products tab. 
> (https://demo-trunk.ofbiz.apache.org/catalog/control/FindProduct)
> 3. Find a product and click on id link. 
> (https://demo-trunk.ofbiz.apache.org/catalog/control/EditProduct?productId=WG-9943).
> 4. Click on Suppliers 
> subtab.(https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductSuppliers?productId=WG-9943)
> 5. Click Create button on Add Product Supplier form.
> No required validation so an error message from the service.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8717) OFBIZ-7471: Improve all the service level error messages for missing required field for webtools component

2017-07-22 Thread Ritesh Kumar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ritesh Kumar updated OFBIZ-8717:

Attachment: (was: OFBIZ-8717.patch)

> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for webtools component
> --
>
> Key: OFBIZ-8717
> URL: https://issues.apache.org/jira/browse/OFBIZ-8717
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: 16.11.01
>Reporter: Jagpreet Kaur
>Assignee: Ritesh Kumar
>Priority: Minor
> Attachments: OFBIZ-8717.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8717) OFBIZ-7471: Improve all the service level error messages for missing required field for webtools component

2017-07-22 Thread Ritesh Kumar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ritesh Kumar updated OFBIZ-8717:

Attachment: OFBIZ-8717.patch

Improved patch with proper naming conventions on error UI labels. 

> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for webtools component
> --
>
> Key: OFBIZ-8717
> URL: https://issues.apache.org/jira/browse/OFBIZ-8717
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: 16.11.01
>Reporter: Jagpreet Kaur
>Assignee: Ritesh Kumar
>Priority: Minor
> Attachments: OFBIZ-8717.patch, OFBIZ-8717.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8487) Content : Remove unused imports from groovy files for code optimization.

2017-07-22 Thread Pradeep Choudhary (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-8487:
-
Attachment: OFBIZ-8487.patch

> Content : Remove unused imports from groovy files for code optimization.
> 
>
> Key: OFBIZ-8487
> URL: https://issues.apache.org/jira/browse/OFBIZ-8487
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-8487.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9507) Jobs get stuck and Job Poller not able to execute the pending jobs

2017-07-22 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097256#comment-16097256
 ] 

Arun Patidar commented on OFBIZ-9507:
-

I faced similar kind of issue on 14.12.  Job was in pending status for long 
time and it get invoked only after restarting of instance.

> Jobs get stuck and Job Poller not able to execute the pending jobs
> --
>
> Key: OFBIZ-9507
> URL: https://issues.apache.org/jira/browse/OFBIZ-9507
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 14.12
>Reporter: Chandan Khandelwal
>Assignee: Chandan Khandelwal
>
> -- Some Time Job Poller stuck and not able to execute the pending jobs.
> -- As per the run time in JobSandBox jobs should be executed.
> -- On server restart JobPoller start executing the pending jobs.
> Found Some Details might be related to this issue -
> https://issues.apache.org/jira/browse/OFBIZ-5710



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8487) Content : Remove unused imports from groovy files for code optimization.

2017-07-22 Thread Pradeep Choudhary (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-8487:
-
Attachment: (was: OFBIZ-8487.patch)

> Content : Remove unused imports from groovy files for code optimization.
> 
>
> Key: OFBIZ-8487
> URL: https://issues.apache.org/jira/browse/OFBIZ-8487
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-5936) Invoice transactions for purchase order sale tax not supported

2017-07-22 Thread Deepak Nigam (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-5936:

Attachment: MissingTaxEntry.pdf
TransacationNotGettingPosted.pdf

> Invoice transactions for purchase order sale tax not supported
> --
>
> Key: OFBIZ-5936
> URL: https://issues.apache.org/jira/browse/OFBIZ-5936
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Christian Carlow
> Attachments: MissingTaxEntry.pdf, TransacationNotGettingPosted.pdf
>
>
> Invoice transactions for sales tax adjustments manually added to purchase 
> orders are not supported leading to an error when attempting to change the 
> invoice status to "Ready for Posting".  
> GeneralLedgerServices.xml#createAcctgTransForPurchaseInvoice does not include 
> logic to set the glAccountTypeId for purchase invoices for item type 
> PITM_SALES_TAX.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-5936) Invoice transactions for purchase order sale tax not supported

2017-07-22 Thread Deepak Nigam (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097253#comment-16097253
 ] 

Deepak Nigam commented on OFBIZ-5936:
-

Hi [~ofbizzer], [~arunpati]

I tried to regenerate the issue by the steps provided by Arun on OFBiz demo 
instance.
The issue here is that accounting transaction is not getting posted when you 
include tax in purchase orders. The reason behind this is, in AcctgTransEntry 
table total credit total is not equal to the debit total. Accounts payable 
entry does include tax amount. Please find the attached screenshot for more 
information.

> Invoice transactions for purchase order sale tax not supported
> --
>
> Key: OFBIZ-5936
> URL: https://issues.apache.org/jira/browse/OFBIZ-5936
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Christian Carlow
>
> Invoice transactions for sales tax adjustments manually added to purchase 
> orders are not supported leading to an error when attempting to change the 
> invoice status to "Ready for Posting".  
> GeneralLedgerServices.xml#createAcctgTransForPurchaseInvoice does not include 
> logic to set the glAccountTypeId for purchase invoices for item type 
> PITM_SALES_TAX.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9131) Error changing the state of a lead

2017-07-22 Thread priya sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097250#comment-16097250
 ] 

priya sharma commented on OFBIZ-9131:
-

Following are the findings on the issue :

- When user creates a lead, passing the first name and last name only. Person 
is created with the role "LEAD" and with party status as LEAD_ASSIGNED.
- The cause of reported error is that there is no data for transition from 
LEAD_ASSIGNED status to PARTY_ENABLED status in STATUS_VALID_CHANGE entity.
- STATUS_VALID_CHANGE entity contains data for transition from LEAD_ASSIGNED to 
LEAD_QUALIFIED, LEAD_ASSIGNED to LEAD_CONVERTED and LEAD_ASSIGNED to 
PARTY_DISABLED.


I'm not providing the patch for it as it seems the enabled and disabled 
statuses of type PARTY_STATUS are put intentionally in the code. Thus I request 
to community to suggest if we can proceed with the solution I proposed or we 
should add more valid changes for LEAD_ASSIGNED and proceed accordingly?


> Error changing the state of a lead
> --
>
> Key: OFBIZ-9131
> URL: https://issues.apache.org/jira/browse/OFBIZ-9131
> Project: OFBiz
>  Issue Type: Bug
>  Components: Demo
>Affects Versions: Release Branch 13.07
> Environment: DEMO
>Reporter: Lisardo de Jesús Bohórquez Bedoya
>Assignee: priya sharma
> Attachments: ERROR STATE CHANGE OF A LEAD.docx
>
>
> After creating a LEAD, it is generated in the Assigned state, then I enter 
> the lead, I change the state (for example to the "Active" state) and I CLICK 
> save, but the action does not execute and the following error is generated.
> Error Calling event: org.ofbiz.webapp.event.EventHandler.Exception: Service 
> invocation error (Could not commit transaction for service [updatePerson] 
> call: Roll back error, could not commit transaction, was rolled back instead 
> because of: Error in service [SetPartyStatus]: Cannot change party status 
> from LEAD_ASSIGNED to PARTY_ENABLED)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7275) Adding condition in price rule on 'Role Type' shown incorrect result

2017-07-22 Thread Pranay Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey reassigned OFBIZ-7275:


Assignee: Pranay Pandey  (was: Aditi Patidar)

> Adding condition in price rule on 'Role Type' shown incorrect result
> 
>
> Key: OFBIZ-7275
> URL: https://issues.apache.org/jira/browse/OFBIZ-7275
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Aditi Patidar
>Assignee: Pranay Pandey
>Priority: Minor
> Attachments: OFBIZ-7275.patch, OFBIZ-7275.png
>
>
> Steps to regenerate issue:
> 1. Create a price rule or open an existing one.
> 2. Add a condition, select input 'Role Type', operator 'Is' and select the 
> value 'Customer'.
> Expected Result: For added condition value should be 'Customer'.
> Actual Result: It's showing value 'Ship-To Customer'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9512) Profile link for Lead not working properly for "My Leads" in SFA component

2017-07-22 Thread Devanshu Vyas (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097246#comment-16097246
 ] 

Devanshu Vyas commented on OFBIZ-9512:
--

Hello Jagpreet,

Please create a separate ticket for each issue rather than mentioning all in 
one. This approach is more helpful in issue traceability.
If all the issues mentioned here are related to a parent one, then create child 
tickets else create separate tickets. :)

> Profile link for Lead not working properly for "My Leads" in SFA component
> --
>
> Key: OFBIZ-9512
> URL: https://issues.apache.org/jira/browse/OFBIZ-9512
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Jagpreet Kaur
>Assignee: Aditya Sharma
> Attachments: Issue2.jpeg, OFBIZ-9512.patch, OFBIZ-9512.patch, 
> screenshot-1.png
>
>
> #Issue1
> Steps to reproduce:
> 1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> Profile page shows no information.
> #Issue2
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Contacts link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindContacts].
> 3. In "Find SFA Contacts" section, click on "My Contacts" button.
> 4. Click on partyId link of any Contact 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?partyId=DemoCustomer].
> Profile page shows no information.
> #Issue 3
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> 5. Click on "Show Old" button. 
> Profile page shows no information.
> Note: #Issue 3 can be regenerated in whole sfa component party profile 
> screens.
> #Issue 4
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Accounts link in sub menu 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindAccounts].
> 3. In "All Accounts" section, Click on partyId link 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=ACCOUNT&partyId=Company].
> 4. In the sub-menu, click on "Profile".
> Profile page shows no information.
> #Issue 5
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Opportunities link in sub menu 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity].
> 3. In the "Find Results" section, click on Lead/Account partyId.
> Profile page shows no information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-7275) Adding condition in price rule on 'Role Type' shown incorrect result

2017-07-22 Thread Aditi Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditi Patidar updated OFBIZ-7275:
-
Attachment: OFBIZ-7275.patch

The issue exists because in role type list there are multiple occurrences of 
substring "CUSTOMER" and the existing check was just checking the occurrence of 
a substring in the string and found this value more than once in the list so 
the last option gets selected.

Applied the equality check to find the exact match.

> Adding condition in price rule on 'Role Type' shown incorrect result
> 
>
> Key: OFBIZ-7275
> URL: https://issues.apache.org/jira/browse/OFBIZ-7275
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Aditi Patidar
>Assignee: Aditi Patidar
>Priority: Minor
> Attachments: OFBIZ-7275.patch, OFBIZ-7275.png
>
>
> Steps to regenerate issue:
> 1. Create a price rule or open an existing one.
> 2. Add a condition, select input 'Role Type', operator 'Is' and select the 
> value 'Customer'.
> Expected Result: For added condition value should be 'Customer'.
> Actual Result: It's showing value 'Ship-To Customer'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9479) Use FlexibleLocation.resolveLocation() instead of hard-coded path

2017-07-22 Thread Ashish Vijaywargiya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-9479.
--
   Resolution: Fixed
Fix Version/s: Upcoming Release

Thanks Devanshu for the contribution.
Changes are committed in trunk at r1802673.

> Use FlexibleLocation.resolveLocation() instead of hard-coded path
> -
>
> Key: OFBIZ-9479
> URL: https://issues.apache.org/jira/browse/OFBIZ-9479
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9479.patch
>
>
> I found some occurrences where file path URL is prepared using the actual 
> path of the file rather than the relative path. For e.g. 
> {code}
> String imgPropertyFullPath = System.getProperty("ofbiz.home") + 
> "/applications/product/config/ImageProperties.xml";
> {code}
> IMO the location URL of files should be prepared dynamically using relative 
> paths and this can be achieved by using
> FlexibleLocation.resolveLocation() method. This method covers all the 
> scenarios and in future, if we want to change anything, then all we need is 
> to update the method and all instances will be fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9507) Jobs get stuck and Job Poller not able to execute the pending jobs

2017-07-22 Thread Chandan Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal reassigned OFBIZ-9507:
-

Assignee: Chandan Khandelwal

> Jobs get stuck and Job Poller not able to execute the pending jobs
> --
>
> Key: OFBIZ-9507
> URL: https://issues.apache.org/jira/browse/OFBIZ-9507
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 14.12
>Reporter: Chandan Khandelwal
>Assignee: Chandan Khandelwal
>
> -- Some Time Job Poller stuck and not able to execute the pending jobs.
> -- As per the run time in JobSandBox jobs should be executed.
> -- On server restart JobPoller start executing the pending jobs.
> Found Some Details might be related to this issue -
> https://issues.apache.org/jira/browse/OFBIZ-5710



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8716) OFBIZ-7471: Improve all the service level error messages for missing required field for humanares component

2017-07-22 Thread Prasheel Soni (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasheel Soni updated OFBIZ-8716:
-
Attachment: OFBIZ-8716.patch

> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for humanares component
> ---
>
> Key: OFBIZ-8716
> URL: https://issues.apache.org/jira/browse/OFBIZ-8716
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: 16.11.01
>Reporter: Jagpreet Kaur
>Priority: Minor
> Attachments: OFBIZ-8716.patch, OFBIZ-8716.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8487) Content : Remove unused imports from groovy files for code optimization.

2017-07-22 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097243#comment-16097243
 ] 

Deepak Dixit commented on OFBIZ-8487:
-

Hi [~pradeep.choudhary1994], 

I reviewed your patch and it seems that there are some more unused imports 
exits in file attached in patch.
Could you please review it and attach patch again?

> Content : Remove unused imports from groovy files for code optimization.
> 
>
> Key: OFBIZ-8487
> URL: https://issues.apache.org/jira/browse/OFBIZ-8487
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-8487.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7275) Adding condition in price rule on 'Role Type' shown incorrect result

2017-07-22 Thread Pranay Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey reassigned OFBIZ-7275:


Assignee: Aditi Patidar  (was: Pranay Pandey)

> Adding condition in price rule on 'Role Type' shown incorrect result
> 
>
> Key: OFBIZ-7275
> URL: https://issues.apache.org/jira/browse/OFBIZ-7275
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Aditi Patidar
>Assignee: Aditi Patidar
>Priority: Minor
> Attachments: OFBIZ-7275.png
>
>
> Steps to regenerate issue:
> 1. Create a price rule or open an existing one.
> 2. Add a condition, select input 'Role Type', operator 'Is' and select the 
> value 'Customer'.
> Expected Result: For added condition value should be 'Customer'.
> Actual Result: It's showing value 'Ship-To Customer'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9512) Profile link for Lead not working properly for "My Leads" in SFA component

2017-07-22 Thread Jagpreet Kaur (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097242#comment-16097242
 ] 

Jagpreet Kaur commented on OFBIZ-9512:
--

Hi Aditya, Thanks for the patch. After applying the patch the functionality 
works fine.
Found some more issues in sfa component for profile redirection so, mentioned 
those in the description as #Issue 4 and #Issue 5.

> Profile link for Lead not working properly for "My Leads" in SFA component
> --
>
> Key: OFBIZ-9512
> URL: https://issues.apache.org/jira/browse/OFBIZ-9512
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Jagpreet Kaur
>Assignee: Aditya Sharma
> Attachments: Issue2.jpeg, OFBIZ-9512.patch, OFBIZ-9512.patch, 
> screenshot-1.png
>
>
> #Issue1
> Steps to reproduce:
> 1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> Profile page shows no information.
> #Issue2
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Contacts link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindContacts].
> 3. In "Find SFA Contacts" section, click on "My Contacts" button.
> 4. Click on partyId link of any Contact 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?partyId=DemoCustomer].
> Profile page shows no information.
> #Issue 3
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> 5. Click on "Show Old" button. 
> Profile page shows no information.
> Note: #Issue 3 can be regenerated in whole sfa component party profile 
> screens.
> #Issue 4
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Accounts link in sub menu 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindAccounts].
> 3. In "All Accounts" section, Click on partyId link 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=ACCOUNT&partyId=Company].
> 4. In the sub-menu, click on "Profile".
> Profile page shows no information.
> #Issue 5
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Opportunities link in sub menu 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity].
> 3. In the "Find Results" section, click on Lead/Account partyId.
> Profile page shows no information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Saurabh Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Saurabh Dixit updated OFBIZ-9501:
-
Attachment: OFBIZ-9501-003.patch

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch, OFBIZ-9501-002.patch, 
> OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9512) Profile link for Lead not working properly for "My Leads" in SFA component

2017-07-22 Thread Jagpreet Kaur (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jagpreet Kaur updated OFBIZ-9512:
-
Description: 
#Issue1
Steps to reproduce:
1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
2. Click on the Lead link in sub menu 
[https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
3. In "Find SFA Leads" section, click on "My Leads" button.
4. Click on partyId link of any Lead 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
Profile page shows no information.

#Issue2
1. Navigate to SFA component 
[https://demo-trunk.ofbiz.apache.org/sfa/control/main].
2. Click on the Contacts link in sub menu 
[https://demo-trunk.ofbiz.apache.org/sfa/control/FindContacts].
3. In "Find SFA Contacts" section, click on "My Contacts" button.
4. Click on partyId link of any Contact 
[https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?partyId=DemoCustomer].

Profile page shows no information.

#Issue 3
1. Navigate to SFA component 
[https://demo-trunk.ofbiz.apache.org/sfa/control/main].
2. Click on the Lead link in sub menu 
[https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
3. In "Find SFA Leads" section, click on "My Leads" button.
4. Click on partyId link of any Lead 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
5. Click on "Show Old" button. 
Profile page shows no information.
Note: #Issue 3 can be regenerated in whole sfa component party profile screens.

#Issue 4
1. Navigate to SFA component 
[https://demo-trunk.ofbiz.apache.org/sfa/control/main].
2. Click on the Accounts link in sub menu 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindAccounts].
3. In "All Accounts" section, Click on partyId link 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=ACCOUNT&partyId=Company].
4. In the sub-menu, click on "Profile".
Profile page shows no information.

#Issue 5
1. Navigate to SFA component 
[https://demo-trunk.ofbiz.apache.org/sfa/control/main].
2. Click on the Opportunities link in sub menu 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity].
3. In the "Find Results" section, click on Lead/Account partyId.
Profile page shows no information.

  was:
#Issue1
Steps to reproduce:
1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
2. Click on the Lead link in sub menu 
[https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
3. In "Find SFA Leads" section, click on "My Leads" button.
4. Click on partyId link of any Lead 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
Profile page shows no information.

#Issue2
1. Navigate to SFA component 
[https://demo-trunk.ofbiz.apache.org/sfa/control/main].
2. Click on the Contacts link in sub menu 
[https://demo-trunk.ofbiz.apache.org/sfa/control/FindContacts].
3. In "Find SFA Contacts" section, click on "My Contacts" button.
4. Click on partyId link of any Contact 
[https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?partyId=DemoCustomer].

Profile page shows no information.

#Issue 3
1. Navigate to SFA component 
[https://demo-trunk.ofbiz.apache.org/sfa/control/main].
2. Click on the Lead link in sub menu 
[https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
3. In "Find SFA Leads" section, click on "My Leads" button.
4. Click on partyId link of any Lead 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
5. Click on "Show Old" button. 
Profile page shows no information.
Note: #Issue 3 can be regenerated in whole sfa component party profile screens.


> Profile link for Lead not working properly for "My Leads" in SFA component
> --
>
> Key: OFBIZ-9512
> URL: https://issues.apache.org/jira/browse/OFBIZ-9512
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Jagpreet Kaur
>Assignee: Aditya Sharma
> Attachments: Issue2.jpeg, OFBIZ-9512.patch, OFBIZ-9512.patch, 
> screenshot-1.png
>
>
> #Issue1
> Steps to reproduce:
> 1. Go to sfa component [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Lead link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads].
> 3. In "Find SFA Leads" section, click on "My Leads" button.
> 4. Click on partyId link of any Lead 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads?all=false].
> Profile page shows no information.
> #Issue2
> 1. Navigate to SFA component 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/main].
> 2. Click on the Contacts link in sub menu 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindContacts].
> 3. In "Find SFA Contacts" section, click on "My Contacts" button.
> 4. C

  1   2   >