[jira] [Created] (OFBIZ-9903) Erros in data load

2017-10-28 Thread Renuka Srishti (JIRA)
Renuka Srishti created OFBIZ-9903:
-

 Summary: Erros in data load
 Key: OFBIZ-9903
 URL: https://issues.apache.org/jira/browse/OFBIZ-9903
 Project: OFBiz
  Issue Type: Task
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Renuka Srishti
Assignee: Renuka Srishti


>From Date is missing in data related to SecurityGroupPermission entity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9856) Add rat exclude files to excludes those files that does not need license header

2017-10-28 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222692#comment-16222692
 ] 

Jacques Le Roux edited comment on OFBIZ-9856 at 10/28/17 7:42 AM:
--

I have added a WIP 
[rat-excludes.txt|http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/rat-excludes.txt?view=markup]
 files in OFBiz root dir but it does not work yet. 

I have asked infra about it 
https://issues.apache.org/jira/servicedesk/agent/INFRA/issue/INFRA-15395



was (Author: jacques.le.roux):
I have added a WIP rat-excludes.txt at revision: 1813550 


> Add rat exclude files to excludes those files that does not need license 
> header 
> 
>
> Key: OFBIZ-9856
> URL: https://issues.apache.org/jira/browse/OFBIZ-9856
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>
> As recently we added Apache Rat in Buildbot, Rat audits software 
> distributions, with a special interest in headers.
> Here is the Rat report for ofbiz
> https://ci.apache.org/projects/ofbiz/rat-output.html
> In this reports there are several files that does not need license header 
> like *.svg etc.
> Rat provide a way to exclude files while auditing
> http://creadur.apache.org/rat/apache-rat/
> {quote}
> It is common to use the Rat with the Maven or Ant plugins and specify a 
> series of files to exclude (such as a README or version control files). If 
> you are using the Rat application instead of a plugin you can specify a 
> series of regex excludes in a file and specify that with the -E option.
> {quote}
> We can add .rat-excludes.txt files at ofbiz root for this purpose.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9903) Erros in data load

2017-10-28 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223308#comment-16223308
 ] 

Deepak Dixit commented on OFBIZ-9903:
-

Hi Renuka,

Could you take update of ofbiz-framework and ofbiz-plugins ?
I am able to load data on my machine. 

> Erros in data load
> --
>
> Key: OFBIZ-9903
> URL: https://issues.apache.org/jira/browse/OFBIZ-9903
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Renuka Srishti
>
> From Date is missing in data related to SecurityGroupPermission entity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9856) Add rat exclude files to excludes those files that does not need license header

2017-10-28 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223309#comment-16223309
 ] 

Deepak Dixit commented on OFBIZ-9856:
-

Hi [~jacques.le.roux]

I think we need to add rat-exclude.txt path in buildboat.

http://creadur.apache.org/rat/apache-rat/
{info}

Using multiple excludes from a file

It is common to use the Rat with the Maven or Ant plugins and specify a series 
of files to exclude (such as a README or version control files). If you are 
using the Rat application instead of a plugin you can specify a series of regex 
excludes in a file and specify that with the -E option.

java -jar apache-rat-0.13-SNAPSHOT.jar
 -E /path/to/project/.rat-excludes
 -d /path/to/project
{info}

> Add rat exclude files to excludes those files that does not need license 
> header 
> 
>
> Key: OFBIZ-9856
> URL: https://issues.apache.org/jira/browse/OFBIZ-9856
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>
> As recently we added Apache Rat in Buildbot, Rat audits software 
> distributions, with a special interest in headers.
> Here is the Rat report for ofbiz
> https://ci.apache.org/projects/ofbiz/rat-output.html
> In this reports there are several files that does not need license header 
> like *.svg etc.
> Rat provide a way to exclude files while auditing
> http://creadur.apache.org/rat/apache-rat/
> {quote}
> It is common to use the Rat with the Maven or Ant plugins and specify a 
> series of files to exclude (such as a README or version control files). If 
> you are using the Rat application instead of a plugin you can specify a 
> series of regex excludes in a file and specify that with the -E option.
> {quote}
> We can add .rat-excludes.txt files at ofbiz root for this purpose.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9903) Erros in data load

2017-10-28 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223310#comment-16223310
 ] 

Suraj Khurana commented on OFBIZ-9903:
--

Hi [~Renuka_Srishti],
Working fine at my end at -r1813586 which is the latest revision as of now.
Can you please elaborate more on this issue.

> Erros in data load
> --
>
> Key: OFBIZ-9903
> URL: https://issues.apache.org/jira/browse/OFBIZ-9903
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Renuka Srishti
>
> From Date is missing in data related to SecurityGroupPermission entity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-10-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-9758:


Assignee: Rishi Solanki  (was: Rohit Rai)

> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rishi Solanki
> Attachments: OFBIZ-9758.patch, OFBIZ-9758.png
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-10-28 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223317#comment-16223317
 ] 

Rishi Solanki commented on OFBIZ-9758:
--

[~rohit.rai]: Thanks for your contribution, fix has been committed in revision 
trunk-1813588 and 16.11-1813589. Please note the minor modification done in 
your patch before committing. 

> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rishi Solanki
> Attachments: OFBIZ-9758.patch, OFBIZ-9758.png
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9763) Create separate Permission Services for CRUD services of ShoppingList and ShoppingListItem

2017-10-28 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9763:
---

Assignee: Arun Patidar  (was: Chinmay Patidar)

> Create separate Permission Services for CRUD services of ShoppingList and 
> ShoppingListItem
> --
>
> Key: OFBIZ-9763
> URL: https://issues.apache.org/jira/browse/OFBIZ-9763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce, party
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Chinmay Patidar
>Assignee: Arun Patidar
> Fix For: Trunk
>
> Attachments: OFBIZ-9763.patch
>
>
> In CRUD services for ShoppingList and ShoppingListItem entities, the security 
> related checks are present inline in the services. This implementation 
> violates the best practice of keeping security implementation different from 
> the business logic.
> We need to implement security services for such operations and to call them 
> as a permission-service from the CRUD operation services definition



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-10-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-9758.
--
   Resolution: Fixed
Fix Version/s: Release Branch 16.11
   Upcoming Release

> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rishi Solanki
> Fix For: Upcoming Release, Release Branch 16.11
>
> Attachments: OFBIZ-9758.patch, OFBIZ-9758.png
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9758) Party Id label missing from edit data resource role

2017-10-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-9758.


> Party Id label missing from edit data resource role
> ---
>
> Key: OFBIZ-9758
> URL: https://issues.apache.org/jira/browse/OFBIZ-9758
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rishi Solanki
> Fix For: Upcoming Release, Release Branch 16.11
>
> Attachments: OFBIZ-9758.patch, OFBIZ-9758.png
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> Party Id label is missing,
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9840) Mime Type not supported Error while generating a Composite Pdf

2017-10-28 Thread Aman Mishra (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Mishra reassigned OFBIZ-9840:
--

Assignee: Aman Mishra

> Mime Type not supported Error while generating a Composite Pdf
> --
>
> Key: OFBIZ-9840
> URL: https://issues.apache.org/jira/browse/OFBIZ-9840
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Assignee: Aman Mishra
>
> When generating a Composite Pdf in the Content Manager an Error occurs :
> Mime Type not Supported
> Steps to recreate the Error Message:
>   Content Manager-> CompDoc ->T ree-> View Instances-> Tree -> Generate 
> Composite Pdf
> Error log:
> {code:java}
> java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
> supported
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
>  [ofbiz.jar:?]
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9897) Add ability to disable entity eca rule

2017-10-28 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-9897:
---

Assignee: Deepak Dixit

> Add ability to disable entity eca rule 
> ---
>
> Key: OFBIZ-9897
> URL: https://issues.apache.org/jira/browse/OFBIZ-9897
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>
> We have enabled flag in EntityEcaRule class, if its set false then entity eca 
> rule will not be execute.
> But there is not way to disable entity eca.
> We can add enabled flag in Entity ECA definition to disable the existing 
> entity eca rule.
> - Add new attribute on entity eca tag named enabled
> - Default value will be true for this.
> - If user want to disable existing OOTB entity eca rule, then user can define 
> same rule in custom component and set the enabled=false
> Also as per current flow if same seca rule is define more then once, system 
> will execute all the rule, ideally it should not execute same rule (same 
> rule, condition and action) if its defined more than one.
> Also need to ovride hasCode, equals and toString method for EntityEcaRule 
> class file. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-8014) Introduce the "Product" Screen under Party app to manage the products supplied by any supplier

2017-10-28 Thread Yashwant Dhakad (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad reassigned OFBIZ-8014:
--

Assignee: Rohit Koushal  (was: Yashwant Dhakad)

> Introduce the "Product" Screen under Party app to manage the products 
> supplied by any supplier
> --
>
> Key: OFBIZ-8014
> URL: https://issues.apache.org/jira/browse/OFBIZ-8014
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Release Branch 14.12, 16.11.01, Release Branch 15.12
>Reporter: Swapnil Shah
>Assignee: Rohit Koushal
> Attachments: SupplierProduct.png
>
>
> Currently, upon logging into the Party application (or login as supplier 
> itself) and go to any specific supplier view then there is no way to manage 
> the list of supplied products. 
> # We can try introducing the "Product" tab/screen along with other tabs. (to 
> begin with we can simply mimic the Supplier screen from Catalog app e.g., 
> https://ofbiz-vm.apache.org:8443/catalog/control/EditProductSuppliers?productId=MAT_A_COST)
>  
> # We can also choose to show the "Products" tab for only Parties in supplier 
> role and later can try to extend for other roles with further needed 
> refinements. 
> Please refer to attached screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7357) OFBIZ-6964: Prepare Demo Data based on the propsed design to support replenishment planning through any inter-company facility

2017-10-28 Thread Yashwant Dhakad (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad reassigned OFBIZ-7357:
--

Assignee: Swapnil M Mane  (was: Swapnil Shah)

> OFBIZ-6964: Prepare Demo Data based on the propsed design to support 
> replenishment planning through any inter-company facility
> --
>
> Key: OFBIZ-7357
> URL: https://issues.apache.org/jira/browse/OFBIZ-7357
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil M Mane
> Fix For: Upcoming Release
>
>
> We can start preparing demo data for implementation and testing purpose based 
> on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9903) Erros in data load

2017-10-28 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti closed OFBIZ-9903.
-
Resolution: Fixed

> Erros in data load
> --
>
> Key: OFBIZ-9903
> URL: https://issues.apache.org/jira/browse/OFBIZ-9903
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Renuka Srishti
>
> From Date is missing in data related to SecurityGroupPermission entity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9903) Erros in data load

2017-10-28 Thread Renuka Srishti (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223325#comment-16223325
 ] 

Renuka Srishti commented on OFBIZ-9903:
---

Yes, it was my local machine issue. Its working fine now, I am closing this 
ticket.

> Erros in data load
> --
>
> Key: OFBIZ-9903
> URL: https://issues.apache.org/jira/browse/OFBIZ-9903
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Renuka Srishti
>
> From Date is missing in data related to SecurityGroupPermission entity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-1585) Credit card valdation does not work properly during anonymous quick checkout process

2017-10-28 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-1585:
---

Assignee: Arun Patidar  (was: Amit Gadaley)

> Credit card valdation does not work properly during anonymous quick checkout 
> process
> 
>
> Key: OFBIZ-1585
> URL: https://issues.apache.org/jira/browse/OFBIZ-1585
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
> Environment: Ubuntu 7.10, Firefox 2.0.0.11
>Reporter: Raj Saini
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-1585.patch, OFBIZ-1585.patch, OFBIZ-1585.patch, 
> credit-card-validation.png, credit-card-validation2.png
>
>
> If a credit card is selected as payment method and process button is pressed 
> without adding all mandatory fields of credit card, order will be summited 
> despite showing the validation error on credit card and user have no choice 
> of rectifying the validation errors. 
> Screenshot is attached showing this behavior 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9755) ShoppingCart's 'getPaymentMethodTypes' method should use 'getPaymentMethodTypeIds' internally instead of 'getPaymentMethodIds'

2017-10-28 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9755:
---

Assignee: Arun Patidar  (was: Amit Gadaley)

> ShoppingCart's 'getPaymentMethodTypes' method should use 
> 'getPaymentMethodTypeIds' internally instead of 'getPaymentMethodIds'
> --
>
> Key: OFBIZ-9755
> URL: https://issues.apache.org/jira/browse/OFBIZ-9755
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Arun Patidar
> Fix For: Trunk
>
> Attachments: OFBIZ-9755.patch
>
>
> ShoppingCart's 'getPaymentMethodTypes' method should use 
> 'getPaymentMethodTypeIds' internally instead of 'getPaymentMethodIds'. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9899) UI Issue with Account Limit at Find Billing Account(s)

2017-10-28 Thread Aayush jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aayush jain updated OFBIZ-9899:
---
Attachment: Find_Billing_Account.png

> UI Issue with Account Limit at Find Billing Account(s)
> --
>
> Key: OFBIZ-9899
> URL: https://issues.apache.org/jira/browse/OFBIZ-9899
> Project: OFBiz
>  Issue Type: Bug
> Environment: demo-trunk.ofbiz.apache.org
>Reporter: Aayush jain
>Assignee: Ankush Upadhyay
>Priority: Trivial
> Attachments: Find_Billing_Account.png
>
>
> Steps:
> 1. Open 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindBillingAccount
> 2. Navigate to Find Billing account
> 3. Check for Search Results
> Actual: At Account Limit section, symbol is been displayed
> Expected: Currency Symbols should be displayed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9760) Using Bootstrap Framework for E-Commerce Website

2017-10-28 Thread Nitish Mishra (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitish Mishra reassigned OFBIZ-9760:


Assignee: Nitish Mishra  (was: Saurabh Dixit)

> Using Bootstrap Framework for E-Commerce Website
> 
>
> Key: OFBIZ-9760
> URL: https://issues.apache.org/jira/browse/OFBIZ-9760
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Saurabh Dixit
>Assignee: Nitish Mishra
>
> Use of the bootstrap framework so that the UI of the e-commerce would be more 
> arranged and user-friendly



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9904) Issue while removing RateAmount Record

2017-10-28 Thread Parakh Maheshwari (JIRA)
Parakh Maheshwari created OFBIZ-9904:


 Summary: Issue while removing RateAmount Record
 Key: OFBIZ-9904
 URL: https://issues.apache.org/jira/browse/OFBIZ-9904
 Project: OFBiz
  Issue Type: Bug
  Components: scrum
Reporter: Parakh Maheshwari


*Steps to regenerate the issue:*
1)Navigate to 
[https://demo-trunk.ofbiz.apache.org/scrum/control/main?externalLoginKey=EL0a347422-1144-4dc1-9ab2-a48f17078c13]
2)Click on *My Profile* Tab under Scrum component.
3)Click on *Rates* Section:
[https://demo-trunk.ofbiz.apache.org/scrum/control/EditPartyRates?partyId=admin]
4)Try to delete Existing Rate Amount Record, there is a service invocation 
error generates while removing the record.
  OR
5)If no record exists then create a new Rate Amount record then try to repeat 
the same process as mentioned in step(4)

Please refer the attached screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9901) Unable to create event in SFA component

2017-10-28 Thread Praveen Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma reassigned OFBIZ-9901:
-

Assignee: Praveen Sharma

> Unable to create event in SFA component
> ---
>
> Key: OFBIZ-9901
> URL: https://issues.apache.org/jira/browse/OFBIZ-9901
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Rubia Elza Joshep
>Assignee: Praveen Sharma
> Attachments: screenshot-1.png
>
>
> Steps-
> 1) Open URL 
> https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign
> 2) In SFA component, create an event by clicking on "Create new".
> 3) Fill in the information with name and select "To party id" (except admin).
> Expected: Event should be successfully created
> Actual: Unable to create event



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9904) Issue while removing RateAmount Record

2017-10-28 Thread Parakh Maheshwari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Parakh Maheshwari updated OFBIZ-9904:
-
Attachment: IssueWithRateAmount.png

> Issue while removing RateAmount Record
> --
>
> Key: OFBIZ-9904
> URL: https://issues.apache.org/jira/browse/OFBIZ-9904
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Reporter: Parakh Maheshwari
> Attachments: IssueWithRateAmount.png
>
>
> *Steps to regenerate the issue:*
> 1)Navigate to 
> [https://demo-trunk.ofbiz.apache.org/scrum/control/main?externalLoginKey=EL0a347422-1144-4dc1-9ab2-a48f17078c13]
> 2)Click on *My Profile* Tab under Scrum component.
> 3)Click on *Rates* Section:
> [https://demo-trunk.ofbiz.apache.org/scrum/control/EditPartyRates?partyId=admin]
> 4)Try to delete Existing Rate Amount Record, there is a service invocation 
> error generates while removing the record.
>   OR
> 5)If no record exists then create a new Rate Amount record then try to repeat 
> the same process as mentioned in step(4)
> Please refer the attached screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (OFBIZ-7722) Sub-menu looks overlapping in Tomahawk theme

2017-10-28 Thread Ayushi Rathod (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayushi Rathod reopened OFBIZ-7722:
--
  Assignee: Ayushi Rathod  (was: Jacques Le Roux)

> Sub-menu looks overlapping in Tomahawk theme
> 
>
> Key: OFBIZ-7722
> URL: https://issues.apache.org/jira/browse/OFBIZ-7722
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Ayushi Rathod
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7722.patch, OFBIZ-7722.png, Theme.png
>
>
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (OFBIZ-9903) Erros in data load

2017-10-28 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti reopened OFBIZ-9903:
---

> Erros in data load
> --
>
> Key: OFBIZ-9903
> URL: https://issues.apache.org/jira/browse/OFBIZ-9903
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Renuka Srishti
>
> From Date is missing in data related to SecurityGroupPermission entity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9904) Issue while removing RateAmount Record

2017-10-28 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-9904:


Assignee: Suraj Khurana

> Issue while removing RateAmount Record
> --
>
> Key: OFBIZ-9904
> URL: https://issues.apache.org/jira/browse/OFBIZ-9904
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Reporter: Parakh Maheshwari
>Assignee: Suraj Khurana
> Attachments: IssueWithRateAmount.png
>
>
> *Steps to regenerate the issue:*
> 1)Navigate to 
> [https://demo-trunk.ofbiz.apache.org/scrum/control/main?externalLoginKey=EL0a347422-1144-4dc1-9ab2-a48f17078c13]
> 2)Click on *My Profile* Tab under Scrum component.
> 3)Click on *Rates* Section:
> [https://demo-trunk.ofbiz.apache.org/scrum/control/EditPartyRates?partyId=admin]
> 4)Try to delete Existing Rate Amount Record, there is a service invocation 
> error generates while removing the record.
>   OR
> 5)If no record exists then create a new Rate Amount record then try to repeat 
> the same process as mentioned in step(4)
> Please refer the attached screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9895) Success message also showing before the party identification number is updated

2017-10-28 Thread Pallavi Goyal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pallavi Goyal updated OFBIZ-9895:
-
Attachment: OFBIZ-9895.patch

Providing patch.

Added a separate controller request for view screen without event.

> Success message also showing before the party identification number is 
> updated  
> 
>
> Key: OFBIZ-9895
> URL: https://issues.apache.org/jira/browse/OFBIZ-9895
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Assignee: Pallavi Goyal
>Priority: Trivial
> Attachments: OFBIZ-9895.patch
>
>
> *Steps to regenerate-*
> 1. Login to application.
> 2. Go to "party" component and open any party profile view page.
> 3. Go to "Identification Numbers" panel.
> 4. Create a "New" identification number for the party.
> 5. Now, go back to Party Profile View Page.
> 6. In "Identification Numbers" panel, click on "Update" button for the 
> identification number.
> 7. The "Update Party Identification" page will render with success message 
> but the number is yet to be updated.
> 8. Also, click on "Update" button in the "List Identification Number" panel. 
> The success message is showed again and the number is yet to be updated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9903) Erros in data load

2017-10-28 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti closed OFBIZ-9903.
-
Resolution: Invalid

> Erros in data load
> --
>
> Key: OFBIZ-9903
> URL: https://issues.apache.org/jira/browse/OFBIZ-9903
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Renuka Srishti
>
> From Date is missing in data related to SecurityGroupPermission entity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9905) Issue with Agreement under Accounting

2017-10-28 Thread Aayush jain (JIRA)
Aayush jain created OFBIZ-9905:
--

 Summary: Issue with Agreement under Accounting
 Key: OFBIZ-9905
 URL: https://issues.apache.org/jira/browse/OFBIZ-9905
 Project: OFBiz
  Issue Type: Bug
 Environment: 
https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
Reporter: Aayush jain


Following issues found:
1. Create Agreement opens an edit agreement window
2. Able to Create Agreement without any detail (empty Agreement) 

Steps:
1. Open URL https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
2. Navigate to Agreement section
3. Click on create Agreement
4. Click submit button

Actual: Agreement id is generated for empty agreement and when create window 
opens, it's redirection is wrong to edit window

Expected: Proper redirection should be there (create agreement) and if an 
agreement is created without any details its of no use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9895) Success message also showing before the party identification number is updated

2017-10-28 Thread Pallavi Goyal (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223339#comment-16223339
 ] 

Pallavi Goyal commented on OFBIZ-9895:
--

*Steps to verify:*
1. Go to any party profile view page.
2. Add a new party identification.
3. Again to party profile page and click on "Update" button for the added party 
identification.
4. The "Update Party Identification" page will open.
5. Success message for updation will not show.
6. Update the identification.
7. Success message will show only after updation.

> Success message also showing before the party identification number is 
> updated  
> 
>
> Key: OFBIZ-9895
> URL: https://issues.apache.org/jira/browse/OFBIZ-9895
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Assignee: Pallavi Goyal
>Priority: Trivial
> Attachments: OFBIZ-9895.patch
>
>
> *Steps to regenerate-*
> 1. Login to application.
> 2. Go to "party" component and open any party profile view page.
> 3. Go to "Identification Numbers" panel.
> 4. Create a "New" identification number for the party.
> 5. Now, go back to Party Profile View Page.
> 6. In "Identification Numbers" panel, click on "Update" button for the 
> identification number.
> 7. The "Update Party Identification" page will render with success message 
> but the number is yet to be updated.
> 8. Also, click on "Update" button in the "List Identification Number" panel. 
> The success message is showed again and the number is yet to be updated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-7722) Sub-menu looks overlapping in Tomahawk theme

2017-10-28 Thread Ayushi Rathod (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayushi Rathod closed OFBIZ-7722.

Resolution: Fixed

> Sub-menu looks overlapping in Tomahawk theme
> 
>
> Key: OFBIZ-7722
> URL: https://issues.apache.org/jira/browse/OFBIZ-7722
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Swapnil Shah
>Assignee: Ayushi Rathod
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7722.patch, OFBIZ-7722.png, Theme.png
>
>
> Please refer to attached screenshot for reference



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9904) Issue while removing RateAmount Record

2017-10-28 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-9904:
-
Attachment: OFBIZ-9904.patch

Here is the proposed patch with the proper fix.

> Issue while removing RateAmount Record
> --
>
> Key: OFBIZ-9904
> URL: https://issues.apache.org/jira/browse/OFBIZ-9904
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Reporter: Parakh Maheshwari
>Assignee: Suraj Khurana
> Attachments: IssueWithRateAmount.png, OFBIZ-9904.patch
>
>
> *Steps to regenerate the issue:*
> 1)Navigate to 
> [https://demo-trunk.ofbiz.apache.org/scrum/control/main?externalLoginKey=EL0a347422-1144-4dc1-9ab2-a48f17078c13]
> 2)Click on *My Profile* Tab under Scrum component.
> 3)Click on *Rates* Section:
> [https://demo-trunk.ofbiz.apache.org/scrum/control/EditPartyRates?partyId=admin]
> 4)Try to delete Existing Rate Amount Record, there is a service invocation 
> error generates while removing the record.
>   OR
> 5)If no record exists then create a new Rate Amount record then try to repeat 
> the same process as mentioned in step(4)
> Please refer the attached screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9906) Inconsistent styling in Tomahawk theme

2017-10-28 Thread Ayushi Rathod (JIRA)
Ayushi Rathod created OFBIZ-9906:


 Summary: Inconsistent styling in Tomahawk theme
 Key: OFBIZ-9906
 URL: https://issues.apache.org/jira/browse/OFBIZ-9906
 Project: OFBiz
  Issue Type: Improvement
  Components: content, order
Reporter: Ayushi Rathod
Assignee: Ayushi Rathod
Priority: Trivial


Misleading background on view CompDoc template tree screen and Return order 
view screen in Tomahawk theme.

Screenshots of the conflicting background are attached for reference.







--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9902) Create a DATAMODELCHANGES.md to track data model changes

2017-10-28 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223361#comment-16223361
 ] 

Michael Brohl commented on OFBIZ-9902:
--

Thanks for the initiative, [~aditya.sharma]!

I think we should additionally provide SQL migration scripts along with the 
changes.
As an example: we lately introduced the fromDate as part of the PK in 
SecurityPermission.

So additionally to the change log you proposed, I would add a migration SQL for 
the Derby database.

{code:sql}
ALTER TABLE SECURITY_PERMISSION ADD FROM_DATE DATETIME;
UPDATE SECURITY_PERMISSION SET FROM_DATE = '2017-01-01 00:00:00.0';
ALTER TABLE SECURITY_PERMISSION DROP PRIMARY_KEY, ADD PRIMARY KEY 
(PERMISSION_ID, FROM_DATE);
{code}

(this might be syntactically incorrect, it's only an example).

I also would like to see every change in order of it's introduction. So the 
order would not be on the entity level but on the database level.
By changing primary keys and such, relations could also be affected and I think 
it would make sense to have everything in order, especially for migrations.

In our db changelogs, we also list new seed data as OFBiz load data to prevent 
missing data which is needed by added or changed funtionality.

In my view, the main use case of a db changelog is to help users keep their 
database up-to-date without the need to monitor everything themselves and do a 
migration by trial-and-error so it should be as comprehensive as possible.

As a general rule, I would like to introduce the guideline to provide a 
changelog along with every database or functionality change affecting the data, 
latest within the commit. If you take the time to work this out, we should take 
care to keep it up-to-date in the community.

Thanks,
Michael

> Create a DATAMODELCHANGES.md to track data model changes
> 
>
> Key: OFBIZ-9902
> URL: https://issues.apache.org/jira/browse/OFBIZ-9902
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>
> The file will have the format:
> Entity Changes:
> Here we will have a bulleted list with entity names and the revision changes 
> took place
> 1. Added Entities
> 2. Removed Entities
> Field changes:
> Here we will show data in tabular form in format
> entityname | field | action | isPK | revision



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9906) Inconsistent styling in Tomahawk theme

2017-10-28 Thread Ayushi Rathod (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayushi Rathod updated OFBIZ-9906:
-
Attachment: ReturnLinks.png
CompDocsTree.png

> Inconsistent styling in Tomahawk theme
> --
>
> Key: OFBIZ-9906
> URL: https://issues.apache.org/jira/browse/OFBIZ-9906
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, order
>Reporter: Ayushi Rathod
>Assignee: Ayushi Rathod
>Priority: Trivial
> Attachments: CompDocsTree.png, ReturnLinks.png
>
>
> Misleading background on view CompDoc template tree screen and Return order 
> view screen in Tomahawk theme.
> Screenshots of the conflicting background are attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9906) Inconsistent styling in Tomahawk theme

2017-10-28 Thread Ayushi Rathod (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayushi Rathod updated OFBIZ-9906:
-
Attachment: ofbiz-9906.patch

> Inconsistent styling in Tomahawk theme
> --
>
> Key: OFBIZ-9906
> URL: https://issues.apache.org/jira/browse/OFBIZ-9906
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, order
>Reporter: Ayushi Rathod
>Assignee: Ayushi Rathod
>Priority: Trivial
> Attachments: CompDocsTree.png, ReturnLinks.png, ofbiz-9906.patch
>
>
> Misleading background on view CompDoc template tree screen and Return order 
> view screen in Tomahawk theme.
> Screenshots of the conflicting background are attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9854) Error when unsubscribing Newsletter from Ecommerce store

2017-10-28 Thread sourabh jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

sourabh jain updated OFBIZ-9854:

Attachment: OFBIZ-9854.patch

Added a missing attribute 'contactListId' in 'updateContactListParty' service.

> Error when unsubscribing Newsletter from Ecommerce store
> 
>
> Key: OFBIZ-9854
> URL: https://issues.apache.org/jira/browse/OFBIZ-9854
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: sourabh jain
>Priority: Trivial
> Attachments: EcommerceUnsubscribeError.png, OFBIZ-9854.patch
>
>
> Steps to regenerate:
> 1. Go to Ecommerce component 
> (https://demo-trunk.ofbiz.apache.org/ecommerce/control/main)
> 2. From Sign up from Contact List section, select newsletter, provide an 
> already subscribed email  address and click on unsubscribe
> Following error message:
> {code:java}
> ERROR: Could not complete the Unsubscribe for contact list 
> [file:/home/ofbizDemo/trunk/applications/marketing/minilang/marketing/contact/ContactListServices.xml#unsubscribeContactListParty]
>  process [problem invoking the [updateContactListParty] service with the map 
> named [updateContactListPartyMap] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2017-10-17 
> 03:06:03.658(java.sql.Timestamp)][createdTxStamp,2017-10-17 
> 03:06:03.504(java.sql.Timestamp)][currentPassword,null()][disabledBy,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2017-10-17
>  03:06:11.284(java.sql.Timestamp)][lastUpdatedTxStamp,2017-10-17 
> 03:06:11.22(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>  statusId=CLPT_UNSUBS_PENDING, baseLocation=/ecommerce, contactListId=9000, 
> preferredContactMechId=1, partyId=_NA_, locale=en_US}]: Outgoing result 
> (in runSync : updateContactListParty) does not match expected requirements 
> (Unknown parameter found: [updateContactListParty.contactListId])]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9906) Inconsistent styling in Tomahawk theme

2017-10-28 Thread Ayushi Rathod (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayushi Rathod updated OFBIZ-9906:
-
Description: 
Misleading background on :

1. View CompDoc template tree screen
- 
https://demo-trunk.ofbiz.apache.org/content/control/ViewCompDocTemplateTree?rootContentId=CDT1201

and Return order view screen 
- https://demo-trunk.ofbiz.apache.org/ordermgr/control/returnMain?returnId=10003


Screenshots of the conflicting background are attached for reference.





  was:
Misleading background on view CompDoc template tree screen and Return order 
view screen in Tomahawk theme.

Screenshots of the conflicting background are attached for reference.






> Inconsistent styling in Tomahawk theme
> --
>
> Key: OFBIZ-9906
> URL: https://issues.apache.org/jira/browse/OFBIZ-9906
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, order
>Reporter: Ayushi Rathod
>Assignee: Ayushi Rathod
>Priority: Trivial
> Attachments: CompDocsTree.png, ReturnLinks.png, ofbiz-9906.patch
>
>
> Misleading background on :
> 1. View CompDoc template tree screen
> - 
> https://demo-trunk.ofbiz.apache.org/content/control/ViewCompDocTemplateTree?rootContentId=CDT1201
> and Return order view screen 
> - 
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/returnMain?returnId=10003
> Screenshots of the conflicting background are attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9906) Inconsistent styling in Tomahawk theme

2017-10-28 Thread Ayushi Rathod (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayushi Rathod updated OFBIZ-9906:
-
Description: 
Misleading background in Tomahawk theme on :

1. View CompDoc template tree screen
- 
https://demo-trunk.ofbiz.apache.org/content/control/ViewCompDocTemplateTree?rootContentId=CDT1201

and Return order view screen 
- https://demo-trunk.ofbiz.apache.org/ordermgr/control/returnMain?returnId=10003


Screenshots of the conflicting background are attached for reference.





  was:
Misleading background on :

1. View CompDoc template tree screen
- 
https://demo-trunk.ofbiz.apache.org/content/control/ViewCompDocTemplateTree?rootContentId=CDT1201

and Return order view screen 
- https://demo-trunk.ofbiz.apache.org/ordermgr/control/returnMain?returnId=10003


Screenshots of the conflicting background are attached for reference.






> Inconsistent styling in Tomahawk theme
> --
>
> Key: OFBIZ-9906
> URL: https://issues.apache.org/jira/browse/OFBIZ-9906
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, order
>Reporter: Ayushi Rathod
>Assignee: Ayushi Rathod
>Priority: Trivial
> Attachments: CompDocsTree.png, ReturnLinks.png, ofbiz-9906.patch
>
>
> Misleading background in Tomahawk theme on :
> 1. View CompDoc template tree screen
> - 
> https://demo-trunk.ofbiz.apache.org/content/control/ViewCompDocTemplateTree?rootContentId=CDT1201
> and Return order view screen 
> - 
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/returnMain?returnId=10003
> Screenshots of the conflicting background are attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9906) Inconsistent styling in Tomahawk theme

2017-10-28 Thread Ayushi Rathod (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223374#comment-16223374
 ] 

Ayushi Rathod commented on OFBIZ-9906:
--

Improved the misleading background color on tomahawk themed screens. I am 
providing the patch for correcting styling in Tomahawk theme for order history 
and compDocs tree screen.

The patch has been attached.


> Inconsistent styling in Tomahawk theme
> --
>
> Key: OFBIZ-9906
> URL: https://issues.apache.org/jira/browse/OFBIZ-9906
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, order
>Reporter: Ayushi Rathod
>Assignee: Ayushi Rathod
>Priority: Trivial
> Attachments: CompDocsTree.png, ReturnLinks.png, ofbiz-9906.patch
>
>
> Misleading background in Tomahawk theme on :
> 1. View CompDoc template tree screen
> - 
> https://demo-trunk.ofbiz.apache.org/content/control/ViewCompDocTemplateTree?rootContentId=CDT1201
> and Return order view screen 
> - 
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/returnMain?returnId=10003
> Screenshots of the conflicting background are attached for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9755) ShoppingCart's 'getPaymentMethodTypes' method should use 'getPaymentMethodTypeIds' internally instead of 'getPaymentMethodIds'

2017-10-28 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9755.
---
   Resolution: Fixed
Fix Version/s: (was: Trunk)
   Upcoming Release

Committed revision 1813598

Thanks Amit Gadaley, Deepak Dixit, Divesh Dutta and Mridul Pathak for your 
contribution.

> ShoppingCart's 'getPaymentMethodTypes' method should use 
> 'getPaymentMethodTypeIds' internally instead of 'getPaymentMethodIds'
> --
>
> Key: OFBIZ-9755
> URL: https://issues.apache.org/jira/browse/OFBIZ-9755
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Arun Patidar
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9755.patch
>
>
> ShoppingCart's 'getPaymentMethodTypes' method should use 
> 'getPaymentMethodTypeIds' internally instead of 'getPaymentMethodIds'. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-1585) Credit card valdation does not work properly during anonymous quick checkout process

2017-10-28 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-1585.
-
   Resolution: Fixed
Fix Version/s: Upcoming Release

Committed revision 1813598

Thanks Amit Gadaley, Deepak Dixit, Divesh Dutta and Mridul Pathak for your 
contribution.

> Credit card valdation does not work properly during anonymous quick checkout 
> process
> 
>
> Key: OFBIZ-1585
> URL: https://issues.apache.org/jira/browse/OFBIZ-1585
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
> Environment: Ubuntu 7.10, Firefox 2.0.0.11
>Reporter: Raj Saini
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-1585.patch, OFBIZ-1585.patch, OFBIZ-1585.patch, 
> credit-card-validation.png, credit-card-validation2.png
>
>
> If a credit card is selected as payment method and process button is pressed 
> without adding all mandatory fields of credit card, order will be summited 
> despite showing the validation error on credit card and user have no choice 
> of rectifying the validation errors. 
> Screenshot is attached showing this behavior 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9680) No option to add Event Purpose on Events page.

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-9680:
--
Issue Type: Improvement  (was: Bug)

I think this is an improvement.

> No option to add Event Purpose on Events page.
> --
>
> Key: OFBIZ-9680
> URL: https://issues.apache.org/jira/browse/OFBIZ-9680
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Sonal Patwari
>Assignee: Akash Jain
> Attachments: OFBIZ-9680.patch
>
>
> Navigate to SFA component > Events > Create Event.
> - While creating an event, there is no option to enter purpose.
> - On Events screen there is 'Purpose' field in the table which remains empty 
> as there is no option for adding it.
> Here are the helpful links :
> - [Events Page|https://demo-stable.ofbiz.apache.org/sfa/control/Events]
> - [Create Event|https://demo-stable.ofbiz.apache.org/sfa/control/EditEvent]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9856) Add rat exclude files to excludes those files that does not need license header

2017-10-28 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223379#comment-16223379
 ] 

Jacques Le Roux commented on OFBIZ-9856:


Hi Deepak,

I answered you also on HipChat
bq. I'll wait infra return on INFRA-15395 because it's not clear to me how to 
do that in Buildbot

> Add rat exclude files to excludes those files that does not need license 
> header 
> 
>
> Key: OFBIZ-9856
> URL: https://issues.apache.org/jira/browse/OFBIZ-9856
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>
> As recently we added Apache Rat in Buildbot, Rat audits software 
> distributions, with a special interest in headers.
> Here is the Rat report for ofbiz
> https://ci.apache.org/projects/ofbiz/rat-output.html
> In this reports there are several files that does not need license header 
> like *.svg etc.
> Rat provide a way to exclude files while auditing
> http://creadur.apache.org/rat/apache-rat/
> {quote}
> It is common to use the Rat with the Maven or Ant plugins and specify a 
> series of files to exclude (such as a README or version control files). If 
> you are using the Rat application instead of a plugin you can specify a 
> series of regex excludes in a file and specify that with the -E option.
> {quote}
> We can add .rat-excludes.txt files at ofbiz root for this purpose.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9897) Add ability to disable entity eca rule

2017-10-28 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9897:

Attachment: OFBIZ-9897.patch

Here is the patch for this issue. 

> Add ability to disable entity eca rule 
> ---
>
> Key: OFBIZ-9897
> URL: https://issues.apache.org/jira/browse/OFBIZ-9897
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Attachments: OFBIZ-9897.patch
>
>
> We have enabled flag in EntityEcaRule class, if its set false then entity eca 
> rule will not be execute.
> But there is not way to disable entity eca.
> We can add enabled flag in Entity ECA definition to disable the existing 
> entity eca rule.
> - Add new attribute on entity eca tag named enabled
> - Default value will be true for this.
> - If user want to disable existing OOTB entity eca rule, then user can define 
> same rule in custom component and set the enabled=false
> Also as per current flow if same seca rule is define more then once, system 
> will execute all the rule, ideally it should not execute same rule (same 
> rule, condition and action) if its defined more than one.
> Also need to ovride hasCode, equals and toString method for EntityEcaRule 
> class file. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9680) No option to add Event Purpose on Events page.

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain resolved OFBIZ-9680.
---
   Resolution: Done
Fix Version/s: Upcoming Release

This has been fixed on ofbiz-framework trunk at r#1813597

Done these changes in attached patch:
-- used existing ui label
-- corrected positioning of purpose type field

Thanks, Sonal Patwari and Lalit Dashora for your contribution.

> No option to add Event Purpose on Events page.
> --
>
> Key: OFBIZ-9680
> URL: https://issues.apache.org/jira/browse/OFBIZ-9680
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Sonal Patwari
>Assignee: Akash Jain
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9680.patch
>
>
> Navigate to SFA component > Events > Create Event.
> - While creating an event, there is no option to enter purpose.
> - On Events screen there is 'Purpose' field in the table which remains empty 
> as there is no option for adding it.
> Here are the helpful links :
> - [Events Page|https://demo-stable.ofbiz.apache.org/sfa/control/Events]
> - [Create Event|https://demo-stable.ofbiz.apache.org/sfa/control/EditEvent]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9680) No option to add Event Purpose on Events page.

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9680.
-

> No option to add Event Purpose on Events page.
> --
>
> Key: OFBIZ-9680
> URL: https://issues.apache.org/jira/browse/OFBIZ-9680
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Sonal Patwari
>Assignee: Akash Jain
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9680.patch
>
>
> Navigate to SFA component > Events > Create Event.
> - While creating an event, there is no option to enter purpose.
> - On Events screen there is 'Purpose' field in the table which remains empty 
> as there is no option for adding it.
> Here are the helpful links :
> - [Events Page|https://demo-stable.ofbiz.apache.org/sfa/control/Events]
> - [Create Event|https://demo-stable.ofbiz.apache.org/sfa/control/EditEvent]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9890) Having condition is ignored on queryList() and queryFirst() calls in EntityQuery

2017-10-28 Thread Prakhar Kumar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prakhar Kumar reassigned OFBIZ-9890:


Assignee: Prakhar Kumar

> Having condition is ignored on queryList() and queryFirst() calls in 
> EntityQuery
> 
>
> Key: OFBIZ-9890
> URL: https://issues.apache.org/jira/browse/OFBIZ-9890
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Prakhar Kumar
>Priority: Critical
>
> queryList() and queryFirst() both call internal private query() method. This 
> method calls delegator.findList if a normal Entity/ViewEntity is used (not a 
> DVE). This has no option to include a having condition and so must opt to use 
> queryIterator(). Even queryCount() can use a having condition



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9697) Create Related Account from Contact Profile redirect to empty profile screen.

2017-10-28 Thread Ankit Joshi (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi updated OFBIZ-9697:
---
Attachment: OFBIZ-9697.patch

Added patch with a proper fix.

> Create Related Account from Contact Profile redirect to empty profile screen.
> -
>
> Key: OFBIZ-9697
> URL: https://issues.apache.org/jira/browse/OFBIZ-9697
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ankit Joshi
>Assignee: Ankit Joshi
>  Labels: sfa
> Attachments: OFBIZ-9697.patch
>
>
> Steps to Regenerate -
> 1) Navigate to SFA and search for contacts.
> 2) Move to Contact Profile detail screen.
> 3) Click on Create New button to create Related Accounts for the Contact.
> Actual: It redirects to the empty profile screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9697) Create Related Account from Contact Profile redirect to empty profile screen.

2017-10-28 Thread Ankit Joshi (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi reassigned OFBIZ-9697:
--

Assignee: (was: Ankit Joshi)

> Create Related Account from Contact Profile redirect to empty profile screen.
> -
>
> Key: OFBIZ-9697
> URL: https://issues.apache.org/jira/browse/OFBIZ-9697
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ankit Joshi
>  Labels: sfa
> Attachments: OFBIZ-9697.patch
>
>
> Steps to Regenerate -
> 1) Navigate to SFA and search for contacts.
> 2) Move to Contact Profile detail screen.
> 3) Click on Create New button to create Related Accounts for the Contact.
> Actual: It redirects to the empty profile screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2017-10-28 Thread Aishwary Shrivastava (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aishwary Shrivastava updated OFBIZ-8411:

Attachment: OFBIZ-8411.patch

Attaching Patch for this issue.

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Aishwary Shrivastava
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9907) Replace ContentAssoc related CRUD services with entity-auto

2017-10-28 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-9907:


 Summary: Replace ContentAssoc related CRUD services with 
entity-auto
 Key: OFBIZ-9907
 URL: https://issues.apache.org/jira/browse/OFBIZ-9907
 Project: OFBiz
  Issue Type: Bug
  Components: content
Reporter: Suraj Khurana
Assignee: Suraj Khurana


Currently, we have unnecessary service written which can be converted to 
entity-auto service for ContentAssoc entity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9503) Fixed Asset Id field is below update button on EditInventoryItem page

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain resolved OFBIZ-9503.
---
   Resolution: Fixed
Fix Version/s: 16.11.04

This has been fixed on ofbiz-framework trunk at r#1813600 and release16.11 at 
r#1813603.

Changed position of Fixed Asset Id field in the attached patch.

Thanks, Aditya Sharma and Dhaval Wagela for your contribution.

> Fixed Asset Id field is below update button on EditInventoryItem page
> -
>
> Key: OFBIZ-9503
> URL: https://issues.apache.org/jira/browse/OFBIZ-9503
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Akash Jain
>Priority: Trivial
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9503.patch
>
>
> Steps to reproduce:
> 1. Go to Facility component 
> (https://demo-trunk.ofbiz.apache.org/facility/control/main)
> 2. Select facility and click on submit button 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacility)
> 3. Click on Inventory item in sub menu 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacilityInventoryItems?facilityId=WebStoreWarehouse)
> 4. Click on id link of any inventory item 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditInventoryItem?inventoryItemId=9003&facilityId=WebStoreWarehouse)
> Fixed Asset Id field is below Update button



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9503) Fixed Asset Id field is below update button on EditInventoryItem page

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9503.
-

> Fixed Asset Id field is below update button on EditInventoryItem page
> -
>
> Key: OFBIZ-9503
> URL: https://issues.apache.org/jira/browse/OFBIZ-9503
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Akash Jain
>Priority: Trivial
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9503.patch
>
>
> Steps to reproduce:
> 1. Go to Facility component 
> (https://demo-trunk.ofbiz.apache.org/facility/control/main)
> 2. Select facility and click on submit button 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacility)
> 3. Click on Inventory item in sub menu 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditFacilityInventoryItems?facilityId=WebStoreWarehouse)
> 4. Click on id link of any inventory item 
> (https://demo-trunk.ofbiz.apache.org/facility/control/EditInventoryItem?inventoryItemId=9003&facilityId=WebStoreWarehouse)
> Fixed Asset Id field is below Update button



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9757) Required field indicator (*) is missing on edit data resource role

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-9757:
-

Assignee: Akash Jain  (was: Rohit Rai)

> Required field indicator (*) is missing on edit data resource role
> --
>
> Key: OFBIZ-9757
> URL: https://issues.apache.org/jira/browse/OFBIZ-9757
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Akash Jain
> Attachments: OFBIZ-9757.patch
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> no required symbol for the required parameters, as a result, service throws 
> missing parameter error.
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9756) Required field indicator (*) is missing from create contact list.

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-9756:
-

Assignee: Akash Jain  (was: Rohit Rai)

> Required field indicator (*) is missing from create contact list.
> -
>
> Key: OFBIZ-9756
> URL: https://issues.apache.org/jira/browse/OFBIZ-9756
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Akash Jain
> Attachments: OFBIZ-9756.patch
>
>
> 1. go to content -> website
> 2. find websites -> select a website from the link
> 3. Click on contact lists from the submenu.
> contact list id is a required field,
> Quick link to test the issue,
> https://demo-trunk.ofbiz.apache.org/content/control/createWebSiteContactList



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9904) Issue while removing RateAmount Record

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-9904:
-

Assignee: Akash Jain  (was: Suraj Khurana)

> Issue while removing RateAmount Record
> --
>
> Key: OFBIZ-9904
> URL: https://issues.apache.org/jira/browse/OFBIZ-9904
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Reporter: Parakh Maheshwari
>Assignee: Akash Jain
> Attachments: IssueWithRateAmount.png, OFBIZ-9904.patch
>
>
> *Steps to regenerate the issue:*
> 1)Navigate to 
> [https://demo-trunk.ofbiz.apache.org/scrum/control/main?externalLoginKey=EL0a347422-1144-4dc1-9ab2-a48f17078c13]
> 2)Click on *My Profile* Tab under Scrum component.
> 3)Click on *Rates* Section:
> [https://demo-trunk.ofbiz.apache.org/scrum/control/EditPartyRates?partyId=admin]
> 4)Try to delete Existing Rate Amount Record, there is a service invocation 
> error generates while removing the record.
>   OR
> 5)If no record exists then create a new Rate Amount record then try to repeat 
> the same process as mentioned in step(4)
> Please refer the attached screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9902) Create a DATAMODELCHANGES.md to track data model changes

2017-10-28 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9902:
-
Attachment: DATAMODELCHANGES.md

Hi Michael,
Totally agreed on that.
I am attaching the file with format & some initial data. Please have a look and 
provide inputs if any.

> Create a DATAMODELCHANGES.md to track data model changes
> 
>
> Key: OFBIZ-9902
> URL: https://issues.apache.org/jira/browse/OFBIZ-9902
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
> Attachments: DATAMODELCHANGES.md
>
>
> The file will have the format:
> Entity Changes:
> Here we will have a bulleted list with entity names and the revision changes 
> took place
> 1. Added Entities
> 2. Removed Entities
> Field changes:
> Here we will show data in tabular form in format
> entityname | field | action | isPK | revision



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9763) Create separate Permission Services for CRUD services of ShoppingList and ShoppingListItem

2017-10-28 Thread Chinmay Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Patidar updated OFBIZ-9763:
---
Attachment: OFBIZ-9763.patch

Updated the patch with an occurrence which was left out. i.e. replace the 
method call to 'checkShoppingListItemSecurity' with service call as it's 
converted into a service.

> Create separate Permission Services for CRUD services of ShoppingList and 
> ShoppingListItem
> --
>
> Key: OFBIZ-9763
> URL: https://issues.apache.org/jira/browse/OFBIZ-9763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce, party
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Chinmay Patidar
>Assignee: Arun Patidar
> Fix For: Trunk
>
> Attachments: OFBIZ-9763.patch, OFBIZ-9763.patch
>
>
> In CRUD services for ShoppingList and ShoppingListItem entities, the security 
> related checks are present inline in the services. This implementation 
> violates the best practice of keeping security implementation different from 
> the business logic.
> We need to implement security services for such operations and to call them 
> as a permission-service from the CRUD operation services definition



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9907) Replace ContentAssoc related CRUD services with entity-auto

2017-10-28 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-9907:
-
Attachment: OFBIZ-9907.patch

Here is the proposed patch with proper improvements.

> Replace ContentAssoc related CRUD services with entity-auto
> ---
>
> Key: OFBIZ-9907
> URL: https://issues.apache.org/jira/browse/OFBIZ-9907
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-9907.patch
>
>
> Currently, we have unnecessary service written which can be converted to 
> entity-auto service for ContentAssoc entity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2017-10-28 Thread Ritesh Kumar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ritesh Kumar updated OFBIZ-9759:

Attachment: OFBIZ-9759.patch

> Fiscal Gl type is reflecting twice in drop-down of Cost Centers.
> 
>
> Key: OFBIZ-9759
> URL: https://issues.apache.org/jira/browse/OFBIZ-9759
> Project: OFBiz
>  Issue Type: Improvement
> Environment: 
> https://ofbiz-trunk.hotwaxsystems.com/accounting/control/GlAccountBalanceByCostCenter?organizationPartyId=Company
>Reporter: Tejas Khanna
>Assignee: Ritesh Kumar
>Priority: Minor
> Attachments: OFBIZ-9759.patch
>
>
> Steps to reproduce:
> 1. Select Accounting from Applications.
> 2. Select Organization GL Settings from Accounting Manager.
> 3. Click on accounting.
> 4. Click on Reports
> 5. Select Cost Centers
> 6. Choose Fiscal Gl Type drop-down.
> Actual result: on selecting Gl Type from drop-down, selected Gl Type is 
> reflecting twice.
> Expected result: Selected value should come only once in drop-down after 
> report generation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9908) Quick Add button for shopping list on Orderentry screen is not working

2017-10-28 Thread Garima jain (JIRA)
Garima jain created OFBIZ-9908:
--

 Summary: Quick Add button for shopping list on Orderentry screen 
is not working
 Key: OFBIZ-9908
 URL: https://issues.apache.org/jira/browse/OFBIZ-9908
 Project: OFBiz
  Issue Type: Bug
  Components: order
Reporter: Garima jain
Priority: Minor


steps to generate 
1. Navigate to https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
2. Press continue on sales order screen.
3. Add any finished good  product to the sales order
4. In 'Add Order Items to Shopping List' section, select 'new shopping list' 
from the drop down and click on 'Add to shopping list' button
5. you navigate to 'addBulkToShoppingList' screen, click on 'Quick Add' button.
Issue: The quick add button is not working.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2017-10-28 Thread Ritesh Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223425#comment-16223425
 ] 

Ritesh Kumar commented on OFBIZ-9759:
-

The currently selected value is displayed on the top of the drop-down list. 
This proposed patch contains a  check to prevent the redundant display of the 
current value. 

> Fiscal Gl type is reflecting twice in drop-down of Cost Centers.
> 
>
> Key: OFBIZ-9759
> URL: https://issues.apache.org/jira/browse/OFBIZ-9759
> Project: OFBiz
>  Issue Type: Improvement
> Environment: 
> https://ofbiz-trunk.hotwaxsystems.com/accounting/control/GlAccountBalanceByCostCenter?organizationPartyId=Company
>Reporter: Tejas Khanna
>Assignee: Ritesh Kumar
>Priority: Minor
> Attachments: OFBIZ-9759.patch
>
>
> Steps to reproduce:
> 1. Select Accounting from Applications.
> 2. Select Organization GL Settings from Accounting Manager.
> 3. Click on accounting.
> 4. Click on Reports
> 5. Select Cost Centers
> 6. Choose Fiscal Gl Type drop-down.
> Actual result: on selecting Gl Type from drop-down, selected Gl Type is 
> reflecting twice.
> Expected result: Selected value should come only once in drop-down after 
> report generation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (OFBIZ-9904) Issue while removing RateAmount Record

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain resolved OFBIZ-9904.
---
   Resolution: Fixed
Fix Version/s: Upcoming Release

This has been fixed on ofbiz-framework trunk at r#1813608

Thanks, Parakh Maheshwari and Suraj Khurana for your contribution.

> Issue while removing RateAmount Record
> --
>
> Key: OFBIZ-9904
> URL: https://issues.apache.org/jira/browse/OFBIZ-9904
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Reporter: Parakh Maheshwari
>Assignee: Akash Jain
> Fix For: Upcoming Release
>
> Attachments: IssueWithRateAmount.png, OFBIZ-9904.patch
>
>
> *Steps to regenerate the issue:*
> 1)Navigate to 
> [https://demo-trunk.ofbiz.apache.org/scrum/control/main?externalLoginKey=EL0a347422-1144-4dc1-9ab2-a48f17078c13]
> 2)Click on *My Profile* Tab under Scrum component.
> 3)Click on *Rates* Section:
> [https://demo-trunk.ofbiz.apache.org/scrum/control/EditPartyRates?partyId=admin]
> 4)Try to delete Existing Rate Amount Record, there is a service invocation 
> error generates while removing the record.
>   OR
> 5)If no record exists then create a new Rate Amount record then try to repeat 
> the same process as mentioned in step(4)
> Please refer the attached screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9904) Issue while removing RateAmount Record

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9904.
-

> Issue while removing RateAmount Record
> --
>
> Key: OFBIZ-9904
> URL: https://issues.apache.org/jira/browse/OFBIZ-9904
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Reporter: Parakh Maheshwari
>Assignee: Akash Jain
> Fix For: Upcoming Release
>
> Attachments: IssueWithRateAmount.png, OFBIZ-9904.patch
>
>
> *Steps to regenerate the issue:*
> 1)Navigate to 
> [https://demo-trunk.ofbiz.apache.org/scrum/control/main?externalLoginKey=EL0a347422-1144-4dc1-9ab2-a48f17078c13]
> 2)Click on *My Profile* Tab under Scrum component.
> 3)Click on *Rates* Section:
> [https://demo-trunk.ofbiz.apache.org/scrum/control/EditPartyRates?partyId=admin]
> 4)Try to delete Existing Rate Amount Record, there is a service invocation 
> error generates while removing the record.
>   OR
> 5)If no record exists then create a new Rate Amount record then try to repeat 
> the same process as mentioned in step(4)
> Please refer the attached screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9509) Order : Remove unused imports from groovy files for code optimization.

2017-10-28 Thread Pradeep Choudhary (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-9509:
-
Attachment: OFBIZ-9509.patch

> Order : Remove unused imports from groovy files for code optimization.
> --
>
> Key: OFBIZ-9509
> URL: https://issues.apache.org/jira/browse/OFBIZ-9509
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Pradeep Choudhary
>Priority: Minor
> Attachments: OFBIZ-9509.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9675) Use ofbizCurrency macro and remove hardcoded ##0.00 string

2017-10-28 Thread Ritesh Kumar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ritesh Kumar reassigned OFBIZ-9675:
---

Assignee: Ritesh Kumar  (was: Renuka Srishti)

> Use ofbizCurrency macro and remove hardcoded ##0.00 string
> --
>
> Key: OFBIZ-9675
> URL: https://issues.apache.org/jira/browse/OFBIZ-9675
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Ritesh Kumar
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2017-10-28 Thread Aishwary Shrivastava (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223430#comment-16223430
 ] 

Aishwary Shrivastava commented on OFBIZ-8411:
-

I explored this issue and found that CSS for popup was not there in  style.css, 
which is style sheet of Multiflex.

I explored other theme's CSS and found that every other theme has CSS for popup 
class.
I think adding CSS for popup will do the work.

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Aishwary Shrivastava
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9509) Order : Remove unused imports from groovy files for code optimization.

2017-10-28 Thread Pradeep Choudhary (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-9509:
-
Attachment: (was: OFBIZ-9509.patch)

> Order : Remove unused imports from groovy files for code optimization.
> --
>
> Key: OFBIZ-9509
> URL: https://issues.apache.org/jira/browse/OFBIZ-9509
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Pradeep Choudhary
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9769) Instead of using title and labels, use single label for independent fields

2017-10-28 Thread Garima jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Garima jain updated OFBIZ-9769:
---
Attachment: OFBIZ-9769.patch

Patch is available for create lead screen. I will provide the patch for other 
screens later.
Removed extra title field from the screen.

> Instead of using title and labels, use single label for independent fields
> --
>
> Key: OFBIZ-9769
> URL: https://issues.apache.org/jira/browse/OFBIZ-9769
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Garima jain
>Assignee: Garima jain
>Priority: Minor
> Attachments: OFBIZ-9769.patch
>
>
> If there are multiple input fields and all belong to same group/category(like 
> address1, address2, city and state input fields belong to Address category) 
> in a form then we can use a title for such type of categories. But, if there 
> is only a single field (like Email address has single input field) then we 
> should not use the title for it.
>  Here is the reference 
> https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer
> Like for Email address does not require Title and label both we can only use 
> title for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9769) Instead of using title and labels, use single label for independent fields

2017-10-28 Thread Garima jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Garima jain updated OFBIZ-9769:
---
Description: 
If there are multiple input fields and all belong to same group/category(like 
address1, address2, city and state input fields belong to Address category) in 
a form then we can use a title for such type of categories. But, if there is 
only a single field (like Email address has single input field) then we should 
not use the title for it.


 Here is the reference 
https://demo-trunk.ofbiz.apache.org/sfa/control/NewLead
https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer

Like for Email address does not require Title and label both we can only use 
title for it.



  was:
If there are multiple input fields and all belong to same group/category(like 
address1, address2, city and state input fields belong to Address category) in 
a form then we can use a title for such type of categories. But, if there is 
only a single field (like Email address has single input field) then we should 
not use the title for it.


 Here is the reference 
https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer

Like for Email address does not require Title and label both we can only use 
title for it.




> Instead of using title and labels, use single label for independent fields
> --
>
> Key: OFBIZ-9769
> URL: https://issues.apache.org/jira/browse/OFBIZ-9769
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Garima jain
>Assignee: Garima jain
>Priority: Minor
> Attachments: OFBIZ-9769.patch
>
>
> If there are multiple input fields and all belong to same group/category(like 
> address1, address2, city and state input fields belong to Address category) 
> in a form then we can use a title for such type of categories. But, if there 
> is only a single field (like Email address has single input field) then we 
> should not use the title for it.
>  Here is the reference 
> https://demo-trunk.ofbiz.apache.org/sfa/control/NewLead
> https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer
> Like for Email address does not require Title and label both we can only use 
> title for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7606) Set the default value for macros

2017-10-28 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223436#comment-16223436
 ] 

Deepak Dixit commented on OFBIZ-7606:
-

Hi Aditya,

I think we can use data-mask attrribute to recognize the element instead of 
adding class. 

> Set the default value for macros 
> -
>
> Key: OFBIZ-7606
> URL: https://issues.apache.org/jira/browse/OFBIZ-7606
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>
> Need to set the default value for all the macros, so that at the time of 
> calling we don't need to pass all the parameters. As per current 
> implementation we have to pass all the parameters with as empty value. We 
> have support in freemarker to set the default in macros.
> This pattern has been used in htmlTemplate.lookupField macro. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9509) Order : Remove unused imports from groovy files for code optimization.

2017-10-28 Thread Pradeep Choudhary (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-9509:
-
Attachment: OFBIZ-9509.patch

> Order : Remove unused imports from groovy files for code optimization.
> --
>
> Key: OFBIZ-9509
> URL: https://issues.apache.org/jira/browse/OFBIZ-9509
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Pradeep Choudhary
>Priority: Minor
> Attachments: OFBIZ-9509.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9465) Replace Inline Javascript with External Javascript

2017-10-28 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223439#comment-16223439
 ] 

Deepak Dixit commented on OFBIZ-9465:
-

Hi Aditya,

I think we can use data-mask attrribute to recognize the element instead of 
adding class. 

> Replace Inline Javascript with External Javascript 
> ---
>
> Key: OFBIZ-9465
> URL: https://issues.apache.org/jira/browse/OFBIZ-9465
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
> Attachments: OFBIZ-9465.patch, OFBIZ-9465.patch, OFBIZ-9465.patch, 
> OFBIZ-9465_example.patch
>
>
> As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline 
> javascript for various macros like renderLookupField, 
> makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be 
> replaced with a generic code written as external javascript. Generic 
> Javascript code should be written in OfbizUtil.js and appropriate classes or 
> identifiers should be used for applying that. Any additional data can be 
> passed with HTML 5 custom data attribute 
> (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes).
> As suggested by Jacques in  https://s.apache.org/y8P1 will introduce 
> require.js for the split javascript files in a sub-task.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Issue Comment Deleted] (OFBIZ-7606) Set the default value for macros

2017-10-28 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7606:

Comment: was deleted

(was: Hi Aditya,

I think we can use data-mask attrribute to recognize the element instead of 
adding class. )

> Set the default value for macros 
> -
>
> Key: OFBIZ-7606
> URL: https://issues.apache.org/jira/browse/OFBIZ-7606
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>
> Need to set the default value for all the macros, so that at the time of 
> calling we don't need to pass all the parameters. As per current 
> implementation we have to pass all the parameters with as empty value. We 
> have support in freemarker to set the default in macros.
> This pattern has been used in htmlTemplate.lookupField macro. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9509) Order : Remove unused imports from groovy files for code optimization.

2017-10-28 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-9509:
---

Assignee: Deepak Dixit  (was: Pradeep Choudhary)

> Order : Remove unused imports from groovy files for code optimization.
> --
>
> Key: OFBIZ-9509
> URL: https://issues.apache.org/jira/browse/OFBIZ-9509
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9509.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-7357) OFBIZ-6964: Prepare Demo Data based on the propsed design to support replenishment planning through any inter-company facility

2017-10-28 Thread Swapnil M Mane (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil M Mane updated OFBIZ-7357:
--
Attachment: OFBIZ-7357.patch

Here is the patch for the demo data for implementation and testing purpose 
based on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356.

> OFBIZ-6964: Prepare Demo Data based on the propsed design to support 
> replenishment planning through any inter-company facility
> --
>
> Key: OFBIZ-7357
> URL: https://issues.apache.org/jira/browse/OFBIZ-7357
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil M Mane
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7357.patch
>
>
> We can start preparing demo data for implementation and testing purpose based 
> on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9509) Order : Remove unused imports from groovy files for code optimization.

2017-10-28 Thread Pradeep Choudhary (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-9509:
-
Attachment: OFBIZ-9509.patch

Here is the patch for the groovy files optimization:

> Order : Remove unused imports from groovy files for code optimization.
> --
>
> Key: OFBIZ-9509
> URL: https://issues.apache.org/jira/browse/OFBIZ-9509
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9509.patch, OFBIZ-9509.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9509) Order : Remove unused imports from groovy files for code optimization.

2017-10-28 Thread Pradeep Choudhary (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223443#comment-16223443
 ] 

Pradeep Choudhary edited comment on OFBIZ-9509 at 10/28/17 11:52 AM:
-

Here is the patch for the groovy files optimization


was (Author: pradeep.choudhary1994):
Here is the patch for the groovy files optimization:

> Order : Remove unused imports from groovy files for code optimization.
> --
>
> Key: OFBIZ-9509
> URL: https://issues.apache.org/jira/browse/OFBIZ-9509
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9509.patch, OFBIZ-9509.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9756) Required field indicator (*) is missing from create contact list.

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9756.
-

> Required field indicator (*) is missing from create contact list.
> -
>
> Key: OFBIZ-9756
> URL: https://issues.apache.org/jira/browse/OFBIZ-9756
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Akash Jain
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9756.patch
>
>
> 1. go to content -> website
> 2. find websites -> select a website from the link
> 3. Click on contact lists from the submenu.
> contact list id is a required field,
> Quick link to test the issue,
> https://demo-trunk.ofbiz.apache.org/content/control/createWebSiteContactList



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-7357) OFBIZ-6964: Prepare Demo Data based on the propsed design to support replenishment planning through any inter-company facility

2017-10-28 Thread Swapnil M Mane (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223441#comment-16223441
 ] 

Swapnil M Mane edited comment on OFBIZ-7357 at 10/28/17 11:54 AM:
--

Here is the patch for the demo data for implementation and testing purpose 
based on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356.

[~yashwant.dhakad] Kindly have a look into this and let me know if any 
improvements required.

Thanks,
Swapnil M Mane


was (Author: swapnilmmane):
Here is the patch for the demo data for implementation and testing purpose 
based on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356.

> OFBIZ-6964: Prepare Demo Data based on the propsed design to support 
> replenishment planning through any inter-company facility
> --
>
> Key: OFBIZ-7357
> URL: https://issues.apache.org/jira/browse/OFBIZ-7357
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Swapnil M Mane
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7357.patch
>
>
> We can start preparing demo data for implementation and testing purpose based 
> on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9509) Order : Remove unused imports from groovy files for code optimization.

2017-10-28 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-9509.
---
   Resolution: Done
Fix Version/s: Upcoming Release

> Order : Remove unused imports from groovy files for code optimization.
> --
>
> Key: OFBIZ-9509
> URL: https://issues.apache.org/jira/browse/OFBIZ-9509
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9509.patch, OFBIZ-9509.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9509) Order : Remove unused imports from groovy files for code optimization.

2017-10-28 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223451#comment-16223451
 ] 

Deepak Dixit commented on OFBIZ-9509:
-

Thanks Suraj and Pradeep for your contribution 
This has been committed at ofbiz-framework trunk at r#1813612

> Order : Remove unused imports from groovy files for code optimization.
> --
>
> Key: OFBIZ-9509
> URL: https://issues.apache.org/jira/browse/OFBIZ-9509
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9509.patch, OFBIZ-9509.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-7334) Remove unused imports from Groovy files

2017-10-28 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-7334.
---
   Resolution: Done
Fix Version/s: Upcoming Release

> Remove unused imports from Groovy files
> ---
>
> Key: OFBIZ-7334
> URL: https://issues.apache.org/jira/browse/OFBIZ-7334
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Ankit Joshi
>Assignee: Ankit Joshi
>Priority: Minor
> Fix For: Upcoming Release
>
>
> Groovy files in various components have unused package imports. These can be 
> removed for code optimzation purpose.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9895) Success message also showing before the party identification number is updated

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-9895:
-

Assignee: Akash Jain  (was: Pallavi Goyal)

> Success message also showing before the party identification number is 
> updated  
> 
>
> Key: OFBIZ-9895
> URL: https://issues.apache.org/jira/browse/OFBIZ-9895
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Assignee: Akash Jain
>Priority: Trivial
> Attachments: OFBIZ-9895.patch
>
>
> *Steps to regenerate-*
> 1. Login to application.
> 2. Go to "party" component and open any party profile view page.
> 3. Go to "Identification Numbers" panel.
> 4. Create a "New" identification number for the party.
> 5. Now, go back to Party Profile View Page.
> 6. In "Identification Numbers" panel, click on "Update" button for the 
> identification number.
> 7. The "Update Party Identification" page will render with success message 
> but the number is yet to be updated.
> 8. Also, click on "Update" button in the "List Identification Number" panel. 
> The success message is showed again and the number is yet to be updated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9909) Marketing campaigns are not listed out within the given date range in Reports section

2017-10-28 Thread Rubia Elza Joshep (JIRA)
Rubia Elza Joshep created OFBIZ-9909:


 Summary: Marketing campaigns are not listed out within the given 
date range in Reports section
 Key: OFBIZ-9909
 URL: https://issues.apache.org/jira/browse/OFBIZ-9909
 Project: OFBiz
  Issue Type: Bug
  Components: marketing
 Environment: demo-trunk.ofbiz.apache.org
Reporter: Rubia Elza Joshep


Steps-
1) Open URL 
https://demo-trunk.ofbiz.apache.org/marketing/control/MarketingCampaignReport
2) In marketing component, click "Reports'
3) Navigate to marketing campaign report, set the from date and through date 
and click on "Run Marketing Campaign Report"

Expected: All the marketing campaign should be listed out within the given date 
range
Actual: Marketing campaigns are not listed out within the given date range



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9757) Required field indicator (*) is missing on edit data resource role

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9757.
-

> Required field indicator (*) is missing on edit data resource role
> --
>
> Key: OFBIZ-9757
> URL: https://issues.apache.org/jira/browse/OFBIZ-9757
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Rohit Rai
>Assignee: Akash Jain
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9757.patch
>
>
> go to,
> content -> dataresource -> Find DataResource -> select a data resource from 
> the list -> role
> no required symbol for the required parameters, as a result, service throws 
> missing parameter error.
> direct link to test the issue,
> https://localhost:8443/content/control/addDataResourceRole



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (OFBIZ-9769) Instead of using title and labels, use single label for independent fields

2017-10-28 Thread Garima jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Garima jain reopened OFBIZ-9769:


> Instead of using title and labels, use single label for independent fields
> --
>
> Key: OFBIZ-9769
> URL: https://issues.apache.org/jira/browse/OFBIZ-9769
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Garima jain
>Assignee: Garima jain
>Priority: Minor
> Attachments: OFBIZ-9769.patch
>
>
> If there are multiple input fields and all belong to same group/category(like 
> address1, address2, city and state input fields belong to Address category) 
> in a form then we can use a title for such type of categories. But, if there 
> is only a single field (like Email address has single input field) then we 
> should not use the title for it.
>  Here is the reference 
> https://demo-trunk.ofbiz.apache.org/sfa/control/NewLead
> https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer
> Like for Email address does not require Title and label both we can only use 
> title for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9905) Issue with Agreement under Accounting

2017-10-28 Thread sourabh jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

sourabh jain reassigned OFBIZ-9905:
---

Assignee: sourabh jain

> Issue with Agreement under Accounting
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: sourabh jain
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9895) Success message also showing before the party identification number is updated

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-9895:
--
Issue Type: Bug  (was: Improvement)

This is a bug.

> Success message also showing before the party identification number is 
> updated  
> 
>
> Key: OFBIZ-9895
> URL: https://issues.apache.org/jira/browse/OFBIZ-9895
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Assignee: Akash Jain
>Priority: Trivial
> Attachments: OFBIZ-9895.patch
>
>
> *Steps to regenerate-*
> 1. Login to application.
> 2. Go to "party" component and open any party profile view page.
> 3. Go to "Identification Numbers" panel.
> 4. Create a "New" identification number for the party.
> 5. Now, go back to Party Profile View Page.
> 6. In "Identification Numbers" panel, click on "Update" button for the 
> identification number.
> 7. The "Update Party Identification" page will render with success message 
> but the number is yet to be updated.
> 8. Also, click on "Update" button in the "List Identification Number" panel. 
> The success message is showed again and the number is yet to be updated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9895) Success message also showing before the party identification number is updated

2017-10-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9895.
-

This has been fixed on ofbiz-framework trunk at r#1813617 and release16.11 at 
r#1813618.

Thanks, Pallavi Goyal for your contribution.

> Success message also showing before the party identification number is 
> updated  
> 
>
> Key: OFBIZ-9895
> URL: https://issues.apache.org/jira/browse/OFBIZ-9895
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Assignee: Akash Jain
>Priority: Trivial
> Attachments: OFBIZ-9895.patch
>
>
> *Steps to regenerate-*
> 1. Login to application.
> 2. Go to "party" component and open any party profile view page.
> 3. Go to "Identification Numbers" panel.
> 4. Create a "New" identification number for the party.
> 5. Now, go back to Party Profile View Page.
> 6. In "Identification Numbers" panel, click on "Update" button for the 
> identification number.
> 7. The "Update Party Identification" page will render with success message 
> but the number is yet to be updated.
> 8. Also, click on "Update" button in the "List Identification Number" panel. 
> The success message is showed again and the number is yet to be updated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9910) Getting console error on creating sales order, while using UPS live ship rates

2017-10-28 Thread Aditi Patidar (JIRA)
Aditi Patidar created OFBIZ-9910:


 Summary: Getting console error on creating sales order, while 
using UPS live ship rates
 Key: OFBIZ-9910
 URL: https://issues.apache.org/jira/browse/OFBIZ-9910
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Trunk
Reporter: Aditi Patidar
Assignee: Aditi Patidar


please view attached screenshot for the error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9910) Getting console error on creating sales order, while using UPS live ship rates

2017-10-28 Thread Aditi Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditi Patidar updated OFBIZ-9910:
-
Attachment: current.png

> Getting console error on creating sales order, while using UPS live ship rates
> --
>
> Key: OFBIZ-9910
> URL: https://issues.apache.org/jira/browse/OFBIZ-9910
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Aditi Patidar
>Assignee: Aditi Patidar
> Attachments: current.png
>
>
> please view attached screenshot for the error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9770) CSS files defined through layoutSettings in GlobalActions are loaded twice

2017-10-28 Thread Aishwary Shrivastava (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223471#comment-16223471
 ] 

Aishwary Shrivastava commented on OFBIZ-9770:
-

Hi Aditya, I verified this patch and its working fine. 

> CSS files defined through layoutSettings in GlobalActions are loaded twice
> --
>
> Key: OFBIZ-9770
> URL: https://issues.apache.org/jira/browse/OFBIZ-9770
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
> Attachments: OFBIZ-9770.patch, screenshot-1.png
>
>
> CSS files added in GlobalActions screen of CommonScreens.xml are loaded twice.
> Css file jquery.jgrowl.min.css is loaded twice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9763) Create separate Permission Services for CRUD services of ShoppingList and ShoppingListItem

2017-10-28 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9763.
---
   Resolution: Done
Fix Version/s: (was: Trunk)
   Upcoming Release

Committed revision 1813619.

Thanks Chinmay Patidar for your contribution.

> Create separate Permission Services for CRUD services of ShoppingList and 
> ShoppingListItem
> --
>
> Key: OFBIZ-9763
> URL: https://issues.apache.org/jira/browse/OFBIZ-9763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce, party
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Chinmay Patidar
>Assignee: Arun Patidar
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9763.patch, OFBIZ-9763.patch
>
>
> In CRUD services for ShoppingList and ShoppingListItem entities, the security 
> related checks are present inline in the services. This implementation 
> violates the best practice of keeping security implementation different from 
> the business logic.
> We need to implement security services for such operations and to call them 
> as a permission-service from the CRUD operation services definition



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9905) Issue with Agreement under Accounting

2017-10-28 Thread sourabh jain (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223473#comment-16223473
 ] 

sourabh jain commented on OFBIZ-9905:
-

I think it is the correct flow. In OFBiz, the Agreement entity has only one 
primary key i.e. Agreement Id. And Agreement Id is an auto-generated field 
here. Here we can create an agreement without any required input fields, but as 
per any particular business need, we can customize it accordingly.
An agreement is a configurable thing. So we can configure it after creating as 
well. Although the flow is working fine.

> Issue with Agreement under Accounting
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: sourabh jain
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9643) Improvements in Find Invoice and Find Payment screen

2017-10-28 Thread Ayushi Rathod (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayushi Rathod reassigned OFBIZ-9643:


Assignee: (was: Ayushi Rathod)

> Improvements in Find Invoice and Find Payment screen
> 
>
> Key: OFBIZ-9643
> URL: https://issues.apache.org/jira/browse/OFBIZ-9643
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Priority: Minor
>
> Go to [https://demo-trunk.ofbiz.apache.org/accounting/control/main]
> Here you can see two headings under Accounting Manager Main Page:
> * Invoice
> * Payments
> For example:
> If you want to search invoices with approved status, you will click on *Show 
> Invoice Approved*
> and it will redirect you to  
> [https://demo-trunk.ofbiz.apache.org/accounting/control/findInvoices?lookupFlag=Y&statusId=INVOICE_APPROVED]
> Here you can see all approved invoices, but the status check box is not 
> selected. Check box should be selected for chosen search criteria.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9618) "Order Entry Payment Settings" should not be hard coded.

2017-10-28 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-9618:
--
Attachment: OFBIZ-9618.patch

Here is the patch for the mentioned improvement.

> "Order Entry Payment Settings" should not be hard coded.
> 
>
> Key: OFBIZ-9618
> URL: https://issues.apache.org/jira/browse/OFBIZ-9618
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Assignee: Renuka Srishti
>Priority: Minor
> Attachments: OFBIZ-9618.patch
>
>
> When we create a sales order, in this process in the Payment section 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/finalizeOrder] payment 
> options shown are hard coded.
> Proposed Solution:
> Only those payment options should be shown which are associated with the 
> selected Product Store.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9643) Improvements in Find Invoice and Find Payment screen

2017-10-28 Thread Ayushi Rathod (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223476#comment-16223476
 ] 

Ayushi Rathod commented on OFBIZ-9643:
--

*Quick update*
After digging into the issue I discovered that no checkbox appears as selected 
when we click on find button even though the order is filtered, this is 
happening on all the screens where form-widget is used, as ** tag has an 
attribute *all-check* for checkboxes which is set to *false*.

If the value of the checkbox is *false* then whenever the page loads, it 
unchecks all checkboxes and displays no checkbox as selected, but filters the 
result correctly.

If we remove this attribute from the check element then it is working fine in 
case of single checkbox selection, but if multiple checkboxes are selected then 
again it shows all checkboxes as unchecked.
This happens on all the find forms which are implemented using *form-widgets*.

The other screens are working fine because the find forms are implemented in 
*FTL*.

I am not sure but I think either we need to look into form-widget for some 
improvements or we will have to convert (finding) screens implemented using 
form-widget into FTL.

> Improvements in Find Invoice and Find Payment screen
> 
>
> Key: OFBIZ-9643
> URL: https://issues.apache.org/jira/browse/OFBIZ-9643
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Assignee: Ayushi Rathod
>Priority: Minor
>
> Go to [https://demo-trunk.ofbiz.apache.org/accounting/control/main]
> Here you can see two headings under Accounting Manager Main Page:
> * Invoice
> * Payments
> For example:
> If you want to search invoices with approved status, you will click on *Show 
> Invoice Approved*
> and it will redirect you to  
> [https://demo-trunk.ofbiz.apache.org/accounting/control/findInvoices?lookupFlag=Y&statusId=INVOICE_APPROVED]
> Here you can see all approved invoices, but the status check box is not 
> selected. Check box should be selected for chosen search criteria.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9909) Marketing campaigns are not listed out within the given date range in Reports section

2017-10-28 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223479#comment-16223479
 ] 

Suraj Khurana commented on OFBIZ-9909:
--

Hello,

IMO, It will run only when there are some orders or visits corresponding to 
that marketing campaign to be filtered out. Please correct me if I am wrong or 
missed something.

> Marketing campaigns are not listed out within the given date range in Reports 
> section
> -
>
> Key: OFBIZ-9909
> URL: https://issues.apache.org/jira/browse/OFBIZ-9909
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
> Environment: demo-trunk.ofbiz.apache.org
>Reporter: Rubia Elza Joshep
>
> Steps-
> 1) Open URL 
> https://demo-trunk.ofbiz.apache.org/marketing/control/MarketingCampaignReport
> 2) In marketing component, click "Reports'
> 3) Navigate to marketing campaign report, set the from date and through date 
> and click on "Run Marketing Campaign Report"
> Expected: All the marketing campaign should be listed out within the given 
> date range
> Actual: Marketing campaigns are not listed out within the given date range



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


  1   2   >