[jira] [Updated] (OFBIZ-10193) remove hardcoded viewSize for product search
[ https://issues.apache.org/jira/browse/OFBIZ-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wai updated OFBIZ-10193: Attachment: OFBIZ-10193.patch > remove hardcoded viewSize for product search > > > Key: OFBIZ-10193 > URL: https://issues.apache.org/jira/browse/OFBIZ-10193 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Wai >Priority: Trivial > Attachments: OFBIZ-10193.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10193) remove hardcoded viewSize for product search
[ https://issues.apache.org/jira/browse/OFBIZ-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wai updated OFBIZ-10193: Priority: Trivial (was: Major) > remove hardcoded viewSize for product search > > > Key: OFBIZ-10193 > URL: https://issues.apache.org/jira/browse/OFBIZ-10193 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Wai >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10193) remove hardcoded viewSize for product search
Wai created OFBIZ-10193: --- Summary: remove hardcoded viewSize for product search Key: OFBIZ-10193 URL: https://issues.apache.org/jira/browse/OFBIZ-10193 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Trunk Reporter: Wai -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10192) German translation correction (CLIENT)
Ingo Wolfmayr created OFBIZ-10192: - Summary: German translation correction (CLIENT) Key: OFBIZ-10192 URL: https://issues.apache.org/jira/browse/OFBIZ-10192 Project: OFBiz Issue Type: Improvement Reporter: Ingo Wolfmayr Attachments: ofbiz.patch -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10191) Translate invoice type dropdown
[ https://issues.apache.org/jira/browse/OFBIZ-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-10191: -- Attachment: ofbiz.patch > Translate invoice type dropdown > --- > > Key: OFBIZ-10191 > URL: https://issues.apache.org/jira/browse/OFBIZ-10191 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Ingo Wolfmayr >Priority: Trivial > Attachments: ofbiz.patch > > > It would be nice if the "Invoice item type" (Invoice --> items) would display > in the locale language. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10191) Translate invoice type dropdown
Ingo Wolfmayr created OFBIZ-10191: - Summary: Translate invoice type dropdown Key: OFBIZ-10191 URL: https://issues.apache.org/jira/browse/OFBIZ-10191 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: Trunk Reporter: Ingo Wolfmayr Attachments: ofbiz.patch It would be nice if the "Invoice item type" (Invoice --> items) would display in the locale language. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346886#comment-16346886
]
Michael Brohl commented on OFBIZ-10187:
---
I think we have to decide on several points:
* what should be the default setting OOTB?
* what should be in PERMISSIVE_POLICY?
* how can we enhance this mechanism to allow better customization without
changing the OFBiz standard code?
I'm going to test if using the permissive policy allows for a reasonable set of
html and come back then.
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: 16.11.04
>Reporter: Michael Brohl
>Assignee: Jacques Le Roux
>Priority: Critical
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> I do not see any reason to not allow class attributes in html code. There
> might be other problems with these rules but this is a showstopper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10190) Update order calculation
Ingo Wolfmayr created OFBIZ-10190:
-
Summary: Update order calculation
Key: OFBIZ-10190
URL: https://issues.apache.org/jira/browse/OFBIZ-10190
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: Release Branch 16.11, Release Branch 15.12, Trunk,
Release Branch 14.12, Release Branch 13.07
Reporter: Ingo Wolfmayr
Attachments: ofbiz.patch
When creating an order with a promotion the tax value is wrong after updating
the order if a promotion is involved.
Order --> Edit Items --> update selected items
Example:
*initial:*
item1 $200
Promo -$10 (simple promotion -5%)
Tax 20%: $38.00
Tax adj: -$2
--> $ 218.00
*update:*
item1 $200
Promo -$20 (changed promotion to -10%)
Tax 20%: $38.00
*{color:#d04437}Tax adj: -$2{color}*
--> $ 218.00
Attached a patch to fix it:
1) Calc promotion before tax
2) enable existing skipEmptyAddresses flag on calcAndAddTax
3) use skipEmptyAddresses flag in calcAndAddTax
Result:
item1 $200
Promo -$20 (changed promotion to -10%)
Tax 20%: $36.00
{color:#14892c}*Tax adj: -$4*{color}
--> $ 216.00
Right know the person working on the order has to manually calulate the order
tax and add/subtract it from the initial calculated value. So when updating an
order the values have to be checked manually as the promotion is recalculated
and may have changed - but the tax is not.
The proposal is to recalculate the automatic calculated tax values when the
order was created. Adding additional tax can still be done by adding a tax
value manually.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10185) Fix UI issue for error messages.
[ https://issues.apache.org/jira/browse/OFBIZ-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342128#comment-16342128 ] Mayank Lambhate edited comment on OFBIZ-10185 at 1/31/18 8:48 AM: -- Patch made available. Added CSS rules to fix position of error messages in ecommerce. was (Author: mayank.lambhate): Patch made available. > Fix UI issue for error messages. > > > Key: OFBIZ-10185 > URL: https://issues.apache.org/jira/browse/OFBIZ-10185 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Release Branch 16.11 >Reporter: Mayank Lambhate >Assignee: Mayank Lambhate >Priority: Major > Attachments: OFBIZ-10185.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10185) Fix UI issue for error messages.
[ https://issues.apache.org/jira/browse/OFBIZ-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayank Lambhate reassigned OFBIZ-10185: --- Assignee: Mayank Lambhate > Fix UI issue for error messages. > > > Key: OFBIZ-10185 > URL: https://issues.apache.org/jira/browse/OFBIZ-10185 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Release Branch 16.11 >Reporter: Mayank Lambhate >Assignee: Mayank Lambhate >Priority: Major > Attachments: OFBIZ-10185.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10189) Invoice in status approved - cancel
Ingo Wolfmayr created OFBIZ-10189: - Summary: Invoice in status approved - cancel Key: OFBIZ-10189 URL: https://issues.apache.org/jira/browse/OFBIZ-10189 Project: OFBiz Issue Type: Improvement Components: accounting Reporter: Ingo Wolfmayr Attachments: ofbiz.patch When I create an invoice and set it to status "INVOICE_APPROVED" it is not possible to cancel the invoice as the status change is not available. If I change the status to "INVOICE_READY" it is again possible to cancel the invoice. I think in most of the business cases this won't make sense. I therefore would like to suggest to change it: if invoice in status "INVOICE_APPROVED" it can be cancelled. # Create invoice (sales invoice) # Set status to "INVOICE_APPROVED": available status changes: INVOICE_SEND, INVOICE_READY 3. Set status to "INVOICE_READY": available status changes: INVOICE_PAID, INVOICE_CANCELLED, INVOICE_PAIDOFF -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10189) Invoice in status approved - cancel
[ https://issues.apache.org/jira/browse/OFBIZ-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-10189: -- Attachment: ofbiz.patch > Invoice in status approved - cancel > --- > > Key: OFBIZ-10189 > URL: https://issues.apache.org/jira/browse/OFBIZ-10189 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Ingo Wolfmayr >Priority: Trivial > Attachments: ofbiz.patch > > > When I create an invoice and set it to status "INVOICE_APPROVED" it is not > possible to cancel the invoice as the status change is not available. If I > change the status to "INVOICE_READY" it is again possible to cancel the > invoice. I think in most of the business cases this won't make sense. I > therefore would like to suggest to change it: if invoice in status > "INVOICE_APPROVED" it can be cancelled. > # Create invoice (sales invoice) > # Set status to "INVOICE_APPROVED": available status changes: INVOICE_SEND, > INVOICE_READY 3. Set status to "INVOICE_READY": available status changes: > INVOICE_PAID, INVOICE_CANCELLED, INVOICE_PAIDOFF -- This message was sent by Atlassian JIRA (v7.6.3#76005)
