[jira] [Commented] (OFBIZ-9833) Token Based Authentication
[
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405337#comment-16405337
]
Jacques Le Roux commented on OFBIZ-9833:
Weirdly, when I apply the {{OFBIZ-9833-revert.patch}} (sorry forgot to attach
it last time) on an older revision (r1806036 from 2017-08-24) I don't have this
problem. So it must be a change between r1806036 and HEAD somewhere. Very weird
because of course when you don't apply the reverting patch all works as
expected. I'll try to dig that!
> Token Based Authentication
> --
>
> Key: OFBIZ-9833
> URL: https://issues.apache.org/jira/browse/OFBIZ-9833
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: JSON Web Tokens.pdf, OFBIZ-9833-JWTManager.patch,
> OFBIZ-9833-external-server-test-example.patch,
> OFBIZ-9833-external-server-test-example.patch,
> OFBIZ-9833-external-server.patch, OFBIZ-9833-external-server.patch,
> OFBIZ-9833-external-server.patch, OFBIZ-9833-revert.patch, Token Based
> Authentication in Apache OfBiz.pdf, Token Based Authentication.pdf,
> rfc7519.pdf
>
>
> Here is dev list discussion for token based authentication work:
> http://markmail.org/message/vyskeh2wujqpkbwg
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-9833) Token Based Authentication
[ https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9833: --- Attachment: OFBIZ-9833-revert.patch > Token Based Authentication > -- > > Key: OFBIZ-9833 > URL: https://issues.apache.org/jira/browse/OFBIZ-9833 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: JSON Web Tokens.pdf, OFBIZ-9833-JWTManager.patch, > OFBIZ-9833-external-server-test-example.patch, > OFBIZ-9833-external-server-test-example.patch, > OFBIZ-9833-external-server.patch, OFBIZ-9833-external-server.patch, > OFBIZ-9833-external-server.patch, OFBIZ-9833-revert.patch, Token Based > Authentication in Apache OfBiz.pdf, Token Based Authentication.pdf, > rfc7519.pdf > > > Here is dev list discussion for token based authentication work: > http://markmail.org/message/vyskeh2wujqpkbwg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10281) HttpClient failed to return the error result
[
https://issues.apache.org/jira/browse/OFBIZ-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-10281.
-
Resolution: Fixed
Fix Version/s: Upcoming Branch
done on trunk at revision 1827212
> HttpClient failed to return the error result
>
>
> Key: OFBIZ-10281
> URL: https://issues.apache.org/jira/browse/OFBIZ-10281
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10281.patch
>
>
> When you call the HttpClient on Rest API on url that return you an error, the
> HttpClient failed to give you the error stream:
> {code:java}
> callResult = restClient.getStream();{code}
> If the flow is an error you have HttpClient:534
> {code:java}
> in = con.getInputStream();
> {code}
> return a FileNotFoundException
> To solve this I catch the error and restart the connexion like this
> {code:java}
> if ((con instanceof HttpURLConnection)) {
> try {
> in = ((HttpURLConnection) con).getErrorStream();
> } catch (Exception ioerror) {
> throw new HttpClientException("IO Error processing request", ioerror);
> }
> return in;
> }{code}
> With this the inputStream contains the error message and we can use it for
> end user return
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10242) Standardise Layout throughout Applications
[ https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404808#comment-16404808 ] Rishi Solanki commented on OFBIZ-10242: --- +1 for back port these improvements to 17.12 . Its worth porting these changes for consistency. > Standardise Layout throughout Applications > -- > > Key: OFBIZ-10242 > URL: https://issues.apache.org/jira/browse/OFBIZ-10242 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Labels: backport-needed > Attachments: OFBIZ-10242_common.SecurityScreens.patch, > OFBIZ-10242_content.CompDocScreens.patch, > OFBIZ-10242_content.ContentScreens.patch, > OFBIZ-10242_content.ContentSetupScreens.patch, > OFBIZ-10242_content.DataResourceScreens.patch, > OFBIZ-10242_content.DataResourceSetupScreens.patch, > OFBIZ-10242_content.ForumScreens2.patch, > OFBIZ-10242_webtools.EnitityScreens.patch, > OFBIZ-10242_webtools.StatsScreens.patch, > OFBIZ_webtools.ArtifactInfoScreen.patch > > > While working on a Theme I discovered that many screens are missing > screenlets, or some buttons are at the wrong Position etc. . > I propose to standardise the layout of every screen, to support easy theming. > Similar to the examplary patch provided below. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10297) Add Document Content: acc-global-settings.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404784#comment-16404784 ] Sharan Foga commented on OFBIZ-10297: - New document added and content updated. Initial commit for draft documentation done at r1827195. > Add Document Content: acc-global-settings.adoc > -- > > Key: OFBIZ-10297 > URL: https://issues.apache.org/jira/browse/OFBIZ-10297 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > > Add content for acc-global-settings.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10297) Add Document Content: acc-global-settings.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga reassigned OFBIZ-10297: --- Assignee: Sharan Foga > Add Document Content: acc-global-settings.adoc > -- > > Key: OFBIZ-10297 > URL: https://issues.apache.org/jira/browse/OFBIZ-10297 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > > Add content for acc-global-settings.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10297) Add Document Content: acc-global-settings.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10297: Labels: accounting asciidoc documentation (was: ) Priority: Minor (was: Major) Fix Version/s: Upcoming Branch Component/s: accounting > Add Document Content: acc-global-settings.adoc > -- > > Key: OFBIZ-10297 > URL: https://issues.apache.org/jira/browse/OFBIZ-10297 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > > Add content for acc-global-settings.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga closed OFBIZ-10290. --- Resolution: Implemented New document added and content updated. Implemented at r1827188 > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > > Add content for acc-agreements.doc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10290: Labels: accounting asciidoc documentation (was: ) Component/s: accounting > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > > Add content for acc-agreements.doc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10289) Add Document Content: acc-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10289: Labels: accounting asciidoc documentation (was: ) > Add Document Content: acc-intro.adoc > > > Key: OFBIZ-10289 > URL: https://issues.apache.org/jira/browse/OFBIZ-10289 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > > Add document content acc-intro.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10288) Move Accounting Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10288: Labels: accounting documentation (was: documentation) Component/s: accounting > Move Accounting Guide into OFBiz Asciidoc Framework > --- > > Key: OFBIZ-10288 > URL: https://issues.apache.org/jira/browse/OFBIZ-10288 > Project: OFBiz > Issue Type: Task > Components: accounting >Reporter: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > > This is a general umbrella task for the creation and migration of all > accounting related information and documentation into the OFBiz asciidoc > documentation framework. > Subtasks will be created for each area where documentation needs to be > creaated. An initial list is as follows: > # accounting.adoc (already created - may create an issue to track any > additional work_ > # acc-intro.adoc > # acc-agreements.adoc > # acc-tax-authorities.adoc > # acc-invoices.adoc > # acc-billing-accounts.adoc > # acc-payments.adoc > # acc-payment-gateway.adoc > # acc-financial-accounts.adoc > # acc-global-settings.adoc > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10288) Move Accounting Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10288: Labels: accounting asciidoc documentation (was: accounting documentation) > Move Accounting Guide into OFBiz Asciidoc Framework > --- > > Key: OFBIZ-10288 > URL: https://issues.apache.org/jira/browse/OFBIZ-10288 > Project: OFBiz > Issue Type: Task > Components: accounting >Reporter: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > > This is a general umbrella task for the creation and migration of all > accounting related information and documentation into the OFBiz asciidoc > documentation framework. > Subtasks will be created for each area where documentation needs to be > creaated. An initial list is as follows: > # accounting.adoc (already created - may create an issue to track any > additional work_ > # acc-intro.adoc > # acc-agreements.adoc > # acc-tax-authorities.adoc > # acc-invoices.adoc > # acc-billing-accounts.adoc > # acc-payments.adoc > # acc-payment-gateway.adoc > # acc-financial-accounts.adoc > # acc-global-settings.adoc > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10251: Labels: asciidoc documentation humanres (was: documentation humanres) > Move Human Resources Guide into OFBiz Asciidoc Framework > > > Key: OFBIZ-10251 > URL: https://issues.apache.org/jira/browse/OFBIZ-10251 > Project: OFBiz > Issue Type: Task >Reporter: Sharan Foga >Priority: Minor > Labels: asciidoc, documentation, humanres > Attachments: introduction.patch > > > This is a general umbrella issue for managing the creation and migration of > all OFBiz related Human Resources documentation into the OFBiz code base. > Subtasks will be created for each of the documents that need to be created. > Also created as a sub task will the task to create empty documents for each > of the sub-files in the list > An initial list is as follows: > # human-resources.adoc > # human-resources-intro.adoc > # employee-evaluations.adoc > # human-resources-glossary.adoc > # employee-positions.adoc > # employees.adoc > # employments.adoc > # performance-review.adoc > # positions.adoc > # qualifications.adoc > # recruitment.adoc > # skiils.adoc > # resumes.adoc > # training.adoc > # leave.adoc > # human-resources-security.adoc > # human-resources-global-settings.adoc > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10285) OFBiz Documentation Global Task
[ https://issues.apache.org/jira/browse/OFBIZ-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10285: Labels: asciidoc documentation (was: ) > OFBiz Documentation Global Task > > > Key: OFBIZ-10285 > URL: https://issues.apache.org/jira/browse/OFBIZ-10285 > Project: OFBiz > Issue Type: Task >Reporter: Sharan Foga >Priority: Minor > Labels: asciidoc, documentation > > This is a global Jira task to consolidate all work related to the OFBiz > documentation effort. All existing document related Jira tasks will be > included here as well as the current effort for moving documentation from > wiki, workspaces etc into the codebase using Asciidoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10288) Move Accounting Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10288: Labels: documentation (was: ) Fix Version/s: Upcoming Branch > Move Accounting Guide into OFBiz Asciidoc Framework > --- > > Key: OFBIZ-10288 > URL: https://issues.apache.org/jira/browse/OFBIZ-10288 > Project: OFBiz > Issue Type: Task >Reporter: Sharan Foga >Priority: Minor > Labels: documentation > Fix For: Upcoming Branch > > > This is a general umbrella task for the creation and migration of all > accounting related information and documentation into the OFBiz asciidoc > documentation framework. > Subtasks will be created for each area where documentation needs to be > creaated. An initial list is as follows: > # accounting.adoc (already created - may create an issue to track any > additional work_ > # acc-intro.adoc > # acc-agreements.adoc > # acc-tax-authorities.adoc > # acc-invoices.adoc > # acc-billing-accounts.adoc > # acc-payments.adoc > # acc-payment-gateway.adoc > # acc-financial-accounts.adoc > # acc-global-settings.adoc > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10290: Fix Version/s: Upcoming Branch > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Fix For: Upcoming Branch > > > Add content for acc-agreements.doc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10290: Priority: Minor (was: Major) > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > > Add content for acc-agreements.doc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-4959) Logout do not remove autoLogin
[
https://issues.apache.org/jira/browse/OFBIZ-4959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401683#comment-16401683
]
Jacques Le Roux edited comment on OFBIZ-4959 at 3/19/18 10:18 AM:
--
I completed the fix in
trunk r1826938
R17.12 r1826939
R16.11 r1826943
I used the only available (and I must say confusing) WebappInfo.getName() when
I needed the webAppName not the WebappInfoName. So this put in a new
WebappInfo.getMountPoint() and use it in getWebappInfo
Also use LoginWorker.autoLoginSet() in different places where I missed it. In
other words all autoUserLogin coockies are deleted on login and logout, and
an autoUserLogin cookie is created when going locally from a webapp to another,
with checkExternalLoginKey
was (Author: jacques.le.roux):
I completed the fix in
trunk r1826938
R17.12 r1826939
R16.11 r1826943
> Logout do not remove autoLogin
> --
>
> Key: OFBIZ-4959
> URL: https://issues.apache.org/jira/browse/OFBIZ-4959
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Release 09.04, Release 10.04
> Environment: Windows 2003 Server. Apache Ofbiz 2004 and Ofbiz 10
>Reporter: Roberto Benítez Monje
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: logout, security
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-4959.patch, OFBIZ-4959.patch
>
> Original Estimate: 70,056h
> Remaining Estimate: 70,056h
>
> Logout method do not disable autoLogin functionality. Instead of that it just
> initializes autoLogin in session and request.
> It have to be replace autoLoginCheck for autoLoginRemove inside of logout
> method.
> {code:title=LoginEvents/LoginWorker.java|borderStyle=solid}
> public static String logout(HttpServletRequest request, HttpServletResponse
> response) {
> // invalidate the security group list cache
> GenericValue userLogin = (GenericValue)
> request.getSession().getAttribute("userLogin");
> String returnValue = "success";
> if (request.getAttribute("_AUTO_LOGIN_LOGOUT_") == null) {
> try {
> returnValue = autoLoginRemove(request, response);
> } catch (IOException e) {
> Debug.logWarning(e, "", module);
> }
> }
> // log out from all other sessions too; do this here so that it is only
> done when a user explicitly logs out
> logoutFromAllSessions(userLogin);
> doBasicLogout(userLogin, request);
> return returnValue;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga reassigned OFBIZ-10290: --- Assignee: Sharan Foga > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Major > > Add content for acc-agreements.doc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10289) Add Document Content: acc-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga closed OFBIZ-10289. --- Resolution: Implemented New document added and content updated. Implemented at r1827176 > Add Document Content: acc-intro.adoc > > > Key: OFBIZ-10289 > URL: https://issues.apache.org/jira/browse/OFBIZ-10289 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > > Add document content acc-intro.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10289) Add Document Content: acc-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10289: Affects Version/s: Upcoming Branch > Add Document Content: acc-intro.adoc > > > Key: OFBIZ-10289 > URL: https://issues.apache.org/jira/browse/OFBIZ-10289 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > > Add document content acc-intro.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10255) Add Document Content: humanres.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga closed OFBIZ-10255. --- Committed at r1827082. > Add Document Content: humanres.adoc > --- > > Key: OFBIZ-10255 > URL: https://issues.apache.org/jira/browse/OFBIZ-10255 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Attachments: OFBIZ-10255.patch, humanres.adoc > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the humanres.adoc file. > An copy of the existing file will be attached. > Please update the template and re-attach it. > NOTE: This document might not be able to be completed until other sections > for Human Resources are done. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404533#comment-16404533 ] Jacques Le Roux commented on OFBIZ-9873: +1 > Create a PoC for a documentation system for OFBiz based on Asciidoc > --- > > Key: OFBIZ-9873 > URL: https://issues.apache.org/jira/browse/OFBIZ-9873 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9873.patch, OFBIZ-9873.patch > > > In reference to the [discussion > thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E] > this is an attempt to create a PoC for OFBiz documentation system based on > Asciidoc. The main assumptions for the design of this system are: > - The documentation language to use is Asciidoc > - The documentation tool is Asciidoctor > - Publishing happens through Gradle using the asciidoctor gradle plugin (not > the OFBiz framework or anything else). > - The only place where we write documentation is inside the code base > - Every component contains its own documentation > - General documentation goes to either a standalone directory or a generic > component like common or base > - As much as possible, documentation files are small and focused on one > topic. And then other longer documents are constructed from these snippets of > documentation. > - We publish to all formats including PDF for users, or HTML for embedded > help and wiki pages. So OFBiz does not parse docbook for its help system, > instead it just renders generated HTML. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10297) Add Document Content: acc-global-settings.adoc
Sharan Foga created OFBIZ-10297: --- Summary: Add Document Content: acc-global-settings.adoc Key: OFBIZ-10297 URL: https://issues.apache.org/jira/browse/OFBIZ-10297 Project: OFBiz Issue Type: Sub-task Reporter: Sharan Foga Add content for acc-global-settings.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10289) Add Document Content: acc-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga reassigned OFBIZ-10289: --- Assignee: Sharan Foga > Add Document Content: acc-intro.adoc > > > Key: OFBIZ-10289 > URL: https://issues.apache.org/jira/browse/OFBIZ-10289 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > > Add document content acc-intro.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10295) Add Document Content: acc-payment-gateway.adoc
Sharan Foga created OFBIZ-10295: --- Summary: Add Document Content: acc-payment-gateway.adoc Key: OFBIZ-10295 URL: https://issues.apache.org/jira/browse/OFBIZ-10295 Project: OFBiz Issue Type: Sub-task Reporter: Sharan Foga Add content acc-payment-gateway.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10296) Add Document Content: acc-financial-accounts.adoc
Sharan Foga created OFBIZ-10296: --- Summary: Add Document Content: acc-financial-accounts.adoc Key: OFBIZ-10296 URL: https://issues.apache.org/jira/browse/OFBIZ-10296 Project: OFBiz Issue Type: Sub-task Reporter: Sharan Foga Add content for acc-financial-accounts.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10294) Add Document Content: acc-payments.adoc
Sharan Foga created OFBIZ-10294: --- Summary: Add Document Content: acc-payments.adoc Key: OFBIZ-10294 URL: https://issues.apache.org/jira/browse/OFBIZ-10294 Project: OFBiz Issue Type: Sub-task Reporter: Sharan Foga Add content acc-payments.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10293) Add Document Content: acc-billing-accounts.adoc
Sharan Foga created OFBIZ-10293: --- Summary: Add Document Content: acc-billing-accounts.adoc Key: OFBIZ-10293 URL: https://issues.apache.org/jira/browse/OFBIZ-10293 Project: OFBiz Issue Type: Sub-task Reporter: Sharan Foga Add content acc-billing-accounts.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10292) Add Document Content: acc-invoices.adoc
Sharan Foga created OFBIZ-10292: --- Summary: Add Document Content: acc-invoices.adoc Key: OFBIZ-10292 URL: https://issues.apache.org/jira/browse/OFBIZ-10292 Project: OFBiz Issue Type: Sub-task Reporter: Sharan Foga Add content for acc-invoices.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10291) Add Document Content: acc-tax-authorities.adoc
Sharan Foga created OFBIZ-10291: --- Summary: Add Document Content: acc-tax-authorities.adoc Key: OFBIZ-10291 URL: https://issues.apache.org/jira/browse/OFBIZ-10291 Project: OFBiz Issue Type: Sub-task Reporter: Sharan Foga Add content for acc-tax-authorities.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
Sharan Foga created OFBIZ-10290: --- Summary: Add Document Content: acc-agreements.adoc Key: OFBIZ-10290 URL: https://issues.apache.org/jira/browse/OFBIZ-10290 Project: OFBiz Issue Type: Sub-task Reporter: Sharan Foga Add content for acc-agreements.doc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10289) Add Document Content: acc-intro.adoc
Sharan Foga created OFBIZ-10289: --- Summary: Add Document Content: acc-intro.adoc Key: OFBIZ-10289 URL: https://issues.apache.org/jira/browse/OFBIZ-10289 Project: OFBiz Issue Type: Sub-task Reporter: Sharan Foga Add document content acc-intro.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10288) Move Accounting Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10288: Description: This is a general umbrella task for the creation and migration of all accounting related information and documentation into the OFBiz asciidoc documentation framework. Subtasks will be created for each area where documentation needs to be creaated. An initial list is as follows: # accounting.adoc (already created - may create an issue to track any additional work_ # acc-intro.adoc # acc-agreements.adoc # acc-tax-authorities.adoc # acc-invoices.adoc # acc-billing-accounts.adoc # acc-payments.adoc # acc-payment-gateway.adoc # acc-financial-accounts.adoc # acc-global-settings.adoc was: This is a general umbrella task for the creation and migration of all accounting related information and documentation into the OFBiz asciidoc documentation framework. Subtasks will be created for each area where documentation needs to be creaated. An initial list is as follows: # accounting.adoc (already created - may create an issue to track any additional work_ # acc-intro.adoc.adoc # acc-agreements.adoc # acc-tax-authorities.adoc # acc-invoices.adoc # acc-billing-accounts.adoc # acc-payments.adoc # acc-payment-gateway.adoc # acc-financial-accounts.adoc # acc-global-settings.adoc > Move Accounting Guide into OFBiz Asciidoc Framework > --- > > Key: OFBIZ-10288 > URL: https://issues.apache.org/jira/browse/OFBIZ-10288 > Project: OFBiz > Issue Type: Task >Reporter: Sharan Foga >Priority: Minor > > This is a general umbrella task for the creation and migration of all > accounting related information and documentation into the OFBiz asciidoc > documentation framework. > Subtasks will be created for each area where documentation needs to be > creaated. An initial list is as follows: > # accounting.adoc (already created - may create an issue to track any > additional work_ > # acc-intro.adoc > # acc-agreements.adoc > # acc-tax-authorities.adoc > # acc-invoices.adoc > # acc-billing-accounts.adoc > # acc-payments.adoc > # acc-payment-gateway.adoc > # acc-financial-accounts.adoc > # acc-global-settings.adoc > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10288) Move Accounting Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga updated OFBIZ-10288: Description: This is a general umbrella task for the creation and migration of all accounting related information and documentation into the OFBiz asciidoc documentation framework. Subtasks will be created for each area where documentation needs to be creaated. An initial list is as follows: # accounting.adoc (already created - may create an issue to track any additional work_ # acc-intro.adoc.adoc # acc-agreements.adoc # acc-tax-authorities.adoc # acc-invoices.adoc # acc-billing-accounts.adoc # acc-payments.adoc # acc-payment-gateway.adoc # acc-financial-accounts.adoc # acc-global-settings.adoc was:This is a general umbrella task for the creation and migration of all accounting related information and documentation into the OFBiz asciidoc documentation framework > Move Accounting Guide into OFBiz Asciidoc Framework > --- > > Key: OFBIZ-10288 > URL: https://issues.apache.org/jira/browse/OFBIZ-10288 > Project: OFBiz > Issue Type: Task >Reporter: Sharan Foga >Priority: Minor > > This is a general umbrella task for the creation and migration of all > accounting related information and documentation into the OFBiz asciidoc > documentation framework. > Subtasks will be created for each area where documentation needs to be > creaated. An initial list is as follows: > # accounting.adoc (already created - may create an issue to track any > additional work_ > # acc-intro.adoc.adoc > # acc-agreements.adoc > # acc-tax-authorities.adoc > # acc-invoices.adoc > # acc-billing-accounts.adoc > # acc-payments.adoc > # acc-payment-gateway.adoc > # acc-financial-accounts.adoc > # acc-global-settings.adoc > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10288) Move Accounting Guide into OFBiz Asciidoc Framework
Sharan Foga created OFBIZ-10288: --- Summary: Move Accounting Guide into OFBiz Asciidoc Framework Key: OFBIZ-10288 URL: https://issues.apache.org/jira/browse/OFBIZ-10288 Project: OFBiz Issue Type: Task Reporter: Sharan Foga This is a general umbrella task for the creation and migration of all accounting related information and documentation into the OFBiz asciidoc documentation framework -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc
[
https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404492#comment-16404492
]
Taher Alkhateeb commented on OFBIZ-9873:
I see, you up-numbered without excluding from asciidoctorj-pdf. It works but
would be fragile for the future.
So my recommendation if everyone agrees is to apply Jacque's patch with the
below comment. This way we can come back to it and remove it later when the
issue is fixed with a future release of asciidoctorj-pdf.
{code}
Index: build.gradle
===
--- build.gradle (revision 1827146)
+++ build.gradle (working copy)
@@ -31,6 +31,8 @@
classpath 'at.bxm.gradleplugins:gradle-svntools-plugin:latest.release'
classpath 'org.asciidoctor:asciidoctor-gradle-plugin:1.5.7'
classpath 'org.asciidoctor:asciidoctorj-pdf:1.5.0-alpha.16'
+ // asciidoctorj-pdf bug workaround - override jruby. See OFBIZ-9873
+ classpath 'org.jruby:jruby-complete:9.1.13.0'
}
}
apply plugin: 'java'
{code}
> Create a PoC for a documentation system for OFBiz based on Asciidoc
> ---
>
> Key: OFBIZ-9873
> URL: https://issues.apache.org/jira/browse/OFBIZ-9873
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9873.patch, OFBIZ-9873.patch
>
>
> In reference to the [discussion
> thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E]
> this is an attempt to create a PoC for OFBiz documentation system based on
> Asciidoc. The main assumptions for the design of this system are:
> - The documentation language to use is Asciidoc
> - The documentation tool is Asciidoctor
> - Publishing happens through Gradle using the asciidoctor gradle plugin (not
> the OFBiz framework or anything else).
> - The only place where we write documentation is inside the code base
> - Every component contains its own documentation
> - General documentation goes to either a standalone directory or a generic
> component like common or base
> - As much as possible, documentation files are small and focused on one
> topic. And then other longer documents are constructed from these snippets of
> documentation.
> - We publish to all formats including PDF for users, or HTML for embedded
> help and wiki pages. So OFBiz does not parse docbook for its help system,
> instead it just renders generated HTML.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc
[
https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404468#comment-16404468
]
Jacques Le Roux commented on OFBIZ-9873:
I wrote above
bq. Adding classpath 'org.jruby:jruby-complete:9.1.13.0' in build.gradle
worked.
{code}
but this is more clear:
Index: build.gradle
===
--- build.gradle(revision 1826795)
+++ build.gradle(working copy)
@@ -31,6 +31,7 @@
classpath 'at.bxm.gradleplugins:gradle-svntools-plugin:latest.release'
classpath 'org.asciidoctor:asciidoctor-gradle-plugin:1.5.7'
classpath 'org.asciidoctor:asciidoctorj-pdf:1.5.0-alpha.16'
+classpath 'org.jruby:jruby-complete:9.1.13.0'
}
}
apply plugin: 'java'
{code}
And yes I had no problem overriding
> Create a PoC for a documentation system for OFBiz based on Asciidoc
> ---
>
> Key: OFBIZ-9873
> URL: https://issues.apache.org/jira/browse/OFBIZ-9873
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9873.patch, OFBIZ-9873.patch
>
>
> In reference to the [discussion
> thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E]
> this is an attempt to create a PoC for OFBiz documentation system based on
> Asciidoc. The main assumptions for the design of this system are:
> - The documentation language to use is Asciidoc
> - The documentation tool is Asciidoctor
> - Publishing happens through Gradle using the asciidoctor gradle plugin (not
> the OFBiz framework or anything else).
> - The only place where we write documentation is inside the code base
> - Every component contains its own documentation
> - General documentation goes to either a standalone directory or a generic
> component like common or base
> - As much as possible, documentation files are small and focused on one
> topic. And then other longer documents are constructed from these snippets of
> documentation.
> - We publish to all formats including PDF for users, or HTML for embedded
> help and wiki pages. So OFBiz does not parse docbook for its help system,
> instead it just renders generated HTML.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
