[jira] [Updated] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong

2018-03-27 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10304:

Description: 
I commited 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
 which I guess forced (or allowed?) James Yong to use the 
javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
userLogin service at 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]

Else it would (should?) have been
 

Now I need to revert/remove the wrapper in ContextFilter which is useless and 
silly (my bad).

 

{color:#FF}After a deeper investigation today (saturday 2019-03-24) the 
right solution is now attached as a patch{color}
Update: we had a discussion on this subject at 

  was:
I commited 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
 which I guess forced (or allowed?) James Yong to use the 
javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
userLogin service at 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]

Else it would (should?) have been
 

Now I need to revert/remove the wrapper in ContextFilter which is useless and 
silly (my bad).

 

{color:#FF}After a deeper investigation today (saturday 2019-03-24) the 
right solution is now attached as a patch{color}


> The "request" attribute type of the userLogin service is wrong
> --
>
> Key: OFBIZ-10304
> URL: https://issues.apache.org/jira/browse/OFBIZ-10304
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10304.patch
>
>
> I commited 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
>  which I guess forced (or allowed?) James Yong to use the 
> javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
> userLogin service at 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]
> Else it would (should?) have been
>   type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and 
> silly (my bad).
>  
> {color:#FF}After a deeper investigation today (saturday 2019-03-24) the 
> right solution is now attached as a patch{color}
> Update: we had a discussion on this subject at 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong

2018-03-27 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10304:

Description: 
I commited 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
 which I guess forced (or allowed?) James Yong to use the 
javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
userLogin service at 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]

Else it would (should?) have been
 

Now I need to revert/remove the wrapper in ContextFilter which is useless and 
silly (my bad).

 

{color:#FF}After a deeper investigation today (saturday 2019-03-24) the 
right solution is now attached as a patch{color}
Update: we had a discussion on this subject at 

  was:
I commited 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
 which I guess forced (or allowed?) James Yong to use the 
javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
userLogin service at 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]

Else it would (should?) have been
 

Now I need to revert/remove the wrapper in ContextFilter which is useless and 
silly (my bad).

 

{color:#FF}After a deeper investigation today (saturday 2019-03-24) the 
right solution is now attached as a patch{color}
Update: we had a discussion on this subject at 


> The "request" attribute type of the userLogin service is wrong
> --
>
> Key: OFBIZ-10304
> URL: https://issues.apache.org/jira/browse/OFBIZ-10304
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10304.patch
>
>
> I commited 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
>  which I guess forced (or allowed?) James Yong to use the 
> javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
> userLogin service at 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]
> Else it would (should?) have been
>   type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and 
> silly (my bad).
>  
> {color:#FF}After a deeper investigation today (saturday 2019-03-24) the 
> right solution is now attached as a patch{color}
> Update: we had a discussion on this subject at 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong

2018-03-27 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10304:

Affects Version/s: 17.12.01
   Trunk

> The "request" attribute type of the userLogin service is wrong
> --
>
> Key: OFBIZ-10304
> URL: https://issues.apache.org/jira/browse/OFBIZ-10304
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10304.patch
>
>
> I commited 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
>  which I guess forced (or allowed?) James Yong to use the 
> javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
> userLogin service at 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]
> Else it would (should?) have been
>   type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and 
> silly (my bad).
> {color:#ff}-After a deeper investigation today (saturday 2019-03-24) the 
> right solution is now attached as a patch-
>  UPDATE: we had a discussion on this subject at 
> [https://markmail.org/message/4jwrnbhpapb4ncrd] and Scott suggested to rather 
> temporary use the  child element of the   
> element. Temporary because the definitive solution (w/o using 
> ) could be either to update to Tomcat 9 (preferred) or even 
> downgrade to Tomcat 8. I guess nobody really want the later because only the 
> trunk and not yet released R17.12 branch are concerned.{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong

2018-03-27 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10304:

Description: 
I commited 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
 which I guess forced (or allowed?) James Yong to use the 
javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
userLogin service at 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]

Else it would (should?) have been
 

Now I need to revert/remove the wrapper in ContextFilter which is useless and 
silly (my bad).

{color:#ff}-After a deeper investigation today (saturday 2019-03-24) the 
right solution is now attached as a patch-
 UPDATE: we had a discussion on this subject at 
[https://markmail.org/message/4jwrnbhpapb4ncrd] and Scott suggested to rather 
temporary use the  child element of the   
element. Temporary because the definitive solution (w/o using ) 
could be either to update to Tomcat 9 (preferred) or even downgrade to Tomcat 
8. I guess nobody really want the later because only the trunk and not yet 
released R17.12 branch are concerned.{color}

  was:
I commited 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
 which I guess forced (or allowed?) James Yong to use the 
javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
userLogin service at 
[http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]

Else it would (should?) have been
 

Now I need to revert/remove the wrapper in ContextFilter which is useless and 
silly (my bad).

 

{color:#FF}After a deeper investigation today (saturday 2019-03-24) the 
right solution is now attached as a patch{color}
Update: we had a discussion on this subject at 


> The "request" attribute type of the userLogin service is wrong
> --
>
> Key: OFBIZ-10304
> URL: https://issues.apache.org/jira/browse/OFBIZ-10304
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10304.patch
>
>
> I commited 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
>  which I guess forced (or allowed?) James Yong to use the 
> javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
> userLogin service at 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]
> Else it would (should?) have been
>   type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and 
> silly (my bad).
> {color:#ff}-After a deeper investigation today (saturday 2019-03-24) the 
> right solution is now attached as a patch-
>  UPDATE: we had a discussion on this subject at 
> [https://markmail.org/message/4jwrnbhpapb4ncrd] and Scott suggested to rather 
> temporary use the  child element of the   
> element. Temporary because the definitive solution (w/o using 
> ) could be either to update to Tomcat 9 (preferred) or even 
> downgrade to Tomcat 8. I guess nobody really want the later because only the 
> trunk and not yet released R17.12 branch are concerned.{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong

2018-03-27 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10304:

   Priority: Blocker  (was: Major)
Component/s: framework

> The "request" attribute type of the userLogin service is wrong
> --
>
> Key: OFBIZ-10304
> URL: https://issues.apache.org/jira/browse/OFBIZ-10304
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10304.patch
>
>
> I commited 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
>  which I guess forced (or allowed?) James Yong to use the 
> javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
> userLogin service at 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]
> Else it would (should?) have been
>   type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and 
> silly (my bad).
> {color:#ff}-After a deeper investigation today (saturday 2019-03-24) the 
> right solution is now attached as a patch-
>  UPDATE: we had a discussion on this subject at 
> [https://markmail.org/message/4jwrnbhpapb4ncrd] and Scott suggested to rather 
> temporary use the  child element of the   
> element. Temporary because the definitive solution (w/o using 
> ) could be either to update to Tomcat 9 (preferred) or even 
> downgrade to Tomcat 8. I guess nobody really want the later because only the 
> trunk and not yet released R17.12 branch are concerned.{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong

2018-03-27 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411153#comment-16411153
 ] 

Jacques Le Roux edited comment on OFBIZ-10304 at 3/27/18 7:47 AM:
--

I reopen this issue after this discussion on dev ML: 
[https://markmail.org/message/yjlpzrwy7ptnvll6]

I think we need to revisit OFBIZ-10047 because I found another occurence of the 
problem in 
 payPalCheckoutUpdate. Jacopo said he will review the Tomcat SSO code and I'll 
try too.

*Actually note that the Tomcat SSO code only made appears this issue, it's not 
the "'culprit"; Tomcat 8.5 with its servlet4preview is .*


was (Author: jacques.le.roux):
I reopen this issue after this discussion on dev ML: 
[https://markmail.org/message/yjlpzrwy7ptnvll6]

I think we need to revisit OFBIZ-10047 because I found another occurence of the 
problem in 
 payPalCheckoutUpdate. Jacopo said he will review the Tomcat SSO code and I'll 
try too.

*Actually note that the Tomcat SSO code only made appears this issue, it's not 
the "'culprit" Tomcat 8.5 with its servlet4preview is .*

> The "request" attribute type of the userLogin service is wrong
> --
>
> Key: OFBIZ-10304
> URL: https://issues.apache.org/jira/browse/OFBIZ-10304
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10304.patch
>
>
> I commited 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
>  which I guess forced (or allowed?) James Yong to use the 
> javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
> userLogin service at 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]
> Else it would (should?) have been
>   type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and 
> silly (my bad).
> {color:#ff}-After a deeper investigation today (saturday 2019-03-24) the 
> right solution is now attached as a patch-
>  UPDATE: we had a discussion on this subject at 
> [https://markmail.org/message/4jwrnbhpapb4ncrd] and Scott suggested to rather 
> temporary use the  child element of the   
> element. Temporary because the definitive solution (w/o using 
> ) could be either to update to Tomcat 9 (preferred) or even 
> downgrade to Tomcat 8. I guess nobody really want the later because only the 
> trunk and not yet released R17.12 branch are concerned.{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10304) The "request" attribute type of the userLogin service is wrong

2018-03-27 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411153#comment-16411153
 ] 

Jacques Le Roux edited comment on OFBIZ-10304 at 3/27/18 7:47 AM:
--

I reopen this issue after this discussion on dev ML: 
[https://markmail.org/message/yjlpzrwy7ptnvll6]

I think we need to revisit OFBIZ-10047 because I found another occurence of the 
problem in 
 payPalCheckoutUpdate. Jacopo said he will review the Tomcat SSO code and I'll 
try too.

*Actually note that the Tomcat SSO code only made appears this issue, it's not 
the "'culprit" Tomcat 8.5 with its servlet4preview is .*


was (Author: jacques.le.roux):
I reopen this issue after this discussion on dev ML: 
https://markmail.org/message/yjlpzrwy7ptnvll6

I think we need to revisit OFBIZ-10047 because I found another occurence of the 
problem in 
payPalCheckoutUpdate. Jacopo said he will review the Tomcat SSO code and I'll 
try too.

> The "request" attribute type of the userLogin service is wrong
> --
>
> Key: OFBIZ-10304
> URL: https://issues.apache.org/jira/browse/OFBIZ-10304
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10304.patch
>
>
> I commited 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679]
>  which I guess forced (or allowed?) James Yong to use the 
> javax.servlet.http.HttpServletRequest as type of "request" attribute of the 
> userLogin service at 
> [http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133]
> Else it would (should?) have been
>   type="org.apache.catalina.connector.RequestFacade" optional="true"/>
> Now I need to revert/remove the wrapper in ContextFilter which is useless and 
> silly (my bad).
> {color:#ff}-After a deeper investigation today (saturday 2019-03-24) the 
> right solution is now attached as a patch-
>  UPDATE: we had a discussion on this subject at 
> [https://markmail.org/message/4jwrnbhpapb4ncrd] and Scott suggested to rather 
> temporary use the  child element of the   
> element. Temporary because the definitive solution (w/o using 
> ) could be either to update to Tomcat 9 (preferred) or even 
> downgrade to Tomcat 8. I guess nobody really want the later because only the 
> trunk and not yet released R17.12 branch are concerned.{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9833) Token Based Authentication

2018-03-27 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415242#comment-16415242
 ] 

Jacques Le Roux commented on OFBIZ-9833:


To clarify here, the problem is not Tomcat SSO, but Tomcat 8.5 and its 
servlet4preview hiding standard HTTP requests.
You can find more at https://markmail.org/message/4jwrnbhpapb4ncrd

> Token Based Authentication
> --
>
> Key: OFBIZ-9833
> URL: https://issues.apache.org/jira/browse/OFBIZ-9833
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: JSON Web Tokens.pdf, OFBIZ-9833-JWTManager.patch, Token 
> Based Authentication in Apache OfBiz.pdf, Token Based Authentication.pdf, 
> rfc7519.pdf
>
>
> Here is dev list discussion for token based authentication work:
> http://markmail.org/message/vyskeh2wujqpkbwg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-10301:
--
Affects Version/s: Trunk
  Component/s: order

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10301:
-

Assignee: Rishi Solanki  (was: Suraj Khurana)

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-27 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415409#comment-16415409
 ] 

Rishi Solanki commented on OFBIZ-10301:
---

After commit got build failure email, seems no issues with commit. I'll check 
and close the ticket. Thanks Suraj for your work.

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-03-27 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415494#comment-16415494
 ] 

Taher Alkhateeb commented on OFBIZ-10317:
-

Hi Rajesh,

The first thing we need to do is create a test script to repeat the break. 
>From there we can start to find solutions.

So my recommendation to start on this task is to create a test script (in 
groovy or python or whatever) that utilizes XML RPC to generate the error. We 
can use that same script to test our solutions later on.

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-03-27 Thread Rajesh Kumar Mallah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415528#comment-16415528
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

Hello Mr Taher ,

Firstly Thanks for initiating this.

Sure i can craft the spanner .

One thing that i  miss is exported services in the demo trunk/stable. The demo 
trunk
goes a long way to serve as common reference when discussing a wide range of
issues , however to create test cases involving XML/SOAP we have to involve 
local configurations and the test scripts loose their universality. 

It would have been useful if it were possible to utilize the demo infra for such
cases also.

I guess the demo trunk is a sandbox that resets everyday probably we shall need
some persistence mechanisms there for config data.

regds
mallah.

 

 

 

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-03-27 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415562#comment-16415562
 ] 

Taher Alkhateeb commented on OFBIZ-10317:
-

A simple patch would be sufficient for our work here. I prefer to keep the demo 
out of our experimentation.

Make it a minimal test case, just choose any service, make it exported, and 
then run your test script against that service, and get the error. This 
"repeatable" test would help us a lot in moving forward.

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10258) Add Document Content: hr-glossary.adoc

2018-03-27 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga reassigned OFBIZ-10258:
---

Assignee: Sharan Foga  (was: Swapnil M Mane)

> Add Document Content: hr-glossary.adoc
> --
>
> Key: OFBIZ-10258
> URL: https://issues.apache.org/jira/browse/OFBIZ-10258
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Sharan Foga
>Priority: Minor
> Attachments: OFBIZ-10258.patch, hr-glossary.adoc, hr-glossary.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-glossary.adoc file.
> An existing glossary can be found
> [https://cwiki.apache.org/confluence/display/OFBENDUSER/Human+Resources+Glossary]
> A copy of the existing file will be attached. Please write document content 
> for hr-glossary.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10258) Add Document Content: hr-glossary.adoc

2018-03-27 Thread Sharan Foga (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415576#comment-16415576
 ] 

Sharan Foga commented on OFBIZ-10258:
-

Hi [~swapnilmmane] I've taken a look and it looks very good. I corrected a 
small typo and did a little formatting but it is great. I'll upload my patch so 
you can see what I've changed. I think this is ready to commit, so will do that 
too

> Add Document Content: hr-glossary.adoc
> --
>
> Key: OFBIZ-10258
> URL: https://issues.apache.org/jira/browse/OFBIZ-10258
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Swapnil M Mane
>Priority: Minor
> Attachments: OFBIZ-10258.patch, hr-glossary.adoc, hr-glossary.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-glossary.adoc file.
> An existing glossary can be found
> [https://cwiki.apache.org/confluence/display/OFBENDUSER/Human+Resources+Glossary]
> A copy of the existing file will be attached. Please write document content 
> for hr-glossary.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10258) Add Document Content: hr-glossary.adoc

2018-03-27 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-10258:

Attachment: OFBIZ-10258sf.patch

> Add Document Content: hr-glossary.adoc
> --
>
> Key: OFBIZ-10258
> URL: https://issues.apache.org/jira/browse/OFBIZ-10258
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Sharan Foga
>Priority: Minor
> Attachments: OFBIZ-10258.patch, OFBIZ-10258sf.patch, 
> hr-glossary.adoc, hr-glossary.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-glossary.adoc file.
> An existing glossary can be found
> [https://cwiki.apache.org/confluence/display/OFBENDUSER/Human+Resources+Glossary]
> A copy of the existing file will be attached. Please write document content 
> for hr-glossary.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10258) Add Document Content: hr-glossary.adoc

2018-03-27 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-10258:

Labels: asciidoc documentaion humanres  (was: )

> Add Document Content: hr-glossary.adoc
> --
>
> Key: OFBIZ-10258
> URL: https://issues.apache.org/jira/browse/OFBIZ-10258
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Sharan Foga
>Priority: Minor
>  Labels: asciidoc, documentaion, humanres
> Attachments: OFBIZ-10258.patch, OFBIZ-10258sf.patch, 
> hr-glossary.adoc, hr-glossary.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-glossary.adoc file.
> An existing glossary can be found
> [https://cwiki.apache.org/confluence/display/OFBENDUSER/Human+Resources+Glossary]
> A copy of the existing file will be attached. Please write document content 
> for hr-glossary.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10258) Add Document Content: hr-glossary.adoc

2018-03-27 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga updated OFBIZ-10258:

Fix Version/s: Upcoming Branch

> Add Document Content: hr-glossary.adoc
> --
>
> Key: OFBIZ-10258
> URL: https://issues.apache.org/jira/browse/OFBIZ-10258
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Sharan Foga
>Priority: Minor
>  Labels: asciidoc, documentaion, humanres
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10258.patch, OFBIZ-10258sf.patch, 
> hr-glossary.adoc, hr-glossary.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-glossary.adoc file.
> An existing glossary can be found
> [https://cwiki.apache.org/confluence/display/OFBENDUSER/Human+Resources+Glossary]
> A copy of the existing file will be attached. Please write document content 
> for hr-glossary.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10258) Add Document Content: hr-glossary.adoc

2018-03-27 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga closed OFBIZ-10258.
---
Resolution: Implemented

Committed at r1827834. Thanks [~swapnilmmane] for the patch

> Add Document Content: hr-glossary.adoc
> --
>
> Key: OFBIZ-10258
> URL: https://issues.apache.org/jira/browse/OFBIZ-10258
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Sharan Foga
>Priority: Minor
>  Labels: asciidoc, documentaion, humanres
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10258.patch, OFBIZ-10258sf.patch, 
> hr-glossary.adoc, hr-glossary.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-glossary.adoc file.
> An existing glossary can be found
> [https://cwiki.apache.org/confluence/display/OFBENDUSER/Human+Resources+Glossary]
> A copy of the existing file will be attached. Please write document content 
> for hr-glossary.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10258) Add Document Content: hr-glossary.adoc

2018-03-27 Thread Swapnil M Mane (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415613#comment-16415613
 ] 

Swapnil M Mane commented on OFBIZ-10258:


Thank you [~sharan]! :)

> Add Document Content: hr-glossary.adoc
> --
>
> Key: OFBIZ-10258
> URL: https://issues.apache.org/jira/browse/OFBIZ-10258
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Sharan Foga
>Priority: Minor
>  Labels: asciidoc, documentaion, humanres
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10258.patch, OFBIZ-10258sf.patch, 
> hr-glossary.adoc, hr-glossary.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-glossary.adoc file.
> An existing glossary can be found
> [https://cwiki.apache.org/confluence/display/OFBENDUSER/Human+Resources+Glossary]
> A copy of the existing file will be attached. Please write document content 
> for hr-glossary.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10301.
---
   Resolution: Fixed
Fix Version/s: Trunk
   Upcoming Branch

Thanks [~suraj.khurana] for reporting the issue and providing patch for the 
same. Your patch has been committed in trunk -r1827827 and 17.12 branch 
-r1827828.

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch, Trunk
>
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items

2018-03-27 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10301.
-

> loadCartFromOrder changes order date even when updating order items
> ---
>
> Key: OFBIZ-10301
> URL: https://issues.apache.org/jira/browse/OFBIZ-10301
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Trunk, Upcoming Branch
>
> Attachments: OFBIZ-10301.patch
>
>
> It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is 
> true other wise it should set orderDate from existing orderHeader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10317) Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN fields

2018-03-27 Thread Rajesh Kumar Mallah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415679#comment-16415679
 ] 

Rajesh Kumar Mallah commented on OFBIZ-10317:
-

Sure Taher ,

Pls allow some moments, I  will provide the repeatable case.

Regds
mallah

> Allowing XML-RPC and SOAP to pass GenericValue objects to services as IN 
> fields
> ---
>
> Key: OFBIZ-10317
> URL: https://issues.apache.org/jira/browse/OFBIZ-10317
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Major
>
>  
> The existing framework allows invoking  various services via XMLRPC or SOAP 
> as per their argument expectations. However only basic types are handled
> like String , Boolean , Int etc. If a service is expecting a GenericValue eg: 
> 'calculateProductPrice'   it is not possible to invoke it via SOAP or XMLRPC.
> The reason being SOAP or XMLRPC can support Map and that is the closest 
> it can provide in lieu of any custom Object that a Service might be expecting.
> A generic solution needs to be found so that the full potential of the 
> plethora of 
> exportable services can be utilized by external systems that looks for 
> integrating and 
> banking upon OfBiz via XMLRPC or SOAP.
> h6. related Threads:
> [How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC]
> [https://markmail.org/message/dwako4nsu4h3zgmu] [ dev ]
> [https://markmail.org/message/iuffmakor3ru2yce] [user]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-6882) Extend the PostalAddress entity with additional elements

2018-03-27 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416089#comment-16416089
 ] 

Jacques Le Roux commented on OFBIZ-6882:


Thanks Scott, Paul, Nicolas (long ago),

I agree I should have gone with streetNumber, I think I focused on the 
functionallity but not the name despite your several comments.

It's not a big deal, we can add streetNumber and streetNumberExt in trunk 
keeping oldHouseNumber and oldHouseNumberExt with column-names STREET_NUMBER 
and STREET_NUMBER_EXT plus provide a service to move the data from the old 
fields to the new ones. Also we should mark those fields to be removed in next 
release branch (I don't remember how we decided to mark that). 

Agreed? We could even dot that in R17 (no risks at all) since it has not been 
released, what do you think?

> Extend the PostalAddress entity with additional elements
> 
>
> Key: OFBIZ-6882
> URL: https://issues.apache.org/jira/browse/OFBIZ-6882
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: 3rdParty, Shipment, integration
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6882-party-PostalAddress.patch
>
>
> Various modern day 3rd party delivery solutions (e.g. PostNL in The 
> Netherlands) require that elements are delivered separately, so that 
> addresses can be checked more easily.
> Current definition of the PostalAddress doesn't have separation of:
> * street name
> * house number
> * house number addition or extension



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-6882) Extend the PostalAddress entity with additional elements

2018-03-27 Thread Scott Gray (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416379#comment-16416379
 ] 

Scott Gray commented on OFBIZ-6882:
---

A rushed data model change with no design discussion from you, despite feedback 
which should have been addressed.  Data model changes are always a "big deal" 
because there are no quick fixes, migration is required and the old fields 
stick around for a long time.

My comment is less about how we should fix change and more about how we should 
fix our collaboration process.  If doubts are raised and not addressed, then 
nothing should ever be committed until that happens especially in the data 
model.

> Extend the PostalAddress entity with additional elements
> 
>
> Key: OFBIZ-6882
> URL: https://issues.apache.org/jira/browse/OFBIZ-6882
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: 3rdParty, Shipment, integration
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6882-party-PostalAddress.patch
>
>
> Various modern day 3rd party delivery solutions (e.g. PostNL in The 
> Netherlands) require that elements are delivered separately, so that 
> addresses can be checked more easily.
> Current definition of the PostalAddress doesn't have separation of:
> * street name
> * house number
> * house number addition or extension



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-6882) Extend the PostalAddress entity with additional elements

2018-03-27 Thread Scott Gray (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416379#comment-16416379
 ] 

Scott Gray edited comment on OFBIZ-6882 at 3/27/18 10:57 PM:
-

A rushed data model change with no design discussion from you, despite feedback 
which should have been addressed.  Data model changes are always a "big deal" 
because there are no quick fixes, migration is required and the old fields 
stick around for a long time.

My comment is less about how we should fix this change and more about how we 
should fix our collaboration process.  If doubts are raised and not addressed, 
then nothing should ever be committed until that happens especially in the data 
model.


was (Author: lektran):
A rushed data model change with no design discussion from you, despite feedback 
which should have been addressed.  Data model changes are always a "big deal" 
because there are no quick fixes, migration is required and the old fields 
stick around for a long time.

My comment is less about how we should fix change and more about how we should 
fix our collaboration process.  If doubts are raised and not addressed, then 
nothing should ever be committed until that happens especially in the data 
model.

> Extend the PostalAddress entity with additional elements
> 
>
> Key: OFBIZ-6882
> URL: https://issues.apache.org/jira/browse/OFBIZ-6882
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: 3rdParty, Shipment, integration
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6882-party-PostalAddress.patch
>
>
> Various modern day 3rd party delivery solutions (e.g. PostNL in The 
> Netherlands) require that elements are delivered separately, so that 
> addresses can be checked more easily.
> Current definition of the PostalAddress doesn't have separation of:
> * street name
> * house number
> * house number addition or extension



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10186) Configure official document templates for an organizational party

2018-03-27 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10186:
--
Attachment: OFBIZ-10186.patch

> Configure official document templates for an organizational party
> -
>
> Key: OFBIZ-10186
> URL: https://issues.apache.org/jira/browse/OFBIZ-10186
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
>  Labels: invoice, organization, template
> Attachments: OFBIZ-10186-PartyPref.patch, 
> OFBIZ-10186-commonscreens.patch, OFBIZ-10186.patch, OFBIZ-10186.patch, 
> OFBIZ-10186.patch, Sélection_134.png, Sélection_135.png
>
>
> For an organizational party, add possibility to give the specific template to 
> use for official document like invoice and order.
> The first step is adding mechanism to indicate what template to use for a 
> party, for that :
>  * add CustomScreen entity (like CustomMethod) to prepare and organize your 
> screen by theme
>  * add PartyPrefDocTypeTpl as association entity between an organizational 
> party, a document type and a custom screen
> For use case, I create a new invoice template for oriented on EU format (in 
> process) with VAT directly display on invoice item.
> Related mailing list thread : 
> https://lists.apache.org/thread.html/4a5244e6d022564414e4f4a5676f72288d4000913ec2afa7e4af5e1a@%3Cdev.ofbiz.apache.org%3E
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10186) Configure official document templates for an organizational party

2018-03-27 Thread Aditya Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416830#comment-16416830
 ] 

Aditya Sharma commented on OFBIZ-10186:
---

Hi Nicolas,

Great work here.

I think there is a typo in createPartyPrefDocTypeTpl service definition. 

Got following logs:
{quote}No parameter found for override parameter named: partylId in service 
createPartyPrefDocTypeTpl
{quote}
Attaching a patch.

Thanks!

> Configure official document templates for an organizational party
> -
>
> Key: OFBIZ-10186
> URL: https://issues.apache.org/jira/browse/OFBIZ-10186
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
>  Labels: invoice, organization, template
> Attachments: OFBIZ-10186-PartyPref.patch, 
> OFBIZ-10186-commonscreens.patch, OFBIZ-10186.patch, OFBIZ-10186.patch, 
> OFBIZ-10186.patch, Sélection_134.png, Sélection_135.png
>
>
> For an organizational party, add possibility to give the specific template to 
> use for official document like invoice and order.
> The first step is adding mechanism to indicate what template to use for a 
> party, for that :
>  * add CustomScreen entity (like CustomMethod) to prepare and organize your 
> screen by theme
>  * add PartyPrefDocTypeTpl as association entity between an organizational 
> party, a document type and a custom screen
> For use case, I create a new invoice template for oriented on EU format (in 
> process) with VAT directly display on invoice item.
> Related mailing list thread : 
> https://lists.apache.org/thread.html/4a5244e6d022564414e4f4a5676f72288d4000913ec2afa7e4af5e1a@%3Cdev.ofbiz.apache.org%3E
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)