[jira] [Updated] (OFBIZ-10328) CatalogServices #duplicateProductCategory doesn't check for existing categories

2018-04-05 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10328:
--
Summary: CatalogServices #duplicateProductCategory doesn't check for 
existing categories  (was: CLONE - CatalogServices #duplicateProductCategory 
doesn't check for existing categories)

> CatalogServices #duplicateProductCategory doesn't check for existing 
> categories
> ---
>
> Key: OFBIZ-10328
> URL: https://issues.apache.org/jira/browse/OFBIZ-10328
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: 
> OFBIZ-10328_applications.prodict.groovyScripts.product.category.CategoryServices_validatePrimaryKey.patch
>
>
> {quote}"This method just crashes, if there is an attribute which has the same 
> name as the one the user is trying to create.
>  There should be a check for existing attributes and a clean return, no 
> exception throwing." [~Dennis Balkir]
> {quote}
> There is no check for duplicates in this method either, resulting in a crash 
> and unhandled exceptions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10328) CLONE - CatalogServices #duplicateProductCategory doesn't check for existing categories

2018-04-05 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10328:
--
Attachment: 
OFBIZ-10328_applications.prodict.groovyScripts.product.category.CategoryServices_validatePrimaryKey.patch

> CLONE - CatalogServices #duplicateProductCategory doesn't check for existing 
> categories
> ---
>
> Key: OFBIZ-10328
> URL: https://issues.apache.org/jira/browse/OFBIZ-10328
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: 
> OFBIZ-10328_applications.prodict.groovyScripts.product.category.CategoryServices_validatePrimaryKey.patch
>
>
> {quote}"This method just crashes, if there is an attribute which has the same 
> name as the one the user is trying to create.
>  There should be a check for existing attributes and a clean return, no 
> exception throwing." [~Dennis Balkir]
> {quote}
> There is no check for duplicates in this method either, resulting in a crash 
> and unhandled exceptions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10328) CLONE - CatalogServices #duplicateProductCategory doesn't check for existing categories

2018-04-05 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10328:
--
Description: 
{quote}"This method just crashes, if there is an attribute which has the same 
name as the one the user is trying to create.
 There should be a check for existing attributes and a clean return, no 
exception throwing." [~Dennis Balkir]
{quote}
There is no check for duplicates in this method either, resulting in a crash 
and unhandled exceptions.

  was:
"This method just crashes, if there is an attribute which has the same name as 
the one the user is trying to create.
 There should be a check for existing attributes and a clean return, no 
exception throwing." [~Dennis Balkir]


> CLONE - CatalogServices #duplicateProductCategory doesn't check for existing 
> categories
> ---
>
> Key: OFBIZ-10328
> URL: https://issues.apache.org/jira/browse/OFBIZ-10328
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
>
> {quote}"This method just crashes, if there is an attribute which has the same 
> name as the one the user is trying to create.
>  There should be a check for existing attributes and a clean return, no 
> exception throwing." [~Dennis Balkir]
> {quote}
> There is no check for duplicates in this method either, resulting in a crash 
> and unhandled exceptions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10328) CLONE - CatalogServices #duplicateProductCategory doesn't check for existing categories

2018-04-05 Thread Benjamin Jugl (JIRA)
Benjamin Jugl created OFBIZ-10328:
-

 Summary: CLONE - CatalogServices #duplicateProductCategory doesn't 
check for existing categories
 Key: OFBIZ-10328
 URL: https://issues.apache.org/jira/browse/OFBIZ-10328
 Project: OFBiz
  Issue Type: Bug
Affects Versions: Trunk
Reporter: Benjamin Jugl
Assignee: Benjamin Jugl


"This method just crashes, if there is an attribute which has the same name as 
the one the user is trying to create.
 There should be a check for existing attributes and a clean return, no 
exception throwing." [~Dennis Balkir]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10327) CatalogServices #createProductCategoryAttribute doesn't check for existing attributes

2018-04-05 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10327:
--
Attachment: 
OFBIZ-10327_applications.prodict.groovyScripts.product.category.CategoryServices_validateCompositePrimaryKey.patch

> CatalogServices #createProductCategoryAttribute doesn't check for existing 
> attributes
> -
>
> Key: OFBIZ-10327
> URL: https://issues.apache.org/jira/browse/OFBIZ-10327
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: 
> OFBIZ-10327_applications.prodict.groovyScripts.product.category.CategoryServices_validateCompositePrimaryKey.patch
>
>
> "This method just crashes, if there is an attribute which has the same name 
> as the one the user is trying to create.
>  There should be a check for existing attributes and a clean return, no 
> exception throwing." [~Dennis Balkir]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10327) CatalogServices #createProductCategoryAttribute doesn't check for existing attributes

2018-04-05 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10327:
--
Affects Version/s: Trunk

> CatalogServices #createProductCategoryAttribute doesn't check for existing 
> attributes
> -
>
> Key: OFBIZ-10327
> URL: https://issues.apache.org/jira/browse/OFBIZ-10327
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: 
> OFBIZ-10327_applications.prodict.groovyScripts.product.category.CategoryServices_validateCompositePrimaryKey.patch
>
>
> "This method just crashes, if there is an attribute which has the same name 
> as the one the user is trying to create.
>  There should be a check for existing attributes and a clean return, no 
> exception throwing." [~Dennis Balkir]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10327) CatalogServices #createProductCategoryAttribute doesn't check for existing attributes

2018-04-05 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10327:
--
Description: 
"This method just crashes, if there is an attribute which has the same name as 
the one the user is trying to create.
 There should be a check for existing attributes and a clean return, no 
exception throwing." [~Dennis Balkir]

  was:
"This method just crashes, if there is an attribute which has the same name as 
the one the user is trying to create.
There should be a check for existing attributes and a clean return, no 
exception throwing."(@Dennis Balkir)


> CatalogServices #createProductCategoryAttribute doesn't check for existing 
> attributes
> -
>
> Key: OFBIZ-10327
> URL: https://issues.apache.org/jira/browse/OFBIZ-10327
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
>
> "This method just crashes, if there is an attribute which has the same name 
> as the one the user is trying to create.
>  There should be a check for existing attributes and a clean return, no 
> exception throwing." [~Dennis Balkir]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10327) CatalogServices #createProductCategoryAttribute doesn't check for existing attributes

2018-04-05 Thread Benjamin Jugl (JIRA)
Benjamin Jugl created OFBIZ-10327:
-

 Summary: CatalogServices #createProductCategoryAttribute doesn't 
check for existing attributes
 Key: OFBIZ-10327
 URL: https://issues.apache.org/jira/browse/OFBIZ-10327
 Project: OFBiz
  Issue Type: Bug
Reporter: Benjamin Jugl
Assignee: Benjamin Jugl


"This method just crashes, if there is an attribute which has the same name as 
the one the user is trying to create.
There should be a check for existing attributes and a clean return, no 
exception throwing."(@Dennis Balkir)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10326) Implement dependency from "State/Province" Field to "Country" in New Employee Form

2018-04-05 Thread Benjamin Jugl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426754#comment-16426754
 ] 

Benjamin Jugl commented on OFBIZ-10326:
---

Thank you [~jleichert] for the patch.

> Implement dependency from "State/Province" Field to "Country" in New Employee 
> Form
> --
>
> Key: OFBIZ-10326
> URL: https://issues.apache.org/jira/browse/OFBIZ-10326
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: 
> OFBIZ-10326_org.apache.ofbiz.humanres.widget.Employee_dependentDropdown.patch
>
>
> In OFBiz go to Facility -> Contact Information -> New Contact Information 
> Select "Postal Address" in the dropdown and click "create". In this form the 
> "State/Province" dropdown is dependant on the "Country" dropdown. Once a 
> country is selected the States of that country will be in the selection of 
> the first dropdown. This behaviour should be part of every form which has an 
> address as an input. The dropdown dependencies are realized with the 
> getDependentDropdownValues function in miscAjaxFunctions.js.
> A place where this functionality is missing is in the HR section of OFBiz. 
> Got to HR -> Employees -> New Employee 
> ([https://localhost:8443/humanres/control/NewEmployee])
> Here, the "State" dropdown lists ALL states which are listed in the geo 
> entity. It would be nice to implement dependant dropdowns here aswell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10306) Create an asciidoc style guide for the OFBiz project

2018-04-05 Thread Sharan Foga (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426755#comment-16426755
 ] 

Sharan Foga commented on OFBIZ-10306:
-

Thanks Michael. I will try and take a look at it over the weekend and come back 
with any comments.

> Create an asciidoc style guide for the OFBiz project
> 
>
> Key: OFBIZ-10306
> URL: https://issues.apache.org/jira/browse/OFBIZ-10306
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: asciidoc, documentation
> Attachments: OFBIZ-10306_Create_styleguide.patch
>
>
> Create a guideline/ style guide as discussed in the mailing list (see 
> [https://s.apache.org/qJoS]).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10326) Implement dependency from "State/Province" Field to "Country" in New Employee Form

2018-04-05 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10326:
--
Attachment: 
OFBIZ-10326_org.apache.ofbiz.humanres.widget.Employee_dependentDropdown.patch

> Implement dependency from "State/Province" Field to "Country" in New Employee 
> Form
> --
>
> Key: OFBIZ-10326
> URL: https://issues.apache.org/jira/browse/OFBIZ-10326
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: 
> OFBIZ-10326_org.apache.ofbiz.humanres.widget.Employee_dependentDropdown.patch
>
>
> In OFBiz go to Facility -> Contact Information -> New Contact Information 
> Select "Postal Address" in the dropdown and click "create". In this form the 
> "State/Province" dropdown is dependant on the "Country" dropdown. Once a 
> country is selected the States of that country will be in the selection of 
> the first dropdown. This behaviour should be part of every form which has an 
> address as an input. The dropdown dependencies are realized with the 
> getDependentDropdownValues function in miscAjaxFunctions.js.
> A place where this functionality is missing is in the HR section of OFBiz. 
> Got to HR -> Employees -> New Employee 
> ([https://localhost:8443/humanres/control/NewEmployee])
> Here, the "State" dropdown lists ALL states which are listed in the geo 
> entity. It would be nice to implement dependant dropdowns here aswell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10300) Convert Minilang to Groovy Guide into asciidoc

2018-04-05 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10300:
--
Attachment: OFBIZ-10300_Convert_Minilang_to_Groovy_guide_into_asciidoc.patch

> Convert Minilang to Groovy Guide into asciidoc 
> ---
>
> Key: OFBIZ-10300
> URL: https://issues.apache.org/jira/browse/OFBIZ-10300
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: 
> OFBIZ-10300_Convert_Minilang_to_Groovy_guide_into_asciidoc.patch
>
>
> Convert [~Dennis Balkir]s [Minilang to Groovy 
> Guide|https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+From+Mini+Language+to+Groovy]
>  into AsciiDoc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10326) Implement dependency from "State/Province" Field to "Country" in New Employee Form

2018-04-05 Thread Benjamin Jugl (JIRA)
Benjamin Jugl created OFBIZ-10326:
-

 Summary: Implement dependency from "State/Province" Field to 
"Country" in New Employee Form
 Key: OFBIZ-10326
 URL: https://issues.apache.org/jira/browse/OFBIZ-10326
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Benjamin Jugl
Assignee: Benjamin Jugl


In OFBiz go to Facility -> Contact Information -> New Contact Information 
Select "Postal Address" in the dropdown and click "create". In this form the 
"State/Province" dropdown is dependant on the "Country" dropdown. Once a 
country is selected the States of that country will be in the selection of the 
first dropdown. This behaviour should be part of every form which has an 
address as an input. The dropdown dependencies are realized with the 
getDependentDropdownValues function in miscAjaxFunctions.js.

A place where this functionality is missing is in the HR section of OFBiz. Got 
to HR -> Employees -> New Employee 
([https://localhost:8443/humanres/control/NewEmployee])
Here, the "State" dropdown lists ALL states which are listed in the geo entity. 
It would be nice to implement dependant dropdowns here aswell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)