[jira] [Assigned] (OFBIZ-10268) Add Document Content: hr-training.adoc

2018-04-09 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga reassigned OFBIZ-10268:
---

Assignee: Sharan Foga  (was: Benjamin Jugl)

> Add Document Content: hr-training.adoc
> --
>
> Key: OFBIZ-10268
> URL: https://issues.apache.org/jira/browse/OFBIZ-10268
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Sharan Foga
>Priority: Minor
> Attachments: hr-training.adoc, hr-training.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-training.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-training.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10268) Add Document Content: hr-training.adoc

2018-04-09 Thread Sharan Foga (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431164#comment-16431164
 ] 

Sharan Foga commented on OFBIZ-10268:
-

Hi [~bjugl] thanks for doing some work on this. I'll take a look at it.

> Add Document Content: hr-training.adoc
> --
>
> Key: OFBIZ-10268
> URL: https://issues.apache.org/jira/browse/OFBIZ-10268
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-training.adoc, hr-training.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-training.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-training.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10242) Standardise Layout throughout Applications

2018-04-09 Thread Dennis Balkir (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430640#comment-16430640
 ] 

Dennis Balkir commented on OFBIZ-10242:
---

added another patch, this time for marketing

> Standardise Layout throughout Applications
> --
>
> Key: OFBIZ-10242
> URL: https://issues.apache.org/jira/browse/OFBIZ-10242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: 
> OFBIZ-10242-marketing.widget.MarketingCampaignScreens.patch, 
> OFBIZ-10242_common.SecurityScreens.patch, 
> OFBIZ-10242_content.CompDocScreens.patch, 
> OFBIZ-10242_content.ContentScreens.patch, 
> OFBIZ-10242_content.ContentSetupScreens.patch, 
> OFBIZ-10242_content.DataResourceScreens.patch, 
> OFBIZ-10242_content.DataResourceSetupScreens.patch, 
> OFBIZ-10242_content.ForumScreens2.patch, 
> OFBIZ-10242_webtools.EnitityScreens.patch, 
> OFBIZ-10242_webtools.StatsScreens.patch, 
> OFBIZ_webtools.ArtifactInfoScreen.patch, 
> OFBiz-10242_applications.content.widget.cms.CMSForms.patch
>
>
> While working on a Theme I discovered that many screens are missing 
> screenlets, or some buttons are at the wrong Position etc. .
> I propose to standardise the layout of every screen, to support easy theming. 
> Similar to the examplary patch provided below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10242) Standardise Layout throughout Applications

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10242:
--
Attachment: OFBIZ-10242-marketing.widget.MarketingCampaignScreens.patch

> Standardise Layout throughout Applications
> --
>
> Key: OFBIZ-10242
> URL: https://issues.apache.org/jira/browse/OFBIZ-10242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: 
> OFBIZ-10242-marketing.widget.MarketingCampaignScreens.patch, 
> OFBIZ-10242_common.SecurityScreens.patch, 
> OFBIZ-10242_content.CompDocScreens.patch, 
> OFBIZ-10242_content.ContentScreens.patch, 
> OFBIZ-10242_content.ContentSetupScreens.patch, 
> OFBIZ-10242_content.DataResourceScreens.patch, 
> OFBIZ-10242_content.DataResourceSetupScreens.patch, 
> OFBIZ-10242_content.ForumScreens2.patch, 
> OFBIZ-10242_webtools.EnitityScreens.patch, 
> OFBIZ-10242_webtools.StatsScreens.patch, 
> OFBIZ_webtools.ArtifactInfoScreen.patch, 
> OFBiz-10242_applications.content.widget.cms.CMSForms.patch
>
>
> While working on a Theme I discovered that many screens are missing 
> screenlets, or some buttons are at the wrong Position etc. .
> I propose to standardise the layout of every screen, to support easy theming. 
> Similar to the examplary patch provided below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10331) Improve Order

2018-04-09 Thread Dennis Balkir (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430637#comment-16430637
 ] 

Dennis Balkir commented on OFBIZ-10331:
---

I added a new patch and this should fix this error

> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10331) Improve Order

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10331:
--
Attachment: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch

> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10242) Standardise Layout throughout Applications

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10242:
--
Attachment: OFBiz-10242_applications.content.widget.cms.CMSForms.patch

> Standardise Layout throughout Applications
> --
>
> Key: OFBIZ-10242
> URL: https://issues.apache.org/jira/browse/OFBIZ-10242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: OFBIZ-10242_common.SecurityScreens.patch, 
> OFBIZ-10242_content.CompDocScreens.patch, 
> OFBIZ-10242_content.ContentScreens.patch, 
> OFBIZ-10242_content.ContentSetupScreens.patch, 
> OFBIZ-10242_content.DataResourceScreens.patch, 
> OFBIZ-10242_content.DataResourceSetupScreens.patch, 
> OFBIZ-10242_content.ForumScreens2.patch, 
> OFBIZ-10242_webtools.EnitityScreens.patch, 
> OFBIZ-10242_webtools.StatsScreens.patch, 
> OFBIZ_webtools.ArtifactInfoScreen.patch, 
> OFBiz-10242_applications.content.widget.cms.CMSForms.patch
>
>
> While working on a Theme I discovered that many screens are missing 
> screenlets, or some buttons are at the wrong Position etc. .
> I propose to standardise the layout of every screen, to support easy theming. 
> Similar to the examplary patch provided below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10242) Standardise Layout throughout Applications

2018-04-09 Thread Dennis Balkir (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430633#comment-16430633
 ] 

Dennis Balkir commented on OFBIZ-10242:
---

Added another patch for content

> Standardise Layout throughout Applications
> --
>
> Key: OFBIZ-10242
> URL: https://issues.apache.org/jira/browse/OFBIZ-10242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: OFBIZ-10242_common.SecurityScreens.patch, 
> OFBIZ-10242_content.CompDocScreens.patch, 
> OFBIZ-10242_content.ContentScreens.patch, 
> OFBIZ-10242_content.ContentSetupScreens.patch, 
> OFBIZ-10242_content.DataResourceScreens.patch, 
> OFBIZ-10242_content.DataResourceSetupScreens.patch, 
> OFBIZ-10242_content.ForumScreens2.patch, 
> OFBIZ-10242_webtools.EnitityScreens.patch, 
> OFBIZ-10242_webtools.StatsScreens.patch, 
> OFBIZ_webtools.ArtifactInfoScreen.patch, 
> OFBiz-10242_applications.content.widget.cms.CMSForms.patch
>
>
> While working on a Theme I discovered that many screens are missing 
> screenlets, or some buttons are at the wrong Position etc. .
> I propose to standardise the layout of every screen, to support easy theming. 
> Similar to the examplary patch provided below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: 
OFBiz-10242_applications.content.widget.cms.CMSForms.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: OFBiz-10242_applications.content.widget.cms.CMSForms.patch

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch, 
> OFBiz-10242_applications.content.widget.cms.CMSForms.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10263) Add Document Content: hr-positions.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430624#comment-16430624
 ] 

Benjamin Jugl edited comment on OFBIZ-10263 at 4/9/18 2:46 PM:
---

I think this is duplicate of 
[https://issues.apache.org/jira/browse/OFBIZ-10259]. While the Overview talks 
about Positions, the Detail calls them "Employee Positions". As I understand 
it, the same topic is covered.


was (Author: bjugl):
I think this is duplicate of [#10259]. While the Overview talks about 
Positions, the Detail calls them "Employee Positions". As I understand it, the 
same topic is covered.

> Add Document Content: hr-positions.adoc
> ---
>
> Key: OFBIZ-10263
> URL: https://issues.apache.org/jira/browse/OFBIZ-10263
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-positions.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-positions.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-positions.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10263) Add Document Content: hr-positions.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430624#comment-16430624
 ] 

Benjamin Jugl commented on OFBIZ-10263:
---

I think this is duplicate of [#10259]. While the Overview talks about 
Positions, the Detail calls them "Employee Positions". As I understand it, the 
same topic is covered.

> Add Document Content: hr-positions.adoc
> ---
>
> Key: OFBIZ-10263
> URL: https://issues.apache.org/jira/browse/OFBIZ-10263
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-positions.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-positions.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-positions.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430581#comment-16430581
 ] 

Dennis Balkir commented on OFBIZ-10221:
---

Hi [~deepak.dixit],
I added a new patch, this should fix it.

Thanks for your comment on the patches

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: OFBIZ-10221-product.template.Main.patch

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10263) Add Document Content: hr-positions.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10263:
--
Attachment: (was: hr-positions.adoc)

> Add Document Content: hr-positions.adoc
> ---
>
> Key: OFBIZ-10263
> URL: https://issues.apache.org/jira/browse/OFBIZ-10263
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-positions.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-positions.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-positions.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10260) Add Document Content: hr-employees.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430528#comment-16430528
 ] 

Benjamin Jugl commented on OFBIZ-10260:
---

Sorry, what state should I give to signal that I added content?

> Add Document Content: hr-employees.adoc
> ---
>
> Key: OFBIZ-10260
> URL: https://issues.apache.org/jira/browse/OFBIZ-10260
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-employees.adoc, hr-employees.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc files,  write or organise the content for 
> the hr-employees.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-employees.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10268) Add Document Content: hr-training.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl reopened OFBIZ-10268:
---

> Add Document Content: hr-training.adoc
> --
>
> Key: OFBIZ-10268
> URL: https://issues.apache.org/jira/browse/OFBIZ-10268
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-training.adoc, hr-training.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-training.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-training.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10263) Add Document Content: hr-positions.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl reopened OFBIZ-10263:
---

> Add Document Content: hr-positions.adoc
> ---
>
> Key: OFBIZ-10263
> URL: https://issues.apache.org/jira/browse/OFBIZ-10263
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-positions.adoc, hr-positions.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-positions.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-positions.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10260) Add Document Content: hr-employees.adoc

2018-04-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430533#comment-16430533
 ] 

Jacques Le Roux commented on OFBIZ-10260:
-

Provide Patch, you can find more at  
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices

> Add Document Content: hr-employees.adoc
> ---
>
> Key: OFBIZ-10260
> URL: https://issues.apache.org/jira/browse/OFBIZ-10260
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-employees.adoc, hr-employees.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc files,  write or organise the content for 
> the hr-employees.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-employees.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10260) Add Document Content: hr-employees.adoc

2018-04-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-10260:
-

Please Benjamin, don't close before it has been committed ;)

> Add Document Content: hr-employees.adoc
> ---
>
> Key: OFBIZ-10260
> URL: https://issues.apache.org/jira/browse/OFBIZ-10260
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-employees.adoc, hr-employees.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc files,  write or organise the content for 
> the hr-employees.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-employees.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10261) Add Document Content: hr-employments.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10261:
--
Attachment: hr-employments.adoc

> Add Document Content: hr-employments.adoc
> -
>
> Key: OFBIZ-10261
> URL: https://issues.apache.org/jira/browse/OFBIZ-10261
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-employments.adoc, hr-employments.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-employments.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-employments.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10261) Add Document Content: hr-employments.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl reassigned OFBIZ-10261:
-

Assignee: Benjamin Jugl

> Add Document Content: hr-employments.adoc
> -
>
> Key: OFBIZ-10261
> URL: https://issues.apache.org/jira/browse/OFBIZ-10261
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-employments.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-employments.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-employments.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10260) Add Document Content: hr-employees.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10260:
--
Attachment: hr-employees.adoc

> Add Document Content: hr-employees.adoc
> ---
>
> Key: OFBIZ-10260
> URL: https://issues.apache.org/jira/browse/OFBIZ-10260
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-employees.adoc, hr-employees.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc files,  write or organise the content for 
> the hr-employees.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-employees.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10260) Add Document Content: hr-employees.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl resolved OFBIZ-10260.
---
Resolution: Done

> Add Document Content: hr-employees.adoc
> ---
>
> Key: OFBIZ-10260
> URL: https://issues.apache.org/jira/browse/OFBIZ-10260
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-employees.adoc, hr-employees.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc files,  write or organise the content for 
> the hr-employees.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-employees.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10263) Add Document Content: hr-positions.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10263:
--
Attachment: (was: hr-positions.adoc)

> Add Document Content: hr-positions.adoc
> ---
>
> Key: OFBIZ-10263
> URL: https://issues.apache.org/jira/browse/OFBIZ-10263
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-positions.adoc, hr-positions.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-positions.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-positions.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10263) Add Document Content: hr-positions.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10263:
--
Attachment: hr-positions.adoc

> Add Document Content: hr-positions.adoc
> ---
>
> Key: OFBIZ-10263
> URL: https://issues.apache.org/jira/browse/OFBIZ-10263
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-positions.adoc, hr-positions.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-positions.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-positions.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10331) Improve Order

2018-04-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430497#comment-16430497
 ] 

Deepak Dixit edited comment on OFBIZ-10331 at 4/9/18 1:05 PM:
--

HI [~Dennis Balkir]

I am talking about following code snippet , you can your markup 
[here|https://validator.w3.org/]

 
{code:java}
+  
+
+  
+  
+
+  ${uiLabelMap.OrderOrderName}:
+
+
{code}
 Error: document type does not allow element "form" here; missing one of "th", 
"td" start-tag

 

 


was (Author: deepak.dixit):
HI [~Dennis Balkir]

I am talking about following code snippet , you can your markup 
[here|https://validator.w3.org]

 
{code:java}
+  
+
+  
+  
+
+  ${uiLabelMap.OrderOrderName}:
+
+
{code}
 

 

> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10331) Improve Order

2018-04-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430497#comment-16430497
 ] 

Deepak Dixit commented on OFBIZ-10331:
--

HI [~Dennis Balkir]

I am talking about following code snippet , you can your markup 
[here|https://validator.w3.org]

 
{code:java}
+  
+
+  
+  
+
+  ${uiLabelMap.OrderOrderName}:
+
+
{code}
 

 

> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10263) Add Document Content: hr-positions.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl reassigned OFBIZ-10263:
-

Assignee: Benjamin Jugl

> Add Document Content: hr-positions.adoc
> ---
>
> Key: OFBIZ-10263
> URL: https://issues.apache.org/jira/browse/OFBIZ-10263
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-positions.adoc, hr-positions.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-positions.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-positions.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10263) Add Document Content: hr-positions.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl resolved OFBIZ-10263.
---
Resolution: Done

> Add Document Content: hr-positions.adoc
> ---
>
> Key: OFBIZ-10263
> URL: https://issues.apache.org/jira/browse/OFBIZ-10263
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-positions.adoc, hr-positions.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-positions.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-positions.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10263) Add Document Content: hr-positions.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10263:
--
Attachment: hr-positions.adoc

> Add Document Content: hr-positions.adoc
> ---
>
> Key: OFBIZ-10263
> URL: https://issues.apache.org/jira/browse/OFBIZ-10263
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-positions.adoc, hr-positions.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-positions.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-positions.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10260) Add Document Content: hr-employees.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl reassigned OFBIZ-10260:
-

Assignee: Benjamin Jugl

> Add Document Content: hr-employees.adoc
> ---
>
> Key: OFBIZ-10260
> URL: https://issues.apache.org/jira/browse/OFBIZ-10260
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-employees.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc files,  write or organise the content for 
> the hr-employees.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-employees.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10268) Add Document Content: hr-training.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl resolved OFBIZ-10268.
---
Resolution: Done

> Add Document Content: hr-training.adoc
> --
>
> Key: OFBIZ-10268
> URL: https://issues.apache.org/jira/browse/OFBIZ-10268
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-training.adoc, hr-training.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-training.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-training.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10268) Add Document Content: hr-training.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10268:
--
Attachment: hr-training.adoc

> Add Document Content: hr-training.adoc
> --
>
> Key: OFBIZ-10268
> URL: https://issues.apache.org/jira/browse/OFBIZ-10268
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-training.adoc, hr-training.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-training.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-training.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10334) Standardise layout for Party

2018-04-09 Thread Dennis Balkir (JIRA)
Dennis Balkir created OFBIZ-10334:
-

 Summary: Standardise layout for Party
 Key: OFBIZ-10334
 URL: https://issues.apache.org/jira/browse/OFBIZ-10334
 Project: OFBiz
  Issue Type: Sub-task
  Components: party
Affects Versions: Trunk
Reporter: Dennis Balkir
 Attachments: OFBIZ-10242-humanres.EmploymentAppScreens.patch, 
OFBIZ-10242-party.PartyMenus.patch, OFBIZ-10242-party.ProfileScreens.patch, 
OFBIZ-10242-party.widget.partymgr.PartyContactListScreens.patch, 
OFBIZ-10242-party.widget.partymgr.PartyForms.patch, 
OFBIZ-10242-party.widget.partymgr.PartyScreens.patch, 
OFBIZ-10242_common.SecurityScreens.patch





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10331) Improve Order

2018-04-09 Thread Dennis Balkir (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430456#comment-16430456
 ] 

Dennis Balkir commented on OFBIZ-10331:
---

Hi Deepak Dixit,

can you specify what you mean? I am maybe overlooking the problem at the 
moment, but I don't really know where {{form}} is a child of {{table}}

> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10332) Standardise layout for Order

2018-04-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-10332:


Assignee: Deepak Dixit

> Standardise layout for Order
> 
>
> Key: OFBIZ-10332
> URL: https://issues.apache.org/jira/browse/OFBIZ-10332
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: 
> OFBIZ-10242_order.widget.ordermgr.OrderReturnScreens.patch, 
> OFBIZ-10242_order.widget.ordermgr.QuoteScreens.patch, 
> OFBIZ-10242_order.widget.ordermgr.QuoteWorkEffortScreens.patch, 
> OFBIZ-10242_order.widget.ordermgr.RequirementScreens.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430451#comment-16430451
 ] 

Deepak Dixit commented on OFBIZ-10221:
--

Hi [~Dennis Balkir],

Thanks for your effort, I did cursory review and all changes looks good to me 
except changes done in OFBIZ-10221_product.template.Main.patch, in this patch 
markup is not semantically correct, form used inside table incorrectly, 

form is not a valid child of table,

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10333) Improve Party

2018-04-09 Thread Dennis Balkir (JIRA)
Dennis Balkir created OFBIZ-10333:
-

 Summary: Improve Party
 Key: OFBIZ-10333
 URL: https://issues.apache.org/jira/browse/OFBIZ-10333
 Project: OFBiz
  Issue Type: Sub-task
  Components: party
Affects Versions: Trunk
Reporter: Dennis Balkir
 Attachments: OFBIZ-10221-party.template-party.AddCheckForParty.patch, 
OFBIZ-10221-party.template-party.profileBlocks.ProductStores.patch, 
OFBIZ-10221-party.template-party.profileBlocks.Visits.patch, 
OFBIZ-10221-party.template.party.EditShoppingList.patch, 
OFBIZ-10221-party.template.party.profileblocks.Attributes.patch, 
OFBIZ-10221-party.template.party.profileblocks.Contact.patch, 
OFBIZ-10221-party.template.party.profileblocks.Content.patch, 
OFBIZ-10221-party.template.party.profileblocks.ContentList.patch, 
OFBIZ-10221-party.template.party.profileblocks.Notes.patch, 
OFBIZ-10221-party.template.party.profileblocks.UserLogin.patch

All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10331) Improve Order

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10331:
--
Description: All improvements for layout and structure for the 
Order-Application  (was: All improvements for layout and structure of order)

> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10331) Improve Order

2018-04-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430440#comment-16430440
 ] 

Deepak Dixit commented on OFBIZ-10331:
--

Hi  Dennis Balkir ,

I reviewed OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, in this 
patch you used form inside table and its semantically incorrect markup, and 
form is not a valid child of table,

To fix UX pattern we can't use semantically incorrect markup.

> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10242) Standardise Layout throughout Applications

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10242:
--
Attachment: (was: 
OFBIZ-10242_order.widget.ordermgr.RequirementScreens.patch)

> Standardise Layout throughout Applications
> --
>
> Key: OFBIZ-10242
> URL: https://issues.apache.org/jira/browse/OFBIZ-10242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: OFBIZ-10242_common.SecurityScreens.patch, 
> OFBIZ-10242_content.CompDocScreens.patch, 
> OFBIZ-10242_content.ContentScreens.patch, 
> OFBIZ-10242_content.ContentSetupScreens.patch, 
> OFBIZ-10242_content.DataResourceScreens.patch, 
> OFBIZ-10242_content.DataResourceSetupScreens.patch, 
> OFBIZ-10242_content.ForumScreens2.patch, 
> OFBIZ-10242_webtools.EnitityScreens.patch, 
> OFBIZ-10242_webtools.StatsScreens.patch, 
> OFBIZ_webtools.ArtifactInfoScreen.patch
>
>
> While working on a Theme I discovered that many screens are missing 
> screenlets, or some buttons are at the wrong Position etc. .
> I propose to standardise the layout of every screen, to support easy theming. 
> Similar to the examplary patch provided below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10242) Standardise Layout throughout Applications

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10242:
--
Attachment: (was: 
OFBIZ-10242_order.widget.ordermgr.OrderReturnScreens.patch)

> Standardise Layout throughout Applications
> --
>
> Key: OFBIZ-10242
> URL: https://issues.apache.org/jira/browse/OFBIZ-10242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: OFBIZ-10242_common.SecurityScreens.patch, 
> OFBIZ-10242_content.CompDocScreens.patch, 
> OFBIZ-10242_content.ContentScreens.patch, 
> OFBIZ-10242_content.ContentSetupScreens.patch, 
> OFBIZ-10242_content.DataResourceScreens.patch, 
> OFBIZ-10242_content.DataResourceSetupScreens.patch, 
> OFBIZ-10242_content.ForumScreens2.patch, 
> OFBIZ-10242_webtools.EnitityScreens.patch, 
> OFBIZ-10242_webtools.StatsScreens.patch, 
> OFBIZ_webtools.ArtifactInfoScreen.patch
>
>
> While working on a Theme I discovered that many screens are missing 
> screenlets, or some buttons are at the wrong Position etc. .
> I propose to standardise the layout of every screen, to support easy theming. 
> Similar to the examplary patch provided below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10332) Standardise layout for Order

2018-04-09 Thread Dennis Balkir (JIRA)
Dennis Balkir created OFBIZ-10332:
-

 Summary: Standardise layout for Order
 Key: OFBIZ-10332
 URL: https://issues.apache.org/jira/browse/OFBIZ-10332
 Project: OFBiz
  Issue Type: Sub-task
  Components: order
Affects Versions: Trunk
Reporter: Dennis Balkir
 Attachments: 
OFBIZ-10242_order.widget.ordermgr.OrderReturnScreens.patch, 
OFBIZ-10242_order.widget.ordermgr.QuoteScreens.patch, 
OFBIZ-10242_order.widget.ordermgr.QuoteWorkEffortScreens.patch, 
OFBIZ-10242_order.widget.ordermgr.RequirementScreens.patch





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10242) Standardise Layout throughout Applications

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10242:
--
Attachment: (was: 
OFBIZ-10242_order.widget.ordermgr.QuoteWorkEffortScreens.patch)

> Standardise Layout throughout Applications
> --
>
> Key: OFBIZ-10242
> URL: https://issues.apache.org/jira/browse/OFBIZ-10242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: OFBIZ-10242_common.SecurityScreens.patch, 
> OFBIZ-10242_content.CompDocScreens.patch, 
> OFBIZ-10242_content.ContentScreens.patch, 
> OFBIZ-10242_content.ContentSetupScreens.patch, 
> OFBIZ-10242_content.DataResourceScreens.patch, 
> OFBIZ-10242_content.DataResourceSetupScreens.patch, 
> OFBIZ-10242_content.ForumScreens2.patch, 
> OFBIZ-10242_webtools.EnitityScreens.patch, 
> OFBIZ-10242_webtools.StatsScreens.patch, 
> OFBIZ_webtools.ArtifactInfoScreen.patch
>
>
> While working on a Theme I discovered that many screens are missing 
> screenlets, or some buttons are at the wrong Position etc. .
> I propose to standardise the layout of every screen, to support easy theming. 
> Similar to the examplary patch provided below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10242) Standardise Layout throughout Applications

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10242:
--
Attachment: (was: OFBIZ-10242_order.widget.ordermgr.QuoteScreens.patch)

> Standardise Layout throughout Applications
> --
>
> Key: OFBIZ-10242
> URL: https://issues.apache.org/jira/browse/OFBIZ-10242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: OFBIZ-10242_common.SecurityScreens.patch, 
> OFBIZ-10242_content.CompDocScreens.patch, 
> OFBIZ-10242_content.ContentScreens.patch, 
> OFBIZ-10242_content.ContentSetupScreens.patch, 
> OFBIZ-10242_content.DataResourceScreens.patch, 
> OFBIZ-10242_content.DataResourceSetupScreens.patch, 
> OFBIZ-10242_content.ForumScreens2.patch, 
> OFBIZ-10242_webtools.EnitityScreens.patch, 
> OFBIZ-10242_webtools.StatsScreens.patch, 
> OFBIZ_webtools.ArtifactInfoScreen.patch
>
>
> While working on a Theme I discovered that many screens are missing 
> screenlets, or some buttons are at the wrong Position etc. .
> I propose to standardise the layout of every screen, to support easy theming. 
> Similar to the examplary patch provided below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430426#comment-16430426
 ] 

Dennis Balkir edited comment on OFBIZ-10221 at 4/9/18 12:18 PM:


Hello,

I thought it would be easier to review if the different applications were 
separated.


was (Author: dennis balkir):
Hello,

I provided new patches, which should fix the ordermanager issues.

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: 
OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: 
OFBiz-10221_order.template.order.OrderPaymentInfo.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: OFBIZ-10221_order.template.order.OrderList.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: OFBiz-10221_order.template.order.OrderInfo.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: 
OFBiz-10221_order.template.order.OrderContactInfo.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: OFBiz-10221_order.template.order.OrderItems.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: OFBIZ-10221_order.template.order.OrderStats.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10331) Improve Order

2018-04-09 Thread Dennis Balkir (JIRA)
Dennis Balkir created OFBIZ-10331:
-

 Summary: Improve Order
 Key: OFBIZ-10331
 URL: https://issues.apache.org/jira/browse/OFBIZ-10331
 Project: OFBiz
  Issue Type: Sub-task
  Components: order
Affects Versions: Trunk
Reporter: Dennis Balkir
 Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
OFBIZ-10221_order.template.entry.CheckInits.patch, 
OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
OFBIZ-10221_order.template.order.FindOrders.patch, 
OFBIZ-10221_order.template.order.OrderList.patch, 
OFBIZ-10221_order.template.order.OrderStats.patch, 
OFBiz-10221_order.template.order.OrderContactInfo.patch, 
OFBiz-10221_order.template.order.OrderInfo.patch, 
OFBiz-10221_order.template.order.OrderItems.patch, 
OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
OFBiz-10221_order.template.order.OrderShippingInfo.patch

All improvements for layout and structure of order



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: 
OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: 
OFBIZ-10221_order.template.entry.OrderAgreements.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: OFBIZ-10221_order.template.order.FindOrders.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: OFBIZ-10221_order.template.entry.ChooseCatalog2.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: 
OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: OFBIZ-10221_order.template.entry.OrderShortcuts.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: 
OFBiz-10221_order.template.order.OrderShippingInfo.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10268) Add Document Content: hr-training.adoc

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl reassigned OFBIZ-10268:
-

Assignee: Benjamin Jugl

> Add Document Content: hr-training.adoc
> --
>
> Key: OFBIZ-10268
> URL: https://issues.apache.org/jira/browse/OFBIZ-10268
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: hr-training.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the hr-training.adoc file.
> A copy of the existing file will be attached. Please write document content 
> for hr-training.adoc by updating the template then re-attach the updated 
> document to this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: 
OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10221:
--
Attachment: (was: 
OFBIZ-10221_common-theme.template.includes.GenericLink.patch)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10242) Standardise Layout throughout Applications

2018-04-09 Thread Dennis Balkir (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430428#comment-16430428
 ] 

Dennis Balkir commented on OFBIZ-10242:
---

Hello,

I added some patches, that should fix the ordermanager.

> Standardise Layout throughout Applications
> --
>
> Key: OFBIZ-10242
> URL: https://issues.apache.org/jira/browse/OFBIZ-10242
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Attachments: OFBIZ-10242_common.SecurityScreens.patch, 
> OFBIZ-10242_content.CompDocScreens.patch, 
> OFBIZ-10242_content.ContentScreens.patch, 
> OFBIZ-10242_content.ContentSetupScreens.patch, 
> OFBIZ-10242_content.DataResourceScreens.patch, 
> OFBIZ-10242_content.DataResourceSetupScreens.patch, 
> OFBIZ-10242_content.ForumScreens2.patch, 
> OFBIZ-10242_order.widget.ordermgr.OrderReturnScreens.patch, 
> OFBIZ-10242_order.widget.ordermgr.QuoteScreens.patch, 
> OFBIZ-10242_order.widget.ordermgr.QuoteWorkEffortScreens.patch, 
> OFBIZ-10242_order.widget.ordermgr.RequirementScreens.patch, 
> OFBIZ-10242_webtools.EnitityScreens.patch, 
> OFBIZ-10242_webtools.StatsScreens.patch, 
> OFBIZ_webtools.ArtifactInfoScreen.patch
>
>
> While working on a Theme I discovered that many screens are missing 
> screenlets, or some buttons are at the wrong Position etc. .
> I propose to standardise the layout of every screen, to support easy theming. 
> Similar to the examplary patch provided below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430426#comment-16430426
 ] 

Dennis Balkir commented on OFBIZ-10221:
---

Hello,

I provided new patches, which should fix the ordermanager issues.

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10330) ControlEventListener - Change Log-Level

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-10330:
--
Attachment: OFBIZ-10330_ControlEventListener_ChangeLogLevel.patch

> ControlEventListener - Change Log-Level
> ---
>
> Key: OFBIZ-10330
> URL: https://issues.apache.org/jira/browse/OFBIZ-10330
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: OFBIZ-10330_ControlEventListener_ChangeLogLevel.patch
>
>
> the Log-Level of the Message "Could not find visit value object in 
> session." currently is "warning". It should be set to info.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10330) ControlEventListener - Change Log-Level

2018-04-09 Thread Benjamin Jugl (JIRA)
Benjamin Jugl created OFBIZ-10330:
-

 Summary: ControlEventListener - Change Log-Level
 Key: OFBIZ-10330
 URL: https://issues.apache.org/jira/browse/OFBIZ-10330
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Benjamin Jugl
Assignee: Benjamin Jugl


the Log-Level of the Message "Could not find visit value object in 
session." currently is "warning". It should be set to info.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2018-04-09 Thread Benjamin Jugl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430349#comment-16430349
 ] 

Benjamin Jugl edited comment on OFBIZ-4361 at 4/9/18 10:29 AM:
---

I just reviewed the patch and did some changes myself. I like the approach, but 
I think that we might consider using hashed tokens in place of the 
customerRequests, because the plain text URL might really be a security issue. 
(If you knew a username, you could generate a custRequest by sending the email 
and than have a script run through all custRequestIds...)

I renamed the requests as I found it really hard to read all the different 
"steps" of the process. And I changed the Error Messages. The programm will no 
longer give hints about valid or invalid usernames, as it was discussed in this 
issue.


was (Author: bjugl):
I just reviewed the patch and did some changes myself. I like the approach, but 
I think that we might consider creating tokens in place of the 
customerRequests, because the plain text URL might really be a security issue. 
(If you knew a username, you could generate a custRequest by sending the email 
and than have a script run through all custRequestIds...)

I renamed the requests as I found it really hard to read all the different 
"steps" of the process. And I changed the Error Messages. The programm will no 
longer give hints about valid or invalid usernames, as it was discussed in this 
issue.

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 11.04, Trunk
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Michael Brohl
>Priority: Major
>  Labels: security
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_ReworkPasswordLogic.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2018-04-09 Thread Benjamin Jugl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430349#comment-16430349
 ] 

Benjamin Jugl commented on OFBIZ-4361:
--

I just reviewed the patch and did some changes myself. I like the approach, but 
I think that we might consider creating tokens in place of the 
customerRequests, because the plain text URL might really be a security issue. 
(If you knew a username, you could generate a custRequest by sending the email 
and than have a script run through all custRequestIds...)

I renamed the requests as I found it really hard to read all the different 
"steps" of the process. And I changed the Error Messages. The programm will no 
longer give hints about valid or invalid usernames, as it was discussed in this 
issue.

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 11.04, Trunk
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Michael Brohl
>Priority: Major
>  Labels: security
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_ReworkPasswordLogic.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2018-04-09 Thread Benjamin Jugl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-4361:
-
Attachment: OFBIZ-4361_ReworkPasswordLogic.patch

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 11.04, Trunk
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Michael Brohl
>Priority: Major
>  Labels: security
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_ReworkPasswordLogic.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)