[jira] [Assigned] (OFBIZ-10256) Add Document Content: hr-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga reassigned OFBIZ-10256: --- Assignee: Sharan Foga (was: Olivier Heintz) > Add Document Content: hr-intro.adoc > --- > > Key: OFBIZ-10256 > URL: https://issues.apache.org/jira/browse/OFBIZ-10256 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Attachments: hr-intro.adoc > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-intro.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-intro.adoc by updating the template then re-attach the updated > document to this issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10256) Add Document Content: hr-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464845#comment-16464845 ] Sharan Foga commented on OFBIZ-10256: - Hi [~holivier] I'm re-assigning this to me as I have some updates that I'd like to commit on this section. Let me know if you'd like to integrate any of the changes you are working on. Thanks > Add Document Content: hr-intro.adoc > --- > > Key: OFBIZ-10256 > URL: https://issues.apache.org/jira/browse/OFBIZ-10256 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Olivier Heintz >Priority: Minor > Attachments: hr-intro.adoc > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-intro.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-intro.adoc by updating the template then re-attach the updated > document to this issue. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10306) Create an asciidoc style guide for the OFBiz project
[ https://issues.apache.org/jira/browse/OFBIZ-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464806#comment-16464806 ] Sharan Foga commented on OFBIZ-10306: - Hi [~mbrohl] Great work. I've committed some minor changes to it at r1830987 > Create an asciidoc style guide for the OFBiz project > > > Key: OFBIZ-10306 > URL: https://issues.apache.org/jira/browse/OFBIZ-10306 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Labels: asciidoc, documentation > Attachments: OFBIZ-10306_Create_styleguide.patch > > > Create a guideline/ style guide as discussed in the mailing list (see > [https://s.apache.org/qJoS]). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10390) New documentation for EntitySync
[ https://issues.apache.org/jira/browse/OFBIZ-10390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464767#comment-16464767 ] Jacques Le Roux commented on OFBIZ-10390: - First pass committed at r1830972 > New documentation for EntitySync > > > Key: OFBIZ-10390 > URL: https://issues.apache.org/jira/browse/OFBIZ-10390 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The [current EntitySync documentation in > wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Sync+Setup+Notes+and+Example] > is POS oriented so somehow deprecated. > I have recently worked on a project with EntitySync and collected as much > possible information. I also got David E. Jones's agreement to reuse the part > on EntitySync in his 2006 "Apache OFBiz Advanced Framework - Training Video > Transcription" document. > So I'll create an Asciidoc file: > framework/entityext/src/doc/asciidoc/EntitySync-manual.adoc and will fill it > with all the available information I have. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10348) Refactoring Variable Scope for org.apache.ofbiz.entity
[ https://issues.apache.org/jira/browse/OFBIZ-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464757#comment-16464757 ] Taher Alkhateeb commented on OFBIZ-10348: - Too large, and pattern-driven instead of refactoring-driven as stated in other related JIRAs. I highly recommend breaking it down with more proper and slow study of the code. These kinds of commits can have massive repercussions on the code. There is a lot of runtime stuff happening in OFBiz that such sweeping changes might be very dangerous. > Refactoring Variable Scope for org.apache.ofbiz.entity > -- > > Key: OFBIZ-10348 > URL: https://issues.apache.org/jira/browse/OFBIZ-10348 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10348_1.patch, OFBIZ-10348_2.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10347) Refactoring Variable Scope for org.apache.ofbiz.datafile
[ https://issues.apache.org/jira/browse/OFBIZ-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464756#comment-16464756 ] Taher Alkhateeb commented on OFBIZ-10347: - Like in other JIRAs, this patch is too mixed with too many different unrelated files. It's also not clear what you're trying to accomplish. There is no description in the Jira or anywhere else to understand what you're trying to achieve. > Refactoring Variable Scope for org.apache.ofbiz.datafile > > > Key: OFBIZ-10347 > URL: https://issues.apache.org/jira/browse/OFBIZ-10347 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10347.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10346) Refactoring Variable Scope for org.apache.ofbiz.common
[ https://issues.apache.org/jira/browse/OFBIZ-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464755#comment-16464755 ] Taher Alkhateeb commented on OFBIZ-10346: - This patch is too mixed and doing too many different things. I suggest redesigning. It's almost impossible to keep track of everything done. > Refactoring Variable Scope for org.apache.ofbiz.common > -- > > Key: OFBIZ-10346 > URL: https://issues.apache.org/jira/browse/OFBIZ-10346 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10346.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10345) Refactoring Variable Scope for org.apache.ofbiz.catalina.container
[ https://issues.apache.org/jira/browse/OFBIZ-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464753#comment-16464753 ] Taher Alkhateeb commented on OFBIZ-10345: - Why did you make the references static? > Refactoring Variable Scope for org.apache.ofbiz.catalina.container > -- > > Key: OFBIZ-10345 > URL: https://issues.apache.org/jira/browse/OFBIZ-10345 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10345.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10344) Refactoring Variable Scope for org.apache.ofbiz.base package
[ https://issues.apache.org/jira/browse/OFBIZ-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464752#comment-16464752 ] Taher Alkhateeb commented on OFBIZ-10344: - Oh and one more thing, some description of what you've done in the Jira would be helpful > Refactoring Variable Scope for org.apache.ofbiz.base package > > > Key: OFBIZ-10344 > URL: https://issues.apache.org/jira/browse/OFBIZ-10344 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10344.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10344) Refactoring Variable Scope for org.apache.ofbiz.base package
[ https://issues.apache.org/jira/browse/OFBIZ-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464751#comment-16464751 ] Taher Alkhateeb commented on OFBIZ-10344: - On a first view of this commit it looks well thought out, thank you for your work. The formatting needs some work though, the lines are too long. It is a common convention for java streams to be broken down to lines (usually at the dot operator). I also think some places where streams are used, the code looks worse not better. Streams are supposed to make the code easier to read, not harder. So it's a combination of proper formatting and making sure you use the right tool at the right place. Also, some care needs to be taken into picking variable names. Using cryptic and short names makes things worse not better. This is my feedback insofar, well done on the effort. > Refactoring Variable Scope for org.apache.ofbiz.base package > > > Key: OFBIZ-10344 > URL: https://issues.apache.org/jira/browse/OFBIZ-10344 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10344.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10220) Introduce support for condition-service for entity eca's as well
[ https://issues.apache.org/jira/browse/OFBIZ-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464743#comment-16464743 ] Jacques Le Roux commented on OFBIZ-10220: - Thanks Deepak > Introduce support for condition-service for entity eca's as well > > > Key: OFBIZ-10220 > URL: https://issues.apache.org/jira/browse/OFBIZ-10220 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Arun Patidar >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10220.patch > > > Currently, condition-service tag works for service eca's only, extend this > support for entity eca's as well. > Here is the discussion on dev list for reference: > http://markmail.org/message/roqhaqsdbcycrwj2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10220) Introduce support for condition-service for entity eca's as well
[ https://issues.apache.org/jira/browse/OFBIZ-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10220. Resolution: Fixed > Introduce support for condition-service for entity eca's as well > > > Key: OFBIZ-10220 > URL: https://issues.apache.org/jira/browse/OFBIZ-10220 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Arun Patidar >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10220.patch > > > Currently, condition-service tag works for service eca's only, extend this > support for entity eca's as well. > Here is the discussion on dev list for reference: > http://markmail.org/message/roqhaqsdbcycrwj2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10220) Introduce support for condition-service for entity eca's as well
[ https://issues.apache.org/jira/browse/OFBIZ-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464733#comment-16464733 ] Deepak Dixit commented on OFBIZ-10220: -- Added condition service in entity-eca.xsd in ofbiz framewrok trunk at r#1830960 and ofbiz-site at r#1830962 > Introduce support for condition-service for entity eca's as well > > > Key: OFBIZ-10220 > URL: https://issues.apache.org/jira/browse/OFBIZ-10220 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Arun Patidar >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10220.patch > > > Currently, condition-service tag works for service eca's only, extend this > support for entity eca's as well. > Here is the discussion on dev list for reference: > http://markmail.org/message/roqhaqsdbcycrwj2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
