[jira] [Assigned] (OFBIZ-5672) UOM conversion for supplier and sale order
[ https://issues.apache.org/jira/browse/OFBIZ-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-5672: -- Assignee: (was: Jacques Le Roux) > UOM conversion for supplier and sale order > -- > > Key: OFBIZ-5672 > URL: https://issues.apache.org/jira/browse/OFBIZ-5672 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Release Branch 13.07, Trunk > Environment: OOTB >Reporter: Julien NICOLAS >Priority: Minor > Labels: features > Attachments: OFBIZ-5672-UOM-conversion-supplier-and-sale-order.13.07 > > Original Estimate: 120h > Remaining Estimate: 120h > > It's possible to define different UomQuantity in measures tab, supplier tab > or price tab of a product but OFBiz don't manage it in stock. > The improvement must manage it using UomConversion table for standard > conversions. > When a new order (supplier or sale) is created, the user can choose the > UomQuantity if more than one UomQuantity is available. > By default if only one conversion is defined in UomConversion table, OFBiz > will use it for both conversion way. > However, it's possible to define different rules for each ways. > Add new concept in UomConversion rules : rouding method and number of digit > after decimal point. > To be more flexible, add new fields in price and supplier product tab. > - Uom conversion factor > - Rounding method > - Number of digit after decimal point > If those fields are empty, OFBiz will use the standard UomConversion table. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-5672) UOM conversion for supplier and sale order
[ https://issues.apache.org/jira/browse/OFBIZ-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721057#comment-16721057 ] Michael Brohl commented on OFBIZ-5672: -- To get this into the codebase, it has to be reworked for the current trunk. [~julien.nicolas], would you work on it to make it testable for trunk or should we close this issue? > UOM conversion for supplier and sale order > -- > > Key: OFBIZ-5672 > URL: https://issues.apache.org/jira/browse/OFBIZ-5672 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Release Branch 13.07, Trunk > Environment: OOTB >Reporter: Julien NICOLAS >Priority: Minor > Labels: features > Attachments: OFBIZ-5672-UOM-conversion-supplier-and-sale-order.13.07 > > Original Estimate: 120h > Remaining Estimate: 120h > > It's possible to define different UomQuantity in measures tab, supplier tab > or price tab of a product but OFBiz don't manage it in stock. > The improvement must manage it using UomConversion table for standard > conversions. > When a new order (supplier or sale) is created, the user can choose the > UomQuantity if more than one UomQuantity is available. > By default if only one conversion is defined in UomConversion table, OFBiz > will use it for both conversion way. > However, it's possible to define different rules for each ways. > Add new concept in UomConversion rules : rouding method and number of digit > after decimal point. > To be more flexible, add new fields in price and supplier product tab. > - Uom conversion factor > - Rounding method > - Number of digit after decimal point > If those fields are empty, OFBiz will use the standard UomConversion table. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-6032) Add a warning on UI about the "X quantity of Product" condition in Promo Rules
[ https://issues.apache.org/jira/browse/OFBIZ-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6032. -- Resolution: Implemented Fix Version/s: (was: 17.12.01) Upcoming Branch Done at revision: 1848916 > Add a warning on UI about the "X quantity of Product" condition in Promo Rules > -- > > Key: OFBIZ-6032 > URL: https://issues.apache.org/jira/browse/OFBIZ-6032 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > I will add a sentence on the UI to explain what the current implentation > really does: it always and only uses the "Is Greater Than" operator. With > this information in the UI people should not be confused. With this operator > you can easily do a "Is Greater Than or Equal to" operator by changing the > "condition value". For instance if you want a break at 10 put 9 in the > condition value, etc. > I believe it's usable as is because the other operators don't make much sense > (if any) with this rule condition. IMO, Only the "Is Greater Than" and Is > Greater Than or Equal to" operators make sense with "X Quantities of Product". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721070#comment-16721070 ] Michael Brohl commented on OFBIZ-10707: --- I'd propose to handle this by configuration, not hardcoded in the ftl. It could be either properties or maybe using https://docs.oracle.com/javase/8/docs/api/java/awt/ComponentOrientation.html > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10708) visual-editor not workign on ecommerce
Deepak Dixit created OFBIZ-10708: Summary: visual-editor not workign on ecommerce Key: OFBIZ-10708 URL: https://issues.apache.org/jira/browse/OFBIZ-10708 Project: OFBiz Issue Type: Bug Affects Versions: Trunk, Release Branch 17.12 Reporter: Deepak Dixit Assignee: Deepak Dixit We have a visual editor on Add Forum message screen, https://demo-trunk.ofbiz.apache.org/ecommerce/control/AddForumThread?forumId=ASK We are getting following error message TypeError: element.elrte is not a function[Learn More] This is due to incorrect loading sequence of plugin js library. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10708) visual-editor not workign on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721087#comment-16721087 ] Aditya Sharma commented on OFBIZ-10708: --- At a cursory view, I noticed the jQuery file being loaded twice. I think the jQuery is being initialised twice thus eltre might not be available in the prototype of reinitialised jQuery object. > visual-editor not workign on ecommerce > -- > > Key: OFBIZ-10708 > URL: https://issues.apache.org/jira/browse/OFBIZ-10708 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > > We have a visual editor on Add Forum message screen, > https://demo-trunk.ofbiz.apache.org/ecommerce/control/AddForumThread?forumId=ASK > We are getting following error message > TypeError: element.elrte is not a function[Learn More] > This is due to incorrect loading sequence of plugin js library. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10708) visual-editor not working on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10708: -- Summary: visual-editor not working on ecommerce (was: visual-editor not workign on ecommerce) > visual-editor not working on ecommerce > -- > > Key: OFBIZ-10708 > URL: https://issues.apache.org/jira/browse/OFBIZ-10708 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > > We have a visual editor on Add Forum message screen, > https://demo-trunk.ofbiz.apache.org/ecommerce/control/AddForumThread?forumId=ASK > We are getting following error message > TypeError: element.elrte is not a function[Learn More] > This is due to incorrect loading sequence of plugin js library. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10708) visual-editor not working on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-10708: - Attachment: OFBIZ-10708.patch > visual-editor not working on ecommerce > -- > > Key: OFBIZ-10708 > URL: https://issues.apache.org/jira/browse/OFBIZ-10708 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10708.patch > > > We have a visual editor on Add Forum message screen, > https://demo-trunk.ofbiz.apache.org/ecommerce/control/AddForumThread?forumId=ASK > We are getting following error message > TypeError: element.elrte is not a function[Learn More] > This is due to incorrect loading sequence of plugin js library. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10708) visual-editor not working on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721100#comment-16721100 ] Deepak Dixit commented on OFBIZ-10708: -- Here is the Patch for the issue, removed duplicate js/css entry from e-commerce main-decorator and popup decorator. Added additional js/css file in e-commerce theme.xml file. > visual-editor not working on ecommerce > -- > > Key: OFBIZ-10708 > URL: https://issues.apache.org/jira/browse/OFBIZ-10708 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10708.patch > > > We have a visual editor on Add Forum message screen, > https://demo-trunk.ofbiz.apache.org/ecommerce/control/AddForumThread?forumId=ASK > We are getting following error message > TypeError: element.elrte is not a function[Learn More] > This is due to incorrect loading sequence of plugin js library. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"
[
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721193#comment-16721193
]
Jacques Le Roux commented on OFBIZ-4361:
Dennis, Michael,
Just a quick preliminary 1st pass, there is a lot to review in this patch!
You use a token different than a JWT. Your token is used in emails with a
verification URL. Did you consider to use a JWT as it exists in OFBiz?
It's one of the case where a JWT fits. Referring to
[https://github.com/dwyl/learn-json-web-tokens]
I read at the section:
{quote}"Use-cases for a JWT token in a url are:"
{quote}
that it fits for URL sents in an email. I can't say that there are security
issues with your solution and the JWT way is not much used in OFBiz yet. But
I'd advocate for an unique way to use validation tokens in OFBiz, and the JWT
is a well established standard.
With JWT the idea is [to securely store
tokens|https://stormpath.com/blog/where-to-store-your-jwts-cookies-vs-html5-web-storage].
We already discussed that. I believe a DB is not the best place (and we see
that everyday, even all big companies have DBs compromised) . Disclaimer: I did
only a cursory review (actually did more read Dennis specifications) and I may
miss something. Are the features not possible w/o storing in DB? It seems to me
that a JWT token would fit. Of course a JWT itself does not guarantee security,
it all depends on the code around...
In any case please remember to remove the comments like
{quote}// MOD dbalkir
{quote}
from the patch.
This said it looks like a great step in the right direction, thanks for your
work guys!
> Any ecommerce user has the ability to reset anothers password (including
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Michael Brohl
>Priority: Major
> Labels: security
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch,
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch,
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to
> reset another users password, including "admin" without permission. By
> simply entering "admin" and clicking "Email Password", the following is
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password. It is also
> possible to generate a dictionary attack against ofbiz because there is no
> capta code required. This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name
> is optionally in the format of an email address, and maybe require a capta
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was
> generated via an ecommerce transaction.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-6243) Have a readme in every component
[ https://issues.apache.org/jira/browse/OFBIZ-6243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-6243: -- Assignee: (was: Jacques Le Roux) > Have a readme in every component > > > Key: OFBIZ-6243 > URL: https://issues.apache.org/jira/browse/OFBIZ-6243 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Fix For: 17.12.01 > > > A readme should be the first starting point of each component for developers > have references to the placeholder in the wiki, in jira and in svn/viewvc. > (!) In the course of the asciidoc documentation effort, the existing > README.md files should be reworked: > * (re-)moved to src/docs/asciidoc/[componentname].adoc > * move contents from the wiki to the [componentname].adoc or includes -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10708) visual-editor not working on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721222#comment-16721222 ] Deepak Dixit commented on OFBIZ-10708: -- Thanks Aditya for details, This has been fixed at ofbiz plugins trunk at r#1848921 R17.12 plugins atr#1848922 > visual-editor not working on ecommerce > -- > > Key: OFBIZ-10708 > URL: https://issues.apache.org/jira/browse/OFBIZ-10708 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10708.patch > > > We have a visual editor on Add Forum message screen, > https://demo-trunk.ofbiz.apache.org/ecommerce/control/AddForumThread?forumId=ASK > We are getting following error message > TypeError: element.elrte is not a function[Learn More] > This is due to incorrect loading sequence of plugin js library. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10709) LoginWorker.autoLoginCheck performance improvement
Benjamin Jugl created OFBIZ-10709: - Summary: LoginWorker.autoLoginCheck performance improvement Key: OFBIZ-10709 URL: https://issues.apache.org/jira/browse/OFBIZ-10709 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Benjamin Jugl Assignee: Benjamin Jugl Fix For: Trunk LoginWorker.autoLoginCheck does not check if the attribute "autoUserLogin" is not already filled and executes even if it is not needed. A check on the attribute beforehand can improve performance significantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10709) LoginWorker.autoLoginCheck performance improvement
[ https://issues.apache.org/jira/browse/OFBIZ-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10709: -- Attachment: OFBIZ-10709_LoginWorker.java.patch > LoginWorker.autoLoginCheck performance improvement > -- > > Key: OFBIZ-10709 > URL: https://issues.apache.org/jira/browse/OFBIZ-10709 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10709_LoginWorker.java.patch > > > LoginWorker.autoLoginCheck does not check if the attribute "autoUserLogin" is > not already filled and executes even if it is not needed. A check on the > attribute beforehand can improve performance significantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-3844) Splitting CommonRate and CommonProductRating
[ https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3844. -- Resolution: Implemented Done in trunk at revision: 1848923 > Splitting CommonRate and CommonProductRating > > > Key: OFBIZ-3844 > URL: https://issues.apache.org/jira/browse/OFBIZ-3844 > Project: OFBiz > Issue Type: Improvement > Components: framework, product >Affects Versions: Release 09.04 > Environment: irrelevant, only XML and FTL changes >Reporter: Carsten Schinzer >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: 0001-OFBIZ-3844_commonRate_and_commonRating.patch, > 0002-OFBIZ-3844_commonRate_and_commonRating.patch, OFBIZ-3844_Splitting > CommonRate and CommonProductRating_part1.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > The CommonRate label is currently not used coherently throughout the > application stack. The existing translations suggest that the commonly > understood meaning of CommonRate is a rate as a tariff or day rate. However, > in the product management GUI, the CommonRate label is used to demark the > section where ProductRating setting are made. > The provided fix splits CommonRate into two labels, CommonRate and > CommonProductRating. Also, the application/product/webapp/ form definition > now references the CommonProductRating label. > Unfortunately, the patches have to be provided per affected file, i.e. two > patches make this imporvement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721239#comment-16721239 ] Jacques Le Roux commented on OFBIZ-10707: - ComponentOrientation seems interesting but maybe a bit too much here? > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10709) LoginWorker.autoLoginCheck performance improvement
[ https://issues.apache.org/jira/browse/OFBIZ-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10709: --- Assignee: Jacques Le Roux (was: Benjamin Jugl) > LoginWorker.autoLoginCheck performance improvement > -- > > Key: OFBIZ-10709 > URL: https://issues.apache.org/jira/browse/OFBIZ-10709 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10709_LoginWorker.java.patch > > > LoginWorker.autoLoginCheck does not check if the attribute "autoUserLogin" is > not already filled and executes even if it is not needed. A check on the > attribute beforehand can improve performance significantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[
https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721245#comment-16721245
]
Michael Brohl commented on OFBIZ-10707:
---
Why do you think that? It provides a simple method to get the orientation from
the Locale...
{code:java}
ComponentOrientation.getOrientation(Locale locale){code}
> ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
>
>
> Key: OFBIZ-10707
> URL: https://issues.apache.org/jira/browse/OFBIZ-10707
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10707_ListLocales.ftl.patch
>
>
> Because langAttr can be empty on some occations, the check of available
> languages can result in a SringINdexOutOfBounds Exception
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces
[ https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721255#comment-16721255 ] Benjamin Jugl commented on OFBIZ-10461: --- My patch already removes all nbsp and linebreaks. I did not touch the css, though. > Texts of checkboxes sometimes have whitespaces > -- > > Key: OFBIZ-10461 > URL: https://issues.apache.org/jira/browse/OFBIZ-10461 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Benjamin Jugl >Priority: Minor > Attachments: OFBIZ-10461_RemoveBlanksBetweenCheckboxesAndLabels.patch > > > On some pages, when there are checkboxes, the text after the checkbox has a > rendered whitespace in front of it. > A good example for this can be seen right here: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist] > The first checkboxes do not have this rendered whitespace, the lines after > that do have it. > This issue can be fixed simply through removing the whitespaces inside the > .ftl files. > > After that there an added styling should create a new gap between the > checkbox and the following text, but this time all the gaps would have the > same distance. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
Benjamin Jugl created OFBIZ-10710: - Summary: Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType Key: OFBIZ-10710 URL: https://issues.apache.org/jira/browse/OFBIZ-10710 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Benjamin Jugl Assignee: Benjamin Jugl Fix For: Trunk Avoid logging this warning (for example on freemarker.ext.beans.StringModel source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10710: -- Attachment: OFBIZ-10710_ObjectType.java.patch > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721257#comment-16721257 ] Benjamin Jugl commented on OFBIZ-10710: --- Thank you, @Martin Becker, for this patch. > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces
[ https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721254#comment-16721254 ] Deepak Dixit commented on OFBIZ-10461: -- We can remove the nbsp from the code as this can be easily achievable by CSS. If no one disagrees I'll do the nbsp related improvement. For the line break thing, first we can check something at freemarker level if nothing found then we can go with the mass update > Texts of checkboxes sometimes have whitespaces > -- > > Key: OFBIZ-10461 > URL: https://issues.apache.org/jira/browse/OFBIZ-10461 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Benjamin Jugl >Priority: Minor > Attachments: OFBIZ-10461_RemoveBlanksBetweenCheckboxesAndLabels.patch > > > On some pages, when there are checkboxes, the text after the checkbox has a > rendered whitespace in front of it. > A good example for this can be seen right here: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist] > The first checkboxes do not have this rendered whitespace, the lines after > that do have it. > This issue can be fixed simply through removing the whitespaces inside the > .ftl files. > > After that there an added styling should create a new gap between the > checkbox and the following text, but this time all the gaps would have the > same distance. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10708) visual-editor not working on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10708. Resolution: Fixed Fix Version/s: 17.12.01 No need to backport to R16. It's working fine on R16 > visual-editor not working on ecommerce > -- > > Key: OFBIZ-10708 > URL: https://issues.apache.org/jira/browse/OFBIZ-10708 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10708.patch > > > We have a visual editor on Add Forum message screen, > https://demo-trunk.ofbiz.apache.org/ecommerce/control/AddForumThread?forumId=ASK > We are getting following error message > TypeError: element.elrte is not a function[Learn More] > This is due to incorrect loading sequence of plugin js library. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721286#comment-16721286
]
Deepak Dixit commented on OFBIZ-10688:
--
While calling createTextContent we are passing some additional parameter
(contentIdFrom, mapKey etc), that is used by createContent SECA rule.
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721263#comment-16721263
]
Deepak Dixit commented on OFBIZ-10688:
--
Hi [~jacques.le.roux],
This is not related to space thing, its due to jquery library initialize twice.
This has been fixed at OFBIZ-10708
The main issue is in createArticleContent service, I am trying to understand
why system throwing service validation exception in case of group service
validation (createTextContent).
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10709) LoginWorker.autoLoginCheck performance improvement
[ https://issues.apache.org/jira/browse/OFBIZ-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10709. --- Resolution: Implemented Fix Version/s: (was: Trunk) Upcoming Branch Thanks Benjamin, Your patch is in trunk at revision: 1848926 > LoginWorker.autoLoginCheck performance improvement > -- > > Key: OFBIZ-10709 > URL: https://issues.apache.org/jira/browse/OFBIZ-10709 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10709_LoginWorker.java.patch > > > LoginWorker.autoLoginCheck does not check if the attribute "autoUserLogin" is > not already filled and executes even if it is not needed. A check on the > attribute beforehand can improve performance significantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721298#comment-16721298 ] Jacques Le Roux commented on OFBIZ-10707: - Yes indeed, sounds good. > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[
https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721341#comment-16721341
]
Jacques Le Roux commented on OFBIZ-10710:
-
There is a "bug" in the patch: second part is useless and wrong (duplicated
{{if (Debug.infoOn())}}). Else it's OK with me.
> Avoid logging warning message from ObjectType.java while using
> sourceType.toString() for getting String targetType
> --
>
> Key: OFBIZ-10710
> URL: https://issues.apache.org/jira/browse/OFBIZ-10710
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10710_ObjectType.java.patch
>
>
> Avoid logging this warning (for example on freemarker.ext.beans.StringModel
> source type at screen rendering), change to info adviseable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10711) FindGeneric page broken
Deepak Dixit created OFBIZ-10711: Summary: FindGeneric page broken Key: OFBIZ-10711 URL: https://issues.apache.org/jira/browse/OFBIZ-10711 Project: OFBiz Issue Type: Bug Reporter: Deepak Dixit FindGeneic page broken, Error getting the next result (ResultSet not open. Operation 'next' not permitted. Verify that autocommit is off.) https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721356#comment-16721356 ] Deepak Dixit commented on OFBIZ-10711: -- Getting same error on local as well as on demo instance. It might be related to derby dependencies update not sure. > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Priority: Major > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-10711: - Attachment: Screenshot 2018-12-14 at 6.07.09 PM.png > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Priority: Major > Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png > > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10710: -- Attachment: (was: OFBIZ-10710_ObjectType.java.patch) > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10710: -- Attachment: OFBIZ-10710_ObjectType.java.patch > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721368#comment-16721368 ] Benjamin Jugl commented on OFBIZ-10710: --- Corrected. Thank you. > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10712) Inconsistent behaviour of ServiceDispatcher.checkAuth
Deepak Dixit created OFBIZ-10712: Summary: Inconsistent behaviour of ServiceDispatcher.checkAuth Key: OFBIZ-10712 URL: https://issues.apache.org/jira/browse/OFBIZ-10712 Project: OFBiz Issue Type: Bug Reporter: Deepak Dixit We have checkAuth method in service dispatcher class, this method performs multiple auth related check. if all checks passed it call the modelService.makeValid method to prepare service context (line#960) but this code executed only when service definition has a permission service call. If service does not have any permission service call then it does not call the modelService.makeValid and this may cause the service validation issue unknown parameter found. Ideally modelService.makeValid should call irrespective to permission service check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721390#comment-16721390
]
Deepak Dixit commented on OFBIZ-10688:
--
Found the root cause of this behavior (OFBIZ-10712),
if we call a service that has permission service in service definition, so it
prepares context using the makeValid method, and if we do not have a permission
service then service dispatcher pass all the parameter while calling service
and it's causing the "unknown parameter found exception"
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721401#comment-16721401 ] Jacques Le Roux commented on OFBIZ-10711: - I confirm it's due to r1848673. I'll try to see why before reverting... > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Priority: Major > Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png > > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721400#comment-16721400 ] Jacques Le Roux commented on OFBIZ-10711: - It could be due to recent massive changes. Svn updating to r1848514 works, I tried to revert changes in r1848673 but got compile errors (weird and don't know why yet). I'll check that... > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Priority: Major > Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png > > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721486#comment-16721486 ] Jacques Le Roux commented on OFBIZ-10711: - OK found it, I'll do some tests and maybe changes before committing... > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Priority: Major > Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png > > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10711: --- Assignee: Jacques Le Roux > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Major > Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png > > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10711. --- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in trunk at revision: 1848954 > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png > > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721547#comment-16721547 ] Michael Brohl commented on OFBIZ-10711: --- r1848673 should be analyzed again if there are similar patterns. The findings of static code analysis sometimes reports false positives. > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png > > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6650) Blank page when ordering an open-gismo-GZ-1006-p
[ https://issues.apache.org/jira/browse/OFBIZ-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721616#comment-16721616 ] Jacques Le Roux commented on OFBIZ-6650: This still does not work and I have no clues :/ > Blank page when ordering an open-gismo-GZ-1006-p > > > Key: OFBIZ-6650 > URL: https://issues.apache.org/jira/browse/OFBIZ-6650 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: Image 095.png, Image 096.png, Image 097.png, Image > 098.png > > > This issue is also happenning in stable and old demo -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10711) FindGeneric page broken
[
https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721720#comment-16721720
]
Jacques Le Roux commented on OFBIZ-10711:
-
Hi Michael,
In understand your concern. There are no other similar patterns. This one is
something very special, and I guess that's why it escaped Mathieu's scrutinity.
Mathieu introduced several other try-with-ressources (4 exactly) but none of
them are used in a such complex (if not convoluted) case.
You might reassure yourself by looking for the "\+ +try \(" regexp in a copy of
https://fisheye.apache.org/rdiff/ofbiz?csid=1848673&u&N.
> FindGeneric page broken
> ---
>
> Key: OFBIZ-10711
> URL: https://issues.apache.org/jira/browse/OFBIZ-10711
> Project: OFBiz
> Issue Type: Bug
>Reporter: Deepak Dixit
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png
>
>
> FindGeneic page broken, Error getting the next result (ResultSet not open.
> Operation 'next' not permitted. Verify that autocommit is off.)
> https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10711) FindGeneric page broken
[
https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721720#comment-16721720
]
Jacques Le Roux edited comment on OFBIZ-10711 at 12/14/18 7:26 PM:
---
Hi Michael,
In understand your concern. There are no other similar patterns. This one is
something very special, and I guess that's why it escaped Mathieu's scrutinity.
Mathieu introduced several other try-with-ressources (4 exactly) but none of
them are used in a such complex (if not convoluted) case.
You might reassure yourself by looking for the {code}"\+ +try \"{code} regexp
in a copy of https://fisheye.apache.org/rdiff/ofbiz?csid=1848673&u&N.
was (Author: jacques.le.roux):
Hi Michael,
In understand your concern. There are no other similar patterns. This one is
something very special, and I guess that's why it escaped Mathieu's scrutinity.
Mathieu introduced several other try-with-ressources (4 exactly) but none of
them are used in a such complex (if not convoluted) case.
You might reassure yourself by looking for the "\+ +try \(" regexp in a copy of
https://fisheye.apache.org/rdiff/ofbiz?csid=1848673&u&N.
> FindGeneric page broken
> ---
>
> Key: OFBIZ-10711
> URL: https://issues.apache.org/jira/browse/OFBIZ-10711
> Project: OFBiz
> Issue Type: Bug
>Reporter: Deepak Dixit
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png
>
>
> FindGeneic page broken, Error getting the next result (ResultSet not open.
> Operation 'next' not permitted. Verify that autocommit is off.)
> https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-7907) Move jsgantt files from images to projectmgr component
[ https://issues.apache.org/jira/browse/OFBIZ-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7907. -- Resolution: Information Provided This is obsolete after the work on common-theme > Move jsgantt files from images to projectmgr component > -- > > Key: OFBIZ-7907 > URL: https://issues.apache.org/jira/browse/OFBIZ-7907 > Project: OFBiz > Issue Type: Improvement > Components: framework, projectmgr >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-7907-jsgantt.patch > > > Currently the jsgantt files (css and js) are only used by the projectmgr > component, but the files are included in the image component in the framework > stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721726#comment-16721726 ] Jacques Le Roux commented on OFBIZ-5776: I'm unsure why this has not been done yet... > Move static resources from framework/images to framework/resources webapp > - > > Key: OFBIZ-5776 > URL: https://issues.apache.org/jira/browse/OFBIZ-5776 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-5776.patch > > > Move all the static resources form images webapp to resources webapp, as they > all are more related to resources rather then images. > Also we need to rearrange these resources based on their purpose, like > - Move all js related files and plugins under resources/js > - Move all the css related files and plugins under resources/css > - Move all the images related to js and css under resources/images or > resources/img -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9211) Load demo data shows error loading xml files
[ https://issues.apache.org/jira/browse/OFBIZ-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9211. -- Resolution: Cannot Reproduce Fix Version/s: (was: 17.12.01) Upcoming Branch Cannot reproduce using "cleanAll eclipse loadAll" > Load demo data shows error loading xml files > > > Key: OFBIZ-9211 > URL: https://issues.apache.org/jira/browse/OFBIZ-9211 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Trunk >Reporter: Wai >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > ran "gradlew loadDefault" > found the following error... > 2017-02-09 23:30:19,274 |main |EntityDataLoadContainer > |I| The following errors occurred in the data load: > 2017-02-09 23:30:19,274 |main |EntityDataLoadContainer > |I| [loadData]: Error loading XML Resource > "file:/ofbiz-trunk/plugins/ebay/data/DemoEbayData.xml"; Error was: A > transaction error occurred reading data > 2017-02-09 23:30:19,274 |main |EntityDataLoadContainer > |I| [loadData]: Error loading XML Resource > "file:/ofbiz-trunk/plugins/myportal/data/MyPortalDemoData.xml"; Error was: A > transaction error occurred reading data -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10713) wrong title in table header of Config Option List
Sebastian Wachinger created OFBIZ-10713: --- Summary: wrong title in table header of Config Option List Key: OFBIZ-10713 URL: https://issues.apache.org/jira/browse/OFBIZ-10713 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: 16.11.04, Trunk Reporter: Sebastian Wachinger The table header in the box containing the list of config options on top of the page [Config Options |https://demo-stable.ofbiz.apache.org/catalog/control/EditProductConfigOptions?configItemId=PZ] has for the first column the title "Config Item", it should be "Config Option" instead. Trivial, but still confusing . . . -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10713) wrong title in table header of Config Option List
[
https://issues.apache.org/jira/browse/OFBIZ-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Wachinger updated OFBIZ-10713:
Description: The table header in the box containing the list of config
options on top of the page [Config
Options|https://demo-stable.ofbiz.apache.org/catalog/control/EditProductConfigOptions?configItemId=PZ]
has for the first column the title {{Config Item}}, it should be {{Config
Option}} instead. Trivial, but still confusing . . . (was: The table header in
the box containing the list of config options on top of the page [Config
Options
|https://demo-stable.ofbiz.apache.org/catalog/control/EditProductConfigOptions?configItemId=PZ]
has for the first column the title "Config Item", it should be "Config Option"
instead. Trivial, but still confusing . . .)
> wrong title in table header of Config Option List
> -
>
> Key: OFBIZ-10713
> URL: https://issues.apache.org/jira/browse/OFBIZ-10713
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 16.11.04
>Reporter: Sebastian Wachinger
>Priority: Trivial
>
> The table header in the box containing the list of config options on top of
> the page [Config
> Options|https://demo-stable.ofbiz.apache.org/catalog/control/EditProductConfigOptions?configItemId=PZ]
> has for the first column the title {{Config Item}}, it should be {{Config
> Option}} instead. Trivial, but still confusing . . .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10714) Display the user selected variant product options for configurable product
Sebastian Wachinger created OFBIZ-10714:
---
Summary: Display the user selected variant product options for
configurable product
Key: OFBIZ-10714
URL: https://issues.apache.org/jira/browse/OFBIZ-10714
Project: OFBiz
Issue Type: Improvement
Components: ecommerce
Affects Versions: 16.11.04, Trunk
Reporter: Sebastian Wachinger
If the customer buys a configurable product, with a product component being a
{{Product Variant}}, the selected variant (Product ID and component price) is
displayed on the {{ConfigProductDetail}} page before you click {{Add to Cart}},
but after this the selected variant never is displayed, or communicated, at all:
- not in the {{ShowCart}} page,
- not in the checkout summary pages,
- not at all in the confirmation email,
- and not in the {{OrderInfo}} page (order detail page) in the backend
management.
The only way to find out which variant options the customer configured before
buying is to click on the +{{Production Run}}+ link on the {{OrderInfo}} page.
For the shop manager and manufacturer this might even be good enough, but not
communicating the ordered and sold product configuration in detail to the buyer
spells trouble!
So it would be great if, in the pages listed above, the selected variants would
appear in detail, eg with the product ID of the selected variant product,
and/or with the product name / short description, and maybe the component
prices.
For example, the shopping cart now only displays the lines
{quote}Pizza
Peppers
Sauce
{quote}
Instead it should display
{quote}Pizza
Peppers : Roasted PEPPERS-R
Sauce : Tomato Parmesan SAUCE-TP
{quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
