[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition
[
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722710#comment-16722710
]
Aditya Sharma commented on OFBIZ-10645:
---
Hi [~jacques.le.roux] [~mthl] ,
I have updated the patch. Please have a look.
> Empty entity name should not be allowed in entity definition
>
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png, OFBIZ-10645-alternate.patch,
> OFBIZ-10645.patch, OFBIZ-10645.patch
>
>
> Present system allows empty name in entity definition due to which there
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3 |DatabaseUtil
> |I| Error getting primary key info from database with null tableName, will
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1 |DatabaseUtil
> |I| Error getting primary key info from database with null tableName, will
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2 |DatabaseUtil
> |I| Error getting primary key info from database with null tableName, will
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2 |DatabaseUtil
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1 |DatabaseUtil
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP,
> CREATED_TX_STAMP TIMESTAMP, PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1,
> column 21.
> at
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source)
> ~[derby-10.14.1.0.jar:?]
> at
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source)
> ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
> ~[commons-dbcp2-2.1.1.jar:2.1.1]
> at
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
> ~[commons-dbcp2-2.1.1.jar:2.1.1]
> at
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
> [ofbiz.jar:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [?:1.8.0_66]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [?:1.8.0_66]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [?:1.8.0_66]
> at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error:
> Encountered "(" at line 1, column 21.
> at org.apache.derby.iapi.error.StandardException.newException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.iapi.error.StandardException.newException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
[jira] [Updated] (OFBIZ-10645) Empty entity name should not be allowed in entity definition
[
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma updated OFBIZ-10645:
--
Attachment: OFBIZ-10645.patch
> Empty entity name should not be allowed in entity definition
>
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png, OFBIZ-10645-alternate.patch,
> OFBIZ-10645.patch, OFBIZ-10645.patch
>
>
> Present system allows empty name in entity definition due to which there
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3 |DatabaseUtil
> |I| Error getting primary key info from database with null tableName, will
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1 |DatabaseUtil
> |I| Error getting primary key info from database with null tableName, will
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2 |DatabaseUtil
> |I| Error getting primary key info from database with null tableName, will
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2 |DatabaseUtil
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1 |DatabaseUtil
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP,
> CREATED_TX_STAMP TIMESTAMP, PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1,
> column 21.
> at
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source)
> ~[derby-10.14.1.0.jar:?]
> at
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source)
> ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
> ~[commons-dbcp2-2.1.1.jar:2.1.1]
> at
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
> ~[commons-dbcp2-2.1.1.jar:2.1.1]
> at
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
> [ofbiz.jar:?]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [?:1.8.0_66]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [?:1.8.0_66]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [?:1.8.0_66]
> at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error:
> Encountered "(" at line 1, column 21.
> at org.apache.derby.iapi.error.StandardException.newException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at org.apache.derby.iapi.error.StandardException.newException(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
> Source) ~[derby-10.14.1.0.jar:?]
> at
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown
[jira] [Created] (OFBIZ-10716) Browser Unresponsive when Loading Entity with Large Results
Devanshu Vyas created OFBIZ-10716:
-
Summary: Browser Unresponsive when Loading Entity with Large
Results
Key: OFBIZ-10716
URL: https://issues.apache.org/jira/browse/OFBIZ-10716
Project: OFBiz
Issue Type: Improvement
Components: framework/webtools
Affects Versions: Trunk
Reporter: Devanshu Vyas
Assignee: Devanshu Vyas
Recently, I came across a situation where an entity was taking too much of a
time(browser asked me to either wait or kill) while loading/searching results
in the Webtools application. The entity had close to 5M records, and I checked
the server responded timely but the rendering of the screen was taking time.
When I explored the issue I came across a macro which renders the pagination on
the screen, and it had a code block which was causing the screen rendering
delay.
{code}
<#assign x=(listSize/viewSize)?ceiling>
<#list 1..x as i>
<#if i == (viewIndex+1)>${i-1}">${i}
{code}
This code seems logical enough to me, and what I gather from this is that the
list will render a select box with 250,000 options.
I would like to propose a change in this UI/UX from select box to an input text
box so a user can navigate to any page, similar to a navigation input box in a
PDF document reader application.
Please let me know your thoughts on this and share some more ideas to how we
can improve/resolve this issue. Looking forward to your replies!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9603) EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], caught in Finalize
[
https://issues.apache.org/jira/browse/OFBIZ-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722677#comment-16722677
]
Aditya Sharma commented on OFBIZ-9603:
--
Thanks for the details [~jacques.le.roux] :)
> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail],
> caught in Finalize
>
>
> Key: OFBIZ-9603
> URL: https://issues.apache.org/jira/browse/OFBIZ-9603
> Project: OFBiz
> Issue Type: Sub-task
> Components: marketing
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
>
> Steps to regenerate issue:
> 1. Go to SFA component (https://localhost:8443/sfa/control/main)
> 2. Click on sub-menu "Leads" (https://localhost:8443/sfa/control/FindLeads)
> Following error in logs:
> {code:java}
> 2017-08-22 08:59:50,496 |Finalizer|EntityListIterator
> |E|
> ==
> EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail],
> caught in Finalize
> ==
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9743) updateContent service does not return an error/success message
[ https://issues.apache.org/jira/browse/OFBIZ-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722681#comment-16722681 ] Aditya Sharma commented on OFBIZ-9743: -- Indeed. With OFBIZ-10625 being done we can close it. > updateContent service does not return an error/success message > --- > > Key: OFBIZ-9743 > URL: https://issues.apache.org/jira/browse/OFBIZ-9743 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Rohit Rai >Assignee: Aditya Sharma >Priority: Major > Fix For: 17.12.01, 16.11.06 > > > 1. Go to Content, > 2. Click on Find in the search options to get a list of all the contents in > the system. > 3. Select a content from the list of content. > 4. Edit Content form should get opened. > 5. Click on update, the user is not presented with success or error message > on the screen. > Although, the service works and the content gets updated. > Here is a link to the issue, > https://demo-trunk.ofbiz.apache.org/content/control/editContent?contentId=TEMPLATE_MASTER -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9743) updateContent service does not return an error/success message
[ https://issues.apache.org/jira/browse/OFBIZ-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9743. > updateContent service does not return an error/success message > --- > > Key: OFBIZ-9743 > URL: https://issues.apache.org/jira/browse/OFBIZ-9743 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Rohit Rai >Assignee: Aditya Sharma >Priority: Major > Fix For: 17.12.01, 16.11.06 > > > 1. Go to Content, > 2. Click on Find in the search options to get a list of all the contents in > the system. > 3. Select a content from the list of content. > 4. Edit Content form should get opened. > 5. Click on update, the user is not presented with success or error message > on the screen. > Although, the service works and the content gets updated. > Here is a link to the issue, > https://demo-trunk.ofbiz.apache.org/content/control/editContent?contentId=TEMPLATE_MASTER -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-9743) updateContent service does not return an error/success message
[ https://issues.apache.org/jira/browse/OFBIZ-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-9743. -- Resolution: Fixed > updateContent service does not return an error/success message > --- > > Key: OFBIZ-9743 > URL: https://issues.apache.org/jira/browse/OFBIZ-9743 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Rohit Rai >Assignee: Aditya Sharma >Priority: Major > Fix For: 17.12.01, 16.11.06 > > > 1. Go to Content, > 2. Click on Find in the search options to get a list of all the contents in > the system. > 3. Select a content from the list of content. > 4. Edit Content form should get opened. > 5. Click on update, the user is not presented with success or error message > on the screen. > Although, the service works and the content gets updated. > Here is a link to the issue, > https://demo-trunk.ofbiz.apache.org/content/control/editContent?contentId=TEMPLATE_MASTER -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10625) Convert updateContent and removeContent service to entity-auto
[ https://issues.apache.org/jira/browse/OFBIZ-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722676#comment-16722676 ] Aditya Sharma commented on OFBIZ-10625: --- Thanks Deepak :) > Convert updateContent and removeContent service to entity-auto > -- > > Key: OFBIZ-10625 > URL: https://issues.apache.org/jira/browse/OFBIZ-10625 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6807) UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with publicId [null] and the file/resource is [web-app_3_0.xsd]
[
https://issues.apache.org/jira/browse/OFBIZ-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722653#comment-16722653
]
Paul Foxworthy commented on OFBIZ-6807:
---
Hi Jacques,
Yes, I agree proper use of XML namespaces should be a separate issue. The
Eclipse catalogs may not work for other IDEs, so we may need to maintain
several versions. It shouldn't be too hard because we won't be defining new XML
schemas and namespaces very often. Mostly we'd just change details within them,
and that won't affect the catalog or catalogs.
> UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with
> publicId [null] and the file/resource is [web-app_3_0.xsd]
>
>
> Key: OFBIZ-6807
> URL: https://issues.apache.org/jira/browse/OFBIZ-6807
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Deepak Dixit
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> System throws following exception on server start:
> {code}
> [java] 2016-01-16 15:04:50,942 |catalina-startup-2 |UtilXml
> |W| [UtilXml.LocalResolver.resolveEntity] could not find LOCAL
> DTD/Schema with publicId [null] and the file/resource is [web-app_3_0.xsd]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-6731) In widget forms display element has not time type
[ https://issues.apache.org/jira/browse/OFBIZ-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6731. -- Resolution: Done Assignee: Jacques Le Roux Fix Version/s: (was: 17.12.01) Upcoming Branch bq. a new Jira will be needed. > In widget forms display element has not time type > - > > Key: OFBIZ-6731 > URL: https://issues.apache.org/jira/browse/OFBIZ-6731 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Note that there is only 1 (in > formWidgetExampleForms.xml ) so it seems this has not much use OOTB, hence > it's only a minor improvement -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-8079) persian calendar problem
[ https://issues.apache.org/jira/browse/OFBIZ-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8079. -- Resolution: Information Provided > persian calendar problem > - > > Key: OFBIZ-8079 > URL: https://issues.apache.org/jira/browse/OFBIZ-8079 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 14.12 >Reporter: ali sohrabi >Priority: Major > > I set ma locale to fa-IR and Time zone to Iran Standard time, but still all > calendars are gregorian, but it must be (shamsi/jalali) persian calendar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10128) Clean images, among them logos, in all locations used
[ https://issues.apache.org/jira/browse/OFBIZ-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10128: --- Assignee: Jacques Le Roux > Clean images, among them logos, in all locations used > - > > Key: OFBIZ-10128 > URL: https://issues.apache.org/jira/browse/OFBIZ-10128 > Project: OFBiz > Issue Type: Task >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > This is a copy of what [I said in dev > ML|http://markmail.org/message/ubx6he4z22vtat3r] > bq. It would be great if we could use the same logo everywhere and get rid of > old version at least in svn trunk It's a mess in general with images. There > are 3 locations: svn repo, main site and wiki. We should link as much as > possible from our svn repo. I even wonder if we should not ALWAYS link to it, > even from the main site! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9255) The Tax information have not been filled for "Tax adjustment due to order change" in service recalcTaxTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9255: -- Assignee: (was: Jacques Le Roux) > The Tax information have not been filled for "Tax adjustment due to order > change" in service recalcTaxTotal > --- > > Key: OFBIZ-9255 > URL: https://issues.apache.org/jira/browse/OFBIZ-9255 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Trunk > Environment: Xubuntu, POSTGRES >Reporter: Marie-Aline Pantais >Priority: Major > Attachments: Capture d’écran_2017-03-14_15-34-13.png, OFBIZ-9255.patch > > > As per example, when you remove carrier cost and modify it a new line is > created in OrderAjustment mentioning "Tax adjustment due to order change" in > the description but Tax information as taxAuthorityRateSeqId, > sourcePercentage, taxAuthGeoId, taxAuthPartyId are not filled -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-4501) Incorrect use of eca for create/updateShipment
[
https://issues.apache.org/jira/browse/OFBIZ-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-4501:
---
Description:
createShipment service doesn't populate the facility and order info into
shipment. Instead it is handled by eca rules. This is wrong. ECA rules should
be used to update other objects or cause other actions and not update the
object that is being committed. This makes it difficult to traverse the code.
Can also cause bugs that are difficult troubleshoot. e.g: In this case,
facilities are populated in shipment by method
setShipmentSettingsFromPrimaryOrder, but eca rule checking for originFacilityId
gets executed before it is populated. Following eca rules should be removed and
instead the code should be added to create/updateshipment methods.
{code:xml}
{code}
was:
createShipment service doesn't populate the facility and order info into
shipment. Instead it is handled by eca rules. This is wrong. ECA rules should
be used to update other objects or cause other actions and not update the
object that is being committed. This makes it difficult to traverse the code.
Can also cause bugs that are difficult troubleshoot. e.g: In this case,
facilities are populated in shipment by method
setShipmentSettingsFromPrimaryOrder, but eca rule checking for originFacilityId
gets executed before it is populated. Following eca rules should be removed and
instead the code should be added to create/updateshipment methods.
> Incorrect use of eca for create/updateShipment
> --
>
> Key: OFBIZ-4501
> URL: https://issues.apache.org/jira/browse/OFBIZ-4501
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: Release Branch 11.04, Trunk
>Reporter: Kiran Gawde
>Priority: Major
> Attachments: OFBIZ-4501-ModifiedCreateUpdateShipmentService.patch,
> OFBIZ-4501-ModifiedCreateUpdateShipmentService.patch,
> OFBIZ-4501-ShipmentServiceXml.patch, OFBIZ-4501-ShipmentServiceXml.patch,
> OFBIZ-4501-ShipmentServiceXml.patch
>
>
> createShipment service doesn't populate the facility and order info into
> shipment. Instead it is handled by eca rules. This is wrong. ECA rules should
> be used to update other objects or cause other actions and not update the
> object that is being committed. This makes it difficult to traverse the code.
> Can also cause bugs that are difficult troubleshoot. e.g: In this case,
> facilities are populated in shipment by method
> setShipmentSettingsFromPrimaryOrder, but eca rule checking for
> originFacilityId gets executed before it is populated. Following eca rules
> should be removed and instead the code should be added to
> create/updateshipment methods.
> {code:xml}
>
>
>
>
>
>
> operator="is-not-empty"/>
>
>
>
> to-field-name="oldOriginFacilityId"/>
>
>
>
>
> operator="not-equals" to-field-name="oldDestinationFacilityId"/>
> operator="is-not-empty"/>
>
>
>
>
>
>
>
>
> to-field-name="oldPrimaryOrderId"/>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10024) INOUT entity-auto engine parameter not seen in SECA
[
https://issues.apache.org/jira/browse/OFBIZ-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722475#comment-16722475
]
Jacques Le Roux commented on OFBIZ-10024:
-
Thanks Deepak,
Indeed, I agree.
> INOUT entity-auto engine parameter not seen in SECA
>
>
> Key: OFBIZ-10024
> URL: https://issues.apache.org/jira/browse/OFBIZ-10024
> Project: OFBiz
> Issue Type: Bug
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> At the bottom of OFBIZ-9985 I mentionned an issue I crossed when using an
> INOUT parameter with entity-auto engine and triggering an SECA.
> Here it is:
> Hi Dennis,
> No there is no problems with entity-auto as is, ie as it's used so far, in
> other words no known bugs. The problem I crossed is something "special" (or
> new).
> Using entity-auto, I wanted to mimic the current createBudget Minilang
> implementation which also calls createBudgetStatus. So I thought that by
> trigerring createBudgetStatus with a SECA it would be OK.
> Here is the patch:
> {code}
> Index: secas.xml
> ===
> --- secas.xml (revision 1815825)
> +++ secas.xml (working copy)
> @@ -99,7 +99,13 @@
> persist="true"/>
>
> -
> +
> +
> +
> +
> + run-as-user="system"/>
> +
> +
>
>
>
> Index: services_budget.xml
> ===
> --- services_budget.xml (revision 1815825)
> +++ services_budget.xml (working copy)
> @@ -25,8 +25,7 @@
> 1.0
>
> - -
> location="component://accounting/minilang/budget/BudgetServices.xml"
> invoke="createBudget" auth="true">
> + engine="entity-auto" invoke="create" auth="true">
> Create a Budget
>
>
> {code}
> And here is the error
> {code}
> 2017-11-21 15:00:47,649 |jsse-nio-8443-exec-1 |ServiceDispatcher
> |E| Incoming context (in runSync : createBudgetStatus) does not match
> expected requirements
> org.apache.ofbiz.service.ServiceValidationException: Le param�tre requis
> suivant manque : [createBudgetStatus.budgetId]
> at
> org.apache.ofbiz.service.ModelService.validate(ModelService.java:565)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:379)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:387)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.event.CoreEvents.scheduleService(CoreEvents.java:316)
> [ofbiz.jar:?]
> {code}
> I did not check the relation between the entity-auto and SECA code yet, but
> at the moment {{ optional="true"/>}} does not pass a budgetId in the SECA environement so the
> SECA fails.
> BTW the service-eca.xsd seriously lacks documentation. I have created
> OFBIZ-9994 for that
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10625) Convert updateContent and removeContent service to entity-auto
[ https://issues.apache.org/jira/browse/OFBIZ-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10625. Resolution: Done Fix Version/s: Upcoming Branch This has been done at ofbiz framework trunk at r#1849025 Thanks Aditya Sharma for reporting the issue. > Convert updateContent and removeContent service to entity-auto > -- > > Key: OFBIZ-10625 > URL: https://issues.apache.org/jira/browse/OFBIZ-10625 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10625) Convert updateContent and removeContent service to entity-auto
[ https://issues.apache.org/jira/browse/OFBIZ-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-10625: Assignee: Deepak Dixit (was: Aditya Sharma) > Convert updateContent and removeContent service to entity-auto > -- > > Key: OFBIZ-10625 > URL: https://issues.apache.org/jira/browse/OFBIZ-10625 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Deepak Dixit >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10715) Convert createBudget service to entity-auto
[ https://issues.apache.org/jira/browse/OFBIZ-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722473#comment-16722473 ] Deepak Dixit commented on OFBIZ-10715: -- This has been done at ofbiz framework trunk at r#1849024 > Convert createBudget service to entity-auto > --- > > Key: OFBIZ-10715 > URL: https://issues.apache.org/jira/browse/OFBIZ-10715 > Project: OFBiz > Issue Type: Sub-task >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Fix For: Upcoming Branch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10715) Convert createBudget service to entity-auto
[ https://issues.apache.org/jira/browse/OFBIZ-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10715. Resolution: Done Fix Version/s: Upcoming Branch > Convert createBudget service to entity-auto > --- > > Key: OFBIZ-10715 > URL: https://issues.apache.org/jira/browse/OFBIZ-10715 > Project: OFBiz > Issue Type: Sub-task >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Fix For: Upcoming Branch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10715) Convert createBudget service to entity-auto
Deepak Dixit created OFBIZ-10715: Summary: Convert createBudget service to entity-auto Key: OFBIZ-10715 URL: https://issues.apache.org/jira/browse/OFBIZ-10715 Project: OFBiz Issue Type: Sub-task Reporter: Deepak Dixit Assignee: Deepak Dixit -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10024) INOUT entity-auto engine parameter not seen in SECA
[
https://issues.apache.org/jira/browse/OFBIZ-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722468#comment-16722468
]
Deepak Dixit commented on OFBIZ-10024:
--
I think this is not a valid issue, I tested it locally and its working fine,
The issue with SECA rule, it is written on invoke, at the time of invoking you
are creating BudgetStatus, and it will throw the foreign key constraints issue.
As budgetId not created in the system at the time of invoke
Please change the event="invoke" to event="commit" it will work fine.
> INOUT entity-auto engine parameter not seen in SECA
>
>
> Key: OFBIZ-10024
> URL: https://issues.apache.org/jira/browse/OFBIZ-10024
> Project: OFBiz
> Issue Type: Bug
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> At the bottom of OFBIZ-9985 I mentionned an issue I crossed when using an
> INOUT parameter with entity-auto engine and triggering an SECA.
> Here it is:
> Hi Dennis,
> No there is no problems with entity-auto as is, ie as it's used so far, in
> other words no known bugs. The problem I crossed is something "special" (or
> new).
> Using entity-auto, I wanted to mimic the current createBudget Minilang
> implementation which also calls createBudgetStatus. So I thought that by
> trigerring createBudgetStatus with a SECA it would be OK.
> Here is the patch:
> {code}
> Index: secas.xml
> ===
> --- secas.xml (revision 1815825)
> +++ secas.xml (working copy)
> @@ -99,7 +99,13 @@
> persist="true"/>
>
> -
> +
> +
> +
> +
> + run-as-user="system"/>
> +
> +
>
>
>
> Index: services_budget.xml
> ===
> --- services_budget.xml (revision 1815825)
> +++ services_budget.xml (working copy)
> @@ -25,8 +25,7 @@
> 1.0
>
> - -
> location="component://accounting/minilang/budget/BudgetServices.xml"
> invoke="createBudget" auth="true">
> + engine="entity-auto" invoke="create" auth="true">
> Create a Budget
>
>
> {code}
> And here is the error
> {code}
> 2017-11-21 15:00:47,649 |jsse-nio-8443-exec-1 |ServiceDispatcher
> |E| Incoming context (in runSync : createBudgetStatus) does not match
> expected requirements
> org.apache.ofbiz.service.ServiceValidationException: Le param�tre requis
> suivant manque : [createBudgetStatus.budgetId]
> at
> org.apache.ofbiz.service.ModelService.validate(ModelService.java:565)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:379)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:387)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.event.CoreEvents.scheduleService(CoreEvents.java:316)
> [ofbiz.jar:?]
> {code}
> I did not check the relation between the entity-auto and SECA code yet, but
> at the moment {{ optional="true"/>}} does not pass a budgetId in the SECA environement so the
> SECA fails.
> BTW the service-eca.xsd seriously lacks documentation. I have created
> OFBIZ-9994 for that
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9743) updateContent service does not return an error/success message
[ https://issues.apache.org/jira/browse/OFBIZ-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722471#comment-16722471 ] Deepak Dixit commented on OFBIZ-9743: - [~aditya.sharma] Can we close this issue? > updateContent service does not return an error/success message > --- > > Key: OFBIZ-9743 > URL: https://issues.apache.org/jira/browse/OFBIZ-9743 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Rohit Rai >Assignee: Aditya Sharma >Priority: Major > Fix For: 17.12.01, 16.11.06 > > > 1. Go to Content, > 2. Click on Find in the search options to get a list of all the contents in > the system. > 3. Select a content from the list of content. > 4. Edit Content form should get opened. > 5. Click on update, the user is not presented with success or error message > on the screen. > Although, the service works and the content gets updated. > Here is a link to the issue, > https://demo-trunk.ofbiz.apache.org/content/control/editContent?contentId=TEMPLATE_MASTER -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10024) INOUT entity-auto engine parameter not seen in SECA
[
https://issues.apache.org/jira/browse/OFBIZ-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722468#comment-16722468
]
Deepak Dixit edited comment on OFBIZ-10024 at 12/16/18 12:08 PM:
-
I think this is not a valid issue, I tested it locally and its working fine,
The issue with SECA rule, it is written on invoke.
at the time of invoke you are creating BudgetStatus, budgetId not created in
the system at the time of invoke, it will throw the foreign key constraints
error.
Please change the event="invoke" to event="commit" it will work fine.
was (Author: deepak.dixit):
I think this is not a valid issue, I tested it locally and its working fine,
The issue with SECA rule, it is written on invoke, at the time of invoking you
are creating BudgetStatus, and it will throw the foreign key constraints issue.
As budgetId not created in the system at the time of invoke
Please change the event="invoke" to event="commit" it will work fine.
> INOUT entity-auto engine parameter not seen in SECA
>
>
> Key: OFBIZ-10024
> URL: https://issues.apache.org/jira/browse/OFBIZ-10024
> Project: OFBiz
> Issue Type: Bug
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> At the bottom of OFBIZ-9985 I mentionned an issue I crossed when using an
> INOUT parameter with entity-auto engine and triggering an SECA.
> Here it is:
> Hi Dennis,
> No there is no problems with entity-auto as is, ie as it's used so far, in
> other words no known bugs. The problem I crossed is something "special" (or
> new).
> Using entity-auto, I wanted to mimic the current createBudget Minilang
> implementation which also calls createBudgetStatus. So I thought that by
> trigerring createBudgetStatus with a SECA it would be OK.
> Here is the patch:
> {code}
> Index: secas.xml
> ===
> --- secas.xml (revision 1815825)
> +++ secas.xml (working copy)
> @@ -99,7 +99,13 @@
> persist="true"/>
>
> -
> +
> +
> +
> +
> + run-as-user="system"/>
> +
> +
>
>
>
> Index: services_budget.xml
> ===
> --- services_budget.xml (revision 1815825)
> +++ services_budget.xml (working copy)
> @@ -25,8 +25,7 @@
> 1.0
>
> - -
> location="component://accounting/minilang/budget/BudgetServices.xml"
> invoke="createBudget" auth="true">
> + engine="entity-auto" invoke="create" auth="true">
> Create a Budget
>
>
> {code}
> And here is the error
> {code}
> 2017-11-21 15:00:47,649 |jsse-nio-8443-exec-1 |ServiceDispatcher
> |E| Incoming context (in runSync : createBudgetStatus) does not match
> expected requirements
> org.apache.ofbiz.service.ServiceValidationException: Le param�tre requis
> suivant manque : [createBudgetStatus.budgetId]
> at
> org.apache.ofbiz.service.ModelService.validate(ModelService.java:565)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:379)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:387)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.event.CoreEvents.scheduleService(CoreEvents.java:316)
> [ofbiz.jar:?]
> {code}
> I did not check the relation between the entity-auto and SECA code yet, but
> at the moment {{ optional="true"/>}} does not pass a budgetId in the SECA environement so the
> SECA fails.
> BTW the service-eca.xsd seriously lacks documentation. I have created
> OFBIZ-9994 for that
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10024) INOUT entity-auto engine parameter not seen in SECA
[
https://issues.apache.org/jira/browse/OFBIZ-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722469#comment-16722469
]
Deepak Dixit commented on OFBIZ-10024:
--
I am closing this issue as not a problem.
Also, there is an issue with Budget entity modeling, statusId should be part of
the Budget entity.
> INOUT entity-auto engine parameter not seen in SECA
>
>
> Key: OFBIZ-10024
> URL: https://issues.apache.org/jira/browse/OFBIZ-10024
> Project: OFBiz
> Issue Type: Bug
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> At the bottom of OFBIZ-9985 I mentionned an issue I crossed when using an
> INOUT parameter with entity-auto engine and triggering an SECA.
> Here it is:
> Hi Dennis,
> No there is no problems with entity-auto as is, ie as it's used so far, in
> other words no known bugs. The problem I crossed is something "special" (or
> new).
> Using entity-auto, I wanted to mimic the current createBudget Minilang
> implementation which also calls createBudgetStatus. So I thought that by
> trigerring createBudgetStatus with a SECA it would be OK.
> Here is the patch:
> {code}
> Index: secas.xml
> ===
> --- secas.xml (revision 1815825)
> +++ secas.xml (working copy)
> @@ -99,7 +99,13 @@
> persist="true"/>
>
> -
> +
> +
> +
> +
> + run-as-user="system"/>
> +
> +
>
>
>
> Index: services_budget.xml
> ===
> --- services_budget.xml (revision 1815825)
> +++ services_budget.xml (working copy)
> @@ -25,8 +25,7 @@
> 1.0
>
> - -
> location="component://accounting/minilang/budget/BudgetServices.xml"
> invoke="createBudget" auth="true">
> + engine="entity-auto" invoke="create" auth="true">
> Create a Budget
>
>
> {code}
> And here is the error
> {code}
> 2017-11-21 15:00:47,649 |jsse-nio-8443-exec-1 |ServiceDispatcher
> |E| Incoming context (in runSync : createBudgetStatus) does not match
> expected requirements
> org.apache.ofbiz.service.ServiceValidationException: Le param�tre requis
> suivant manque : [createBudgetStatus.budgetId]
> at
> org.apache.ofbiz.service.ModelService.validate(ModelService.java:565)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:379)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:387)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.event.CoreEvents.scheduleService(CoreEvents.java:316)
> [ofbiz.jar:?]
> {code}
> I did not check the relation between the entity-auto and SECA code yet, but
> at the moment {{ optional="true"/>}} does not pass a budgetId in the SECA environement so the
> SECA fails.
> BTW the service-eca.xsd seriously lacks documentation. I have created
> OFBIZ-9994 for that
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10024) INOUT entity-auto engine parameter not seen in SECA
[
https://issues.apache.org/jira/browse/OFBIZ-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-10024.
Resolution: Not A Problem
> INOUT entity-auto engine parameter not seen in SECA
>
>
> Key: OFBIZ-10024
> URL: https://issues.apache.org/jira/browse/OFBIZ-10024
> Project: OFBiz
> Issue Type: Bug
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> At the bottom of OFBIZ-9985 I mentionned an issue I crossed when using an
> INOUT parameter with entity-auto engine and triggering an SECA.
> Here it is:
> Hi Dennis,
> No there is no problems with entity-auto as is, ie as it's used so far, in
> other words no known bugs. The problem I crossed is something "special" (or
> new).
> Using entity-auto, I wanted to mimic the current createBudget Minilang
> implementation which also calls createBudgetStatus. So I thought that by
> trigerring createBudgetStatus with a SECA it would be OK.
> Here is the patch:
> {code}
> Index: secas.xml
> ===
> --- secas.xml (revision 1815825)
> +++ secas.xml (working copy)
> @@ -99,7 +99,13 @@
> persist="true"/>
>
> -
> +
> +
> +
> +
> + run-as-user="system"/>
> +
> +
>
>
>
> Index: services_budget.xml
> ===
> --- services_budget.xml (revision 1815825)
> +++ services_budget.xml (working copy)
> @@ -25,8 +25,7 @@
> 1.0
>
> - -
> location="component://accounting/minilang/budget/BudgetServices.xml"
> invoke="createBudget" auth="true">
> + engine="entity-auto" invoke="create" auth="true">
> Create a Budget
>
>
> {code}
> And here is the error
> {code}
> 2017-11-21 15:00:47,649 |jsse-nio-8443-exec-1 |ServiceDispatcher
> |E| Incoming context (in runSync : createBudgetStatus) does not match
> expected requirements
> org.apache.ofbiz.service.ServiceValidationException: Le param�tre requis
> suivant manque : [createBudgetStatus.budgetId]
> at
> org.apache.ofbiz.service.ModelService.validate(ModelService.java:565)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:379)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaAction.runAction(ServiceEcaAction.java:128)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaRule.eval(ServiceEcaRule.java:160)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.eca.ServiceEcaUtil.evalRules(ServiceEcaUtil.java:195)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:387)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
> [ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.event.CoreEvents.scheduleService(CoreEvents.java:316)
> [ofbiz.jar:?]
> {code}
> I did not check the relation between the entity-auto and SECA code yet, but
> at the moment {{ optional="true"/>}} does not pass a budgetId in the SECA environement so the
> SECA fails.
> BTW the service-eca.xsd seriously lacks documentation. I have created
> OFBIZ-9994 for that
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10712) Inconsistent behaviour of ServiceDispatcher.checkAuth
[
https://issues.apache.org/jira/browse/OFBIZ-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722467#comment-16722467
]
Jacques Le Roux commented on OFBIZ-10712:
-
could return {{origService.makeValid(context, ModelService.IN_PARAM);}}
directly ;)
> Inconsistent behaviour of ServiceDispatcher.checkAuth
> --
>
> Key: OFBIZ-10712
> URL: https://issues.apache.org/jira/browse/OFBIZ-10712
> Project: OFBiz
> Issue Type: Bug
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-10712.patch
>
>
> We have checkAuth method in service dispatcher class, this method performs
> multiple auth related check.
> if all checks passed it call the modelService.makeValid method to prepare
> service context (line#960) but this code executed only when service
> definition has a permission service call.
> If service does not have any permission service call then it does not call
> the modelService.makeValid and this may cause the service validation issue
> unknown parameter found.
> Ideally modelService.makeValid should call irrespective to permission service
> check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10712) Inconsistent behaviour of ServiceDispatcher.checkAuth
[ https://issues.apache.org/jira/browse/OFBIZ-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722465#comment-16722465 ] Jacques Le Roux commented on OFBIZ-10712: - Reviewed the patch, +1 it makes sense to me > Inconsistent behaviour of ServiceDispatcher.checkAuth > -- > > Key: OFBIZ-10712 > URL: https://issues.apache.org/jira/browse/OFBIZ-10712 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10712.patch > > > We have checkAuth method in service dispatcher class, this method performs > multiple auth related check. > if all checks passed it call the modelService.makeValid method to prepare > service context (line#960) but this code executed only when service > definition has a permission service call. > If service does not have any permission service call then it does not call > the modelService.makeValid and this may cause the service validation issue > unknown parameter found. > Ideally modelService.makeValid should call irrespective to permission service > check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10699) request map to create party content in controller.xml exists twice
[
https://issues.apache.org/jira/browse/OFBIZ-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722464#comment-16722464
]
Jacques Le Roux commented on OFBIZ-10699:
-
Thanks Deepak
> request map to create party content in controller.xml exists twice
> --
>
> Key: OFBIZ-10699
> URL: https://issues.apache.org/jira/browse/OFBIZ-10699
> Project: OFBiz
> Issue Type: Improvement
> Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 17.12.01
>
>
> In controller.xml of the Party component the following exist:
> {code:java}
>
> {code}
> and
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces
[ https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722463#comment-16722463 ] Deepak Dixit commented on OFBIZ-10461: -- Thanks [~bjugl], Here I was referring all the nbsp occurrences :) > Texts of checkboxes sometimes have whitespaces > -- > > Key: OFBIZ-10461 > URL: https://issues.apache.org/jira/browse/OFBIZ-10461 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Benjamin Jugl >Priority: Minor > Attachments: OFBIZ-10461_RemoveBlanksBetweenCheckboxesAndLabels.patch > > > On some pages, when there are checkboxes, the text after the checkbox has a > rendered whitespace in front of it. > A good example for this can be seen right here: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist] > The first checkboxes do not have this rendered whitespace, the lines after > that do have it. > This issue can be fixed simply through removing the whitespaces inside the > .ftl files. > > After that there an added styling should create a new gap between the > checkbox and the following text, but this time all the gaps would have the > same distance. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10699) request map to create party content in controller.xml exists twice
[
https://issues.apache.org/jira/browse/OFBIZ-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-10699:
-
Issue Type: Improvement (was: Bug)
> request map to create party content in controller.xml exists twice
> --
>
> Key: OFBIZ-10699
> URL: https://issues.apache.org/jira/browse/OFBIZ-10699
> Project: OFBiz
> Issue Type: Improvement
> Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
>Priority: Minor
>
> In controller.xml of the Party component the following exist:
> {code:java}
>
> {code}
> and
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10699) request map to create party content in controller.xml exists twice
[
https://issues.apache.org/jira/browse/OFBIZ-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-10699.
Resolution: Done
Fix Version/s: 17.12.01
> request map to create party content in controller.xml exists twice
> --
>
> Key: OFBIZ-10699
> URL: https://issues.apache.org/jira/browse/OFBIZ-10699
> Project: OFBiz
> Issue Type: Improvement
> Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 17.12.01
>
>
> In controller.xml of the Party component the following exist:
> {code:java}
>
> {code}
> and
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10699) request map to create party content in controller.xml exists twice
[
https://issues.apache.org/jira/browse/OFBIZ-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722461#comment-16722461
]
Deepak Dixit commented on OFBIZ-10699:
--
This has been done at
ofbiz framework at r#1849021 and
R17.12 at r#1849022. As this was done in 17.12 as well so backported changes to
17.12 to maintain consistency.
Thanks Pierre Smits and Jacques for the contribution.
> request map to create party content in controller.xml exists twice
> --
>
> Key: OFBIZ-10699
> URL: https://issues.apache.org/jira/browse/OFBIZ-10699
> Project: OFBiz
> Issue Type: Improvement
> Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 17.12.01
>
>
> In controller.xml of the Party component the following exist:
> {code:java}
>
> {code}
> and
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10699) request map to create party content in controller.xml exists twice
[
https://issues.apache.org/jira/browse/OFBIZ-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit reassigned OFBIZ-10699:
Assignee: Deepak Dixit
> request map to create party content in controller.xml exists twice
> --
>
> Key: OFBIZ-10699
> URL: https://issues.apache.org/jira/browse/OFBIZ-10699
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
>Priority: Major
>
> In controller.xml of the Party component the following exist:
> {code:java}
>
> {code}
> and
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10699) request map to create party content in controller.xml exists twice
[
https://issues.apache.org/jira/browse/OFBIZ-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-10699:
-
Priority: Minor (was: Major)
> request map to create party content in controller.xml exists twice
> --
>
> Key: OFBIZ-10699
> URL: https://issues.apache.org/jira/browse/OFBIZ-10699
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
>Priority: Minor
>
> In controller.xml of the Party component the following exist:
> {code:java}
>
> {code}
> and
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722457#comment-16722457
]
Deepak Dixit commented on OFBIZ-10688:
--
To fix this issue, we need to write the createArticleContent service from
scratch.
As contentIdFrom is not a valid parameter anymore for createContentAssoc
service, so createTextContent service does not create the ContentAssoc for
forum message.
We are tracking unknown parameter found issue in OFBIZ-10712
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10712) Inconsistent behaviour of ServiceDispatcher.checkAuth
[ https://issues.apache.org/jira/browse/OFBIZ-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-10712: Assignee: Deepak Dixit > Inconsistent behaviour of ServiceDispatcher.checkAuth > -- > > Key: OFBIZ-10712 > URL: https://issues.apache.org/jira/browse/OFBIZ-10712 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10712.patch > > > We have checkAuth method in service dispatcher class, this method performs > multiple auth related check. > if all checks passed it call the modelService.makeValid method to prepare > service context (line#960) but this code executed only when service > definition has a permission service call. > If service does not have any permission service call then it does not call > the modelService.makeValid and this may cause the service validation issue > unknown parameter found. > Ideally modelService.makeValid should call irrespective to permission service > check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10712) Inconsistent behaviour of ServiceDispatcher.checkAuth
[ https://issues.apache.org/jira/browse/OFBIZ-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722452#comment-16722452 ] Deepak Dixit commented on OFBIZ-10712: -- Here is the Patch for this issue, If we are doing service.makeValid so it should be executed for all the service irrespective of permissionServiceCheck. > Inconsistent behaviour of ServiceDispatcher.checkAuth > -- > > Key: OFBIZ-10712 > URL: https://issues.apache.org/jira/browse/OFBIZ-10712 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10712.patch > > > We have checkAuth method in service dispatcher class, this method performs > multiple auth related check. > if all checks passed it call the modelService.makeValid method to prepare > service context (line#960) but this code executed only when service > definition has a permission service call. > If service does not have any permission service call then it does not call > the modelService.makeValid and this may cause the service validation issue > unknown parameter found. > Ideally modelService.makeValid should call irrespective to permission service > check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10712) Inconsistent behaviour of ServiceDispatcher.checkAuth
[ https://issues.apache.org/jira/browse/OFBIZ-10712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-10712: - Attachment: OFBIZ-10712.patch > Inconsistent behaviour of ServiceDispatcher.checkAuth > -- > > Key: OFBIZ-10712 > URL: https://issues.apache.org/jira/browse/OFBIZ-10712 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10712.patch > > > We have checkAuth method in service dispatcher class, this method performs > multiple auth related check. > if all checks passed it call the modelService.makeValid method to prepare > service context (line#960) but this code executed only when service > definition has a permission service call. > If service does not have any permission service call then it does not call > the modelService.makeValid and this may cause the service validation issue > unknown parameter found. > Ideally modelService.makeValid should call irrespective to permission service > check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10152) Use properties for hard-coded date/time strings
[
https://issues.apache.org/jira/browse/OFBIZ-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722451#comment-16722451
]
Jacques Le Roux commented on OFBIZ-10152:
-
Thanks Pierre,
Makes sense indeed.
> Use properties for hard-coded date/time strings
>
>
> Key: OFBIZ-10152
> URL: https://issues.apache.org/jira/browse/OFBIZ-10152
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This refers to a suggestion from Adrian at
> http://markmail.org/message/bldm5eajql4in3yg
> {quote}
> The current OFBiz framework supports a user-selected locale and time
> zone. There are places in the UI where those settings are ignored and
> date/time strings are hard-coded to the -MM-dd HH:mm:ss.SSS format.
> That was a design decision made by the developer community.
> Most of the framework code uses a formatting string constant found in
> UtilDateTime.java:
> public static final String DATE_TIME_FORMAT = "-MM-dd HH:mm:ss.SSS";
> If you want to change the date/time format, that would be place to do it.
> It would be best to have those format strings loaded from a properties
> file, so that users like yourself can change it easily - without having
> to modify framework code. Anyone wanting to work on that improvement can
> submit a patch to Jira and I would be happy to review and commit it.
> -Adrian
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-6965)
[ https://issues.apache.org/jira/browse/OFBIZ-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722449#comment-16722449 ] Pierre Smits commented on OFBIZ-6965: - Me neither. And yes, we may be required to update things. > --- > > Key: OFBIZ-6965 > URL: https://issues.apache.org/jira/browse/OFBIZ-6965 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Labels: entity > > The Test/Production > mode has a reserved name. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10699) request map to create party content in controller.xml exists twice
[
https://issues.apache.org/jira/browse/OFBIZ-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722448#comment-16722448
]
Jacques Le Roux commented on OFBIZ-10699:
-
Yes but the 1st one is not used by the controller, only the second. From the
top of my head, I agree renaming the 1st one to EditPartyContent
> request map to create party content in controller.xml exists twice
> --
>
> Key: OFBIZ-10699
> URL: https://issues.apache.org/jira/browse/OFBIZ-10699
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> In controller.xml of the Party component the following exist:
> {code:java}
>
> {code}
> and
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-6965)
[ https://issues.apache.org/jira/browse/OFBIZ-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722446#comment-16722446 ] Jacques Le Roux commented on OFBIZ-6965: bq. BTW I'd be ready to commit a such change for the issue at hand, but I'll not w/o filling an entry in the "Deprecated Entities" section in wiki as explained above. Notsure what the state is though. So maybe now we need to update things indeed... > --- > > Key: OFBIZ-6965 > URL: https://issues.apache.org/jira/browse/OFBIZ-6965 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Labels: entity > > The Test/Production > mode has a reserved name. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722444#comment-16722444 ] Jacques Le Roux commented on OFBIZ-10711: - Hi Deepak, As I said in my comment above there are no other cases in this commit and you can check by yourself. BTW nothing induces that Mathieu's work was done after " findings of static code analysis sometimes reports false positives.". I think it was more based on removing warnings and such. > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png > > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10019) Replace ?default(value) by !value in Freemarker templates
[
https://issues.apache.org/jira/browse/OFBIZ-10019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-10019:
Description:
I want to replace {code}?default(value){code} by {code}!value{code} in
Freemarker templates, that's 1394 cases!
But before doing so I prefer to wait for a 2.4 Freemarker version because we
already experienced an issue at OFBIZ-4902, see
http://svn.apache.org/viewvc?view=revision=r1624876
Actually I know now that it was not a bug of ours but [one of
Freemarker|https://freemarker.apache.org/docs/dgui_template_exp.html#dgui_template_exp_missing_default]:
bq. Warning! If you have a composite expression after the \!, like 1 + x,
always use parenthesses, like ${x!(1 + y)} or ${(x!1) + y)}, depending on which
interpretation you meant. That's needed because due to a programming mistake in
FreeMarker 2.3.x, the precedence of ! (when it's used as default value
operator) is very low at its right side. This means that, for example, ${x!1 +
y} is misinterpreted by FreeMarker as ${x!(1 + y)} while it should mean ${(x!1)
+ y}. This programming error will be fixed in FreeMarker 2.4, so you should not
utilize this wrong behavior, or else your templates will break with FreeMarker
2.4!
was:
I want to replace ?default(value) by !value in Freemarker templates, that's
1394 cases!
But before doing so I prefer to wait for a 2.4 Freemarker version because we
already experienced an issue at OFBIZ-4902, see
http://svn.apache.org/viewvc?view=revision=r1624876
Actually I know now that it was not a bug of ours but [one of
Freemarker|https://freemarker.apache.org/docs/dgui_template_exp.html#dgui_template_exp_missing_default]:
bq. Warning! If you have a composite expression after the \!, like 1 + x,
always use parenthesses, like ${x!(1 + y)} or ${(x!1) + y)}, depending on which
interpretation you meant. That's needed because due to a programming mistake in
FreeMarker 2.3.x, the precedence of ! (when it's used as default value
operator) is very low at its right side. This means that, for example, ${x!1 +
y} is misinterpreted by FreeMarker as ${x!(1 + y)} while it should mean ${(x!1)
+ y}. This programming error will be fixed in FreeMarker 2.4, so you should not
utilize this wrong behavior, or else your templates will break with FreeMarker
2.4!
> Replace ?default(value) by !value in Freemarker templates
> -
>
> Key: OFBIZ-10019
> URL: https://issues.apache.org/jira/browse/OFBIZ-10019
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 17.12.01
>
>
> I want to replace {code}?default(value){code} by {code}!value{code} in
> Freemarker templates, that's 1394 cases!
> But before doing so I prefer to wait for a 2.4 Freemarker version because we
> already experienced an issue at OFBIZ-4902, see
> http://svn.apache.org/viewvc?view=revision=r1624876
> Actually I know now that it was not a bug of ours but [one of
> Freemarker|https://freemarker.apache.org/docs/dgui_template_exp.html#dgui_template_exp_missing_default]:
> bq. Warning! If you have a composite expression after the \!, like 1 + x,
> always use parenthesses, like ${x!(1 + y)} or ${(x!1) + y)}, depending on
> which interpretation you meant. That's needed because due to a programming
> mistake in FreeMarker 2.3.x, the precedence of ! (when it's used as default
> value operator) is very low at its right side. This means that, for example,
> ${x!1 + y} is misinterpreted by FreeMarker as ${x!(1 + y)} while it should
> mean ${(x!1) + y}. This programming error will be fixed in FreeMarker 2.4, so
> you should not utilize this wrong behavior, or else your templates will break
> with FreeMarker 2.4!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722439#comment-16722439 ] Michael Brohl commented on OFBIZ-6510: -- Thanks Jacques, I'll see if we can organise to finish this. > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6510: --- Attachment: OFBIZ-6510.patch > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6965)
[ https://issues.apache.org/jira/browse/OFBIZ-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722438#comment-16722438 ] Pierre Smits commented on OFBIZ-6965: - Hi Jacques, Yes, lots of changes have occurred since the creation of the ticket. You need to be a bit more precise. > --- > > Key: OFBIZ-6965 > URL: https://issues.apache.org/jira/browse/OFBIZ-6965 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Labels: entity > > The Test/Production > mode has a reserved name. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722434#comment-16722434 ] Jacques Le Roux commented on OFBIZ-6510: Hi Michael, I'll defintely not work on this, I just updated the patch, it still applies > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10287) gradlew --no-daemon "ofbiz --shutdown" does not work
[
https://issues.apache.org/jira/browse/OFBIZ-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-10287:
Description:
When in production, if you use several OFBiz instances on your server, to stop
them safely you need to use {{./gradlew --no-daemon terminateOfbiz}} which
actually kills all OFBiz instances using "kill -9"
{{./gradlew --no-daemon "ofbiz --shutdown"}} does not work, at least on demos
VM where there is 3 instances. So if you use it you get an unstable situation
and have to use "kill -9" manually.
You always can use "terminateOfbiz", but it means that you have to restart all
OFBiz instances. So it's easier to do that with {{all-manual-nicely.sh}}
was:
When in production, if you use several OFBiz instances on your server, to stop
them safely you need to use {{./gradlew --no-daemon terminateOfbiz}} which
actually kills all OFBiz instances using "kill -9"
{{./gradlew --no-daemon "ofbiz --shutdown" }} does not work, at least on demos
VM where there is 3 instances. So if you use it you get an unstable situation
and have to use "kill -9" manually.
This is is minor because you always can use "terminateOfbiz", but it means that
you have to restart all OFBiz instances
> gradlew --no-daemon "ofbiz --shutdown" does not work
> -
>
> Key: OFBIZ-10287
> URL: https://issues.apache.org/jira/browse/OFBIZ-10287
> Project: OFBiz
> Issue Type: Bug
>Reporter: Jacques Le Roux
>Priority: Major
>
> When in production, if you use several OFBiz instances on your server, to
> stop them safely you need to use {{./gradlew --no-daemon terminateOfbiz}}
> which actually kills all OFBiz instances using "kill -9"
> {{./gradlew --no-daemon "ofbiz --shutdown"}} does not work, at least on demos
> VM where there is 3 instances. So if you use it you get an unstable situation
> and have to use "kill -9" manually.
> You always can use "terminateOfbiz", but it means that you have to restart
> all OFBiz instances. So it's easier to do that with {{all-manual-nicely.sh}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10699) request map to create party content in controller.xml exists twice
[
https://issues.apache.org/jira/browse/OFBIZ-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722430#comment-16722430
]
Deepak Dixit commented on OFBIZ-10699:
--
[~jacques.le.roux],
CreatePartyContent request is being used in EditPartyContents screen. So its
not an unsed reqeust.
> request map to create party content in controller.xml exists twice
> --
>
> Key: OFBIZ-10699
> URL: https://issues.apache.org/jira/browse/OFBIZ-10699
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> In controller.xml of the Party component the following exist:
> {code:java}
>
> {code}
> and
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10699) request map to create party content in controller.xml exists twice
[
https://issues.apache.org/jira/browse/OFBIZ-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722429#comment-16722429
]
Deepak Dixit commented on OFBIZ-10699:
--
One request is to render create screen and another one for a service call.
I think for screen request we can rename it to EditPartyContent as OOTB
pattern.
> request map to create party content in controller.xml exists twice
> --
>
> Key: OFBIZ-10699
> URL: https://issues.apache.org/jira/browse/OFBIZ-10699
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> In controller.xml of the Party component the following exist:
> {code:java}
>
> {code}
> and
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-6965)
[ https://issues.apache.org/jira/browse/OFBIZ-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-6965: -- Assignee: (was: Jacques Le Roux) Hi Pierre, Any chances? > --- > > Key: OFBIZ-6965 > URL: https://issues.apache.org/jira/browse/OFBIZ-6965 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Labels: entity > > The Test/Production > mode has a reserved name. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10699) request map to create party content in controller.xml exists twice
[
https://issues.apache.org/jira/browse/OFBIZ-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722427#comment-16722427
]
Jacques Le Roux commented on OFBIZ-10699:
-
Hi Arun,
Any chances? W/o reply in a week I'll simply remove the 1st entry which is not
used anyway.
> request map to create party content in controller.xml exists twice
> --
>
> Key: OFBIZ-10699
> URL: https://issues.apache.org/jira/browse/OFBIZ-10699
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> In controller.xml of the Party component the following exist:
> {code:java}
>
> {code}
> and
> {code:java}
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10152) Use properties for hard-coded date/time strings
[
https://issues.apache.org/jira/browse/OFBIZ-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722421#comment-16722421
]
Pierre Smits commented on OFBIZ-10152:
--
I would say this is part of a bigger issue (namely correct formatting of date,
time and numbers (both monetary amounts and others).
Having this defined in and retrieved from a properties file is good for the
'default', but when considering multiple internal organisations in different
countries that can be used as a primary accounting entity, it is foreseeable
that employees of such countries are accustomed to having the bulk of their
invoices, orders, shipping manifests, inventory documents with dates, time and
numbers in a format in accordance to their country.
And it is imaginable that when dealing with parties across the border the
format of date/time and amounts of documents sent to the external parties are
catered to their locale/custom/etc. so that the risk of misunderstanding is
minimised.
It would be a good thing for the adopters, when such flexibility were to be
addressed in stead of just having one mandatory default that must be applied to
all.
Since we're talking about how date, time and numbers are displayed in widgets
and templates (it is not about how these values are persisted in the underlying
RDBMS) the format of how these are shown is dependent on the choices made for
the internal companies (and the individual users), and should be set/retrieved
in such fashion.
> Use properties for hard-coded date/time strings
>
>
> Key: OFBIZ-10152
> URL: https://issues.apache.org/jira/browse/OFBIZ-10152
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This refers to a suggestion from Adrian at
> http://markmail.org/message/bldm5eajql4in3yg
> {quote}
> The current OFBiz framework supports a user-selected locale and time
> zone. There are places in the UI where those settings are ignored and
> date/time strings are hard-coded to the -MM-dd HH:mm:ss.SSS format.
> That was a design decision made by the developer community.
> Most of the framework code uses a formatting string constant found in
> UtilDateTime.java:
> public static final String DATE_TIME_FORMAT = "-MM-dd HH:mm:ss.SSS";
> If you want to change the date/time format, that would be place to do it.
> It would be best to have those format strings loaded from a properties
> file, so that users like yourself can change it easily - without having
> to modify framework code. Anyone wanting to work on that improvement can
> submit a patch to Jira and I would be happy to review and commit it.
> -Adrian
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722418#comment-16722418 ] Deepak Dixit commented on OFBIZ-10711: -- I agree with Michael, this was the one example, there might be some more cases. > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png > > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10711) FindGeneric page broken
[ https://issues.apache.org/jira/browse/OFBIZ-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722417#comment-16722417 ] Deepak Dixit commented on OFBIZ-10711: -- Thanks Jacques. > FindGeneric page broken > --- > > Key: OFBIZ-10711 > URL: https://issues.apache.org/jira/browse/OFBIZ-10711 > Project: OFBiz > Issue Type: Bug >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: Screenshot 2018-12-14 at 6.07.09 PM.png > > > FindGeneic page broken, Error getting the next result (ResultSet not open. > Operation 'next' not permitted. Verify that autocommit is off.) > https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Content -- This message was sent by Atlassian JIRA (v7.6.3#76005)
