[jira] [Commented] (OFBIZ-7675) Investigate if we should turn Freemarker autoescaping on
[
https://issues.apache.org/jira/browse/OFBIZ-7675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729129#comment-16729129
]
Jacques Le Roux commented on OFBIZ-7675:
I'll try to review this in next weeks...
> Investigate if we should turn Freemarker autoescaping on
>
>
> Key: OFBIZ-7675
> URL: https://issues.apache.org/jira/browse/OFBIZ-7675
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-7675-plugins.patch, OFBIZ-7675.patch
>
>
> At OFBIZ-7041 [~f...@14x.net] suggested that we turn Freemarker autoescaping
> on. Quoting him there:
> {quote}
> This new version of FreeMarker includes auto-escaping and output formats. The
> <#escape> directive has been deprecated. Notice the comment at the very end
> of this page:
> "FreeMarker automatically escapes all values printed ... if it's properly
> configured (that's the responsibility of the programmers; [see here
> how|http://freemarker.org/docs/pgui_config_outputformatsautoesc.html])."
> Would be good to turn autoescaping on, and set the configuration to match
> .ftl as HTML and .fo.ftl as XML.
> {quote}
> [~pfm.smits] asked
> {quote}
> If we are going down that path I guess we have to visit a lot of Freemarker
> template files, right?
> {quote}
> Here is my answer
> {quote}
> We don' t use any <#escape> directives in all OFBiz. We have a couple of
> <#noescape> which should be replaced by <#noautoesc>. So I agree we could set
> the Freemarker environement to auto-escaping, and test if it has not
> unexpected side-effects.
> Could be that this will fix or complicate the issue I crossed (at bottom) of
> OFBIZ-7041 and more recently at OFBIZ-7343, let's see...
> {quote}
> Reply
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729127#comment-16729127
]
Jacques Le Roux commented on OFBIZ-10187:
-
Good news: we have access again to https://github.com/OWASP/java-html-sanitizer
and prepackaged policies there.
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: 16.11.04
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> I do not see any reason to not allow class attributes in html code. There
> might be other problems with these rules but this is a showstopper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9774) [FB] Package org.apache.ofbiz.product.config
[
https://issues.apache.org/jira/browse/OFBIZ-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729086#comment-16729086
]
Jacques Le Roux edited comment on OFBIZ-9774 at 12/26/18 4:13 PM:
--
I reopen because we have an issue with at least one of the hashCode in
ProductConfigWrapper as explained in OFBIZ-10741.
The problem is the line {{result = prime * result +
getOuterType().hashCode();}} calls getOuterType() hence the hashcode calls
itself through {{this}}. It seems we have only this case in hashcode() methods
with from [FB] issues. But we shall better check...
was (Author: jacques.le.roux):
I reopen because we have an issue with at least one of the hashCode in
ProductConfigWrapper as explained in OFBIZ-10741.
The problem is the line {{result = prime * result +
getOuterType().hashCode();}} calls getOuterType() hence the hascode calls
itself through this. It seems we have only this case in hascode() added from
[FB] issue. But we shall better check.
> [FB] Package org.apache.ofbiz.product.config
>
>
> Key: OFBIZ-9774
> URL: https://issues.apache.org/jira/browse/OFBIZ-9774
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9774_org.apache.ofbiz.product.config_bugfixes.patch
>
>
> ProductConfigItemContentWrapper.java:125,
> RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
> - RCN: Nullcheck of ProductConfigItemContentWrapper.configItemContentCache at
> line 137 of value previously dereferenced in
> org.apache.ofbiz.product.config.ProductConfigItemContentWrapper.getProductConfigItemContentAsText(GenericValue,
> String, Locale, String, Delegator, LocalDispatcher, String)
> A value is checked here to see whether it is null, but this value can't be
> null because it was previously dereferenced and if it were null a null
> pointer exception would have occurred at the earlier dereference.
> Essentially, this code and the previous dereference disagree as to whether
> this value is allowed to be null. Either the check is redundant or the
> previous dereference is erroneous.
> ProductConfigWorker.java:397, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> - RCN: Redundant nullcheck of configWrapper, which is known to be non-null in
> org.apache.ofbiz.product.config.ProductConfigWorker.loadProductConfigWrapper(Delegator,
> LocalDispatcher, String, String, String, String, String, String, Locale,
> GenericValue)
> This method contains a redundant check of a known non-null value against the
> constant null.
> ProductConfigWrapper.java:-1, SE_TRANSIENT_FIELD_NOT_RESTORED
> - Se: The field
> org.apache.ofbiz.product.config.ProductConfigWrapper.dispatcher is transient
> but isn't set by deserialization
> This class contains a field that is updated at multiple places in the class,
> thus it seems to be part of the state of the class. However, since the field
> is marked as transient and not set in readObject or readResolve, it will
> contain the default value in any deserialized instance of the class.
> ProductConfigWrapper.java:-1, SE_TRANSIENT_FIELD_NOT_RESTORED
> - Se: The field
> org.apache.ofbiz.product.config.ProductConfigWrapper.delegator is transient
> but isn't set by deserialization
> This class contains a field that is updated at multiple places in the class,
> thus it seems to be part of the state of the class. However, since the field
> is marked as transient and not set in readObject or readResolve, it will
> contain the default value in any deserialized instance of the class.
> ProductConfigWrapper.java:-1, SE_BAD_FIELD
> - Se: Class org.apache.ofbiz.product.config.ProductConfigWrapper$ConfigItem
> defines non-transient non-serializable instance field content
> This Serializable class defines a non-primitive instance field which is
> neither transient, Serializable, or java.lang.Object, and does not appear to
> implement the Externalizable interface or the readObject() and writeObject()
> methods. Objects of this class will not be deserialized correctly if a
> non-Serializable object is stored in this field.
> ProductConfigWrapper.java:50, SE_NO_SERIALVERSIONID
> - SnVI: org.apache.ofbiz.product.config.ProductConfigWrapper is Serializable;
> consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a
> serialVersionUID field. A change as simple as adding a reference to a .class
> object will add synthetic fields to the class, which will unfortunately
> change the implicit serialVersionUID (e.g., adding a reference to
> String.class will generate a static field class$java$lang$String). Also,
[jira] [Reopened] (OFBIZ-9774) [FB] Package org.apache.ofbiz.product.config
[
https://issues.apache.org/jira/browse/OFBIZ-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-9774:
I reopen because we have an issue with at least one of the hashCode in
ProductConfigWrapper as explained in OFBIZ-10741.
The problem is the line {{result = prime * result +
getOuterType().hashCode();}} calls getOuterType() hence the hascode calls
itself through this. It seems we have only this case in hascode() added from
[FB] issue. But we shall better check.
> [FB] Package org.apache.ofbiz.product.config
>
>
> Key: OFBIZ-9774
> URL: https://issues.apache.org/jira/browse/OFBIZ-9774
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9774_org.apache.ofbiz.product.config_bugfixes.patch
>
>
> ProductConfigItemContentWrapper.java:125,
> RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
> - RCN: Nullcheck of ProductConfigItemContentWrapper.configItemContentCache at
> line 137 of value previously dereferenced in
> org.apache.ofbiz.product.config.ProductConfigItemContentWrapper.getProductConfigItemContentAsText(GenericValue,
> String, Locale, String, Delegator, LocalDispatcher, String)
> A value is checked here to see whether it is null, but this value can't be
> null because it was previously dereferenced and if it were null a null
> pointer exception would have occurred at the earlier dereference.
> Essentially, this code and the previous dereference disagree as to whether
> this value is allowed to be null. Either the check is redundant or the
> previous dereference is erroneous.
> ProductConfigWorker.java:397, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> - RCN: Redundant nullcheck of configWrapper, which is known to be non-null in
> org.apache.ofbiz.product.config.ProductConfigWorker.loadProductConfigWrapper(Delegator,
> LocalDispatcher, String, String, String, String, String, String, Locale,
> GenericValue)
> This method contains a redundant check of a known non-null value against the
> constant null.
> ProductConfigWrapper.java:-1, SE_TRANSIENT_FIELD_NOT_RESTORED
> - Se: The field
> org.apache.ofbiz.product.config.ProductConfigWrapper.dispatcher is transient
> but isn't set by deserialization
> This class contains a field that is updated at multiple places in the class,
> thus it seems to be part of the state of the class. However, since the field
> is marked as transient and not set in readObject or readResolve, it will
> contain the default value in any deserialized instance of the class.
> ProductConfigWrapper.java:-1, SE_TRANSIENT_FIELD_NOT_RESTORED
> - Se: The field
> org.apache.ofbiz.product.config.ProductConfigWrapper.delegator is transient
> but isn't set by deserialization
> This class contains a field that is updated at multiple places in the class,
> thus it seems to be part of the state of the class. However, since the field
> is marked as transient and not set in readObject or readResolve, it will
> contain the default value in any deserialized instance of the class.
> ProductConfigWrapper.java:-1, SE_BAD_FIELD
> - Se: Class org.apache.ofbiz.product.config.ProductConfigWrapper$ConfigItem
> defines non-transient non-serializable instance field content
> This Serializable class defines a non-primitive instance field which is
> neither transient, Serializable, or java.lang.Object, and does not appear to
> implement the Externalizable interface or the readObject() and writeObject()
> methods. Objects of this class will not be deserialized correctly if a
> non-Serializable object is stored in this field.
> ProductConfigWrapper.java:50, SE_NO_SERIALVERSIONID
> - SnVI: org.apache.ofbiz.product.config.ProductConfigWrapper is Serializable;
> consider declaring a serialVersionUID
> This class implements the Serializable interface, but does not define a
> serialVersionUID field. A change as simple as adding a reference to a .class
> object will add synthetic fields to the class, which will unfortunately
> change the implicit serialVersionUID (e.g., adding a reference to
> String.class will generate a static field class$java$lang$String). Also,
> different source code to bytecode compilers may use different naming
> conventions for synthetic variables generated for references to class objects
> or inner classes. To ensure interoperability of Serializable across versions,
> consider adding an explicit serialVersionUID.
> ProductConfigWrapper.java:226, HE_EQUALS_USE_HASHCODE
> - HE: org.apache.ofbiz.product.config.ProductConfigWrapper defines equals and
> uses Object.hashCode()
> This class overrides equals(Object), but does not override hashCode(), and
> i
[jira] [Commented] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729080#comment-16729080 ] Jacques Le Roux commented on OFBIZ-10741: - I reopen OFBIZ-9774 for that. > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Priya Sharma >Priority: Major > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729079#comment-16729079 ] Jacques Le Roux commented on OFBIZ-10741: - Well spoted Priya, When you remove the hashCode in ProductConfigWrapper added with OFBIZ-9774 the problem is gone. It does not mean that it's the right solution. Obviously a hash code should exist but this implementation is not right one. > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Priya Sharma >Priority: Major > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729012#comment-16729012 ] Jacques Le Roux commented on OFBIZ-10741: - Priya, You said bq. maybe this issue is not related to (OFBIZ-10536) I guess you mean " maybe this issue is related to (OFBIZ-10536)"? > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Priya Sharma >Priority: Major > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10750) Umbrella issue for misc. issues in form widget date-time field
[ https://issues.apache.org/jira/browse/OFBIZ-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10750: Description: It's hard to keep tracks of somehow related issues with > Umbrella issue for misc. issues in form widget date-time field > -- > > Key: OFBIZ-10750 > URL: https://issues.apache.org/jira/browse/OFBIZ-10750 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > It's hard to keep tracks of somehow related issues with -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10750) Umbrella issue for misc. issues in form widget date-time field
[ https://issues.apache.org/jira/browse/OFBIZ-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10750: Description: It's hard to keep tracks of somehow related issues with date-time field in form widget, this issue is just for that. Please link any issue you know is related, even losely (as OFBIZ-6734 for instance) (was: It's hard to keep tracks of somehow related issues with ) > Umbrella issue for misc. issues in form widget date-time field > -- > > Key: OFBIZ-10750 > URL: https://issues.apache.org/jira/browse/OFBIZ-10750 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > It's hard to keep tracks of somehow related issues with date-time field in > form widget, this issue is just for that. Please link any issue you know is > related, even losely (as OFBIZ-6734 for instance) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10750) Umbrella issue for misc. issues in form widget date-time field
Jacques Le Roux created OFBIZ-10750: --- Summary: Umbrella issue for misc. issues in form widget date-time field Key: OFBIZ-10750 URL: https://issues.apache.org/jira/browse/OFBIZ-10750 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Jacques Le Roux Fix For: Upcoming Branch -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10118) Update multifex theme as per new markup
[ https://issues.apache.org/jira/browse/OFBIZ-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-10118: - Attachment: (was: Screenshot 2018-12-26 at 4.16.28 PM.png) > Update multifex theme as per new markup > --- > > Key: OFBIZ-10118 > URL: https://issues.apache.org/jira/browse/OFBIZ-10118 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Deepak Dixit >Assignee: Parakh Maheshwari >Priority: Major > Attachments: OFBIZ-10118_Body.patch, OFBIZ-10118_Footer.patch, > OFBIZ-10118_HEADER.patch > > > As we are updating UX of ecommerce site, this breaks the multifex them of > ecommerce. > Need to update css rule of multiflex theme as per new markup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10118) Update multifex theme as per new markup
[ https://issues.apache.org/jira/browse/OFBIZ-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-10118: - Attachment: Screenshot 2018-12-26 at 4.16.28 PM.png > Update multifex theme as per new markup > --- > > Key: OFBIZ-10118 > URL: https://issues.apache.org/jira/browse/OFBIZ-10118 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Deepak Dixit >Assignee: Parakh Maheshwari >Priority: Major > Attachments: OFBIZ-10118_Body.patch, OFBIZ-10118_Footer.patch, > OFBIZ-10118_HEADER.patch > > > As we are updating UX of ecommerce site, this breaks the multifex them of > ecommerce. > Need to update css rule of multiflex theme as per new markup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728967#comment-16728967 ] Jacques Le Roux commented on OFBIZ-10741: - Thanks Priya, looking forward... > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Priya Sharma >Priority: Major > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10741) Blank page is displayed on ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728883#comment-16728883 ] Jacques Le Roux edited comment on OFBIZ-10741 at 12/26/18 10:04 AM: Hi Jacques, I did notice this log, there is some issue in the hashCode method, which was related to OFBIZ-9774 I am looking into the cause of the issue, will revert back to you once I reach a conclusion. Just to update, maybe this issue is not related to (OFBIZ-10536) As this issue exists only for configurable products, like [https://demo-trunk.ofbiz.apache.org/ecommerce/configurable-pc-PC001-p] [https://demo-trunk.ofbiz.apache.org/ecommerce/pizza-PIZZA-p] was (Author: priya.sharma.9362): Hi Jacques, I did notice this log, there is some issue in the hashCode method, which was related to OFBIZ-9774 I am looking into the cause of the issue, will revert back to you once I reach a conclusion. Just to update, maybe this issue is not related to (https://issues.apache.org/jira/browse/OFBIZ-10536) As this issue exists only for configurable products, like [https://demo-trunk.ofbiz.apache.org/ecommerce/configurable-pc-PC001-p] [https://demo-trunk.ofbiz.apache.org/ecommerce/pizza-PIZZA-p] > Blank page is displayed on ecommerce > > > Key: OFBIZ-10741 > URL: https://issues.apache.org/jira/browse/OFBIZ-10741 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Priya Sharma >Priority: Major > Attachments: 1-Enchiladas.png, 2-BlankPage.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > # Under Feature Products section, click on product Enchiladas (Please refer > attachment: 1-Enchiladas) > Or open URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p] > Actual: Blank page is displayed (Please refer attachment: 2-BlankPage) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10732) Refactor boolean returns for TemporalExpression methods
[ https://issues.apache.org/jira/browse/OFBIZ-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10732. - No more instances, hence closing. > Refactor boolean returns for TemporalExpression methods > > > Key: OFBIZ-10732 > URL: https://issues.apache.org/jira/browse/OFBIZ-10732 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10732.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10732) Refactor boolean returns for TemporalExpression methods
[ https://issues.apache.org/jira/browse/OFBIZ-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728932#comment-16728932 ] Aditya Sharma commented on OFBIZ-10732: --- done for trunk at R1849742. > Refactor boolean returns for TemporalExpression methods > > > Key: OFBIZ-10732 > URL: https://issues.apache.org/jira/browse/OFBIZ-10732 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10732.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728930#comment-16728930 ] Aditya Sharma commented on OFBIZ-10725: --- Improves code in methods: isPrimaryKey() of GenericEntity hasNext() and hasPrevious() of EntityListIterator isValueActive() of EntityUtil Additional change: Improved return for getStartIndexFromViewIndex() method in EntityUtil. Instead of using if-else block, a ternary operator is used for improving readability. Done for trunk at R1849741. > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
