[jira] [Updated] (OFBIZ-11000) Integrate birt functionalities into the bi component
[ https://issues.apache.org/jira/browse/OFBIZ-11000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11000: - Description: Per discussion in dev@. See [https://ofbiz.markmail.org/search/?q=bi%2Fbirt+integration#query:bi%2Fbirt%20integration+page:1+mid:mw4vyqfihtv3qgfb+state:results] or [[DISCUSSION] bi/birt component integration|https://lists.apache.org/thread.html/7f7db5645bba8b9de3a0189356300afd0d7651646671ad782b0a557f@%3Cdev.ofbiz.apache.org%3E] (was: Per discussion in dev@. See https://ofbiz.markmail.org/search/?q=bi%2Fbirt+integration#query:bi%2Fbirt%20integration+page:1+mid:mw4vyqfihtv3qgfb+state:results) > Integrate birt functionalities into the bi component > > > Key: OFBIZ-11000 > URL: https://issues.apache.org/jira/browse/OFBIZ-11000 > Project: OFBiz > Issue Type: Improvement > Components: bi, birt >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: birt, dwh, refactor > > Per discussion in dev@. See > [https://ofbiz.markmail.org/search/?q=bi%2Fbirt+integration#query:bi%2Fbirt%20integration+page:1+mid:mw4vyqfihtv3qgfb+state:results] > or [[DISCUSSION] bi/birt component > integration|https://lists.apache.org/thread.html/7f7db5645bba8b9de3a0189356300afd0d7651646671ad782b0a557f@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829983#comment-16829983 ] Pierre Smits commented on OFBIZ-10990: -- No worries, Swapnil, I value each and every input. Could you share your thoughts on [[DISCUSSION] bi/birt component integration|https://lists.apache.org/thread.html/7f7db5645bba8b9de3a0189356300afd0d7651646671ad782b0a557f@%3Cdev.ofbiz.apache.org%3E] ? > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829976#comment-16829976 ] Swapnil Shah commented on OFBIZ-10990: -- I am not sure if i would be able to browse through all the tix history anytime soon. Please feel free to ignore and move on if raised issues are already being handled one way or other. I just happened to stumble upon this ticket and shared few thoughts from the targetted end user perspective on BI and reporting . > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9275) Add a Gradle task to svn update all plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9275. -- Resolution: Won't Do Assignee: Jacques Le Roux This is not necessary > Add a Gradle task to svn update all plugins > --- > > Key: OFBIZ-9275 > URL: https://issues.apache.org/jira/browse/OFBIZ-9275 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > When you svn update the framework, unlike for svn:externals, it does not > update the plugins because it's an embedded working copy. So I have tried > that w/o success so far: > {code} > Index: build.gradle > === > --- build.gradle (revision 1788020) > +++ build.gradle (working copy) > @@ -17,6 +17,7 @@ > * under the License. > */ > import at.bxm.gradleplugins.svntools.tasks.SvnCheckout > +import at.bxm.gradleplugins.svntools.tasks.SvnUpdate > import org.apache.tools.ant.filters.ReplaceTokens > /* > @@ -774,6 +775,14 @@ > } > } > +task updateAllPluginsSource(group: ofbizPlugin, > +description: 'Update all plugins from source control.') { > + > +task updatePluginsFromSvn(type: SvnUpdate) { > +workspaceDir = "${pluginsDir}" > +} > +} > + > // == Clean up tasks == > task cleanCatalina(group: cleanupGroup, description: 'Clean Catalina data in > runtime/catalina/work') { > doLast { delete "${rootDir}/runtime/catalina/work" } > {code} > The doc is here > https://github.com/martoe/gradle-svntools-plugin/blob/master/docs/SvnUpdate.md > https://github.com/martoe/gradle-svntools-plugin/blob/master/src/main/groovy/at/bxm/gradleplugins/svntools/tasks/SvnUpdate.groovy > BTW somehow related there is no Gradle svn plugin way to get the status. So > you have to move to the plugins directory. A bit tedious, I propose a > pluginsStatus.bat script for that (could be in tools but I'll move it in > another branch) > {code} > @echo off > cd plugins > svn st > cd .. > {code} > If we agree I can add the same pluginsStatus.sh -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829594#comment-16829594 ] Jacques Le Roux commented on OFBIZ-10725: - Thanks Guys, I intend to do some also... > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829422#comment-16829422 ] Swapnil M Mane commented on OFBIZ-10145: Thanks, everyone for detailed discussion. Loved your work [~soledad] ! :) Here are my inputs and details on minor issue I faced +*Issue faced:*+ The whereis -b $1 | grep / command in my machine is giving following error {code:java} whereis: illegal option -- b usage: whereis program [...]{code} I am using Mac, here are details of my OS *macOS Mojave* *Version 10.14.3 (18D109)* I can understand that we used -b to search only for binaries in the script. I also checked the manual of whereis command on mac using command {code:java} man whereis{code} It also don't show -b option for whereis command on mac. (I know it generally works for Linux based OS). So, to fix this, I removed the -b option from whereis command in script. After this everything works like charm for me. Is anybody faced the same issue on the Mac? +*Suggestion/Improvement:*+ When I run the script the first time (after above fix), it starts downloading gradle. Now before completing the download, I mistakenly stop the downloading by terminating the download process. After this, I run the *init-gradle-wrapper-trunk-and-18.sh* script *again*. But this time I got following error {code:java} Archive: gradle-5.0-bin.zip End-of-central-directory signature not found. Either this file is not a zipfile, or it constitutes one disk of a multi-part archive. In the latter case the central directory and zipfile comment will be found on the last disk(s) of this archive. unzip: cannot find zipfile directory in one of gradle-5.0-bin.zip or gradle-5.0-bin.zip.zip, and cannot find gradle-5.0-bin.zip.ZIP, period. init-gradle-wrapper-trunk-and-18.sh: line 63: ./runtime/tmp/gradle-5.0/bin/gradle: No such file or directory{code} Since my *gradle-5.0-bin.zip* was corrupted because I stoped the download process in between. The command {code:java} unzip gradle-5.0-bin.zip{code} throws the above error. To fix this, I removed the corrupted file and run the script again,and everything worked as expected. We can do an improvement here, after running the command *unzip gradle-5.0-bin.zip* If it fails, we can show the message to the user to remove the corrupted file and run the script again. Here is suggested code improvement {code:java} unzip $GRADLE_ZIP_RELEASE; if [ $? -eq 0 ]; then cd ../.. ./runtime/tmp/$GRADLE_RELEASE/bin/$CMD_INIT_WRAPPER else echo "\nThe gradle-5.0-bin.zip file is corrupted.\nPlease remove this file from $OFBIZ_HOME/runtime/tmp location and run the script again." fi{code} Please feel free to share your thoughts on this. Nice work [~soledad] , thanks again! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11000) Integrate birt functionalities into the bi component
Pierre Smits created OFBIZ-11000: Summary: Integrate birt functionalities into the bi component Key: OFBIZ-11000 URL: https://issues.apache.org/jira/browse/OFBIZ-11000 Project: OFBiz Issue Type: Improvement Components: bi, birt Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pierre Smits Assignee: Pierre Smits Per discussion in dev@. See https://ofbiz.markmail.org/search/?q=bi%2Fbirt+integration#query:bi%2Fbirt%20integration+page:1+mid:mw4vyqfihtv3qgfb+state:results -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10999) Have all @deprecated show when it will be removed from the repo
Pierre Smits created OFBIZ-10999: Summary: Have all @deprecated show when it will be removed from the repo Key: OFBIZ-10999 URL: https://issues.apache.org/jira/browse/OFBIZ-10999 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Pierre Smits Currently we don't provide any information on functions with @deprecated when they will be removed from the repo. I suggest we add a 'Will be removed at ' + a designator for a release branch after the latest available to the @deprecated, when a function is to be deprecated. As an example: * Currently latest available branch is: release18.12 * if a contributor deprecates a function now, the statement would be: @deprecated Will be removed at release branch 20.12 This would leave adopters with enough time to plan for migrations, and at the moment the new branch is cut contributors can easily find what needs to be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829234#comment-16829234 ] Pierre Smits commented on OFBIZ-10990: -- It seems to me that we're digressing (too much?) here into areas already covered by other - open - tickets. My fault as well. See latest list at [1]. I suggest we take further comments for each specific aspect forward in the appropriate one. And for a more generic discussion follow it through on dev. [1] [https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20component%20%3D%20bi%20and%20status%20!%3D%20closed] > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829275#comment-16829275 ] Swapnil M Mane commented on OFBIZ-10725: BTW [~jacques.le.roux], I like the regexp! :) > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829228#comment-16829228 ] Pierre Smits commented on OFBIZ-10990: -- {code:java} I think we usually model and identify the styles and assortment through virtual/variant pairing via ProductAssoc https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=ProductAssoc (where productAssocTypeId='PRODUCT_VARIANT'). Here the virtual product could contain the styles and all the variants (based on their standard features i.e. Size/Color/Taste/Material etc.) as assortment. e.g, https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductAssoc?productId=SAUCE https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductAssoc?productId=GZ-1006 {code} Variants of a virtual is already catered for in the ProductDimension entity, as they have their own natural key (productId). The steps to reproduce in demo-trunk: # initialise the DWH in the bi component; # see the result in [https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=ProductDimension] As for adding feature fields (and equivalents) to the ProductDimension entity: I suggest to read up on [1] and the various differentiators (GITN, UPC, EAN, etc.). This would require a complete redesign of the entity. It is then better to have a SkuDimension to cater for this. [1] [https://en.wikipedia.org/wiki/Stock_keeping_unit] > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829207#comment-16829207 ] Pierre Smits commented on OFBIZ-10990: -- {noformat} Later, if required can add 'Hour' as next granular level below Date in it{noformat} That is not advisable, because it would mean having (at first) to inject the 24 records per date into the table, and later on (when we tend to cater to adopters requirements of having minutes in as well) 1.440 records per date. The DateDimension, now, would contain 365/366 records per annum, with the addition of the hour that would balloon to 8.760/8.784 records per year. And for the addition of minutes in that table this would even be more staggering: 525.600/527.040 records per annum. Please consider page 83 of The Data Warehouse Toolkit. > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829210#comment-16829210 ] Swapnil Shah commented on OFBIZ-10990: -- {quote} My point being: why not bring it back in the olap db to one single entity that is commonly understood, because most elements are hierarchical to the country? {quote} I would not be very particular about naming convention at this point of time as long as we are able to capture the market segmentation based on the different geographies. For a typical global business, the sales hierarchy based on the geographic market segmentation might even start from above the country level like APAC,EMEA,AMER etc. and goes down till City or zip code level. > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829196#comment-16829196 ] Swapnil Shah edited comment on OFBIZ-10990 at 4/29/19 12:19 PM: {quote}..But where should the style and assortment come from? Can you reference entities from [https://demo-trunk.ofbiz.apache.org/webtools/control/entityref] ? That will give a clue regarding determining what is achievable. {quote} I think we usually model and identify the styles and assortment through virtual/variant pairing via ProductAssoc [https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=ProductAssoc] (where productAssocTypeId='PRODUCT_VARIANT'). Here the virtual product could contain the styles and all the variants (based on their standard features i.e. Size/Color/Taste/Material etc.) as assortment. e.g, https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductAssoc?productId=SAUCE [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductAssoc?productId=GZ-1006] was (Author: swash78): {quote} ..But where should the style and assortment come from? Can you reference entities from [https://demo-trunk.ofbiz.apache.org/webtools/control/entityref] ? That will give a clue regarding determining what is achievable. {quote} I think we usually model and identify the styles and assortment through virtual/variant pairing via ProductAssoc [https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=ProductAssoc] (where productAssocTypeId='PRODUCT_VARIANT'). Here the virtual product could contain the styles and all the variants (based on their standard features i.e. Size/Color/Taste/Material etc.) as assortment. e.g, [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductAssoc?productId=SAUCE ] [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductAssoc?productId=GZ-1006] > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829196#comment-16829196 ] Swapnil Shah commented on OFBIZ-10990: -- {quote} ..But where should the style and assortment come from? Can you reference entities from [https://demo-trunk.ofbiz.apache.org/webtools/control/entityref] ? That will give a clue regarding determining what is achievable. {quote} I think we usually model and identify the styles and assortment through virtual/variant pairing via ProductAssoc [https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=ProductAssoc] (where productAssocTypeId='PRODUCT_VARIANT'). Here the virtual product could contain the styles and all the variants (based on their standard features i.e. Size/Color/Taste/Material etc.) as assortment. e.g, [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductAssoc?productId=SAUCE ] [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductAssoc?productId=GZ-1006] > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10705) Replace DateFormat and Simple DateFormat by FastDateFormat
[ https://issues.apache.org/jira/browse/OFBIZ-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829185#comment-16829185 ] Pierre Smits commented on OFBIZ-10705: -- Of course I am, Jacques. Why so serious But not so kiddingly: why do we have DateFormat, Simple DateFormat and FastDateFormat? And how does the 'FastDateFormat' differentiate itself from the other kinds that it requires the addition of 'Fast' > Replace DateFormat and Simple DateFormat by FastDateFormat > --- > > Key: OFBIZ-10705 > URL: https://issues.apache.org/jira/browse/OFBIZ-10705 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Kumar Rahul >Priority: Minor > > This is a performance improvement and was suggested by [Adrian 6 years > ago|https://markmail.org/message/zbuaef7aaueij5w2] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829184#comment-16829184 ] Swapnil Shah commented on OFBIZ-10990: -- {quote} {noformat} Time Dimension - can help in getting financial/merchandising calendars with Years, Season, quarters, weeks , days etc. for different views. {noformat} We already have a date dimension catering for year, week, days. This dimension can, of course, be extended with missing elements (like season, trimesters, etc.) As for time. yes we can add a static time dimension having are all time increments between 00:00:00 and 23:59:59. If only using the minute discriminator this would be a table consisting of 1440 records. Businesses are not that much interested in sales/purchases/etc. per second, whereas IT more often is (transactions per second), but at least the time dimension will allow doing that in fact tables and star schemas. Businesses are interested in stuff like: how do our sales in the morning compare to sales in the afternoon, and how do our morning sales trend over time I will add a new ticket for this. {quote} If we already have Date Dimension then i guess no need to add new Time Dimension (if needed this itself can be relablled as Time Dimension). Later, if required can add 'Hour' as next granular level below Date in it. > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10966) JSON entity data import and export utility
[ https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829191#comment-16829191 ] Nicolas Malin commented on OFBIZ-10966: --- It's a good idea to extend import/export to json. I suggest to manage one service and analyse the content type. how you imagine to manage action element for import (create-update, create-replace, create, delete) ? > JSON entity data import and export utility > -- > > Key: OFBIZ-10966 > URL: https://issues.apache.org/jira/browse/OFBIZ-10966 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Jayansh Shinde >Priority: Minor > > Currently, we support import/export entity data in XML format. > Nowadays JSON is widely used in industry, we can have support for JSON > format which looks quite similar to XML support. > Here is example of XML data and it's JSON version > {code:java} > > {code} > {code:java} > {“Party”: > {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}} > {code} > > *Design Proposal* > We can write *entityImportJson* and *entityImportDirJson* services for > importing JSON from screen and directory respectively. > And the *entityExportAllJson* service for exporting entity data in JSON. > > *Import Design* > The import service will perform following operations: > 1.) Validate the input JSON data (I am in process of exploring the way for > this) > 2.) On successful validation, convert JSON to OFBiz's entity model > (GenericValue) > 3.) The GenericValue will be inserted in database by some handler class for > e.g we can write JsonDataHandler, it will convert given JSON to > List, and finally write it to database (Similar pattern is used > in XML import). > > *Export Design* > Based on existing XML pattern the writeXmlText method of GenericEntity class > write the exported data in XML format. > In the similar way, we can implement writeJsonText to export data in JSON > format. > Please free feel to share your thought. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10705) Replace DateFormat and Simple DateFormat by FastDateFormat
[ https://issues.apache.org/jira/browse/OFBIZ-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829190#comment-16829190 ] Michael Brohl commented on OFBIZ-10705: --- Still kidding? Please have a look where DateFormat, SimpleDateFormat and FastDateFormat is coming from and ask them these questions... > Replace DateFormat and Simple DateFormat by FastDateFormat > --- > > Key: OFBIZ-10705 > URL: https://issues.apache.org/jira/browse/OFBIZ-10705 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Kumar Rahul >Priority: Minor > > This is a performance improvement and was suggested by [Adrian 6 years > ago|https://markmail.org/message/zbuaef7aaueij5w2] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10705) Replace DateFormat and Simple DateFormat by FastDateFormat
[ https://issues.apache.org/jira/browse/OFBIZ-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829182#comment-16829182 ] Jacques Le Roux commented on OFBIZ-10705: - You are kidding Pierre, right? > Replace DateFormat and Simple DateFormat by FastDateFormat > --- > > Key: OFBIZ-10705 > URL: https://issues.apache.org/jira/browse/OFBIZ-10705 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Kumar Rahul >Priority: Minor > > This is a performance improvement and was suggested by [Adrian 6 years > ago|https://markmail.org/message/zbuaef7aaueij5w2] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829175#comment-16829175 ] Pierre Smits commented on OFBIZ-10990: -- As far as I can tell the field brandName is included in the Product entity. That can be added quite easily. But where should the style and assortment come from? Can you reference entities from [https://demo-trunk.ofbiz.apache.org/webtools/control/entityref] ? That will give a clue regarding determining what is achievable. > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829158#comment-16829158 ] Swapnil Shah commented on OFBIZ-10990: -- {quote} Regarding the other points: {noformat} Product Dimesion - Can help in getting the Brand, Style, Assortments, Component level info for different views.{noformat} For sure we can add more dimensions (like the ones suggested). The thing to keep in mind here is whether a product can be sold under different brands, styles, etc) or not. I don't think we can dictate one approach here, but we have to start somewhere. And - as always - our adopters can (and will) extend entity-packages and individual entities as they see fit. {quote} Here didn't mean to necessarily add the new dimensions for Brand/Style/Assortment etc. We could rather consider them as different possible views out of Product Dimension itself (as the above mentioned details can be very well captured through it at product level). For example. a sales managers who may like to track the sales performance for products by Brands.or by Style can possibly do so by traversing through the product dimension itself. > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10698) Improve german translations for the hr component
[ https://issues.apache.org/jira/browse/OFBIZ-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10698: -- Affects Version/s: Trunk > Improve german translations for the hr component > > > Key: OFBIZ-10698 > URL: https://issues.apache.org/jira/browse/OFBIZ-10698 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-10698_HR_translation_de.patch > > > During the tests for OFBIZ-10326 I noticed several UI labels which were not > translated. This should be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10698) Improve german translations for the hr component
[ https://issues.apache.org/jira/browse/OFBIZ-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10698. - Resolution: Implemented Fix Version/s: Upcoming Branch Implemented in trunk r1858362 > Improve german translations for the hr component > > > Key: OFBIZ-10698 > URL: https://issues.apache.org/jira/browse/OFBIZ-10698 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10698_HR_translation_de.patch > > > During the tests for OFBIZ-10326 I noticed several UI labels which were not > translated. This should be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10979) Example tab is displayed twice in order tab section
[ https://issues.apache.org/jira/browse/OFBIZ-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Sharma updated OFBIZ-10979: -- Component/s: order > Example tab is displayed twice in order tab section > --- > > Key: OFBIZ-10979 > URL: https://issues.apache.org/jira/browse/OFBIZ-10979 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Prakhar Kumar >Priority: Trivial > Fix For: Trunk > > Attachments: OFBIZ-10979.docx > > > *Step to reproduce* > 1. Open - https://demo-trunk.ofbiz.apache.org/catalog/control/main > 2. Navigate to order tab. > 3. Click on plus icon > *Actual Result:* Example tab is displayed twice. > Order status spelling is not correct. > *Screen print attached* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10979) Example tab is displayed twice in order tab section
[ https://issues.apache.org/jira/browse/OFBIZ-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Sharma updated OFBIZ-10979: -- Affects Version/s: Trunk > Example tab is displayed twice in order tab section > --- > > Key: OFBIZ-10979 > URL: https://issues.apache.org/jira/browse/OFBIZ-10979 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Prakhar Kumar >Priority: Trivial > Fix For: Trunk > > Attachments: OFBIZ-10979.docx > > > *Step to reproduce* > 1. Open - https://demo-trunk.ofbiz.apache.org/catalog/control/main > 2. Navigate to order tab. > 3. Click on plus icon > *Actual Result:* Example tab is displayed twice. > Order status spelling is not correct. > *Screen print attached* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10192) German translation correction (CLIENT)
[ https://issues.apache.org/jira/browse/OFBIZ-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829152#comment-16829152 ] Michael Brohl commented on OFBIZ-10192: --- [~iwolf] can you give us the purpose to this change request? > German translation correction (CLIENT) > -- > > Key: OFBIZ-10192 > URL: https://issues.apache.org/jira/browse/OFBIZ-10192 > Project: OFBiz > Issue Type: Improvement >Reporter: Ingo Wolfmayr >Assignee: Michael Brohl >Priority: Trivial > Attachments: ofbiz.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10813) Improve Accounting -> Financial Account container structure
[ https://issues.apache.org/jira/browse/OFBIZ-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10813. - Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Dennis, this is done in trunk r1858361. > Improve Accounting -> Financial Account container structure > --- > > Key: OFBIZ-10813 > URL: https://issues.apache.org/jira/browse/OFBIZ-10813 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10813_FinAccountScreens.patch > > > There were again some structural differences found, this time in Accounting > -> Financial Account. > I treated them like I did Accounting AR -> Main in OFBIZ-10469 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[ https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829128#comment-16829128 ] Michael Brohl commented on OFBIZ-10187: --- This is fixed in trunk r1858352 release17.12 r1858354 release 18.12 r1858353 I'm not sure about backporting to 16.11 and added a valid patch for this. Devs, please check and give feedback if this should be backported to 16.11 also, thanks! > OWASP sanitizer breaks proper rendering of HTML code > > > Key: OFBIZ-10187 > URL: https://issues.apache.org/jira/browse/OFBIZ-10187 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch > 18.12 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Critical > Attachments: OFBIZ-10187_Sanitizer.patch, > OFBIZ-10187_Sanitizer_New.patch > > > The current implementation of the sanitizer breaks the proper rendering of > html code. In our case, class attributes are stripped from the html content. > Example: > {code:java} > > src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" > alt="" /> > > > Lorem ipsum dolor sit amet > At vero eos et accusam et justo > > Lorem ipsum dolor sit amet, consetetur > sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea > takimata sanctus est Lorem ipsum dolor sit amet. > > href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen > > > {code} > will be rendered to > {code:java} > > src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" > alt="" /> > > > Lorem ipsum dolor sit amet > At vero eos et accusam et justo > > Lorem ipsum dolor sit amet, consetetur > sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea > takimata sanctus est Lorem ipsum dolor sit amet. > > href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen > > > {code} > I do not see any reason to not allow class attributes in html code. There > might be other problems with these rules but this is a showstopper. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[ https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10187: -- Labels: backport-needed (was: ) > OWASP sanitizer breaks proper rendering of HTML code > > > Key: OFBIZ-10187 > URL: https://issues.apache.org/jira/browse/OFBIZ-10187 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch > 18.12 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Critical > Labels: backport-needed > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-10187_Sanitizer.patch, > OFBIZ-10187_Sanitizer_16.11.patch, OFBIZ-10187_Sanitizer_New.patch > > > The current implementation of the sanitizer breaks the proper rendering of > html code. In our case, class attributes are stripped from the html content. > Example: > {code:java} > > src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" > alt="" /> > > > Lorem ipsum dolor sit amet > At vero eos et accusam et justo > > Lorem ipsum dolor sit amet, consetetur > sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea > takimata sanctus est Lorem ipsum dolor sit amet. > > href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen > > > {code} > will be rendered to > {code:java} > > src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" > alt="" /> > > > Lorem ipsum dolor sit amet > At vero eos et accusam et justo > > Lorem ipsum dolor sit amet, consetetur > sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea > takimata sanctus est Lorem ipsum dolor sit amet. > > href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen > > > {code} > I do not see any reason to not allow class attributes in html code. There > might be other problems with these rules but this is a showstopper. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[ https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10187: -- Fix Version/s: 18.12.01 17.12.01 > OWASP sanitizer breaks proper rendering of HTML code > > > Key: OFBIZ-10187 > URL: https://issues.apache.org/jira/browse/OFBIZ-10187 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch > 18.12 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Critical > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-10187_Sanitizer.patch, > OFBIZ-10187_Sanitizer_16.11.patch, OFBIZ-10187_Sanitizer_New.patch > > > The current implementation of the sanitizer breaks the proper rendering of > html code. In our case, class attributes are stripped from the html content. > Example: > {code:java} > > src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" > alt="" /> > > > Lorem ipsum dolor sit amet > At vero eos et accusam et justo > > Lorem ipsum dolor sit amet, consetetur > sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea > takimata sanctus est Lorem ipsum dolor sit amet. > > href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen > > > {code} > will be rendered to > {code:java} > > src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" > alt="" /> > > > Lorem ipsum dolor sit amet > At vero eos et accusam et justo > > Lorem ipsum dolor sit amet, consetetur > sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea > takimata sanctus est Lorem ipsum dolor sit amet. > > href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen > > > {code} > I do not see any reason to not allow class attributes in html code. There > might be other problems with these rules but this is a showstopper. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[ https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10187: -- Attachment: OFBIZ-10187_Sanitizer_16.11.patch > OWASP sanitizer breaks proper rendering of HTML code > > > Key: OFBIZ-10187 > URL: https://issues.apache.org/jira/browse/OFBIZ-10187 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch > 18.12 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Critical > Attachments: OFBIZ-10187_Sanitizer.patch, > OFBIZ-10187_Sanitizer_16.11.patch, OFBIZ-10187_Sanitizer_New.patch > > > The current implementation of the sanitizer breaks the proper rendering of > html code. In our case, class attributes are stripped from the html content. > Example: > {code:java} > > src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" > alt="" /> > > > Lorem ipsum dolor sit amet > At vero eos et accusam et justo > > Lorem ipsum dolor sit amet, consetetur > sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea > takimata sanctus est Lorem ipsum dolor sit amet. > > href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen > > > {code} > will be rendered to > {code:java} > > src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" > alt="" /> > > > Lorem ipsum dolor sit amet > At vero eos et accusam et justo > > Lorem ipsum dolor sit amet, consetetur > sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea > takimata sanctus est Lorem ipsum dolor sit amet. > > href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen > > > {code} > I do not see any reason to not allow class attributes in html code. There > might be other problems with these rules but this is a showstopper. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10705) Replace DateFormat and Simple DateFormat by FastDateFormat
[ https://issues.apache.org/jira/browse/OFBIZ-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829124#comment-16829124 ] Pierre Smits commented on OFBIZ-10705: -- Is there also a SlowDateFormat? > Replace DateFormat and Simple DateFormat by FastDateFormat > --- > > Key: OFBIZ-10705 > URL: https://issues.apache.org/jira/browse/OFBIZ-10705 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Kumar Rahul >Priority: Minor > > This is a performance improvement and was suggested by [Adrian 6 years > ago|https://markmail.org/message/zbuaef7aaueij5w2] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10979) Example tab is displayed twice in order tab section
[ https://issues.apache.org/jira/browse/OFBIZ-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829106#comment-16829106 ] Pierre Smits commented on OFBIZ-10979: -- Please state affected version(s)/branche(s) and component(s) that are applicable. > Example tab is displayed twice in order tab section > --- > > Key: OFBIZ-10979 > URL: https://issues.apache.org/jira/browse/OFBIZ-10979 > Project: OFBiz > Issue Type: Bug >Reporter: Ashish Sharma >Assignee: Prakhar Kumar >Priority: Trivial > Fix For: Trunk > > Attachments: OFBIZ-10979.docx > > > *Step to reproduce* > 1. Open - https://demo-trunk.ofbiz.apache.org/catalog/control/main > 2. Navigate to order tab. > 3. Click on plus icon > *Actual Result:* Example tab is displayed twice. > Order status spelling is not correct. > *Screen print attached* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10705) Replace DateFormat and Simple DateFormat by FastDateFormat
[ https://issues.apache.org/jira/browse/OFBIZ-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829107#comment-16829107 ] Michael Brohl commented on OFBIZ-10705: --- What do you mean by "name change"? The proposal is to not use DateFormat and Simple DateFormat but use FastDateFormat from the commons.lang.time package. > Replace DateFormat and Simple DateFormat by FastDateFormat > --- > > Key: OFBIZ-10705 > URL: https://issues.apache.org/jira/browse/OFBIZ-10705 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Kumar Rahul >Priority: Minor > > This is a performance improvement and was suggested by [Adrian 6 years > ago|https://markmail.org/message/zbuaef7aaueij5w2] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10375) Issues with Recurrence Info ID at Edit Invoice
[ https://issues.apache.org/jira/browse/OFBIZ-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829103#comment-16829103 ] Pierre Smits commented on OFBIZ-10375: -- It seems to me that this should not exist in the Invoice entity. Any invoice can occur only once. See meaning of recurrence below {noformat} noun: recurrence; plural noun: recurrences the fact of occurring again.{noformat} > Issues with Recurrence Info ID at Edit Invoice > -- > > Key: OFBIZ-10375 > URL: https://issues.apache.org/jira/browse/OFBIZ-10375 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/ap/control/updateInvoice >Reporter: Aayush jain >Priority: Major > Attachments: Screenshot from 2018-04-28 11-13-03.png > > > Steps: > 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/updateInvoice > 2. Navigate to Edit Invoice > 3. Enter Recurrence Info ID like ABCTEST001 > 4. Check on Update button > Actual Result: > Throwing an exception error, kindly refer attachment for the same. > Expected Result: > An exception should be handled properly and the proper error message should > be displayed on the screen > Note: > Recurrence Info ID is Key of another table, so we can not enter any kind of > ramdom value. > Thanks! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9978) Upgrade jQuery 1.11.0 to jQuery 3.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829104#comment-16829104 ] Aditya Sharma commented on OFBIZ-9978: -- Hi Jacques, Yes, We can close it for now. > Upgrade jQuery 1.11.0 to jQuery 3.2.1 > - > > Key: OFBIZ-9978 > URL: https://issues.apache.org/jira/browse/OFBIZ-9978 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > Attachments: Image 001.png, Image 002.png, Image 003.png, Image > 007.png, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, > OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, > OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, > OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, > OFBIZ-9978_plugins.patch, OFBIZ-9978_pluginswithReadmore2.2.0.patch, > OFBIZ-9978withReadmore2.2.0.patch, Readmore.tar.gz, Screenshot-2017-11-26 > OFBiz Example .png, images.tar.gz, jquery-jgrowl.tar.gz > > > Migration Steps: > 1. Upgrade JQuery 1.11.0 to 3.2.1 > * Remove JQuery 1.x & JQuery migrate 1.x > * Add JQuery 3.2.1 & JQuery migrate 3.0.0 > * Rectify any broken code and plugin > 2. Upgrade all the JQuery plugins to latest > 3. Remove JQuery migrate 3.0.0 & rectify any broken code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829091#comment-16829091 ] Aditya Sharma commented on OFBIZ-10725: --- Hi [~jacques.le.roux] , Thanks for looking into it. It's in my list. I am really occupied these days but I intend to get these tasks done asap.I will resume soon. > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9978) Upgrade jQuery 1.11.0 to jQuery 3.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829092#comment-16829092 ] Jacques Le Roux commented on OFBIZ-9978: Hi Aditya, So if I'm not wrong remains here only OFBIZ-10093, right? > Upgrade jQuery 1.11.0 to jQuery 3.2.1 > - > > Key: OFBIZ-9978 > URL: https://issues.apache.org/jira/browse/OFBIZ-9978 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > Attachments: Image 001.png, Image 002.png, Image 003.png, Image > 007.png, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, > OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, > OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, > OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, > OFBIZ-9978_plugins.patch, OFBIZ-9978_pluginswithReadmore2.2.0.patch, > OFBIZ-9978withReadmore2.2.0.patch, Readmore.tar.gz, Screenshot-2017-11-26 > OFBiz Example .png, images.tar.gz, jquery-jgrowl.tar.gz > > > Migration Steps: > 1. Upgrade JQuery 1.11.0 to 3.2.1 > * Remove JQuery 1.x & JQuery migrate 1.x > * Add JQuery 3.2.1 & JQuery migrate 3.0.0 > * Rectify any broken code and plugin > 2. Upgrade all the JQuery plugins to latest > 3. Remove JQuery migrate 3.0.0 & rectify any broken code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10964) Nested Entity Data Loading : Provide a feature for nested entity loading
[ https://issues.apache.org/jira/browse/OFBIZ-10964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829088#comment-16829088 ] Pierre Smits commented on OFBIZ-10964: -- Would this be a new feature? Please state component and affected version. > Nested Entity Data Loading : Provide a feature for nested entity loading > - > > Key: OFBIZ-10964 > URL: https://issues.apache.org/jira/browse/OFBIZ-10964 > Project: OFBiz > Issue Type: Improvement >Reporter: Girish Vasmatkar >Assignee: Girish Vasmatkar >Priority: Minor > > OFBiz entity data loading works in sequence and one entity load at a time. We > would want to be able to support nested entity data loading akin to what > moqui provides. > As an example, here is a demo moqui data file that demonstrate nested entity > data loading. > [https://github.com/moqui/PopCommerce/blob/master/data/PopCommerceDemoData.xml] > The feature will also enable to automatically create required (nested) entity > and associate with the parent entity. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.
[ https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10895: --- Assignee: Jacques Le Roux > Unknown request [images]; this request does not exist or cannot be called > directly. > --- > > Key: OFBIZ-10895 > URL: https://issues.apache.org/jira/browse/OFBIZ-10895 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, themes >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > This error happens in many occasions: > Inside another request (here LookupProduct) > {noformat} > 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet > |T| [[[LookupProduct(Domain:https://localhost)] Request Begun, > encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] > 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet > |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- > total:0.0,since last(Begin):0.0]] > 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet > |E| Error in request handler: > org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request > [images]; this request does not exist or cannot be called directly. > at > org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212) > [ofbiz.jar:?] > at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) > [javax.servlet-api-4.0.1.jar:4.0.1] > at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) > [javax.servlet-api-4.0.1.jar:4.0.1] > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) > [tomcat-embed-websocket-9.0.16.jar:9.0.16] > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191) > [ofbiz.jar:?] > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156) > [ofbiz.jar:?] > at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) > [javax.servlet-api-4.0.1.jar:4.0.1] > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) > [tomcat-catalina-9.0.16.jar:9.0.16] > at > org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408) > [tomcat-coyote-9.0.16.jar:9.0.16] > at > org.apache.coyote.AbstractProcessorLight.process(AbstractProcess
[jira] [Commented] (OFBIZ-10705) Replace DateFormat and Simple DateFormat by FastDateFormat
[ https://issues.apache.org/jira/browse/OFBIZ-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829081#comment-16829081 ] Pierre Smits commented on OFBIZ-10705: -- Is it still valid? Why the name change? Would it not be better to integrate the two into one, and follow best practices? I can't imagine this hasn't come up in other communities. > Replace DateFormat and Simple DateFormat by FastDateFormat > --- > > Key: OFBIZ-10705 > URL: https://issues.apache.org/jira/browse/OFBIZ-10705 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Kumar Rahul >Priority: Minor > > This is a performance improvement and was suggested by [Adrian 6 years > ago|https://markmail.org/message/zbuaef7aaueij5w2] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10660) Similar values reflecting twice on Add Action Type dropdown in Pricerule
[ https://issues.apache.org/jira/browse/OFBIZ-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10660: Fix Version/s: Upcoming Branch Component/s: framework > Similar values reflecting twice on Add Action Type dropdown in Pricerule > > > Key: OFBIZ-10660 > URL: https://issues.apache.org/jira/browse/OFBIZ-10660 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond >Reporter: Archana Asthana >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: ActionTypeDropdown.png, OFBIZ-10660.patch > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond > 2. Add the name for a new Price Rule > 3. Add Condition and go to Add Action panel > 4. Check the dropdown values under Action Type > *Actual: * > Same value reflecting twice in the dropdown ( Flat Amount Modify) > The Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10660) Similar values reflecting twice on Add Action Type dropdown in Pricerule
[ https://issues.apache.org/jira/browse/OFBIZ-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10660. --- Resolution: Fixed Thanks Archana, Prakhar, Prakhar, your patch is in trunk at revision: 1858355 I made few tests also. Anyway I can't see how it could go wrong, and I have always wondered about this behaviour :) > Similar values reflecting twice on Add Action Type dropdown in Pricerule > > > Key: OFBIZ-10660 > URL: https://issues.apache.org/jira/browse/OFBIZ-10660 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond >Reporter: Archana Asthana >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: ActionTypeDropdown.png, OFBIZ-10660.patch > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond > 2. Add the name for a new Price Rule > 3. Add Condition and go to Add Action panel > 4. Check the dropdown values under Action Type > *Actual: * > Same value reflecting twice in the dropdown ( Flat Amount Modify) > The Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829068#comment-16829068 ] Pierre Smits commented on OFBIZ-10990: -- I can't seem to edit my existing comment, so I'll state it here. There is already a ProductDimension in the entity definitions of the bi component. > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10998) Have a Time dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10998: - Labels: birt dwh (was: ) > Have a Time dimension > - > > Key: OFBIZ-10998 > URL: https://issues.apache.org/jira/browse/OFBIZ-10998 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: birt, dwh > > The component would benefit from a time dimension for future fact tables and > star schema view entities. > Per comments in OFBIZ-10990 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10998) Have a Time dimension
Pierre Smits created OFBIZ-10998: Summary: Have a Time dimension Key: OFBIZ-10998 URL: https://issues.apache.org/jira/browse/OFBIZ-10998 Project: OFBiz Issue Type: Improvement Components: bi Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pierre Smits The component would benefit from a time dimension for future fact tables and star schema view entities. Per comments in OFBIZ-10990 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10998) Have a Time dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-10998: Assignee: Pierre Smits > Have a Time dimension > - > > Key: OFBIZ-10998 > URL: https://issues.apache.org/jira/browse/OFBIZ-10998 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > > The component would benefit from a time dimension for future fact tables and > star schema view entities. > Per comments in OFBIZ-10990 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829046#comment-16829046 ] Jacques Le Roux edited comment on OFBIZ-10725 at 4/29/19 9:21 AM: -- Hi Aditya, Even if this is not functional and minor, it's delicate, thanks for all your work cleaning the code :) I was wondering if we should close here. I just had a look and using this regexp: {code:java} if \(.*\) \{\R.*return true; {code} I found * 60 matches in applications * 138 in framework * 4 in plugins I only checked the 1st two in applications and they really match (the regexp is very simple). While at it I improved 3 of the 4 in plugins (the other is in a loop) at revisions: 1858350+1858351 So let's keep it open, most if done, but if we get some spare time why not continue :) For now I guess we have bigger fishes to fry even if it's always hard to clearly define priority when it's about code. was (Author: jacques.le.roux): Hi Aditya, Even if this is not functional and minor, it's delicate, thanks for all your work cleaning the code :) I was wondering if we should close here. I just had a look and using this regexp: {code:java} if \(.*\) \{\R.*return true; {code} I found * 60 matches in applications * 138 in framework * 4 in plugins I only checked the 1st two in applications and they really match (the regexp is very simple). While at it I improved 3 of the 4 in plugins (the other is in a loop) at revision: 1858350 So let's keep it open, most if done, but if we get some spare time why not continue :) For now I guess we have bigger fishes to fry even if it's always hard to clearly define priority when it's about code. > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10660) Similar values reflecting twice on Add Action Type dropdown in Pricerule
[ https://issues.apache.org/jira/browse/OFBIZ-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828981#comment-16828981 ] Jacques Le Roux edited comment on OFBIZ-10660 at 4/29/19 9:13 AM: -- Hello [~jacques.le.roux], Yes, I have verified this change on various screens and did not find any issue. Also, I was trying to figure out the reason for the same. Regards Prakhar was (Author: prakhar.kumar): Hello [~jacques.le.roux], Yes, I have verified this change on various screens and did not find any issue. Also, I was trying to figure out the reason for the same. Regards Prakhar > Similar values reflecting twice on Add Action Type dropdown in Pricerule > > > Key: OFBIZ-10660 > URL: https://issues.apache.org/jira/browse/OFBIZ-10660 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond >Reporter: Archana Asthana >Assignee: Prakhar Kumar >Priority: Trivial > Attachments: ActionTypeDropdown.png, OFBIZ-10660.patch > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond > 2. Add the name for a new Price Rule > 3. Add Condition and go to Add Action panel > 4. Check the dropdown values under Action Type > *Actual: * > Same value reflecting twice in the dropdown ( Flat Amount Modify) > The Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10660) Similar values reflecting twice on Add Action Type dropdown in Pricerule
[ https://issues.apache.org/jira/browse/OFBIZ-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10660: --- Assignee: Jacques Le Roux (was: Prakhar Kumar) > Similar values reflecting twice on Add Action Type dropdown in Pricerule > > > Key: OFBIZ-10660 > URL: https://issues.apache.org/jira/browse/OFBIZ-10660 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond >Reporter: Archana Asthana >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ActionTypeDropdown.png, OFBIZ-10660.patch > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond > 2. Add the name for a new Price Rule > 3. Add Condition and go to Add Action panel > 4. Check the dropdown values under Action Type > *Actual: * > Same value reflecting twice in the dropdown ( Flat Amount Modify) > The Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829046#comment-16829046 ] Jacques Le Roux commented on OFBIZ-10725: - Hi Aditya, Even if this is not functional and minor, it's delicate, thanks for all your work cleaning the code :) I was wondering if we should close here. I just had a look and using this regexp: {code:java} if \(.*\) \{\R.*return true; {code} I found * 60 matches in applications * 138 in framework * 4 in plugins I only checked the 1st two in applications and they really match (the regexp is very simple). While at it I improved 3 of the 4 in plugins (the other is in a loop) at revision: 1858350 So let's keep it open, most if done, but if we get some spare time why not continue :) For now I guess we have bigger fishes to fry even if it's always hard to clearly define priority when it's about code. > Refactor boolean returns from methods > - > > Key: OFBIZ-10725 > URL: https://issues.apache.org/jira/browse/OFBIZ-10725 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10765) Failed registration for virtual hosts with similar mount points
[ https://issues.apache.org/jira/browse/OFBIZ-10765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10765. - Resolution: Fixed This is fixed in trunk r1858347 release 17.12 r1858349 release 18.12 r1858348 > Failed registration for virtual hosts with similar mount points > --- > > Key: OFBIZ-10765 > URL: https://issues.apache.org/jira/browse/OFBIZ-10765 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Blocker > Fix For: 17.12.01, 18.12.01 > > Attachments: > OFBIZ-10765_failed_registration_for_similar_mount_points.patch > > > The registration of webapps with virtual hosts using similar mount points > does not work. > Example > The following webapps should be registered (virtual host/ mount point) > * host1/webcontent > * host2/webcontent > During registration, the name of the context is implicitly set through the > setPath(...) method in org.apache.catalina.core.StandardContext if not > already set. In the above example, the name will be set as "/webcontent". > Wenn the context is added, it is checked if a child under the name is already > registered and the addition will be refused. > The solution would be to explicitly set the name from the webappInfo.name > before the path is set. I will provide a patch for it. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[ https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10187: -- Affects Version/s: Release Branch 18.12 Release Branch 17.12 Trunk > OWASP sanitizer breaks proper rendering of HTML code > > > Key: OFBIZ-10187 > URL: https://issues.apache.org/jira/browse/OFBIZ-10187 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch > 18.12 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Critical > Attachments: OFBIZ-10187_Sanitizer.patch, > OFBIZ-10187_Sanitizer_New.patch > > > The current implementation of the sanitizer breaks the proper rendering of > html code. In our case, class attributes are stripped from the html content. > Example: > {code:java} > > src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" > alt="" /> > > > Lorem ipsum dolor sit amet > At vero eos et accusam et justo > > Lorem ipsum dolor sit amet, consetetur > sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea > takimata sanctus est Lorem ipsum dolor sit amet. > > href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen > > > {code} > will be rendered to > {code:java} > > src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" > alt="" /> > > > Lorem ipsum dolor sit amet > At vero eos et accusam et justo > > Lorem ipsum dolor sit amet, consetetur > sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea > takimata sanctus est Lorem ipsum dolor sit amet. > > href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen > > > {code} > I do not see any reason to not allow class attributes in html code. There > might be other problems with these rules but this is a showstopper. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10959) Enable entity timestamp fields
[ https://issues.apache.org/jira/browse/OFBIZ-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828993#comment-16828993 ] Pawan Verma commented on OFBIZ-10959: - Thanks, [~mthl] for the review, totally makes sense to me. I have updated patch for the suggested changes. Please have a look! > Enable entity timestamp fields > -- > > Key: OFBIZ-10959 > URL: https://issues.apache.org/jira/browse/OFBIZ-10959 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10959.patch, OFBIZ-10959.patch, OFBIZ-10959.patch > > > MarkMail link for the discussion: > [https://markmail.org/thread/x7paa3ulljns6awh] > > While working on a Production environment, I have found that for some reason > entity timestamp fields are disabled at Search Results screen in Trunk and > the previous release branch. It is available at View Value screen. It was > enabled in Release 16.11. > > These fields are helpful for developers to get the idea about when the row in > the entity is created/updated. Extremely helpful while working on the > Production environment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10959) Enable entity timestamp fields
[ https://issues.apache.org/jira/browse/OFBIZ-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-10959: Attachment: OFBIZ-10959.patch > Enable entity timestamp fields > -- > > Key: OFBIZ-10959 > URL: https://issues.apache.org/jira/browse/OFBIZ-10959 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10959.patch, OFBIZ-10959.patch, OFBIZ-10959.patch > > > MarkMail link for the discussion: > [https://markmail.org/thread/x7paa3ulljns6awh] > > While working on a Production environment, I have found that for some reason > entity timestamp fields are disabled at Search Results screen in Trunk and > the previous release branch. It is available at View Value screen. It was > enabled in Release 16.11. > > These fields are helpful for developers to get the idea about when the row in > the entity is created/updated. Extremely helpful while working on the > Production environment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10996) Have a Supplier dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10996: - Labels: birt dww (was: ) > Have a Supplier dimension > - > > Key: OFBIZ-10996 > URL: https://issues.apache.org/jira/browse/OFBIZ-10996 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: birt, dww > > The component would benefit from a Supplier dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10997) Have an Employee dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10997: - Labels: birt dwh (was: ) > Have an Employee dimension > -- > > Key: OFBIZ-10997 > URL: https://issues.apache.org/jira/browse/OFBIZ-10997 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: birt, dwh > > The component would benefit from an employee dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10995) Have a Brand dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10995: - Labels: birt dwh (was: ) > Have a Brand dimension > -- > > Key: OFBIZ-10995 > URL: https://issues.apache.org/jira/browse/OFBIZ-10995 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: birt, dwh > > The component would benefit from a brand dimension for future fact tables and > star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10989) Have a Facility dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10989: - Summary: Have a Facility dimension (was: Have a facility dimension) > Have a Facility dimension > - > > Key: OFBIZ-10989 > URL: https://issues.apache.org/jira/browse/OFBIZ-10989 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > > The component would benefit from a facility dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10660) Similar values reflecting twice on Add Action Type dropdown in Pricerule
[ https://issues.apache.org/jira/browse/OFBIZ-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827561#comment-16827561 ] Prakhar Kumar edited comment on OFBIZ-10660 at 4/29/19 7:16 AM: Hello [~archana.asthana], Thanks for reporting this but this is not a bug. This is the default behavior of forms in OFBiz. Although, this behavior is confusing and it seems to be a UX improvement to me. So I have attached the patch for the same. Regards Prakhar [^OFBIZ-10660.patch] was (Author: prakhar.kumar): Hello [~archana.asthana], Thanks for reporting this but this is not a bug. This is the default behaviour of forms in OFBiz. Although, this behaviour is confusing and it seems to be a UX improvement to me. So I have attached the patch for the same. Regards Prakhar [^OFBIZ-10660.patch] > Similar values reflecting twice on Add Action Type dropdown in Pricerule > > > Key: OFBIZ-10660 > URL: https://issues.apache.org/jira/browse/OFBIZ-10660 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond >Reporter: Archana Asthana >Assignee: Prakhar Kumar >Priority: Trivial > Attachments: ActionTypeDropdown.png, OFBIZ-10660.patch > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond > 2. Add the name for a new Price Rule > 3. Add Condition and go to Add Action panel > 4. Check the dropdown values under Action Type > *Actual: * > Same value reflecting twice in the dropdown ( Flat Amount Modify) > The Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10997) Have an Employee dimension
Pierre Smits created OFBIZ-10997: Summary: Have an Employee dimension Key: OFBIZ-10997 URL: https://issues.apache.org/jira/browse/OFBIZ-10997 Project: OFBiz Issue Type: Improvement Components: bi Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pierre Smits Assignee: Pierre Smits The component would benefit from an employee dimension for future fact tables and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10996) Have a Supplier dimension
Pierre Smits created OFBIZ-10996: Summary: Have a Supplier dimension Key: OFBIZ-10996 URL: https://issues.apache.org/jira/browse/OFBIZ-10996 Project: OFBiz Issue Type: Improvement Components: bi Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pierre Smits Assignee: Pierre Smits The component would benefit from a Supplier dimension for future fact tables and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10995) Have a Brand dimension
Pierre Smits created OFBIZ-10995: Summary: Have a Brand dimension Key: OFBIZ-10995 URL: https://issues.apache.org/jira/browse/OFBIZ-10995 Project: OFBiz Issue Type: Improvement Components: bi Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pierre Smits Assignee: Pierre Smits The component would benefit from a brand dimension for future fact tables and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10994) Hello3:Error while loading seed data
[ https://issues.apache.org/jira/browse/OFBIZ-10994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-10994. -- Resolution: Not A Problem Assignee: Swapnil M Mane > Hello3:Error while loading seed data > > > Key: OFBIZ-10994 > URL: https://issues.apache.org/jira/browse/OFBIZ-10994 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 15.12 >Reporter: Arshitha k m >Assignee: Swapnil M Mane >Priority: Major > > hello, > I am new to OFBiz, I have completed hello1 and hello2, and currently facing > an issue to load seed data, using URL and text both generating the same error. > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > I tryed to import in to HelloPerson and that was successful. > Can you please help me to fix the trouble. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10660) Similar values reflecting twice on Add Action Type dropdown in Pricerule
[ https://issues.apache.org/jira/browse/OFBIZ-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828981#comment-16828981 ] Prakhar Kumar commented on OFBIZ-10660: --- Hello [~jacques.le.roux], Yes, I have verified this change on various screens and did not find any issue. Also, I was trying to figure out the reason for the same. Regards Prakhar > Similar values reflecting twice on Add Action Type dropdown in Pricerule > > > Key: OFBIZ-10660 > URL: https://issues.apache.org/jira/browse/OFBIZ-10660 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond >Reporter: Archana Asthana >Assignee: Prakhar Kumar >Priority: Trivial > Attachments: ActionTypeDropdown.png, OFBIZ-10660.patch > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/createProductPriceCond > 2. Add the name for a new Price Rule > 3. Add Condition and go to Add Action panel > 4. Check the dropdown values under Action Type > *Actual: * > Same value reflecting twice in the dropdown ( Flat Amount Modify) > The Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10993) error while loading seeddata
[ https://issues.apache.org/jira/browse/OFBIZ-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-10993. -- Resolution: Not A Problem Assignee: Swapnil M Mane > error while loading seeddata > > > Key: OFBIZ-10993 > URL: https://issues.apache.org/jira/browse/OFBIZ-10993 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Reporter: Arshitha k m >Assignee: Swapnil M Mane >Priority: Major > > hi, > I am new to OFBiz .completed hello1and hello2 .currentlyfacing an issue to > import the seed data .iam getting an error as shown below, > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > tried to load seed data to the HelloPerson ,and that was successfull, > can you please help me to fix the trouble. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10993) error while loading seeddata
[ https://issues.apache.org/jira/browse/OFBIZ-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828969#comment-16828969 ] Swapnil M Mane commented on OFBIZ-10993: This query seems specific to the developer mailing list - (d...@ofbiz.apache.org) Please subscribe to the dev mailing list [1] before posting your question. [1] https://ofbiz.apache.org/mailing-lists.html Thanks! > error while loading seeddata > > > Key: OFBIZ-10993 > URL: https://issues.apache.org/jira/browse/OFBIZ-10993 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Reporter: Arshitha k m >Priority: Major > > hi, > I am new to OFBiz .completed hello1and hello2 .currentlyfacing an issue to > import the seed data .iam getting an error as shown below, > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > tried to load seed data to the HelloPerson ,and that was successfull, > can you please help me to fix the trouble. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10993) error while loading seeddata
[ https://issues.apache.org/jira/browse/OFBIZ-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828968#comment-16828968 ] Deepak Nigam commented on OFBIZ-10993: -- Hi [~Arshithakmanaf], it seems the entities and data you are referring, are your customized things. You will have to provide entity definitions and the data you are trying to load. At first glance, it looks like you are not entering the value in the column 'HELLO_PERSON_ID'. > error while loading seeddata > > > Key: OFBIZ-10993 > URL: https://issues.apache.org/jira/browse/OFBIZ-10993 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Reporter: Arshitha k m >Priority: Major > > hi, > I am new to OFBiz .completed hello1and hello2 .currentlyfacing an issue to > import the seed data .iam getting an error as shown below, > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > tried to load seed data to the HelloPerson ,and that was successfull, > can you please help me to fix the trouble. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10994) Hello3:Error while loading seed data
[ https://issues.apache.org/jira/browse/OFBIZ-10994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828975#comment-16828975 ] Swapnil M Mane commented on OFBIZ-10994: Hi [~Arshithakmanaf], As mentioned in comments of OFBIZ-10993 Please don't create JIRA tickets for your queries, mailing lists are appropriate for this kind of things. I request you to please read this comment again https://issues.apache.org/jira/browse/OFBIZ-10993?focusedCommentId=16828966&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16828966 And please avoid creating these types of issues in OFBiz Jira. Thanks! > Hello3:Error while loading seed data > > > Key: OFBIZ-10994 > URL: https://issues.apache.org/jira/browse/OFBIZ-10994 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 15.12 >Reporter: Arshitha k m >Priority: Major > > hello, > I am new to OFBiz, I have completed hello1 and hello2, and currently facing > an issue to load seed data, using URL and text both generating the same error. > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > I tryed to import in to HelloPerson and that was successful. > Can you please help me to fix the trouble. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10993) error while loading seeddata
[ https://issues.apache.org/jira/browse/OFBIZ-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828966#comment-16828966 ] Swapnil M Mane commented on OFBIZ-10993: Hello Arshitha, Welcome to Apache OFBiz ecosystem. OFBiz Jira is not the right place for asking your queries. It for tracking bugs and improvement in OFBiz. Please ask your questions/queries on the user mailing list - (u...@ofbiz.apache.org). You will get wider audience support there. Please subscribe to the mailing list before posting your question. For more detail, refer Apache OFBiz mailing list [1] I am closing this issue, please post your queries on the user mailing list along with details. [1] https://ofbiz.apache.org/mailing-lists.html Thanks! > error while loading seeddata > > > Key: OFBIZ-10993 > URL: https://issues.apache.org/jira/browse/OFBIZ-10993 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Reporter: Arshitha k m >Priority: Major > > hi, > I am new to OFBiz .completed hello1and hello2 .currentlyfacing an issue to > import the seed data .iam getting an error as shown below, > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > tried to load seed data to the HelloPerson ,and that was successfull, > can you please help me to fix the trouble. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16828963#comment-16828963 ] Pierre Smits commented on OFBIZ-10990: -- Regarding the other points: {noformat} Product Dimesion - Can help in getting the Brand, Style, Assortments, Component level info for different views.{noformat} For sure we can add more dimensions (like the ones suggested). The thing to keep in mind here is whether a product can be sold under different brands, styles, etc) or not. I don't think we can dictate one approach here, but we have to start somewhere. And - as always - our adopters can (and will) extend entity-packages and individual entities as they see fit. {noformat} Time Dimension - can help in getting financial/merchandising calendars with Years, Season, quarters, weeks , days etc. for different views. {noformat} We already have a date dimension catering for year, week, days. This dimension can, of course, be extended with missing elements (like season, trimesters, etc.) As for time. yes we can add a static time dimension having are all time increments between 00:00:00 and 23:59:59. If only using the minute discriminator this would be a table consisting of 1440 records. Businesses are not that much interested in sales/purchases/etc. per second, whereas IT more often is (transactions per second), but at least the time dimension will allow doing that in fact tables and star schemas. Businesses are interested in stuff like: how do our sales in the morning compare to sales in the afternoon, and how do our morning sales trend over time I will add a new ticket for this. {noformat} Supplier Dimension - can help in getting Supplier, Vendors or any other product sourcing agency info for different views.{noformat} Yes, I will add a new ticket for this. Please keep in mind that the term 'vendor' is ambiguous as it can be used in both the purchase and the sales domain. I tend to not use that discriminator. > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: birt, dwh > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10994) Hello3:Error while loading seed data
Arshitha k m created OFBIZ-10994: Summary: Hello3:Error while loading seed data Key: OFBIZ-10994 URL: https://issues.apache.org/jira/browse/OFBIZ-10994 Project: OFBiz Issue Type: Bug Components: framework/webtools Affects Versions: Release Branch 15.12 Reporter: Arshitha k m hello, I am new to OFBiz, I have completed hello1 and hello2, and currently facing an issue to load seed data, using URL and text both generating the same error. The Following Errors Occurred: ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: A transaction error occurred reading dataorg.ofbiz.entity.GenericEntityException: org.ofbiz.entity.GenericEntityException: org.ofbiz.entity.GenericEntityException: Error while inserting: [GenericEntity:HelloHobby][createdStamp,2019-04-29 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL value.)) I tryed to import in to HelloPerson and that was successful. Can you please help me to fix the trouble. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10993) error while loading seeddata
Arshitha k m created OFBIZ-10993: Summary: error while loading seeddata Key: OFBIZ-10993 URL: https://issues.apache.org/jira/browse/OFBIZ-10993 Project: OFBiz Issue Type: Bug Components: framework/webtools Reporter: Arshitha k m hi, I am new to OFBiz .completed hello1and hello2 .currentlyfacing an issue to import the seed data .iam getting an error as shown below, The Following Errors Occurred: ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: A transaction error occurred reading dataorg.ofbiz.entity.GenericEntityException: org.ofbiz.entity.GenericEntityException: org.ofbiz.entity.GenericEntityException: Error while inserting: [GenericEntity:HelloHobby][createdStamp,2019-04-29 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL value.)) tried to load seed data to the HelloPerson ,and that was successfull, can you please help me to fix the trouble. -- This message was sent by Atlassian JIRA (v7.6.3#76005)