[jira] [Commented] (OFBIZ-11005) Missing uiLabel for Create New on CMS Content Find Screen

2019-05-01 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831424#comment-16831424
 ] 

Suraj Khurana commented on OFBIZ-11005:
---

Hello Pawan,

Thanks for your contribution.
We have done some changes recently on OFBIZ-9905, I don't know it it is related.
Also, IMO, we can remove OrderNotesCreateNew and use this CommonCreateNew 
instead.

WDYT.

Please check if this is for trunk only or also affect/s release versions.

Thanks !!

> Missing uiLabel for Create New on CMS Content Find Screen
> -
>
> Key: OFBIZ-11005
> URL: https://issues.apache.org/jira/browse/OFBIZ-11005
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11005.patch
>
>
> Steps to regenerate:
>  # Go to [https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind]
>  # Find missing uiLabel for Create New, showing as CommonCreateNew.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11005) Missing uiLabel for Create New on CMS Content Find Screen

2019-05-01 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-11005:

Attachment: OFBIZ-11005.patch

> Missing uiLabel for Create New on CMS Content Find Screen
> -
>
> Key: OFBIZ-11005
> URL: https://issues.apache.org/jira/browse/OFBIZ-11005
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11005.patch
>
>
> Steps to regenerate:
>  # Go to [https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind]
>  # Find missing uiLabel for Create New, showing as CommonCreateNew.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11005) Missing uiLabel for Create New on CMS Content Find Screen

2019-05-01 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831422#comment-16831422
 ] 

Pawan Verma commented on OFBIZ-11005:
-

While working on content, I have found this missing uiLabel. Created new 
uiLabel in CommonUiLabels and copied values with different locales from 
OrderNotesCreateNew.

 

> Missing uiLabel for Create New on CMS Content Find Screen
> -
>
> Key: OFBIZ-11005
> URL: https://issues.apache.org/jira/browse/OFBIZ-11005
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11005.patch
>
>
> Steps to regenerate:
>  # Go to [https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind]
>  # Find missing uiLabel for Create New, showing as CommonCreateNew.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11005) Missing uiLabel for Create New on CMS Content Find Screen

2019-05-01 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11005:
---

Assignee: Pawan Verma

> Missing uiLabel for Create New on CMS Content Find Screen
> -
>
> Key: OFBIZ-11005
> URL: https://issues.apache.org/jira/browse/OFBIZ-11005
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
>
> Steps to regenerate:
>  # Go to [https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind]
>  # Find missing uiLabel for Create New, showing as CommonCreateNew.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11005) Missing uiLabel for Create New on CMS Content Find Screen

2019-05-01 Thread Pawan Verma (JIRA)
Pawan Verma created OFBIZ-11005:
---

 Summary: Missing uiLabel for Create New on CMS Content Find Screen
 Key: OFBIZ-11005
 URL: https://issues.apache.org/jira/browse/OFBIZ-11005
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: Trunk
Reporter: Pawan Verma


Steps to regenerate:
 # Go to [https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind]
 # Find missing uiLabel for Create New, showing as CommonCreateNew.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10833) CMS add content not working

2019-05-01 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831413#comment-16831413
 ] 

Swapnil M Mane commented on OFBIZ-10833:


Thanks [~jacques.le.roux]!

> CMS add content not working
> ---
>
> Key: OFBIZ-10833
> URL: https://issues.apache.org/jira/browse/OFBIZ-10833
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk, 17.12.01
>Reporter: Ingo Wolfmayr
>Assignee: Swapnil M Mane
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: LogCreateContent.txt, OFBIZ-10833.patch, 
> cms_addImage.patch
>
>
> On demo: content --> "CmsSite" --> CMS:
> Right click on one of the items to add "New Long Text" or "Image".
> After saving the new content:
> Edit WebSite CMS For: []
> "There is no Content PUBLISH_POINT for this WebSite!"
> Having the same problem on a  17.12 local installation.
> h1.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831199#comment-16831199
 ] 

Jacques Le Roux commented on OFBIZ-11004:
-

Hi Mathieu,

Makes sense to me, as always: better be safe than sorry

> Add missing ‘synchronized’ modifier
> ---
>
> Key: OFBIZ-11004
> URL: https://issues.apache.org/jira/browse/OFBIZ-11004
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11004_Add-missing-synchronized-modifier.patch
>
>
> Overidding a synchronized method with a non-synchronized one can
> introduce potential runtime concurrency bugs. Since
> ‘ExtendedProperties#loadFromXML’ is overridding
> ‘Propertiers#loadFromXML’ which is synchronized, it is safer to mark
> it as synchonized.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code

2019-05-01 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831198#comment-16831198
 ] 

Jacques Le Roux commented on OFBIZ-10187:
-

Hi Mathieu,

I see no reasons to not do so.

> OWASP sanitizer breaks proper rendering of HTML code
> 
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch 
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
>  Labels: backport-needed
> Fix For: 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch, 
> OFBIZ-10187_Sanitizer.patch, OFBIZ-10187_Sanitizer_16.11.patch, 
> OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of 
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>     
>           src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" 
> alt="" />
>                  
>                      
>                          Lorem ipsum dolor sit amet
>                          At vero eos et accusam et justo
>                          
>                              Lorem ipsum dolor sit amet, consetetur 
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
>                              takimata sanctus est Lorem ipsum dolor sit amet.
>                          
>                           href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>                      
>                  
>              {code}
> will be rendered to
> {code:java}
>     
>           src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" 
> alt="" />
>                  
>                      
>                          Lorem ipsum dolor sit amet
>                          At vero eos et accusam et justo
>                          
>                              Lorem ipsum dolor sit amet, consetetur 
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
>                              takimata sanctus est Lorem ipsum dolor sit amet.
>                          
>                           href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>                      
>                  
>              {code}
> I do not see any reason to not allow class attributes in html code. There 
> might be other problems with these rules but this is a showstopper.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10833) CMS add content not working

2019-05-01 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831184#comment-16831184
 ] 

Jacques Le Roux edited comment on OFBIZ-10833 at 5/1/19 6:55 PM:
-

Reopening, I thought it was complete, thanks Swapnil!


was (Author: jacques.le.roux):
Reopring, I thought it was complete, thanks Swapnil!

> CMS add content not working
> ---
>
> Key: OFBIZ-10833
> URL: https://issues.apache.org/jira/browse/OFBIZ-10833
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk, 17.12.01
>Reporter: Ingo Wolfmayr
>Assignee: Swapnil M Mane
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: LogCreateContent.txt, OFBIZ-10833.patch, 
> cms_addImage.patch
>
>
> On demo: content --> "CmsSite" --> CMS:
> Right click on one of the items to add "New Long Text" or "Image".
> After saving the new content:
> Edit WebSite CMS For: []
> "There is no Content PUBLISH_POINT for this WebSite!"
> Having the same problem on a  17.12 local installation.
> h1.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10933) Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’

2019-05-01 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831185#comment-16831185
 ] 

Jacques Le Roux commented on OFBIZ-10933:
-

I confirm it fixed it

> Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’
> ---
>
> Key: OFBIZ-10933
> URL: https://issues.apache.org/jira/browse/OFBIZ-10933
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 18.12
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk, Release Branch 18.12
>
> Attachments: 
> OFBIZ-10933_0001-Improved-Add-UtilMisc-toMap-Supplier-Map-K-V-Object.patch, 
> OFBIZ-10933_0002-Fixed-Ensure-that-MapContext-preserves-insertion-ord.patch
>
>
> Since revision 1837462, when pushing a ‘LinkedHashMap’ inside a ‘MapContext’, 
> the iteration order of the ‘MapContext’ values is not corresponding to the
> insertion order of the embedded ‘LinkedHashMap’ which is important in the 
> ‘ControllerConfig’ case where configuration elements are stored in 
> ‘LinkedHashMap’ objects and the ‘include’ mechanism relies on ‘MapContext’.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10833) CMS add content not working

2019-05-01 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-10833:
-

Reopring, I thought it was complete, thanks Swapnil!

> CMS add content not working
> ---
>
> Key: OFBIZ-10833
> URL: https://issues.apache.org/jira/browse/OFBIZ-10833
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk, 17.12.01
>Reporter: Ingo Wolfmayr
>Assignee: Swapnil M Mane
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: LogCreateContent.txt, OFBIZ-10833.patch, 
> cms_addImage.patch
>
>
> On demo: content --> "CmsSite" --> CMS:
> Right click on one of the items to add "New Long Text" or "Image".
> After saving the new content:
> Edit WebSite CMS For: []
> "There is no Content PUBLISH_POINT for this WebSite!"
> Having the same problem on a  17.12 local installation.
> h1.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831030#comment-16831030
 ] 

Mathieu Lirzin commented on OFBIZ-11004:


Committed in revision 1858490 on trunk.

> Add missing ‘synchronized’ modifier
> ---
>
> Key: OFBIZ-11004
> URL: https://issues.apache.org/jira/browse/OFBIZ-11004
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11004_Add-missing-synchronized-modifier.patch
>
>
> Overidding a synchronized method with a non-synchronized one can
> introduce potential runtime concurrency bugs. Since
> ‘ExtendedProperties#loadFromXML’ is overridding
> ‘Propertiers#loadFromXML’ which is synchronized, it is safer to mark
> it as synchonized.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831021#comment-16831021
 ] 

Mathieu Lirzin edited comment on OFBIZ-11004 at 5/1/19 2:30 PM:


This is not a bug fix since I didn't observe any undesired behavior, but to be 
safe I think it would be a good idea to backport this patch to releases 
branches. What do people think?


was (Author: mthl):
This is not a bug fix since I didn't observe any undesired behavior, but to be 
safe I think I is a good idea to backport this patch to releases branches. What 
do people think?

> Add missing ‘synchronized’ modifier
> ---
>
> Key: OFBIZ-11004
> URL: https://issues.apache.org/jira/browse/OFBIZ-11004
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11004_Add-missing-synchronized-modifier.patch
>
>
> Overidding a synchronized method with a non-synchronized one can
> introduce potential runtime concurrency bugs. Since
> ‘ExtendedProperties#loadFromXML’ is overridding
> ‘Propertiers#loadFromXML’ which is synchronized, it is safer to mark
> it as synchonized.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831021#comment-16831021
 ] 

Mathieu Lirzin commented on OFBIZ-11004:


This is not a bug fix since I didn't observe any undesired behavior, but to be 
safe I think I is a good idea to backport this patch to releases branches. What 
do people think?

> Add missing ‘synchronized’ modifier
> ---
>
> Key: OFBIZ-11004
> URL: https://issues.apache.org/jira/browse/OFBIZ-11004
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11004_Add-missing-synchronized-modifier.patch
>
>
> Overidding a synchronized method with a non-synchronized one can
> introduce potential runtime concurrency bugs. Since
> ‘ExtendedProperties#loadFromXML’ is overridding
> ‘Propertiers#loadFromXML’ which is synchronized, it is safer to mark
> it as synchonized.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Mathieu Lirzin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin updated OFBIZ-11004:
---
Attachment: OFBIZ-11004_Add-missing-synchronized-modifier.patch

> Add missing ‘synchronized’ modifier
> ---
>
> Key: OFBIZ-11004
> URL: https://issues.apache.org/jira/browse/OFBIZ-11004
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11004_Add-missing-synchronized-modifier.patch
>
>
> Overidding a synchronized method with a non-synchronized one can
> introduce potential runtime concurrency bugs. Since
> ‘ExtendedProperties#loadFromXML’ is overridding
> ‘Propertiers#loadFromXML’ which is synchronized, it is safer to mark
> it as synchonized.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11004:
--

 Summary: Add missing ‘synchronized’ modifier
 Key: OFBIZ-11004
 URL: https://issues.apache.org/jira/browse/OFBIZ-11004
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Mathieu Lirzin
Assignee: Mathieu Lirzin
 Fix For: Upcoming Branch


Overidding a synchronized method with a non-synchronized one can
introduce potential runtime concurrency bugs. Since
‘ExtendedProperties#loadFromXML’ is overridding
‘Propertiers#loadFromXML’ which is synchronized, it is safer to mark
it as synchonized.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2019-05-01 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831007#comment-16831007
 ] 

Mathieu Lirzin commented on OFBIZ-10518:


Hello here,

In revision 1858487, I have removed two unused local variables introduced by 
revision 1858270.

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, CreateAllocationPlanEditMode-Step2.png, 
> EditAllocationPlan.png, FindAllocationPlan.png, OFBiz-10518-UI.patch, 
> OFBiz-10518-data.patch, OFBiz-10518-entity-model.patch, 
> OFBiz-10518-secas.patch, OFBiz-10518-services.patch, 
> OFBiz-10518-ui-labels.patch, OFBiz-10518.patch, OFBiz-10518.patch, 
> OFBiz-10518.patch, OFBiz-10518.patch, OFBiz-10518.patch, OFBiz-10518.patch, 
> ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code

2019-05-01 Thread Mathieu Lirzin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin updated OFBIZ-10187:
---
Attachment: OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch

> OWASP sanitizer breaks proper rendering of HTML code
> 
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch 
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
>  Labels: backport-needed
> Fix For: 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch, 
> OFBIZ-10187_Sanitizer.patch, OFBIZ-10187_Sanitizer_16.11.patch, 
> OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of 
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>     
>           src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" 
> alt="" />
>                  
>                      
>                          Lorem ipsum dolor sit amet
>                          At vero eos et accusam et justo
>                          
>                              Lorem ipsum dolor sit amet, consetetur 
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
>                              takimata sanctus est Lorem ipsum dolor sit amet.
>                          
>                           href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>                      
>                  
>              {code}
> will be rendered to
> {code:java}
>     
>           src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" 
> alt="" />
>                  
>                      
>                          Lorem ipsum dolor sit amet
>                          At vero eos et accusam et justo
>                          
>                              Lorem ipsum dolor sit amet, consetetur 
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
>                              takimata sanctus est Lorem ipsum dolor sit amet.
>                          
>                           href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>                      
>                  
>              {code}
> I do not see any reason to not allow class attributes in html code. There 
> might be other problems with these rules but this is a showstopper.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10933) Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’

2019-05-01 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830983#comment-16830983
 ] 

Mathieu Lirzin commented on OFBIZ-10933:


The warning should not appear anymore after the commit  done in revision 
1858483.

{quote}Should we not heed comments made in the 'move to jdk11' discussion in 
the dev ml, from what I got from it: have it correctly working for jdk8?{quote}
Indeed OFBiz {{trunk}} branch requires jdk8 so it must work with jdk8.

> Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’
> ---
>
> Key: OFBIZ-10933
> URL: https://issues.apache.org/jira/browse/OFBIZ-10933
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 18.12
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk, Release Branch 18.12
>
> Attachments: 
> OFBIZ-10933_0001-Improved-Add-UtilMisc-toMap-Supplier-Map-K-V-Object.patch, 
> OFBIZ-10933_0002-Fixed-Ensure-that-MapContext-preserves-insertion-ord.patch
>
>
> Since revision 1837462, when pushing a ‘LinkedHashMap’ inside a ‘MapContext’, 
> the iteration order of the ‘MapContext’ values is not corresponding to the
> insertion order of the embedded ‘LinkedHashMap’ which is important in the 
> ‘ControllerConfig’ case where configuration elements are stored in 
> ‘LinkedHashMap’ objects and the ‘include’ mechanism relies on ‘MapContext’.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11003) Do not use ‘java.util’ backported classes

2019-05-01 Thread Mathieu Lirzin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin updated OFBIZ-11003:
---
Attachment: OFBIZ-11003_Do-not-use-java.util-backported-classes.patch

> Do not use ‘java.util’ backported classes
> -
>
> Key: OFBIZ-11003
> URL: https://issues.apache.org/jira/browse/OFBIZ-11003
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11003_Do-not-use-java.util-backported-classes.patch
>
>
> Probably due to some IDE auto-importing mistake, some classes meant as
> backports of the ‘java.util.Arrays’ and ‘java.util.Collections’
> classes were imported.  This makes no sense since we are requiring
> Java 8 which already provide those.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11003) Do not use ‘java.util’ backported classes

2019-05-01 Thread Mathieu Lirzin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin reassigned OFBIZ-11003:
--

Assignee: Mathieu Lirzin

> Do not use ‘java.util’ backported classes
> -
>
> Key: OFBIZ-11003
> URL: https://issues.apache.org/jira/browse/OFBIZ-11003
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Probably due to some IDE auto-importing mistake, some classes meant as
> backports of the ‘java.util.Arrays’ and ‘java.util.Collections’
> classes were imported.  This makes no sense since we are requiring
> Java 8 which already provide those.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11003) Do not use ‘java.util’ backported classes

2019-05-01 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11003:
--

 Summary: Do not use ‘java.util’ backported classes
 Key: OFBIZ-11003
 URL: https://issues.apache.org/jira/browse/OFBIZ-11003
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Mathieu Lirzin
 Fix For: Upcoming Branch


Probably due to some IDE auto-importing mistake, some classes meant as
backports of the ‘java.util.Arrays’ and ‘java.util.Collections’
classes were imported.  This makes no sense since we are requiring
Java 8 which already provide those.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10833) CMS add content not working

2019-05-01 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830969#comment-16830969
 ] 

Swapnil M Mane commented on OFBIZ-10833:


Dear [~jacques.le.roux] ,
I have committed the patch which I uploaded for fixing the issue in which the 
parameters are not available to the next response type when form of 
enctype="multipart/form-data" type is submitted.
I commit the change since this was the issue at our framework and needs to fix. 

But as mentioned by [~iwolf] in above comments, his problem doesn't fixed with 
this patch.
I think, we should wait for him to confirm that his issue is resolve and then 
we can proceed to close this issue.
WDYT?

Thanks!

> CMS add content not working
> ---
>
> Key: OFBIZ-10833
> URL: https://issues.apache.org/jira/browse/OFBIZ-10833
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk, 17.12.01
>Reporter: Ingo Wolfmayr
>Assignee: Swapnil M Mane
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: LogCreateContent.txt, OFBIZ-10833.patch, 
> cms_addImage.patch
>
>
> On demo: content --> "CmsSite" --> CMS:
> Right click on one of the items to add "New Long Text" or "Image".
> After saving the new content:
> Edit WebSite CMS For: []
> "There is no Content PUBLISH_POINT for this WebSite!"
> Having the same problem on a  17.12 local installation.
> h1.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10921) Marital Status not managed properly in Person entity

2019-05-01 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830968#comment-16830968
 ] 

Suraj Khurana commented on OFBIZ-10921:
---

Updated code occurrences of marital status in e-commerce plugin as per recent 
changes done for it in trunk.

This has been pushed to latest plugins directory at rev #1858479.

I will close the ticket once its sub task is completed.

 

> Marital Status not managed properly in Person entity
> 
>
> Key: OFBIZ-10921
> URL: https://issues.apache.org/jira/browse/OFBIZ-10921
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10921.patch, OFBIZ-10921.patch
>
>
> Currently, *maritalStatus* is managed as an indicator (Y/N) in *Person*
>  entity. I think we can enhance it and make it derived from *Enumeration*
>  pattern.
>  
>  *Classification of legal marital status*
>  
>     - 1 - Married (and not separated) ...
>     - 2 - Widowed (including living common law) ...
>     - 3 - Separated (and not Divorced) ...
>     - 4 - Divorced (including living common law) ...
>     - 5 - Single (including living common law)
> Please refer discussion over ML:
> [https://markmail.org/message/5b33qm3osy76if24]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10833) CMS add content not working

2019-05-01 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10833.
---
   Resolution: Fixed
Fix Version/s: 18.12.01
   17.12.01

> CMS add content not working
> ---
>
> Key: OFBIZ-10833
> URL: https://issues.apache.org/jira/browse/OFBIZ-10833
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk, 17.12.01
>Reporter: Ingo Wolfmayr
>Assignee: Swapnil M Mane
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: LogCreateContent.txt, OFBIZ-10833.patch, 
> cms_addImage.patch
>
>
> On demo: content --> "CmsSite" --> CMS:
> Right click on one of the items to add "New Long Text" or "Image".
> After saving the new content:
> Edit WebSite CMS For: []
> "There is no Content PUBLISH_POINT for this WebSite!"
> Having the same problem on a  17.12 local installation.
> h1.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11002) Manufacturer Support In Promotion Engine

2019-05-01 Thread Rishi Solanki (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-11002:
--
Environment: (was: Currently promotion engine and price rules support 
all the discount based on party, category, party role, party classification, 
shipping etc.. And promotion engine based on the condition decide that the 
promotion will apply for customer purchase over the cart or cart item depending 
upon the action.

I would like to propose to add support in promotion engine, so that , we can 
add promotion against manufacturing party and should apply to all the products 
manufactured by that party.

For example;
M1, M2 are two manufacturers.
M1P1 and M1P2 are products manufactured by M1.
M2P1 and M2P2 are products manufactured by M2.

Now M1 gives 10% discount on all products M1, and if customer purchase all 
products with quantity ONE.

Assuming all items price is $100. Then CartTotal will be $400 and discount 
amount will be $20. As discount is on M1 products only.

As per discussion need to add support at both price rule and promotion level.
[
Reference 
Thread|https://ofbiz.markmail.org/search/?q=Manufacturer+Support+In+Promotion+Engine#query:Manufacturer%20Support%20In%20Promotion%20Engine+page:1+mid:fkgs3pvmqgwe6vrh+state:results])

> Manufacturer Support In Promotion Engine
> 
>
> Key: OFBIZ-11002
> URL: https://issues.apache.org/jira/browse/OFBIZ-11002
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce, product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11002) Manufacturer Support In Promotion Engine

2019-05-01 Thread Rishi Solanki (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-11002:
--
Description: 
Currently promotion engine and price rules support all the discount based on 
party, category, party role, party classification, shipping etc.. And promotion 
engine based on the condition decide that the promotion will apply for customer 
purchase over the cart or cart item depending upon the action.

I would like to propose to add support in promotion engine, so that , we can 
add promotion against manufacturing party and should apply to all the products 
manufactured by that party.

For example;
M1, M2 are two manufacturers.
M1P1 and M1P2 are products manufactured by M1.
M2P1 and M2P2 are products manufactured by M2.

Now M1 gives 10% discount on all products M1, and if customer purchase all 
products with quantity ONE.

Assuming all items price is $100. Then CartTotal will be $400 and discount 
amount will be $20. As discount is on M1 products only.

As per discussion need to add support at both price rule and promotion level.
[Reference 
Thread|https://ofbiz.markmail.org/search/?q=Manufacturer+Support+In+Promotion+Engine#query:Manufacturer%20Support%20In%20Promotion%20Engine+page:1+mid:fkgs3pvmqgwe6vrh+state:results]

  was:
Currently promotion engine and price rules support all the discount based on 
party, category, party role, party classification, shipping etc.. And promotion 
engine based on the condition decide that the promotion will apply for customer 
purchase over the cart or cart item depending upon the action.

I would like to propose to add support in promotion engine, so that , we can 
add promotion against manufacturing party and should apply to all the products 
manufactured by that party.

For example;
M1, M2 are two manufacturers.
M1P1 and M1P2 are products manufactured by M1.
M2P1 and M2P2 are products manufactured by M2.

Now M1 gives 10% discount on all products M1, and if customer purchase all 
products with quantity ONE.

Assuming all items price is $100. Then CartTotal will be $400 and discount 
amount will be $20. As discount is on M1 products only.

As per discussion need to add support at both price rule and promotion level.
[
Reference 
Thread|https://ofbiz.markmail.org/search/?q=Manufacturer+Support+In+Promotion+Engine#query:Manufacturer%20Support%20In%20Promotion%20Engine+page:1+mid:fkgs3pvmqgwe6vrh+state:results]


> Manufacturer Support In Promotion Engine
> 
>
> Key: OFBIZ-11002
> URL: https://issues.apache.org/jira/browse/OFBIZ-11002
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce, product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Major
>
> Currently promotion engine and price rules support all the discount based on 
> party, category, party role, party classification, shipping etc.. And 
> promotion engine based on the condition decide that the promotion will apply 
> for customer purchase over the cart or cart item depending upon the action.
> I would like to propose to add support in promotion engine, so that , we can 
> add promotion against manufacturing party and should apply to all the 
> products manufactured by that party.
> For example;
> M1, M2 are two manufacturers.
> M1P1 and M1P2 are products manufactured by M1.
> M2P1 and M2P2 are products manufactured by M2.
> Now M1 gives 10% discount on all products M1, and if customer purchase all 
> products with quantity ONE.
> Assuming all items price is $100. Then CartTotal will be $400 and discount 
> amount will be $20. As discount is on M1 products only.
> As per discussion need to add support at both price rule and promotion level.
> [Reference 
> Thread|https://ofbiz.markmail.org/search/?q=Manufacturer+Support+In+Promotion+Engine#query:Manufacturer%20Support%20In%20Promotion%20Engine+page:1+mid:fkgs3pvmqgwe6vrh+state:results]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11002) Manufacturer Support In Promotion Engine

2019-05-01 Thread Rishi Solanki (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-11002:
--
Description: 
Currently promotion engine and price rules support all the discount based on 
party, category, party role, party classification, shipping etc.. And promotion 
engine based on the condition decide that the promotion will apply for customer 
purchase over the cart or cart item depending upon the action.

I would like to propose to add support in promotion engine, so that , we can 
add promotion against manufacturing party and should apply to all the products 
manufactured by that party.

For example;
M1, M2 are two manufacturers.
M1P1 and M1P2 are products manufactured by M1.
M2P1 and M2P2 are products manufactured by M2.

Now M1 gives 10% discount on all products M1, and if customer purchase all 
products with quantity ONE.

Assuming all items price is $100. Then CartTotal will be $400 and discount 
amount will be $20. As discount is on M1 products only.

As per discussion need to add support at both price rule and promotion level.
[
Reference 
Thread|https://ofbiz.markmail.org/search/?q=Manufacturer+Support+In+Promotion+Engine#query:Manufacturer%20Support%20In%20Promotion%20Engine+page:1+mid:fkgs3pvmqgwe6vrh+state:results]

> Manufacturer Support In Promotion Engine
> 
>
> Key: OFBIZ-11002
> URL: https://issues.apache.org/jira/browse/OFBIZ-11002
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce, product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Major
>
> Currently promotion engine and price rules support all the discount based on 
> party, category, party role, party classification, shipping etc.. And 
> promotion engine based on the condition decide that the promotion will apply 
> for customer purchase over the cart or cart item depending upon the action.
> I would like to propose to add support in promotion engine, so that , we can 
> add promotion against manufacturing party and should apply to all the 
> products manufactured by that party.
> For example;
> M1, M2 are two manufacturers.
> M1P1 and M1P2 are products manufactured by M1.
> M2P1 and M2P2 are products manufactured by M2.
> Now M1 gives 10% discount on all products M1, and if customer purchase all 
> products with quantity ONE.
> Assuming all items price is $100. Then CartTotal will be $400 and discount 
> amount will be $20. As discount is on M1 products only.
> As per discussion need to add support at both price rule and promotion level.
> [
> Reference 
> Thread|https://ofbiz.markmail.org/search/?q=Manufacturer+Support+In+Promotion+Engine#query:Manufacturer%20Support%20In%20Promotion%20Engine+page:1+mid:fkgs3pvmqgwe6vrh+state:results]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11002) Manufacturer Support In Promotion Engine

2019-05-01 Thread Rishi Solanki (JIRA)
Rishi Solanki created OFBIZ-11002:
-

 Summary: Manufacturer Support In Promotion Engine
 Key: OFBIZ-11002
 URL: https://issues.apache.org/jira/browse/OFBIZ-11002
 Project: OFBiz
  Issue Type: New Feature
  Components: ecommerce, product
Affects Versions: Trunk
 Environment: Currently promotion engine and price rules support all 
the discount based on party, category, party role, party classification, 
shipping etc.. And promotion engine based on the condition decide that the 
promotion will apply for customer purchase over the cart or cart item depending 
upon the action.

I would like to propose to add support in promotion engine, so that , we can 
add promotion against manufacturing party and should apply to all the products 
manufactured by that party.

For example;
M1, M2 are two manufacturers.
M1P1 and M1P2 are products manufactured by M1.
M2P1 and M2P2 are products manufactured by M2.

Now M1 gives 10% discount on all products M1, and if customer purchase all 
products with quantity ONE.

Assuming all items price is $100. Then CartTotal will be $400 and discount 
amount will be $20. As discount is on M1 products only.

As per discussion need to add support at both price rule and promotion level.
[
Reference 
Thread|https://ofbiz.markmail.org/search/?q=Manufacturer+Support+In+Promotion+Engine#query:Manufacturer%20Support%20In%20Promotion%20Engine+page:1+mid:fkgs3pvmqgwe6vrh+state:results]
Reporter: Rishi Solanki






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)