[jira] [Created] (OFBIZ-11299) Add a "gradlew check" step in our Builbot trunk framework builder.

2019-11-26 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-11299:
---

 Summary: Add a "gradlew check" step in our Builbot trunk framework 
builder. 
 Key: OFBIZ-11299
 URL: https://issues.apache.org/jira/browse/OFBIZ-11299
 Project: OFBiz
  Issue Type: New Feature
  Components: BuildBot
Affects Versions: Trunk
Reporter: Jacques Le Roux


Since it depends on the good will of scrutinizer/s and varies in errors 
depending on context, I suggest that we add a "gradlew check" step in our 
Builbot trunk framework builder.

Then everyone will be aware of this feature and we will be able to adjust the 
maxErrors as needed. Actually I'm still waiting for INFRA-19443 for that...





--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11298) Adapt the commit template to Git convention

2019-11-26 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-11298:
---

 Summary: Adapt the commit template to Git convention
 Key: OFBIZ-11298
 URL: https://issues.apache.org/jira/browse/OFBIZ-11298
 Project: OFBiz
  Issue Type: Sub-task
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Jacques Le Roux


A lazy consensus tends forward separating by a line the subject from the Jira 
ussue number, see
* https://s.apache.org/l8kbj
* 
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template

For easy of use, it was also proposed by [~stregouet] that we use the link to 
the Jira instead of only its number. I tend to agree :)





--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11161) OFBiz distribution should not require including extra content

2019-11-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982824#comment-16982824
 ] 

Jacques Le Roux commented on OFBIZ-11161:
-

With the comment above I can close INFRA-19471 :)

> OFBiz distribution should not require including extra content
> -
>
> Key: OFBIZ-11161
> URL: https://issues.apache.org/jira/browse/OFBIZ-11161
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Attachments: 
> OFBIZ-11161_0001-Separate-resources-from-Java-source-files.patch, 
> OFBIZ-11161_0002-Don-t-exclude-properties-and-labels-file-fr.patch, 
> OFBIZ-11161_0003-framework_Remove-redundant-dtd-directory-from-classpa.patch, 
> OFBIZ-11161_0003-plugins_Remove-redundant-dtd-directory-from-classpa.patch, 
> OFBIZ-11161_0004-Move-APACHE2_HEADER_FOR_XML.patch, 
> OFBIZ-11161_0005-Do-not-exclude-files-from-component-config-.patch
>
>
> Currently to deploy OFBiz it is necessary to include the source directories 
> containing xml and groovy files in addition of {{ofbiz.jar}}, because loading 
> of those files is not done using the standard [location independent resource 
> mechanism|https://docs.oracle.com/javase/8/docs/technotes/guides/lang/resources.html]
>  of Java.
> To facilitate the deployment on production servers, the following 
> configuration is added in {{build.gradle}}
> {code:groovy}
> distributions.main.contents.from(rootDir) {
> include 'framework/**', 'applications/**', 'themes/**', 'plugins/**'
> }
> {code}
> However this doesn't solve the problem that OFBiz is not usable as a library 
> downloaded from a Jar repository. The proper solution would be to remove any 
> dependencies on OFBiz home directory and bundle every resource in 
> {{ofbiz.jar}}
> This has been [discussed on Development mailing 
> list|https://lists.apache.org/thread.html/c2612f1e296b6ea15872185871d3a9d83d6a4afc6d2a76f7a336a126@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11297) Tools to backport

2019-11-26 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-11297:
---

 Summary: Tools to backport
 Key: OFBIZ-11297
 URL: https://issues.apache.org/jira/browse/OFBIZ-11297
 Project: OFBiz
  Issue Type: Sub-task
Reporter: Jacques Le Roux


Currently backport in Git (to R18 and R17) is mostly done by cherry picking. 
This is hand work. I think we should concentrate on tools necessary to backport 
with Git. Like the convenient scripts we had previously with Svn.

And if we want to continuously/seriously backport to R16 we need a such tool 
too, from Git to Svn, using patches maybe. An alternative is to stop supporting 
R16 and release R17. Sincerely, I'm actually more inclined to this 
alternative...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11161) OFBiz distribution should not require including extra content

2019-11-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982653#comment-16982653
 ] 

ASF subversion and git services commented on OFBIZ-11161:
-

Commit 1a8860a33f7327331af54e492bde4fa8f9f1ee60 in ofbiz-framework's branch 
refs/heads/trunk from Mathieu Lirzin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1a8860a ]

Improved: Do not exclude files from component ‘config’ directories (OFBIZ-11161)

With the goal of distributing OFBiz as a library in a Jar, we must
include every configuration resource files in the Jar.


> OFBiz distribution should not require including extra content
> -
>
> Key: OFBIZ-11161
> URL: https://issues.apache.org/jira/browse/OFBIZ-11161
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Attachments: 
> OFBIZ-11161_0001-Separate-resources-from-Java-source-files.patch, 
> OFBIZ-11161_0002-Don-t-exclude-properties-and-labels-file-fr.patch, 
> OFBIZ-11161_0003-framework_Remove-redundant-dtd-directory-from-classpa.patch, 
> OFBIZ-11161_0003-plugins_Remove-redundant-dtd-directory-from-classpa.patch, 
> OFBIZ-11161_0004-Move-APACHE2_HEADER_FOR_XML.patch, 
> OFBIZ-11161_0005-Do-not-exclude-files-from-component-config-.patch
>
>
> Currently to deploy OFBiz it is necessary to include the source directories 
> containing xml and groovy files in addition of {{ofbiz.jar}}, because loading 
> of those files is not done using the standard [location independent resource 
> mechanism|https://docs.oracle.com/javase/8/docs/technotes/guides/lang/resources.html]
>  of Java.
> To facilitate the deployment on production servers, the following 
> configuration is added in {{build.gradle}}
> {code:groovy}
> distributions.main.contents.from(rootDir) {
> include 'framework/**', 'applications/**', 'themes/**', 'plugins/**'
> }
> {code}
> However this doesn't solve the problem that OFBiz is not usable as a library 
> downloaded from a Jar repository. The proper solution would be to remove any 
> dependencies on OFBiz home directory and bundle every resource in 
> {{ofbiz.jar}}
> This has been [discussed on Development mailing 
> list|https://lists.apache.org/thread.html/c2612f1e296b6ea15872185871d3a9d83d6a4afc6d2a76f7a336a126@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11161) OFBiz distribution should not require including extra content

2019-11-26 Thread Mathieu Lirzin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin updated OFBIZ-11161:
---
Attachment: 
OFBIZ-11161_0005-Do-not-exclude-files-from-component-config-.patch

> OFBiz distribution should not require including extra content
> -
>
> Key: OFBIZ-11161
> URL: https://issues.apache.org/jira/browse/OFBIZ-11161
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Attachments: 
> OFBIZ-11161_0001-Separate-resources-from-Java-source-files.patch, 
> OFBIZ-11161_0002-Don-t-exclude-properties-and-labels-file-fr.patch, 
> OFBIZ-11161_0003-framework_Remove-redundant-dtd-directory-from-classpa.patch, 
> OFBIZ-11161_0003-plugins_Remove-redundant-dtd-directory-from-classpa.patch, 
> OFBIZ-11161_0004-Move-APACHE2_HEADER_FOR_XML.patch, 
> OFBIZ-11161_0005-Do-not-exclude-files-from-component-config-.patch
>
>
> Currently to deploy OFBiz it is necessary to include the source directories 
> containing xml and groovy files in addition of {{ofbiz.jar}}, because loading 
> of those files is not done using the standard [location independent resource 
> mechanism|https://docs.oracle.com/javase/8/docs/technotes/guides/lang/resources.html]
>  of Java.
> To facilitate the deployment on production servers, the following 
> configuration is added in {{build.gradle}}
> {code:groovy}
> distributions.main.contents.from(rootDir) {
> include 'framework/**', 'applications/**', 'themes/**', 'plugins/**'
> }
> {code}
> However this doesn't solve the problem that OFBiz is not usable as a library 
> downloaded from a Jar repository. The proper solution would be to remove any 
> dependencies on OFBiz home directory and bundle every resource in 
> {{ofbiz.jar}}
> This has been [discussed on Development mailing 
> list|https://lists.apache.org/thread.html/c2612f1e296b6ea15872185871d3a9d83d6a4afc6d2a76f7a336a126@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11296) Use 'depends-on' everywhere

2019-11-26 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11296.
---
Resolution: Implemented

> Use 'depends-on' everywhere
> ---
>
> Key: OFBIZ-11296
> URL: https://issues.apache.org/jira/browse/OFBIZ-11296
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11296_0001-Improved-Use-depends-on-attribute-instead-of-compone.patch
>
>
> We currently have two ways to define component loading order. Either
> by using ‘depends-on’ attribute in “component-config.xml” or by adding
> a “component-load.xml” file at the root of a component directory.
> “depends-on” is more flexible because it handles partial ordering when
> “component-load.xml” defines a total order which is not necessarily
> meaningful, so it is better to rely only “depends-on”.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-11296) Use 'depends-on' everywhere

2019-11-26 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-11296:
-

> Use 'depends-on' everywhere
> ---
>
> Key: OFBIZ-11296
> URL: https://issues.apache.org/jira/browse/OFBIZ-11296
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11296_0001-Improved-Use-depends-on-attribute-instead-of-compone.patch
>
>
> We currently have two ways to define component loading order. Either
> by using ‘depends-on’ attribute in “component-config.xml” or by adding
> a “component-load.xml” file at the root of a component directory.
> “depends-on” is more flexible because it handles partial ordering when
> “component-load.xml” defines a total order which is not necessarily
> meaningful, so it is better to rely only “depends-on”.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)