[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets

2020-01-02 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006906#comment-17006906
 ] 

Nicolas Malin commented on OFBIZ-6510:
--

Hello [~bjugl] it's nice works however I didn't understand why you centralize 
all the generation on WebToolsDbEvents.java ?

Do we would be win more visibility and maintenability if we would beuse a ftl 
with a call to ModelEntity.toXmlElement function ?

> Replace webtools/control/view/ModelInduceFromDb with widgets
> 
>
> Key: OFBIZ-6510
> URL: https://issues.apache.org/jira/browse/OFBIZ-6510
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Christian Carlow
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, 
> OFBIZ-6510_ModelInduceFromDb.patch, OFBIZ-6510_ModelInduceFromDb_002.patch
>
>
> The page is written in JSP probably from very long ago when FTL and widgets 
> didn't even exist yet.  It should be implemented in widgets now that they are 
> available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10577) New Feature: Inventory Cycle Count

2020-01-02 Thread Mathieu Lirzin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006892#comment-17006892
 ] 

Mathieu Lirzin commented on OFBIZ-10577:


Hello [~ankit.joshi],

I am not sure to understand what an "inventory cycle count" mean. Can you 
expand on it?

Maybe that was already planned, but I recommend opening a discussion on 
d...@ofbiz.apache.org to allow other contributors to discuss the modelisation 
of that domain.

> New Feature: Inventory Cycle Count
> --
>
> Key: OFBIZ-10577
> URL: https://issues.apache.org/jira/browse/OFBIZ-10577
> Project: OFBiz
>  Issue Type: New Feature
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Yashwant Dhakad
>Assignee: Yashwant Dhakad
>Priority: Major
> Attachments: OFBIZ-10577-Database-Changes.patch
>
>
> *Here are the design notes for cycle count workflow:*
> *Find Session Screen:* In this screen, we will show all the sessions created 
> in the system with respect to the facility, locations, inventory count item, 
> current status, and created date. We have a search field to filter the 
> records on the basis of the facility, status.
> *Find Pending Locations:* In this screen, we have a table listing all the 
> pending locations whose countings are pending and we can create a session for 
> them. All details regarding the pending locations are listed here with the 
> location, next count date, last count date and days extended for the count, 
> total inventory item and product for this location. We have facets for 
> filtering the records on the basis of the facility, not scanned since and 
> scheduled for next scan. Also, we have a global search at the top of the 
> screen. In Pending Locations screen, we have a Create Session button. To 
> create a session we can either select one or more records from the below list 
> or create a new session by yourself.
> In Create Session screen, the basic overview is shown in the "Overview" 
> section and the items are listed in the "Items" section. We can create a new 
> line item by clicking on the 'Add' button and we can also update the item 
> quantity. After completing this, we can proceed with this session and mark it 
> with 'Pending for Review' status from the 'Status' button at the top of the 
> screen or we can simply 'Reject'. 'Reject' status button is available at the 
> top of the screen.
> *Find Review Screen:* In this screen, we have a table listing all the 
> locations pending for the review. All the details regarding the review 
> sessions are listed with the facility, locations and counted inventory item. 
> We have facets for filtering records on the basis of the facility. By 
> clicking any session we can go to its detail screen, where basic details 
> regarding this session are listed in the 'Overview' section and items are 
> listed in the 'Items' section. We can select any number of rows and mark them 
> as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the 
> variance is created and these are added in the Count Progress report. Only 
> authorized persons can accept or reject the sessions and once the session is 
> accepted it is marked as 'Completed'.
> *Count Progress Report:* In this screen, User can view the advanced counting 
> related analytics with respect to all the 'Completed' status session from 
> Reports Screen. We can filter the records on the basis of the facility and 
> within the date range. We can also see the percentage of the total locations, 
> inventory items counted and errors occurred during the process. Item variance 
> details are listed in the below section in tabular form.
> Following changes to the existing data model to support end to end counting 
> process flow:
> *New entities:*
> *InventoryCount*
>   inventoryCountId
>   uploadedByUserLogin
>   facilityId
>   statusId
>   createdDatetime
>  *InventoryCountItem*
>   inventoryCountId
>   inventoryCountItemSeqId
>   inventoryItemId
>   itemStatusId
>   locationSeqId
>   productId
>   productIdentifier
>   quantity
>  *InventoryCountVariance* 
>   inventoryCountId
>   inventoryCountItemSeqId
>   inventoryItemId
>   productId
>   productIdentifier
>   locationSeqId
>   systemQuantityOnHand
>   actualQuantityOnHand
>   varianceQuantityOnHand
>   totalCost
>   actualCost
>   costVariance
>   actualValue
>   totalValue
>   valueVariance
>   unitCost
>  *ProductCategoryFacilityLocation*
>   facilityId
>   locationSeqId
>   productCategoryId
>   fromDate
>   thruDate
>   isCountable
> *Extended entity:*
>  *FacilityLocation*
>   locked
>   lastCountDate
>   nextCountDate
>  *ProductCategory*
>   isCountable
> We will prevent following inbound and outbound transactions within the 
> application if the location is locked for counting:
> Inventory Transfer 
> 

[jira] [Updated] (OFBIZ-11314) Avoid stack overflow in the presence of cycles in controller inclusion

2020-01-02 Thread Mathieu Lirzin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin updated OFBIZ-11314:
---
Description: 
The inclusion of controller configuration files can lead to inclusion cycles 
which are not safely handled, because they can lead to infinite recursion that 
end up in stack overflow exception.

A very basic form of cycle is controllers A and B which includes each other.

I would be better to check the inclusion cycles and report an appropriate error.

  was:
The inclusion of controller configuration files can lead to inclusion cycles 
which are not safely handled, because they can lead to infinite recursion that 
end up in stack overflow exception.

A very basic form of cycle is controllers A and B which includes each other.

I would be better to checket the inclusion cycles and report an appropriate 
error.


> Avoid stack overflow in the presence of cycles in controller inclusion
> --
>
> Key: OFBIZ-11314
> URL: https://issues.apache.org/jira/browse/OFBIZ-11314
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments: 0001-Improved-Rewrite-Digraph.patch, 
> 0002-Improved-Detect-inclusion-cycles-in-controller-confi.patch
>
>
> The inclusion of controller configuration files can lead to inclusion cycles 
> which are not safely handled, because they can lead to infinite recursion 
> that end up in stack overflow exception.
> A very basic form of cycle is controllers A and B which includes each other.
> I would be better to check the inclusion cycles and report an appropriate 
> error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11314) Avoid stack overflow in the presence of cycles in controller inclusion

2020-01-02 Thread Mathieu Lirzin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006881#comment-17006881
 ] 

Mathieu Lirzin commented on OFBIZ-11314:


I will commit [^0001-Improved-Rewrite-Digraph.patch]  and  
[^0002-Improved-Detect-inclusion-cycles-in-controller-confi.patch]  in 3 days 
if nobody objects.

Those patches are meant to be applied in order and must be applied using {{git 
am XXX.patch}}.

> Avoid stack overflow in the presence of cycles in controller inclusion
> --
>
> Key: OFBIZ-11314
> URL: https://issues.apache.org/jira/browse/OFBIZ-11314
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments: 0001-Improved-Rewrite-Digraph.patch, 
> 0002-Improved-Detect-inclusion-cycles-in-controller-confi.patch
>
>
> The inclusion of controller configuration files can lead to inclusion cycles 
> which are not safely handled, because they can lead to infinite recursion 
> that end up in stack overflow exception.
> A very basic form of cycle is controllers A and B which includes each other.
> I would be better to checket the inclusion cycles and report an appropriate 
> error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11314) Avoid stack overflow in the presence of cycles in controller inclusion

2020-01-02 Thread Mathieu Lirzin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin updated OFBIZ-11314:
---
Attachment: 0002-Improved-Detect-inclusion-cycles-in-controller-confi.patch
0001-Improved-Rewrite-Digraph.patch

> Avoid stack overflow in the presence of cycles in controller inclusion
> --
>
> Key: OFBIZ-11314
> URL: https://issues.apache.org/jira/browse/OFBIZ-11314
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments: 0001-Improved-Rewrite-Digraph.patch, 
> 0002-Improved-Detect-inclusion-cycles-in-controller-confi.patch
>
>
> The inclusion of controller configuration files can lead to inclusion cycles 
> which are not safely handled, because they can lead to infinite recursion 
> that end up in stack overflow exception.
> A very basic form of cycle is controllers A and B which includes each other.
> I would be better to checket the inclusion cycles and report an appropriate 
> error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10577) New Feature: Inventory Cycle Count

2020-01-02 Thread Yashwant Dhakad (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad reassigned OFBIZ-10577:
---

Assignee: Yashwant Dhakad  (was: Ankit Joshi)

> New Feature: Inventory Cycle Count
> --
>
> Key: OFBIZ-10577
> URL: https://issues.apache.org/jira/browse/OFBIZ-10577
> Project: OFBiz
>  Issue Type: New Feature
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Yashwant Dhakad
>Assignee: Yashwant Dhakad
>Priority: Major
> Attachments: OFBIZ-10577-Database-Changes.patch
>
>
> *Here are the design notes for cycle count workflow:*
> *Find Session Screen:* In this screen, we will show all the sessions created 
> in the system with respect to the facility, locations, inventory count item, 
> current status, and created date. We have a search field to filter the 
> records on the basis of the facility, status.
> *Find Pending Locations:* In this screen, we have a table listing all the 
> pending locations whose countings are pending and we can create a session for 
> them. All details regarding the pending locations are listed here with the 
> location, next count date, last count date and days extended for the count, 
> total inventory item and product for this location. We have facets for 
> filtering the records on the basis of the facility, not scanned since and 
> scheduled for next scan. Also, we have a global search at the top of the 
> screen. In Pending Locations screen, we have a Create Session button. To 
> create a session we can either select one or more records from the below list 
> or create a new session by yourself.
> In Create Session screen, the basic overview is shown in the "Overview" 
> section and the items are listed in the "Items" section. We can create a new 
> line item by clicking on the 'Add' button and we can also update the item 
> quantity. After completing this, we can proceed with this session and mark it 
> with 'Pending for Review' status from the 'Status' button at the top of the 
> screen or we can simply 'Reject'. 'Reject' status button is available at the 
> top of the screen.
> *Find Review Screen:* In this screen, we have a table listing all the 
> locations pending for the review. All the details regarding the review 
> sessions are listed with the facility, locations and counted inventory item. 
> We have facets for filtering records on the basis of the facility. By 
> clicking any session we can go to its detail screen, where basic details 
> regarding this session are listed in the 'Overview' section and items are 
> listed in the 'Items' section. We can select any number of rows and mark them 
> as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the 
> variance is created and these are added in the Count Progress report. Only 
> authorized persons can accept or reject the sessions and once the session is 
> accepted it is marked as 'Completed'.
> *Count Progress Report:* In this screen, User can view the advanced counting 
> related analytics with respect to all the 'Completed' status session from 
> Reports Screen. We can filter the records on the basis of the facility and 
> within the date range. We can also see the percentage of the total locations, 
> inventory items counted and errors occurred during the process. Item variance 
> details are listed in the below section in tabular form.
> Following changes to the existing data model to support end to end counting 
> process flow:
> *New entities:*
> *InventoryCount*
>   inventoryCountId
>   uploadedByUserLogin
>   facilityId
>   statusId
>   createdDatetime
>  *InventoryCountItem*
>   inventoryCountId
>   inventoryCountItemSeqId
>   inventoryItemId
>   itemStatusId
>   locationSeqId
>   productId
>   productIdentifier
>   quantity
>  *InventoryCountVariance* 
>   inventoryCountId
>   inventoryCountItemSeqId
>   inventoryItemId
>   productId
>   productIdentifier
>   locationSeqId
>   systemQuantityOnHand
>   actualQuantityOnHand
>   varianceQuantityOnHand
>   totalCost
>   actualCost
>   costVariance
>   actualValue
>   totalValue
>   valueVariance
>   unitCost
>  *ProductCategoryFacilityLocation*
>   facilityId
>   locationSeqId
>   productCategoryId
>   fromDate
>   thruDate
>   isCountable
> *Extended entity:*
>  *FacilityLocation*
>   locked
>   lastCountDate
>   nextCountDate
>  *ProductCategory*
>   isCountable
> We will prevent following inbound and outbound transactions within the 
> application if the location is locked for counting:
> Inventory Transfer 
> Issuance against Sales Order 
> Sales Return receiving 
> Inventory receive 
> Issuance and return inventory in manufacturing Job
> Kit breakup 
> Update Location 
> Physical Variance creation
> The locked locations won’t have any bearing on the transactions that are 

[jira] [Issue Comment Deleted] (OFBIZ-5522) Introduce websocket usage

2020-01-02 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-5522:
---
Comment: was deleted

(was: Good happy to see this here and very thankful to you

https://dpviral.blogspot.com/

https://www.viraldpstatus.com/

https://www.viraldpstatus.com/2019/10/hindi-good-morning-thoughts-hd-images.html

https://dpviral.blogspot.com/2019/11/hindi-shayari-gf.html)

> Introduce websocket usage
> -
>
> Key: OFBIZ-5522
> URL: https://issues.apache.org/jira/browse/OFBIZ-5522
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> After a discussion with Ean, was suggested (draft here):
> You need a service that lets you "subscribe" a widget to an entity and
> then propagate change events to the widget as the entity is modified.
> A generic mechanism like that could eventually expand to be a general
> purpose "data bound widgets" system that mostly looks like the existing
> system but magically reflects updates.
> Could be used with/for
> * The entity cache and webforms to automatically update views when data 
> changes. 
> * Replaces the current system notes
> * Create a dashboard type pages  (to be discussed futher)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11314) Avoid stack overflow in the presence of cycles in controller inclusion

2020-01-02 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006698#comment-17006698
 ] 

Jacques Le Roux commented on OFBIZ-11314:
-

+1

> Avoid stack overflow in the presence of cycles in controller inclusion
> --
>
> Key: OFBIZ-11314
> URL: https://issues.apache.org/jira/browse/OFBIZ-11314
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
>
> The inclusion of controller configuration files can lead to inclusion cycles 
> which are not safely handled, because they can lead to infinite recursion 
> that end up in stack overflow exception.
> A very basic form of cycle is controllers A and B which includes each other.
> I would be better to checket the inclusion cycles and report an appropriate 
> error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)