[jira] [Commented] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047283#comment-17047283 ] ASF subversion and git services commented on OFBIZ-11418: - Commit cfad407c48840f951f5118a887c327b1e8d59562 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=cfad407 ] Merge pull request #34 from danwatford/ofbiz-11418-documentation OFBIZ-11418: Documented use of field attribute parameter-name and lookup field attribute target-parameter in widget-form.xsd > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Labels: patch-available > Time Spent: 20m > Remaining Estimate: 0h > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047282#comment-17047282 ] ASF subversion and git services commented on OFBIZ-11418: - Commit 5640de4eba0148e4a95d72528945866b7069d2ed in ofbiz-framework's branch refs/heads/trunk from Daniel Watford [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5640de4 ] Documented: Documented use of field attribute parameter-name and lookup field attribute target-parameter in widget-form.xsd (OFBIZ-11418) > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Labels: patch-available > Time Spent: 20m > Remaining Estimate: 0h > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047280#comment-17047280 ] Jacques Le Roux commented on OFBIZ-11418: - Great, thanks Daniel, Also could you please take care of the style (formatting). As you can see in the red stdio of https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1202 you have introduced some anomalies. You can refer to https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions, TIA. > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Labels: patch-available > Time Spent: 10m > Remaining Estimate: 0h > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047254#comment-17047254 ] Rohit Koushal commented on OFBIZ-6638: -- I tried same past week and faced same error, possibly due to that axis-1.4.jar has been moved somewhere esle in the jcenter repository. > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11426) Unable to view entity row record in webtools if PK contains timestamp field
[ https://issues.apache.org/jira/browse/OFBIZ-11426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047224#comment-17047224 ] Pawan Verma commented on OFBIZ-11426: - Not sure, but I suspect this is due to the changes done in https://issues.apache.org/jira/browse/OFBIZ-11007 > Unable to view entity row record in webtools if PK contains timestamp field > > > Key: OFBIZ-11426 > URL: https://issues.apache.org/jira/browse/OFBIZ-11426 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Pawan Verma >Priority: Major > Attachments: Error Screen.png > > > Unable to view entity row record in webtools if PK contains timestamp field. > Steps to regenerate: > # Go to > [https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/PartyRelationship] > # Try to open any record via view link > # IllegalArgumentException screen would be shown. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11426) Unable to view entity row record in webtools if PK contains timestamp field
Pawan Verma created OFBIZ-11426: --- Summary: Unable to view entity row record in webtools if PK contains timestamp field Key: OFBIZ-11426 URL: https://issues.apache.org/jira/browse/OFBIZ-11426 Project: OFBiz Issue Type: Bug Components: framework/webtools Affects Versions: Trunk Reporter: Pawan Verma Attachments: Error Screen.png Unable to view entity row record in webtools if PK contains timestamp field. Steps to regenerate: # Go to [https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/PartyRelationship] # Try to open any record via view link # IllegalArgumentException screen would be shown. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046972#comment-17046972 ] Daniel Watford commented on OFBIZ-11418: Hi [~jleroux], New PR raised to cover documentation of the target-parameter and parameter-name attributes in widget-form.xsd. [https://github.com/apache/ofbiz-framework/pull/34] Please take a look. > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Labels: patch-available > Time Spent: 10m > Remaining Estimate: 0h > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046965#comment-17046965 ] Jacques Le Roux commented on OFBIZ-11383: - BWT, A goo way to remember bq. Inserted trinary Operator (? : ) where possible It's Elvis ;) > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails
[
https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046879#comment-17046879
]
Jacques Le Roux commented on OFBIZ-6638:
Mmm,
I tried to replace in birt build.gradle
pluginLibsCompile('org.eclipse.birt.runtime:viewservlets:4.5.0')
by
pluginLibsCompile('org.eclipse.birt.runtime:viewservlets:4.3.1')
and, even when adding mavenCentral() repository, got
{noformat}
FAILURE: Build failed with an exception.
* Where:
Build file 'C:\projectsASF\Git\ofbiz-framework\build.gradle' line: 1043
* What went wrong:
A problem occurred evaluating root project 'ofbiz'.
> Could not resolve all files for configuration ':runtimeClasspath'.
> Could not find commons-discovery:axis:1.4.
Searched in the following locations:
- https://jcenter.bintray.com/commons-discovery/axis/1.4/axis-1.4.pom
- https://jcenter.bintray.com/commons-discovery/axis/1.4/axis-1.4.jar
-
file:/C:/Users/Jacques/.m2/repository/commons-discovery/axis/1.4/axis-1.4.pom
-
file:/C:/Users/Jacques/.m2/repository/commons-discovery/axis/1.4/axis-1.4.jar
-
https://repo.maven.apache.org/maven2/commons-discovery/axis/1.4/axis-1.4.pom
-
https://repo.maven.apache.org/maven2/commons-discovery/axis/1.4/axis-1.4.jar
Required by:
project : > project :plugins:birt >
org.eclipse.birt.runtime:viewservlets:4.3.1
{noformat}
Any ideas?
> TrialBalance PDF export fails
> -
>
> Key: OFBIZ-6638
> URL: https://issues.apache.org/jira/browse/OFBIZ-6638
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png
>
>
> # Get to
> http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company
> #pick a "Custom Time Period Id" (default works also)
> #Submit
> Then the CSV export works but not the PDF, this in trunk demo.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046853#comment-17046853 ] Jacques Le Roux commented on OFBIZ-11418: - Hi Daniel, Thanks for your work, could you please also modify the documentation of in widget-form.xsd. While at it it would be good to do it for parameter-name too, in relation with OFBIZ-11330 TIA > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Labels: patch-available > Time Spent: 10m > Remaining Estimate: 0h > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046851#comment-17046851 ] ASF subversion and git services commented on OFBIZ-11418: - Commit 08a371d0471a506e663c879f30299f424fc70921 in ofbiz-framework's branch refs/heads/trunk from Daniel Watford [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=08a371d ] Improved: Use FlexibleStringExpander in form widget lookup field field target parameters (OFBIZ-11418) Changed target-parameter attribute of the form widget's Lookup field to use the FlexibleStringExpander type rather than String. This has been done to allow reference to other form fields which may have had their parameter-name attribute set to a FlexibleStringExpander expression. > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Labels: patch-available > Time Spent: 10m > Remaining Estimate: 0h > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046848#comment-17046848 ] Priya Sharma commented on OFBIZ-11383: -- Wow [~bjugl], That's great learning for me. I will definitely keep these things in mind the next time I work on something. Thank you so much for the review. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11418: --- Assignee: Jacques Le Roux (was: Daniel Watford) > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Labels: patch-available > Time Spent: 10m > Remaining Estimate: 0h > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9352) Remove unused labels from AccountingUiLabels.xml
[ https://issues.apache.org/jira/browse/OFBIZ-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9352: --- Attachment: OFBIZ-9352-not-used.png > Remove unused labels from AccountingUiLabels.xml > > > Key: OFBIZ-9352 > URL: https://issues.apache.org/jira/browse/OFBIZ-9352 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Pierre Smits >Priority: Minor > Labels: cleanup > Attachments: OFBIZ-9352-not-used.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11407) Upgrade Tomcat from 9.0.29 to 9.0.31 (CVE-2020-1938)
[ https://issues.apache.org/jira/browse/OFBIZ-11407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046672#comment-17046672 ] ASF subversion and git services commented on OFBIZ-11407: - Commit 227ecf8023a13789a7ed739807e1d93ee7891e0c in ofbiz-plugins's branch refs/heads/release17.12 from Deepak Dixit [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=227ecf8 ] Upgrade Tomcat from 9.0.29 to 9.0.31 (CVE-2020-1938) (OFBIZ-11407) tomcat-embed-websocket dependencies not updated > Upgrade Tomcat from 9.0.29 to 9.0.31 (CVE-2020-1938) > > > Key: OFBIZ-11407 > URL: https://issues.apache.org/jira/browse/OFBIZ-11407 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > CVE-2020-1938 AJP Request Injection and potential Remote Code Execution > Severity: High > Vendor: The Apache Software Foundation > Versions Affected: > Apache Tomcat 9.0.0.M1 to 9.0.30 > Apache Tomcat 8.5.0 to 8.5.50 > Apache Tomcat 7.0.0 to 7.0.99 > Description: > When using the Apache JServ Protocol (AJP), care must be taken when > trusting incoming connections to Apache Tomcat. Tomcat treats AJP > connections as having higher trust than, for example, a similar HTTP > connection. If such connections are available to an attacker, they can > be exploited in ways that may be surprising. > Prior to Tomcat 9.0.31, 8.5.51 and 7.0.100, Tomcat shipped with an AJP > Connector enabled by default that listened on all configured IP > addresses. It was expected (and recommended in the security guide) that > this Connector would be disabled if not required. > Prior to this vulnerability report, the known risks of an attacker being > able to access the AJP port directly were: > - bypassing security checks based on client IP address > - bypassing user authentication if Tomcat was configured to trust > authentication data provided by the reverse proxy > This vulnerability report identified a mechanism that allowed the following: > - returning arbitrary files from anywhere in the web application > including under the WEB-INF and META-INF directories or any other > location reachable via ServletContext.getResourceAsStream() > - processing any file in the web application as a JSP > Further, if the web application allowed file upload and stored those > files within the web application (or the attacker was able to control > the content of the web application by some other means) then this, along > with the ability to process a file as a JSP, made remote code execution > possible. > Mitigation: > It is important to note that mitigation is only required if an AJP port > is accessible to untrusted users. > - If AJP support is not required, the Connector may be disabled e.g. by > removing the AJP Connector element from the server.xml file > - If AJP support is required, untrusted users may be prevented from > accessing the AJP port by one or more of the following means: > - configuring appropriate network firewall rules > - configuring an explicit address attribute to the connector so that > the Connector listens on a non-public interface > - configuring a shared secret for the AJP connection > Users wishing to take a defence-in-depth approach and block the vector > that permits returning arbitrary files and execution as JSP may upgrade to: > - Apache Tomcat 9.0.31 or later > - Apache Tomcat 8.5.51 or later > - Apache Tomcat 7.0.100 or later > Users should note that a number of changes were made to the default AJP > Connector configuration in these versions to harden the default > configuration. The changes are: > - The AJP Connector is commented out in the provided server.xml file. > - The "requiredSecret" attribute has been renamed "secret" (the old name > continues to work but is deprecated). > - A new attribute "secretRequired" has been added which defaults to > "true". When this attribute is "true", the AJP Connector will not > start unless a shared secret has been configured. > - The default listen address for the AJP Connector is now the loopback > address. > It is likely that users upgrading to 9.0.31, 8.5.51 or 7.0.100 and later > will need to make small changes to their configurations as a result. > References: > [1] http://tomcat.apache.org/security-9.html > [2] http://tomcat.apache.org/security-8.html > [3] http://tomcat.apache.org/securit -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11383: -- Attachment: OFBIZ-11383.patch > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11383: -- Attachment: (was: OFBIZ-11383.patch) > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11383: -- Attachment: OFBIZ-11383.patch > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11383: -- Attachment: (was: OFBIZ-11383.patch) > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[
https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046659#comment-17046659
]
Benjamin Jugl commented on OFBIZ-11383:
---
Hey Priya,
I did review your patch and intorduced some changes. Here is a nearly complete
list of the changes I did:
* Variable "module" should be defined in the class, so it scope includes all
other methods that will be added in the future.
* Variables should be declared with strong typing. This makes it more readable
and better to maintain (if you do not use any types, the variables are written
into the context object of the groovies "this". That is quite cumbersome to
debug.
* "createMain.dataResourceId" was declared twice, "createMain.assocTypeId" was
not declared. "createMain.partyId" was not declared.
* "createImage.contentNam" Typo, misses an "e"
* "createImage._uploadedFile_contentType" missing entirely.
* GroovyBaseScript.groovy provides a "run service" implementation. Not sure
how the overall preferences are, but its sheer existence implies that it should
be used...
* Inserted some {} for inline if-clauses. They can be omitted but reduce
readability
* Inserted trinary Operator (? : ) where possible
* Renamed variable "map" into "result"
> Convert createArticleContent service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11383
> URL: https://issues.apache.org/jira/browse/OFBIZ-11383
> Project: OFBiz
> Issue Type: Sub-task
> Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch
>
>
> Convert createArticleContent service code from mini-lang to groovy DSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11383: -- Attachment: OFBIZ-11383.patch > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11425) Test "POC for CSRF Token"
[ https://issues.apache.org/jira/browse/OFBIZ-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046658#comment-17046658 ] Jacques Le Roux commented on OFBIZ-11425: - Don't hesitate to assign yourself when you work on an issue related to the effort. > Test "POC for CSRF Token" > - > > Key: OFBIZ-11425 > URL: https://issues.apache.org/jira/browse/OFBIZ-11425 > Project: OFBiz > Issue Type: Test > Components: ALL APPLICATIONS >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > > Hi All, > This "test" Jira to ask your help to review and test the work done in > OFBIZ-11306. We have done all our possible, and now help is welcome. If you > are experienced with penetrations tools, please use them. > You can find the branch to use in > https://github.com/JacquesLeRoux/ofbiz-framework/tree/POC-for-CSRF-Token-OFBIZ-11306. > It's ready to merge in OFBiz trunk but we will not create a PR before being > rassured that we (James and I) did not miss any issues. Like links without > "csrf" token, or regressions introduced by the effort. > TIA -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11425) Test "POC for CSRF Token"
[ https://issues.apache.org/jira/browse/OFBIZ-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11425: Fix Version/s: (was: 17.12.02) (was: 18.12.01) > Test "POC for CSRF Token" > - > > Key: OFBIZ-11425 > URL: https://issues.apache.org/jira/browse/OFBIZ-11425 > Project: OFBiz > Issue Type: Test > Components: ALL APPLICATIONS >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > > Hi All, > This "test" Jira to ask your help to review and test the work done in > OFBIZ-11306. We have done all our possible, and now help is welcome. If you > are experienced with penetrations tools, please use them. > You can find the branch to use in > https://github.com/JacquesLeRoux/ofbiz-framework/tree/POC-for-CSRF-Token-OFBIZ-11306. > It's ready to merge in OFBiz trunk but we will not create a PR before being > rassured that we (James and I) did not miss any issues. Like links without > "csrf" token, or regressions introduced by the effort. > TIA -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046645#comment-17046645 ] Jacques Le Roux commented on OFBIZ-11306: - The test issue is OFBIZ-11425, let's go! > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative > merged with James's.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-v2.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > partyTokenMap.webtools.txt > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11425) Test "POC for CSRF Token"
Jacques Le Roux created OFBIZ-11425: --- Summary: Test "POC for CSRF Token" Key: OFBIZ-11425 URL: https://issues.apache.org/jira/browse/OFBIZ-11425 Project: OFBiz Issue Type: Test Components: ALL APPLICATIONS Affects Versions: Trunk, Release Branch 18.12, Release Branch 17.12 Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: 18.12.01, 17.12.02 Hi All, This "test" Jira to ask your help to review and test the work done in OFBIZ-11306. We have done all our possible, and now help is welcome. If you are experienced with penetrations tools, please use them. You can find the branch to use in https://github.com/JacquesLeRoux/ofbiz-framework/tree/POC-for-CSRF-Token-OFBIZ-11306. It's ready to merge in OFBiz trunk but we will not create a PR before being rassured that we (James and I) did not miss any issues. Like links without "csrf" token, or regressions introduced by the effort. TIA -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046632#comment-17046632 ] Jacques Le Roux commented on OFBIZ-11306: - Actually to not scramble minds of others, I'll create a new "test" Jira. There is too much to read here ;) > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative > merged with James's.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-v2.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > partyTokenMap.webtools.txt > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046630#comment-17046630 ] Jacques Le Roux commented on OFBIZ-11306: - Hi James I have deleted the remote branches in [Gitbox|https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=summary] and [GitHub|https://github.com/apache/ofbiz-framework]. They went there by mistake. We should only work on https://github.com/JacquesLeRoux/ofbiz-framework/tree/POC-for-CSRF-Token-OFBIZ-11306 I'll now ask help (review and tests) on dev ML... > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative > merged with James's.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-v2.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > partyTokenMap.webtools.txt > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046616#comment-17046616
]
Pierre Smits commented on OFBIZ-11030:
--
[~sberg]
Applying the patch gave following in a window in my git client (SourceTree)
{code:java}
git --no-optional-locks -c color.branch=false -c color.diff=false -c
color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c
credential.helper=sourcetree apply -v --reject -p 1
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:79:
trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:107:
trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:123:
trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:139:
trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:153:
trailing whitespace.
Checking patch bi/groovyScripts/FactServices.groovy...
Checking patch bi/minilang/FactServices.xml...
Checking patch bi/servicedef/services.xml...
Applied patch bi/groovyScripts/FactServices.groovy cleanly.
Applied patch bi/minilang/FactServices.xml cleanly.
Applied patch bi/servicedef/services.xml cleanly.
warning: squelched 49 whitespace errors
warning: 54 lines add whitespace errors.
Completed successfully
{code}
Apart from that, loadInventoryFact() now delivered an acceptable result in a
test.
> Convert FactServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11030
> URL: https://issues.apache.org/jira/browse/OFBIZ-11030
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Sebastian Berg
>Priority: Major
> Labels: Fact, dwh, services
> Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-InventoryItemFact-DemoTrunk.png,
> OFBIZ-11030-InventoryItemFact-test.png,
> OFBIZ-11030-Order-SalesOrder-overview.png,
> OFBIZ-11030-SalesInvoiceItemFact-test.png,
> OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046530#comment-17046530
]
Benjamin Jugl commented on OFBIZ-10688:
---
I can not reproduce the bug anymore. The data is stored and instead of the bug
mentioned above, another bug is thrown:
{noformat}
Could not convert field value for the field: [viewIndex] to the [Integer] type
for the value [null]: org.apache.ofbiz.base.util.GeneralException:
java.text.ParseException: Unparseable number: "null" (java.text.ParseException:
Unparseable number: "null"){noformat}
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10845) Product Search Constraint on CountBy...methods
[
https://issues.apache.org/jira/browse/OFBIZ-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043164#comment-17043164
]
Jacques Le Roux edited comment on OFBIZ-10845 at 2/27/20 11:18 AM:
---
Currently, I want to focus on OFBIZ-10353 that's I am releasing it for others :)
was (Author: pawan.verma):
Currently, I want to focus on https://issues.apache.org/jira/browse/OFBIZ-10353
that's I am releasing it for others :)
> Product Search Constraint on CountBy...methods
> --
>
> Key: OFBIZ-10845
> URL: https://issues.apache.org/jira/browse/OFBIZ-10845
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Priority: Minor
> Labels: search
> Fix For: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12
>
> Attachments: SearchCount.patch
>
>
> If a search constraint like featuresId or categorieId is applied, the
> CountBy...methods in the ProductSearchSession fail.
> Error: mainProductId field is missing.
> Attached is a patch that fixes the problem.
> *Test:*
> # Enable LayeredNavigation function in ecommerce module.
> # Add feature "TEXT_BLACK" to product GZ-1000 as standard feature
> # Add "ProductSearchSession.searchAddConstraint(new
> ProductSearch.FeatureConstraint("TEXT_BLACK", true), session);" in
> LayeredNavigation.groovy before "result =
> ProductSearchSession.getProductSearchResult(request, delegator,
> prodCatalogId);"
> # Navigate to the product via category menu.
> # --> GZ-1000 should not be visible + no error message
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10845) Product Search Constraint on CountBy...methods
[
https://issues.apache.org/jira/browse/OFBIZ-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046513#comment-17046513
]
Jacques Le Roux commented on OFBIZ-10845:
-
I confirm for achived releases, saw that already.
> Product Search Constraint on CountBy...methods
> --
>
> Key: OFBIZ-10845
> URL: https://issues.apache.org/jira/browse/OFBIZ-10845
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Priority: Minor
> Labels: search
> Fix For: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12
>
> Attachments: SearchCount.patch
>
>
> If a search constraint like featuresId or categorieId is applied, the
> CountBy...methods in the ProductSearchSession fail.
> Error: mainProductId field is missing.
> Attached is a patch that fixes the problem.
> *Test:*
> # Enable LayeredNavigation function in ecommerce module.
> # Add feature "TEXT_BLACK" to product GZ-1000 as standard feature
> # Add "ProductSearchSession.searchAddConstraint(new
> ProductSearch.FeatureConstraint("TEXT_BLACK", true), session);" in
> LayeredNavigation.groovy before "result =
> ProductSearchSession.getProductSearchResult(request, delegator,
> prodCatalogId);"
> # Navigate to the product via category menu.
> # --> GZ-1000 should not be visible + no error message
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-6705:
-
Affects Version/s: Release Branch 17.12
Release Branch 18.12
Trunk
> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: 17.12.02
>
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch,
> OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:
> if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
> = request.getParameter("viewIndex") ?
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
> = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy:
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-6705:
-
Fix Version/s: (was: 17.12.02)
> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch,
> OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:
> if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
> = request.getParameter("viewIndex") ?
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
> = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy:
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato updated OFBIZ-9254:
-
Fix Version/s: (was: 17.12.01)
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins_groovy.patch,
> OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-9465) Replace Inline Javascript with External Javascript
[ https://issues.apache.org/jira/browse/OFBIZ-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-9465: - Fix Version/s: (was: 17.12.01) > Replace Inline Javascript with External Javascript > --- > > Key: OFBIZ-9465 > URL: https://issues.apache.org/jira/browse/OFBIZ-9465 > Project: OFBiz > Issue Type: Improvement >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-9465.patch, OFBIZ-9465.patch, OFBIZ-9465.patch, > OFBIZ-9465.patch, OFBIZ-9465_example.patch, OFBIZ-9465_example.patch > > > As discussed in http://ofbiz.markmail.org/thread/ti54omjdt4fy662m inline > javascript for various macros like renderLookupField, > makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl should be > replaced with a generic code written as external javascript. Generic > Javascript code should be written in OfbizUtil.js and appropriate classes or > identifiers should be used for applying that. Any additional data can be > passed with HTML 5 custom data attribute > (https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#embedding-custom-non-visible-data-with-the-data-attributes). > As suggested by Jacques in https://s.apache.org/y8P1 will introduce > require.js for the split javascript files in a sub-task. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-7467) WebSocket Example - Push Notifications
[ https://issues.apache.org/jira/browse/OFBIZ-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-7467: - Fix Version/s: (was: 17.12.01) > WebSocket Example - Push Notifications > -- > > Key: OFBIZ-7467 > URL: https://issues.apache.org/jira/browse/OFBIZ-7467 > Project: OFBiz > Issue Type: Sub-task > Components: example >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Jacques Le Roux >Priority: Major > Fix For: 16.11.01 > > Attachments: OFBIZ-7467.patch, OFBIZ-7483-Screen-Shot.png > > > This is a ticket for adding working example (in example application) of > WebSocket support that has been done in OFBIZ-7073 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-7112) EntityUtilProperties
[ https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-7112: - Fix Version/s: (was: 17.12.01) > EntityUtilProperties > > > Key: OFBIZ-7112 > URL: https://issues.apache.org/jira/browse/OFBIZ-7112 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Wai >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch, > OFBIZ-7112.patch, OFBIZ-7112.patch > > > Ofbiz reads properties from either a properties file or the > entity:SystemProperty. The way it works previously is that ofbiz reads from > the entity:SystemProperty first and if there is no value associated with the > target propertyname, it would then locate the value from the relevant > properties file. > In other words, if there is a database entry for a property, the database > entry should override the associated properties file. > The issue is that if a database entry exist but the value is empty, it would > look for a value from the properties file. It should not do so. If a > database entry exists for the propertyname of interest, the value should be > taken from the database even if it holds an empty value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6650) Blank page when ordering an open-gismo-GZ-1006-p
[ https://issues.apache.org/jira/browse/OFBIZ-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-6650: - Fix Version/s: (was: 17.12.01) > Blank page when ordering an open-gismo-GZ-1006-p > > > Key: OFBIZ-6650 > URL: https://issues.apache.org/jira/browse/OFBIZ-6650 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Attachments: Image 095.png, Image 096.png, Image 097.png, Image > 098.png > > > This issue is also happenning in stable and old demo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6212) Accounting financial summary reports fail
[
https://issues.apache.org/jira/browse/OFBIZ-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato updated OFBIZ-6212:
-
Fix Version/s: (was: 17.12.01)
> Accounting financial summary reports fail
> --
>
> Key: OFBIZ-6212
> URL: https://issues.apache.org/jira/browse/OFBIZ-6212
> Project: OFBiz
> Issue Type: Bug
> Components: accounting, birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 14.12.01
>
> Attachments: OFBIZ-6212-1.patch
>
>
> Below are the issues:
> 1).
> http://demo-trunk-ofbiz.apache.org/accounting/control/FinancialSummaryReportOptions?organizationPartyId=Company
> 1st report: groovy file error, others miss request-maps
> 2). http://demo-trunk-ofbiz.apache.org/accounting/control/TrialBalance
> {noformat}
> ERROR rendering error page [/error/error.jsp], but here is the error text:
> org.ofbiz.widget.renderer.ScreenRenderException:
> Error rendering screen
> [component://accounting/widget/ReportFinancialSummaryScreens.xml#TrialBalance]:
> java.lang.IllegalArgumentException:
> Error calling service with name getPartyAccountingPreferences:
> org.ofbiz.service.ServiceValidationException:
> Le paramètre requis suivant manque :
> [getPartyAccountingPreferences.organizationPartyId]
> {noformat}
> 3).
> The followings are Birt issues
>
> http://demo-trunk-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
> (PFD export)
>
> http://demo-trunk-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
> (PFD export)
> They work in stable demo, there is no Birt there
>
> http://demo-stable-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
> (PFD export)
>
> http://demo-stable-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
> (PFD export)
> These issues should be addressed separately in sub-tasks each, I have not
> time to do that yet...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10722) Date-find error when used in two forms of a same screen
[ https://issues.apache.org/jira/browse/OFBIZ-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-10722. - Resolution: Fixed > Date-find error when used in two forms of a same screen > --- > > Key: OFBIZ-10722 > URL: https://issues.apache.org/jira/browse/OFBIZ-10722 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Leila Mekika >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01 > > Attachments: CsvFormMacroLibrary.ftl.rej, FoFormMacroLibrary.ftl.rej, > HtmlFormMacroLibrary.ftl.rej, OFBIZ-10722.patch, > TextFormMacroLibrary.ftl.rej, XlsFormMacroLibrary.ftl.rej, > XmlFormMacroLibrary.ftl.rej > > > When we have more than one form, in a screen, that use a date-find field, the > second date-find picker is not working. > To reproduce, you can add a new form with a date-find and call it below > FindInvoices in FindInvoices screen > Then load page [https://localhost:8443/accounting/control/findInvoices] . You > should see that there is no picker on ne second date-find > > The patch adds an id that allow renderDateFindField macro script to work for > both fields -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6866) Add links to edit/delete a term, for instance from the list
[ https://issues.apache.org/jira/browse/OFBIZ-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-6866: - Fix Version/s: (was: 17.12.01) > Add links to edit/delete a term, for instance from the list > --- > > Key: OFBIZ-6866 > URL: https://issues.apache.org/jira/browse/OFBIZ-6866 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-6866-InvoiceScreens.xml.patch, OFBIZ-6866.patch, > OFBIZ-6866.patch > > > Currently in UI there is no way to edit nor delete a term -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10799) User is unable to update the review of product.
[ https://issues.apache.org/jira/browse/OFBIZ-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-10799: -- Fix Version/s: (was: 18.12.01) (was: 17.12.01) > User is unable to update the review of product. > --- > > Key: OFBIZ-10799 > URL: https://issues.apache.org/jira/browse/OFBIZ-10799 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11, Release Branch 17.12, Trunk >Reporter: Ashish Sharma >Assignee: Rohit Hukkeri >Priority: Major > Attachments: OFBIZ-10799-1.patch, OFBIZ-10799.patch, Screenshot > 2019-10-04 at 1.02.15 PM.png > > > *See: https://demo-trunk.ofbiz.apache.org/catalog/control/FindReviews* > > *Step to Reproduce* > # Login with valid username and password. > # Navigate to catalog->review. > # Search for product in which review is available or click on find. > # Click on update button. > *Expected Result:* User should be able to update the review of product. > *Actual Result:* Once click on update button. Blank screen is displayed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10760) Errors and warnings in webtools' ArtifactInfo
[
https://issues.apache.org/jira/browse/OFBIZ-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato updated OFBIZ-10760:
--
Fix Version/s: (was: 18.12.01)
> Errors and warnings in webtools' ArtifactInfo
> -
>
> Key: OFBIZ-10760
> URL: https://issues.apache.org/jira/browse/OFBIZ-10760
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Major
> Attachments: ArtifactInfo.log,
> OFBIZ-10760_Fixed-Remove-updateEntitySyncRunning-service.patch,
> OFBIZ-10760_Fixed-Removing-unused-services.patch,
> OFBIZ-10760_Fixed-declare-entity-auto-services-properly.patch
>
>
> When running {{https://localhost:8443/webtools/control/ArtifactInfo}}
> multiple warnings and errors are logged, including missing definition of
> services and {{null}} pointer exceptions.
> The filtered log is available in [^ArtifactInfo.log] .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10760) Errors and warnings in webtools' ArtifactInfo
[
https://issues.apache.org/jira/browse/OFBIZ-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato updated OFBIZ-10760:
--
Fix Version/s: (was: 17.12.01)
> Errors and warnings in webtools' ArtifactInfo
> -
>
> Key: OFBIZ-10760
> URL: https://issues.apache.org/jira/browse/OFBIZ-10760
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 18.12.01
>
> Attachments: ArtifactInfo.log,
> OFBIZ-10760_Fixed-Remove-updateEntitySyncRunning-service.patch,
> OFBIZ-10760_Fixed-Removing-unused-services.patch,
> OFBIZ-10760_Fixed-declare-entity-auto-services-properly.patch
>
>
> When running {{https://localhost:8443/webtools/control/ArtifactInfo}}
> multiple warnings and errors are logged, including missing definition of
> services and {{null}} pointer exceptions.
> The filtered log is available in [^ArtifactInfo.log] .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11424) createPartyContent not working
[ https://issues.apache.org/jira/browse/OFBIZ-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11424: --- Description: go to Party -> search -> select any PartyId -> Party Content Create will produce the following error: "The Following Errors Occurred: layoutEvents.no_files_uploaded" was: go to Party --> search --> select any PartyId --> Party Content Create will produce the following error: "The Following Errors Occurred: layoutEvents.no_files_uploaded" > createPartyContent not working > -- > > Key: OFBIZ-11424 > URL: https://issues.apache.org/jira/browse/OFBIZ-11424 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Sebastian Berg >Priority: Major > Fix For: Upcoming Branch > > > go to Party -> search -> select any PartyId -> Party Content > Create will produce the following error: > "The Following Errors Occurred: > layoutEvents.no_files_uploaded" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11424) createPartyContent not working
[ https://issues.apache.org/jira/browse/OFBIZ-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reassigned OFBIZ-11424: -- Assignee: (was: Sebastian Berg) > createPartyContent not working > -- > > Key: OFBIZ-11424 > URL: https://issues.apache.org/jira/browse/OFBIZ-11424 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Sebastian Berg >Priority: Major > Fix For: Upcoming Branch > > > go to Party --> search --> select any PartyId --> Party Content > Create will produce the following error: > "The Following Errors Occurred: > layoutEvents.no_files_uploaded" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11424) createPartyContent not working
Sebastian Berg created OFBIZ-11424: -- Summary: createPartyContent not working Key: OFBIZ-11424 URL: https://issues.apache.org/jira/browse/OFBIZ-11424 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch go to Party --> search --> select any PartyId --> Party Content Create will produce the following error: "The Following Errors Occurred: layoutEvents.no_files_uploaded" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11399) Update India Geo information according to ISO notifications 2019-11-22
[ https://issues.apache.org/jira/browse/OFBIZ-11399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11399: -- Fix Version/s: 17.12.01 18.12.01 > Update India Geo information according to ISO notifications 2019-11-22 > -- > > Key: OFBIZ-11399 > URL: https://issues.apache.org/jira/browse/OFBIZ-11399 > Project: OFBiz > Issue Type: Improvement >Affects Versions: 16.11.07, Release Branch 18.12, Release Branch 17.12, > Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Fix For: 16.11.08, 18.12.01, 17.12.01 > > > Update the IND geo information published on 2019-11-22 iso notifications > https://isotc.iso.org/livelink/livelink/fetch/-14762372/14762396/16474544/16879393/20901554/N1016_%2D_Consolidation_of_the_2019_update_of_ISO_3166%2D2%2Dwebsite.pdf?nodeid=20902555=-2 > Change of subdivision category from state to Union territory for IN-JK; > Addition of Union territory IN-LA; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11399) Update India Geo information according to ISO notifications 2019-11-22
[ https://issues.apache.org/jira/browse/OFBIZ-11399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11399: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 Trunk > Update India Geo information according to ISO notifications 2019-11-22 > -- > > Key: OFBIZ-11399 > URL: https://issues.apache.org/jira/browse/OFBIZ-11399 > Project: OFBiz > Issue Type: Improvement >Affects Versions: 16.11.07, Release Branch 18.12, Release Branch 17.12, > Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Fix For: 16.11.08 > > > Update the IND geo information published on 2019-11-22 iso notifications > https://isotc.iso.org/livelink/livelink/fetch/-14762372/14762396/16474544/16879393/20901554/N1016_%2D_Consolidation_of_the_2019_update_of_ISO_3166%2D2%2Dwebsite.pdf?nodeid=20902555=-2 > Change of subdivision category from state to Union territory for IN-JK; > Addition of Union territory IN-LA; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10845) Product Search Constraint on CountBy...methods
[
https://issues.apache.org/jira/browse/OFBIZ-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046391#comment-17046391
]
Michael Brohl commented on OFBIZ-10845:
---
Adjusted the versions, seems that archived releases cannot be removed from fix
versions though.
> Product Search Constraint on CountBy...methods
> --
>
> Key: OFBIZ-10845
> URL: https://issues.apache.org/jira/browse/OFBIZ-10845
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Priority: Minor
> Labels: search
> Fix For: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12
>
> Attachments: SearchCount.patch
>
>
> If a search constraint like featuresId or categorieId is applied, the
> CountBy...methods in the ProductSearchSession fail.
> Error: mainProductId field is missing.
> Attached is a patch that fixes the problem.
> *Test:*
> # Enable LayeredNavigation function in ecommerce module.
> # Add feature "TEXT_BLACK" to product GZ-1000 as standard feature
> # Add "ProductSearchSession.searchAddConstraint(new
> ProductSearch.FeatureConstraint("TEXT_BLACK", true), session);" in
> LayeredNavigation.groovy before "result =
> ProductSearchSession.getProductSearchResult(request, delegator,
> prodCatalogId);"
> # Navigate to the product via category menu.
> # --> GZ-1000 should not be visible + no error message
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10845) Product Search Constraint on CountBy...methods
[
https://issues.apache.org/jira/browse/OFBIZ-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-10845:
--
Fix Version/s: (was: Upcoming Branch)
> Product Search Constraint on CountBy...methods
> --
>
> Key: OFBIZ-10845
> URL: https://issues.apache.org/jira/browse/OFBIZ-10845
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Priority: Minor
> Labels: search
> Fix For: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12
>
> Attachments: SearchCount.patch
>
>
> If a search constraint like featuresId or categorieId is applied, the
> CountBy...methods in the ProductSearchSession fail.
> Error: mainProductId field is missing.
> Attached is a patch that fixes the problem.
> *Test:*
> # Enable LayeredNavigation function in ecommerce module.
> # Add feature "TEXT_BLACK" to product GZ-1000 as standard feature
> # Add "ProductSearchSession.searchAddConstraint(new
> ProductSearch.FeatureConstraint("TEXT_BLACK", true), session);" in
> LayeredNavigation.groovy before "result =
> ProductSearchSession.getProductSearchResult(request, delegator,
> prodCatalogId);"
> # Navigate to the product via category menu.
> # --> GZ-1000 should not be visible + no error message
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10845) Product Search Constraint on CountBy...methods
[
https://issues.apache.org/jira/browse/OFBIZ-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-10845:
--
Fix Version/s: Upcoming Branch
> Product Search Constraint on CountBy...methods
> --
>
> Key: OFBIZ-10845
> URL: https://issues.apache.org/jira/browse/OFBIZ-10845
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Priority: Minor
> Labels: search
> Fix For: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12, Upcoming Branch
>
> Attachments: SearchCount.patch
>
>
> If a search constraint like featuresId or categorieId is applied, the
> CountBy...methods in the ProductSearchSession fail.
> Error: mainProductId field is missing.
> Attached is a patch that fixes the problem.
> *Test:*
> # Enable LayeredNavigation function in ecommerce module.
> # Add feature "TEXT_BLACK" to product GZ-1000 as standard feature
> # Add "ProductSearchSession.searchAddConstraint(new
> ProductSearch.FeatureConstraint("TEXT_BLACK", true), session);" in
> LayeredNavigation.groovy before "result =
> ProductSearchSession.getProductSearchResult(request, delegator,
> prodCatalogId);"
> # Navigate to the product via category menu.
> # --> GZ-1000 should not be visible + no error message
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10845) Product Search Constraint on CountBy...methods
[
https://issues.apache.org/jira/browse/OFBIZ-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-10845:
--
Affects Version/s: Release Branch 17.12
Release Branch 18.12
> Product Search Constraint on CountBy...methods
> --
>
> Key: OFBIZ-10845
> URL: https://issues.apache.org/jira/browse/OFBIZ-10845
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Priority: Minor
> Labels: search
> Fix For: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12, Release Branch 16.11, Trunk
>
> Attachments: SearchCount.patch
>
>
> If a search constraint like featuresId or categorieId is applied, the
> CountBy...methods in the ProductSearchSession fail.
> Error: mainProductId field is missing.
> Attached is a patch that fixes the problem.
> *Test:*
> # Enable LayeredNavigation function in ecommerce module.
> # Add feature "TEXT_BLACK" to product GZ-1000 as standard feature
> # Add "ProductSearchSession.searchAddConstraint(new
> ProductSearch.FeatureConstraint("TEXT_BLACK", true), session);" in
> LayeredNavigation.groovy before "result =
> ProductSearchSession.getProductSearchResult(request, delegator,
> prodCatalogId);"
> # Navigate to the product via category menu.
> # --> GZ-1000 should not be visible + no error message
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10845) Product Search Constraint on CountBy...methods
[
https://issues.apache.org/jira/browse/OFBIZ-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-10845:
--
Fix Version/s: (was: Release Branch 16.11)
(was: Trunk)
> Product Search Constraint on CountBy...methods
> --
>
> Key: OFBIZ-10845
> URL: https://issues.apache.org/jira/browse/OFBIZ-10845
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Priority: Minor
> Labels: search
> Fix For: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12
>
> Attachments: SearchCount.patch
>
>
> If a search constraint like featuresId or categorieId is applied, the
> CountBy...methods in the ProductSearchSession fail.
> Error: mainProductId field is missing.
> Attached is a patch that fixes the problem.
> *Test:*
> # Enable LayeredNavigation function in ecommerce module.
> # Add feature "TEXT_BLACK" to product GZ-1000 as standard feature
> # Add "ProductSearchSession.searchAddConstraint(new
> ProductSearch.FeatureConstraint("TEXT_BLACK", true), session);" in
> LayeredNavigation.groovy before "result =
> ProductSearchSession.getProductSearchResult(request, delegator,
> prodCatalogId);"
> # Navigate to the product via category menu.
> # --> GZ-1000 should not be visible + no error message
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11234) Invoice status fails to update after payment application
[ https://issues.apache.org/jira/browse/OFBIZ-11234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11234: -- Affects Version/s: (was: 16.11.07) Release Branch 17.12 Release Branch 18.12 Trunk > Invoice status fails to update after payment application > > > Key: OFBIZ-11234 > URL: https://issues.apache.org/jira/browse/OFBIZ-11234 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk > Environment: Ofbiz 16.11.06 > Database Mariadb > >Reporter: Parminder >Assignee: Harman kaur Matharu >Priority: Major > Labels: invoice > Fix For: Release Branch 16.11 > > > The invoice status fails to change (to paid etc.) after applying payment to > it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11234) Invoice status fails to update after payment application
[ https://issues.apache.org/jira/browse/OFBIZ-11234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11234: -- Fix Version/s: (was: Release Branch 16.11) > Invoice status fails to update after payment application > > > Key: OFBIZ-11234 > URL: https://issues.apache.org/jira/browse/OFBIZ-11234 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk > Environment: Ofbiz 16.11.06 > Database Mariadb > >Reporter: Parminder >Assignee: Harman kaur Matharu >Priority: Major > Labels: invoice > > The invoice status fails to change (to paid etc.) after applying payment to > it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11120) Issue while creating an order for product of type (Fixed) Asset Usage
[ https://issues.apache.org/jira/browse/OFBIZ-11120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11120: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 Trunk > Issue while creating an order for product of type (Fixed) Asset Usage > - > > Key: OFBIZ-11120 > URL: https://issues.apache.org/jira/browse/OFBIZ-11120 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Vedansh Tiwari >Assignee: Amit Gadaley >Priority: Major > Labels: asset > Attachments: ProductAO03.png, ProductAO04.png, ProductAO1.png, > ProductAO2.png > > > Steps to regenerate > # Login to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem] > # Click on the product lookup icon > # Click on the "Find" button > # Select the "(Fixed) Asset Usage" product (FORKLIFT_PROPANE) > # Click on "Add to order" button > Actual: Error message "The following occurred: Enter Booking Information > Before Adding to Cart" is showing. Please refer the attachment: ProductAO1.jpg > Expected: Error message should be corrected > > Issue 2: > Steps to regenerate: > # Login to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem] > # Click on the product lookup icon > # Click on the "Find" button > # Select the "(Fixed) Asset Usage" product (FORKLIFT_PROPANE) > # Click on "Add to order" button > # Select the date and time > # Click on the "Add to cart" > # Again click on the product look-up for selecting the product. > > Actual: UI issue on the model. Please refer the attachment: ProductAO04 > > Note: please refer the attachment. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11120) Issue while creating an order for product of type (Fixed) Asset Usage
[ https://issues.apache.org/jira/browse/OFBIZ-11120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11120: -- Fix Version/s: (was: Release Branch 16.11) (was: Trunk) > Issue while creating an order for product of type (Fixed) Asset Usage > - > > Key: OFBIZ-11120 > URL: https://issues.apache.org/jira/browse/OFBIZ-11120 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Vedansh Tiwari >Assignee: Amit Gadaley >Priority: Major > Labels: asset > Attachments: ProductAO03.png, ProductAO04.png, ProductAO1.png, > ProductAO2.png > > > Steps to regenerate > # Login to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem] > # Click on the product lookup icon > # Click on the "Find" button > # Select the "(Fixed) Asset Usage" product (FORKLIFT_PROPANE) > # Click on "Add to order" button > Actual: Error message "The following occurred: Enter Booking Information > Before Adding to Cart" is showing. Please refer the attachment: ProductAO1.jpg > Expected: Error message should be corrected > > Issue 2: > Steps to regenerate: > # Login to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem] > # Click on the product lookup icon > # Click on the "Find" button > # Select the "(Fixed) Asset Usage" product (FORKLIFT_PROPANE) > # Click on "Add to order" button > # Select the date and time > # Click on the "Add to cart" > # Again click on the product look-up for selecting the product. > > Actual: UI issue on the model. Please refer the attachment: ProductAO04 > > Note: please refer the attachment. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10831) Re-reservation of Inventory Items when Ship Group Destination Address or Shipment Method is updated in Sales Order
[ https://issues.apache.org/jira/browse/OFBIZ-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10831: -- Fix Version/s: (was: Release Branch 16.11) > Re-reservation of Inventory Items when Ship Group Destination Address or > Shipment Method is updated in Sales Order > -- > > Key: OFBIZ-10831 > URL: https://issues.apache.org/jira/browse/OFBIZ-10831 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Vijay Ganesh >Assignee: Aditi Patidar >Priority: Major > Attachments: image-2019-04-27-12-32-44-743.png, > image-2019-04-27-12-34-57-818.png, image-2019-04-27-12-46-52-368.png > > > Hi, > We came across this issue recently and also have fixed the same. > After creating a sales order and approving it, we created a shipment and > receive all the items and change the status to Packed. > Moving to the sales order edit screen. We are able to update the Ship Group > Destination Address or Shipment Method. Even without changing anything if we > simply click the update button, Inventory re-reservation service is being > called and getting re-reserved. Since there are no records in the > [OrderItemShipGrpInvRes|https://localhost:8443/webtools/control/FindGeneric?entityName=OrderItemShipGrpInvRes] > Entity, the inventory values are getting re-reserved again and this is a > major issue. > For a Sales Order of quantity 10, after approving and creating a shipment, we > issue 10 items and change status to packed. Now we go to the Order View/Edit > Screen and update the shipment method/Address or simply click the update > button and the quantity in the Shipment for that order changes to 20 which > should not happen. > > The fix we made is passing a hidden variable from the shipping Info Section > and when clicking the update button, we pass that value to the Inventory > Re-reservation event and check the value in that method. > In the loadCartForUpdate method in OrderService.java, we pass the checkValue > to see whether this request is coming from the Shipping Information update > section and prevent the cancelOrderInventoryReservation service from calling. > In the saveUpdatedCartToOrder method in OrderService.java using the same > checkValue, we prevent the reserveInventory service from calling. > This occurs when an existing shipment is in packed status for an order and > that order's shipping information needs to be edited. > This was an issue in our case and we fixed this way. > If it is ok we will provide the patch here?. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10831) Re-reservation of Inventory Items when Ship Group Destination Address or Shipment Method is updated in Sales Order
[ https://issues.apache.org/jira/browse/OFBIZ-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10831: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 Trunk > Re-reservation of Inventory Items when Ship Group Destination Address or > Shipment Method is updated in Sales Order > -- > > Key: OFBIZ-10831 > URL: https://issues.apache.org/jira/browse/OFBIZ-10831 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Vijay Ganesh >Assignee: Aditi Patidar >Priority: Major > Fix For: Release Branch 16.11 > > Attachments: image-2019-04-27-12-32-44-743.png, > image-2019-04-27-12-34-57-818.png, image-2019-04-27-12-46-52-368.png > > > Hi, > We came across this issue recently and also have fixed the same. > After creating a sales order and approving it, we created a shipment and > receive all the items and change the status to Packed. > Moving to the sales order edit screen. We are able to update the Ship Group > Destination Address or Shipment Method. Even without changing anything if we > simply click the update button, Inventory re-reservation service is being > called and getting re-reserved. Since there are no records in the > [OrderItemShipGrpInvRes|https://localhost:8443/webtools/control/FindGeneric?entityName=OrderItemShipGrpInvRes] > Entity, the inventory values are getting re-reserved again and this is a > major issue. > For a Sales Order of quantity 10, after approving and creating a shipment, we > issue 10 items and change status to packed. Now we go to the Order View/Edit > Screen and update the shipment method/Address or simply click the update > button and the quantity in the Shipment for that order changes to 20 which > should not happen. > > The fix we made is passing a hidden variable from the shipping Info Section > and when clicking the update button, we pass that value to the Inventory > Re-reservation event and check the value in that method. > In the loadCartForUpdate method in OrderService.java, we pass the checkValue > to see whether this request is coming from the Shipping Information update > section and prevent the cancelOrderInventoryReservation service from calling. > In the saveUpdatedCartToOrder method in OrderService.java using the same > checkValue, we prevent the reserveInventory service from calling. > This occurs when an existing shipment is in packed status for an order and > that order's shipping information needs to be edited. > This was an issue in our case and we fixed this way. > If it is ok we will provide the patch here?. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10883) Picklist is in Input status even after order is completed
[ https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046371#comment-17046371 ] Suraj Khurana commented on OFBIZ-10883: --- Thanks [~mbrohl]. > Picklist is in Input status even after order is completed > - > > Key: OFBIZ-10883 > URL: https://issues.apache.org/jira/browse/OFBIZ-10883 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Suraj Khurana >Priority: Major > Fix For: 18.12.01, 17.12.01 > > Attachments: OFBIZ-10883-new.patch, OFBIZ-10883.patch, > OrderStatus.jpg, PicklistStatus.jpg > > > Steps to regenerate: > 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main > 2. Create order > 3. Open > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse > 4. Create Picking > 5. Click on Packing under the facility > 6. Enter order id and click on pack order > 7. Enter package detail and complete packaging > 8. Open > https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse > Actual: Picklist is in the input status > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046358#comment-17046358 ] Pierre Smits commented on OFBIZ-11030: -- No worries, [~sberg]. Human errors do happen. For all kinds of reasons. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046355#comment-17046355 ] Sebastian Berg commented on OFBIZ-11030: You are right [~pierresmits] in loadInventoryFact() were some if-clauses in the wrong place. It should be fine now. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11030: --- Attachment: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0
[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-6705:
-
Fix Version/s: (was: 17.12.01)
17.12.02
> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: 17.12.02
>
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch,
> OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:
> if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
> = request.getParameter("viewIndex") ?
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
> = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy:
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10883) Picklist is in Input status even after order is completed
[ https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10883. - Fix Version/s: (was: 17.12.02) 17.12.01 Resolution: Fixed Closing again with the correct release branch 17.12.01 (we will have a new dist/vote). We should create a new Jira for the checkstyle issues. > Picklist is in Input status even after order is completed > - > > Key: OFBIZ-10883 > URL: https://issues.apache.org/jira/browse/OFBIZ-10883 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Suraj Khurana >Priority: Major > Fix For: 18.12.01, 17.12.01 > > Attachments: OFBIZ-10883-new.patch, OFBIZ-10883.patch, > OrderStatus.jpg, PicklistStatus.jpg > > > Steps to regenerate: > 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main > 2. Create order > 3. Open > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse > 4. Create Picking > 5. Click on Packing under the facility > 6. Enter order id and click on pack order > 7. Enter package detail and complete packaging > 8. Open > https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse > Actual: Picklist is in the input status > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9352) Remove unused labels from AccountingUiLabels.xml
[ https://issues.apache.org/jira/browse/OFBIZ-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-9352: Attachment: (was: OFBIZ-9352-AccountingUiLabels.xml.patch) > Remove unused labels from AccountingUiLabels.xml > > > Key: OFBIZ-9352 > URL: https://issues.apache.org/jira/browse/OFBIZ-9352 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Pierre Smits >Priority: Minor > Labels: cleanup > -- This message was sent by Atlassian Jira (v8.3.4#803005)
