[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #117: Improved: Update Data Sets

2020-05-13 Thread GitBox


sonarcloud[bot] commented on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-628196085


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-13 Thread GitBox


sonarcloud[bot] removed a comment on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-628195008


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-13 Thread GitBox


sonarcloud[bot] removed a comment on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-628186520


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #117: Improved: Update Data Sets

2020-05-13 Thread GitBox


sonarcloud[bot] commented on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-628195008


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-11703) Themes provides link to partymgr in headers

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11703:
-
Description: 
The headers of the back-end themes offers the user a link to view his/her 
profile in the Party application. However, not every user will have access to 
the party application. Therefore the link should not be present.

Such users are (typically):
 * MyPortal users (external parties)
 * Project users (external parties)

but this is also applicable to users of other components, who don't have 
privileges for functions in the Party application.

See attached image

  was:
The drop-down widget in the top right hand corner of the theme offers the user 
to see his/her profile in the Party application. However, not every user will 
have access to the party application. Therefore the link should not be present.

Such users are:
 * MyPortal users (external parties)
 * Project users (external parties)

See attached image


> Themes provides link to partymgr in headers
> ---
>
> Key: OFBIZ-11703
> URL: https://issues.apache.org/jira/browse/OFBIZ-11703
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: Rainbow, bluelight, flatgrey, permissions, security, 
> tomahawk
> Attachments: image-2020-05-13-18-32-30-065.png
>
>
> The headers of the back-end themes offers the user a link to view his/her 
> profile in the Party application. However, not every user will have access to 
> the party application. Therefore the link should not be present.
> Such users are (typically):
>  * MyPortal users (external parties)
>  * Project users (external parties)
> but this is also applicable to users of other components, who don't have 
> privileges for functions in the Party application.
> See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11703) Themes provides link to partymgr in headers

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11703:
-
Summary: Themes provides link to partymgr in headers  (was: Themes headers 
provides link to partymgr in drop-down widget)

> Themes provides link to partymgr in headers
> ---
>
> Key: OFBIZ-11703
> URL: https://issues.apache.org/jira/browse/OFBIZ-11703
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: Rainbow, permissions, security
> Attachments: image-2020-05-13-18-32-30-065.png
>
>
> The drop-down widget in the top right hand corner of the theme offers the 
> user to see his/her profile in the Party application. However, not every user 
> will have access to the party application. Therefore the link should not be 
> present.
> Such users are:
>  * MyPortal users (external parties)
>  * Project users (external parties)
> See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11703) Themes provides link to partymgr in headers

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11703:
-
Labels: Rainbow bluelight flatgrey permissions security tomahawk  (was: 
Rainbow permissions security)

> Themes provides link to partymgr in headers
> ---
>
> Key: OFBIZ-11703
> URL: https://issues.apache.org/jira/browse/OFBIZ-11703
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: Rainbow, bluelight, flatgrey, permissions, security, 
> tomahawk
> Attachments: image-2020-05-13-18-32-30-065.png
>
>
> The drop-down widget in the top right hand corner of the theme offers the 
> user to see his/her profile in the Party application. However, not every user 
> will have access to the party application. Therefore the link should not be 
> present.
> Such users are:
>  * MyPortal users (external parties)
>  * Project users (external parties)
> See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11703) RainBowStone themes provides link to partymgr in drop-down widget

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106506#comment-17106506
 ] 

Pierre Smits commented on OFBIZ-11703:
--

Will adjust subject and description.

> RainBowStone themes provides link to partymgr in drop-down widget
> -
>
> Key: OFBIZ-11703
> URL: https://issues.apache.org/jira/browse/OFBIZ-11703
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: Rainbow, permissions, security
> Attachments: image-2020-05-13-18-32-30-065.png
>
>
> The drop-down widget in the top right hand corner of the theme offers the 
> user to see his/her profile in the Party application. However, not every user 
> will have access to the party application. Therefore the link should not be 
> present.
> Such users are:
>  * MyPortal users (external parties)
>  * Project users (external parties)
> See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11703) Themes headers provides link to partymgr in drop-down widget

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11703:
-
Summary: Themes headers provides link to partymgr in drop-down widget  
(was: RainBowStone themes provides link to partymgr in drop-down widget)

> Themes headers provides link to partymgr in drop-down widget
> 
>
> Key: OFBIZ-11703
> URL: https://issues.apache.org/jira/browse/OFBIZ-11703
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: Rainbow, permissions, security
> Attachments: image-2020-05-13-18-32-30-065.png
>
>
> The drop-down widget in the top right hand corner of the theme offers the 
> user to see his/her profile in the Party application. However, not every user 
> will have access to the party application. Therefore the link should not be 
> present.
> Such users are:
>  * MyPortal users (external parties)
>  * Project users (external parties)
> See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11703) RainBowStone themes provides link to partymgr in drop-down widget

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106505#comment-17106505
 ] 

Pierre Smits commented on OFBIZ-11703:
--

It appears  this is also the case in all the other back-end themes.

> RainBowStone themes provides link to partymgr in drop-down widget
> -
>
> Key: OFBIZ-11703
> URL: https://issues.apache.org/jira/browse/OFBIZ-11703
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: Rainbow, permissions, security
> Attachments: image-2020-05-13-18-32-30-065.png
>
>
> The drop-down widget in the top right hand corner of the theme offers the 
> user to see his/her profile in the Party application. However, not every user 
> will have access to the party application. Therefore the link should not be 
> present.
> Such users are:
>  * MyPortal users (external parties)
>  * Project users (external parties)
> See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11703) RainBowStone themes provides link to partymgr in drop-down widget

2020-05-13 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-11703:


 Summary: RainBowStone themes provides link to partymgr in 
drop-down widget
 Key: OFBIZ-11703
 URL: https://issues.apache.org/jira/browse/OFBIZ-11703
 Project: OFBiz
  Issue Type: Bug
  Components: themes
Affects Versions: Trunk, 17.12.03
Reporter: Pierre Smits
 Attachments: image-2020-05-13-18-32-30-065.png

The drop-down widget in the top right hand corner of the theme offers the user 
to see his/her profile in the Party application. However, not every user will 
have access to the party application. Therefore the link should not be present.

Such users are:
 * MyPortal users (external parties)
 * Project users (external parties)

See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11702) RainbowStone themes don't show middleName in drop-down widget

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11702:
-
Parent: (was: OFBIZ-6881)
Issue Type: Bug  (was: Sub-task)

> RainbowStone themes don't show middleName in drop-down widget
> -
>
> Key: OFBIZ-11702
> URL: https://issues.apache.org/jira/browse/OFBIZ-11702
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: Rainbow, usability
>
> See attached image.
> While working on improving the data-sets under OFBIZ-6976 (and testing the 
> changes), I noticed when logging into MyPortal with one enhanced demo data 
> records that the middleName is not shown in the the right-hand drop-down when 
> using one of the RainbowStone themes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11702) RainbowStone themes don't show middleName in drop-down widget

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11702:
-
Parent: OFBIZ-6881
Issue Type: Sub-task  (was: Bug)

> RainbowStone themes don't show middleName in drop-down widget
> -
>
> Key: OFBIZ-11702
> URL: https://issues.apache.org/jira/browse/OFBIZ-11702
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: Rainbow, usability
>
> See attached image.
> While working on improving the data-sets under OFBIZ-6976 (and testing the 
> changes), I noticed when logging into MyPortal with one enhanced demo data 
> records that the middleName is not shown in the the right-hand drop-down when 
> using one of the RainbowStone themes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-9866) Rainbow theme: if you set the Arab language it's difficult to get back to another language

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-9866.
---
Resolution: Not A Problem

Closing as not a problem, based on comments provided.

> Rainbow theme: if you set the Arab language it's difficult to get back to 
> another language
> --
>
> Key: OFBIZ-9866
> URL: https://issues.apache.org/jira/browse/OFBIZ-9866
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
>
> If,using the Rainbow theme, you set the Arab language it's difficult to get 
> back to another language.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-9866) Rainbow theme: if you set the Arab language it's difficult to get back to another language

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-9866:
---

Assignee: Pierre Smits

> Rainbow theme: if you set the Arab language it's difficult to get back to 
> another language
> --
>
> Key: OFBIZ-9866
> URL: https://issues.apache.org/jira/browse/OFBIZ-9866
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
>
> If,using the Rainbow theme, you set the Arab language it's difficult to get 
> back to another language.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10528) "Last system notes" are not shown in Rainbow themes

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-10528.

Resolution: Not A Problem

It appears that this is not an issue anymore. Notifications are shown in the 
Portal component on the main screen. 

> "Last system notes" are not shown in Rainbow themes
> ---
>
> Key: OFBIZ-10528
> URL: https://issues.apache.org/jira/browse/OFBIZ-10528
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: 16.11.05, 17.12.01, Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Major
>
> See this [thread 
> |https://lists.apache.org/thread.html/65e478f1461a2126fe8ed8aa4704ea6cdc136fe3cc1eab6b43c4491f@%3Cdev.ofbiz.apache.org%3E]
>  for more
> Please check that it also concerns R16.11 (I guess so  it put in affected 
> versions)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10528) "Last system notes" are not shown in Rainbow themes

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-10528:


Assignee: Pierre Smits

> "Last system notes" are not shown in Rainbow themes
> ---
>
> Key: OFBIZ-10528
> URL: https://issues.apache.org/jira/browse/OFBIZ-10528
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: 16.11.05, 17.12.01, Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Major
>
> See this [thread 
> |https://lists.apache.org/thread.html/65e478f1461a2126fe8ed8aa4704ea6cdc136fe3cc1eab6b43c4491f@%3Cdev.ofbiz.apache.org%3E]
>  for more
> Please check that it also concerns R16.11 (I guess so  it put in affected 
> versions)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11626) Purchase Order Receipt Doesn't create Tax Account Code

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106401#comment-17106401
 ] 

Pierre Smits commented on OFBIZ-11626:
--

Hi [~allen_tan], 

>From the description you provided I get that you have resolved this in your 
>local clone. Could you provide us with what you modified and where?

It will help us in working this ticket.

Mvg
Pierre

> Purchase Order Receipt Doesn't create Tax Account Code
> --
>
> Key: OFBIZ-11626
> URL: https://issues.apache.org/jira/browse/OFBIZ-11626
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 17.12
>Reporter: allen_tan
>Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, purchase, tax
>
> Dear Team 
> When we do the purchase order receipt at whole level, then system can create 
> a purchase invoice with VAT tax item on the journal entries. BUT for the Tax 
> Line, it doesn't get the tax account code from the setup on the tax 
> autorithies. After we adjusted the source code, then it get the tax account 
> code now.
> Please help to verify this is bug or standard function as designed. 
> Thanks
> Allen
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11626) Purchase Order Receipt Doesn't create Tax Account Code

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11626:


Assignee: Pierre Smits

> Purchase Order Receipt Doesn't create Tax Account Code
> --
>
> Key: OFBIZ-11626
> URL: https://issues.apache.org/jira/browse/OFBIZ-11626
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Release Branch 17.12
>Reporter: allen_tan
>Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, purchase, tax
>
> Dear Team 
> When we do the purchase order receipt at whole level, then system can create 
> a purchase invoice with VAT tax item on the journal entries. BUT for the Tax 
> Line, it doesn't get the tax account code from the setup on the tax 
> autorithies. After we adjusted the source code, then it get the tax account 
> code now.
> Please help to verify this is bug or standard function as designed. 
> Thanks
> Allen
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11702) RainbowStone themes don't show middleName in drop-down widget

2020-05-13 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-11702:


 Summary: RainbowStone themes don't show middleName in drop-down 
widget
 Key: OFBIZ-11702
 URL: https://issues.apache.org/jira/browse/OFBIZ-11702
 Project: OFBiz
  Issue Type: Bug
  Components: themes
Affects Versions: Trunk, 17.12.03
Reporter: Pierre Smits


See attached image.

While working on improving the data-sets under OFBIZ-6976 (and testing the 
changes), I noticed when logging into MyPortal with one enhanced demo data 
records that the middleName is not shown in the the right-hand drop-down when 
using one of the RainbowStone themes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11578) Convert PriceServices.xml minilang to groovy

2020-05-13 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-11578.
-
Resolution: Done

It's load on trunk, thanks Sebastian

> Convert PriceServices.xml minilang to groovy
> 
>
> Key: OFBIZ-11578
> URL: https://issues.apache.org/jira/browse/OFBIZ-11578
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11701) getAssociatedPriceRulesConds service return huge result

2020-05-13 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-11701.
-
Fix Version/s: Upcoming Branch
   Resolution: Done

> getAssociatedPriceRulesConds service return huge result
> ---
>
> Key: OFBIZ-11701
> URL: https://issues.apache.org/jira/browse/OFBIZ-11701
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The service getAssociatedPriceRulesConds return some element to help the 
> selection on product prise rule condition screen.
> The problem: all query to resolve element are realized without filter :
>  {code}from("Product").queryList(){code}
> On big database, a call on this service generate a server saturation (load 1 
> Million product to a dropdown, isn't logical)
> To keep the benefit of this service as example to implement a custom service 
> with filter, I introduce a limit range to 200. For much more it's better to 
> improve the screen with a lookup.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11578) Convert PriceServices.xml minilang to groovy

2020-05-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106332#comment-17106332
 ] 

ASF subversion and git services commented on OFBIZ-11578:
-

Commit 4ebdcdd9d03b6682f9f00397ef5d61d2f0bee08b in ofbiz-framework's branch 
refs/heads/trunk from Sebastian Berg
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4ebdcdd ]

Improved: Convert PriceServices.xml mini lang to groovy

(OFBIZ-11578)


> Convert PriceServices.xml minilang to groovy
> 
>
> Key: OFBIZ-11578
> URL: https://issues.apache.org/jira/browse/OFBIZ-11578
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11701) getAssociatedPriceRulesConds service return huge result

2020-05-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106334#comment-17106334
 ] 

ASF subversion and git services commented on OFBIZ-11701:
-

Commit a6cfaf87320dab2492502bc27d2c4007aab62b94 in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a6cfaf8 ]

Improved: getAssociatedPriceRulesConds service return huge result

(OFBIZ-11701)

The service getAssociatedPriceRulesConds return some element to help the 
selection on product prise rule condition screen.
The problem: all query to resolve element are realized without filter :
 from("Product").queryList()

On big database, a call on this service generate a server saturation (load 1 
Million product to a dropdown, isn't logical)
To keep the benefit of this service as example to implement a custom service 
with filter, I introduce a limit range to 200. For much more it's better to 
improve the screen with a lookup.

I also simplify the list generation to homogenize and help the reader.


> getAssociatedPriceRulesConds service return huge result
> ---
>
> Key: OFBIZ-11701
> URL: https://issues.apache.org/jira/browse/OFBIZ-11701
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>
> The service getAssociatedPriceRulesConds return some element to help the 
> selection on product prise rule condition screen.
> The problem: all query to resolve element are realized without filter :
>  {code}from("Product").queryList(){code}
> On big database, a call on this service generate a server saturation (load 1 
> Million product to a dropdown, isn't logical)
> To keep the benefit of this service as example to implement a custom service 
> with filter, I introduce a limit range to 200. For much more it's better to 
> improve the screen with a lookup.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11578) Convert PriceServices.xml minilang to groovy

2020-05-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106333#comment-17106333
 ] 

ASF subversion and git services commented on OFBIZ-11578:
-

Commit b9b8c1405b847a262ea866f0844ed05da33744c8 in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b9b8c14 ]

Improved: Convert PriceServices.xml mini lang to groovy

(OFBIZ-11578)

Second pass:
 * slimdown code
 * move saveProductPriceChange to entity-auto


> Convert PriceServices.xml minilang to groovy
> 
>
> Key: OFBIZ-11578
> URL: https://issues.apache.org/jira/browse/OFBIZ-11578
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11701) getAssociatedPriceRulesConds service return huge result

2020-05-13 Thread Nicolas Malin (Jira)
Nicolas Malin created OFBIZ-11701:
-

 Summary: getAssociatedPriceRulesConds service return huge result
 Key: OFBIZ-11701
 URL: https://issues.apache.org/jira/browse/OFBIZ-11701
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Nicolas Malin
Assignee: Nicolas Malin


The service getAssociatedPriceRulesConds return some element to help the 
selection on product prise rule condition screen.

The problem: all query to resolve element are realized without filter :
 {code}from("Product").queryList(){code}

On big database, a call on this service generate a server saturation (load 1 
Million product to a dropdown, isn't logical)

To keep the benefit of this service as example to implement a custom service 
with filter, I introduce a limit range to 200. For much more it's better to 
improve the screen with a lookup.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11700) Refactor simple methods name as per naming convention best practices

2020-05-13 Thread Suraj Khurana (Jira)
Suraj Khurana created OFBIZ-11700:
-

 Summary: Refactor simple methods name as per naming convention 
best practices
 Key: OFBIZ-11700
 URL: https://issues.apache.org/jira/browse/OFBIZ-11700
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana


Here are some simple methods found whose naming is not proper as best practices:
 - UploadProductImages
 - UtilCheckEntriesBalance
 - InvoiceStatusInProgress
 - DeleteSprint
 - DeleteTaskFromSprintOverview
 - CopyMemberLastSprint
 - CreateCustRequestAndAssignTaskToPerson
 - MoveItemBetweenShipGroups

They should follow naming pattern, i.e. lower camel case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11698) Convert following simple services services from simple to entity-auto

2020-05-13 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11698:
--
Labels: Refactoring  (was: )

> Convert following simple services services from simple to entity-auto
> -
>
> Key: OFBIZ-11698
> URL: https://issues.apache.org/jira/browse/OFBIZ-11698
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting, order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: Refactoring
>
> Here are some straight forward delete action specific services that can be 
> converted:
>  - deleteOrderAdjustment
>  - removeShoppingList
>  - removeInvoiceRole
>  - deleteFinAccount



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11698) Convert following simple services services from simple to entity-auto

2020-05-13 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11698:
--
Component/s: order
 accounting

> Convert following simple services services from simple to entity-auto
> -
>
> Key: OFBIZ-11698
> URL: https://issues.apache.org/jira/browse/OFBIZ-11698
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting, order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>
> Here are some straight forward delete action specific services that can be 
> converted:
>  - deleteOrderAdjustment
>  - removeShoppingList
>  - removeInvoiceRole
>  - deleteFinAccount



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11698) Convert following simple services services from simple to entity-auto

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106276#comment-17106276
 ] 

Pierre Smits commented on OFBIZ-11698:
--

Hi [~surajk],

Are these specific actions related to just one component/application? If so, 
please set the correct component

Mvg,
Pierre

> Convert following simple services services from simple to entity-auto
> -
>
> Key: OFBIZ-11698
> URL: https://issues.apache.org/jira/browse/OFBIZ-11698
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>
> Here are some straight forward delete action specific services that can be 
> converted:
>  - deleteOrderAdjustment
>  - removeShoppingList
>  - removeInvoiceRole
>  - deleteFinAccount



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11699) Have improvements to data-sets go into demo-stable

2020-05-13 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-11699:


 Summary: Have improvements to data-sets go into demo-stable
 Key: OFBIZ-11699
 URL: https://issues.apache.org/jira/browse/OFBIZ-11699
 Project: OFBiz
  Issue Type: Improvement
  Components: Demo
Affects Versions: 17.12.04
Reporter: Pierre Smits


While the data sets in demo-trunk (coming from the trunk branch) is intended to 
showcase the maturity of OFBiz to predominantly developers and contributors, 
the data sets applied to demo-stable can be regarded to highlight the maturity 
of OFBiz (from release to release) to potential adopters (and influencers other 
than developers).

Improvements to the data-sets should therefore be merged into the - upcoming - 
release branch(es) and releases a.s.a.p. after having been committed to the 
trunk branch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11698) Convert following simple services services from simple to entity-auto

2020-05-13 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11698:
--
Description: 
Here are some straight forward delete action specific services that can be 
converted:
 - deleteOrderAdjustment
 - removeShoppingList
 - removeInvoiceRole
 - deleteFinAccount

  was:
Here are some straight forward delete action specific services that can be 
converted:

- deleteOrderAdjustment
- removeShoppingList
- removeInvoiceRole
- deleteFinAccount
- deleteTaskNote
- removeProductMember


> Convert following simple services services from simple to entity-auto
> -
>
> Key: OFBIZ-11698
> URL: https://issues.apache.org/jira/browse/OFBIZ-11698
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>
> Here are some straight forward delete action specific services that can be 
> converted:
>  - deleteOrderAdjustment
>  - removeShoppingList
>  - removeInvoiceRole
>  - deleteFinAccount



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) widget tag

2020-05-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106253#comment-17106253
 ] 

ASF subversion and git services commented on OFBIZ-11686:
-

Commit 803f7fa06048baa5c4246c80ff249cba2edb9451 in ofbiz-framework's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=803f7fa ]

Improved:  widget tag (OFBIZ-11686)

The new tag allows us to render a freemarker template containing javascript,
as external script in html instead of inline script.
This helps to reduce CSP errors.


>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
> Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11698) Convert following simple services services from simple to entity-auto

2020-05-13 Thread Suraj Khurana (Jira)
Suraj Khurana created OFBIZ-11698:
-

 Summary: Convert following simple services services from simple to 
entity-auto
 Key: OFBIZ-11698
 URL: https://issues.apache.org/jira/browse/OFBIZ-11698
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana


Here are some straight forward delete action specific services that can be 
converted:

- deleteOrderAdjustment
- removeShoppingList
- removeInvoiceRole
- deleteFinAccount
- deleteTaskNote
- removeProductMember



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11662) Convert all GlReconciliationEntry related CRUD services from simple to entity-auto

2020-05-13 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11662.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Convert all GlReconciliationEntry related CRUD services from simple to 
> entity-auto
> --
>
> Key: OFBIZ-11662
> URL: https://issues.apache.org/jira/browse/OFBIZ-11662
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11662) Convert all GlReconciliationEntry related CRUD services from simple to entity-auto

2020-05-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106228#comment-17106228
 ] 

ASF subversion and git services commented on OFBIZ-11662:
-

Commit 2b0166410dcb7165ba4493400db690810e540554 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2b01664 ]

Improved: Converted all GlReconciliationEntry related CRUD services from simple 
to entity-auto (#129)

* Improved: Converted all GlReconciliationEntry related CRUD services from 
simple to entity-auto
(OFBIZ-11662)

> Convert all GlReconciliationEntry related CRUD services from simple to 
> entity-auto
> --
>
> Key: OFBIZ-11662
> URL: https://issues.apache.org/jira/browse/OFBIZ-11662
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) widget tag

2020-05-13 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106218#comment-17106218
 ] 

James Yong commented on OFBIZ-11686:


Updated the patch before commit

>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
> Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11686) widget tag

2020-05-13 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-11686:
---
Attachment: OFBIZ-11686.patch

>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
> Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11697) 'New Employment' widget(s) allows party-groups to be selects as the employee

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11697:
-
Affects Version/s: 17.12.03

> 'New Employment' widget(s) allows party-groups to be selects as the employee
> 
>
> Key: OFBIZ-11697
> URL: https://issues.apache.org/jira/browse/OFBIZ-11697
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: employment
> Attachments: image-2020-05-13-13-21-57-713.png
>
>
> See image. This should only be possible for parties with partytypeId="PERSON" 
> and roleTypeID="EMPLOYEE"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11697) 'New Employment' widget(s) allows party-groups to be selects as the employee

2020-05-13 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-11697:


 Summary: 'New Employment' widget(s) allows party-groups to be 
selects as the employee
 Key: OFBIZ-11697
 URL: https://issues.apache.org/jira/browse/OFBIZ-11697
 Project: OFBiz
  Issue Type: Bug
  Components: humanres
Affects Versions: Trunk
Reporter: Pierre Smits
 Attachments: image-2020-05-13-13-21-57-713.png

See image. This should only be possible for parties with partytypeId="PERSON" 
and roleTypeID="EMPLOYEE"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11690) Convert WorkEffort related services from simple to entity-auto

2020-05-13 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11690:
--
Description: 
Here are the service which can be directly converted:

- createWorkEffortFixedAssetStd
- removeWorkEffortFixedAssetStd
- removeWorkEffortFixedAssetAssign
- deleteWorkEffortReview
- deleteWorkEffortKeyword

> Convert WorkEffort related services from simple to entity-auto
> --
>
> Key: OFBIZ-11690
> URL: https://issues.apache.org/jira/browse/OFBIZ-11690
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: Refactoring
>
> Here are the service which can be directly converted:
> - createWorkEffortFixedAssetStd
> - removeWorkEffortFixedAssetStd
> - removeWorkEffortFixedAssetAssign
> - deleteWorkEffortReview
> - deleteWorkEffortKeyword



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11690) Convert WorkEffort related services from simple to entity-auto

2020-05-13 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11690:
--
Summary: Convert WorkEffort related services from simple to entity-auto  
(was: Convert removeWorkEffortFixedAssetStd service from simple to entity-auto)

> Convert WorkEffort related services from simple to entity-auto
> --
>
> Key: OFBIZ-11690
> URL: https://issues.apache.org/jira/browse/OFBIZ-11690
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: Refactoring
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-6986) Simplify getChildHRCategoryTree

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6986.
---
Resolution: Won't Do

Closing the ticket, due to loss of tractions and recent developments regarding 
other humanres related ticket(s).

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Assignee: Pierre Smits
>Priority: Major
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-6986) Simplify getChildHRCategoryTree

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6986:
---

Assignee: Pierre Smits

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
>Assignee: Pierre Smits
>Priority: Major
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11403) Unable to navigate to 'Recently approved' screen under image mangement

2020-05-13 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-11403:
---

Assignee: Jacques Le Roux  (was: Nicolas Malin)

> Unable to navigate to 'Recently approved' screen under image mangement
> --
>
> Key: OFBIZ-11403
> URL: https://issues.apache.org/jira/browse/OFBIZ-11403
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Dikpal Kanungo
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Issue with recently approved screen.png
>
>
> Steps to regenerate-
> 1. Navigate to - 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/ImageApprove]
> 2. Click on - RECENTLY APPROVED (Catalog Manager->Image Management->Recently 
> Approved)
> 3. The broken page will be displayed (Please have a look at the attached 
> screenshot) !Issue with recently approved screen.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11468) Convert ShipmentReceiptServices.xml mini lang to groovy

2020-05-13 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106188#comment-17106188
 ] 

Jacques Le Roux commented on OFBIZ-11468:
-

Hi Wiebke,

Sorry It's still an issue for me, could you please check?


{noformat}
This branch has conflicts that must be resolved
Ude the command line to resolve conflicts before continuing.
Conflicting files
applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml
applications/product/servicedef/services_shipment.xml
{noformat}


> Convert ShipmentReceiptServices.xml mini lang to groovy
> ---
>
> Key: OFBIZ-11468
> URL: https://issues.apache.org/jira/browse/OFBIZ-11468
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11468) Convert ShipmentReceiptServices.xml mini lang to groovy

2020-05-13 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103184#comment-17103184
 ] 

Jacques Le Roux edited comment on OFBIZ-11468 at 5/13/20, 10:16 AM:


HI Wiebke,

I wanted to merge the PR but unfortunately there are conflicts now, could you 
please check? TIA


was (Author: jacques.le.roux):
Hi Wiebe,

I wanted to merge the PR but unfortunately there are conflicts now, could you 
please check? TIA

> Convert ShipmentReceiptServices.xml mini lang to groovy
> ---
>
> Key: OFBIZ-11468
> URL: https://issues.apache.org/jira/browse/OFBIZ-11468
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11689) Convert CustomTimePeriod services from simple to entity-auto

2020-05-13 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106180#comment-17106180
 ] 

Jacques Le Roux commented on OFBIZ-11689:
-

The [tests failed on 
Buildbot|https://ci.apache.org/builders/ofbizTrunkFramework] but 
bq. gradlew "ofbiz --test component=party --test 
suitename=partycontactmechtests"
is OK locally, I just started a new Buildbot run

> Convert CustomTimePeriod services from simple to entity-auto
> 
>
> Key: OFBIZ-11689
> URL: https://issues.apache.org/jira/browse/OFBIZ-11689
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/common
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>
> Applicable services:
>  * createCustomTimePeriod
>  * updateCustomTimePeriod
>  * deleteCustomTimePeriod



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11504) Solr Configuration Problem on Demo Instance

2020-05-13 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11504.
---
Fix Version/s: Upcoming Branch
   Release Branch 17.12
   Release Branch 18.12
   Resolution: Fixed

All demos are fixed, thanks Ravi

> Solr Configuration Problem on Demo Instance
> ---
>
> Key: OFBIZ-11504
> URL: https://issues.apache.org/jira/browse/OFBIZ-11504
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ravi Lodhi
>Priority: Minor
> Fix For: Release Branch 18.12, Release Branch 17.12, Upcoming 
> Branch
>
> Attachments: DemoStableRebuildSolrIndex.png, DemoTrunkErrorLogs.txt, 
> DemoTrunkRebuildSolrIndexError.png, OFBIZ-11504_DemoTrunk.patch
>
>
> Unable to build Solr Index on demo-trunk and demo-stable instances.
>  
> *Demo Trunk:* Getting connection error while running *rebuildSolrIndex* 
> service from webtools on 
> [demo-trunk|https://demo-trunk.ofbiz.apache.org/webtools/control/runService] 
> instance. Below is the error message-
>  
> {code:java}
> org.apache.http.conn.HttpHostConnectException: Connect to localhost:8443 
> [localhost/127.0.0.1] failed: Connection refused (Connection refused){code}
>  
> *Demo Stable:* I also tried running the same service from webtools on 
> [demo-stable|https://demo-stable.ofbiz.apache.org/webtools/control/runService]
>  instance and getting below error-
>  
>  
> {code:java}
> javax.net.ssl.SSLPeerUnverifiedException: Host name 'localhost' does not 
> match the certificate subject provided by the peer 
> (CN=demo-old.ofbiz.apache.org). Please find the attached screenshots for the 
> same.{code}
>  
>  
> It seems like some configurations are missing for solr plugins on these demo 
> instances.
> Please find attached the error logs from demo-trunk instance as shared by 
> [~jleroux]. Thanks Jacques for providing the error logs from the instance.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11674) Improve scrum component data set(s)

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11674:
-
Summary: Improve scrum component data set(s)  (was: update scrum component 
data set(s))

> Improve scrum component data set(s)
> ---
>
> Key: OFBIZ-11674
> URL: https://issues.apache.org/jira/browse/OFBIZ-11674
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: scrum
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11675) Improve webpos component data set(s)

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11675:
-
Summary: Improve webpos component data set(s)  (was: update webpos 
component data sets)

> Improve webpos component data set(s)
> 
>
> Key: OFBIZ-11675
> URL: https://issues.apache.org/jira/browse/OFBIZ-11675
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11673) Improve ebay component data set(s)

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11673:
-
Summary: Improve ebay component data set(s)  (was: update ebay component 
data set(s))

> Improve ebay component data set(s)
> --
>
> Key: OFBIZ-11673
> URL: https://issues.apache.org/jira/browse/OFBIZ-11673
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ebay
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-6110) Move as much as possible demo data from ecommerce to product or order components

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6110.
---
Resolution: Implemented

Implemented.

> Move as much as possible demo data from ecommerce to product or order 
> components
> 
>
> Key: OFBIZ-6110
> URL: https://issues.apache.org/jira/browse/OFBIZ-6110
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting, ecommerce, marketing, order, party, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
>
> It would be better if we have most of the demo product data in product or 
> maybe in order component. Because almost all what can be done concerning 
> ordering in ecommerce can also be done in order manager from which anyway 
> ecommerce depends on
> More generally each component should have the data to be able to work as much 
> on its own as possible. Even if that means redundancy of some sorts. Most of 
> the time, we can avoid redudancy when there are components dependencies and 
> the component data are loaded after the main one.
> This is when 
> https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
>  helps and shows why it should be actively maintained! For instance I'm not 
> sure we show data loading order there...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11672) Improve myportal component data set(s)

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11672:
-
Summary: Improve myportal component data set(s)  (was: update myportal 
component data set(s))

> Improve myportal component data set(s)
> --
>
> Key: OFBIZ-11672
> URL: https://issues.apache.org/jira/browse/OFBIZ-11672
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: myportal
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11671) Improve ecommerce component data set(s0

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11671:
-
Summary: Improve ecommerce component data set(s0  (was: Update ecommerce 
component data set(s0)

> Improve ecommerce component data set(s0
> ---
>
> Key: OFBIZ-11671
> URL: https://issues.apache.org/jira/browse/OFBIZ-11671
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11671) Improve ecommerce component data set(s)

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11671:
-
Summary: Improve ecommerce component data set(s)  (was: Improve ecommerce 
component data set(s0)

> Improve ecommerce component data set(s)
> ---
>
> Key: OFBIZ-11671
> URL: https://issues.apache.org/jira/browse/OFBIZ-11671
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-9243) load demo data failure

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-9243.
---
Resolution: Cannot Reproduce

Closing as not considered to be an issue anymore.

> load demo data failure
> --
>
> Key: OFBIZ-9243
> URL: https://issues.apache.org/jira/browse/OFBIZ-9243
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: ofbiz-framework-buildbot gradlew loadDefault.log.txt
>
>
> checkout latest ofbiz-framework and ofbiz-plugins
> $ gradlew cleanAll build
> $ gradlew loadDefault...using derby
> console output...
> 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer   
> |I| 00040 of 17229 from 
> file:/ofbiz-framework/plugins/webpos/data/PosSyncSettings.xml
> 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer   
> |I| The following errors occurred in the data load:
> 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer   
> |I| [loadData]: Error loading XML Resource 
> "file:/ofbiz-framework/plugins/ebay/data/DemoEbayData.xml"; Error was: A 
> transaction error occurred reading data
> 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer   
> |I| [loadData]: Error loading XML Resource 
> "file:/ofbiz-framework/plugins/myportal/data/MyPortalDemoData.xml"; Error 
> was: A transaction error occurred reading data
> 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer   
> |I| =-=-=-=-=-=-= Finished the data load with 17229 rows changed.
> }}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-6976) Updating data sets

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6976:

Description: 
This is a placeholder issue.

Having correct data shipped with OFBiz is key to not only
 # have a good operational state (meaning adopters can work with OFBiz out of 
the box)
 # have a good data set for demonstration purposes
 # have a good data set to enable unit, system integration and acceptance 
testing

Re aspect 1:
 This encompasses all security, system property and other seed data sets

Re aspect 2:
 This encompasses all data records in the various DemoData.xml files. This kind 
of data needs to be coherent from the perspective of the main internal 
organisation (or the legal demo party) that operates the OFBiz implementation.

Re aspect 3:
 The data set for this aspect encompasses all data under aspect 1 and 2.

With a good data set for demonstration purposes it is easier for potential 
adopters (and their influencers) to see the added value of implementing OFBiz 
in their company/organisation, while at the same time it helps developers to 
understand the coherence between widgets, templates, services, functions and 
other data counter parts. Also, good demo data helps contributors to identity 
issues regarding the usability of OFBiz, work to resolve them and ultimate 
improve OFBiz.

Demo data sets should be grouped in accordance to the component load order (as 
defined in e.g. component-load.xml, see links below). The first appearance of a 
data record of the demo kind should also (as much as possible) be in accordance 
with where the related entity is defined and where the first appearance of 
related seed data records are defined. For guidance see the entity reference 
(per link below)

Example 1:
 The ProductStore entity is defined in the entity model for the Product 
component (the product-entitymodel.xml).

Thus any new demo record regarding this ProductStore entity should first appear 
in the ProductDemoData.xml file.

Example 2:
 Following record is defined in WorkEffortTypeData.xml
{code:java}

{code}
Thus any first appearance of a demo record for the WorkEffort entity with the 
defined workEffortTypeId="PROJECT" should appear in the WorkEffortDemoData.xml 
file

With the above we minimise the risk of duplication and dependency mismatches

  was:
This is a placeholder issue. 

Having correct data shipped with OFBiz is key to not only
# have a good operational state (meaning adopters can work with OFBiz out of 
the box)
# have a good data set for demonstration purposes
# have a good data set to enable unit, system integration and acceptance testing

Re aspect 1:
This encompasses all security, system property and other seed data sets

Re aspect 2:
This encompasses all data records in the various DemoData.xml files. This kind 
of data needs to be coherent from the perspective of the main internal 
organisation (or the legal demo party) that operates the OFBiz implementation.

Re aspect 3:
The data set for this aspect encompasses all data under aspect 1 and 2.

With a good data set for demonstration purposes it is easier for potential 
adopters (and their influencers) to see the added value of implementing OFBiz 
in their company/organisation, while at the same time it helps developers to 
understand the coherence between widgets, templates, services, functions and 
the data counter parts.

Demo data sets should be grouped in accordance to the component load order (as 
defined in e.g. component-load.xml, see links below). The first appearance of a 
data record of the demo kind should also (as much as possible) be in accordance 
with where the related entity is defined and where the first appearance of 
related seed data records are defined. For guidance see the entity reference 
(per link below)

Example 1:
The ProductStore entity is defined in the entity model for the Product 
component (the product-entitymodel.xml). 

Thus any new demo record regarding this ProductStore entity should first appear 
in the ProductDemoData.xml file.

Example 2:
Following record is defined in WorkEffortTypeData.xml
{code:java}

{code}

Thus any first appearance of a demo record for the WorkEffort entity with the 
defined workEffortTypeId="PROJECT" should appear in the WorkEffortDemoData.xml 
file

With the above we minimise the risk of duplication and dependency mismatches


> Updating data sets
> --
>
> Key: OFBIZ-6976
> URL: https://issues.apache.org/jira/browse/OFBIZ-6976
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Demo, configuration, data, test
>
> This is a placeholder issue.
> Having correct data shipped with OFBiz is key to no

[jira] [Assigned] (OFBIZ-11578) Convert PriceServices.xml minilang to groovy

2020-05-13 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-11578:
-

Assignee: Nicolas Malin  (was: Sebastian Berg)

> Convert PriceServices.xml minilang to groovy
> 
>
> Key: OFBIZ-11578
> URL: https://issues.apache.org/jira/browse/OFBIZ-11578
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11651) Improve WorkEffort data set(s)

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106148#comment-17106148
 ] 

Pierre Smits commented on OFBIZ-11651:
--

See (also) Pull Request under OFBIZ-6976

> Improve WorkEffort data set(s)
> --
>
> Key: OFBIZ-11651
> URL: https://issues.apache.org/jira/browse/OFBIZ-11651
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-7017) Improve Content Component data set

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-7017:
---

Assignee: Pierre Smits

> Improve Content Component data set
> --
>
> Key: OFBIZ-7017
> URL: https://issues.apache.org/jira/browse/OFBIZ-7017
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>  Labels: configuration, data, demo, test
>
> Currently a lot of demo data exists in the data files of the content 
> component that are load with the command ./ant load-seed.
> This data should move to the appropriate data files so that it, a.o. doesn't 
> trigger lucene indexing unnecessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-7017) Improve Content Component data set

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106147#comment-17106147
 ] 

Pierre Smits commented on OFBIZ-7017:
-

See (also) Pull Request under OFBIZ-6976

> Improve Content Component data set
> --
>
> Key: OFBIZ-7017
> URL: https://issues.apache.org/jira/browse/OFBIZ-7017
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>  Labels: configuration, data, demo, test
>
> Currently a lot of demo data exists in the data files of the content 
> component that are load with the command ./ant load-seed.
> This data should move to the appropriate data files so that it, a.o. doesn't 
> trigger lucene indexing unnecessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11651) Improve WorkEffort data set(s)

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11651:


Assignee: Pierre Smits

> Improve WorkEffort data set(s)
> --
>
> Key: OFBIZ-11651
> URL: https://issues.apache.org/jira/browse/OFBIZ-11651
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11656) Improve CommonExt Component data set(s)

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106146#comment-17106146
 ] 

Pierre Smits commented on OFBIZ-11656:
--

See (also) Pull Request under OFBIZ-6976

> Improve CommonExt Component data set(s)
> ---
>
> Key: OFBIZ-11656
> URL: https://issues.apache.org/jira/browse/OFBIZ-11656
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11656) Improve CommonExt Component data set(s)

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11656:


Assignee: Pierre Smits

> Improve CommonExt Component data set(s)
> ---
>
> Key: OFBIZ-11656
> URL: https://issues.apache.org/jira/browse/OFBIZ-11656
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11655) Improve Marketing plugin data set(s)

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106145#comment-17106145
 ] 

Pierre Smits commented on OFBIZ-11655:
--

See (also) Pull Request under OFBIZ-6976

> Improve Marketing plugin data set(s)
> 
>
> Key: OFBIZ-11655
> URL: https://issues.apache.org/jira/browse/OFBIZ-11655
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11652) Improve Accounting Component data set(s)

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106142#comment-17106142
 ] 

Pierre Smits commented on OFBIZ-11652:
--

See (also) Pull Request under OFBIZ-6976

> Improve Accounting Component data set(s)
> 
>
> Key: OFBIZ-11652
> URL: https://issues.apache.org/jira/browse/OFBIZ-11652
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11650) Improve Order Component data set(s)

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106141#comment-17106141
 ] 

Pierre Smits commented on OFBIZ-11650:
--

See (also) Pull Request under OFBIZ-6976

> Improve Order Component data set(s)
> ---
>
> Key: OFBIZ-11650
> URL: https://issues.apache.org/jira/browse/OFBIZ-11650
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11649) Improve Party Component data set(s)

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106138#comment-17106138
 ] 

Pierre Smits commented on OFBIZ-11649:
--

See (also) Pull Request under OFBIZ-6976

> Improve Party Component data set(s)
> ---
>
> Key: OFBIZ-11649
> URL: https://issues.apache.org/jira/browse/OFBIZ-11649
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>
> See description in parent ticket



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11648) Improve Product Component data sets

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106137#comment-17106137
 ] 

Pierre Smits commented on OFBIZ-11648:
--

See also Pull Request under OFBIZ-6976

> Improve Product Component data sets
> ---
>
> Key: OFBIZ-11648
> URL: https://issues.apache.org/jira/browse/OFBIZ-11648
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: data, demo, test
>
> See also description in parent ticket.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-10552) Move Accounting AP AR webapps to plugin

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106115#comment-17106115
 ] 

Pierre Smits edited comment on OFBIZ-10552 at 5/13/20, 9:13 AM:


HI [~nmalin],

Shall we close this ticket, given the discussions on dev ml (see my previous 
comment), and just start a new ticket regarding the decluttering aspect?

Or should we just rename the ticket and rework the patch to just have the 
decluttering aspect fulfilled?

Met vriendelijke groet,

Pierre


was (Author: pfm.smits):
HI [~nmalin],

Shall we close this ticket, given the discussions on dev ml (see my previous 
comment), and just start a new ticket regarding the decluttering aspect?

Met vriendelijke groet,

Pierre

> Move Accounting AP AR webapps to plugin
> ---
>
> Key: OFBIZ-10552
> URL: https://issues.apache.org/jira/browse/OFBIZ-10552
> Project: OFBiz
>  Issue Type: Task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-10552-status.txt, OFBIZ-10552.patch, 
> accounting-ap-ar.tar.gz
>
>
> As exchanged on [this discussion 
> |https://lists.apache.org/thread.html/111ad6488cf6d1888004dca149d70f4131844fab3ac1215d7b236aa3@%3Cdev.ofbiz.apache.org%3E]
>  I created the first patch [^OFBIZ-10552.patch] that contains the separation 
> between accounting component and AP/AR  webapps.
> I detected cross dependency on screens between accounting and AP /AR, so I 
> realized following change :
>  * the commissionRun link in accounting to keep this present on AP
>  * move all Financial account deposit payment group screen from AR to 
> Accounting
>  You can see the svn status command result [^OFBIZ-10552-status.txt] that 
> will be helpfull to read the patch.
> To test without plugin ap-ar:
>  * apply patch [^OFBIZ-10552.patch]
>  * ./gradlew ofbiz
> To test with plugin ap-ar
>  * apply patch [^OFBIZ-10552.patch]
>  * ^untar [^accounting-ap-ar.tar.gz] at the ofbiz home^
>  * ./gradlew loadAll ofbiz
> I named the plugin accounting-ap-ar but you'll probably find a much better 
> name :)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11694) Demo-stable doesn't apply default theme at login

2020-05-13 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11694.
---
  Assignee: Jacques Le Roux
Resolution: Fixed

It was due to WIP on demos:  
https://lists.apache.org/thread.html/rab906741ff4e61a689afc08198337477ec98330c6f4eed8e286afdb6%40%3Cuser.ofbiz.apache.org%3E
 fixed

> Demo-stable doesn't apply default theme at login
> 
>
> Key: OFBIZ-11694
> URL: https://issues.apache.org/jira/browse/OFBIZ-11694
> Project: OFBiz
>  Issue Type: Bug
>  Components: Demo
>Affects Versions: 17.12.03
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: image-2020-05-13-08-34-34-590.png
>
>
> See image !image-2020-05-13-08-34-34-590.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11695) Demo-trunk doesn't retain selected theme when switching to a new application

2020-05-13 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11695.
---
  Assignee: Jacques Le Roux
Resolution: Fixed

It was due to WIP on demos:  
https://lists.apache.org/thread.html/rab906741ff4e61a689afc08198337477ec98330c6f4eed8e286afdb6%40%3Cuser.ofbiz.apache.org%3E
 fixed

> Demo-trunk doesn't retain selected theme when switching to a new application
> 
>
> Key: OFBIZ-11695
> URL: https://issues.apache.org/jira/browse/OFBIZ-11695
> Project: OFBiz
>  Issue Type: Bug
>  Components: assetmaint, humanres, product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Critical
>
> After login into a component, and after switching to another theme, when 
> switching to some application the selected theme isn't applied, but the 
> default (previous) theme is applied.
> Steps to verify:
>  # login into e.g. accounting
>  # switch to another theme (e.g. bluelight)
>  # see that the theme applied is the selected theme
>  # switch to another application (e.g. humanres)
>  # See that the default theme is applied and not the selected theme (under #2)
> This happens when switching:
>  # from accounting to assetmaint
>  # from accounting to catalog
>  # from accounting to humanres



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11566) COnvert testGetRatesAmountsFromEmplPositionTypeId test from XML to Groovy

2020-05-13 Thread Anushi Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106116#comment-17106116
 ] 

Anushi Gupta commented on OFBIZ-11566:
--

Provided patch for testGetRatesAmountsFromEmplPositionTypeId test case

Thanks!

> COnvert testGetRatesAmountsFromEmplPositionTypeId test from XML to Groovy
> -
>
> Key: OFBIZ-11566
> URL: https://issues.apache.org/jira/browse/OFBIZ-11566
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Anushi Gupta
>Priority: Minor
> Attachments: OFBIZ-11566.patch
>
>
> COnvert testGetRatesAmountsFromEmplPositionTypeId test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11566) COnvert testGetRatesAmountsFromEmplPositionTypeId test from XML to Groovy

2020-05-13 Thread Anushi Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anushi Gupta updated OFBIZ-11566:
-
Attachment: OFBIZ-11566.patch

> COnvert testGetRatesAmountsFromEmplPositionTypeId test from XML to Groovy
> -
>
> Key: OFBIZ-11566
> URL: https://issues.apache.org/jira/browse/OFBIZ-11566
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Anushi Gupta
>Priority: Minor
> Attachments: OFBIZ-11566.patch
>
>
> COnvert testGetRatesAmountsFromEmplPositionTypeId test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10552) Move Accounting AP AR webapps to plugin

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106115#comment-17106115
 ] 

Pierre Smits commented on OFBIZ-10552:
--

HI [~nmalin],

Shall we close this ticket, given the discussions on dev ml (see my previous 
comment), and just start a new ticket regarding the decluttering aspect?

Met vriendelijke groet,

Pierre

> Move Accounting AP AR webapps to plugin
> ---
>
> Key: OFBIZ-10552
> URL: https://issues.apache.org/jira/browse/OFBIZ-10552
> Project: OFBiz
>  Issue Type: Task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-10552-status.txt, OFBIZ-10552.patch, 
> accounting-ap-ar.tar.gz
>
>
> As exchanged on [this discussion 
> |https://lists.apache.org/thread.html/111ad6488cf6d1888004dca149d70f4131844fab3ac1215d7b236aa3@%3Cdev.ofbiz.apache.org%3E]
>  I created the first patch [^OFBIZ-10552.patch] that contains the separation 
> between accounting component and AP/AR  webapps.
> I detected cross dependency on screens between accounting and AP /AR, so I 
> realized following change :
>  * the commissionRun link in accounting to keep this present on AP
>  * move all Financial account deposit payment group screen from AR to 
> Accounting
>  You can see the svn status command result [^OFBIZ-10552-status.txt] that 
> will be helpfull to read the patch.
> To test without plugin ap-ar:
>  * apply patch [^OFBIZ-10552.patch]
>  * ./gradlew ofbiz
> To test with plugin ap-ar
>  * apply patch [^OFBIZ-10552.patch]
>  * ^untar [^accounting-ap-ar.tar.gz] at the ofbiz home^
>  * ./gradlew loadAll ofbiz
> I named the plugin accounting-ap-ar but you'll probably find a much better 
> name :)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-6184) Add setting of activeApp in CommonScreens.xml of AR and AP

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6184.
---
Resolution: Won't Do

Closing ticket due to new developments on dev ml.

See related threads
 * [https://ofbiz.markmail.org/search/?q=declutter]
 * 
[https://ofbiz.markmail.org/search/q=%22move+ar+and+ap%22+list%3Aorg.apache.ofbiz.dev+order%3Adate-forward]

> Add setting of activeApp in CommonScreens.xml of AR and AP 
> ---
>
> Key: OFBIZ-6184
> URL: https://issues.apache.org/jira/browse/OFBIZ-6184
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: 14.12.01, 12.04.06, 13.07.02, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: AP, AR, Accounts
> Attachments: OFBIZ-6184-ARAPCommon.patch
>
>
> Currently the CommonScreen of both the AP and the AR applications don't have 
> the setting of the activeApp field. As these apps are closely related to the 
> accounting app, the definition can be the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-6184) Add setting of activeApp in CommonScreens.xml of AR and AP

2020-05-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6184:
---

Assignee: Pierre Smits

> Add setting of activeApp in CommonScreens.xml of AR and AP 
> ---
>
> Key: OFBIZ-6184
> URL: https://issues.apache.org/jira/browse/OFBIZ-6184
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: 14.12.01, 12.04.06, 13.07.02, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: AP, AR, Accounts
> Attachments: OFBIZ-6184-ARAPCommon.patch
>
>
> Currently the CommonScreen of both the AP and the AR applications don't have 
> the setting of the activeApp field. As these apps are closely related to the 
> accounting app, the definition can be the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10552) Move Accounting AP AR webapps to plugin

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106102#comment-17106102
 ] 

Pierre Smits commented on OFBIZ-10552:
--

These discussions on dev ml are related:
 * [https://ofbiz.markmail.org/search/?q=declutter]
 * 
https://ofbiz.markmail.org/search/q=%22move+ar+and+ap%22+list%3Aorg.apache.ofbiz.dev+order%3Adate-forward

> Move Accounting AP AR webapps to plugin
> ---
>
> Key: OFBIZ-10552
> URL: https://issues.apache.org/jira/browse/OFBIZ-10552
> Project: OFBiz
>  Issue Type: Task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-10552-status.txt, OFBIZ-10552.patch, 
> accounting-ap-ar.tar.gz
>
>
> As exchanged on [this discussion 
> |https://lists.apache.org/thread.html/111ad6488cf6d1888004dca149d70f4131844fab3ac1215d7b236aa3@%3Cdev.ofbiz.apache.org%3E]
>  I created the first patch [^OFBIZ-10552.patch] that contains the separation 
> between accounting component and AP/AR  webapps.
> I detected cross dependency on screens between accounting and AP /AR, so I 
> realized following change :
>  * the commissionRun link in accounting to keep this present on AP
>  * move all Financial account deposit payment group screen from AR to 
> Accounting
>  You can see the svn status command result [^OFBIZ-10552-status.txt] that 
> will be helpfull to read the patch.
> To test without plugin ap-ar:
>  * apply patch [^OFBIZ-10552.patch]
>  * ./gradlew ofbiz
> To test with plugin ap-ar
>  * apply patch [^OFBIZ-10552.patch]
>  * ^untar [^accounting-ap-ar.tar.gz] at the ofbiz home^
>  * ./gradlew loadAll ofbiz
> I named the plugin accounting-ap-ar but you'll probably find a much better 
> name :)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11689) Convert CustomTimePeriod services from simple to entity-auto

2020-05-13 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106100#comment-17106100
 ] 

Suraj Khurana commented on OFBIZ-11689:
---

Thanks [~nmalin] for reviewing it.

 

> Convert CustomTimePeriod services from simple to entity-auto
> 
>
> Key: OFBIZ-11689
> URL: https://issues.apache.org/jira/browse/OFBIZ-11689
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/common
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>
> Applicable services:
>  * createCustomTimePeriod
>  * updateCustomTimePeriod
>  * deleteCustomTimePeriod



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11222) Wrong heading on creating quote under Accounting-AP component.

2020-05-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106098#comment-17106098
 ] 

Pierre Smits commented on OFBIZ-11222:
--

Is this still an issue? Based on information provided in description and the 
attached image I can't verify that there is an issue.

> Wrong heading on creating quote under Accounting-AP component.
> --
>
> Key: OFBIZ-11222
> URL: https://issues.apache.org/jira/browse/OFBIZ-11222
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pradyum Dharwa
>Priority: Trivial
> Fix For: Trunk
>
> Attachments: Accounting-ap.png, OFBIZ-11222.patch
>
>
> Steps to re-generate
>  # Logging with the correct username and password.
>  # Click on the Accounting Section.
>  # Click on Agreements section.
>  # Click on create new
> Error: Edit quote is shown on the place of edit quote/new quote .
> Actual: edit quote/new quote  should be shown on the place of edit quote



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11689) Convert CustomTimePeriod services from simple to entity-auto

2020-05-13 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-11689.
-
Resolution: Fixed

Thanks Suraj, I push your commit on trunk

> Convert CustomTimePeriod services from simple to entity-auto
> 
>
> Key: OFBIZ-11689
> URL: https://issues.apache.org/jira/browse/OFBIZ-11689
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/common
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>
> Applicable services:
>  * createCustomTimePeriod
>  * updateCustomTimePeriod
>  * deleteCustomTimePeriod



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11689) Convert CustomTimePeriod services from simple to entity-auto

2020-05-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106096#comment-17106096
 ] 

ASF subversion and git services commented on OFBIZ-11689:
-

Commit ba04eda31a36db12bac6dd0f1607c91d31449e47 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ba04eda ]

Improved: Converted CustomTimePeriod related services from simple to entity-auto
(OFBIZ-11689)
Thanks Pierre for reporting.


> Convert CustomTimePeriod services from simple to entity-auto
> 
>
> Key: OFBIZ-11689
> URL: https://issues.apache.org/jira/browse/OFBIZ-11689
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/common
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>
> Applicable services:
>  * createCustomTimePeriod
>  * updateCustomTimePeriod
>  * deleteCustomTimePeriod



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11696) Refactor CatalogWorker.java to remove duplicate code

2020-05-13 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106069#comment-17106069
 ] 

Pawan Verma commented on OFBIZ-11696:
-

[^OFBIZ-11696.patch]

Attaching a patch for this improvement. Please suggest your feedback. Thanks!

> Refactor CatalogWorker.java to remove duplicate code
> 
>
> Key: OFBIZ-11696
> URL: https://issues.apache.org/jira/browse/OFBIZ-11696
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11696.patch
>
>
> We have too much duplicate code in CatalogWorker.java 
> We can refactor it via creating a generic method and use it to fetch 
> prodCatalogCategoryId by passing prodCatalogCategoryTypeId.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11696) Refactor CatalogWorker.java to remove duplicate code

2020-05-13 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-11696:

Attachment: OFBIZ-11696.patch

> Refactor CatalogWorker.java to remove duplicate code
> 
>
> Key: OFBIZ-11696
> URL: https://issues.apache.org/jira/browse/OFBIZ-11696
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11696.patch
>
>
> We have too much duplicate code in CatalogWorker.java 
> We can refactor it via creating a generic method and use it to fetch 
> prodCatalogCategoryId by passing prodCatalogCategoryTypeId.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11696) Refactor CatalogWorker.java to remove duplicate code

2020-05-13 Thread Pawan Verma (Jira)
Pawan Verma created OFBIZ-11696:
---

 Summary: Refactor CatalogWorker.java to remove duplicate code
 Key: OFBIZ-11696
 URL: https://issues.apache.org/jira/browse/OFBIZ-11696
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Pawan Verma
Assignee: Pawan Verma
 Attachments: OFBIZ-11696.patch

We have too much duplicate code in CatalogWorker.java 

We can refactor it via creating a generic method and use it to fetch 
prodCatalogCategoryId by passing prodCatalogCategoryTypeId.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11468) Convert ShipmentReceiptServices.xml mini lang to groovy

2020-05-13 Thread Jira


[ 
https://issues.apache.org/jira/browse/OFBIZ-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106064#comment-17106064
 ] 

Wiebke Pätzold commented on OFBIZ-11468:


Hi [~jleroux],

I resolved the merge conflictes, so now it should be possible to merge the PR. 
Thanks for doing this.

> Convert ShipmentReceiptServices.xml mini lang to groovy
> ---
>
> Key: OFBIZ-11468
> URL: https://issues.apache.org/jira/browse/OFBIZ-11468
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11566) COnvert testGetRatesAmountsFromEmplPositionTypeId test from XML to Groovy

2020-05-13 Thread Anushi Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anushi Gupta reassigned OFBIZ-11566:


Assignee: Anushi Gupta

> COnvert testGetRatesAmountsFromEmplPositionTypeId test from XML to Groovy
> -
>
> Key: OFBIZ-11566
> URL: https://issues.apache.org/jira/browse/OFBIZ-11566
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Anushi Gupta
>Priority: Minor
>
> COnvert testGetRatesAmountsFromEmplPositionTypeId test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)