[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL

2020-05-14 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107932#comment-17107932
 ] 

Priya Sharma commented on OFBIZ-11383:
--

Sure, Jacques. I will create a PR.

> Convert createArticleContent service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11383
> URL: https://issues.apache.org/jira/browse/OFBIZ-11383
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch
>
>
> Convert createArticleContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11686) widget tag

2020-05-14 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-11686.
--
Resolution: Implemented

>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11686) widget tag

2020-05-14 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-11686:
---
Description: 
Propose a new  widget tag that adds an external script after 
body tag.

The external script will contain the rendered result of the specified template 
file location.
 e.g.
{code:xml}

 
{code}

 will render as:
{code:xml}

 

{code}
This will allow inline script from a freemarker file, to be rendered as 
external script in html.

 
 Discussion was started at 
[https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]

 

*15th May 2020*

While extracting the scripts from html-template to script-template and testing 
the changes, I found the process to be cumbersome.
 So I made a change not to use script-template tag but add a multi-block 
attribute to html-template tag.
 When *multi-block=true*, inline scripts will be extracted automatically from 
script tag and converted to external script. 
 So no need to manually extract script from the existing freemarker template. 
 Coding for script-template tag is removed

  was:
Propose a new  widget tag that adds an external script after 
body tag.

The external script will contain the rendered result of the specified template 
file location.
 e.g.
{code:xml}

 
{code}

 will render as:
{code:xml}

 

{code}
This will allow inline script from a freemarker file, to be rendered as 
external script in html.

 
Discussion was started at 
[https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]


>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) widget tag

2020-05-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107889#comment-17107889
 ] 

ASF subversion and git services commented on OFBIZ-11686:
-

Commit 60c78d24be4ab2b4f8aa2f6603968863c12b9b92 in ofbiz-framework's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=60c78d2 ]

Improved:  widget tag (OFBIZ-11686)

Removed script-template tag.
Use multi-block=true on html-template tag instead.


>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
> Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11703) Themes provides link to partymgr in headers

2020-05-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107577#comment-17107577
 ] 

Jacques Le Roux commented on OFBIZ-11703:
-

Even if your case is an edge case, the behaviour seems correct to me. Anyway 
this should be discusses in dev ML, could be seen as a regression by some 
(including me)

> Themes provides link to partymgr in headers
> ---
>
> Key: OFBIZ-11703
> URL: https://issues.apache.org/jira/browse/OFBIZ-11703
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Rainbow, bluelight, flatgrey, permissions, security, 
> tomahawk
> Attachments: image-2020-05-13-18-32-30-065.png
>
>
> The headers of the back-end themes offers the user a link to view his/her 
> profile in the Party application. However, not every user will have access to 
> the party application. Therefore the link should not be present.
> Such users are (typically):
>  * MyPortal users (external parties)
>  * Project users (external parties)
> but this is also applicable to users of other components, who don't have 
> privileges for functions in the Party application.
> See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11691) Create a simple INSTALL file with minimum installation information and redirection to more documentation

2020-05-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107573#comment-17107573
 ] 

Jacques Le Roux commented on OFBIZ-11691:
-

It's plain text. Depends with what you read. Browsers tend to see HTML 
everywhere.

As said in commit comment:
{quote} If we are OK we can backport it to the supported release branches. Of 
course I'm open to modifications...
{quote}

> Create a simple INSTALL file with minimum installation information and 
> redirection to more documentation
> 
>
> Key: OFBIZ-11691
> URL: https://issues.apache.org/jira/browse/OFBIZ-11691
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: INSTALL
>
>
> This follows the https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion in 
> dev ML.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11691) Create a simple INSTALL file with minimum installation information and redirection to more documentation

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107474#comment-17107474
 ] 

Pierre Smits commented on OFBIZ-11691:
--

Maybe you should consider making the document also available in the branch for 
the next stable release. Adopters tend to go more with something released, than 
with something as volatile as trunk.

> Create a simple INSTALL file with minimum installation information and 
> redirection to more documentation
> 
>
> Key: OFBIZ-11691
> URL: https://issues.apache.org/jira/browse/OFBIZ-11691
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: INSTALL
>
>
> This follows the https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion in 
> dev ML.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11703) Themes provides link to partymgr in headers

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107460#comment-17107460
 ] 

Pierre Smits commented on OFBIZ-11703:
--

That should be obvious,

But try this:
 # go to [https://demo-trunk.ofbiz.apache.org/myportal]
 # login with userId=*DemoCustomer* and password=*ofbiz*
 # then click on the name shown in the header (when using the bluelight, 
flatgrey or tomahawk theme) or on the name in the dropdown widget (when using a 
rainbowstone theme variant)

OFBiz then opens a new login screen.

Not every user is intended to have direct access to the party component. If 
such user need to see their profile, we have such functionality available in 
the myportal component.

Better is it to remove the functionality in the header. As solved in the PR.

> Themes provides link to partymgr in headers
> ---
>
> Key: OFBIZ-11703
> URL: https://issues.apache.org/jira/browse/OFBIZ-11703
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Rainbow, bluelight, flatgrey, permissions, security, 
> tomahawk
> Attachments: image-2020-05-13-18-32-30-065.png
>
>
> The headers of the back-end themes offers the user a link to view his/her 
> profile in the Party application. However, not every user will have access to 
> the party application. Therefore the link should not be present.
> Such users are (typically):
>  * MyPortal users (external parties)
>  * Project users (external parties)
> but this is also applicable to users of other components, who don't have 
> privileges for functions in the Party application.
> See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11703) Themes provides link to partymgr in headers

2020-05-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107451#comment-17107451
 ] 

Jacques Le Roux commented on OFBIZ-11703:
-

It should be available only to authorised users

 

> Themes provides link to partymgr in headers
> ---
>
> Key: OFBIZ-11703
> URL: https://issues.apache.org/jira/browse/OFBIZ-11703
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Rainbow, bluelight, flatgrey, permissions, security, 
> tomahawk
> Attachments: image-2020-05-13-18-32-30-065.png
>
>
> The headers of the back-end themes offers the user a link to view his/her 
> profile in the Party application. However, not every user will have access to 
> the party application. Therefore the link should not be present.
> Such users are (typically):
>  * MyPortal users (external parties)
>  * Project users (external parties)
> but this is also applicable to users of other components, who don't have 
> privileges for functions in the Party application.
> See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL

2020-05-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107449#comment-17107449
 ] 

Jacques Le Roux commented on OFBIZ-11383:
-

Hi Priya, Benjamin,

The patch fails to be applied because of changes in ContentServices.groovy. 
Could this be related to changes from OFBIZ-10688 ?

Else could it be possible to create a PR?

> Convert createArticleContent service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11383
> URL: https://issues.apache.org/jira/browse/OFBIZ-11383
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch
>
>
> Convert createArticleContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) widget tag

2020-05-14 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107419#comment-17107419
 ] 

James Yong commented on OFBIZ-11686:


Updated patch which removed the Script-Template tag, because it is cumbersome 
to extract script from Html-Template. 

 

Add a new attribute 'multi-pass' for Html-Template to achieve the same without 
need to edit freemarker templates.

>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
> Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11686) widget tag

2020-05-14 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-11686:
---
Attachment: OFBIZ-11686.patch

>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
> Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11691) Create a simple INSTALL file with minimum installation information and redirection to more documentation

2020-05-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107414#comment-17107414
 ] 

Jacques Le Roux commented on OFBIZ-11691:
-

Here is the text file I propose and commited [^INSTALL]

> Create a simple INSTALL file with minimum installation information and 
> redirection to more documentation
> 
>
> Key: OFBIZ-11691
> URL: https://issues.apache.org/jira/browse/OFBIZ-11691
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: INSTALL
>
>
> This follows the https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion in 
> dev ML.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11691) Create a simple INSTALL file with minimum installation information and redirection to more documentation

2020-05-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107412#comment-17107412
 ] 

ASF subversion and git services commented on OFBIZ-11691:
-

Commit 8f2ce4bc954d2ad07c179ce3aaeaf9365e98f401 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8f2ce4b ]

Documented: Create a simple INSTALL file with minimum installation information 
and redirection to more documentation

(OFBIZ-11691)

Following https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion on dev ML
here is the file I suggest. If we are OK we can backport it to the supported
release branches. Of course I'm open to modifications...

Thanks for their answers: Deepak Nigam, Michael Brohl, Pierre Smits and
Taher Alkhateeb


> Create a simple INSTALL file with minimum installation information and 
> redirection to more documentation
> 
>
> Key: OFBIZ-11691
> URL: https://issues.apache.org/jira/browse/OFBIZ-11691
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: INSTALL
>
>
> This follows the https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion in 
> dev ML.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11691) Create a simple INSTALL file with minimum installation information and redirection to more documentation

2020-05-14 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11691:

Attachment: INSTALL

> Create a simple INSTALL file with minimum installation information and 
> redirection to more documentation
> 
>
> Key: OFBIZ-11691
> URL: https://issues.apache.org/jira/browse/OFBIZ-11691
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: INSTALL
>
>
> This follows the https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion in 
> dev ML.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11435) Remove and/or replace deprecated services

2020-05-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107396#comment-17107396
 ] 

Jacques Le Roux commented on OFBIZ-11435:
-

+1 for commit

> Remove and/or replace deprecated services
> -
>
> Key: OFBIZ-11435
> URL: https://issues.apache.org/jira/browse/OFBIZ-11435
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>
> In the code base (in trunk) there are several services call functions which 
> have been deprecated and replaced by newer functions, such as:
>  * deleteRateAmount -> expireRateAmount
>  * captureBillingAccountPayment -> captureBillingAccountPayments
>  * createQuoteWorkEffort -> ensureWorkEffortAndCreateQuoteWorkEffort
>  * addPriceRuleToMarketingCampaign -> createMarketingCampaignPrice
>  * removePriceRuleFromMarketingCampaign -> deleteMarketingCampaignPrice
>  * addPromoToMarketingCampaign -> createMarketingCampaignPromo
>  * removePromoFromMarketingCampaign -> deleteMarketingCampaignPromo
> These must be removed from trunk, when the time is there (to be done 
> periodically). This is a long running ticket intended to enable committers to 
> associate a removal to a ticket upon periodical clean-up without having to 
> create new tickets.
> It is suggested that committer the ticket under which a the replacement is 
> committed is referenced here as a link.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11435) Remove and/or replace deprecated services

2020-05-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107388#comment-17107388
 ] 

Jacques Le Roux commented on OFBIZ-11435:
-

Thanks for the reminder Suraj, doing so today...

> Remove and/or replace deprecated services
> -
>
> Key: OFBIZ-11435
> URL: https://issues.apache.org/jira/browse/OFBIZ-11435
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>
> In the code base (in trunk) there are several services call functions which 
> have been deprecated and replaced by newer functions, such as:
>  * deleteRateAmount -> expireRateAmount
>  * captureBillingAccountPayment -> captureBillingAccountPayments
>  * createQuoteWorkEffort -> ensureWorkEffortAndCreateQuoteWorkEffort
>  * addPriceRuleToMarketingCampaign -> createMarketingCampaignPrice
>  * removePriceRuleFromMarketingCampaign -> deleteMarketingCampaignPrice
>  * addPromoToMarketingCampaign -> createMarketingCampaignPromo
>  * removePromoFromMarketingCampaign -> deleteMarketingCampaignPromo
> These must be removed from trunk, when the time is there (to be done 
> periodically). This is a long running ticket intended to enable committers to 
> associate a removal to a ticket upon periodical clean-up without having to 
> create new tickets.
> It is suggested that committer the ticket under which a the replacement is 
> committed is referenced here as a link.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11435) Remove and/or replace deprecated services

2020-05-14 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107379#comment-17107379
 ] 

Suraj Khurana commented on OFBIZ-11435:
---

Hey [~jleroux],

Did you got a chance to review it?

> Remove and/or replace deprecated services
> -
>
> Key: OFBIZ-11435
> URL: https://issues.apache.org/jira/browse/OFBIZ-11435
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>
> In the code base (in trunk) there are several services call functions which 
> have been deprecated and replaced by newer functions, such as:
>  * deleteRateAmount -> expireRateAmount
>  * captureBillingAccountPayment -> captureBillingAccountPayments
>  * createQuoteWorkEffort -> ensureWorkEffortAndCreateQuoteWorkEffort
>  * addPriceRuleToMarketingCampaign -> createMarketingCampaignPrice
>  * removePriceRuleFromMarketingCampaign -> deleteMarketingCampaignPrice
>  * addPromoToMarketingCampaign -> createMarketingCampaignPromo
>  * removePromoFromMarketingCampaign -> deleteMarketingCampaignPromo
> These must be removed from trunk, when the time is there (to be done 
> periodically). This is a long running ticket intended to enable committers to 
> associate a removal to a ticket upon periodical clean-up without having to 
> create new tickets.
> It is suggested that committer the ticket under which a the replacement is 
> committed is referenced here as a link.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11673) Improve ebay component data set(s)

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107351#comment-17107351
 ] 

Pierre Smits commented on OFBIZ-11673:
--

See PRs under OFBIZ-6976

 

> Improve ebay component data set(s)
> --
>
> Key: OFBIZ-11673
> URL: https://issues.apache.org/jira/browse/OFBIZ-11673
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ebay
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11674) Improve scrum component data set(s)

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107343#comment-17107343
 ] 

Pierre Smits commented on OFBIZ-11674:
--

See PRs under OFBIZ6976

> Improve scrum component data set(s)
> ---
>
> Key: OFBIZ-11674
> URL: https://issues.apache.org/jira/browse/OFBIZ-11674
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: scrum
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11672) Improve myportal component data set(s)

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107342#comment-17107342
 ] 

Pierre Smits commented on OFBIZ-11672:
--

See Mrs under OFBIZ-6976

> Improve myportal component data set(s)
> --
>
> Key: OFBIZ-11672
> URL: https://issues.apache.org/jira/browse/OFBIZ-11672
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: myportal
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11413) Convert AccountServices.xml from mini lang to groovy

2020-05-14 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-11413:
-

Assignee: Nicolas Malin  (was: Wiebke Pätzold)

> Convert AccountServices.xml from mini lang to groovy
> 
>
> Key: OFBIZ-11413
> URL: https://issues.apache.org/jira/browse/OFBIZ-11413
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Reporter: Wiebke Pätzold
>Assignee: Nicolas Malin
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migration of the AccountServices.xml to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10528) "Last system notes" are not shown in Rainbow themes

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107262#comment-17107262
 ] 

Pierre Smits commented on OFBIZ-10528:
--

We just as well could remove the functionality from the older components to 
keep the consistency.

> "Last system notes" are not shown in Rainbow themes
> ---
>
> Key: OFBIZ-10528
> URL: https://issues.apache.org/jira/browse/OFBIZ-10528
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: 16.11.05, 17.12.01, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image 002.png, Image 004.png
>
>
> See this [thread 
> |https://lists.apache.org/thread.html/65e478f1461a2126fe8ed8aa4704ea6cdc136fe3cc1eab6b43c4491f@%3Cdev.ofbiz.apache.org%3E]
>  for more
> Please check that it also concerns R16.11 (I guess so  it put in affected 
> versions)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10528) "Last system notes" are not shown in Rainbow themes

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107261#comment-17107261
 ] 

Pierre Smits commented on OFBIZ-10528:
--

Should we pursue this? While the older themes has the real estate available to 
show these notifications in the header, RainbowStone clearly hasn't. 

To resolve this, redesign is required. While at the same time the portal 
component offers just that kind of functionality out of the box. Promoting that 
component as the solution for this helps getting the love for the component. 

> "Last system notes" are not shown in Rainbow themes
> ---
>
> Key: OFBIZ-10528
> URL: https://issues.apache.org/jira/browse/OFBIZ-10528
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: 16.11.05, 17.12.01, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image 002.png, Image 004.png
>
>
> See this [thread 
> |https://lists.apache.org/thread.html/65e478f1461a2126fe8ed8aa4704ea6cdc136fe3cc1eab6b43c4491f@%3Cdev.ofbiz.apache.org%3E]
>  for more
> Please check that it also concerns R16.11 (I guess so  it put in affected 
> versions)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11704) Application 'ismgr' doesn't show up

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107258#comment-17107258
 ] 

Pierre Smits commented on OFBIZ-11704:
--

[~jleroux],

Thanks for your assistance in getting this into the code base.

I know. And that is a pity. I guess it has to do with the aspect that it hasn't 
been shown in the demos. Nevertheless, not showing apps doesn't help in getting 
the love.

> Application 'ismgr' doesn't show up 
> 
>
> Key: OFBIZ-11704
> URL: https://issues.apache.org/jira/browse/OFBIZ-11704
> Project: OFBiz
>  Issue Type: Bug
>  Components: assetmaint
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The assetmaint components has 2 applications: assetmaint and ismgr.
> The ismgr doesn't show up in the main menu



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11704) Application 'ismgr' doesn't show up

2020-05-14 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11704.
---
Fix Version/s: Upcoming Branch
   Resolution: Fixed

I committed in trunk, but as [ismgr has not changed since 11 years and 5 months 
ago|http://svn.apache.org/viewvc?view=revision=720118] I'll not 
backport. 

I don't expect much more work in this...


> Application 'ismgr' doesn't show up 
> 
>
> Key: OFBIZ-11704
> URL: https://issues.apache.org/jira/browse/OFBIZ-11704
> Project: OFBiz
>  Issue Type: Bug
>  Components: assetmaint
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The assetmaint components has 2 applications: assetmaint and ismgr.
> The ismgr doesn't show up in the main menu



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11704) Application 'ismgr' doesn't show up

2020-05-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107250#comment-17107250
 ] 

Jacques Le Roux edited comment on OFBIZ-11704 at 5/14/20, 12:15 PM:


Thanks Pierre,

I committed in trunk, but as [ismgr has not changed since 11 years and 5 months 
ago|http://svn.apache.org/viewvc?view=revision=720118] I'll not 
backport. 

I don't expect much more work in this...



was (Author: jacques.le.roux):
I committed in trunk, but as [ismgr has not changed since 11 years and 5 months 
ago|http://svn.apache.org/viewvc?view=revision=720118] I'll not 
backport. 

I don't expect much more work in this...


> Application 'ismgr' doesn't show up 
> 
>
> Key: OFBIZ-11704
> URL: https://issues.apache.org/jira/browse/OFBIZ-11704
> Project: OFBiz
>  Issue Type: Bug
>  Components: assetmaint
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The assetmaint components has 2 applications: assetmaint and ismgr.
> The ismgr doesn't show up in the main menu



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11704) Application 'ismgr' doesn't show up

2020-05-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107246#comment-17107246
 ] 

ASF subversion and git services commented on OFBIZ-11704:
-

Commit 071240205f28124378cf23dc5e400c8c62643363 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=0712402 ]

Fixed: Application 'ismgr' doesn't show up

(OFBIZ-11704)

fixed: app-bar-display (from 'false' to 'true'
added: OFBTOOLS to base-permission


> Application 'ismgr' doesn't show up 
> 
>
> Key: OFBIZ-11704
> URL: https://issues.apache.org/jira/browse/OFBIZ-11704
> Project: OFBiz
>  Issue Type: Bug
>  Components: assetmaint
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> The assetmaint components has 2 applications: assetmaint and ismgr.
> The ismgr doesn't show up in the main menu



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] JacquesLeRoux merged pull request #19: Fixed: Application 'ismgr' doesn't show up (OFBIZ-11704)

2020-05-14 Thread GitBox


JacquesLeRoux merged pull request #19:
URL: https://github.com/apache/ofbiz-plugins/pull/19


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-10528) "Last system notes" are not shown in Rainbow themes

2020-05-14 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10528:

Attachment: Image 002.png

> "Last system notes" are not shown in Rainbow themes
> ---
>
> Key: OFBIZ-10528
> URL: https://issues.apache.org/jira/browse/OFBIZ-10528
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: 16.11.05, 17.12.01, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image 002.png, Image 004.png
>
>
> See this [thread 
> |https://lists.apache.org/thread.html/65e478f1461a2126fe8ed8aa4704ea6cdc136fe3cc1eab6b43c4491f@%3Cdev.ofbiz.apache.org%3E]
>  for more
> Please check that it also concerns R16.11 (I guess so  it put in affected 
> versions)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10528) "Last system notes" are not shown in Rainbow themes

2020-05-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107238#comment-17107238
 ] 

Jacques Le Roux commented on OFBIZ-10528:
-

No it does not, see:

Works in Tomahawk:  !Image 004.png! 
Not in Rainbow:  !Image 002.png! 

This is not specifically related to portal. It was just an advice to Julien to 
be able to reprouce.

> "Last system notes" are not shown in Rainbow themes
> ---
>
> Key: OFBIZ-10528
> URL: https://issues.apache.org/jira/browse/OFBIZ-10528
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: 16.11.05, 17.12.01, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image 002.png, Image 004.png
>
>
> See this [thread 
> |https://lists.apache.org/thread.html/65e478f1461a2126fe8ed8aa4704ea6cdc136fe3cc1eab6b43c4491f@%3Cdev.ofbiz.apache.org%3E]
>  for more
> Please check that it also concerns R16.11 (I guess so  it put in affected 
> versions)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11705) Rainbow theme: use the United Nations flag ad default flag

2020-05-14 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11705:

Parent: OFBIZ-6881
Issue Type: Sub-task  (was: Improvement)

> Rainbow theme: use the United Nations flag ad default flag
> --
>
> Key: OFBIZ-11705
> URL: https://issues.apache.org/jira/browse/OFBIZ-11705
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This follows OFBIZ-9866: we could use the [United Nations 
> flag|https://en.wikipedia.org/wiki/United_Nations#/media/File:Flag_of_the_United_Nations.svg]
>  as default flag



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11705) Rainbow theme: use the United Nations flag ad default flag

2020-05-14 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-11705:
---

 Summary: Rainbow theme: use the United Nations flag ad default flag
 Key: OFBIZ-11705
 URL: https://issues.apache.org/jira/browse/OFBIZ-11705
 Project: OFBiz
  Issue Type: Improvement
  Components: themes
Affects Versions: Trunk
Reporter: Jacques Le Roux


This follows OFBIZ-9866: we could use the [United Nations 
flag|https://en.wikipedia.org/wiki/United_Nations#/media/File:Flag_of_the_United_Nations.svg]
 as default flag



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11403) Unable to navigate to 'Recently approved' screen under image management

2020-05-14 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11403.
---
Fix Version/s: Upcoming Branch
   Resolution: Fixed

> Unable to navigate to 'Recently approved' screen under image management
> ---
>
> Key: OFBIZ-11403
> URL: https://issues.apache.org/jira/browse/OFBIZ-11403
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Dikpal Kanungo
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Issue with recently approved screen.png
>
>
> Steps to regenerate-
> 1. Navigate to - 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/ImageApprove]
> 2. Click on - RECENTLY APPROVED (Catalog Manager->Image Management->Recently 
> Approved)
> 3. The broken page will be displayed (Please have a look at the attached 
> screenshot) !Issue with recently approved screen.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11403) Unable to navigate to 'Recently approved' screen under image management

2020-05-14 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11403:

Summary: Unable to navigate to 'Recently approved' screen under image 
management  (was: Unable to navigate to 'Recently approved' screen under image 
mangement)

> Unable to navigate to 'Recently approved' screen under image management
> ---
>
> Key: OFBIZ-11403
> URL: https://issues.apache.org/jira/browse/OFBIZ-11403
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Dikpal Kanungo
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Issue with recently approved screen.png
>
>
> Steps to regenerate-
> 1. Navigate to - 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/ImageApprove]
> 2. Click on - RECENTLY APPROVED (Catalog Manager->Image Management->Recently 
> Approved)
> 3. The broken page will be displayed (Please have a look at the attached 
> screenshot) !Issue with recently approved screen.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11403) Unable to navigate to 'Recently approved' screen under image mangement

2020-05-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107224#comment-17107224
 ] 

ASF subversion and git services commented on OFBIZ-11403:
-

Commit fb447e7b62b12f57f4a9a97da2a934925cdb0d84 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fb447e7 ]

Fixed: Unable to navigate to 'Recently approved' screen under image management

(OFBIZ-11403)

It works on stable demo which uses 2.4.13 instead of 2.5.11 for trunk.

I guess it's because since Groovy 2.5 DateTimeFormatter, introduced with Java 8,
is used underneath.

This fixes and improves it regarding localisation. Because it's easier with
DateTimeFormatter and LocalDateTime to handle localisation


> Unable to navigate to 'Recently approved' screen under image mangement
> --
>
> Key: OFBIZ-11403
> URL: https://issues.apache.org/jira/browse/OFBIZ-11403
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Dikpal Kanungo
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Issue with recently approved screen.png
>
>
> Steps to regenerate-
> 1. Navigate to - 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/ImageApprove]
> 2. Click on - RECENTLY APPROVED (Catalog Manager->Image Management->Recently 
> Approved)
> 3. The broken page will be displayed (Please have a look at the attached 
> screenshot) !Issue with recently approved screen.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11403) Unable to navigate to 'Recently approved' screen under image mangement

2020-05-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107222#comment-17107222
 ] 

Jacques Le Roux commented on OFBIZ-11403:
-

This is due to

{{def date1 = sdf.format(today-i)}} in ImageRecentlyApproved.groovy

{noformat}
2020-05-13 14:08:46,633 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 23 screens in 0.026s from: 
file:/C:/projectsASF/Git/ofbiz-framework/applications/product/widget/catalog/ImageManagementScreens.xml
2020-05-13 14:08:46,787 |jsse-nio-8443-exec-4 |ScriptUtil
|W| Error running script at location 
[component://product/groovyScripts/catalog/imagemanagement/ImageRecentlyApproved.groovy]:
 groovy.lang.MissingMethodExceptio
n: No signature of method: java.util.Date.minus() is applicable for argument 
types: (Integer) values: [0]
Possible solutions: find(), find(groovy.lang.Closure), is(java.lang.Object), 
any(), print(java.lang.Object), with(groovy.lang.Closure)
groovy.lang.MissingMethodException: No signature of method: 
java.util.Date.minus() is applicable for argument types: (Integer) values: [0]
Possible solutions: find(), find(groovy.lang.Closure), is(java.lang.Object), 
any(), print(java.lang.Object), with(groovy.lang.Closure)
at 
org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:70)
 ~[groovy-2.5.11.jar:2.5.11]
at 
org.codehaus.groovy.runtime.callsite.PojoMetaClassSite.call(PojoMetaClassSite.java:46)
 ~[groovy-2.5.11.jar:2.5.11]
at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
 ~[groovy-2.5.11.jar:2.5.11]
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
 ~[groovy-2.5.11.jar:2.5.11]
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
 ~[groovy-2.5.11.jar:2.5.11]
at ImageRecentlyApproved.run(ImageRecentlyApproved.groovy:36) ~[?:?]

{noformat}

But weird this work in Groovy 2.5.11 console:


{code:java}
import java.text.SimpleDateFormat

def sdf = new SimpleDateFormat(" -MM-dd 00:00:00.000")
def today = new Date()
sdf.format(today-0) + " " + sdf.format(today-13)
{code}

{noformat}
groovy> import java.text.SimpleDateFormat
groovy> def sdf = new SimpleDateFormat(" -MM-dd 00:00:00.000")
groovy> def today = new Date()
groovy> sdf.format(today-0) + " " + sdf.format(today-13)

Result: mercredi 2020-05-13 00:00:00.000 jeudi 2020-04-30 00:00:00.000
{noformat}
And it works on stable demo which uses 2.4.13 instead of 2.5.11 for trunk.

I guess it's because since Groovy 2.5 DateTimeFormatter, introduced with Java 
8, is used underneath.

Anyway, I'll commit a solution. It's a little bit improved, because it's easier 
with DateTimeFormatter and LocalDateTime to handle localisation.

> Unable to navigate to 'Recently approved' screen under image mangement
> --
>
> Key: OFBIZ-11403
> URL: https://issues.apache.org/jira/browse/OFBIZ-11403
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Dikpal Kanungo
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Issue with recently approved screen.png
>
>
> Steps to regenerate-
> 1. Navigate to - 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/ImageApprove]
> 2. Click on - RECENTLY APPROVED (Catalog Manager->Image Management->Recently 
> Approved)
> 3. The broken page will be displayed (Please have a look at the attached 
> screenshot) !Issue with recently approved screen.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11702) RainbowStone themes don't show middleName in drop-down widget

2020-05-14 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11702:


Assignee: Pierre Smits

> RainbowStone themes don't show middleName in drop-down widget
> -
>
> Key: OFBIZ-11702
> URL: https://issues.apache.org/jira/browse/OFBIZ-11702
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Rainbow, usability
>
> See attached image.
> While working on improving the data-sets under OFBIZ-6976 (and testing the 
> changes), I noticed when logging into MyPortal with one enhanced demo data 
> records that the middleName is not shown in the the right-hand drop-down when 
> using one of the RainbowStone themes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #138: Fixed: Themes provides link to partymgr in headers (OFBIZ-11703)

2020-05-14 Thread GitBox


sonarcloud[bot] commented on pull request #138:
URL: https://github.com/apache/ofbiz-framework/pull/138#issuecomment-628552228


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=138=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=138)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=138=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=138=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #138: Fixed: Themes provides link to partymgr in headers (OFBIZ-11703)

2020-05-14 Thread GitBox


PierreSmits opened a new pull request #138:
URL: https://github.com/apache/ofbiz-framework/pull/138


   (OFBIZ-11703)
   
   removed:  to viewprofile



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (OFBIZ-11703) Themes provides link to partymgr in headers

2020-05-14 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11703:


Assignee: Pierre Smits

> Themes provides link to partymgr in headers
> ---
>
> Key: OFBIZ-11703
> URL: https://issues.apache.org/jira/browse/OFBIZ-11703
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Rainbow, bluelight, flatgrey, permissions, security, 
> tomahawk
> Attachments: image-2020-05-13-18-32-30-065.png
>
>
> The headers of the back-end themes offers the user a link to view his/her 
> profile in the Party application. However, not every user will have access to 
> the party application. Therefore the link should not be present.
> Such users are (typically):
>  * MyPortal users (external parties)
>  * Project users (external parties)
> but this is also applicable to users of other components, who don't have 
> privileges for functions in the Party application.
> See attached image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) widget tag

2020-05-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107175#comment-17107175
 ] 

ASF subversion and git services commented on OFBIZ-11686:
-

Commit 4f5e6f9f06095b406128f6cdfce38b325a31668c in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4f5e6f9 ]

Improved:  widget tag
(OFBIZ-11686)

Correction in javadoc,  by "script-template"

>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
> Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #20: Improved: Refactor simple methods names as per naming convention best practices.

2020-05-14 Thread GitBox


sonarcloud[bot] commented on pull request #20:
URL: https://github.com/apache/ofbiz-plugins/pull/20#issuecomment-628536369


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=20=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=20)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=20=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=20=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] surajkhurana opened a new pull request #20: Improved: Refactor simple methods names as per naming convention best practices.

2020-05-14 Thread GitBox


surajkhurana opened a new pull request #20:
URL: https://github.com/apache/ofbiz-plugins/pull/20


   (OFBIZ-11700)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #137: Improved: Refactor simple methods names as per naming convention best practices.

2020-05-14 Thread GitBox


sonarcloud[bot] commented on pull request #137:
URL: https://github.com/apache/ofbiz-framework/pull/137#issuecomment-628535554


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=137=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=137)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=137=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=137=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11658) Improve AssetMaint plugin data set(s)

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107170#comment-17107170
 ] 

Pierre Smits commented on OFBIZ-11658:
--

See PRs under OFBIZ-6976

> Improve AssetMaint plugin data set(s)
> -
>
> Key: OFBIZ-11658
> URL: https://issues.apache.org/jira/browse/OFBIZ-11658
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: assetmaint
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] surajkhurana opened a new pull request #137: Improved: Refactor simple methods names as per naming convention best practices.

2020-05-14 Thread GitBox


surajkhurana opened a new pull request #137:
URL: https://github.com/apache/ofbiz-framework/pull/137


   (OFBIZ-11700)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-14 Thread GitBox


sonarcloud[bot] removed a comment on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-628475627


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #117: Improved: Update Data Sets

2020-05-14 Thread GitBox


sonarcloud[bot] commented on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-628533937


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #18: improved: update data set(s) various plugins (OFBIZ-6976)

2020-05-14 Thread GitBox


sonarcloud[bot] commented on pull request #18:
URL: https://github.com/apache/ofbiz-plugins/pull/18#issuecomment-628531181


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11686) widget tag

2020-05-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107165#comment-17107165
 ] 

ASF subversion and git services commented on OFBIZ-11686:
-

Commit 4f5e6f9f06095b406128f6cdfce38b325a31668c in ofbiz-framework's branch 
refs/heads/trunkGb from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4f5e6f9 ]

Improved:  widget tag
(OFBIZ-11686)

Correction in javadoc,  by "script-template"

>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
> Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #18: improved: update data set(s) various plugins (OFBIZ-6976)

2020-05-14 Thread GitBox


sonarcloud[bot] removed a comment on pull request #18:
URL: https://github.com/apache/ofbiz-plugins/pull/18#issuecomment-628495303


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11686) widget tag

2020-05-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107140#comment-17107140
 ] 

ASF subversion and git services commented on OFBIZ-11686:
-

Commit 4f5e6f9f06095b406128f6cdfce38b325a31668c in ofbiz-framework's branch 
refs/heads/trunkGB from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4f5e6f9 ]

Improved:  widget tag
(OFBIZ-11686)

Correction in javadoc,  by "script-template"

>  widget tag
> 
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
> Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #19: Fixed: Application 'ismgr' doesn't show up (OFBIZ-11704)

2020-05-14 Thread GitBox


sonarcloud[bot] commented on pull request #19:
URL: https://github.com/apache/ofbiz-plugins/pull/19#issuecomment-628499109


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=19=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=19)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=19=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=19=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] PierreSmits opened a new pull request #19: Fixed: Application 'ismgr' doesn't show up (OFBIZ-11704)

2020-05-14 Thread GitBox


PierreSmits opened a new pull request #19:
URL: https://github.com/apache/ofbiz-plugins/pull/19


   (OFBIZ-11704)
   
   fixed: app-bar-display (from 'false' to 'true'
   added: OFBTOOLS to base-permission



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-11704) Application 'ismgr' doesn't show up

2020-05-14 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11704:
-
Summary: Application 'ismgr' doesn't show up   (was: Application 'ismgr' 
doesn't show up in )

> Application 'ismgr' doesn't show up 
> 
>
> Key: OFBIZ-11704
> URL: https://issues.apache.org/jira/browse/OFBIZ-11704
> Project: OFBiz
>  Issue Type: Bug
>  Components: assetmaint
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> The assetmaint components has 2 applications: assetmaint and ismgr.
> The ismgr doesn't show up in the main menu



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #18: improved: update data set(s) various plugins (OFBIZ-6976)

2020-05-14 Thread GitBox


sonarcloud[bot] commented on pull request #18:
URL: https://github.com/apache/ofbiz-plugins/pull/18#issuecomment-628495303


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #18: improved: update data set(s) various plugins (OFBIZ-6976)

2020-05-14 Thread GitBox


sonarcloud[bot] removed a comment on pull request #18:
URL: https://github.com/apache/ofbiz-plugins/pull/18#issuecomment-628478275


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (OFBIZ-11704) Application 'ismgr' doesn't show up in

2020-05-14 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-11704:


 Summary: Application 'ismgr' doesn't show up in 
 Key: OFBIZ-11704
 URL: https://issues.apache.org/jira/browse/OFBIZ-11704
 Project: OFBiz
  Issue Type: Bug
  Components: assetmaint
Affects Versions: Trunk, 17.12.03
Reporter: Pierre Smits
Assignee: Pierre Smits


The assetmaint components has 2 applications: assetmaint and ismgr.

The ismgr doesn't show up in the main menu



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11658) Improve AssetMaint plugin data set(s)

2020-05-14 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11658:


Assignee: Pierre Smits

> Improve AssetMaint plugin data set(s)
> -
>
> Key: OFBIZ-11658
> URL: https://issues.apache.org/jira/browse/OFBIZ-11658
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: assetmaint
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #18: improved: update data set(s) various plugins (OFBIZ-6976)

2020-05-14 Thread GitBox


sonarcloud[bot] removed a comment on pull request #18:
URL: https://github.com/apache/ofbiz-plugins/pull/18#issuecomment-626290204


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #18: improved: update data set(s) various plugins (OFBIZ-6976)

2020-05-14 Thread GitBox


sonarcloud[bot] commented on pull request #18:
URL: https://github.com/apache/ofbiz-plugins/pull/18#issuecomment-628478275


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11659) Improve the ProjectMgr plugin data set(s)

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107065#comment-17107065
 ] 

Pierre Smits commented on OFBIZ-11659:
--

See PR in OFBIZ-116976

> Improve the ProjectMgr plugin data set(s)
> -
>
> Key: OFBIZ-11659
> URL: https://issues.apache.org/jira/browse/OFBIZ-11659
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: projectmgr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demos, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-14 Thread GitBox


sonarcloud[bot] removed a comment on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-628196085


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #117: Improved: Update Data Sets

2020-05-14 Thread GitBox


sonarcloud[bot] commented on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-628475627


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (OFBIZ-11654) Improve Manufacturing plugin data set(s)

2020-05-14 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11654:


Assignee: Pierre Smits

> Improve Manufacturing plugin data set(s)
> 
>
> Key: OFBIZ-11654
> URL: https://issues.apache.org/jira/browse/OFBIZ-11654
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11654) Improve Manufacturing plugin data set(s)

2020-05-14 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107050#comment-17107050
 ] 

Pierre Smits commented on OFBIZ-11654:
--

See PR provided under OFBIZ-6976

> Improve Manufacturing plugin data set(s)
> 
>
> Key: OFBIZ-11654
> URL: https://issues.apache.org/jira/browse/OFBIZ-11654
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, data, demo, test
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)