[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195544#comment-17195544 ] Jacques Le Roux commented on OFBIZ-11926: - Hi Suraj, Because it's rendered in French locally, I have none"Must have at least one [statement]" string in build/reports/checkstyle/main.html. It's "Le bloc devrait contenir au moins une instruction." in French. But I can see the same 10 number of them at https://ci.apache.org/projects/ofbiz/logs/trunk/checkstyle.html I'm in a hurry today, I'll have a closer look tmrw, cheers > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, > OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11039) add a chapter "About this documentation"
[ https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11039: --- Attachment: OFBIZ-11039_Documented-add-a-chapter-About-this-documentation-in.patch > add a chapter "About this documentation" > > > Key: OFBIZ-11039 > URL: https://issues.apache.org/jira/browse/OFBIZ-11039 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Fix For: Trunk > > Attachments: Employee_Main_Screen.png, > HR-Employee_Submenu_Rainbow_Stone.png, HR-Employee_Submenu_Tomahawk.png, > HR_Application_Submenu_Rainbow_Stone.png, > HR_Application_Submenu_Tomahawk.png, > OFBIZ-11039_Documented-add-a-chapter-About-this-documentation-in.patch, > hr-about-doc.adoc > > > This chapter present the main OFBiz GUI rules with some screenshot and link > between tutorial and video of "Scenario GUI Test" > Currently it's in HR, but when other application will be done it can be > generalize and go to User Manual introduction. > The file hr-about-doc.adoc associated with this task is included via a > include:: line in the humanres.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11039) add a chapter "About this documentation"
[ https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195538#comment-17195538 ] Olivier Heintz commented on OFBIZ-11039: create a new patch (with git format-patch so applicable with git am) which replace all the previous patch this patch is applicable after OFBIZ-11026 one because it update humanres.adoc too (add one line to include the new file). [^OFBIZ-11039_Documented-add-a-chapter-About-this-documentation-in.patch] > add a chapter "About this documentation" > > > Key: OFBIZ-11039 > URL: https://issues.apache.org/jira/browse/OFBIZ-11039 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Fix For: Trunk > > Attachments: Employee_Main_Screen.png, > HR-Employee_Submenu_Rainbow_Stone.png, HR-Employee_Submenu_Tomahawk.png, > HR_Application_Submenu_Rainbow_Stone.png, > HR_Application_Submenu_Tomahawk.png, > OFBIZ-11039_Documented-add-a-chapter-About-this-documentation-in.patch, > hr-about-doc.adoc > > > This chapter present the main OFBiz GUI rules with some screenshot and link > between tutorial and video of "Scenario GUI Test" > Currently it's in HR, but when other application will be done it can be > generalize and go to User Manual introduction. > The file hr-about-doc.adoc associated with this task is included via a > include:: line in the humanres.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11027) HR Doc, Associated a scenario UI test for each process
[ https://issues.apache.org/jira/browse/OFBIZ-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11027: --- Attachment: OFBIZ-11027_Documented-HR-Doc-Associated-a-scenario-UI-test-for-.patch > HR Doc, Associated a scenario UI test for each process > -- > > Key: OFBIZ-11027 > URL: https://issues.apache.org/jira/browse/OFBIZ-11027 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: Documentation, humanres, tutorial > Attachments: > OFBIZ-11027_Documented-HR-Doc-Associated-a-scenario-UI-test-for-.patch, > OFBIZ-11027_hr-intro.adoc.patch, hr-tuto-define-company-organization.adoc, > hr-tuto-employment-and-salary.adoc > > > I propose that in HR documentation, each process is described via a scenario > explained like a tutorial. > To realize the tutorial, and to have more quality, I propose to create a UI > Test for each process. > In these tests, some user messages are added and a video recording is in > place when it run, so result is usable as a tutorial > With this method to create tutorial we are sure it are up to date and it > works ! > Currently a tutorial / test exist for process "Organization, Job Position and > Definition" and it run ona daily base on Apache OFBiz trunk demo. > A second one exist for process "Employee Salary and Benefits Administration" > but for runing some modification /enhancement are needed, so currenlty it not > run on Apache OFBiz trunk demo. > Result video are readeable > https://video.ploud.fr/video-channels/ofbizextra_tutorial/videos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11027) HR Doc, Associated a scenario UI test for each process
[ https://issues.apache.org/jira/browse/OFBIZ-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195530#comment-17195530 ] Olivier Heintz commented on OFBIZ-11027: create a new patch (with git format-patch so applicable with git am) this patch is applicable after OFBIZ-11026 one because it update hr-intro.adoc In this patch there are two scenario UI, one per documented HR process [^OFBIZ-11027_Documented-HR-Doc-Associated-a-scenario-UI-test-for-.patch] > HR Doc, Associated a scenario UI test for each process > -- > > Key: OFBIZ-11027 > URL: https://issues.apache.org/jira/browse/OFBIZ-11027 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: Documentation, humanres, tutorial > Attachments: OFBIZ-11027_hr-intro.adoc.patch, > hr-tuto-define-company-organization.adoc, hr-tuto-employment-and-salary.adoc > > > I propose that in HR documentation, each process is described via a scenario > explained like a tutorial. > To realize the tutorial, and to have more quality, I propose to create a UI > Test for each process. > In these tests, some user messages are added and a video recording is in > place when it run, so result is usable as a tutorial > With this method to create tutorial we are sure it are up to date and it > works ! > Currently a tutorial / test exist for process "Organization, Job Position and > Definition" and it run ona daily base on Apache OFBiz trunk demo. > A second one exist for process "Employee Salary and Benefits Administration" > but for runing some modification /enhancement are needed, so currenlty it not > run on Apache OFBiz trunk demo. > Result video are readeable > https://video.ploud.fr/video-channels/ofbizextra_tutorial/videos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11026) HR Doc drive by process
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11026: --- Attachment: OFBIZ-11026_Documented-HR-Doc-drive-by-process-OFBIZ-11026.patch > HR Doc drive by process > --- > > Key: OFBIZ-11026 > URL: https://issues.apache.org/jira/browse/OFBIZ-11026 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Michael Brohl >Priority: Major > Labels: Documentation, humanres > Attachments: > OFBIZ-11026_Documented-HR-Doc-drive-by-process-OFBIZ-11026.patch, > OFBIZ-11026_hr-intro.adoc.patch, OFBIZ-11026_humanres.adoc.patch, > OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch > > > Currently HR doc main chapters are on core HR object, I propose to group them > in a chapter and having a chapter by process in the same level bot group in > the HR Process. > Each process is described via a scenario explained like a tutorial, and each > time a core object is used, a link is done to its chapter. > To help review : doc with these modifications are available at > [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources] > and Apache OFBiz standard (without modifications) is available too at > https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources > current HR TOC > -- > 3.2. Human Resources > 3.2.1. About Human Resources > 3.2.2. Human Resources Processes > 3.2.3. Employee Positions > 3.2.4. Employees > 3.2.5. Employments > 3.2.6. Performance Review > 3.2.7. Qualifications > 3.2.8. Recruitment > 3.2.9. Skills > 3.2.10. Resumes > 3.2.11. Training > 3.2.12. Leave > 3.2.13. Security > 3.2.14. Global HR Settings > 3.2.15. Glossary > Proposed HR TOC > > 4. Human Resources > 4.1. About this documentation > 4.2. About Human Resources > 4.3. HR Processes > 4.3.1. Organization, Job Position and Definition > 4.3.2. Recruitment, Candidate Selection and Hiring > 4.3.3. Employee Training and Development > 4.3.4. Performance Management and Employee Evaluation > 4.3.5. Employee Salary and Benefits Administration > 4.4. HR core object > 4.4.1. Employee Positions > 4.4.2. Employees > 4.4.3. Employments > 4.4.4. Performance Review > 4.4.5. Qualifications > 4.4.6. Recruitment > 4.4.7. Skills > 4.4.8. Resumes > 4.4.9. Training > 4.4.10. Leave > 4.4.11. Security > 4.5. Global HR Settings > 4.5.1. Skills Types > 4.6. HR Data model > 4.6.1. Employee Position > 4.6.2. Employment > 4.6.3. Qualification, Skill, Review > 4.6.4. HR App intra-application integration > 4.7. Glossary -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11026) HR Doc drive by process
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195523#comment-17195523 ] Olivier Heintz commented on OFBIZ-11026: create a new patch (with git format-patch so applicable with git am) including the new sub-chapter hr-data-model and hr-appendix [^OFBIZ-11026_Documented-HR-Doc-drive-by-process-OFBIZ-11026.patch] > HR Doc drive by process > --- > > Key: OFBIZ-11026 > URL: https://issues.apache.org/jira/browse/OFBIZ-11026 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Michael Brohl >Priority: Major > Labels: Documentation, humanres > Attachments: OFBIZ-11026_hr-intro.adoc.patch, > OFBIZ-11026_humanres.adoc.patch, > OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch > > > Currently HR doc main chapters are on core HR object, I propose to group them > in a chapter and having a chapter by process in the same level bot group in > the HR Process. > Each process is described via a scenario explained like a tutorial, and each > time a core object is used, a link is done to its chapter. > To help review : doc with these modifications are available at > [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources] > and Apache OFBiz standard (without modifications) is available too at > https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources > current HR TOC > -- > 3.2. Human Resources > 3.2.1. About Human Resources > 3.2.2. Human Resources Processes > 3.2.3. Employee Positions > 3.2.4. Employees > 3.2.5. Employments > 3.2.6. Performance Review > 3.2.7. Qualifications > 3.2.8. Recruitment > 3.2.9. Skills > 3.2.10. Resumes > 3.2.11. Training > 3.2.12. Leave > 3.2.13. Security > 3.2.14. Global HR Settings > 3.2.15. Glossary > Proposed HR TOC > > 4. Human Resources > 4.1. About this documentation > 4.2. About Human Resources > 4.3. HR Processes > 4.3.1. Organization, Job Position and Definition > 4.3.2. Recruitment, Candidate Selection and Hiring > 4.3.3. Employee Training and Development > 4.3.4. Performance Management and Employee Evaluation > 4.3.5. Employee Salary and Benefits Administration > 4.4. HR core object > 4.4.1. Employee Positions > 4.4.2. Employees > 4.4.3. Employments > 4.4.4. Performance Review > 4.4.5. Qualifications > 4.4.6. Recruitment > 4.4.7. Skills > 4.4.8. Resumes > 4.4.9. Training > 4.4.10. Leave > 4.4.11. Security > 4.5. Global HR Settings > 4.5.1. Skills Types > 4.6. HR Data model > 4.6.1. Employee Position > 4.6.2. Employment > 4.6.3. Qualification, Skill, Review > 4.6.4. HR App intra-application integration > 4.7. Glossary -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-4687) Add attributes value and type for script tag in screen, form. Default type is groovy and value can be a little script.
[ https://issues.apache.org/jira/browse/OFBIZ-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz closed OFBIZ-4687. - Resolution: Abandoned > Add attributes value and type for script tag in screen, form. Default type is > groovy and value can be a little script. > -- > > Key: OFBIZ-4687 > URL: https://issues.apache.org/jira/browse/OFBIZ-4687 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: OFBIZ-4687.patch, OFBIZ-4687_withExpression.patch > > > this enhancement can be usefull for branch 20120209RemoveBsh > and for trunk, to avoid very small groovy file -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10303) Add a Global Glossary for Documentation Guides
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-10303: --- Attachment: (was: OFBIZ-10303-Documented-Add-a-Global-Glossary-for-user-documentat.patch) > Add a Global Glossary for Documentation Guides > -- > > Key: OFBIZ-10303 > URL: https://issues.apache.org/jira/browse/OFBIZ-10303 > Project: OFBiz > Issue Type: Task >Reporter: Olivier Heintz >Priority: Minor > Attachments: > OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch, > humanres.adoc.patch, ofbiz-glossary.adoc, ofbiz-glossary.adoc, > ofbiz-glossary.adoc, user-manual.adoc.patch > > > Create a ofbiz-glossary.adoc in _include directory at the top level (near > user-manual.adoc and developer-manual.adoc) > This file will be used for all terms which are global to ofbiz (not link to a > component). > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10303) Add a Global Glossary for Documentation Guides
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-10303: --- Attachment: OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch > Add a Global Glossary for Documentation Guides > -- > > Key: OFBIZ-10303 > URL: https://issues.apache.org/jira/browse/OFBIZ-10303 > Project: OFBiz > Issue Type: Task >Reporter: Olivier Heintz >Priority: Minor > Attachments: > OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch, > humanres.adoc.patch, ofbiz-glossary.adoc, ofbiz-glossary.adoc, > ofbiz-glossary.adoc, user-manual.adoc.patch > > > Create a ofbiz-glossary.adoc in _include directory at the top level (near > user-manual.adoc and developer-manual.adoc) > This file will be used for all terms which are global to ofbiz (not link to a > component). > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10303) Add a Global Glossary for Documentation Guides
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195448#comment-17195448 ] Olivier Heintz commented on OFBIZ-10303: New patch is done with git format-patch (apply it with git am) [^OFBIZ-10303-Documented-Add-a-Global-Glossary-for-user-documentat.patch] Add the global-glossary and use it in two place. > Add a Global Glossary for Documentation Guides > -- > > Key: OFBIZ-10303 > URL: https://issues.apache.org/jira/browse/OFBIZ-10303 > Project: OFBiz > Issue Type: Task >Reporter: Olivier Heintz >Priority: Minor > Attachments: > OFBIZ-10303-Documented-Add-a-Global-Glossary-for-user-documentat.patch, > humanres.adoc.patch, ofbiz-glossary.adoc, ofbiz-glossary.adoc, > ofbiz-glossary.adoc, user-manual.adoc.patch > > > Create a ofbiz-glossary.adoc in _include directory at the top level (near > user-manual.adoc and developer-manual.adoc) > This file will be used for all terms which are global to ofbiz (not link to a > component). > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10303) Add a Global Glossary for Documentation Guides
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-10303: --- Attachment: OFBIZ-10303-Documented-Add-a-Global-Glossary-for-user-documentat.patch > Add a Global Glossary for Documentation Guides > -- > > Key: OFBIZ-10303 > URL: https://issues.apache.org/jira/browse/OFBIZ-10303 > Project: OFBiz > Issue Type: Task >Reporter: Olivier Heintz >Priority: Minor > Attachments: > OFBIZ-10303-Documented-Add-a-Global-Glossary-for-user-documentat.patch, > humanres.adoc.patch, ofbiz-glossary.adoc, ofbiz-glossary.adoc, > ofbiz-glossary.adoc, user-manual.adoc.patch > > > Create a ofbiz-glossary.adoc in _include directory at the top level (near > user-manual.adoc and developer-manual.adoc) > This file will be used for all terms which are global to ofbiz (not link to a > component). > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195444#comment-17195444 ] Suraj Khurana commented on OFBIZ-11926: --- Hi Jacques, Please check build/reports/checkstyle/main.html, and search for 'Must have at least one'. Some of them can be staright forward to handle, some others needs a defined pattern. HTH. > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, > OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195349#comment-17195349 ] ASF subversion and git services commented on OFBIZ-12014: - Commit 71e027d3a1729eb72b2ff2478e5143114ea53e1e in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=71e027d ] Documented: Error while decoding url parameters with percent character (OFBIZ-12014) Just a comment to clarify > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-12014.patch, Screenshot from 2020-09-14 > 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195336#comment-17195336 ] Pradeep Choudhary commented on OFBIZ-12014: --- Thanks [~jleroux] for adding further points to it. > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-12014.patch, Screenshot from 2020-09-14 > 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12014. --- Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-12014.patch, Screenshot from 2020-09-14 > 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195323#comment-17195323 ] ASF subversion and git services commented on OFBIZ-12014: - Commit 41bbf1593364e7f65191805d809ce9a04e5eacda in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=41bbf15 ] Fixed: Error while decoding url parameters with percent character (OFBIZ-12014) This has been already fixed (an clearly explained) in OFBIZ-10275 and broken again in OFBIZ-11822 Thanks: Pradeep Choudhary > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12014.patch, Screenshot from 2020-09-14 > 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11822) Double encoded urls are not being decoded
[ https://issues.apache.org/jira/browse/OFBIZ-11822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195328#comment-17195328 ] ASF subversion and git services commented on OFBIZ-11822: - Commit 748e6c3452bdd840f563b66268ca3b513b536267 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=748e6c3 ] Fixed: Error while decoding url parameters with percent character (OFBIZ-12014) This has been already fixed (an clearly explained) in OFBIZ-10275 and broken again in OFBIZ-11822 Thanks: Pradeep Choudhary > Double encoded urls are not being decoded > - > > Key: OFBIZ-11822 > URL: https://issues.apache.org/jira/browse/OFBIZ-11822 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: 17.12.03, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 18.12.01, 17.12.04 > > Attachments: apache-ofbiz-17.12.03-fr2.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > a small miss-out error, the urlcodec decode output is not being used -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10275) UtilCodec URL decoding breaks values with german umlauts
[
https://issues.apache.org/jira/browse/OFBIZ-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195321#comment-17195321
]
ASF subversion and git services commented on OFBIZ-10275:
-
Commit a353cda8b6f5ae4fa5dd0706b7885b6402488f76 in ofbiz-framework's branch
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a353cda ]
Fixed: Error while decoding url parameters with percent character (OFBIZ-12014)
This has been already fixed (an clearly explained) in OFBIZ-10275 and broken
again in OFBIZ-11822
Thanks: Pradeep Choudhary
> UtilCodec URL decoding breaks values with german umlauts
>
>
> Key: OFBIZ-10275
> URL: https://issues.apache.org/jira/browse/OFBIZ-10275
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 16.11.05, 18.12.01, 17.12.01
>
> Attachments: OFBIZ-10275_UrlCodec_decode_via_URLDecoder.patch
>
>
> ...and other UTF-8 characters encoded in two hex. values like in this example:
> {code:java}
> String example = "/webcontent/example_öl.jpg";
> String encoded = UtilCodec.getEncoder("url").encode(example);
> System.out.println(encoded);
> => "%2Fwebcontent%2Fexample_%C3%B6l.jpg"
> String decoded = UtilCodec.getDecoder("url").decode(encoded);
> System.out.println(decoded);
> => "/webcontent/example_öl.jpg"{code}
>
> The reason for this is the OWASP ESAPI PercentCodec implementation used
> within the method UtilCodec.canonicalize, called before the proper decoding
> via java.net.URLDecoder here:
> {code:java}
> public String decode(String original) {
> try {
> String canonical = canonicalize(original);
> return URLDecoder.decode(canonical, "UTF-8");
> } catch (UnsupportedEncodingException ee) {
> Debug.logError(ee, module);
> return null;
> }
> }{code}
>
> The fix could be to only use the canonicalize logic to check the original
> value for double/mixed encoding and to encode the original value afterwards
> via URLDecoder instead of using the canonicalize output for this.
> This way the UrlCodec decode method matches the encode method by only using
> URLDecoder / URLEncoder for doing the main job.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195320#comment-17195320 ] ASF subversion and git services commented on OFBIZ-12014: - Commit a353cda8b6f5ae4fa5dd0706b7885b6402488f76 in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a353cda ] Fixed: Error while decoding url parameters with percent character (OFBIZ-12014) This has been already fixed (an clearly explained) in OFBIZ-10275 and broken again in OFBIZ-11822 Thanks: Pradeep Choudhary > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12014.patch, Screenshot from 2020-09-14 > 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11822) Double encoded urls are not being decoded
[ https://issues.apache.org/jira/browse/OFBIZ-11822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195325#comment-17195325 ] ASF subversion and git services commented on OFBIZ-11822: - Commit 41bbf1593364e7f65191805d809ce9a04e5eacda in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=41bbf15 ] Fixed: Error while decoding url parameters with percent character (OFBIZ-12014) This has been already fixed (an clearly explained) in OFBIZ-10275 and broken again in OFBIZ-11822 Thanks: Pradeep Choudhary > Double encoded urls are not being decoded > - > > Key: OFBIZ-11822 > URL: https://issues.apache.org/jira/browse/OFBIZ-11822 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: 17.12.03, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 18.12.01, 17.12.04 > > Attachments: apache-ofbiz-17.12.03-fr2.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > a small miss-out error, the urlcodec decode output is not being used -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10275) UtilCodec URL decoding breaks values with german umlauts
[
https://issues.apache.org/jira/browse/OFBIZ-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195324#comment-17195324
]
ASF subversion and git services commented on OFBIZ-10275:
-
Commit 41bbf1593364e7f65191805d809ce9a04e5eacda in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=41bbf15 ]
Fixed: Error while decoding url parameters with percent character (OFBIZ-12014)
This has been already fixed (an clearly explained) in OFBIZ-10275 and broken
again in OFBIZ-11822
Thanks: Pradeep Choudhary
> UtilCodec URL decoding breaks values with german umlauts
>
>
> Key: OFBIZ-10275
> URL: https://issues.apache.org/jira/browse/OFBIZ-10275
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 16.11.05, 18.12.01, 17.12.01
>
> Attachments: OFBIZ-10275_UrlCodec_decode_via_URLDecoder.patch
>
>
> ...and other UTF-8 characters encoded in two hex. values like in this example:
> {code:java}
> String example = "/webcontent/example_öl.jpg";
> String encoded = UtilCodec.getEncoder("url").encode(example);
> System.out.println(encoded);
> => "%2Fwebcontent%2Fexample_%C3%B6l.jpg"
> String decoded = UtilCodec.getDecoder("url").decode(encoded);
> System.out.println(decoded);
> => "/webcontent/example_öl.jpg"{code}
>
> The reason for this is the OWASP ESAPI PercentCodec implementation used
> within the method UtilCodec.canonicalize, called before the proper decoding
> via java.net.URLDecoder here:
> {code:java}
> public String decode(String original) {
> try {
> String canonical = canonicalize(original);
> return URLDecoder.decode(canonical, "UTF-8");
> } catch (UnsupportedEncodingException ee) {
> Debug.logError(ee, module);
> return null;
> }
> }{code}
>
> The fix could be to only use the canonicalize logic to check the original
> value for double/mixed encoding and to encode the original value afterwards
> via URLDecoder instead of using the canonicalize output for this.
> This way the UrlCodec decode method matches the encode method by only using
> URLDecoder / URLEncoder for doing the main job.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195326#comment-17195326 ] ASF subversion and git services commented on OFBIZ-12014: - Commit 748e6c3452bdd840f563b66268ca3b513b536267 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=748e6c3 ] Fixed: Error while decoding url parameters with percent character (OFBIZ-12014) This has been already fixed (an clearly explained) in OFBIZ-10275 and broken again in OFBIZ-11822 Thanks: Pradeep Choudhary > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12014.patch, Screenshot from 2020-09-14 > 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11822) Double encoded urls are not being decoded
[ https://issues.apache.org/jira/browse/OFBIZ-11822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195322#comment-17195322 ] ASF subversion and git services commented on OFBIZ-11822: - Commit a353cda8b6f5ae4fa5dd0706b7885b6402488f76 in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a353cda ] Fixed: Error while decoding url parameters with percent character (OFBIZ-12014) This has been already fixed (an clearly explained) in OFBIZ-10275 and broken again in OFBIZ-11822 Thanks: Pradeep Choudhary > Double encoded urls are not being decoded > - > > Key: OFBIZ-11822 > URL: https://issues.apache.org/jira/browse/OFBIZ-11822 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: 17.12.03, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 18.12.01, 17.12.04 > > Attachments: apache-ofbiz-17.12.03-fr2.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > a small miss-out error, the urlcodec decode output is not being used -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10275) UtilCodec URL decoding breaks values with german umlauts
[
https://issues.apache.org/jira/browse/OFBIZ-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195327#comment-17195327
]
ASF subversion and git services commented on OFBIZ-10275:
-
Commit 748e6c3452bdd840f563b66268ca3b513b536267 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=748e6c3 ]
Fixed: Error while decoding url parameters with percent character (OFBIZ-12014)
This has been already fixed (an clearly explained) in OFBIZ-10275 and broken
again in OFBIZ-11822
Thanks: Pradeep Choudhary
> UtilCodec URL decoding breaks values with german umlauts
>
>
> Key: OFBIZ-10275
> URL: https://issues.apache.org/jira/browse/OFBIZ-10275
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 16.11.05, 18.12.01, 17.12.01
>
> Attachments: OFBIZ-10275_UrlCodec_decode_via_URLDecoder.patch
>
>
> ...and other UTF-8 characters encoded in two hex. values like in this example:
> {code:java}
> String example = "/webcontent/example_öl.jpg";
> String encoded = UtilCodec.getEncoder("url").encode(example);
> System.out.println(encoded);
> => "%2Fwebcontent%2Fexample_%C3%B6l.jpg"
> String decoded = UtilCodec.getDecoder("url").decode(encoded);
> System.out.println(decoded);
> => "/webcontent/example_öl.jpg"{code}
>
> The reason for this is the OWASP ESAPI PercentCodec implementation used
> within the method UtilCodec.canonicalize, called before the proper decoding
> via java.net.URLDecoder here:
> {code:java}
> public String decode(String original) {
> try {
> String canonical = canonicalize(original);
> return URLDecoder.decode(canonical, "UTF-8");
> } catch (UnsupportedEncodingException ee) {
> Debug.logError(ee, module);
> return null;
> }
> }{code}
>
> The fix could be to only use the canonicalize logic to check the original
> value for double/mixed encoding and to encode the original value afterwards
> via URLDecoder instead of using the canonicalize output for this.
> This way the UrlCodec decode method matches the encode method by only using
> URLDecoder / URLEncoder for doing the main job.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12014) Error while decoding url parameters with percent character
[
https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195314#comment-17195314
]
Jacques Le Roux commented on OFBIZ-12014:
-
Thanks Pradeep
This is indeed the best thing to do. I totally missed the point when I
committed for OFBIZ-11822 which was wrong.
Moreover we have nothing to fear with multiple encoding. Not only the
information will be shown in the log. But also in, at least, the case of
makeHyperlinkString macro, Freemarker is rejecting a double encoded string like
%253Cscript%253Ealert('XSS')%253C%252Fscript%253E (found at bottom of
https://owasp.org/www-community/Double_Encoding):
{noformat}
2020-09-14 11:01:23,065 |sse-nio-8443-exec-10 |RequestHandler
|I| Rendering View [orderview]. Hidden sessionId by default.
2020-09-14 11:01:23,065 |sse-nio-8443-exec-10 |UtilCodec
|W| Multiple (2x) encoding detected in
%253Cscript%253Ealert('XSS')%253C%252Fscript%253E
2020-09-14 11:01:23,065 |sse-nio-8443-exec-10 |UtilCodec
|W| Multiple (2x) encoding detected in
%253Cscript%253Ealert('XSS')%253C%252Fscript%253E
2020-09-14 11:01:23,066 |sse-nio-8443-exec-10 |ServiceDispatcher
|T| Sync service [order/getUserPreferenceGroup] finished in [1] milliseconds
2020-09-14 11:01:23,066 |sse-nio-8443-exec-10 |UtilCodec
|W| Multiple (2x) encoding detected in
%253Cscript%253Ealert('XSS')%253C%252Fscript%253E
2020-09-14 11:01:36,172 |sse-nio-8443-exec-10 |UtilCodec
|W| Multiple (3x) encoding detected in
%25253Cscript%25253Ealert%28%27XSS%27%29%25253C%25252Fscript%25253E
2020-09-14 11:02:06,843 |sse-nio-8443-exec-10 |UtilCodec
|W| Multiple (3x) encoding detected in
%25253Cscript%25253Ealert%28%27XSS%27%29%25253C%25252Fscript%25253E
2020-09-14 11:02:06,843 |sse-nio-8443-exec-10 |UtilCodec
|W| Multiple (2x) encoding detected in
%253Cscript%253Ealert('XSS')%253C%252Fscript%253E
2020-09-14 11:02:06,853 |sse-nio-8443-exec-10 |ScreenFactory
|I| Got 33 screens in 0.007s from:
file:/C:/projectsASF/Git/ofbiz-framework/applications/order/widget/ordermgr/OrderViewScreens.xml
2020-09-14 11:02:07,653 |sse-nio-8443-exec-10 |ScreenFactory
|I| Got 4 screens in 0.005s from:
file:/C:/projectsASF/Git/ofbiz-framework/applications/order/widget/ordermgr/CommonScreens.xml
2020-09-14 11:02:07,659 |sse-nio-8443-exec-10 |ScreenFactory
|I| Got 1 screens in 0.005s from:
file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/widget/CommonScreens.xml
2020-09-14 11:02:07,732 |sse-nio-8443-exec-10 |ServiceDispatcher
|T| Sync service [order/getLastSystemInfoNote] finished in [10] milliseconds
2020-09-14 11:02:07,741 |sse-nio-8443-exec-10 |ScreenFactory
|I| Got 26 screens in 0.005s from:
file:/C:/projectsASF/Git/ofbiz-framework/framework/common/widget/CommonScreens.xml
2020-09-14 11:02:07,923 |sse-nio-8443-exec-10 |ScreenFactory
|I| Got 25 screens in 0.006s from:
file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-09-14 11:02:08,027 |sse-nio-8443-exec-10 |ConfigXMLReader
|I| controller loaded: 0.0s, 0 requests, 0 views in
file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/handlers-controller.xml
2020-09-14 11:02:08,027 |sse-nio-8443-exec-10 |ConfigXMLReader
|I| controller loaded: 0.018s, 51 requests, 21 views in
file:/C:/projectsASF/Git/ofbiz-framework/framework/common/webcommon/WEB-INF/common-controller.xml
2020-09-14 11:02:08,045 |sse-nio-8443-exec-10 |ConfigXMLReader
|I| controller loaded: 0.0s, 4 requests, 0 views in
file:/C:/projectsASF/Git/ofbiz-framework/applications/commonext/webapp/WEB-INF/controller.xml
2020-09-14 11:02:08,070 |sse-nio-8443-exec-10 |ConfigXMLReader
|I| controller loaded: 0.004s, 379 requests, 154 views in
file:/C:/projectsASF/Git/ofbiz-framework/applications/content/webapp/content/WEB-INF/controller.xml
2020-09-14 11:02:08,073 |sse-nio-8443-exec-10 |ConfigXMLReader
|I| controller loaded: 0.081s, 379 requests, 153 views in
file:/C:/projectsASF/Git/ofbiz-framework/applications/order/webapp/ordermgr/WEB-INF/controller.xml
2020-09-14 11:02:08,073 |sse-nio-8443-exec-10 |ConfigXMLReader
|I| controller loaded: 0.103s, 16 requests, 14 views in
file:/C:/projectsASF/Git/ofbiz-framework/plugins/birt/webapp/ordermgr/WEB-INF/controller.xml
2020-09-14 11:02:08,143 |sse-nio-8443-exec-10 |FreeMarkerWorker
|E| null
freemarker.core._MiscTemplateException: Failed to "?eval" string with this
error:
---begin-message---
Syntax error in ?eval-ed string in line 1, column 65:
Encountered "XSS", but was expecting one of:
"."
".."
"..*"
"?"
"??"
"!"
","
[jira] [Commented] (OFBIZ-11999) WSDL does not correspondent to response and is invalid
[
https://issues.apache.org/jira/browse/OFBIZ-11999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195257#comment-17195257
]
Dominik B commented on OFBIZ-11999:
---
Jacques:
I did not cross any other issues yet, but each of the problems mentioned above
alone makes the WSDL file invalid and, thus, defeats the purpose of providing
one.
> WSDL does not correspondent to response and is invalid
> ---
>
> Key: OFBIZ-11999
> URL: https://issues.apache.org/jira/browse/OFBIZ-11999
> Project: OFBiz
> Issue Type: Bug
> Components: framework/service
>Affects Versions: Release Branch 17.12
>Reporter: Dominik B
>Priority: Major
> Labels: soap
>
> I'm new to OFBiz and tried to use its SOAP service. However, I think there's
> something wrong with the generated WSDL.
>
> Let's take for example findProductById, which generates the follow WSDL:
> {code:java}
> http://schemas.xmlsoap.org/wsdl/;
> xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/;
> xmlns:tns="http://ofbiz.apache.org/service/;
> xmlns:xsd="http://www.w3.org/2001/XMLSchema;
> targetNamespace="http://ofbiz.apache.org/service/;>
>
> http://ofbiz.apache.org/service/;>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
> use="required" />
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> The name of element need to be
> appended with name of entity such as eepk-Product for Product
> entity.
>
>
>
>
> The name of element need to be
> appended with name of entity such as eeval-Product for Product
> entity.
>
>
>
>
> Object content is hex encoded so does
> not need to be in a CDATA block.
>
>
>
>
> ref="tns:map-Entry" />
>
>
>
>
> ref="tns:map-Key" />
> ref="tns:map-Value" />
>
>
>
>
> ref="tns:std-String" />
>
>
>
>
>
> ref="tns:std-String" />
> ref="tns:std-Integer" />
> ref="tns:std-Long" />
> ref="tns:std-Float" />
> ref="tns:std-Double" />
> ref="tns:std-Boolean" />
> ref="tns:std-Locale" />
> ref="tns:sql-Timestamp" />
> ref="tns:sql-Date" />
> ref="tns:sql-Time" />
> ref="tns:col-ArrayList" />
> ref="tns:col-LinkedList" />
> ref="tns:col-Stack" />
> ref="tns:col-Vector" />
> ref="tns:col-TreeSet" />
> ref="tns:col-HashSet" />
> ref="tns:col-Collection" />
> ref="tns:map-HashMap" />
> ref="tns:map-Properties" />
> ref="tns:map-Hashtable" />
> ref="tns:map-WeakHashMap" />
> ref="tns:map-TreeMap" />
>
[jira] [Comment Edited] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195233#comment-17195233 ] Pradeep Choudhary edited comment on OFBIZ-12014 at 9/14/20, 6:51 AM: - Attached patch to revert the changes done under [OFBIZ-11822 |https://issues.apache.org/jira/browse/OFBIZ-11822] It will use the canonicalize method just for warning and the original parameter string will be decoded. was (Author: pradeep.choudhary1994): Attached patch to revert the changes done under OFBIZ-11822[https://issues.apache.org/jira/browse/OFBIZ-11822] It will use the canonicalize method just for warning and the original parameter string will be decoded. > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12014.patch, Screenshot from 2020-09-14 > 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195233#comment-17195233 ] Pradeep Choudhary commented on OFBIZ-12014: --- Attached patch to revert the changes done under OFBIZ-11822[https://issues.apache.org/jira/browse/OFBIZ-11822] It will use the canonicalize method just for warning and the original parameter string will be decoded. > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12014.patch, Screenshot from 2020-09-14 > 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Choudhary updated OFBIZ-12014: -- Attachment: OFBIZ-12014.patch > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12014.patch, Screenshot from 2020-09-14 > 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12014: --- Assignee: Jacques Le Roux > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Assignee: Jacques Le Roux >Priority: Major > Attachments: Screenshot from 2020-09-14 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12014: -- Priority: Major (was: Trivial) > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Priority: Major > Attachments: Screenshot from 2020-09-14 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195222#comment-17195222 ] Pradeep Choudhary commented on OFBIZ-12014: --- As mentioned in ticket [OFBIZ-10275|https://issues.apache.org/jira/browse/OFBIZ-10275] "The fix could be to only use the canonicalize logic to check the original value for double/mixed encoding and to encode the original value afterwards via URLDecoder instead of using the canonicalize output for this. This way the UrlCodec decode method matches the encode method by only using URLDecoder / URLEncoder for doing the main job." > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Priority: Trivial > Attachments: Screenshot from 2020-09-14 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Choudhary updated OFBIZ-12014: -- Attachment: Screenshot from 2020-09-14 12-02-00.png > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Priority: Trivial > Attachments: Screenshot from 2020-09-14 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195216#comment-17195216 ] Pradeep Choudhary commented on OFBIZ-12014: --- Here, we have passed canonicalize output to URLDecoder.decode() method. Canonicalize, the method itself decodes the parameters and we are passing its output for further decoding, therefore it renders exception. > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Priority: Trivial > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12014) Error while decoding url parameters with percent character
Pradeep Choudhary created OFBIZ-12014: - Summary: Error while decoding url parameters with percent character Key: OFBIZ-12014 URL: https://issues.apache.org/jira/browse/OFBIZ-12014 Project: OFBiz Issue Type: Bug Components: base Affects Versions: Trunk, Release Branch 17.12 Reporter: Pradeep Choudhary When we pass any URL parameter with a percent character, it throws an exception stating the following message: "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: " Steps to regenerate: 1. Open web tools. 2. Navigate to Order Manager component [https://localhost:8443/ordermgr/control/findorders] 3. Search order by entering order Id like %Test%. 4. It will show an error message "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11993) display/selection of unit of measure is broken/plugins
[ https://issues.apache.org/jira/browse/OFBIZ-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195205#comment-17195205 ] Jacques Le Roux commented on OFBIZ-11993: - Sorry Alex, I could not backport last changes to R17 (conflicts) > display/selection of unit of measure is broken/plugins > -- > > Key: OFBIZ-11993 > URL: https://issues.apache.org/jira/browse/OFBIZ-11993 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Labels: patch > Fix For: 18.12.01, 17.12.05 > > Attachments: p-variantinfojs-1.patch, p-variantinfojs-2.patch, > p-variantinfojs-final.patch > > > allow selection of uom for multiple products on the same web page -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11993) display/selection of unit of measure is broken/plugins
[ https://issues.apache.org/jira/browse/OFBIZ-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195203#comment-17195203 ] ASF subversion and git services commented on OFBIZ-11993: - Commit b1c98eee47736b89fd4f54ce45ec012b2a972ccd in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b1c98ee ] Improved: display/selection of unit of measure is broken/plugins (OFBIZ-11993) Better code Thanks: Alex > display/selection of unit of measure is broken/plugins > -- > > Key: OFBIZ-11993 > URL: https://issues.apache.org/jira/browse/OFBIZ-11993 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Labels: patch > Fix For: 18.12.01, 17.12.05 > > Attachments: p-variantinfojs-1.patch, p-variantinfojs-2.patch, > p-variantinfojs-final.patch > > > allow selection of uom for multiple products on the same web page -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11993) display/selection of unit of measure is broken/plugins
[ https://issues.apache.org/jira/browse/OFBIZ-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195202#comment-17195202 ] ASF subversion and git services commented on OFBIZ-11993: - Commit 1205ac591c54d03301e2fcc7ea188d62ae0035cd in ofbiz-plugins's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=1205ac5 ] Improved: display/selection of unit of measure is broken/plugins (OFBIZ-11993) Better code Thanks: Alex Conflicts handled by hand ProductDetail.ftl > display/selection of unit of measure is broken/plugins > -- > > Key: OFBIZ-11993 > URL: https://issues.apache.org/jira/browse/OFBIZ-11993 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Labels: patch > Fix For: 18.12.01, 17.12.05 > > Attachments: p-variantinfojs-1.patch, p-variantinfojs-2.patch, > p-variantinfojs-final.patch > > > allow selection of uom for multiple products on the same web page -- This message was sent by Atlassian Jira (v8.3.4#803005)
