[jira] [Updated] (OFBIZ-12022) Extra whitespace in code
[ https://issues.apache.org/jira/browse/OFBIZ-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12022: -- Attachment: OFBIZ-12022.patch > Extra whitespace in code > > > Key: OFBIZ-12022 > URL: https://issues.apache.org/jira/browse/OFBIZ-12022 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Trivial > Attachments: OFBIZ-12022.patch > > > Found some code occurences where there are some extra spaces, need to correct > them for checkstyle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12022) Extra whitespace in code
Suraj Khurana created OFBIZ-12022: - Summary: Extra whitespace in code Key: OFBIZ-12022 URL: https://issues.apache.org/jira/browse/OFBIZ-12022 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Reporter: Suraj Khurana Assignee: Suraj Khurana Found some code occurences where there are some extra spaces, need to correct them for checkstyle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #44: Implemented: Create new component, data configuration and connection request for Shopify plugin (OFBIZ-11728)
sonarcloud[bot] commented on pull request #44: URL: https://github.com/apache/ofbiz-plugins/pull/44#issuecomment-699439613 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=44&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=44&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=44&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=44&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=44&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=44&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=44&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ ofbiz-plugins&pullRequest=44&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=44&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=44&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=44&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=44) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=44&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=44&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11728) Create new component, data configuration and connection request
[ https://issues.apache.org/jira/browse/OFBIZ-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202532#comment-17202532 ] Shikha Jaiswal commented on OFBIZ-11728: Hi [~pawan] I have created PR. Here is the link: https://github.com/apache/ofbiz-plugins/pull/44 > Create new component, data configuration and connection request > --- > > Key: OFBIZ-11728 > URL: https://issues.apache.org/jira/browse/OFBIZ-11728 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Shikha Jaiswal >Assignee: Shikha Jaiswal >Priority: Major > Attachments: OFBIZ-11728.patch > > > We will be doing following tasks in this ticket: > # Create a new component named *shopify* > # Basic configuration data setup > # Implement a method for HTTP connection request with Shopify > To store configuration details we will create entity *ShopifyConfig* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11965) Improve service name as per best practices
[ https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vaibhav Hood reassigned OFBIZ-11965: Assignee: Vaibhav Hood > Improve service name as per best practices > -- > > Key: OFBIZ-11965 > URL: https://issues.apache.org/jira/browse/OFBIZ-11965 > Project: OFBiz > Issue Type: Improvement > Components: ALL PLUGINS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Vaibhav Hood >Priority: Minor > > Following service names should be corrected as per naming convention best > practices: > * SagePayPaymentAuthorisation > * SagePayPaymentRefund > * SagePayPaymentRelease > * SagePayPaymentVoid > * SetTimeZoneFromBrowser > * SagePayPaymentAuthentication -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11406) Setting a product price in a Purchase Agreement does not expire previous price on product
[ https://issues.apache.org/jira/browse/OFBIZ-11406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi reassigned OFBIZ-11406: --- Assignee: (was: Ankit Joshi) > Setting a product price in a Purchase Agreement does not expire previous > price on product > - > > Key: OFBIZ-11406 > URL: https://issues.apache.org/jira/browse/OFBIZ-11406 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: 16.11.07, Release Branch 18.12, 17.12.01, Trunk >Reporter: Pierre Smits >Priority: Major > Labels: agreement(s), price, product, supplier > Attachments: OFBIZ-Product-Suppliers.png, > OFBiz-Agreement-Item-Products.png > > > In an agreement with a supplier a product can be added to an agreement item. > As shown in > https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementItemSupplierProduct?agreementId=DS-1000-PURCH&agreementItemSeqId=1 > See image OFBiz-Agreement-Item-Products.png for the result. > When this is completed, the 'Supplier' overview of the product shows the > product and its Supplier price is added. > See image OFBIZ-Product-Suppliers.png > However, as shown in the image, the previous price of the supplier is not > expired. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] shikha50 opened a new pull request #44: Implemented: Create new component, data configuration and connection request for Shopify plugin (OFBIZ-11728)
shikha50 opened a new pull request #44: URL: https://github.com/apache/ofbiz-plugins/pull/44 Improved: Implemented: Documented: Completed: Reverted: Fixed: (OFBIZ-) Explanation Thanks: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas reassigned OFBIZ-10386: - Assignee: Devanshu Vyas > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Assignee: Devanshu Vyas >Priority: Major > Attachments: EmptyFields.png, ViewProfile.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10864) i have problem generating xml on Arabic Language
[ https://issues.apache.org/jira/browse/OFBIZ-10864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202530#comment-17202530 ] Lalit Dashora commented on OFBIZ-10864: --- Hi fawzi, Can you please add some details regarding the issue and steps to replicate this one. Thanks! > i have problem generating xml on Arabic Language > > > Key: OFBIZ-10864 > URL: https://issues.apache.org/jira/browse/OFBIZ-10864 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: 16.11.05 >Reporter: fawzi >Priority: Major > Attachments: Screenshot from 2019-03-16 09-59-19.png > > > i have generated PDF in Arabic and it's working great > but my problem when generating XML it does not work > can you plz help me to solve the issue -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202529#comment-17202529 ] Praveen Patil commented on OFBIZ-10386: --- Hi, [~archana.asthana] I have attached the patch. Somehow I am not able to assign this ticket to me. > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Priority: Major > Attachments: EmptyFields.png, ViewProfile.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Praveen Patil updated OFBIZ-10386: -- Attachment: ViewProfile.patch > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Priority: Major > Attachments: EmptyFields.png, ViewProfile.patch > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202526#comment-17202526 ] Suraj Khurana commented on OFBIZ-11926: --- Hi Jacques, I think we can close this one. > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, > OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11454) Content for Blogs is not properly saved
[ https://issues.apache.org/jira/browse/OFBIZ-11454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prakhar Kumar reassigned OFBIZ-11454: - Assignee: Prakhar Kumar > Content for Blogs is not properly saved > --- > > Key: OFBIZ-11454 > URL: https://issues.apache.org/jira/browse/OFBIZ-11454 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Prakhar Kumar >Priority: Minor > > Do as follows: > # Open Url: [https://demo-trunk.ofbiz.apache.org/ecomseo/] (or stable) > # Click on a Blog to navigate there. > # Create New Blog Post > # Fill the fields with text and image and submit as "publish". > ERROR: The content will not be available and replaced by placeholders > EXPECTED: Blogarticle should be displayed showing all text and images -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11374) Convert createSimpleTextContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Punyani reassigned OFBIZ-11374: --- Assignee: Sourabh Punyani (was: vivek singh bisen) > Convert createSimpleTextContent service from mini-lang to groovy DSL > > > Key: OFBIZ-11374 > URL: https://issues.apache.org/jira/browse/OFBIZ-11374 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > > Convert createSimpleTextContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-8641) Unit test case for service - createPostalAddressAndPurposes
[ https://issues.apache.org/jira/browse/OFBIZ-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta reassigned OFBIZ-8641: --- Assignee: (was: Anushi Gupta) > Unit test case for service - createPostalAddressAndPurposes > --- > > Key: OFBIZ-8641 > URL: https://issues.apache.org/jira/browse/OFBIZ-8641 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Akash Jain >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-8641.patch > > > Unit test case for service - createPostalAddressAndPurposes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order
[ https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lalit Dashora reassigned OFBIZ-11680: - Assignee: Lalit Dashora > ViewQuoteProfit shows fields in wrong order > --- > > Key: OFBIZ-11680 > URL: https://issues.apache.org/jira/browse/OFBIZ-11680 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Lalit Dashora >Priority: Major > Labels: quote > Attachments: Screen Shot 2020-05-09 at 10.40.39.png > > > See attached image. > Total amount (of the quote) should be before total cost. > On line items, the quoteUnitPrice should be before averageCost -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11111) Unable to cancel the order
[ https://issues.apache.org/jira/browse/OFBIZ-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Punyani reassigned OFBIZ-1: --- Assignee: Sourabh Punyani (was: Komal Dayle) > Unable to cancel the order > -- > > Key: OFBIZ-1 > URL: https://issues.apache.org/jira/browse/OFBIZ-1 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Sourabh Punyani >Priority: Major > Attachments: OFBIZ-1.png > > > *Step to reproduce* > 1. Login [https://demo-trunk.ofbiz.apache.org/ecomseo] with a valid username > and password. > 2. Place an order. > 3. Navigate to order history and click on view link. > 4. Click on the cancel link in the order item section. > *Actual Result:* The Error message is displayed. > *Note* - Issue is working fine on > "[https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]"; > *Screen print attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202491#comment-17202491
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
Can you find
{code:java}
{code}
in
{code:java}
plugins/ecommerce/webapp/ecommerce/WEB-INF/controller.xml{code}
file ?
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12021) "description" and "comment" datatypes unnecessarily limited to 255 char
[ https://issues.apache.org/jira/browse/OFBIZ-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202397#comment-17202397 ] ddev commented on OFBIZ-12021: -- I can easily add a note in DATAMODEL_CHANGES.adoc . (attaching a proposal [^documentation-first-draft.diff]) Now reading the link you gave... are you saying that we need to deprecate all the entities that had description fields or comment fields by adding "old" to the entitynames, and then creating new entities and copying the data over? It seems excessive. I'm only familiar with postgres, so I'll talk from that perspective. I believe that in postgres that all operations that work on text should also work on varchar(255), so not changing the datatype to text wouldn't break anything, it would just leave people with old installations with the 255 limit. If other DB's handle things in a similar way, I would think we wouldn't need a "migration system". > "description" and "comment" datatypes unnecessarily limited to 255 char > > > Key: OFBIZ-12021 > URL: https://issues.apache.org/jira/browse/OFBIZ-12021 > Project: OFBiz > Issue Type: Improvement > Components: datamodel, framework/entity >Reporter: ddev >Priority: Minor > Attachments: documentation-first-draft.diff, field-types-v2.diff > > Original Estimate: 10m > Remaining Estimate: 10m > > "description" and "comment" fields are restricted to 255 char. However after > some research I found that all the supported databases support longer then > 255 char > I would expect users to want to write more then 255 char in a comment (I know > I personally can). > I have included diff of my proposed solution as a attachment (I am > unfamiliar with the procedures for submitting patches here) > A discussion has been started on dev ML: > https://markmail.org/message/7utrgejc2c44i37u > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12021) "description" and "comment" datatypes unnecessarily limited to 255 char
[ https://issues.apache.org/jira/browse/OFBIZ-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ddev updated OFBIZ-12021: - Attachment: documentation-first-draft.diff > "description" and "comment" datatypes unnecessarily limited to 255 char > > > Key: OFBIZ-12021 > URL: https://issues.apache.org/jira/browse/OFBIZ-12021 > Project: OFBiz > Issue Type: Improvement > Components: datamodel, framework/entity >Reporter: ddev >Priority: Minor > Attachments: documentation-first-draft.diff, field-types-v2.diff > > Original Estimate: 10m > Remaining Estimate: 10m > > "description" and "comment" fields are restricted to 255 char. However after > some research I found that all the supported databases support longer then > 255 char > I would expect users to want to write more then 255 char in a comment (I know > I personally can). > I have included diff of my proposed solution as a attachment (I am > unfamiliar with the procedures for submitting patches here) > A discussion has been started on dev ML: > https://markmail.org/message/7utrgejc2c44i37u > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202270#comment-17202270
]
Jacques Le Roux edited comment on OFBIZ-12018 at 9/25/20, 4:20 PM:
---
Works with "widget.dev.cmd.openSourceFile=c:\\\photon\\\eclipse.exe
${sourceLocation}"
Still not in ecomseo
was (Author: jacques.le.roux):
Works with "widget.dev.cmd.openSourceFile=c:\\\photon\\\eclipse.exe
${sourceLocation}"
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202270#comment-17202270
]
Jacques Le Roux commented on OFBIZ-12018:
-
Works with "widget.dev.cmd.openSourceFile=c:\\\photon\\\eclipse.exe
${sourceLocation}"
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202252#comment-17202252
]
Jacques Le Roux edited comment on OFBIZ-12018 at 9/25/20, 3:58 PM:
---
Hi James,
In backend I see the "Command is sent to open source file with your IDE"
message. But
With "C:\Photon\eclipse.exe" in path and "C:\Photon\eclipse.exe" correctly
launching Eclipse nothing happens.
No "Command is sent to open source file with your IDE" message in ecommerce,
and nothing happens there too.
was (Author: jacques.le.roux):
Hi James,
No "Command is sent to open source file with your IDE" message in ecommerce,
and nothing happens there.
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202252#comment-17202252
]
Jacques Le Roux edited comment on OFBIZ-12018 at 9/25/20, 3:54 PM:
---
Hi James,
No "Command is sent to open source file with your IDE" message in ecommerce,
and nothing happens there.
was (Author: jacques.le.roux):
Hi James,
Still the same StringIndexOutOfBoundsException issue at 1st access.
No "Command is sent to open source file with your IDE" message in ecommerce,
and nothing happens there.
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202252#comment-17202252
]
Jacques Le Roux edited comment on OFBIZ-12018 at 9/25/20, 3:51 PM:
---
Hi James,
Still the same StringIndexOutOfBoundsException issue at 1st access.
No "Command is sent to open source file with your IDE" message in ecommerce,
and nothing happens there.
was (Author: jacques.le.roux):
Hi James,
Still the same StringIndexOutOfBoundsException issue at 1st access.
Then Also got this in backend.
{noformat}
2020-09-25 17:42:55,477 |jsse-nio-8443-exec-2 |ControlServlet
|T| [[[catalog::openSourceFile (Domain:https://localhost)] Request Begun,
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-09-25 17:42:55,483 |jsse-nio-8443-exec-2 |CommonEvents
|E| null
java.io.IOException: Cannot run program "eclipse.exe": CreateProcess error=2,
Le fichier spÚcifiÚ est introuvable
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
~[?:1.8.0_202]
at java.lang.Runtime.exec(Runtime.java:620) ~[?:1.8.0_202]
at java.lang.Runtime.exec(Runtime.java:450) ~[?:1.8.0_202]
at java.lang.Runtime.exec(Runtime.java:347) ~[?:1.8.0_202]
at
org.apache.ofbiz.common.CommonEvents.openSourceFile(CommonEvents.java:469)
[main/:?]
{noformat}
No "Command is sent to open source file with your IDE" message in ecommerce,
and nothing happens there.
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202252#comment-17202252
]
Jacques Le Roux commented on OFBIZ-12018:
-
Hi James,
Still the same StringIndexOutOfBoundsException issue at 1st access.
Then Also got this in backend.
{noformat}
2020-09-25 17:42:55,477 |jsse-nio-8443-exec-2 |ControlServlet
|T| [[[catalog::openSourceFile (Domain:https://localhost)] Request Begun,
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-09-25 17:42:55,483 |jsse-nio-8443-exec-2 |CommonEvents
|E| null
java.io.IOException: Cannot run program "eclipse.exe": CreateProcess error=2,
Le fichier spÚcifiÚ est introuvable
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
~[?:1.8.0_202]
at java.lang.Runtime.exec(Runtime.java:620) ~[?:1.8.0_202]
at java.lang.Runtime.exec(Runtime.java:450) ~[?:1.8.0_202]
at java.lang.Runtime.exec(Runtime.java:347) ~[?:1.8.0_202]
at
org.apache.ofbiz.common.CommonEvents.openSourceFile(CommonEvents.java:469)
[main/:?]
{noformat}
No "Command is sent to open source file with your IDE" message in ecommerce,
and nothing happens there.
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202221#comment-17202221
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
Didn't encountered StringIndexOutOfBoundsException error after commit
d7a5d601bd9c07fa26f4f0d737841f651d749bff. Let me know what is value of the path
variable before the error hits.
Updated both OFBIZ-FRAMEWORK and OFBIZ-PLUGINS projects.
Kindly try again.
Regards,
James
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202213#comment-17202213
]
ASF subversion and git services commented on OFBIZ-12018:
-
Commit 4b8dd2a06bb28bf14e350382432845143783b621 in ofbiz-framework's branch
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4b8dd2a ]
Fixed: Open FTL File from browser (OFBIZ-12018)
Unable to open file in Windows
Thanks Jacques for reporting.
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202202#comment-17202202
]
ASF subversion and git services commented on OFBIZ-12018:
-
Commit 9c40c67e7a45f1cb8e9d13462567fb0eb1c772b6 in ofbiz-plugins's branch
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=9c40c67 ]
Improved: Open FTL File from browser (OFBIZ-12018)
Add request map for ecommerce
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11860) Convert CustRequestTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra reassigned OFBIZ-11860: - Assignee: Nitish Mishra > Convert CustRequestTests.xml to Groovy > -- > > Key: OFBIZ-11860 > URL: https://issues.apache.org/jira/browse/OFBIZ-11860 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Nitish Mishra >Priority: Minor > > Convert CustRequestTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201976#comment-17201976
]
Jacques Le Roux commented on OFBIZ-12018:
-
Thanks James,
Still the error when getting to OFBiz 1st time, ie
{noformat}
2020-09-25 09:38:19,639 |jsse-nio-8443-exec-2 |ControlServlet
|E| Error in request handler:
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1967) ~[?:1.8.0_202]
at
org.apache.ofbiz.base.util.UtilHtml.getVisualThemeFolderNamesToExempt(UtilHtml.java:135)
~[main/:?]
at
org.apache.ofbiz.widget.renderer.html.HtmlWidgetRenderer.buildNamedBorder(HtmlWidgetRenderer.java:79)
~[main/:?]
{noformat}
This is for both https://localhost:8443/ecomseo and don't need login, and
https://localhost:8443/catalog/control/login?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y.
They are both OK when refreshed (F5).
Also I tried SOURCE and "eclipse.exe --launcher.openFile ${sourceLocation}" but
I don't get anything in Eclipse [Version: 2018-12 (4.10.0)]
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12021) "description" and "comment" datatypes unnecessarily limited to 255 char
[ https://issues.apache.org/jira/browse/OFBIZ-12021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201970#comment-17201970 ] Jacques Le Roux commented on OFBIZ-12021: - Hi ddev, I checked the DMBSs types, your patch is OK with me. Before committing, there is something I did not tell you. When we change something in the DBMSs settings we generally (it depends on the change) update a file to let people know about these changes when upgrading OFBiz. In the wiki it's explained at https://cwiki.apache.org/confluence/display/OFBIZ/General+Entity+Overview#GeneralEntityOverview-DeprecatedEntities. We have also the applications/datamodel/DATAMODEL_CHANGES.adoc file to update. TIA :) > "description" and "comment" datatypes unnecessarily limited to 255 char > > > Key: OFBIZ-12021 > URL: https://issues.apache.org/jira/browse/OFBIZ-12021 > Project: OFBiz > Issue Type: Improvement > Components: datamodel, framework/entity >Reporter: ddev >Priority: Minor > Attachments: field-types-v2.diff > > Original Estimate: 10m > Remaining Estimate: 10m > > "description" and "comment" fields are restricted to 255 char. However after > some research I found that all the supported databases support longer then > 255 char > I would expect users to want to write more then 255 char in a comment (I know > I personally can). > I have included diff of my proposed solution as a attachment (I am > unfamiliar with the procedures for submitting patches here) > A discussion has been started on dev ML: > https://markmail.org/message/7utrgejc2c44i37u > -- This message was sent by Atlassian Jira (v8.3.4#803005)
