[GitHub] [ofbiz-framework] ingo-koenemann commented on pull request #236: Improved: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)
ingo-koenemann commented on pull request #236: URL: https://github.com/apache/ofbiz-framework/pull/236#issuecomment-768096271 Hi Jacques, I tried to explain the reasons in the corresponding JIRA issue but found the problem I mentioned (navigation problems while navigating the site without a login and then logging in) does not exist on the demo front end due to the implementation of the login. It is possible to implement a login button using the current methods that automatically sends the user to the previously viewed page (which we have done in custom projects). Without the commit provided the last visited page will not be cleared on appropriate navigation, resulting in a mismatch between where the user currently is on the site and the site saved as the last visited. This results in said login leading to the (falsely identified) last visited site (which required authorization) instead of the current site (if it does not require authorization). For example: 1. Navigate to a profile page requiring authorization. 2. Navigate to an FAQ site which does not require authorization. 3. The login button should now lead, upon authorization) back to the FAQ site. Instead the browser is send to the profile page since it was the last saved request requiring authorization. I hope this explanation clears up the issue. Best regards, Ingo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-12154) Form widget "checkbox" do not persist selected value with multiple options checked
[ https://issues.apache.org/jira/browse/OFBIZ-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nameet Jain updated OFBIZ-12154: Parent: OFBIZ-11933 Issue Type: Sub-task (was: Bug) > Form widget "checkbox" do not persist selected value with multiple options > checked > -- > > Key: OFBIZ-12154 > URL: https://issues.apache.org/jira/browse/OFBIZ-12154 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Nameet Jain >Priority: Major > Attachments: OFBIZ-12154.patch > > > I tried to use the form-widgets checkbox on my find screen. But when > searching values with multiple options checked, no checkbox appears to be > selected. > I found similar kind of ticket OFBIZ-11933. > Seems the checkbox was replaced by a dropdown here. > I suggest fixing this bug at the framework level. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12154) Form widget "checkbox" do not persist selected value with multiple options checked
[ https://issues.apache.org/jira/browse/OFBIZ-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272583#comment-17272583 ] Nameet Jain commented on OFBIZ-12154: - [~jleroux] yes I was trying to use the checkbox on a custom screen. Sure I will add it as a subtask to OFBIZ-11933. Thanks > Form widget "checkbox" do not persist selected value with multiple options > checked > -- > > Key: OFBIZ-12154 > URL: https://issues.apache.org/jira/browse/OFBIZ-12154 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Nameet Jain >Priority: Major > Attachments: OFBIZ-12154.patch > > > I tried to use the form-widgets checkbox on my find screen. But when > searching values with multiple options checked, no checkbox appears to be > selected. > I found similar kind of ticket OFBIZ-11933. > Seems the checkbox was replaced by a dropdown here. > I suggest fixing this bug at the framework level. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12141) Add support for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272506#comment-17272506 ] Justin Mclean commented on OFBIZ-12141: --- My concerns is that data is under additional licenses as well, the translated version of the language I read seemed to apply that the content is also under Creative Commons 3.0 Attribution or Open Data Commons as well but given it just a machine translation I can't be sure. Also as the link to the data above is broken I can't see if there's any additional information in there that may help. I think it would be safer to not use this data. > Add support for Romania > --- > > Key: OFBIZ-12141 > URL: https://issues.apache.org/jira/browse/OFBIZ-12141 > Project: OFBiz > Issue Type: New Feature >Reporter: Ioan Eugen Stan >Priority: Major > > I would like to add support for Romania to OFBiz: provinces, taxes and the > rest. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12162) Single Form Widget on CSS Grid Layout
[ https://issues.apache.org/jira/browse/OFBIZ-12162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272208#comment-17272208 ] Jacques Le Roux commented on OFBIZ-12162: - Hi James, Just a quick review and no test, I like the idea! Looking at the FindRequests & FindReturn changes, could we not in the future switch most of the singles to single_css-grid-layout, at least the simplest one? > Single Form Widget on CSS Grid Layout > - > > Key: OFBIZ-12162 > URL: https://issues.apache.org/jira/browse/OFBIZ-12162 > Project: OFBiz > Issue Type: New Feature > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12162.patch > > > Add a new form widget type i.e. "single_css-grid-layout" > Whereas single form widget is layout using table, single_css-grid-layout form > widget is layout using CSS Grid. > Also will switch FindRequests & FindReturns forms to single_css-grid-layout. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12162) Single Form Widget on CSS Grid Layout
[ https://issues.apache.org/jira/browse/OFBIZ-12162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12162: --- Attachment: OFBIZ-12162.patch > Single Form Widget on CSS Grid Layout > - > > Key: OFBIZ-12162 > URL: https://issues.apache.org/jira/browse/OFBIZ-12162 > Project: OFBiz > Issue Type: New Feature > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12162.patch > > > Add a new form widget type i.e. "single_css-grid-layout" > Whereas single form widget is layout using table, single_css-grid-layout form > widget is layout using CSS Grid. > Also will switch FindRequests & FindReturns forms to single_css-grid-layout. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12162) Single Form Widget on CSS Grid Layout
James Yong created OFBIZ-12162: -- Summary: Single Form Widget on CSS Grid Layout Key: OFBIZ-12162 URL: https://issues.apache.org/jira/browse/OFBIZ-12162 Project: OFBiz Issue Type: New Feature Components: base Affects Versions: Upcoming Branch Reporter: James Yong Assignee: James Yong Fix For: Upcoming Branch Add a new form widget type i.e. "single_css-grid-layout" Whereas single form widget is layout using table, single_css-grid-layout form widget is layout using CSS Grid. Also will switch FindRequests & FindReturns forms to single_css-grid-layout. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12116) Apply CSS Grid to Find Orders
[ https://issues.apache.org/jira/browse/OFBIZ-12116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272090#comment-17272090 ] ASF subversion and git services commented on OFBIZ-12116: - Commit 0863084062605044521c00e30203f5c79e8e8146 in ofbiz-framework's branch refs/heads/trunk from James Yong [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0863084 ] Improved: Apply CSS Grid to Find Orders (OFBIZ-12116) Improve CSS for centering grid item > Apply CSS Grid to Find Orders > - > > Key: OFBIZ-12116 > URL: https://issues.apache.org/jira/browse/OFBIZ-12116 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > Use CSS Grid Layout to arrange form fields in Find Orders page at > /ordermgr/control/findorders > Discussion started at > https://lists.apache.org/thread.html/r6dcf4a8db595e76ab70808ff46eb7d880d6a29a6dea616ca0415ed95%40%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #258: Improved: Spelling error in the German translation of Slovakia (OFBIZ-12161)
sonarcloud[bot] commented on pull request #258: URL: https://github.com/apache/ofbiz-framework/pull/258#issuecomment-767464447 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=258&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=258) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=258&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=258&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12141) Add support for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272028#comment-17272028 ] Ioan Eugen Stan commented on OFBIZ-12141: - Hi [~jmclean] . Thank you for showing interest in this. The data is licensed under OGL-ROU: See [https://data.gov.ro/dataset/siruta/resource/ed3f9ec6-8c12-4ba6-8688-74cadc69f14b] , look for ||Licență|[OGL-ROU-1.0|https://data.gov.ro/pages/licence]| Note: Licență is License in Romanian. I'll check the ASF license pages you shared. I would like to process and transform (process) the CSV into a XML with cities/provinces for use and distribute with OFBiz. > Add support for Romania > --- > > Key: OFBIZ-12141 > URL: https://issues.apache.org/jira/browse/OFBIZ-12141 > Project: OFBiz > Issue Type: New Feature >Reporter: Ioan Eugen Stan >Priority: Major > > I would like to add support for Romania to OFBiz: provinces, taxes and the > rest. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] wpaetzold opened a new pull request #258: Improved: Spelling error in the German translation of Slovakia (OFBIZ-12161)
wpaetzold opened a new pull request #258: URL: https://github.com/apache/ofbiz-framework/pull/258 Corrects a spelling error for the German translation of Slovakia This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12161) Spelling error in the German translation of Slovakia
Wiebke Pätzold created OFBIZ-12161: -- Summary: Spelling error in the German translation of Slovakia Key: OFBIZ-12161 URL: https://issues.apache.org/jira/browse/OFBIZ-12161 Project: OFBiz Issue Type: Improvement Reporter: Wiebke Pätzold Assignee: Wiebke Pätzold In CommonEntityLabels.xml the german translation of Slovakia is spelled wrong. -- This message was sent by Atlassian Jira (v8.3.4#803005)
