[GitHub] [ofbiz-plugins] bjugl opened a new pull request #51: OFBIZ-11434 Fixed: Makes Forum Articles respond to pagination controls
bjugl opened a new pull request #51: URL: https://github.com/apache/ofbiz-plugins/pull/51 Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #51: OFBIZ-11434 Fixed: Makes Forum Articles respond to pagination controls
sonarcloud[bot] commented on pull request #51: URL: https://github.com/apache/ofbiz-plugins/pull/51#issuecomment-772319572 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=51&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=51) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=51&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=51&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] ingo-koenemann opened a new pull request #262: Fixed: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)
ingo-koenemann opened a new pull request #262: URL: https://github.com/apache/ofbiz-framework/pull/262 Fixed: Remove PREVIOUS_REQUEST Session Attribute on non-authentication pages (OFBIZ-12047) Added removal of the PREVIOUS_REQUEST attribute when requesting non-authenticated sites and moved targetRequestUri handling to a accommodate this change This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] ingo-koenemann commented on pull request #236: Improved: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)
ingo-koenemann commented on pull request #236: URL: https://github.com/apache/ofbiz-framework/pull/236#issuecomment-772328485 Ich created a new PR #262. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #262: Fixed: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)
sonarcloud[bot] commented on pull request #262: URL: https://github.com/apache/ofbiz-framework/pull/262#issuecomment-772330011 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=262&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=262) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=262&metric=duplicated_lines_density&view=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] bjugl opened a new pull request #263: OFBIZ-10707 Fixed: StringOutOfBounds Exception while checking available Languages
bjugl opened a new pull request #263: URL: https://github.com/apache/ofbiz-framework/pull/263 Fixed: StringOutOfBounds Exception while checking available Languages (OFBIZ-10707) Thanks: Martin Becker for the initial fix, Michael Brohl and Jacques Le Roux for discussion and improvement suggestions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #263: OFBIZ-10707 Fixed: StringOutOfBounds Exception while checking available Languages
sonarcloud[bot] commented on pull request #263: URL: https://github.com/apache/ofbiz-framework/pull/263#issuecomment-772371309 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=263&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=263) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=263&metric=duplicated_lines_density&view=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10707: - Assignee: Michael Brohl (was: Benjamin Jugl) > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch, > OFBIZ-10707_ListLocals.ftl_02.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10707: -- Affects Version/s: Release Branch 18.12 > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Release Branch 18.12, Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch, > OFBIZ-10707_ListLocals.ftl_02.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] mbrohl merged pull request #263: OFBIZ-10707 Fixed: StringOutOfBounds Exception while checking available Languages
mbrohl merged pull request #263: URL: https://github.com/apache/ofbiz-framework/pull/263 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277884#comment-17277884 ] ASF subversion and git services commented on OFBIZ-10707: - Commit 7bca526c10318d4f94d9e07f380adba43c67c2de in ofbiz-framework's branch refs/heads/trunk from Benjamin Jugl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7bca526 ] Fixed: StringOutOfBounds Exception while checking available Languages (OFBIZ-10707) > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Release Branch 18.12, Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch, > OFBIZ-10707_ListLocals.ftl_02.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277887#comment-17277887 ] ASF subversion and git services commented on OFBIZ-10707: - Commit b56ff5f65965efcba7097753478b5858c35a637b in ofbiz-framework's branch refs/heads/release18.12 from Benjamin Jugl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b56ff5f ] Fixed: StringOutOfBounds Exception while checking available Languages (OFBIZ-10707) > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Release Branch 18.12, Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch, > OFBIZ-10707_ListLocals.ftl_02.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10707. - Fix Version/s: (was: Trunk) Upcoming Branch 18.12.01 Resolution: Fixed Thanks Martin and Benjamin. > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Release Branch 18.12, Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Minor > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-10707_ListLocales.ftl.patch, > OFBIZ-10707_ListLocals.ftl_02.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] mbrohl commented on pull request #32: Release17.12
mbrohl commented on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-772410165 @alexbodn are you aware that this cannot be handled the way you set it up? We appreciate your work but it should be targeted against trunk and split into separate commits. Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl commented on pull request #262: Fixed: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)
mbrohl commented on pull request #262: URL: https://github.com/apache/ofbiz-framework/pull/262#issuecomment-772412348 For discussion and approvals see #236 . I am going to close the previous PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl closed pull request #236: Improved: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)
mbrohl closed pull request #236: URL: https://github.com/apache/ofbiz-framework/pull/236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl commented on pull request #236: Improved: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)
mbrohl commented on pull request #236: URL: https://github.com/apache/ofbiz-framework/pull/236#issuecomment-772412726 Closed for #262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl merged pull request #262: Fixed: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)
mbrohl merged pull request #262: URL: https://github.com/apache/ofbiz-framework/pull/262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[ https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277899#comment-17277899 ] ASF subversion and git services commented on OFBIZ-12047: - Commit ffcd8f34fc39db979e4ba6ec455b4dc165276632 in ofbiz-framework's branch refs/heads/trunk from Ingo Könemann [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ffcd8f3 ] Fixed: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047) Added removal of the _PREVIOUS_REQUEST_ attribute when requesting non-authenticated sites and moved targetRequestUri handling to a accommodate this change > Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages > --- > > Key: OFBIZ-12047 > URL: https://issues.apache.org/jira/browse/OFBIZ-12047 > Project: OFBiz > Issue Type: Bug >Reporter: Ingo Könemann >Assignee: Michael Brohl >Priority: Minor > Fix For: Release Branch 18.12 > > > There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and > execute the previous request after a login occurs. This attribute is not > removed properly when navigating away from a page without logging in. > When navigating to a page that requires authentication the > "_PREVIOUS_REQUEST_" attribute is saved in the session from within the > LoginWorker to be called again when the login was successful through the > RequestHandler. Currently, the attribute is only removed when a login occurs > resulting in the previous request being stored in the session until some form > of login is successfully executed. > This behavior potentially results in navigation problems since a user is able > to navigate to a page requiring authentication without logging in. An old > request will be pulled from the session when a similar event occurs and the > user logs in. > > I propose to have the RequestHandler remove the session attribute > "_PREVIOUS_REQUEST_" after calling a request that does not require > authentication. We also have to restructure the sequence of request handling > to have the "targetRequestUri" handled after the security check and a > possible removal of the session attribute. > > One problem arises with this solution, however, which should be less of an > issue than the current state: > If the login page includes a request call that is handled after the request > showing the login page (for example an ajax call rendering a screen), the > "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To > my knowledge such a case does not exist within the OFBiz environment and > seems to be an edge case far less problematic than the above mentioned > problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[ https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12047: -- Affects Version/s: Release Branch 18.12 Trunk > Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages > --- > > Key: OFBIZ-12047 > URL: https://issues.apache.org/jira/browse/OFBIZ-12047 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Trunk >Reporter: Ingo Könemann >Assignee: Michael Brohl >Priority: Minor > Fix For: Release Branch 18.12 > > > There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and > execute the previous request after a login occurs. This attribute is not > removed properly when navigating away from a page without logging in. > When navigating to a page that requires authentication the > "_PREVIOUS_REQUEST_" attribute is saved in the session from within the > LoginWorker to be called again when the login was successful through the > RequestHandler. Currently, the attribute is only removed when a login occurs > resulting in the previous request being stored in the session until some form > of login is successfully executed. > This behavior potentially results in navigation problems since a user is able > to navigate to a page requiring authentication without logging in. An old > request will be pulled from the session when a similar event occurs and the > user logs in. > > I propose to have the RequestHandler remove the session attribute > "_PREVIOUS_REQUEST_" after calling a request that does not require > authentication. We also have to restructure the sequence of request handling > to have the "targetRequestUri" handled after the security check and a > possible removal of the session attribute. > > One problem arises with this solution, however, which should be less of an > issue than the current state: > If the login page includes a request call that is handled after the request > showing the login page (for example an ajax call rendering a screen), the > "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To > my knowledge such a case does not exist within the OFBiz environment and > seems to be an edge case far less problematic than the above mentioned > problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[ https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12047: -- Component/s: framework/webapp > Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages > --- > > Key: OFBIZ-12047 > URL: https://issues.apache.org/jira/browse/OFBIZ-12047 > Project: OFBiz > Issue Type: Bug > Components: framework/webapp >Affects Versions: Release Branch 18.12, Trunk >Reporter: Ingo Könemann >Assignee: Michael Brohl >Priority: Minor > Fix For: Release Branch 18.12 > > > There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and > execute the previous request after a login occurs. This attribute is not > removed properly when navigating away from a page without logging in. > When navigating to a page that requires authentication the > "_PREVIOUS_REQUEST_" attribute is saved in the session from within the > LoginWorker to be called again when the login was successful through the > RequestHandler. Currently, the attribute is only removed when a login occurs > resulting in the previous request being stored in the session until some form > of login is successfully executed. > This behavior potentially results in navigation problems since a user is able > to navigate to a page requiring authentication without logging in. An old > request will be pulled from the session when a similar event occurs and the > user logs in. > > I propose to have the RequestHandler remove the session attribute > "_PREVIOUS_REQUEST_" after calling a request that does not require > authentication. We also have to restructure the sequence of request handling > to have the "targetRequestUri" handled after the security check and a > possible removal of the session attribute. > > One problem arises with this solution, however, which should be less of an > issue than the current state: > If the login page includes a request call that is handled after the request > showing the login page (for example an ajax call rendering a screen), the > "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To > my knowledge such a case does not exist within the OFBiz environment and > seems to be an edge case far less problematic than the above mentioned > problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[ https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12047: -- Fix Version/s: (was: Release Branch 18.12) Upcoming Branch 18.12.01 > Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages > --- > > Key: OFBIZ-12047 > URL: https://issues.apache.org/jira/browse/OFBIZ-12047 > Project: OFBiz > Issue Type: Bug > Components: framework/webapp >Affects Versions: Release Branch 18.12, Trunk >Reporter: Ingo Könemann >Assignee: Michael Brohl >Priority: Minor > Fix For: 18.12.01, Upcoming Branch > > > There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and > execute the previous request after a login occurs. This attribute is not > removed properly when navigating away from a page without logging in. > When navigating to a page that requires authentication the > "_PREVIOUS_REQUEST_" attribute is saved in the session from within the > LoginWorker to be called again when the login was successful through the > RequestHandler. Currently, the attribute is only removed when a login occurs > resulting in the previous request being stored in the session until some form > of login is successfully executed. > This behavior potentially results in navigation problems since a user is able > to navigate to a page requiring authentication without logging in. An old > request will be pulled from the session when a similar event occurs and the > user logs in. > > I propose to have the RequestHandler remove the session attribute > "_PREVIOUS_REQUEST_" after calling a request that does not require > authentication. We also have to restructure the sequence of request handling > to have the "targetRequestUri" handled after the security check and a > possible removal of the session attribute. > > One problem arises with this solution, however, which should be less of an > issue than the current state: > If the login page includes a request call that is handled after the request > showing the login page (for example an ajax call rendering a screen), the > "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To > my knowledge such a case does not exist within the OFBiz environment and > seems to be an edge case far less problematic than the above mentioned > problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[ https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277904#comment-17277904 ] ASF subversion and git services commented on OFBIZ-12047: - Commit 03167586f989e32cf3d039b9c85f321b2886d3c5 in ofbiz-framework's branch refs/heads/release18.12 from Ingo Könemann [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0316758 ] Fixed: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047) Added removal of the _PREVIOUS_REQUEST_ attribute when requesting non-authenticated sites and moved targetRequestUri handling to a accommodate this change > Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages > --- > > Key: OFBIZ-12047 > URL: https://issues.apache.org/jira/browse/OFBIZ-12047 > Project: OFBiz > Issue Type: Bug > Components: framework/webapp >Affects Versions: Release Branch 18.12, Trunk >Reporter: Ingo Könemann >Assignee: Michael Brohl >Priority: Minor > Fix For: 18.12.01, Upcoming Branch > > > There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and > execute the previous request after a login occurs. This attribute is not > removed properly when navigating away from a page without logging in. > When navigating to a page that requires authentication the > "_PREVIOUS_REQUEST_" attribute is saved in the session from within the > LoginWorker to be called again when the login was successful through the > RequestHandler. Currently, the attribute is only removed when a login occurs > resulting in the previous request being stored in the session until some form > of login is successfully executed. > This behavior potentially results in navigation problems since a user is able > to navigate to a page requiring authentication without logging in. An old > request will be pulled from the session when a similar event occurs and the > user logs in. > > I propose to have the RequestHandler remove the session attribute > "_PREVIOUS_REQUEST_" after calling a request that does not require > authentication. We also have to restructure the sequence of request handling > to have the "targetRequestUri" handled after the security check and a > possible removal of the session attribute. > > One problem arises with this solution, however, which should be less of an > issue than the current state: > If the login page includes a request call that is handled after the request > showing the login page (for example an ajax call rendering a screen), the > "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To > my knowledge such a case does not exist within the OFBiz environment and > seems to be an edge case far less problematic than the above mentioned > problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[ https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12047. - Thanks Ingo, this is now implemented in trunk and backported to 18.12. > Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages > --- > > Key: OFBIZ-12047 > URL: https://issues.apache.org/jira/browse/OFBIZ-12047 > Project: OFBiz > Issue Type: Bug > Components: framework/webapp >Affects Versions: Release Branch 18.12, Trunk >Reporter: Ingo Könemann >Assignee: Michael Brohl >Priority: Minor > Fix For: 18.12.01, Upcoming Branch > > > There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and > execute the previous request after a login occurs. This attribute is not > removed properly when navigating away from a page without logging in. > When navigating to a page that requires authentication the > "_PREVIOUS_REQUEST_" attribute is saved in the session from within the > LoginWorker to be called again when the login was successful through the > RequestHandler. Currently, the attribute is only removed when a login occurs > resulting in the previous request being stored in the session until some form > of login is successfully executed. > This behavior potentially results in navigation problems since a user is able > to navigate to a page requiring authentication without logging in. An old > request will be pulled from the session when a similar event occurs and the > user logs in. > > I propose to have the RequestHandler remove the session attribute > "_PREVIOUS_REQUEST_" after calling a request that does not require > authentication. We also have to restructure the sequence of request handling > to have the "targetRequestUri" handled after the security check and a > possible removal of the session attribute. > > One problem arises with this solution, however, which should be less of an > issue than the current state: > If the login page includes a request call that is handled after the request > showing the login page (for example an ajax call rendering a screen), the > "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To > my knowledge such a case does not exist within the OFBiz environment and > seems to be an edge case far less problematic than the above mentioned > problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12148) Display last-logged-in-time popup after login
[ https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277908#comment-17277908 ] Michael Brohl commented on OFBIZ-12148: --- Hi [~jamesyong] , is it possible that you provide a PR for this? > Display last-logged-in-time popup after login > - > > Key: OFBIZ-12148 > URL: https://issues.apache.org/jira/browse/OFBIZ-12148 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12148 > > > Popup last-logged-in time from database after user has logged in. > So users can know of any unauthorised access to their accounts. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12147) Allow Unsafe Event Message
[ https://issues.apache.org/jira/browse/OFBIZ-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277909#comment-17277909 ] Michael Brohl commented on OFBIZ-12147: --- [~jamesyong] please close this Jira after your commits, thank you! > Allow Unsafe Event Message > -- > > Key: OFBIZ-12147 > URL: https://issues.apache.org/jira/browse/OFBIZ-12147 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12147 > > > Currently, we can display flash message by setting in request attribute > "__EVENT_MESSAGE__". > Propose to add another request attribute i.e. "__UNSAFE_EVENT_MESSAGE__" for > messages that can contain inline javascript. > One use case is to allow us to display last login timestamp with > browser-specific format. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] bjugl opened a new pull request #264: OFBIZ-6510 Improved: Replaces ModelInduceFromDb with widgets
bjugl opened a new pull request #264: URL: https://github.com/apache/ofbiz-framework/pull/264 Improved: Replaces ModelInduceFromDb with widgets (OFBIZ-6510) Thanks: Christian Carlow for reporting, Nicolas Malin for reviewing and suggestions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #264: OFBIZ-6510 Improved: Replaces ModelInduceFromDb with widgets
sonarcloud[bot] commented on pull request #264: URL: https://github.com/apache/ofbiz-framework/pull/264#issuecomment-772429735 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=264&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=264) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=264&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=264&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10710: -- Fix Version/s: (was: Trunk) Upcoming Branch > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] mbrohl merged pull request #264: OFBIZ-6510 Improved: Replaces ModelInduceFromDb with widgets
mbrohl merged pull request #264: URL: https://github.com/apache/ofbiz-framework/pull/264 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277928#comment-17277928 ] ASF subversion and git services commented on OFBIZ-6510: Commit 8fac07ad0aeb15af9bb28615f54bc514c7a4a2ba in ofbiz-framework's branch refs/heads/trunk from Benjamin Jugl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8fac07a ] Improved: Replaces ModelInduceFromDb with widgets (OFBIZ-6510) > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6510: - Fix Version/s: Upcoming Branch > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277932#comment-17277932 ] Michael Brohl commented on OFBIZ-6510: -- Thanks all for your inputs, review and patches. I've merged the PR now in trunk. I ask myself if we should not backport this also to 18.12? > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6510: - Labels: backport-needed (was: ) > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > Fix For: Upcoming Branch > > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6508) webtools/control/view/ModelInduceFromDb should support
[ https://issues.apache.org/jira/browse/OFBIZ-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277997#comment-17277997 ] Benjamin Jugl commented on OFBIZ-6508: -- Has been incorporated in OFBIZ-6510. Can be closed. > webtools/control/view/ModelInduceFromDb should support > - > > Key: OFBIZ-6508 > URL: https://issues.apache.org/jira/browse/OFBIZ-6508 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6508.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6509) webtools/control/view/ModelInduceFromDb should support package-name attribute setting
[ https://issues.apache.org/jira/browse/OFBIZ-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278009#comment-17278009 ] Benjamin Jugl commented on OFBIZ-6509: -- Has been incorporated in OFBIZ-6510. Can be closed. > webtools/control/view/ModelInduceFromDb should support package-name > attribute setting > -- > > Key: OFBIZ-6509 > URL: https://issues.apache.org/jira/browse/OFBIZ-6509 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > > OFBIZ-6508 added support for generating from ModelInduceFromDb > by adding groupName field for setting group-name attribute. > The field should be reused to allow setting the package-name > attribute also. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-6508) webtools/control/view/ModelInduceFromDb should support
[ https://issues.apache.org/jira/browse/OFBIZ-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-6508. Fix Version/s: Upcoming Branch Resolution: Implemented Implemented with OFBIZ-6510. > webtools/control/view/ModelInduceFromDb should support > - > > Key: OFBIZ-6508 > URL: https://issues.apache.org/jira/browse/OFBIZ-6508 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-6508.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-6509) webtools/control/view/ModelInduceFromDb should support package-name attribute setting
[ https://issues.apache.org/jira/browse/OFBIZ-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-6509. Fix Version/s: Upcoming Branch Resolution: Implemented Implemented with OFBIZ-6510. > webtools/control/view/ModelInduceFromDb should support package-name > attribute setting > -- > > Key: OFBIZ-6509 > URL: https://issues.apache.org/jira/browse/OFBIZ-6509 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > OFBIZ-6508 added support for generating from ModelInduceFromDb > by adding groupName field for setting group-name attribute. > The field should be reused to allow setting the package-name > attribute also. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278016#comment-17278016 ] Benjamin Jugl commented on OFBIZ-7473: -- With OFBIZ-6510, Induce Model XML from Database is accessible again. Can be closed. > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: 17.12.01, Trunk >Reporter: Gopal Yadav >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-5487) Improve induceFieldType() of ModelUtil.java to handle MSSQL FLOAT types
[ https://issues.apache.org/jira/browse/OFBIZ-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-5487: Assignee: Benjamin Jugl > Improve induceFieldType() of ModelUtil.java to handle MSSQL FLOAT types > --- > > Key: OFBIZ-5487 > URL: https://issues.apache.org/jira/browse/OFBIZ-5487 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Benjamin Jugl >Priority: Major > > When using the ModelInduceFromDb.jsp to import MSSQL data many of the fields > were assigned to types like "invalid-float:0:50". This is because the > induceFieldType() of ModelUtil.java does not handle "FLOAT The function > should be changed to allow FLOAT type. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7473: - Affects Version/s: Release Branch 18.12 > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 18.12, 17.12.01, Trunk >Reporter: Gopal Yadav >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-7473. Fix Version/s: Upcoming Branch 18.12.01 Assignee: Michael Brohl (was: Jacques Le Roux) Resolution: Fixed Fixed with OFBIZ-6510. > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 18.12, 17.12.01, Trunk >Reporter: Gopal Yadav >Assignee: Michael Brohl >Priority: Major > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-6510: - Affects Version/s: Release Branch 18.12 > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 18.12, Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > Fix For: Upcoming Branch > > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278019#comment-17278019 ] Michael Brohl commented on OFBIZ-6510: -- OFBIZ-7473 ist fixed with this also, so I propose to backport to 18.12. Any objections? > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > Fix For: Upcoming Branch > > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-5487) Improve induceFieldType() of ModelUtil.java to handle MSSQL FLOAT types
[ https://issues.apache.org/jira/browse/OFBIZ-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-5487: Assignee: (was: Benjamin Jugl) > Improve induceFieldType() of ModelUtil.java to handle MSSQL FLOAT types > --- > > Key: OFBIZ-5487 > URL: https://issues.apache.org/jira/browse/OFBIZ-5487 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Major > > When using the ModelInduceFromDb.jsp to import MSSQL data many of the fields > were assigned to types like "invalid-float:0:50". This is because the > induceFieldType() of ModelUtil.java does not handle "FLOAT The function > should be changed to allow FLOAT type. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12165) Upgrade Tomcat from 9.0.41 to 9.0.43
[ https://issues.apache.org/jira/browse/OFBIZ-12165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12165: -- Fix Version/s: (was: 18.12.01) (was: Release Branch 17.12) (was: Upcoming Branch) > Upgrade Tomcat from 9.0.41 to 9.0.43 > > > Key: OFBIZ-12165 > URL: https://issues.apache.org/jira/browse/OFBIZ-12165 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > CVE-2020-11996 Apache Tomcat HTTP/2 Denial of Service > Severity: Important > Vendor: The Apache Software Foundation > Versions Affected: > Apache Tomcat 10.0.0-M1 to 10.0.0-M5 > Apache Tomcat 9.0.0.M1 to 9.0.35 > Apache Tomcat 8.5.0 to 8.5.55 > Description: > A specially crafted sequence of HTTP/2 requests could trigger high CPU > usage for several seconds. If a sufficient number of such requests were > made on concurrent HTTP/2 connections, the server could become unresponsive. > Mitigation: > - Upgrade to Apache Tomcat 10.0.0-M6 or later > - Upgrade to Apache Tomcat 9.0.36 or later > - Upgrade to Apache Tomcat 8.5.56 or later > Credit: > This issue was reported publicly via the Apache Tomcat Users mailing > list without reference to the potential for DoS. The DoS risks were > identified by the Apache Tomcat Security Team. > References: > [1] http://tomcat.apache.org/security-10.html > [2] http://tomcat.apache.org/security-9.html > [3] http://tomcat.apache.org/security-8.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12165) Upgrade Tomcat from 9.0.41 to 9.0.43
Michael Brohl created OFBIZ-12165: - Summary: Upgrade Tomcat from 9.0.41 to 9.0.43 Key: OFBIZ-12165 URL: https://issues.apache.org/jira/browse/OFBIZ-12165 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: 18.12.01, 17.12.03, Trunk Reporter: Michael Brohl Assignee: Michael Brohl Fix For: 18.12.01, Release Branch 17.12, Upcoming Branch CVE-2020-11996 Apache Tomcat HTTP/2 Denial of Service Severity: Important Vendor: The Apache Software Foundation Versions Affected: Apache Tomcat 10.0.0-M1 to 10.0.0-M5 Apache Tomcat 9.0.0.M1 to 9.0.35 Apache Tomcat 8.5.0 to 8.5.55 Description: A specially crafted sequence of HTTP/2 requests could trigger high CPU usage for several seconds. If a sufficient number of such requests were made on concurrent HTTP/2 connections, the server could become unresponsive. Mitigation: - Upgrade to Apache Tomcat 10.0.0-M6 or later - Upgrade to Apache Tomcat 9.0.36 or later - Upgrade to Apache Tomcat 8.5.56 or later Credit: This issue was reported publicly via the Apache Tomcat Users mailing list without reference to the potential for DoS. The DoS risks were identified by the Apache Tomcat Security Team. References: [1] http://tomcat.apache.org/security-10.html [2] http://tomcat.apache.org/security-9.html [3] http://tomcat.apache.org/security-8.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12165) Upgrade Tomcat from 9.0.41 to 9.0.43
[ https://issues.apache.org/jira/browse/OFBIZ-12165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12165: -- Affects Version/s: (was: 17.12.03) (was: 18.12.01) > Upgrade Tomcat from 9.0.41 to 9.0.43 > > > Key: OFBIZ-12165 > URL: https://issues.apache.org/jira/browse/OFBIZ-12165 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > Fix For: 18.12.01, Release Branch 17.12, Upcoming Branch > > > CVE-2020-11996 Apache Tomcat HTTP/2 Denial of Service > Severity: Important > Vendor: The Apache Software Foundation > Versions Affected: > Apache Tomcat 10.0.0-M1 to 10.0.0-M5 > Apache Tomcat 9.0.0.M1 to 9.0.35 > Apache Tomcat 8.5.0 to 8.5.55 > Description: > A specially crafted sequence of HTTP/2 requests could trigger high CPU > usage for several seconds. If a sufficient number of such requests were > made on concurrent HTTP/2 connections, the server could become unresponsive. > Mitigation: > - Upgrade to Apache Tomcat 10.0.0-M6 or later > - Upgrade to Apache Tomcat 9.0.36 or later > - Upgrade to Apache Tomcat 8.5.56 or later > Credit: > This issue was reported publicly via the Apache Tomcat Users mailing > list without reference to the potential for DoS. The DoS risks were > identified by the Apache Tomcat Security Team. > References: > [1] http://tomcat.apache.org/security-10.html > [2] http://tomcat.apache.org/security-9.html > [3] http://tomcat.apache.org/security-8.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12165) Upgrade Tomcat from 9.0.41 to 9.0.43
[ https://issues.apache.org/jira/browse/OFBIZ-12165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12165: -- Description: The Apache Tomcat team announces the immediate availability of Apache Tomcat 9.0.43. Apache Tomcat 9 is an open source software implementation of the Java Servlet, JavaServer Pages, Java Unified Expression Language, Java WebSocket and JASPIC technologies. Apache Tomcat 9.0.43 is a bugfix and feature release. The notable changes compared to 9.0.41 include: - Add support for using Unix domain sockets for NIO when running on Java 16 or later. - Add a new StringInterpreter interface that allows applications to provide customised string attribute value to type conversion within JSPs. This allows applications to provide a conversion implementation that is optimised for the application. - Add peerAddress to coyote request, which contains the IP address of the direct connection peer. If a reverse proxy sits in front of Tomcat and the RemoteIp(Valve|Filter) is used, the peerAddress is likely to differ from the remoteAddress. The remoteAddress is likely to contain the address of the client in front of the reverse proxy, not the address of the proxy itself. Please refer to the change log for the complete list of changes: [http://tomcat.apache.org/tomcat-9.0-doc/changelog.html] was: CVE-2020-11996 Apache Tomcat HTTP/2 Denial of Service Severity: Important Vendor: The Apache Software Foundation Versions Affected: Apache Tomcat 10.0.0-M1 to 10.0.0-M5 Apache Tomcat 9.0.0.M1 to 9.0.35 Apache Tomcat 8.5.0 to 8.5.55 Description: A specially crafted sequence of HTTP/2 requests could trigger high CPU usage for several seconds. If a sufficient number of such requests were made on concurrent HTTP/2 connections, the server could become unresponsive. Mitigation: - Upgrade to Apache Tomcat 10.0.0-M6 or later - Upgrade to Apache Tomcat 9.0.36 or later - Upgrade to Apache Tomcat 8.5.56 or later Credit: This issue was reported publicly via the Apache Tomcat Users mailing list without reference to the potential for DoS. The DoS risks were identified by the Apache Tomcat Security Team. References: [1] http://tomcat.apache.org/security-10.html [2] http://tomcat.apache.org/security-9.html [3] http://tomcat.apache.org/security-8.html > Upgrade Tomcat from 9.0.41 to 9.0.43 > > > Key: OFBIZ-12165 > URL: https://issues.apache.org/jira/browse/OFBIZ-12165 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > The Apache Tomcat team announces the immediate availability of Apache > Tomcat 9.0.43. > Apache Tomcat 9 is an open source software implementation of the Java > Servlet, JavaServer Pages, Java Unified Expression Language, Java > WebSocket and JASPIC technologies. > Apache Tomcat 9.0.43 is a bugfix and feature release. The notable > changes compared to 9.0.41 include: > - Add support for using Unix domain sockets for NIO when running on Java > 16 or later. > - Add a new StringInterpreter interface that allows applications to > provide customised string attribute value to type conversion within > JSPs. This allows applications to provide a conversion implementation > that is optimised for the application. > - Add peerAddress to coyote request, which contains the IP address of > the direct connection peer. If a reverse proxy sits in front of Tomcat > and the RemoteIp(Valve|Filter) is used, the peerAddress is likely to > differ from the remoteAddress. The remoteAddress is likely to contain > the address of the client in front of the reverse proxy, not the > address of the proxy itself. > Please refer to the change log for the complete list of changes: > [http://tomcat.apache.org/tomcat-9.0-doc/changelog.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10757: -- Affects Version/s: Trunk > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278116#comment-17278116 ] Michael Brohl commented on OFBIZ-10757: --- Hi all, there was the idea to make the official switch to jdk11 within the next new branch which possibly will be 21.x . jdk11 will be available at least until October 2024. jdk17 (LTS) will be available from September 2021 and be available until 2025 (four years). I think we should decide if we want jdk11 to be the next supported JDK for OFBiz r21 or if we want to go with jdk17. I tend to go with jdk11 which is mature and available and the community already made OFBiz ready for it. What do you think? > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278116#comment-17278116 ] Michael Brohl edited comment on OFBIZ-10757 at 2/3/21, 4:20 PM: Hi all, there was the idea to make the official switch to jdk11 within the next new branch which possibly will be 21.x . jdk11 will be available at least until October 2024. jdk17 (LTS) will be available from September 2021 and be available until 2025 (four years). I think we should decide if we want jdk11 to be the next supported JDK for OFBiz r21 or if we want to go with jdk17. I tend to go with jdk11 which is mature and available and the community already made OFBiz ready for it. For jdk17 we'll have to wait until September and gain one more year of support. What do you think? was (Author: mbrohl): Hi all, there was the idea to make the official switch to jdk11 within the next new branch which possibly will be 21.x . jdk11 will be available at least until October 2024. jdk17 (LTS) will be available from September 2021 and be available until 2025 (four years). I think we should decide if we want jdk11 to be the next supported JDK for OFBiz r21 or if we want to go with jdk17. I tend to go with jdk11 which is mature and available and the community already made OFBiz ready for it. What do you think? > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278116#comment-17278116 ] Michael Brohl edited comment on OFBIZ-10757 at 2/3/21, 4:21 PM: Hi all, there was the idea to make the official switch to jdk11 within the next new branch which possibly will be 21.x . jdk11 will be available at least until October 2024. jdk17 (LTS) will be available from September 2021 and be available until 2025 (four years). I think we should decide if we want jdk11 to be the next supported JDK for OFBiz r21 or if we want to go with jdk17. I tend to go with jdk11 which is mature and available and the community already made OFBiz ready for it. For jdk17 we'll have to wait until September and gain one more year of support. What do you think? https://adoptopenjdk.net/support.html was (Author: mbrohl): Hi all, there was the idea to make the official switch to jdk11 within the next new branch which possibly will be 21.x . jdk11 will be available at least until October 2024. jdk17 (LTS) will be available from September 2021 and be available until 2025 (four years). I think we should decide if we want jdk11 to be the next supported JDK for OFBiz r21 or if we want to go with jdk17. I tend to go with jdk11 which is mature and available and the community already made OFBiz ready for it. For jdk17 we'll have to wait until September and gain one more year of support. What do you think? > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278138#comment-17278138 ] Jacques Le Roux commented on OFBIZ-10757: - +1 for 11 > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278148#comment-17278148 ] Jacques Le Roux commented on OFBIZ-6510: +1 to backport if possible... > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 18.12, Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > Fix For: Upcoming Branch > > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12165) Upgrade Tomcat from 9.0.41 to 9.0.43
[ https://issues.apache.org/jira/browse/OFBIZ-12165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278192#comment-17278192 ] ASF subversion and git services commented on OFBIZ-12165: - Commit 91594dd259298a280639074bc1107c62ecc9c8cb in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=91594dd ] Implemented: Upgrade Tomcat from 9.0.41 to 9.0.43 (OFBIZ-12165) > Upgrade Tomcat from 9.0.41 to 9.0.43 > > > Key: OFBIZ-12165 > URL: https://issues.apache.org/jira/browse/OFBIZ-12165 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > The Apache Tomcat team announces the immediate availability of Apache > Tomcat 9.0.43. > Apache Tomcat 9 is an open source software implementation of the Java > Servlet, JavaServer Pages, Java Unified Expression Language, Java > WebSocket and JASPIC technologies. > Apache Tomcat 9.0.43 is a bugfix and feature release. The notable > changes compared to 9.0.41 include: > - Add support for using Unix domain sockets for NIO when running on Java > 16 or later. > - Add a new StringInterpreter interface that allows applications to > provide customised string attribute value to type conversion within > JSPs. This allows applications to provide a conversion implementation > that is optimised for the application. > - Add peerAddress to coyote request, which contains the IP address of > the direct connection peer. If a reverse proxy sits in front of Tomcat > and the RemoteIp(Valve|Filter) is used, the peerAddress is likely to > differ from the remoteAddress. The remoteAddress is likely to contain > the address of the client in front of the reverse proxy, not the > address of the proxy itself. > Please refer to the change log for the complete list of changes: > [http://tomcat.apache.org/tomcat-9.0-doc/changelog.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12165) Upgrade Tomcat from 9.0.41 to 9.0.43
[ https://issues.apache.org/jira/browse/OFBIZ-12165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12165: -- Priority: Minor (was: Major) > Upgrade Tomcat from 9.0.41 to 9.0.43 > > > Key: OFBIZ-12165 > URL: https://issues.apache.org/jira/browse/OFBIZ-12165 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > The Apache Tomcat team announces the immediate availability of Apache > Tomcat 9.0.43. > Apache Tomcat 9 is an open source software implementation of the Java > Servlet, JavaServer Pages, Java Unified Expression Language, Java > WebSocket and JASPIC technologies. > Apache Tomcat 9.0.43 is a bugfix and feature release. The notable > changes compared to 9.0.41 include: > - Add support for using Unix domain sockets for NIO when running on Java > 16 or later. > - Add a new StringInterpreter interface that allows applications to > provide customised string attribute value to type conversion within > JSPs. This allows applications to provide a conversion implementation > that is optimised for the application. > - Add peerAddress to coyote request, which contains the IP address of > the direct connection peer. If a reverse proxy sits in front of Tomcat > and the RemoteIp(Valve|Filter) is used, the peerAddress is likely to > differ from the remoteAddress. The remoteAddress is likely to contain > the address of the client in front of the reverse proxy, not the > address of the proxy itself. > Please refer to the change log for the complete list of changes: > [http://tomcat.apache.org/tomcat-9.0-doc/changelog.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12165) Upgrade Tomcat from 9.0.41 to 9.0.43
[ https://issues.apache.org/jira/browse/OFBIZ-12165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12165: -- Issue Type: Improvement (was: Bug) > Upgrade Tomcat from 9.0.41 to 9.0.43 > > > Key: OFBIZ-12165 > URL: https://issues.apache.org/jira/browse/OFBIZ-12165 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > The Apache Tomcat team announces the immediate availability of Apache > Tomcat 9.0.43. > Apache Tomcat 9 is an open source software implementation of the Java > Servlet, JavaServer Pages, Java Unified Expression Language, Java > WebSocket and JASPIC technologies. > Apache Tomcat 9.0.43 is a bugfix and feature release. The notable > changes compared to 9.0.41 include: > - Add support for using Unix domain sockets for NIO when running on Java > 16 or later. > - Add a new StringInterpreter interface that allows applications to > provide customised string attribute value to type conversion within > JSPs. This allows applications to provide a conversion implementation > that is optimised for the application. > - Add peerAddress to coyote request, which contains the IP address of > the direct connection peer. If a reverse proxy sits in front of Tomcat > and the RemoteIp(Valve|Filter) is used, the peerAddress is likely to > differ from the remoteAddress. The remoteAddress is likely to contain > the address of the client in front of the reverse proxy, not the > address of the proxy itself. > Please refer to the change log for the complete list of changes: > [http://tomcat.apache.org/tomcat-9.0-doc/changelog.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12165) Upgrade Tomcat from 9.0.41 to 9.0.43
[ https://issues.apache.org/jira/browse/OFBIZ-12165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12165. - Fix Version/s: Upcoming Branch Resolution: Implemented > Upgrade Tomcat from 9.0.41 to 9.0.43 > > > Key: OFBIZ-12165 > URL: https://issues.apache.org/jira/browse/OFBIZ-12165 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > The Apache Tomcat team announces the immediate availability of Apache > Tomcat 9.0.43. > Apache Tomcat 9 is an open source software implementation of the Java > Servlet, JavaServer Pages, Java Unified Expression Language, Java > WebSocket and JASPIC technologies. > Apache Tomcat 9.0.43 is a bugfix and feature release. The notable > changes compared to 9.0.41 include: > - Add support for using Unix domain sockets for NIO when running on Java > 16 or later. > - Add a new StringInterpreter interface that allows applications to > provide customised string attribute value to type conversion within > JSPs. This allows applications to provide a conversion implementation > that is optimised for the application. > - Add peerAddress to coyote request, which contains the IP address of > the direct connection peer. If a reverse proxy sits in front of Tomcat > and the RemoteIp(Valve|Filter) is used, the peerAddress is likely to > differ from the remoteAddress. The remoteAddress is likely to contain > the address of the client in front of the reverse proxy, not the > address of the proxy itself. > Please refer to the change log for the complete list of changes: > [http://tomcat.apache.org/tomcat-9.0-doc/changelog.html] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
