[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #143: Improved: Have a status on agreement records (OFBIZ-10192)

2021-03-15 Thread GitBox


JacquesLeRoux commented on pull request #143:
URL: https://github.com/apache/ofbiz-framework/pull/143#issuecomment-79357


   Done by hand, DATAMODEL_CHANGES.MD no longer existed



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] JacquesLeRoux closed pull request #143: Improved: Have a status on agreement records (OFBIZ-10192)

2021-03-15 Thread GitBox


JacquesLeRoux closed pull request #143:
URL: https://github.com/apache/ofbiz-framework/pull/143


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders, code cleanup

2021-03-15 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-12197:
--
Summary: Remove "ofbiz" prefix from files and folders, code cleanup  (was: 
Remove "ofbiz" prefix from files and folders)

> Remove "ofbiz" prefix from files and folders, code cleanup
> --
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders

2021-03-15 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302055#comment-17302055
 ] 

Michael Brohl edited comment on OFBIZ-12197 at 3/15/21, 10:09 PM:
--

[~gvasmatkar] Another question: is there any backend application supposed to 
work or planned to work?

As I understand, the rest-jersey application is the rest endpoint and, using 
the Jersey REST Filter, is not able to serve a common OFBiz backend 
application, right?

If yes, it should be safe to remove any screens, widgets, UILabels, permissions 
etc., is this correct?

This would make the renaming, readability and further development easier I 
think.


was (Author: mbrohl):
[~gvasmatkar] Another question: is there any backend application supposed to 
work or planned to work?

As I understand, the rest-jersey application is the rest endpoint and, using 
the Jersey REST Filter, is not able to serve a common OFBiz backend 
application, right?

If yes, it should be safe to remove any screens, widgets, UILabels, permissions 
etc., is this correct?

> Remove "ofbiz" prefix from files and folders
> 
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders

2021-03-15 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302055#comment-17302055
 ] 

Michael Brohl edited comment on OFBIZ-12197 at 3/15/21, 10:08 PM:
--

[~gvasmatkar] Another question: is there any backend application supposed to 
work or planned to work?

As I understand, the rest-jersey application is the rest endpoint and, using 
the Jersey REST Filter, is not able to serve a common OFBiz backend 
application, right?

If yes, it should be safe to remove any screens, widgets, UILabels, permissions 
etc., is this correct?


was (Author: mbrohl):
[~gvasmatkar] Another question: is there any backend application supposed to 
work or planned to work?

As I understand, the rest-jersey application is the rest endpoint and, using 
the Jersey REST Filter, is not able to serve a common OFBiz backend 
application, right?

If yes, it should be safe to remove any screens, widgets, UILabels etc., is 
this correct?

> Remove "ofbiz" prefix from files and folders
> 
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders

2021-03-15 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302055#comment-17302055
 ] 

Michael Brohl commented on OFBIZ-12197:
---

[~gvasmatkar] Another question: is there any backend application supposed to 
work or planned to work?

As I understand, the rest-jersey application is the rest endpoint and, using 
the Jersey REST Filter, is not able to serve a common OFBiz backend 
application, right?

If yes, it should be safe to remove any screens, widgets, UILabels etc., is 
this correct?

> Remove "ofbiz" prefix from files and folders
> 
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders

2021-03-15 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302035#comment-17302035
 ] 

Michael Brohl commented on OFBIZ-12197:
---

[~gvasmatkar] what does the "Tbc" in "Apache OFBiz - Tbc-api-swagger Component" 
mean?

> Remove "ofbiz" prefix from files and folders
> 
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders

2021-03-15 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-12197:
--
Summary: Remove "ofbiz" prefix from files and folders  (was: Remove "ofbiz" 
suffix from files and folders)

> Remove "ofbiz" prefix from files and folders
> 
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2021-03-15 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302003#comment-17302003
 ] 

Michael Brohl commented on OFBIZ-11328:
---

Ok, any objections?

> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: OFBIZ-11328 Rest Jersey name.patch, Rest webapp 
> issue.patch, image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10902) Have a status on agreement records

2021-03-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10902.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Have a status on agreement records
> --
>
> Key: OFBIZ-10902
> URL: https://issues.apache.org/jira/browse/OFBIZ-10902
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> h2. Pre-amble
> Currently, unlike many other entities, the Agreement entity does not have the 
> statusId field defined. Agreements, like the other entities, should have a 
> status (values that help determine the phase of the lifespan beyond the 
> start- and end date of the agreement), such as:
>  * Created
>  * In Progress
>  * Approved
>  * etc.
> h2. Flows
>  # Happy flows:
>  ## Happy flow a) created ->b) submitted (for review) -> c) reviewed -> d) 
> approved -> e) in effect -> f) concluded (ended)
>  ## Same, with more flow: a) created ->b) submitted (for review) -> c) 
> reviewed -> d) adjusted -> e) reviewed -> f) approved -> g) in effect -> h) 
> concluded (ended)
>  # Unhappy flows:
>  ## Unhappy flow: a) created ->b) submitted (for review) -> c) reviewed -> d) 
> cancelled
>  ## Same, whit more flow: a) created ->b) submitted (for review) -> c) 
> reviewed -> d) adjusted -> e) reviewed -> f) cancelled
>  # Prematurely ended flows:
>  ## Nipped in the bud flow a) created  -> b) cancelled
>  # flows from approval (in effect or in execution) till the end-of-times
>  ## a) approved -> b) in effect -> c) concluded (ended)
>  ## a) approved -> b) in effect -> c) terminated (prematurely ended)
> h2. Party Roles
> Following Party Roles are involved:
>  # Agreement Creator - the party (person) that creates, edit, updates and 
> submits the agreement for review
>  # Agreement Reviewer - the party (person) that reviews the agreement on its 
> merits and impact for the company/organisation
>  # Agreement Approver - the party (person) that, based on law, regulations 
> and/or business policies approves (or rejects) the agreement
>  # Agreement Manager - the party (person) that manages the execution of terms 
> of the agreement after the approval till the end-of-times
>  # Agreement Owner - the Party (party group with roleTypeId 
> INTERNAL_ORGANIZATIO, and  and registered in PartyAcctgPreference) that is 
> legally bound by the agreement
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10902) Have a status on agreement records

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301859#comment-17301859
 ] 

ASF subversion and git services commented on OFBIZ-10902:
-

Commit 1b84668aafe2b3ffef40cb3157ec0cda310cc661 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1b84668 ]

Improved: Have a status on agreement records (OFBIZ-10902)

Pre-amble

Currently, unlike many other entities, the Agreement entity does not have the
statusId field defined. Agreements, like the other entities, should have a
status (values that help determine the phase of the lifespan beyond
the start- and end date of the agreement), such as:

Created
In Progress
Approved
etc.

Flows
Happy flows:
Happy flow a) created ->b) submitted (for review) -> c) reviewed ->
   d) approved -> e) in effect -> f) concluded (ended)
Same, with more flow: a) created ->b) submitted (for review) ->
   c) reviewed -> d) adjusted -> e) reviewed -> f) approved ->
   g) in effect -> h) concluded (ended)
Unhappy flows:
Unhappy flow: a) created ->b) submitted (for review) -> c) reviewed ->
  d) cancelled
Same, with more flow: a) created ->b) submitted (for review) ->
  c) reviewed -> d) adjusted -> e) reviewed -> f) cancelled
Prematurely ended flows:
Nipped in the bud flow a) created  -> b) cancelled
flows from approval (in effect or in execution) till the end-of-times
a) approved -> b) in effect -> c) concluded (ended)
a) approved -> b) in effect -> c) terminated (prematurely ended)

Party Roles

Following Party Roles are involved:

Agreement Creator - the party (person) that creates, edit, updates and
submits the agreement for review
Agreement Reviewer - the party (person) that reviews the agreement on its
 merits and impact for the company/organisation
Agreement Approver - the party (person) that, based on law, regulations
 and/or business policies approves (or rejects) the
 agreement
Agreement Manager - the party (person) that manages the execution of terms
of the agreement after the approval till the 
end-of-times
Agreement Owner - the Party (party group with roleTypeId 
INTERNAL_ORGANIZATIO,
   and  and registered in PartyAcctgPreference) that is
   legally bound by the agreement

jleroux: this lacks demo data but can still be useful

Thanks: Pierre Smits


> Have a status on agreement records
> --
>
> Key: OFBIZ-10902
> URL: https://issues.apache.org/jira/browse/OFBIZ-10902
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> h2. Pre-amble
> Currently, unlike many other entities, the Agreement entity does not have the 
> statusId field defined. Agreements, like the other entities, should have a 
> status (values that help determine the phase of the lifespan beyond the 
> start- and end date of the agreement), such as:
>  * Created
>  * In Progress
>  * Approved
>  * etc.
> h2. Flows
>  # Happy flows:
>  ## Happy flow a) created ->b) submitted (for review) -> c) reviewed -> d) 
> approved -> e) in effect -> f) concluded (ended)
>  ## Same, with more flow: a) created ->b) submitted (for review) -> c) 
> reviewed -> d) adjusted -> e) reviewed -> f) approved -> g) in effect -> h) 
> concluded (ended)
>  # Unhappy flows:
>  ## Unhappy flow: a) created ->b) submitted (for review) -> c) reviewed -> d) 
> cancelled
>  ## Same, whit more flow: a) created ->b) submitted (for review) -> c) 
> reviewed -> d) adjusted -> e) reviewed -> f) cancelled
>  # Prematurely ended flows:
>  ## Nipped in the bud flow a) created  -> b) cancelled
>  # flows from approval (in effect or in execution) till the end-of-times
>  ## a) approved -> b) in effect -> c) concluded (ended)
>  ## a) approved -> b) in effect -> c) terminated (prematurely ended)
> h2. Party Roles
> Following Party Roles are involved:
>  # Agreement Creator - the party (person) that creates, edit, updates and 
> submits the agreement for review
>  # Agreement Reviewer - the party (person) that reviews the agreement on its 
> merits and impact for the company/organisation
>  # Agreement Approver - the party (person) that, based on law, regulations 
> and/or business policies approves (or rejects) the agreement
>  # Agreement Manager - the party (person) that manages the execution of terms 
> of the agre

[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2021-03-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301836#comment-17301836
 ] 

Jacques Le Roux commented on OFBIZ-11328:
-

I'd rather ask if someone is against ;)

> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: OFBIZ-11328 Rest Jersey name.patch, Rest webapp 
> issue.patch, image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2021-03-15 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301823#comment-17301823
 ] 

Michael Brohl commented on OFBIZ-11328:
---

The rename of the base plugin folder has a drawback: the history of the files 
will be lost.

Is everyone ok with that?

> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: OFBIZ-11328 Rest Jersey name.patch, Rest webapp 
> issue.patch, image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301740#comment-17301740
 ] 

ASF subversion and git services commented on OFBIZ-11574:
-

Commit 73d0defd031d98d36f3f0b1d56708f0a9b2fdb28 in ofbiz-tools's branch 
refs/heads/master from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=73d0def ]

Improved: Removes deprecated DATAMODEL_CHANGES.md.html

Deprecated by

Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md
which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier 


> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301739#comment-17301739
 ] 

ASF subversion and git services commented on OFBIZ-11574:
-

Commit 73d0defd031d98d36f3f0b1d56708f0a9b2fdb28 in ofbiz-tools's branch 
refs/heads/master from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=73d0def ]

Improved: Removes deprecated DATAMODEL_CHANGES.md.html

Deprecated by

Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md
which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier 


> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10613) Enhance entity "GlXbrlClass"

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301741#comment-17301741
 ] 

ASF subversion and git services commented on OFBIZ-10613:
-

Commit 73d0defd031d98d36f3f0b1d56708f0a9b2fdb28 in ofbiz-tools's branch 
refs/heads/master from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=73d0def ]

Improved: Removes deprecated DATAMODEL_CHANGES.md.html

Deprecated by

Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md
which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier 


> Enhance entity "GlXbrlClass"
> 
>
> Key: OFBIZ-10613
> URL: https://issues.apache.org/jira/browse/OFBIZ-10613
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: reporting
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10613-accounting-entitymodel.xml.patch
>
>
> See [https://en.wikipedia.org/wiki/XBRL]
> Currently the entity does not allow to capture the hierarchy between records. 
> In order to enable this, and work with nested accounting reporting in 
> downstream solutions, a parent field needs to be added.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301738#comment-17301738
 ] 

ASF subversion and git services commented on OFBIZ-11574:
-

Commit 73d0defd031d98d36f3f0b1d56708f0a9b2fdb28 in ofbiz-tools's branch 
refs/heads/master from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=73d0def ]

Improved: Removes deprecated DATAMODEL_CHANGES.md.html

Deprecated by

Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md
which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier 


> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301737#comment-17301737
 ] 

ASF subversion and git services commented on OFBIZ-11574:
-

Commit 73d0defd031d98d36f3f0b1d56708f0a9b2fdb28 in ofbiz-tools's branch 
refs/heads/master from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=73d0def ]

Improved: Removes deprecated DATAMODEL_CHANGES.md.html

Deprecated by

Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md
which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier 


> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12197) Remove "ofbiz" suffix from files and folders

2021-03-15 Thread Michael Brohl (Jira)
Michael Brohl created OFBIZ-12197:
-

 Summary: Remove "ofbiz" suffix from files and folders
 Key: OFBIZ-12197
 URL: https://issues.apache.org/jira/browse/OFBIZ-12197
 Project: OFBiz
  Issue Type: Sub-task
  Components: rest-api
Affects Versions: Trunk
Reporter: Michael Brohl
Assignee: Michael Brohl


See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12033) Separate login service for API calls

2021-03-15 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301732#comment-17301732
 ] 

Michael Brohl commented on OFBIZ-12033:
---

Hi [~gvasmatkar] ,

I already found this functionality (basic auth and bearer token auth) in the 
demo plugin functionality.

Is this already solved, what's the state?

> Separate login service for API calls
> 
>
> Key: OFBIZ-12033
> URL: https://issues.apache.org/jira/browse/OFBIZ-12033
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
>
> We're using {color:#2a00ff}userLogin {color}{color:#00}service to 
> authenticate users before generating auth tokens for REST API and GraphQL 
> calls. However, we figured that a session is also getting created and 
> returned in response which is defeating the purpose of having an API in 
> place. Even though that session is not getting used anywhere when subsequent 
> calls are made using the token, we still think it is an extra session lying 
> around in tomcat's session cache. {color}
> {color:#00} {color}
> {color:#00}Proposal is to implement a new basic userLogin service 
> (basicAuthUserLogin) that would just do username/password matching and be 
> done with it without ever calling request.getSession(). This will ensure that 
> APIs are stateless and no session is generated.{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.

2021-03-15 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301730#comment-17301730
 ] 

Michael Brohl commented on OFBIZ-11995:
---

Hi [~gvasmatkar] , isn't this already solved and can be closed?

> Define schema for RESTFul resources mapping.
> 
>
> Key: OFBIZ-11995
> URL: https://issues.apache.org/jira/browse/OFBIZ-11995
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Major
> Attachments: rest-api.xsd
>
>
> As a developer, I need to have the ability to define REST resources using XML 
> DSL allowing to plug in OFBiz services to the resources that can serve the 
> HTTP requests.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12062) Refactor few Groovy files, remove redundancy

2021-03-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301728#comment-17301728
 ] 

Jacques Le Roux commented on OFBIZ-12062:
-

Hi Rohit, any chances?

> Refactor few Groovy files, remove redundancy
> 
>
> Key: OFBIZ-12062
> URL: https://issues.apache.org/jira/browse/OFBIZ-12062
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Rohit Hukkeri
>Priority: Minor
>
> There is some redundancy in EditCategory.groovy, 
> EditProductConfigItemContent.groovy, ImageUpload.groovy and 
> EditProductContent.groovy, mostly at the bottom of files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.

2021-03-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301657#comment-17301657
 ] 

Jacques Le Roux commented on OFBIZ-10150:
-

Hi Jesse,

You proposed:
bq.  There are other fields that have this issue too if you are interested?
Yes I'm, and as suggested Michael I'll open a new Jira for that, would you help?

> supplierProductId Should Have Consistent Types Across Entities.
> ---
>
> Key: OFBIZ-10150
> URL: https://issues.apache.org/jira/browse/OFBIZ-10150
> Project: OFBiz
>  Issue Type: Bug
>  Components: order, product
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
> Environment: all
>Reporter: jesse thomas
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10150.patch
>
>
> During some data migration I hit an issue where my data for supplierProductId 
> was too long. So I looked up the fields and noticed that the order item 
> entity had a different type for the field than the supplier product entity. I 
> think it would be a good idea to pick one so the two fields can be treated 
> consistently. I would vote for id-long, but I think either way it would be 
> good to have them be the same type. There are other fields that have this 
> issue too if you are interested?
>   
> Thanks!
> applications/datamodel/entitydef/order-entitymodel.xml:  
>  
> applications/datamodel/entitydef/product-entitymodel.xml:  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2021-03-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301656#comment-17301656
 ] 

Jacques Le Roux commented on OFBIZ-11328:
-

+2 for rest-api, who knows what will comes later like "new-api" ;)

> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: OFBIZ-11328 Rest Jersey name.patch, Rest webapp 
> issue.patch, image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2021-03-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301641#comment-17301641
 ] 

Jacques Le Roux edited comment on OFBIZ-11328 at 3/15/21, 1:49 PM:
---

Hi [~mbrohl] I agree with your proposition. Using "ofbiz" is redundant here. 

I wanted to get rid of "jersey" part because that reveals what this plug in is 
based on which is not necessarily a bad thing but I did not like it when I had 
created it. I somehow went too ahead with implementation and forgot about 
changing the name of the plug in.

 

Please also consider following names if you feel good about it -

Simple API ? "api" or "rest-api" or even "rest".

Thanks,

Girish


was (Author: gvasmatkar):
Hi [~mbrohl] I agree with your proposition. Using "ofbiz" is redundant here. 

I wanted to get rid of "jersey" part because that reveals what this plug in is 
based on which is not necessarily a bad thing but I did not like it when I had 
created it. I somehow went too ahead with implementation and forgot about 
changing the name of the plug in.

 

Please also consider following names if you feel good about it -

Simple API ? "api" or "rest-api" or even "rest".

 

Thanks,

Girish

 

 

 

 

> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: OFBIZ-11328 Rest Jersey name.patch, Rest webapp 
> issue.patch, image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2021-03-15 Thread Girish Vasmatkar (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301641#comment-17301641
 ] 

Girish Vasmatkar commented on OFBIZ-11328:
--

Hi [~mbrohl] I agree with your proposition. Using "ofbiz" is redundant here. 

I wanted to get rid of "jersey" part because that reveals what this plug in is 
based on which is not necessarily a bad thing but I did not like it when I had 
created it. I somehow went too ahead with implementation and forgot about 
changing the name of the plug in.

 

Please also consider following names if you feel good about it -

Simple API ? "api" or "rest-api" or even "rest".

 

Thanks,

Girish

 

 

 

 

> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: OFBIZ-11328 Rest Jersey name.patch, Rest webapp 
> issue.patch, image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12163) Page selection is not working correctly in the lookup-dialog

2021-03-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12163:

Fix Version/s: Upcoming Branch
Affects Version/s: (was: Release Branch 17.12)
   Trunk

> Page selection is not working correctly in the lookup-dialog
> 
>
> Key: OFBIZ-12163
> URL: https://issues.apache.org/jira/browse/OFBIZ-12163
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webapp
>Affects Versions: Trunk
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> If after a search in the lookup dialog a page number is entered to display 
> the found hits, the result is displayed as an independent page without theme 
> and not in the lookup dialog.
> To reproduce this:
>  * go to catalog
>  * Lookup product (lookup-dialog is open)
>  * search for products categories
>  * enter 2 for pagenumber and press enter
>  * the lookup-dialog disappears and your results are shown on the screen 
> without a theme



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12163) Page selection is not working correctly in the lookup-dialog

2021-03-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12163.
---
Resolution: Fixed

> Page selection is not working correctly in the lookup-dialog
> 
>
> Key: OFBIZ-12163
> URL: https://issues.apache.org/jira/browse/OFBIZ-12163
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webapp
>Affects Versions: Trunk
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> If after a search in the lookup dialog a page number is entered to display 
> the found hits, the result is displayed as an independent page without theme 
> and not in the lookup dialog.
> To reproduce this:
>  * go to catalog
>  * Lookup product (lookup-dialog is open)
>  * search for products categories
>  * enter 2 for pagenumber and press enter
>  * the lookup-dialog disappears and your results are shown on the screen 
> without a theme



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12163) Page selection is not working correctly in the lookup-dialog

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301623#comment-17301623
 ] 

ASF subversion and git services commented on OFBIZ-12163:
-

Commit d6eaef2f9bf4935e786defc934f7944b8c8bbe56 in ofbiz-framework's branch 
refs/heads/trunk from wpaetzold
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d6eaef2 ]

Fixed: Page selection is not working correctly in the lookup-dialog (#287)

(OFBIZ-12163)

> Page selection is not working correctly in the lookup-dialog
> 
>
> Key: OFBIZ-12163
> URL: https://issues.apache.org/jira/browse/OFBIZ-12163
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webapp
>Affects Versions: Release Branch 17.12
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
>
> If after a search in the lookup dialog a page number is entered to display 
> the found hits, the result is displayed as an independent page without theme 
> and not in the lookup dialog.
> To reproduce this:
>  * go to catalog
>  * Lookup product (lookup-dialog is open)
>  * search for products categories
>  * enter 2 for pagenumber and press enter
>  * the lookup-dialog disappears and your results are shown on the screen 
> without a theme



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #287: Fixed: Page selection is not working correctly in the lookup-dialog (OFBIZ-12163)

2021-03-15 Thread GitBox


JacquesLeRoux merged pull request #287:
URL: https://github.com/apache/ofbiz-framework/pull/287


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-12163) Page selection is not working correctly in the lookup-dialog

2021-03-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12163:

  Component/s: framework/webapp
Affects Version/s: Release Branch 17.12

> Page selection is not working correctly in the lookup-dialog
> 
>
> Key: OFBIZ-12163
> URL: https://issues.apache.org/jira/browse/OFBIZ-12163
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webapp
>Affects Versions: Release Branch 17.12
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
>
> If after a search in the lookup dialog a page number is entered to display 
> the found hits, the result is displayed as an independent page without theme 
> and not in the lookup dialog.
> To reproduce this:
>  * go to catalog
>  * Lookup product (lookup-dialog is open)
>  * search for products categories
>  * enter 2 for pagenumber and press enter
>  * the lookup-dialog disappears and your results are shown on the screen 
> without a theme



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12163) Page selection is not working correctly in the lookup-dialog

2021-03-15 Thread Jira


[ 
https://issues.apache.org/jira/browse/OFBIZ-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301570#comment-17301570
 ] 

Wiebke Pätzold commented on OFBIZ-12163:


I made a PR for my first solution to fix the lookup-dialog.

> Page selection is not working correctly in the lookup-dialog
> 
>
> Key: OFBIZ-12163
> URL: https://issues.apache.org/jira/browse/OFBIZ-12163
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
>
> If after a search in the lookup dialog a page number is entered to display 
> the found hits, the result is displayed as an independent page without theme 
> and not in the lookup dialog.
> To reproduce this:
>  * go to catalog
>  * Lookup product (lookup-dialog is open)
>  * search for products categories
>  * enter 2 for pagenumber and press enter
>  * the lookup-dialog disappears and your results are shown on the screen 
> without a theme



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #287: Fixed: Page selection is not working correctly in the lookup-dialog (OFBIZ-12163)

2021-03-15 Thread GitBox


sonarcloud[bot] commented on pull request #287:
URL: https://github.com/apache/ofbiz-framework/pull/287#issuecomment-799307816


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=287&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=287)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=287&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=287&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-12163) Page selection is not working correctly in the lookup-dialog

2021-03-15 Thread Jira


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wiebke Pätzold updated OFBIZ-12163:
---
Description: 
If after a search in the lookup dialog a page number is entered to display the 
found hits, the result is displayed as an independent page without theme and 
not in the lookup dialog.

To reproduce this:
 * go to catalog
 * Lookup product (lookup-dialog is open)
 * search for products categories
 * enter 2 for pagenumber and press enter
 * the lookup-dialog disappears and your results are shown on the screen 
without a theme

  was:
If after a search in the lookup dialog a page number is entered to display the 
found hits, the result is displayed as an independent page without theme and 
not in the lookup dialog.

To reproduce this:
 * go to catalog
 * Lookup product (lookup-dialog is open)
 * search for products which contains 0 in productId
 * enter 2 for pagenumber and press enter
 * the lookup-dialog disappears and your results are shown on the screen 
without a theme


> Page selection is not working correctly in the lookup-dialog
> 
>
> Key: OFBIZ-12163
> URL: https://issues.apache.org/jira/browse/OFBIZ-12163
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Wiebke Pätzold
>Assignee: Wiebke Pätzold
>Priority: Minor
>
> If after a search in the lookup dialog a page number is entered to display 
> the found hits, the result is displayed as an independent page without theme 
> and not in the lookup dialog.
> To reproduce this:
>  * go to catalog
>  * Lookup product (lookup-dialog is open)
>  * search for products categories
>  * enter 2 for pagenumber and press enter
>  * the lookup-dialog disappears and your results are shown on the screen 
> without a theme



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] wpaetzold opened a new pull request #287: Fixed: Page selection is not working correctly in the lookup-dialog (OFBIZ-12163)

2021-03-15 Thread GitBox


wpaetzold opened a new pull request #287:
URL: https://github.com/apache/ofbiz-framework/pull/287


   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11599) Convert CheckoutServices.xml minilang to groovy

2021-03-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11599.
---
Resolution: Implemented

Thanks Sebastian,

Tested with one page shopping in ecommerce

> Convert CheckoutServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11599
> URL: https://issues.apache.org/jira/browse/OFBIZ-11599
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #75: OFBIZ-11599 Improved: Convert CheckoutServices.xml minilang to groovy

2021-03-15 Thread GitBox


JacquesLeRoux merged pull request #75:
URL: https://github.com/apache/ofbiz-framework/pull/75


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11599) Convert CheckoutServices.xml minilang to groovy

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301561#comment-17301561
 ] 

ASF subversion and git services commented on OFBIZ-11599:
-

Commit b1d4dc6ea01e961c1c7d70d5fae356f218b5149c in ofbiz-framework's branch 
refs/heads/trunk from SebastianEcomify
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b1d4dc6 ]

Improved: Convert CheckoutServices.xml minilang to groovy (#75)

(OFBIZ-11599)

> Convert CheckoutServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11599
> URL: https://issues.apache.org/jira/browse/OFBIZ-11599
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12064) Load language js for date.js only when required

2021-03-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301543#comment-17301543
 ] 

Jacques Le Roux commented on OFBIZ-12064:
-

Hi James,

While working on OFBIZ-11684 I tried to backport this to R18. As it's not 
straightforward I have a question for you, hope you remember. 
At https://markmail.org/message/doakpjln4qob2agq you said:
bq.  Found one dependency with datetimepicker.
Do you remember what the dependency is? Because simply removing 
JsLanguageFilesMapping.datejs calling from GlobalActions works at least at 
/ordermgr/control/orderentry. I tested other locations as well and all seems 
working. So I wonder what the dependency with datetimepicker are, TIA


> Load language js for date.js only when required 
> 
>
> Key: OFBIZ-12064
> URL: https://issues.apache.org/jira/browse/OFBIZ-12064
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12064.patch
>
>
> Only load language js for Date.js when there is a date time picker in the 
> page. The library is located at 
> themes/common-themes/webapp/common/js/jquery/plugins/datejs.
> Discussion started at 
> https://lists.apache.org/thread.html/re9288f4d70f216677f08d859bba8d6fc195d0d2d754f0e93838d87f9%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree

2021-03-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-11684:
---

Assignee: Jacques Le Roux

> Form to add an employee position doesn't function properly when invoked from 
> Humanres tree
> --
>
> Key: OFBIZ-11684
> URL: https://issues.apache.org/jira/browse/OFBIZ-11684
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, 
> 17.12.03, Trunk, 17.12.04
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: usability
>
> Selecting Add Employee Position or Add Person from the context menu opens the 
> corresponding edit forms with calendar lookup fields.
> The calendar form does no open when the lookup icon is clicked.
> Expected calendar to open on click.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11685) Form to add an employee doesn't function properly when invoked from Humanres tree

2021-03-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11685.
---
  Assignee: Sebastian Berg  (was: Jacques Le Roux)
Resolution: Duplicate

> Form to add an employee doesn't function properly when invoked from Humanres 
> tree
> -
>
> Key: OFBIZ-11685
> URL: https://issues.apache.org/jira/browse/OFBIZ-11685
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, 
> 17.12.03, Trunk, 17.12.04
>Reporter: Pierre Smits
>Assignee: Sebastian Berg
>Priority: Major
>  Labels: usability
>
>   Selecting 'Add Person' from the context menu (on the 'Employment Position' 
> element opens the corresponding edit forms with calendar lookup fields.
> The calendar form does no open when the lookup icon is clicked.
> Expected calendar to open on click.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11685) Form to add an employee doesn't function properly when invoked from Humanres tree

2021-03-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-11685:
---

Assignee: Jacques Le Roux  (was: Sebastian Berg)

> Form to add an employee doesn't function properly when invoked from Humanres 
> tree
> -
>
> Key: OFBIZ-11685
> URL: https://issues.apache.org/jira/browse/OFBIZ-11685
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, 
> 17.12.03, Trunk, 17.12.04
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: usability
>
>   Selecting 'Add Person' from the context menu (on the 'Employment Position' 
> element opens the corresponding edit forms with calendar lookup fields.
> The calendar form does no open when the lookup icon is clicked.
> Expected calendar to open on click.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12191) Bug preventing proper explosion of BOM containing virtual nodes

2021-03-15 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-12191.
---
Fix Version/s: 17.12.06
   18.12.01
   Resolution: Fixed

> Bug preventing proper explosion of BOM containing virtual nodes
> ---
>
> Key: OFBIZ-12191
> URL: https://issues.apache.org/jira/browse/OFBIZ-12191
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.06
>
> Attachments: OFBIZ-12191.patch, OFBIZ-12191_sample-data.xml, 
> image-2021-02-27-18-37-47-422.png
>
>
> I tried the following use case. We configured BOM for the virtual product 
> whose nodes can also be virtual.
>  
> {code:java}
> // Product To Be produced
> PROD_MANUF_1 (Virtual Product)
>  - PROD_MANUF_11 (Variant)
>  - PROD_MANUF_12 (Variant)
>  
> // Raw Material
> RAW_MAT_1 (Virtual)
>  - RAW_MAT_11 (Variant)
>  - RAW_MAT_12 (Variant)
>  
> RAW_MAT_2 (Standard)
> // BOM
> PROD_MANUF_1-> RAW_MAT_1
> -> RAW_MAT_2
> PROD_MANUF_11   -> RAW_MAT_11  -> 2 Qty
> -> RAW_MAT_2   -> 2 Qty
>  
>  
> PROD_MANUF_12   -> RAW_MAT_12  -> 3 Qty
> -> RAW_MAT_2   -> 2 Qty {code}
> Now let say we want to manufacture 10qty of PROD_MANUF_12. To my 
> expectations, the requirement generated should be like
>  - To produce 10qty for PROD_MANUF_12 we will need
>        - 30qty of RAW_MAT_12
>        - 20qty of RAW_MAT_2
> But the result for MRP and BOM simulation is incorrect. Please refer to the 
> screenshot.
> !image-2021-02-27-18-37-47-422.png!
> _I am also attaching sample data to test._



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12191) Bug preventing proper explosion of BOM containing virtual nodes

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301494#comment-17301494
 ] 

ASF subversion and git services commented on OFBIZ-12191:
-

Commit af5d61b051eb4bd2afa1be9035b67b7ba742314d in ofbiz-framework's branch 
refs/heads/release17.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=af5d61b ]

Fixed: Bug preventing proper explosion of BOM containing virtual nodes 
(OFBIZ-12191)

Thanks: Nameet for report and fix and Jacopo for test.


> Bug preventing proper explosion of BOM containing virtual nodes
> ---
>
> Key: OFBIZ-12191
> URL: https://issues.apache.org/jira/browse/OFBIZ-12191
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-12191.patch, OFBIZ-12191_sample-data.xml, 
> image-2021-02-27-18-37-47-422.png
>
>
> I tried the following use case. We configured BOM for the virtual product 
> whose nodes can also be virtual.
>  
> {code:java}
> // Product To Be produced
> PROD_MANUF_1 (Virtual Product)
>  - PROD_MANUF_11 (Variant)
>  - PROD_MANUF_12 (Variant)
>  
> // Raw Material
> RAW_MAT_1 (Virtual)
>  - RAW_MAT_11 (Variant)
>  - RAW_MAT_12 (Variant)
>  
> RAW_MAT_2 (Standard)
> // BOM
> PROD_MANUF_1-> RAW_MAT_1
> -> RAW_MAT_2
> PROD_MANUF_11   -> RAW_MAT_11  -> 2 Qty
> -> RAW_MAT_2   -> 2 Qty
>  
>  
> PROD_MANUF_12   -> RAW_MAT_12  -> 3 Qty
> -> RAW_MAT_2   -> 2 Qty {code}
> Now let say we want to manufacture 10qty of PROD_MANUF_12. To my 
> expectations, the requirement generated should be like
>  - To produce 10qty for PROD_MANUF_12 we will need
>        - 30qty of RAW_MAT_12
>        - 20qty of RAW_MAT_2
> But the result for MRP and BOM simulation is incorrect. Please refer to the 
> screenshot.
> !image-2021-02-27-18-37-47-422.png!
> _I am also attaching sample data to test._



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11799) Move page-specific script links to html template

2021-03-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11799:

Fix Version/s: (was: Trunk)
   Upcoming Branch
Affects Version/s: (was: Upcoming Branch)
   Trunk

> Move page-specific script links to html template
> 
>
> Key: OFBIZ-11799
> URL: https://issues.apache.org/jira/browse/OFBIZ-11799
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> As external script can be defined in html template, suggest to move some of 
> the page-specific script links from layoutSettings.javaScripts to the html 
> templates.
> 6 Aug 2020
>  Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
> VT_STYLESHEET.
> 15 Aug 2020
> Used importLibrary js to load js / css files when needed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12064) Load language js for date.js only when required

2021-03-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12064:

Affects Version/s: (was: Upcoming Branch)
   Trunk

> Load language js for date.js only when required 
> 
>
> Key: OFBIZ-12064
> URL: https://issues.apache.org/jira/browse/OFBIZ-12064
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12064.patch
>
>
> Only load language js for Date.js when there is a date time picker in the 
> page. The library is located at 
> themes/common-themes/webapp/common/js/jquery/plugins/datejs.
> Discussion started at 
> https://lists.apache.org/thread.html/re9288f4d70f216677f08d859bba8d6fc195d0d2d754f0e93838d87f9%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12191) Bug preventing proper explosion of BOM containing virtual nodes

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301474#comment-17301474
 ] 

ASF subversion and git services commented on OFBIZ-12191:
-

Commit e87e8f4418a6c5ea01a0f76b7af0959bd95bc352 in ofbiz-framework's branch 
refs/heads/release18.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e87e8f4 ]

Fixed: Bug preventing proper explosion of BOM containing virtual nodes 
(OFBIZ-12191)

Thanks: Nameet for report and fix and Jacopo for test.


> Bug preventing proper explosion of BOM containing virtual nodes
> ---
>
> Key: OFBIZ-12191
> URL: https://issues.apache.org/jira/browse/OFBIZ-12191
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-12191.patch, OFBIZ-12191_sample-data.xml, 
> image-2021-02-27-18-37-47-422.png
>
>
> I tried the following use case. We configured BOM for the virtual product 
> whose nodes can also be virtual.
>  
> {code:java}
> // Product To Be produced
> PROD_MANUF_1 (Virtual Product)
>  - PROD_MANUF_11 (Variant)
>  - PROD_MANUF_12 (Variant)
>  
> // Raw Material
> RAW_MAT_1 (Virtual)
>  - RAW_MAT_11 (Variant)
>  - RAW_MAT_12 (Variant)
>  
> RAW_MAT_2 (Standard)
> // BOM
> PROD_MANUF_1-> RAW_MAT_1
> -> RAW_MAT_2
> PROD_MANUF_11   -> RAW_MAT_11  -> 2 Qty
> -> RAW_MAT_2   -> 2 Qty
>  
>  
> PROD_MANUF_12   -> RAW_MAT_12  -> 3 Qty
> -> RAW_MAT_2   -> 2 Qty {code}
> Now let say we want to manufacture 10qty of PROD_MANUF_12. To my 
> expectations, the requirement generated should be like
>  - To produce 10qty for PROD_MANUF_12 we will need
>        - 30qty of RAW_MAT_12
>        - 20qty of RAW_MAT_2
> But the result for MRP and BOM simulation is incorrect. Please refer to the 
> screenshot.
> !image-2021-02-27-18-37-47-422.png!
> _I am also attaching sample data to test._



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12191) Bug preventing proper explosion of BOM containing virtual nodes

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301466#comment-17301466
 ] 

ASF subversion and git services commented on OFBIZ-12191:
-

Commit b5b062de2e1f9efb2f7b70291e19b0a6c7bf7a02 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b5b062d ]

Fixed: Bug preventing proper explosion of BOM containing virtual nodes 
(OFBIZ-12191)

Thanks: Nameet for report and fix and Jacopo for test.


> Bug preventing proper explosion of BOM containing virtual nodes
> ---
>
> Key: OFBIZ-12191
> URL: https://issues.apache.org/jira/browse/OFBIZ-12191
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-12191.patch, OFBIZ-12191_sample-data.xml, 
> image-2021-02-27-18-37-47-422.png
>
>
> I tried the following use case. We configured BOM for the virtual product 
> whose nodes can also be virtual.
>  
> {code:java}
> // Product To Be produced
> PROD_MANUF_1 (Virtual Product)
>  - PROD_MANUF_11 (Variant)
>  - PROD_MANUF_12 (Variant)
>  
> // Raw Material
> RAW_MAT_1 (Virtual)
>  - RAW_MAT_11 (Variant)
>  - RAW_MAT_12 (Variant)
>  
> RAW_MAT_2 (Standard)
> // BOM
> PROD_MANUF_1-> RAW_MAT_1
> -> RAW_MAT_2
> PROD_MANUF_11   -> RAW_MAT_11  -> 2 Qty
> -> RAW_MAT_2   -> 2 Qty
>  
>  
> PROD_MANUF_12   -> RAW_MAT_12  -> 3 Qty
> -> RAW_MAT_2   -> 2 Qty {code}
> Now let say we want to manufacture 10qty of PROD_MANUF_12. To my 
> expectations, the requirement generated should be like
>  - To produce 10qty for PROD_MANUF_12 we will need
>        - 30qty of RAW_MAT_12
>        - 20qty of RAW_MAT_2
> But the result for MRP and BOM simulation is incorrect. Please refer to the 
> screenshot.
> !image-2021-02-27-18-37-47-422.png!
> _I am also attaching sample data to test._



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12153) Error in deleting Financial Account

2021-03-15 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-12153.
---
Fix Version/s: 17.12.06
   18.12.01
 Assignee: Pawan Verma  (was: sourabh jain)
   Resolution: Fixed

> Error in deleting Financial Account
> ---
>
> Key: OFBIZ-12153
> URL: https://issues.apache.org/jira/browse/OFBIZ-12153
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Lalit Dashora
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.06
>
> Attachments: FinAccountDelete.png, OFBIZ-12153.patch, 
> OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, 
> OFBIZ-12153.patch
>
>
> 1. Navigate to URL: accounting/control/FindFinAccount
> 2. Click on Find button. List of fin account will be displayed.
> 3. Click on delete button near available balance column.
> The Following Errors Occurred:
> Error doing entity-auto operation for entity FinAccount in service 
> deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting 
> the following entity: 
> [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL 
> Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' 
> caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key 
> (SC_CHECKING). The statement has been rolled back.)) (Exception while 
> deleting the following entity: 
> [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL 
> Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' 
> caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key 
> (SC_CHECKING). The statement has been rolled back.)))



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12153) Error in deleting Financial Account

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301463#comment-17301463
 ] 

ASF subversion and git services commented on OFBIZ-12153:
-

Commit b2a59b12a96e9dbbea72372bc062f5a8532dac24 in ofbiz-framework's branch 
refs/heads/release18.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b2a59b1 ]

Fixed: Error in deleting Financial Account (OFBIZ-12153)

1. Navigate to URL: accounting/control/FindFinAccount
2. Click on Find button. List of fin account will be displayed.
3. Click on delete button near available balance column.

Thanks: Lalit Dashora for report, Sourabh Jain for the initial fix, Jacques for 
the test.


> Error in deleting Financial Account
> ---
>
> Key: OFBIZ-12153
> URL: https://issues.apache.org/jira/browse/OFBIZ-12153
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Lalit Dashora
>Assignee: sourabh jain
>Priority: Major
> Attachments: FinAccountDelete.png, OFBIZ-12153.patch, 
> OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, 
> OFBIZ-12153.patch
>
>
> 1. Navigate to URL: accounting/control/FindFinAccount
> 2. Click on Find button. List of fin account will be displayed.
> 3. Click on delete button near available balance column.
> The Following Errors Occurred:
> Error doing entity-auto operation for entity FinAccount in service 
> deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting 
> the following entity: 
> [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL 
> Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' 
> caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key 
> (SC_CHECKING). The statement has been rolled back.)) (Exception while 
> deleting the following entity: 
> [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL 
> Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' 
> caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key 
> (SC_CHECKING). The statement has been rolled back.)))



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12153) Error in deleting Financial Account

2021-03-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17301458#comment-17301458
 ] 

ASF subversion and git services commented on OFBIZ-12153:
-

Commit 2cf6476a79dd1c71045b903ad8e2e201121fefc3 in ofbiz-framework's branch 
refs/heads/release17.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2cf6476 ]

Fixed: Error in deleting Financial Account (OFBIZ-12153)

1. Navigate to URL: accounting/control/FindFinAccount
2. Click on Find button. List of fin account will be displayed.
3. Click on delete button near available balance column.

Thanks: Lalit Dashora for report, Sourabh Jain for the initial fix, Jacques for 
the test.


> Error in deleting Financial Account
> ---
>
> Key: OFBIZ-12153
> URL: https://issues.apache.org/jira/browse/OFBIZ-12153
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Lalit Dashora
>Assignee: sourabh jain
>Priority: Major
> Attachments: FinAccountDelete.png, OFBIZ-12153.patch, 
> OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, 
> OFBIZ-12153.patch
>
>
> 1. Navigate to URL: accounting/control/FindFinAccount
> 2. Click on Find button. List of fin account will be displayed.
> 3. Click on delete button near available balance column.
> The Following Errors Occurred:
> Error doing entity-auto operation for entity FinAccount in service 
> deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting 
> the following entity: 
> [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL 
> Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' 
> caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key 
> (SC_CHECKING). The statement has been rolled back.)) (Exception while 
> deleting the following entity: 
> [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL 
> Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' 
> caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key 
> (SC_CHECKING). The statement has been rolled back.)))



--
This message was sent by Atlassian Jira
(v8.3.4#803005)