[jira] [Comment Edited] (OFBIZ-12273) IndexOutOfBoundsException on Entity Import
[ https://issues.apache.org/jira/browse/OFBIZ-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374104#comment-17374104 ] Jacques Le Roux edited comment on OFBIZ-12273 at 7/3/21, 5:38 PM: -- Hi guys, I have fixed your issues https://github.com/apache/ofbiz-framework/commit/0effce0 Please check it's OK with you and you don't see any possible vulnerabilities, TIA If it's OK I'll backport and close was (Author: jacques.le.roux): Hi guys, I have fixed your issues https://github.com/apache/ofbiz-framework/commit/0effce0 Please check it's OK with you and you don't see any possible vulnerabilities, TIA If it's OK I'll close > IndexOutOfBoundsException on Entity Import > -- > > Key: OFBIZ-12273 > URL: https://issues.apache.org/jira/browse/OFBIZ-12273 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > > I get an IndexOutOfBoundsException when using the EntityImport. > The problem occurs while having a resemblance of an url in the data. > For example ' > screenPath="component://project/widget/project/ContentScreens.xml#main-page-template"' > is interpreted as url because of '://' but doesn't match a valid url > pattern. > The problem seems to be directly connected to Issue 12249. I think the used > pattern in UtilHttp.exctractUrl() should at least be configureable like the > customSafePolicy. [~jleroux] maybe you can have a look since you implemented > the changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12273) IndexOutOfBoundsException on Entity Import
[ https://issues.apache.org/jira/browse/OFBIZ-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374104#comment-17374104 ] Jacques Le Roux commented on OFBIZ-12273: - Hi guys, I have fixed your issues https://github.com/apache/ofbiz-framework/commit/0effce0 Please check it's OK with you and you don't see any possible vulnerabilities, TIA If it's OK I'll close > IndexOutOfBoundsException on Entity Import > -- > > Key: OFBIZ-12273 > URL: https://issues.apache.org/jira/browse/OFBIZ-12273 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > > I get an IndexOutOfBoundsException when using the EntityImport. > The problem occurs while having a resemblance of an url in the data. > For example ' > screenPath="component://project/widget/project/ContentScreens.xml#main-page-template"' > is interpreted as url because of '://' but doesn't match a valid url > pattern. > The problem seems to be directly connected to Issue 12249. I think the used > pattern in UtilHttp.exctractUrl() should at least be configureable like the > customSafePolicy. [~jleroux] maybe you can have a look since you implemented > the changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12273) IndexOutOfBoundsException on Entity Import
[ https://issues.apache.org/jira/browse/OFBIZ-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374103#comment-17374103 ] ASF subversion and git services commented on OFBIZ-12273: - Commit 0effce0c7b07483143b92e5c673cf8d55db6cef1 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0effce0 ] Fixed: IndexOutOfBoundsException on Entity Import (OFBIZ-12273) I get an IndexOutOfBoundsException when using the EntityImport. The problem occurs while having a resemblance of an url in the data. For example screenPath="component://... is interpreted as url because of '://' but doesn't match a valid url pattern. jleroux: I decided to keep it simple and to take the "component://" and the "https://localhost"; cases apart. I see no reasons to fear "https://localhost"; there. It should be only used in a safe dev env. Thanks: Sebastian Berg and Nicolas Malin for report > IndexOutOfBoundsException on Entity Import > -- > > Key: OFBIZ-12273 > URL: https://issues.apache.org/jira/browse/OFBIZ-12273 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > > I get an IndexOutOfBoundsException when using the EntityImport. > The problem occurs while having a resemblance of an url in the data. > For example ' > screenPath="component://project/widget/project/ContentScreens.xml#main-page-template"' > is interpreted as url because of '://' but doesn't match a valid url > pattern. > The problem seems to be directly connected to Issue 12249. I think the used > pattern in UtilHttp.exctractUrl() should at least be configureable like the > customSafePolicy. [~jleroux] maybe you can have a look since you implemented > the changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-8039) Clean up commented out code in Java source for Minilang component
[ https://issues.apache.org/jira/browse/OFBIZ-8039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8039. -- Resolution: Won't Do Closing, no need to work on that, Minilang is deprecated and slowly replaced by Groovy... > Clean up commented out code in Java source for Minilang component > - > > Key: OFBIZ-8039 > URL: https://issues.apache.org/jira/browse/OFBIZ-8039 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Minilang component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #308: Improved: Cleaned commented code from entity component (OFBIZ-8038)
sonarcloud[bot] commented on pull request #308: URL: https://github.com/apache/ofbiz-framework/pull/308#issuecomment-873382588 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=308&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=308) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=308&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=308&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-7536) Clean up commented out code
[ https://issues.apache.org/jira/browse/OFBIZ-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373987#comment-17373987 ] Ioan Eugen Stan commented on OFBIZ-7536: I started working on this and issue a PR for Entity. Will find some time for the others. My proposal for minilang is to close the issue since it is going out and no need to waste time fixing comments. > Clean up commented out code > --- > > Key: OFBIZ-7536 > URL: https://issues.apache.org/jira/browse/OFBIZ-7536 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Major > > In our Re-Factor To-Do List one of the item is to clean up the commented out > code. > This is the parent ticket and I will further create sub tasks under it so > that we do not push large change in one commit. > This includes Java, Xml, Groovy and FTL files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8038) Clean up commented out code in Java source for Entity component
[ https://issues.apache.org/jira/browse/OFBIZ-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373984#comment-17373984 ] Ioan Eugen Stan commented on OFBIZ-8038: A PR is available for this [https://github.com/apache/ofbiz-framework/pull/308] . > Clean up commented out code in Java source for Entity component > --- > > Key: OFBIZ-8038 > URL: https://issues.apache.org/jira/browse/OFBIZ-8038 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Entity component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8038) Clean up commented out code in Java source for Entity component
[ https://issues.apache.org/jira/browse/OFBIZ-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373986#comment-17373986 ] Ioan Eugen Stan commented on OFBIZ-8038: Some comments might be reverted. They seem to be used for debugging. I removed them to make them stand out for review. > Clean up commented out code in Java source for Entity component > --- > > Key: OFBIZ-8038 > URL: https://issues.apache.org/jira/browse/OFBIZ-8038 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Entity component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] ieugen commented on pull request #308: Improved: Cleaned commented code from entity component (OFBIZ-8038)
ieugen commented on pull request #308: URL: https://github.com/apache/ofbiz-framework/pull/308#issuecomment-873381949 Some comments might be reverted. They seem to be used for debugging. I removed them to make them stand out for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] ieugen opened a new pull request #308: Improved: Cleaned commented code from entity component (OFBIZ-8038)
ieugen opened a new pull request #308: URL: https://github.com/apache/ofbiz-framework/pull/308 Improved: Cleaned commented code from entity component (OFBIZ-8038) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-8038) Clean up commented out code in Java source for Entity component
[ https://issues.apache.org/jira/browse/OFBIZ-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373975#comment-17373975 ] Ioan Eugen Stan commented on OFBIZ-8038: I checked org.apache.ofbiz.entity package , the XSD and xml for config dtd and entitydef. There is no outstanding commented code. Will continue with the other packages. > Clean up commented out code in Java source for Entity component > --- > > Key: OFBIZ-8038 > URL: https://issues.apache.org/jira/browse/OFBIZ-8038 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Entity component -- This message was sent by Atlassian Jira (v8.3.4#803005)
