[jira] [Commented] (OFBIZ-8040) Clean up commented out code in Java source for Service component
[ https://issues.apache.org/jira/browse/OFBIZ-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17376268#comment-17376268 ] Ioan Eugen Stan commented on OFBIZ-8040: Started working on this one. > Clean up commented out code in Java source for Service component > > > Key: OFBIZ-8040 > URL: https://issues.apache.org/jira/browse/OFBIZ-8040 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Service component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-8038) Clean up commented out code in Java source for Entity component
[ https://issues.apache.org/jira/browse/OFBIZ-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8038. -- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux (was: Harsh Vijaywargiya) Resolution: Implemented > Clean up commented out code in Java source for Entity component > --- > > Key: OFBIZ-8038 > URL: https://issues.apache.org/jira/browse/OFBIZ-8038 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Clean up commented out code in Java source for Entity component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8038) Clean up commented out code in Java source for Entity component
[ https://issues.apache.org/jira/browse/OFBIZ-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375773#comment-17375773 ] ASF subversion and git services commented on OFBIZ-8038: Commit dbaed189b17b34da9133a52f569e09e2e07ae6f9 in ofbiz-framework's branch refs/heads/trunk from Ioan Eugen Stan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=dbaed18 ] Improved: Cleaned commented code from entity component (OFBIZ-8038) (#308) > Clean up commented out code in Java source for Entity component > --- > > Key: OFBIZ-8038 > URL: https://issues.apache.org/jira/browse/OFBIZ-8038 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Entity component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #308: Improved: Cleaned commented code from entity component (OFBIZ-8038)
JacquesLeRoux merged pull request #308: URL: https://github.com/apache/ofbiz-framework/pull/308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] JacquesLeRoux commented on pull request #25: Improved: project - simplified uris (OFBIZ-11792)
JacquesLeRoux commented on pull request #25: URL: https://github.com/apache/ofbiz-plugins/pull/25#issuecomment-874792889 Hi Pierre, The Sonar Could Code Analysis is no longer available. So I don't know why it reports 3 bugs, even more intriguing w/o any Java files involved. Nevertheless, there is at least one problem with your change. If you start by login in another application you can't jump to project w/o an error. The reason is other applications still refer to project through control/main. So you would need to handle this case apart if you don't want to provide something big like https://issues.apache.org/jira/browse/OFBIZ-11354. I mean another OFBIZ-11791 sub-task with a patch to be applied before all other where all application would refer to each others w/o "control/main". HTH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-12269) Error while using Product Jump option
[ https://issues.apache.org/jira/browse/OFBIZ-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12269. --- Assignee: Jacques Le Roux Resolution: Duplicate > Error while using Product Jump option > - > > Key: OFBIZ-12269 > URL: https://issues.apache.org/jira/browse/OFBIZ-12269 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Jacques Le Roux >Priority: Major > Attachments: image-2021-06-29-17-50-33-409.png > > > Open the Catalog app and use the "_Product Jump"_ feature under "_Search > Products"_ section to navigate to the "Edit Product" screen. > !image-2021-06-29-17-50-33-409.png! > > Expected: - > Edit product screen should be visible. > Actual:- > Error screen -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12273) IndexOutOfBoundsException on Entity Import
[ https://issues.apache.org/jira/browse/OFBIZ-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375686#comment-17375686 ] Jacques Le Roux commented on OFBIZ-12273: - If nobody objects, I'll backport and close in a week, please test... TIA > IndexOutOfBoundsException on Entity Import > -- > > Key: OFBIZ-12273 > URL: https://issues.apache.org/jira/browse/OFBIZ-12273 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > > I get an IndexOutOfBoundsException when using the EntityImport. > The problem occurs while having a resemblance of an url in the data. > For example ' > screenPath="component://project/widget/project/ContentScreens.xml#main-page-template"' > is interpreted as url because of '://' but doesn't match a valid url > pattern. > The problem seems to be directly connected to Issue 12249. I think the used > pattern in UtilHttp.exctractUrl() should at least be configureable like the > customSafePolicy. [~jleroux] maybe you can have a look since you implemented > the changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12273) IndexOutOfBoundsException on Entity Import
[ https://issues.apache.org/jira/browse/OFBIZ-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375684#comment-17375684 ] ASF subversion and git services commented on OFBIZ-12273: - Commit e4919d16ca33face162defb0e3a07373a8f9f374 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e4919d1 ] Fixed: IndexOutOfBoundsException on Entity Import (OFBIZ-12273) Removes the localhost (and 127.0.0.1) OOTB. Allows to use it through a "multi-property" (list) in security.properties. > IndexOutOfBoundsException on Entity Import > -- > > Key: OFBIZ-12273 > URL: https://issues.apache.org/jira/browse/OFBIZ-12273 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > > I get an IndexOutOfBoundsException when using the EntityImport. > The problem occurs while having a resemblance of an url in the data. > For example ' > screenPath="component://project/widget/project/ContentScreens.xml#main-page-template"' > is interpreted as url because of '://' but doesn't match a valid url > pattern. > The problem seems to be directly connected to Issue 12249. I think the used > pattern in UtilHttp.exctractUrl() should at least be configureable like the > customSafePolicy. [~jleroux] maybe you can have a look since you implemented > the changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] ieugen commented on pull request #308: Improved: Cleaned commented code from entity component (OFBIZ-8038)
ieugen commented on pull request #308: URL: https://github.com/apache/ofbiz-framework/pull/308#issuecomment-873960610 Ready for merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #308: Improved: Cleaned commented code from entity component (OFBIZ-8038)
sonarcloud[bot] removed a comment on pull request #308: URL: https://github.com/apache/ofbiz-framework/pull/308#issuecomment-873382588 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=308=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=308=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=308=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=308) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=308=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=308=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] ieugen commented on a change in pull request #308: Improved: Cleaned commented code from entity component (OFBIZ-8038)
ieugen commented on a change in pull request #308:
URL: https://github.com/apache/ofbiz-framework/pull/308#discussion_r663781203
##
File path:
framework/entity/src/main/java/org/apache/ofbiz/entity/util/EntityCrypto.java
##
@@ -110,16 +110,6 @@ public String encrypt(String keyName, EncryptMethod
encryptMethod, Object obj) t
}
}
Review comment:
Added back.
##
File path:
framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelReader.java
##
@@ -225,8 +224,7 @@ private ModelEntity buildEntity(ResourceHandler
entityResourceHandler, Element c
throw new GenericEntityConfException("Could not
get document for " + entityResourceHandler.toString());
}
-// utilTimer.timerString("Before getDocumentElement in
" +
Review comment:
I've kept one line comments that seem to be useful in debugging.
They are not that many so have little impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #308: Improved: Cleaned commented code from entity component (OFBIZ-8038)
sonarcloud[bot] commented on pull request #308: URL: https://github.com/apache/ofbiz-framework/pull/308#issuecomment-873962310 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=308=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=308=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=308=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=308=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=308) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=308=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=308=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
