[GitHub] [ofbiz-plugins] PierreSmits commented on pull request #25: Improved: project - simplified uris (OFBIZ-11792)
PierreSmits commented on pull request #25: URL: https://github.com/apache/ofbiz-plugins/pull/25#issuecomment-876168763 Jacques, Addressing the other issue with another ticket (and a subsequent pull request/patch file - for those still working with SVN, yay) while not resolving the existing sub-tickets under OFBIZ-11791 seems to be leading to the same circular, chicken-egg discussion that have been there on other improvement aspects in the past. And for some these changes are either too big, too small, too complex or too mediocre to collaborate on (take your pick). All in all, though desired (see user ml), not moving forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] PierreSmits commented on pull request #25: Improved: project - simplified uris (OFBIZ-11792)
PierreSmits commented on pull request #25: URL: https://github.com/apache/ofbiz-plugins/pull/25#issuecomment-876164871 Jacques, Regarding the off-track discussion, it seems to me that you already addressed it (together with INFRA) relating to another issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] JacquesLeRoux commented on pull request #25: Improved: project - simplified uris (OFBIZ-11792)
JacquesLeRoux commented on pull request #25: URL: https://github.com/apache/ofbiz-plugins/pull/25#issuecomment-875720259 Hi Pierre, As I said this is not a problem. We can always try locally. ALso we know that we should not use SonarCloud Code Analysis in GH but w/ Gradle. I already suggested to resolve the issue when coming from other applications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12272) Miscellaneous improvements to FindWorkEffort screen
[
https://issues.apache.org/jira/browse/OFBIZ-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376644#comment-17376644
]
Xin Wang commented on OFBIZ-12272:
--
Hi [~nmalin],
I'll have a look at that in this weekend, just a bit busy in recent days.
> Miscellaneous improvements to FindWorkEffort screen
> ---
>
> Key: OFBIZ-12272
> URL: https://issues.apache.org/jira/browse/OFBIZ-12272
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Xin Wang
>Assignee: Nicolas Malin
>Priority: Major
> Attachments:
> 0001-Miscellaneous-improvements-to-FindWorkEffort-screen.patch,
> OFBIZ-12272-WithDynamism.patch
>
>
> Attached patch add miscellaneous improvements to FindWorkEffort screen:
> 1. Add "noConditionFind" field with value "Y" to FindWorkEffort screen to
> show results without click "Find" button
> 2. Change response type of deleteWorkEffort from "view" to
> "request-redirect", so that user can stay in FindWorkEffort screen after
> deletion
> 3. Remove "buttontext" widget style of workEffortId column, as text of this
> column also contains workEffortName, and it may be very long and even wrapped
> for two lines, "buttontext" does not fit it quite well
> 4. Change ListWorkEfforts from "form" to "grid", and enable "sort-field" for
> most of the columns (except "description")
> 5. Change "workEffortId" field text from "${workEffortName}
> [${workEffortId}]" to "[${workEffortId}] ${workEffortName}", to be consistent
> with the sort order, as this column is sort by workEffortId
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12270) Add menu-container-style to calendar menu
[
https://issues.apache.org/jira/browse/OFBIZ-12270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376455#comment-17376455
]
Nicolas Malin edited comment on OFBIZ-12270 at 7/7/21, 9:59 AM:
>From my part I analyse if the menu orientation match an existing menu on
>framework/common/widget/CommonMenus.xml
{code:java}
{code}
I didn't know if it's the good selection, just an example to explain.
Thus when you create a theme it's easier to manage the style of menu present
Common instead control each screen who can implement a css class
was (Author: soledad):
>From my part I analyse if the menu orientation match an existing menu on
>framework/common/widget/CommonMenus.xml
{code:java}
{code}
I didn't know if it's the good selection, just to example to explain.
Thus when you create a theme it's easier to manage the style of menu present
Common instead control each screen who can implement a css class
> Add menu-container-style to calendar menu
> -
>
> Key: OFBIZ-12270
> URL: https://issues.apache.org/jira/browse/OFBIZ-12270
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Xin Wang
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 0001-Add-menu-container-style-to-calendar-menu.patch,
> with-patch.png, without-patch.png
>
>
> Attached patch try to make calendar menu more appealing in Helveticus theme,
> Without this, menu items will be squeezed together.
>
> See this for example:
> https://demo-trunk.ofbiz.apache.org/workeffort/control/calendar
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12270) Add menu-container-style to calendar menu
[
https://issues.apache.org/jira/browse/OFBIZ-12270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376455#comment-17376455
]
Nicolas Malin commented on OFBIZ-12270:
---
>From my part I analyse if the menu orientation match an existing menu on
>framework/common/widget/CommonMenus.xml
{code:java}
{code}
I didn't know if it's the good selection, just to example to explain.
Thus when you create a theme it's easier to manage the style of menu present
Common instead control each screen who can implement a css class
> Add menu-container-style to calendar menu
> -
>
> Key: OFBIZ-12270
> URL: https://issues.apache.org/jira/browse/OFBIZ-12270
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Xin Wang
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 0001-Add-menu-container-style-to-calendar-menu.patch,
> with-patch.png, without-patch.png
>
>
> Attached patch try to make calendar menu more appealing in Helveticus theme,
> Without this, menu items will be squeezed together.
>
> See this for example:
> https://demo-trunk.ofbiz.apache.org/workeffort/control/calendar
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11812) New child element callback on link to go out information on dynamic navigation from form
[
https://issues.apache.org/jira/browse/OFBIZ-11812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376438#comment-17376438
]
ASF subversion and git services commented on OFBIZ-11812:
-
Commit d795fd45beb0a9a17392be76b52a99425768e497 in ofbiz-framework's branch
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d795fd4 ]
Fixed: List parameters forwarded by element callback failed to restore the list
(OFBIZ-11812) (OFBIZ-12261)
There is an error when the callback element resolve the list parameters, it
check the parameters element as field and not as final variable.
This generate an empty callback link.
> New child element callback on link to go out information on dynamic
> navigation from form
>
>
> Key: OFBIZ-11812
> URL: https://issues.apache.org/jira/browse/OFBIZ-11812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Gil Portenseigne
>Priority: Major
> Labels: screen, widget
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11812.patch
>
>
> When a user realize an updating, creation, or run a complex tunneling
> process, if after that you need to refresh a screen area without reload all,
> the action form need to know what it want to update.
> {code:xml}
> target="AddProductStoreToGroup">
>
> ...
> event-type="submit" area-id="centerdiv">
> from-field="productStoreGroup.productStoreGroupId"/>
>
>
> {code}
> This create a dependency between the screen where is displaying information
> and the updating form. Instead create more complicate case to pilot the
> dynamic interaction between the displaying result and the updating action, we
> change the reasoning. A user want a good displaying after his operation is
> finished, so after he terminated his process.
> We introduce a new element, callback on the link. A user start a process in
> general after follow a link, and when is done, we follow the callback to call
> the area to refreah.
> {code:xml}
>
>
>
> from-field="parentProductCategoryId"/>
>
>
> {code}
> With this the developer is concentrate on the start and the end of a process.
> The form or the tunneling process isn't linked to the final screen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12261) Keep paginate list query on dynamic refresh
[
https://issues.apache.org/jira/browse/OFBIZ-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376439#comment-17376439
]
ASF subversion and git services commented on OFBIZ-12261:
-
Commit d795fd45beb0a9a17392be76b52a99425768e497 in ofbiz-framework's branch
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d795fd4 ]
Fixed: List parameters forwarded by element callback failed to restore the list
(OFBIZ-11812) (OFBIZ-12261)
There is an error when the callback element resolve the list parameters, it
check the parameters element as field and not as final variable.
This generate an empty callback link.
> Keep paginate list query on dynamic refresh
> ---
>
> Key: OFBIZ-12261
> URL: https://issues.apache.org/jira/browse/OFBIZ-12261
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12261.patch
>
>
> At this time, when you display a list with search criteria, pagination
> information and/or sort paramerters, if you update an element of this list
> with a update area, you loose all of them.
> Example:
> {code:java}
> target="updateProductMeter" paginate-target="ListProductMeters">
>
>...
>
>
>
>
>
>
>
> {code}
> Or this works well if you move an next page sort the list.
> I propose to use the same idea for each event that realize a modification of
> an element in the list and after refresh it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11812) New child element callback on link to go out information on dynamic navigation from form
[
https://issues.apache.org/jira/browse/OFBIZ-11812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376440#comment-17376440
]
ASF subversion and git services commented on OFBIZ-11812:
-
Commit 20d99d58ab7398bb49142329b1bac6fd1e21dedd in ofbiz-framework's branch
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=20d99d5 ]
Improved: Globalize the refresh on FindScreenDecorator (OFBIZ-11812)
(OFBIZ-12261)
If you use a ComomnDynamicSingle form for realize a search, the
FindScreenDecorator would be refresh all the container searchOptions +
searchResult.
To keep the coherence, we move the screenStack resolution on the beginning of
the decorator, and leave the searchResult to resolve it itself by usage of
EmbeddedDecorator.
In practice to keep all dynamism on a search element :
* Main screen with global decorator include the find screen wrap by
main-decorator
* The find screen include the search form and include the screen list result
wrap by FindScreenDecorator
* The screen result include the list result form wrap by EmbeddedDecorator
> New child element callback on link to go out information on dynamic
> navigation from form
>
>
> Key: OFBIZ-11812
> URL: https://issues.apache.org/jira/browse/OFBIZ-11812
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Gil Portenseigne
>Priority: Major
> Labels: screen, widget
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11812.patch
>
>
> When a user realize an updating, creation, or run a complex tunneling
> process, if after that you need to refresh a screen area without reload all,
> the action form need to know what it want to update.
> {code:xml}
> target="AddProductStoreToGroup">
>
> ...
> event-type="submit" area-id="centerdiv">
> from-field="productStoreGroup.productStoreGroupId"/>
>
>
> {code}
> This create a dependency between the screen where is displaying information
> and the updating form. Instead create more complicate case to pilot the
> dynamic interaction between the displaying result and the updating action, we
> change the reasoning. A user want a good displaying after his operation is
> finished, so after he terminated his process.
> We introduce a new element, callback on the link. A user start a process in
> general after follow a link, and when is done, we follow the callback to call
> the area to refreah.
> {code:xml}
>
>
>
> from-field="parentProductCategoryId"/>
>
>
> {code}
> With this the developer is concentrate on the start and the end of a process.
> The form or the tunneling process isn't linked to the final screen.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12261) Keep paginate list query on dynamic refresh
[
https://issues.apache.org/jira/browse/OFBIZ-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376441#comment-17376441
]
ASF subversion and git services commented on OFBIZ-12261:
-
Commit 20d99d58ab7398bb49142329b1bac6fd1e21dedd in ofbiz-framework's branch
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=20d99d5 ]
Improved: Globalize the refresh on FindScreenDecorator (OFBIZ-11812)
(OFBIZ-12261)
If you use a ComomnDynamicSingle form for realize a search, the
FindScreenDecorator would be refresh all the container searchOptions +
searchResult.
To keep the coherence, we move the screenStack resolution on the beginning of
the decorator, and leave the searchResult to resolve it itself by usage of
EmbeddedDecorator.
In practice to keep all dynamism on a search element :
* Main screen with global decorator include the find screen wrap by
main-decorator
* The find screen include the search form and include the screen list result
wrap by FindScreenDecorator
* The screen result include the list result form wrap by EmbeddedDecorator
> Keep paginate list query on dynamic refresh
> ---
>
> Key: OFBIZ-12261
> URL: https://issues.apache.org/jira/browse/OFBIZ-12261
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12261.patch
>
>
> At this time, when you display a list with search criteria, pagination
> information and/or sort paramerters, if you update an element of this list
> with a update area, you loose all of them.
> Example:
> {code:java}
> target="updateProductMeter" paginate-target="ListProductMeters">
>
>...
>
>
>
>
>
>
>
> {code}
> Or this works well if you move an next page sort the list.
> I propose to use the same idea for each event that realize a modification of
> an element in the list and after refresh it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12261) Keep paginate list query on dynamic refresh
[
https://issues.apache.org/jira/browse/OFBIZ-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376437#comment-17376437
]
ASF subversion and git services commented on OFBIZ-12261:
-
Commit 3770cdbb383204b33fd070b8de67a982d83c4f00 in ofbiz-framework's branch
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3770cdb ]
Implemented: Keep paginate list query on dynamic refresh (OFBIZ-12261)
Complete previous commit with adding CommonDynamicGrid and CommonDynamicSingle
form on common-theme previously forgot
> Keep paginate list query on dynamic refresh
> ---
>
> Key: OFBIZ-12261
> URL: https://issues.apache.org/jira/browse/OFBIZ-12261
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12261.patch
>
>
> At this time, when you display a list with search criteria, pagination
> information and/or sort paramerters, if you update an element of this list
> with a update area, you loose all of them.
> Example:
> {code:java}
> target="updateProductMeter" paginate-target="ListProductMeters">
>
>...
>
>
>
>
>
>
>
> {code}
> Or this works well if you move an next page sort the list.
> I propose to use the same idea for each event that realize a modification of
> an element in the list and after refresh it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12272) Miscellaneous improvements to FindWorkEffort screen
[
https://issues.apache.org/jira/browse/OFBIZ-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376434#comment-17376434
]
Nicolas Malin commented on OFBIZ-12272:
---
Hello [~dram],
I load the patch [^OFBIZ-12272-WithDynamism.patch] with your improvement and my
implementation of dynamism the FindWorkEffort Screen.
If you can have a look, I would be happy to have your feeling about that
> Miscellaneous improvements to FindWorkEffort screen
> ---
>
> Key: OFBIZ-12272
> URL: https://issues.apache.org/jira/browse/OFBIZ-12272
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Xin Wang
>Assignee: Nicolas Malin
>Priority: Major
> Attachments:
> 0001-Miscellaneous-improvements-to-FindWorkEffort-screen.patch,
> OFBIZ-12272-WithDynamism.patch
>
>
> Attached patch add miscellaneous improvements to FindWorkEffort screen:
> 1. Add "noConditionFind" field with value "Y" to FindWorkEffort screen to
> show results without click "Find" button
> 2. Change response type of deleteWorkEffort from "view" to
> "request-redirect", so that user can stay in FindWorkEffort screen after
> deletion
> 3. Remove "buttontext" widget style of workEffortId column, as text of this
> column also contains workEffortName, and it may be very long and even wrapped
> for two lines, "buttontext" does not fit it quite well
> 4. Change ListWorkEfforts from "form" to "grid", and enable "sort-field" for
> most of the columns (except "description")
> 5. Change "workEffortId" field text from "${workEffortName}
> [${workEffortId}]" to "[${workEffortId}] ${workEffortName}", to be consistent
> with the sort order, as this column is sort by workEffortId
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12272) Miscellaneous improvements to FindWorkEffort screen
[
https://issues.apache.org/jira/browse/OFBIZ-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12272:
--
Attachment: OFBIZ-12272-WithDynamism.patch
> Miscellaneous improvements to FindWorkEffort screen
> ---
>
> Key: OFBIZ-12272
> URL: https://issues.apache.org/jira/browse/OFBIZ-12272
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Xin Wang
>Assignee: Nicolas Malin
>Priority: Major
> Attachments:
> 0001-Miscellaneous-improvements-to-FindWorkEffort-screen.patch,
> OFBIZ-12272-WithDynamism.patch
>
>
> Attached patch add miscellaneous improvements to FindWorkEffort screen:
> 1. Add "noConditionFind" field with value "Y" to FindWorkEffort screen to
> show results without click "Find" button
> 2. Change response type of deleteWorkEffort from "view" to
> "request-redirect", so that user can stay in FindWorkEffort screen after
> deletion
> 3. Remove "buttontext" widget style of workEffortId column, as text of this
> column also contains workEffortName, and it may be very long and even wrapped
> for two lines, "buttontext" does not fit it quite well
> 4. Change ListWorkEfforts from "form" to "grid", and enable "sort-field" for
> most of the columns (except "description")
> 5. Change "workEffortId" field text from "${workEffortName}
> [${workEffortId}]" to "[${workEffortId}] ${workEffortName}", to be consistent
> with the sort order, as this column is sort by workEffortId
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12270) Add menu-container-style to calendar menu
[ https://issues.apache.org/jira/browse/OFBIZ-12270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376382#comment-17376382 ] Jacques Le Roux commented on OFBIZ-12270: - Thanks for the feedback Nicolas, Would you like to suggest something for this case? This would maybe help for future. > Add menu-container-style to calendar menu > - > > Key: OFBIZ-12270 > URL: https://issues.apache.org/jira/browse/OFBIZ-12270 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Xin Wang >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: 0001-Add-menu-container-style-to-calendar-menu.patch, > with-patch.png, without-patch.png > > > Attached patch try to make calendar menu more appealing in Helveticus theme, > Without this, menu items will be squeezed together. > > See this for example: > https://demo-trunk.ofbiz.apache.org/workeffort/control/calendar > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] PierreSmits commented on pull request #25: Improved: project - simplified uris (OFBIZ-11792)
PierreSmits commented on pull request #25: URL: https://github.com/apache/ofbiz-plugins/pull/25#issuecomment-875372945 @JacquesLeRoux 1 year after I would also suspect that some features would not be available. What do you suggest? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12270) Add menu-container-style to calendar menu
[ https://issues.apache.org/jira/browse/OFBIZ-12270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376357#comment-17376357 ] Nicolas Malin commented on OFBIZ-12270: --- Hello, I have a small remark for the future, it's not a big deal however I suggest to limited to set a style direclty on menu or form and try to extend them from a common-theme element. This help for the them creation. > Add menu-container-style to calendar menu > - > > Key: OFBIZ-12270 > URL: https://issues.apache.org/jira/browse/OFBIZ-12270 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Xin Wang >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: 0001-Add-menu-container-style-to-calendar-menu.patch, > with-patch.png, without-patch.png > > > Attached patch try to make calendar menu more appealing in Helveticus theme, > Without this, menu items will be squeezed together. > > See this for example: > https://demo-trunk.ofbiz.apache.org/workeffort/control/calendar > -- This message was sent by Atlassian Jira (v8.3.4#803005)
