[jira] [Closed] (OFBIZ-7536) Clean up commented out code
[ https://issues.apache.org/jira/browse/OFBIZ-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7536. -- Fix Version/s: Upcoming Branch Resolution: Done Thanks to Harsh and Eugen, we can close now > Clean up commented out code > --- > > Key: OFBIZ-7536 > URL: https://issues.apache.org/jira/browse/OFBIZ-7536 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Major > Fix For: Upcoming Branch > > > In our Re-Factor To-Do List one of the item is to clean up the commented out > code. > This is the parent ticket and I will further create sub tasks under it so > that we do not push large change in one commit. > This includes Java, Xml, Groovy and FTL files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-8042) Clean up commented out code in Java source for Webapp component
[ https://issues.apache.org/jira/browse/OFBIZ-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8042. -- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux (was: Harsh Vijaywargiya) Resolution: Done > Clean up commented out code in Java source for Webapp component > --- > > Key: OFBIZ-8042 > URL: https://issues.apache.org/jira/browse/OFBIZ-8042 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Clean up commented out code in Java source for Webapp component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8042) Clean up commented out code in Java source for Webapp component
[ https://issues.apache.org/jira/browse/OFBIZ-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377814#comment-17377814 ] ASF subversion and git services commented on OFBIZ-8042: Commit 19b1b8407ee9f43fe12cd7fc3b01861b87558d4e in ofbiz-framework's branch refs/heads/trunk from Ioan Eugen Stan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=19b1b84 ] Improved: Clean commented code from ofbiz webapp (#312) (OFBIZ-8042) > Clean up commented out code in Java source for Webapp component > --- > > Key: OFBIZ-8042 > URL: https://issues.apache.org/jira/browse/OFBIZ-8042 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Webapp component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-8043) Clean up commented out code in Java source for Webtools component
[ https://issues.apache.org/jira/browse/OFBIZ-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8043. -- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux (was: Harsh Vijaywargiya) Resolution: Done > Clean up commented out code in Java source for Webtools component > - > > Key: OFBIZ-8043 > URL: https://issues.apache.org/jira/browse/OFBIZ-8043 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Clean up commented out code in Java source for Webtools component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #312: Improved: Clean commented code from ofbiz webapp
JacquesLeRoux merged pull request #312: URL: https://github.com/apache/ofbiz-framework/pull/312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-8043) Clean up commented out code in Java source for Webtools component
[ https://issues.apache.org/jira/browse/OFBIZ-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377813#comment-17377813 ] ASF subversion and git services commented on OFBIZ-8043: Commit 293db968c0ff2c5313dfd66e7ac051b79941c7f6 in ofbiz-framework's branch refs/heads/trunk from Ioan Eugen Stan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=293db96 ] Improved: Clean commented code from ofbiz webtools (#313) (OFBIZ-8043) > Clean up commented out code in Java source for Webtools component > - > > Key: OFBIZ-8043 > URL: https://issues.apache.org/jira/browse/OFBIZ-8043 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Webtools component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #313: Improved: Clean commented code from ofbiz webtools
JacquesLeRoux merged pull request #313: URL: https://github.com/apache/ofbiz-framework/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-8040) Clean up commented out code in Java source for Service component
[ https://issues.apache.org/jira/browse/OFBIZ-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8040. -- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux (was: Harsh Vijaywargiya) Resolution: Done > Clean up commented out code in Java source for Service component > > > Key: OFBIZ-8040 > URL: https://issues.apache.org/jira/browse/OFBIZ-8040 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Clean up commented out code in Java source for Service component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] JacquesLeRoux commented on pull request #25: Improved: project - simplified uris (OFBIZ-11792)
JacquesLeRoux commented on pull request #25: URL: https://github.com/apache/ofbiz-plugins/pull/25#issuecomment-876608588 Pierre, I can't push this, and I guess others related PRs, when it breaks the navigation. Did you try, before creating the PR(s)? We need to address that 1st. It's not a chicken-egg issue. If you apply the patch/PR then coming from any other applications fails. This comes from themes. Look for <#assign thisURL = thisURL + "/control/main"> in *.ftl files you will see what I mean. So it should not be a big task to do that before doing all the rest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #313: Improved: Clean commented code from ofbiz webtools
sonarcloud[bot] commented on pull request #313: URL: https://github.com/apache/ofbiz-framework/pull/313#issuecomment-876598082 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=313=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=313=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=313=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=313=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=313=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=313=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=313=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=313=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=313=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=313=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=313=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=313=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=313) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=313=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=313=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-7536) Clean up commented out code
[ https://issues.apache.org/jira/browse/OFBIZ-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377505#comment-17377505 ] Ioan Eugen Stan commented on OFBIZ-7536: I added 2 PR's for last issues. We can close this once all of them are merged. > Clean up commented out code > --- > > Key: OFBIZ-7536 > URL: https://issues.apache.org/jira/browse/OFBIZ-7536 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Major > > In our Re-Factor To-Do List one of the item is to clean up the commented out > code. > This is the parent ticket and I will further create sub tasks under it so > that we do not push large change in one commit. > This includes Java, Xml, Groovy and FTL files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8042) Clean up commented out code in Java source for Webapp component
[ https://issues.apache.org/jira/browse/OFBIZ-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377503#comment-17377503 ] Ioan Eugen Stan commented on OFBIZ-8042: PR available https://github.com/apache/ofbiz-framework/pull/312 > Clean up commented out code in Java source for Webapp component > --- > > Key: OFBIZ-8042 > URL: https://issues.apache.org/jira/browse/OFBIZ-8042 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Webapp component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8043) Clean up commented out code in Java source for Webtools component
[ https://issues.apache.org/jira/browse/OFBIZ-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377502#comment-17377502 ] Ioan Eugen Stan commented on OFBIZ-8043: PR available https://github.com/apache/ofbiz-framework/pull/313/files > Clean up commented out code in Java source for Webtools component > - > > Key: OFBIZ-8043 > URL: https://issues.apache.org/jira/browse/OFBIZ-8043 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Webtools component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] ieugen opened a new pull request #313: Improved: Clean commented code from ofbiz webtools
ieugen opened a new pull request #313: URL: https://github.com/apache/ofbiz-framework/pull/313 Improved: Clean commented code from ofbiz webtools (OFBIZ-8043) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #312: Improved: Clean commented code from ofbiz webapp
sonarcloud[bot] commented on pull request #312: URL: https://github.com/apache/ofbiz-framework/pull/312#issuecomment-876371453 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=312=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=312=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=312=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=312=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=312=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=312=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=312=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=312=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=312=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=312=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=312=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=312=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=312) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=312=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=312=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #311: Improved: Clean commented code from ofbiz services
sonarcloud[bot] commented on pull request #311: URL: https://github.com/apache/ofbiz-framework/pull/311#issuecomment-876369101 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=311=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=311=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=311=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=311=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=311=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=311=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=311=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=311=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=311=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=311=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=311=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=311=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=311) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=311=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=311=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] ieugen opened a new pull request #312: Improved: Clean commented code from ofbiz webapp
ieugen opened a new pull request #312: URL: https://github.com/apache/ofbiz-framework/pull/312 Improved: Clean commented code from ofbiz webapp (OFBIZ-8042) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] ieugen closed pull request #311: Improved: Clean commented code from ofbiz services
ieugen closed pull request #311: URL: https://github.com/apache/ofbiz-framework/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] ieugen opened a new pull request #311: Improved: Clean commented code from ofbiz services
ieugen opened a new pull request #311: URL: https://github.com/apache/ofbiz-framework/pull/311 Improved: Clean commented code from ofbiz services (OFBIZ-8040) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-8040) Clean up commented out code in Java source for Service component
[ https://issues.apache.org/jira/browse/OFBIZ-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377180#comment-17377180 ] ASF subversion and git services commented on OFBIZ-8040: Commit cd40cc28a708880f646c442ffd2ae6b74248de66 in ofbiz-framework's branch refs/heads/trunk from Ioan Eugen Stan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=cd40cc2 ] Improved: Clean commented code from ofbiz services (#310) (OFBIZ-8040) > Clean up commented out code in Java source for Service component > > > Key: OFBIZ-8040 > URL: https://issues.apache.org/jira/browse/OFBIZ-8040 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Harsh Vijaywargiya >Assignee: Harsh Vijaywargiya >Priority: Minor > > Clean up commented out code in Java source for Service component -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #310: Improved: Clean commented code from ofbiz services
JacquesLeRoux merged pull request #310: URL: https://github.com/apache/ofbiz-framework/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] PierreSmits commented on pull request #25: Improved: project - simplified uris (OFBIZ-11792)
PierreSmits commented on pull request #25: URL: https://github.com/apache/ofbiz-plugins/pull/25#issuecomment-876168763 Jacques, Addressing the other issue with another ticket (and a subsequent pull request/patch file - for those still working with SVN, yay) while not resolving the existing sub-tickets under OFBIZ-11791 seems to be leading to the same circular, chicken-egg discussion that have been there on other improvement aspects in the past. And for some these changes are either too big, too small, too complex or too mediocre to collaborate on (take your pick). All in all, though desired (see user ml), not moving forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] PierreSmits commented on pull request #25: Improved: project - simplified uris (OFBIZ-11792)
PierreSmits commented on pull request #25: URL: https://github.com/apache/ofbiz-plugins/pull/25#issuecomment-876164871 Jacques, Regarding the off-track discussion, it seems to me that you already addressed it (together with INFRA) relating to another issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
