[jira] [Commented] (OFBIZ-12360) Find TenantID in Plug-in
[ https://issues.apache.org/jira/browse/OFBIZ-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437044#comment-17437044 ] Joe Nicke commented on OFBIZ-12360: --- Let me add that I use the tenant ID (robin) to retrieve the token used in the URL. This has to run server-side. get 127.0.0.1:8077/kernel/saaslink/session?tenantname=robin (internal API) returns token. Using the tenantid and token, here is what I call in the Webapp. "https://surpaasops.com/surpaas/r/CorentPOC/h/XMTApps/t/robin?token=89fc4edd-5abe-421d-9cba-98c85596019f";; > Find TenantID in Plug-in > > > Key: OFBIZ-12360 > URL: https://issues.apache.org/jira/browse/OFBIZ-12360 > Project: OFBiz > Issue Type: Wish > Components: ALL PLUGINS >Affects Versions: 18.12.01 > Environment: Windows Server 2019 >Reporter: Joe Nicke >Priority: Minor > Fix For: 18.12.01 > > Attachments: subscription.ftl > > > I created a plugin that calls a tenant specific url. How / where can I get > the tenantid as a varible. A Groovy script? I don't see this listed as a > global var. > Background: We are integrating OFBiz with our SaaSify platform. This link > pulls up the tenant's subscription managment page (upgrade, pay, view > invoices, etc.). > https://www.corenttech.com/one-pager/SurPaaS_SaaSify_Product.html > I attched the FTL file from webapp. It is quite simple: I need to replace > "robin" with the value of the curent tenantid. > Any guidance would be appreciated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12360) Find TenantID in Plug-in
Joe Nicke created OFBIZ-12360: - Summary: Find TenantID in Plug-in Key: OFBIZ-12360 URL: https://issues.apache.org/jira/browse/OFBIZ-12360 Project: OFBiz Issue Type: Wish Components: ALL PLUGINS Affects Versions: 18.12.01 Environment: Windows Server 2019 Reporter: Joe Nicke Fix For: 18.12.01 Attachments: subscription.ftl I created a plugin that calls a tenant specific url. How / where can I get the tenantid as a varible. A Groovy script? I don't see this listed as a global var. Background: We are integrating OFBiz with our SaaSify platform. This link pulls up the tenant's subscription managment page (upgrade, pay, view invoices, etc.). https://www.corenttech.com/one-pager/SurPaaS_SaaSify_Product.html I attched the FTL file from webapp. It is quite simple: I need to replace "robin" with the value of the curent tenantid. Any guidance would be appreciated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #326: Fixed: Quote item quantity field not visable (OFBIZ 12357)
JacquesLeRoux merged pull request #326: URL: https://github.com/apache/ofbiz-framework/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-12359) ProductFacility on ecommerce listing product issue
[ https://issues.apache.org/jira/browse/OFBIZ-12359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12359: - Labels: inventory stock (was: ) > ProductFacility on ecommerce listing product issue > -- > > Key: OFBIZ-12359 > URL: https://issues.apache.org/jira/browse/OFBIZ-12359 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, product/catalog >Affects Versions: Trunk, 17.12.08, 18.12.01 > Environment: OS: Linux/Ubuntu 18.04 LTS > Java 8 > Apache OFBiz r17.12.06 > Also affects older versions like r.13.07.03 >Reporter: Giulio Speri >Assignee: Giulio Speri >Priority: Major > Labels: inventory, stock > > Possible issue in the ecommerce listing of products related to the > ProductFacility entity and the filtering of out of stock products. > > Here's the context: > - an ecommerce site where products are configured as a virtual-variant > relationship. > - a virtual product (parent) has color and size features associated as > selectable, and its variants are all the combinations of colors and sizes. > - in such a configuration InventoryItem records are registered for variant > products (the actual sold products) and not for virtual products. > - the product store is configured to not show out of stock products. > - a record of ProductFacility is created for each product variant where its > lastInventoryCount is automatically updated as soon as availability are > imported/created (through PHYSICAL INVENTORY); > - virtual products are associated to some ProductCategories; > > +Issue+: > Products are not shown in listing also if they have stock availability. > > +Issue details:+ > Listing of products is done through the screen > "_CatalogScreens.xml#categorydetail_" and the _CategoryDetail.groovy_ script > is used to retrieve the list of products to show. > > In the groovy script the service responsible to get the product category > members to show is _getProductCategoryAndLimitedMembers,_ which checks and > filters out of stock products (if ProductStore is configured to do so). > > Filtering out of stock products is done using > _ProductWorker.java#filterOutOfStockProducts_ method, that sums up all the > lastInventoryCount (in all the facilities) of each category member and if sum > is GT 0 the (virtual) product is kept and shown in listing. > > The lastInventoryCount field in the table ProductFacility is updated through > the eeca service _setLastInventoryCount_ on create/update on entity > InventoryItemDetail. > This service works only on the product on which a stock move is committed (in > my case a specific product variant): it's (virtual) parent is never > considered. > > That behaviour, in addition to the fact that filterOutOfStock method works on > the category members that are the virtual parents, leads to products to not > be shown in listing also if they have stock availability. > > +Possible solutions:+ > From my point of view there are two ways to fix this. > > 1) add the handling of lastInventoryCount on virtual parents to the service > setLastInventoryCount; the lastInventoryCount of the parent should be the sum > of all its variant in the same facility, and each time a variant is modified, > the related parent should be modified too. > > 2) add the handling of virtual products in the > ProductWorker.java#_filterOutOfStockProducts_: here when a vritual product > category member is processed, all its variant should be retrieved and their > lastInventoryCount added up through all facilities. > Only is the sum of all the variants in all the facilities is GT 0, then we > can keep and show the virtual product. > > +Considerations:+ > After a bit of research within whole OFBiz project (R17.12.06) the > lastInventoryCount field has a quite limited direct usage (basically only for > ecommerce scopes). > I think solution 2) is better, because I think that the ProductFacility > entity should not contain record for "virtual" products (products that > physically won't be sold, since you will sell a variant of it; for the same > reason virtual products should not have InventoryItem records associated). > > I think that solution 1) instead is not so clean and force to adopt inventory > item concepts also for virtual products, that in my opinion it does not make > too much sense. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12357) Quote: Quote item quantity field not visable
[ https://issues.apache.org/jira/browse/OFBIZ-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12357: - Component/s: order > Quote: Quote item quantity field not visable > > > Key: OFBIZ-12357 > URL: https://issues.apache.org/jira/browse/OFBIZ-12357 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, 17.12.08, 18.12.01 >Reporter: Justine Nowak >Assignee: Pierre Smits >Priority: Major > Attachments: Screen Shot 2021-10-31 at 11.18.51 AM.png > > > When I go to enter a quote item, the quantity field is not showing. Causing > the quote to display an order item with no quantity resulting in $0.00 > subtotal pricing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12357) Quote: Quote item quantity field not visable
[ https://issues.apache.org/jira/browse/OFBIZ-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12357: - Labels: quote quote-item (was: ) > Quote: Quote item quantity field not visable > > > Key: OFBIZ-12357 > URL: https://issues.apache.org/jira/browse/OFBIZ-12357 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, 17.12.08, 18.12.01 >Reporter: Justine Nowak >Assignee: Pierre Smits >Priority: Major > Labels: quote, quote-item > Attachments: Screen Shot 2021-10-31 at 11.18.51 AM.png > > > When I go to enter a quote item, the quantity field is not showing. Causing > the quote to display an order item with no quantity resulting in $0.00 > subtotal pricing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #326: Fixed: Quote item quantity field not visable (OFBIZ 12357)
sonarcloud[bot] commented on pull request #326: URL: https://github.com/apache/ofbiz-framework/pull/326#issuecomment-956325201 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=326&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=326) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=326&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=326&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-12357) Quote: Quote item quantity field not visable
[ https://issues.apache.org/jira/browse/OFBIZ-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12357: - Affects Version/s: 17.12.08 18.12.01 > Quote: Quote item quantity field not visable > > > Key: OFBIZ-12357 > URL: https://issues.apache.org/jira/browse/OFBIZ-12357 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.08, 18.12.01 >Reporter: Justine Nowak >Assignee: Pierre Smits >Priority: Major > Fix For: 17.12.08, 18.12.01 > > Attachments: Screen Shot 2021-10-31 at 11.18.51 AM.png > > > When I go to enter a quote item, the quantity field is not showing. Causing > the quote to display an order item with no quantity resulting in $0.00 > subtotal pricing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12357) Quote: Quote item quantity field not visable
[ https://issues.apache.org/jira/browse/OFBIZ-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12357: - Fix Version/s: (was: 17.12.08) (was: 18.12.01) > Quote: Quote item quantity field not visable > > > Key: OFBIZ-12357 > URL: https://issues.apache.org/jira/browse/OFBIZ-12357 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, 17.12.08, 18.12.01 >Reporter: Justine Nowak >Assignee: Pierre Smits >Priority: Major > Attachments: Screen Shot 2021-10-31 at 11.18.51 AM.png > > > When I go to enter a quote item, the quantity field is not showing. Causing > the quote to display an order item with no quantity resulting in $0.00 > subtotal pricing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #326: Fixed: Quote item quantity field not visable (OFBIZ 12357)
PierreSmits opened a new pull request #326: URL: https://github.com/apache/ofbiz-framework/pull/326 removed: display attribute -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12357) Quote: Quote item quantity field not visable
[ https://issues.apache.org/jira/browse/OFBIZ-12357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-12357: Assignee: Pierre Smits > Quote: Quote item quantity field not visable > > > Key: OFBIZ-12357 > URL: https://issues.apache.org/jira/browse/OFBIZ-12357 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Justine Nowak >Assignee: Pierre Smits >Priority: Major > Fix For: 17.12.08, 18.12.01 > > Attachments: Screen Shot 2021-10-31 at 11.18.51 AM.png > > > When I go to enter a quote item, the quantity field is not showing. Causing > the quote to display an order item with no quantity resulting in $0.00 > subtotal pricing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12359) ProductFacility on ecommerce listing product issue
Giulio Speri created OFBIZ-12359: Summary: ProductFacility on ecommerce listing product issue Key: OFBIZ-12359 URL: https://issues.apache.org/jira/browse/OFBIZ-12359 Project: OFBiz Issue Type: Bug Components: ecommerce, product/catalog Affects Versions: 18.12.01, 17.12.08, Trunk Environment: OS: Linux/Ubuntu 18.04 LTS Java 8 Apache OFBiz r17.12.06 Also affects older versions like r.13.07.03 Reporter: Giulio Speri Assignee: Giulio Speri Possible issue in the ecommerce listing of products related to the ProductFacility entity and the filtering of out of stock products. Here's the context: - an ecommerce site where products are configured as a virtual-variant relationship. - a virtual product (parent) has color and size features associated as selectable, and its variants are all the combinations of colors and sizes. - in such a configuration InventoryItem records are registered for variant products (the actual sold products) and not for virtual products. - the product store is configured to not show out of stock products. - a record of ProductFacility is created for each product variant where its lastInventoryCount is automatically updated as soon as availability are imported/created (through PHYSICAL INVENTORY); - virtual products are associated to some ProductCategories; +Issue+: Products are not shown in listing also if they have stock availability. +Issue details:+ Listing of products is done through the screen "_CatalogScreens.xml#categorydetail_" and the _CategoryDetail.groovy_ script is used to retrieve the list of products to show. In the groovy script the service responsible to get the product category members to show is _getProductCategoryAndLimitedMembers,_ which checks and filters out of stock products (if ProductStore is configured to do so). Filtering out of stock products is done using _ProductWorker.java#filterOutOfStockProducts_ method, that sums up all the lastInventoryCount (in all the facilities) of each category member and if sum is GT 0 the (virtual) product is kept and shown in listing. The lastInventoryCount field in the table ProductFacility is updated through the eeca service _setLastInventoryCount_ on create/update on entity InventoryItemDetail. This service works only on the product on which a stock move is committed (in my case a specific product variant): it's (virtual) parent is never considered. That behaviour, in addition to the fact that filterOutOfStock method works on the category members that are the virtual parents, leads to products to not be shown in listing also if they have stock availability. +Possible solutions:+ >From my point of view there are two ways to fix this. 1) add the handling of lastInventoryCount on virtual parents to the service setLastInventoryCount; the lastInventoryCount of the parent should be the sum of all its variant in the same facility, and each time a variant is modified, the related parent should be modified too. 2) add the handling of virtual products in the ProductWorker.java#_filterOutOfStockProducts_: here when a vritual product category member is processed, all its variant should be retrieved and their lastInventoryCount added up through all facilities. Only is the sum of all the variants in all the facilities is GT 0, then we can keep and show the virtual product. +Considerations:+ After a bit of research within whole OFBiz project (R17.12.06) the lastInventoryCount field has a quite limited direct usage (basically only for ecommerce scopes). I think solution 2) is better, because I think that the ProductFacility entity should not contain record for "virtual" products (products that physically won't be sold, since you will sell a variant of it; for the same reason virtual products should not have InventoryItem records associated). I think that solution 1) instead is not so clean and force to adopt inventory item concepts also for virtual products, that in my opinion it does not make too much sense. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-12354) Removes useless redundant data
[
https://issues.apache.org/jira/browse/OFBIZ-12354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits reopened OFBIZ-12354:
--
Assignee: (was: Jacques Le Roux)
> Removes useless redundant data
> --
>
> Key: OFBIZ-12354
> URL: https://issues.apache.org/jira/browse/OFBIZ-12354
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> As mentionned in OFBIZ-5980:
> {quote}
> I note pre-existing redundancies (not of your work) like
> And there are other such cases. Now that the data are in commonext, the
> applications not separable and the plugins dependent of data in commonext, we
> can easily remove the redundancies.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12354) Removes useless redundant data
[
https://issues.apache.org/jira/browse/OFBIZ-12354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436883#comment-17436883
]
Pierre Smits commented on OFBIZ-12354:
--
It is a pity, Jacques, that deem removing redundancies not worth the effort.
It reminds me of people not willing to pick up (one or two) littered plastic
bits from the environment they want to enjoy. It also reminds of some words I
once read about not caring enough, because he felt himself (as a committer)
being too good do menial work (like fixing typos, removing unnecessary
comments, etc. from the code base).
These small tickets are an excellent way of starting to do more as a newbee.
And we should appreciate this kind of work being done.
> Removes useless redundant data
> --
>
> Key: OFBIZ-12354
> URL: https://issues.apache.org/jira/browse/OFBIZ-12354
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> As mentionned in OFBIZ-5980:
> {quote}
> I note pre-existing redundancies (not of your work) like
> And there are other such cases. Now that the data are in commonext, the
> applications not separable and the plugins dependent of data in commonext, we
> can easily remove the redundancies.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436880#comment-17436880 ] Pierre Smits commented on OFBIZ-5980: - ありがとう、ジャック for assisting me in getting this improvement in the code base > Have the ability to revoke (expire) roles of a party > > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: roles > Fix For: Upcoming Branch > > > Currently it only possible to delete a role. > Which can lead to potential error messages, when a particular role is > associated with records where the roleTypeId is used as a foreign key in the > entity-model/database and the user tries to delete that role from the list. > In order to avoid such, it is better to revoke the PartyRole record by > setting an expiration date (end date) on the record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-5980: --- Assignee: Pierre Smits (was: Jacques Le Roux) > Have the ability to revoke (expire) roles of a party > > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: roles > Fix For: Upcoming Branch > > > Currently it only possible to delete a role. > Which can lead to potential error messages, when a particular role is > associated with records where the roleTypeId is used as a foreign key in the > entity-model/database and the user tries to delete that role from the list. > In order to avoid such, it is better to revoke the PartyRole record by > setting an expiration date (end date) on the record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12354) Removes useless redundant data
[
https://issues.apache.org/jira/browse/OFBIZ-12354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-12354.
---
Fix Version/s: (was: Upcoming Branch)
Assignee: Jacques Le Roux
Resolution: Won't Do
I decided it's too much work not worth the effort
> Removes useless redundant data
> --
>
> Key: OFBIZ-12354
> URL: https://issues.apache.org/jira/browse/OFBIZ-12354
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> As mentionned in OFBIZ-5980:
> {quote}
> I note pre-existing redundancies (not of your work) like
> And there are other such cases. Now that the data are in commonext, the
> applications not separable and the plugins dependent of data in commonext, we
> can easily remove the redundancies.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436775#comment-17436775 ] ASF subversion and git services commented on OFBIZ-5980: Commit 46f7ee91d3355b3e10a5b2732797591c748a27dd in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=46f7ee9 ] Improved: Have the ability to revoke (expire) roles of a party (OFBIZ-5980) Currently it only possible to delete a role. That can lead to potential error messages, when a particular role is associated with records where the roleTypeId is used as a foreign key in the entity-model/database and the user tries to delete that role from the list. In order to avoid such, it is better to revoke the PartyRole record by setting an expiration date (end date) on the record. Thanks: Pierre Smits > Have the ability to revoke (expire) roles of a party > > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: roles > > Currently it only possible to delete a role. > Which can lead to potential error messages, when a particular role is > associated with records where the roleTypeId is used as a foreign key in the > entity-model/database and the user tries to delete that role from the list. > In order to avoid such, it is better to revoke the PartyRole record by > setting an expiration date (end date) on the record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5980. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Have the ability to revoke (expire) roles of a party > > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: roles > Fix For: Upcoming Branch > > > Currently it only possible to delete a role. > Which can lead to potential error messages, when a particular role is > associated with records where the roleTypeId is used as a foreign key in the > entity-model/database and the user tries to delete that role from the list. > In order to avoid such, it is better to revoke the PartyRole record by > setting an expiration date (end date) on the record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12358) As a user I want to be able to select 1, multiple or all Roles of a party to revoke them
[ https://issues.apache.org/jira/browse/OFBIZ-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12358: - Labels: roles (was: ) > As a user I want to be able to select 1, multiple or all Roles of a party to > revoke them > > > Key: OFBIZ-12358 > URL: https://issues.apache.org/jira/browse/OFBIZ-12358 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Labels: roles > > Following up on OFBIZ-5980, the list of roles associated with a party can > grow big. > If a user then has to go through the process of individually setting the > expiration date for each PartyRole record (and make that effective), the > process can take quite some time. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12358) As a user I want to be able to select 1, multiple or all Roles of a party to revoke them
Pierre Smits created OFBIZ-12358: Summary: As a user I want to be able to select 1, multiple or all Roles of a party to revoke them Key: OFBIZ-12358 URL: https://issues.apache.org/jira/browse/OFBIZ-12358 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: Trunk Reporter: Pierre Smits Following up on OFBIZ-5980, the list of roles associated with a party can grow big. If a user then has to go through the process of individually setting the expiration date for each PartyRole record (and make that effective), the process can take quite some time. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-5980: Description: Currently it only possible to delete a role. Which can lead to potential error messages, when a particular role is associated with records where the roleTypeId is used as a foreign key in the entity-model/database and the user tries to delete that role from the list. In order to avoid such, it is better to revoke the PartyRole record by setting an expiration date (end date) on the record. was: The list of roles of a party can grow enormously. Currently it only possible to revoke/expire one role at a time. In order to improve the UX we should enable to select multiple or all roles so that all selected roles are revoked or expired in one go. > Have the ability to revoke (expire) roles of a party > > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: roles > > Currently it only possible to delete a role. > Which can lead to potential error messages, when a particular role is > associated with records where the roleTypeId is used as a foreign key in the > entity-model/database and the user tries to delete that role from the list. > In order to avoid such, it is better to revoke the PartyRole record by > setting an expiration date (end date) on the record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-5980) Have the ability to revoke (expire) multipe roles of a party in one action
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436718#comment-17436718 ] Pierre Smits edited comment on OFBIZ-5980 at 11/1/21, 9:56 AM: --- Bore da Jacques, As you gathered from the changes is that we don't delete anymore (that is the new thing there). And things like checking existing roles when a user accidentally selects a role already in the list and adding that. To make this PR go in I will adjust the title and description. And I will follow-up with a new ticket for the multi-select (so that it is up to the user to select either 1, multiple or all), which will require new development iterations. Can you live with this approach? was (Author: pfm.smits): Bore da Jacques, As you gathered from the changes is that we don't delete anymore (that is the new thing there). To make this PR go in I will adjust the title and description. And I will follow-up with a new ticket for the multi-select (so that it is up to the user to select either 1, multiple or all), which will require new development iterations. Can you live with this approach? > Have the ability to revoke (expire) multipe roles of a party in one action > -- > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: roles > > The list of roles of a party can grow enormously. > Currently it only possible to revoke/expire one role at a time. > In order to improve the UX we should enable to select multiple or all roles > so that all selected roles are revoked or expired in one go. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-5980: Summary: Have the ability to revoke (expire) roles of a party (was: Have the ability to revoke (expire) multipe roles of a party in one action) > Have the ability to revoke (expire) roles of a party > > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: roles > > The list of roles of a party can grow enormously. > Currently it only possible to revoke/expire one role at a time. > In order to improve the UX we should enable to select multiple or all roles > so that all selected roles are revoked or expired in one go. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) multipe roles of a party in one action
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436719#comment-17436719 ] Jacques Le Roux commented on OFBIZ-5980: +1 > Have the ability to revoke (expire) multipe roles of a party in one action > -- > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: roles > > The list of roles of a party can grow enormously. > Currently it only possible to revoke/expire one role at a time. > In order to improve the UX we should enable to select multiple or all roles > so that all selected roles are revoked or expired in one go. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-5980) Have the ability to revoke (expire) multipe roles of a party in one action
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-5980: -- Assignee: Jacques Le Roux > Have the ability to revoke (expire) multipe roles of a party in one action > -- > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: roles > > The list of roles of a party can grow enormously. > Currently it only possible to revoke/expire one role at a time. > In order to improve the UX we should enable to select multiple or all roles > so that all selected roles are revoked or expired in one go. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) multipe roles of a party in one action
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436718#comment-17436718 ] Pierre Smits commented on OFBIZ-5980: - Bore da Jacques, As you gathered from the changes is that we don't delete anymore (that is the new thing there). To make this PR go in I will adjust the title and description. And I will follow-up with a new ticket for the multi-select (so that it is up to the user to select either 1, multiple or all), which will require new development iterations. Can you live with this approach? > Have the ability to revoke (expire) multipe roles of a party in one action > -- > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Labels: roles > > The list of roles of a party can grow enormously. > Currently it only possible to revoke/expire one role at a time. > In order to improve the UX we should enable to select multiple or all roles > so that all selected roles are revoked or expired in one go. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12356) Try to reduce "Incomplete string escaping or encoding branch" issues reported by CodeQL
[
https://issues.apache.org/jira/browse/OFBIZ-12356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436714#comment-17436714
]
Jacques Le Roux commented on OFBIZ-12356:
-
Thanks for the info. I don't think it's possible. Because it's about security,
sorry forgot that.
> Try to reduce "Incomplete string escaping or encoding branch" issues reported
> by CodeQL
> ---
>
> Key: OFBIZ-12356
> URL: https://issues.apache.org/jira/browse/OFBIZ-12356
> Project: OFBiz
> Issue Type: Improvement
> Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> At
> https://github.com/apache/ofbiz-framework/security/code-scanning?query=is%3AIncomplete+string+escaping+or+encoding+branch%3Atrunk+severity%3Ahigh
> GH CodeQL reports 556 "Incomplete string escaping or encoding branch" issues
> (there are 588 issues at all).
> Most of them are in jQuery-UI but not only:
> {quote}
> Incomplete string escaping or encoding
> (Library)
> themes/common-theme/webapp/common/js/jquery/ui/jquery-ui-1.12.1.js:17591 •
> {quote}
> Some are reported inside jQuery itself:
> {quote}
> Incomplete string escaping or encoding
> themes/common-theme/webapp/common/js/jquery/plugins/jsTree/jquery.jstree.js:2961
> •
> {quote}
> So this only an attempt to clarify among the 23 pages(!) reported by
> upgrading jQuery-UI to 1.13.0.
> While working on this I crossed an issue related to element.form() that is
> now [element._form() in jQuery-UI
> 1.13.0|https://jqueryui.com/changelog/1.13.0/#ui-core]. I think it appears
> only in OfbizUtil.js because it's loaded after jQuery-UI.
> I also tried to load jQuery-UI with npmInstall but unfortunately
> https://jqueryui.com/upgrade-guide/1.12/#official-package-on-npm (ie
> jquery-ui.js & jquery-ui-min.js)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12356) Try to reduce "Incomplete string escaping or encoding branch" issues reported by CodeQL
[
https://issues.apache.org/jira/browse/OFBIZ-12356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436712#comment-17436712
]
Pierre Smits commented on OFBIZ-12356:
--
Hi Jacques,
Those uri regarding security/code-scanning are not available to contributors.
Can we correct this?
> Try to reduce "Incomplete string escaping or encoding branch" issues reported
> by CodeQL
> ---
>
> Key: OFBIZ-12356
> URL: https://issues.apache.org/jira/browse/OFBIZ-12356
> Project: OFBiz
> Issue Type: Improvement
> Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> At
> https://github.com/apache/ofbiz-framework/security/code-scanning?query=is%3AIncomplete+string+escaping+or+encoding+branch%3Atrunk+severity%3Ahigh
> GH CodeQL reports 556 "Incomplete string escaping or encoding branch" issues
> (there are 588 issues at all).
> Most of them are in jQuery-UI but not only:
> {quote}
> Incomplete string escaping or encoding
> (Library)
> themes/common-theme/webapp/common/js/jquery/ui/jquery-ui-1.12.1.js:17591 •
> {quote}
> Some are reported inside jQuery itself:
> {quote}
> Incomplete string escaping or encoding
> themes/common-theme/webapp/common/js/jquery/plugins/jsTree/jquery.jstree.js:2961
> •
> {quote}
> So this only an attempt to clarify among the 23 pages(!) reported by
> upgrading jQuery-UI to 1.13.0.
> While working on this I crossed an issue related to element.form() that is
> now [element._form() in jQuery-UI
> 1.13.0|https://jqueryui.com/changelog/1.13.0/#ui-core]. I think it appears
> only in OfbizUtil.js because it's loaded after jQuery-UI.
> I also tried to load jQuery-UI with npmInstall but unfortunately
> https://jqueryui.com/upgrade-guide/1.12/#official-package-on-npm (ie
> jquery-ui.js & jquery-ui-min.js)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-5980) Have the ability to revoke (expire) multipe roles of a party in one action
[ https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436711#comment-17436711 ] Jacques Le Roux commented on OFBIZ-5980: Hi Pierre, You don't need to teach me about the squash and merge feature. With the team we already discussed about it many times on dev ML . It's just that the GH patch feature has no squash option.- What you did not want to get is that I need to test before pushing. The only ways were to create a patch or a PR with a sole commit. PR 325 is OK. I just tested and it works well. I have just a question. The issue is about expiring multipe roles of a party in one action. How can I do that? At partymgr/control/viewroles I see only one "Expire" button by line and no way to (eg) check lines, with a "global" button for expiring those checked lines. Do I miss something? I don't see anything new about it. Is there another alredy existing location for that? > Have the ability to revoke (expire) multipe roles of a party in one action > -- > > Key: OFBIZ-5980 > URL: https://issues.apache.org/jira/browse/OFBIZ-5980 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Labels: roles > > The list of roles of a party can grow enormously. > Currently it only possible to revoke/expire one role at a time. > In order to improve the UX we should enable to select multiple or all roles > so that all selected roles are revoked or expired in one go. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12345) Add state/provinces for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436706#comment-17436706 ] Pierre Smits commented on OFBIZ-12345: -- Good morning Ioan, You have to ask yourself this: will the breakdown risk be if not addressed (meaning: not included in the address)? Will mail not be delivered? Will a package not arrive at the correct door? One thing I could think of is that it is valuable for BI purposes, but there I can think of work-arounds too. Just my 2 cents > Add state/provinces for Romania > --- > > Key: OFBIZ-12345 > URL: https://issues.apache.org/jira/browse/OFBIZ-12345 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Priority: Major > > When creating new contact information we should be able to select the state / > provinces in Romania > Right now I get : > |State/Province|No States/Provinces exist | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12345) Add state/provinces for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436700#comment-17436700 ] Ioan Eugen Stan commented on OFBIZ-12345: - I created some data and imported it but noticed the select menu for state province does not change. Romania does not have states or provinces but we use counties as an administrative subdivision. If I prepare an OFBIz installation for Romania State / Province will always be empty . An alternative would be to change that for Counties or to add counties to the list: State / Province / County and do the following algorithm: * Load states and provinces. * If the state/province list is empty - load counties Any recommendations on how to address this ? > Add state/provinces for Romania > --- > > Key: OFBIZ-12345 > URL: https://issues.apache.org/jira/browse/OFBIZ-12345 > Project: OFBiz > Issue Type: Sub-task >Reporter: Ioan Eugen Stan >Priority: Major > > When creating new contact information we should be able to select the state / > provinces in Romania > Right now I get : > |State/Province|No States/Provinces exist | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12244) Code clarity - separate Groovy implementations vs test cases in org.apache.ofbiz.order
[ https://issues.apache.org/jira/browse/OFBIZ-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12244: - Labels: test (was: ) > Code clarity - separate Groovy implementations vs test cases in > org.apache.ofbiz.order > -- > > Key: OFBIZ-12244 > URL: https://issues.apache.org/jira/browse/OFBIZ-12244 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Carsten Schinzer >Assignee: Carsten Schinzer >Priority: Minor > Labels: test > Fix For: Trunk > > Attachments: ofbiz-12244.patch > > > 1. File move: > 1.a Create package org.apache.ofbiz.order.test in path > ofbiz-framework/applications/order/src/main > 1.b Move the following files to the new package: > * OrderRequirementTests > * OrderReturnTests > * OrderTests > * QuoteTests > * TestCustRequestPermissionCheck > 2. Apply attached patch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-12356) Try to reduce "Incomplete string escaping or encoding branch" issues reported by CodeQL
[
https://issues.apache.org/jira/browse/OFBIZ-12356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-12356:
-
> Try to reduce "Incomplete string escaping or encoding branch" issues reported
> by CodeQL
> ---
>
> Key: OFBIZ-12356
> URL: https://issues.apache.org/jira/browse/OFBIZ-12356
> Project: OFBiz
> Issue Type: Improvement
> Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> At
> https://github.com/apache/ofbiz-framework/security/code-scanning?query=is%3AIncomplete+string+escaping+or+encoding+branch%3Atrunk+severity%3Ahigh
> GH CodeQL reports 556 "Incomplete string escaping or encoding branch" issues
> (there are 588 issues at all).
> Most of them are in jQuery-UI but not only:
> {quote}
> Incomplete string escaping or encoding
> (Library)
> themes/common-theme/webapp/common/js/jquery/ui/jquery-ui-1.12.1.js:17591 •
> {quote}
> Some are reported inside jQuery itself:
> {quote}
> Incomplete string escaping or encoding
> themes/common-theme/webapp/common/js/jquery/plugins/jsTree/jquery.jstree.js:2961
> •
> {quote}
> So this only an attempt to clarify among the 23 pages(!) reported by
> upgrading jQuery-UI to 1.13.0.
> While working on this I crossed an issue related to element.form() that is
> now [element._form() in jQuery-UI
> 1.13.0|https://jqueryui.com/changelog/1.13.0/#ui-core]. I think it appears
> only in OfbizUtil.js because it's loaded after jQuery-UI.
> I also tried to load jQuery-UI with npmInstall but unfortunately
> https://jqueryui.com/upgrade-guide/1.12/#official-package-on-npm (ie
> jquery-ui.js & jquery-ui-min.js)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12356) Try to reduce "Incomplete string escaping or encoding branch" issues reported by CodeQL
[
https://issues.apache.org/jira/browse/OFBIZ-12356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436658#comment-17436658
]
Jacques Le Roux commented on OFBIZ-12356:
-
Ha, actually I filtered by using "Incomplete string escaping or encoding" (ie
with quotes) I saw only 181 such remaining (still 8 pages). It's only 3rd party
libs, mostly (if not all) jQuery. I have closed almost all (577) the reporting
of 3rd party libs issues. We can't do anything about them anyway. Note that
they are closed so can still be reviewed.
Remains 12 cases that we need to look at closer:
https://github.com/apache/ofbiz-framework/security/code-scanning. As you can
see only 3 are in OFBiz js code.
> Try to reduce "Incomplete string escaping or encoding branch" issues reported
> by CodeQL
> ---
>
> Key: OFBIZ-12356
> URL: https://issues.apache.org/jira/browse/OFBIZ-12356
> Project: OFBiz
> Issue Type: Improvement
> Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> At
> https://github.com/apache/ofbiz-framework/security/code-scanning?query=is%3AIncomplete+string+escaping+or+encoding+branch%3Atrunk+severity%3Ahigh
> GH CodeQL reports 556 "Incomplete string escaping or encoding branch" issues
> (there are 588 issues at all).
> Most of them are in jQuery-UI but not only:
> {quote}
> Incomplete string escaping or encoding
> (Library)
> themes/common-theme/webapp/common/js/jquery/ui/jquery-ui-1.12.1.js:17591 •
> {quote}
> Some are reported inside jQuery itself:
> {quote}
> Incomplete string escaping or encoding
> themes/common-theme/webapp/common/js/jquery/plugins/jsTree/jquery.jstree.js:2961
> •
> {quote}
> So this only an attempt to clarify among the 23 pages(!) reported by
> upgrading jQuery-UI to 1.13.0.
> While working on this I crossed an issue related to element.form() that is
> now [element._form() in jQuery-UI
> 1.13.0|https://jqueryui.com/changelog/1.13.0/#ui-core]. I think it appears
> only in OfbizUtil.js because it's loaded after jQuery-UI.
> I also tried to load jQuery-UI with npmInstall but unfortunately
> https://jqueryui.com/upgrade-guide/1.12/#official-package-on-npm (ie
> jquery-ui.js & jquery-ui-min.js)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
