[jira] [Comment Edited] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467124#comment-17467124 ] Jacques Le Roux edited comment on OFBIZ-12456 at 12/31/21, 7:12 AM: Also the builds results are now available here: https://nightlies.apache.org/ofbiz/ was (Author: jacques.le.roux): Also the builds results are available here: https://nightlies.apache.org/ofbiz/ > Migrate Ofbiz bb 0.8 config to 3.2 > -- > > Key: OFBIZ-12456 > URL: https://issues.apache.org/jira/browse/OFBIZ-12456 > Project: OFBiz > Issue Type: Task > Components: BuildBot >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > > This is a clone of INFRA-22279 that says: > bq. Migrate all Ofbiz configs from ci.apache.org to c2.apache.org upgrading > the config from 0.8 to 3.2 and changing uploads of docs to go to > nightlies.apache.org/ofbiz instead of ci.apache.org/projects/ofbiz . > Currently we have an issue with XMLRPC tests with BuildBot. I believe it's > because the new BB config does not allow HTTP and/or the port 8080. > For more information see https://markmail.org/message/z6qfhcb2xnlqs2ji -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467124#comment-17467124 ] Jacques Le Roux commented on OFBIZ-12456: - Also the builds results are available here: https://nightlies.apache.org/ofbiz/ > Migrate Ofbiz bb 0.8 config to 3.2 > -- > > Key: OFBIZ-12456 > URL: https://issues.apache.org/jira/browse/OFBIZ-12456 > Project: OFBiz > Issue Type: Task > Components: BuildBot >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > > This is a clone of INFRA-22279 that says: > bq. Migrate all Ofbiz configs from ci.apache.org to c2.apache.org upgrading > the config from 0.8 to 3.2 and changing uploads of docs to go to > nightlies.apache.org/ofbiz instead of ci.apache.org/projects/ofbiz . > Currently we have an issue with XMLRPC tests with BuildBot. I believe it's > because the new BB config does not allow HTTP and/or the port 8080. > For more information see https://markmail.org/message/z6qfhcb2xnlqs2ji -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467123#comment-17467123 ] Jacques Le Roux commented on OFBIZ-12456: - As can be seen at https://ci2.apache.org/#/builders it's OK for trunk and 18.12 branch The RAT builds continue to fail because of thepoint 3 below Remain few questions: 1) When I run "force build ofbizBranch18Framework forces manual build for initial testing" on ofbiz-bot IRC I get: "No such nick/channel". 2) At this point no status emails are sent (success, failure) to comm...@ofbiz.apache.org answering to d...@ofbiz.apache.org 3) I have asked Gavin xhere to put the RAT exclude file currently at https://github.com/apache/ofbiz-tools/trunk/rat-excludes.txt. > Migrate Ofbiz bb 0.8 config to 3.2 > -- > > Key: OFBIZ-12456 > URL: https://issues.apache.org/jira/browse/OFBIZ-12456 > Project: OFBiz > Issue Type: Task > Components: BuildBot >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > > This is a clone of INFRA-22279 that says: > bq. Migrate all Ofbiz configs from ci.apache.org to c2.apache.org upgrading > the config from 0.8 to 3.2 and changing uploads of docs to go to > nightlies.apache.org/ofbiz instead of ci.apache.org/projects/ofbiz . > Currently we have an issue with XMLRPC tests with BuildBot. I believe it's > because the new BB config does not allow HTTP and/or the port 8080. > For more information see https://markmail.org/message/z6qfhcb2xnlqs2ji -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)
PierreSmits commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003126709 Indeed, Ioan. Any property value used during the startup of OFBiz can't be set as a SystemProperty record. I guess that applies to most in the config folders of the framework (folder) components. But still there are several there that should be considered as run-time configurations. USD comes to mind, as one example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] ieugen commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)
ieugen commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003121702 @PierreSmits : True, and maybe we should consider moving those there. I don't think we will have a lot of config options use via ENV. For those that need this configuration - I don't think they can be configured via DB: You can't configure db connection strings from the DB, JVM options as well, perhaps even ports. I did not saw a guide for how to best handle OFBiz configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)
PierreSmits commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003054946 I like this improvement. But it seems to me that there might be more properties that could be applicable (not those related to run-time configuration, which can be retrieved from the SystemProperties table). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466855#comment-17466855 ] Ioan Eugen Stan commented on OFBIZ-9498: Thanks. I saw there is the PR here that can improve life in these situations. I did add some feedback there [https://github.com/apache/ofbiz-framework/pull/355] . Any plans to merge that now or later after more work? > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [ofbiz-framework] ieugen commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)
ieugen commented on pull request #355:
URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003014965
@gilPts : Here is my feedback:
The PR looks good overall.
* I would add documentation for this feature in the asciidoc files + link to
issue ?!
* I would make the code easier to test and add tests for these cases.
Make it easier to test by passing the env map
https://docs.oracle.com/javase/7/docs/api/java/lang/System.html#getenv() .
`public static Map getenv()` .
Add extra method:
```
public static String getEnvironmentProperty(Map env, String
value) {
// Move the implementation here
}
// Update old method to delegate to the other one like this
public static String getEnvironmentProperty(String value) {
return getEnvironmentProperty(System.getenv(), value);
}
```
Write tests that pass whatever environment you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466789#comment-17466789 ] Gil Portenseigne commented on OFBIZ-9498: - Hello [~ieugen] , Thanks for your review, I work with [~marco_adeti] whom i gave the relay to animate the subject. He should make a first proposal about a new idea, in some times. About the current patch, no progress yet, it is usable, and used in several customer project in our side, feel free to experience. > Improve DevOps using environment variable configuration > --- > > Key: OFBIZ-9498 > URL: https://issues.apache.org/jira/browse/OFBIZ-9498 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9498.patch > > > Discussed in thread : https://s.apache.org/Mh3q > This Jira will present the improvment proposal giving a way to configure > OFBiz using environment variable. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12456: Attachment: patch.patch > Migrate Ofbiz bb 0.8 config to 3.2 > -- > > Key: OFBIZ-12456 > URL: https://issues.apache.org/jira/browse/OFBIZ-12456 > Project: OFBiz > Issue Type: Task > Components: BuildBot >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > > This is a clone of INFRA-22279 that says: > bq. Migrate all Ofbiz configs from ci.apache.org to c2.apache.org upgrading > the config from 0.8 to 3.2 and changing uploads of docs to go to > nightlies.apache.org/ofbiz instead of ci.apache.org/projects/ofbiz . > Currently we have an issue with XMLRPC tests with BuildBot. I believe it's > because the new BB config does not allow HTTP and/or the port 8080. > For more information see https://markmail.org/message/z6qfhcb2xnlqs2ji -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12456: Attachment: (was: patch.patch) > Migrate Ofbiz bb 0.8 config to 3.2 > -- > > Key: OFBIZ-12456 > URL: https://issues.apache.org/jira/browse/OFBIZ-12456 > Project: OFBiz > Issue Type: Task > Components: BuildBot >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > > This is a clone of INFRA-22279 that says: > bq. Migrate all Ofbiz configs from ci.apache.org to c2.apache.org upgrading > the config from 0.8 to 3.2 and changing uploads of docs to go to > nightlies.apache.org/ofbiz instead of ci.apache.org/projects/ofbiz . > Currently we have an issue with XMLRPC tests with BuildBot. I believe it's > because the new BB config does not allow HTTP and/or the port 8080. > For more information see https://markmail.org/message/z6qfhcb2xnlqs2ji -- This message was sent by Atlassian Jira (v8.20.1#820001)
