[jira] [Commented] (OFBIZ-12508) Request - Move new item action to menu

2022-01-26 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482759#comment-17482759
 ] 

Michael Brohl commented on OFBIZ-12508:
---

Thanks Daniel, appreciate that you care!

> Request - Move new item action to menu
> --
>
> Key: OFBIZ-12508
> URL: https://issues.apache.org/jira/browse/OFBIZ-12508
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, menu-item, request, trust, usability, ux
> Fix For: Upcoming Branch
>
>
> Currently the action trigger for adding a new item to a Request, by users 
> with CREATE permissions is located in screens related to a Request.
> This action trigger should be located in the Action Menu for the request.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12544) Update of request item generates an error

2022-01-26 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12544:
-
Attachment: Screenshot 2022-01-26 at 22.56.14.png

> Update of request item generates an error
> -
>
> Key: OFBIZ-12544
> URL: https://issues.apache.org/jira/browse/OFBIZ-12544
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
>  Labels: request
> Attachments: Screenshot 2022-01-26 at 22.56.14.png
>
>
> Saving an update of a request item generates following error
> {code:java}
> 2022-01-26 22:48:08,447 |jsse-nio-8443-exec-5 |ServiceEventHandler           
> |E| Service invocation error
> org.apache.ofbiz.service.GenericServiceException: Error running simple method 
> [update] in XML file []:  (Could not find SimpleMethod XML document in 
> resource: )
>   at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:83)
>  ~[ofbiz.jar:?]
>   at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:47)
>  ~[ofbiz.jar:?]
>   at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:424)
>  ~[ofbiz.jar:?]
>   at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  ~[ofbiz.jar:?]
>   at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:93)
>  ~[ofbiz.jar:?]
>   at 
> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:253)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:1026)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:677)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:231)
>  [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81) 
> [ofbiz.jar:?]
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:681) 
> [tomcat-servlet-api-9.0.54.jar:4.0.FR]
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
> [tomcat-servlet-api-9.0.54.jar:4.0.FR]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> [tomcat-embed-websocket-9.0.41.jar:9.0.41]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.ofbiz.webapp.control.SameSiteFilter.doFilter(SameSiteFilter.java:45)
>  [ofbiz.jar:?]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:188)
>  [ofbiz.jar:?]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>   at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:57) 
> [tomcat-servlet-api-9.0.54.jar:4.0.FR]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
>  [log4j-web-2.17.1.jar:2.17.1]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
>  [tomcat-catalina-9.0.54.jar:9.0.54]
>   at 
> org.apache.catalina.core.Stand

[jira] [Created] (OFBIZ-12544) Update of request item generates an error

2022-01-26 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12544:


 Summary: Update of request item generates an error
 Key: OFBIZ-12544
 URL: https://issues.apache.org/jira/browse/OFBIZ-12544
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Upcoming Branch
Reporter: Pierre Smits


Saving an update of a request item generates following error
{code:java}
2022-01-26 22:48:08,447 |jsse-nio-8443-exec-5 |ServiceEventHandler           
|E| Service invocation error
org.apache.ofbiz.service.GenericServiceException: Error running simple method 
[update] in XML file []:  (Could not find SimpleMethod XML document in 
resource: )
at 
org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:83)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:47)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:424) 
~[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240) 
~[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:93)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:253)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:1026)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:677)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:231) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81) 
[ofbiz.jar:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:681) 
[tomcat-servlet-api-9.0.54.jar:4.0.FR]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) 
[tomcat-servlet-api-9.0.54.jar:4.0.FR]
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
[tomcat-embed-websocket-9.0.41.jar:9.0.41]
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.ofbiz.webapp.control.SameSiteFilter.doFilter(SameSiteFilter.java:45) 
[ofbiz.jar:?]
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:188) 
[ofbiz.jar:?]
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156) 
[ofbiz.jar:?]
at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:57) 
[tomcat-servlet-api-9.0.54.jar:4.0.FR]
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
 [log4j-web-2.17.1.jar:2.17.1]
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:197)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:540)
 [tomcat-catalina-9.0.54.jar:9.0.54]
at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:135) 
[tomcat-catalina-

[jira] [Updated] (OFBIZ-12540) Tracking Codes - add menu-item to MainActionMenu

2022-01-26 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12540:
-
Labels: consistency menu-item menus user-experience ux  (was: consistency 
menu-item ux)

> Tracking Codes - add menu-item to MainActionMenu
> 
>
> Key: OFBIZ-12540
> URL: https://issues.apache.org/jira/browse/OFBIZ-12540
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing/marketing
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, menu-item, menus, user-experience, ux
> Fix For: Upcoming Branch
>
>
> Add a menu-item to create new Tracking Codes to the MainActionMenu of the 
> Marketing application.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #493: Improved: CommonProduct application (OFBIZ-12543)

2022-01-26 Thread GitBox


sonarcloud[bot] commented on pull request #493:
URL: https://github.com/apache/ofbiz-framework/pull/493#issuecomment-1022506187


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=493&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=493)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=493&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=493&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #493: Improved: CommonProduct application (OFBIZ-12543)

2022-01-26 Thread GitBox


PierreSmits opened a new pull request #493:
URL: https://github.com/apache/ofbiz-framework/pull/493


   modified: InvoiceForms.xml
   applied CommonProduct to various forms and grids
   additional cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (OFBIZ-12543) Use CommonProduct in forms having LookupProduct function

2022-01-26 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12543:


 Summary: Use CommonProduct in forms having LookupProduct function
 Key: OFBIZ-12543
 URL: https://issues.apache.org/jira/browse/OFBIZ-12543
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Upcoming Branch
Reporter: Pierre Smits
Assignee: Pierre Smits






--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #492: Improved: Have CommonProduct Label for use with LookupProduct function (OFBIZ-12542)

2022-01-26 Thread GitBox


sonarcloud[bot] commented on pull request #492:
URL: https://github.com/apache/ofbiz-framework/pull/492#issuecomment-1022479696


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=492&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=492)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=492&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=492&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #492: Improved: Have CommonProduct Label for use with LookupProduct function (OFBIZ-12542)

2022-01-26 Thread GitBox


PierreSmits opened a new pull request #492:
URL: https://github.com/apache/ofbiz-framework/pull/492


   The LookupProduct function is used across various applications,
   intended to assist users with the need to search, find and select
   products in forms where one needs to be added or changed.
   Also usable in overviews where a product is referenced.
   
   modified: CommonUiLabels.xml


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #491: Improved: Have CommonProduct Label for use with LookupProduct function (OFBIZ-12542)

2022-01-26 Thread GitBox


sonarcloud[bot] commented on pull request #491:
URL: https://github.com/apache/ofbiz-framework/pull/491#issuecomment-1022475287


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=491&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=491)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=491&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=491&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits closed pull request #491: Improved: Have CommonProduct Label for use with LookupProduct function (OFBIZ-12542)

2022-01-26 Thread GitBox


PierreSmits closed pull request #491:
URL: https://github.com/apache/ofbiz-framework/pull/491


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #491: Improved: Have CommonProduct Label for use with LookupProduct function (OFBIZ-12542)

2022-01-26 Thread GitBox


PierreSmits opened a new pull request #491:
URL: https://github.com/apache/ofbiz-framework/pull/491


   The LookupProduct function is used across various applications, intended to 
assist users with the need to search, find and select products in forms where 
one needs to be added or changed. 
   Also usable in overviews where a product is referenced.
   
   modified: CommonUiLabels.xml
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (OFBIZ-12542) Have CommonProduct Label for use with LookupProduct function

2022-01-26 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12542:


 Summary: Have CommonProduct Label for use with LookupProduct 
function
 Key: OFBIZ-12542
 URL: https://issues.apache.org/jira/browse/OFBIZ-12542
 Project: OFBiz
  Issue Type: Improvement
  Components: framework/common
Affects Versions: Upcoming Branch
Reporter: Pierre Smits
Assignee: Pierre Smits


The LookupProduct function is used across various applications, intended to 
assist users with the need to search, find and select products in forms where 
one needs to be added or changed. 

Also usable in overviews where a product is referenced.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12508) Request - Move new item action to menu

2022-01-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482655#comment-17482655
 ] 

Jacques Le Roux commented on OFBIZ-12508:
-

Thanks Daniel

> Request - Move new item action to menu
> --
>
> Key: OFBIZ-12508
> URL: https://issues.apache.org/jira/browse/OFBIZ-12508
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, menu-item, request, trust, usability, ux
> Fix For: Upcoming Branch
>
>
> Currently the action trigger for adding a new item to a Request, by users 
> with CREATE permissions is located in screens related to a Request.
> This action trigger should be located in the Action Menu for the request.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #490: Improved: Have a Menu in Content featuring actions to create the main objects (OFBIZ-12541)

2022-01-26 Thread GitBox


sonarcloud[bot] commented on pull request #490:
URL: https://github.com/apache/ofbiz-framework/pull/490#issuecomment-1022451287


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=490&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=490)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=490&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=490&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #490: Improved: Have a Menu in Content featuring actions to create the main objects (OFBIZ-12541)

2022-01-26 Thread GitBox


PierreSmits opened a new pull request #490:
URL: https://github.com/apache/ofbiz-framework/pull/490


   Currently the create buttons for the main objects of the Content application 
are located within find and profile widgets/templates of those objects.
   In order to improve the usability of this application, OFBiz and thus the 
appeal of it for adopters and users, these create buttons/links/etc. should be 
in a main action menu visible at all times when a user with CREATE permissions 
is working within the application
   
   modified:
   ContentMenuxs.xml - added MainActionMenu for users with CREATE permissions 
in the Content application
   Various screens in the content component - added MainActionMenu where 
appropriate
   additional cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-12508) Request - Move new item action to menu

2022-01-26 Thread Daniel Watford (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Watford closed OFBIZ-12508.
--
Resolution: Implemented

> Request - Move new item action to menu
> --
>
> Key: OFBIZ-12508
> URL: https://issues.apache.org/jira/browse/OFBIZ-12508
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, menu-item, request, trust, usability, ux
> Fix For: Upcoming Branch
>
>
> Currently the action trigger for adding a new item to a Request, by users 
> with CREATE permissions is located in screens related to a Request.
> This action trigger should be located in the Action Menu for the request.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12508) Request - Move new item action to menu

2022-01-26 Thread Daniel Watford (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482634#comment-17482634
 ] 

Daniel Watford commented on OFBIZ-12508:


Label changes fixed/reverted in PR489. 

> Request - Move new item action to menu
> --
>
> Key: OFBIZ-12508
> URL: https://issues.apache.org/jira/browse/OFBIZ-12508
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, menu-item, request, trust, usability, ux
> Fix For: Upcoming Branch
>
>
> Currently the action trigger for adding a new item to a Request, by users 
> with CREATE permissions is located in screens related to a Request.
> This action trigger should be located in the Action Menu for the request.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12541) Have a Menu in Content featuring actions to create the main objects

2022-01-26 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12541:


 Summary: Have a Menu in Content featuring actions to create the 
main objects
 Key: OFBIZ-12541
 URL: https://issues.apache.org/jira/browse/OFBIZ-12541
 Project: OFBiz
  Issue Type: Improvement
  Components: content
Affects Versions: Upcoming Branch
Reporter: Pierre Smits
Assignee: Pierre Smits


Currently the create buttons for the main objects of the Content application 
are located within find and profile widgets/templates of those objects.

In order to improve the usability of this application, OFBiz and thus the 
appeal of it for adopters and users, these create buttons/links/etc. should be 
in a main action menu visible at all times when a user with CREATE permissions 
is working within the application



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12508) Request - Move new item action to menu

2022-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482624#comment-17482624
 ] 

ASF subversion and git services commented on OFBIZ-12508:
-

Commit acf0730c8d9a0b911411c8b002542922c2fae636 in ofbiz-framework's branch 
refs/heads/trunk from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=acf0730 ]

Reverted: Labels used for Customer Request Items (OFBIZ-12508)



> Request - Move new item action to menu
> --
>
> Key: OFBIZ-12508
> URL: https://issues.apache.org/jira/browse/OFBIZ-12508
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, menu-item, request, trust, usability, ux
> Fix For: Upcoming Branch
>
>
> Currently the action trigger for adding a new item to a Request, by users 
> with CREATE permissions is located in screens related to a Request.
> This action trigger should be located in the Action Menu for the request.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] danwatford merged pull request #489: Reverted: Labels used for Customer Request Items (OFBIZ-12508)

2022-01-26 Thread GitBox


danwatford merged pull request #489:
URL: https://github.com/apache/ofbiz-framework/pull/489


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #489: Reverted: Labels used for Customer Request Items (OFBIZ-12508)

2022-01-26 Thread GitBox


sonarcloud[bot] commented on pull request #489:
URL: https://github.com/apache/ofbiz-framework/pull/489#issuecomment-1022391498


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=489&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=489)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=489&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=489&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12526) Maintenance (demo) dataset(s)

2022-01-26 Thread Ioan Eugen Stan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482564#comment-17482564
 ] 

Ioan Eugen Stan commented on OFBIZ-12526:
-

By the way, I think you are doing a good job of adding demo data to OFBiz . 
It makes a great experience for first time users to explore the app that has 
data. 

I'll try to help as much as possible.

> Maintenance (demo) dataset(s)
> -
>
> Key: OFBIZ-12526
> URL: https://issues.apache.org/jira/browse/OFBIZ-12526
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, usability, ux
> Attachments: ofbiz-demo-data-count-by-tables.csv
>
>
> Good (demo) data increases the appeal of OFBiz, making it easier for both 
> user and contributor to understand how particular functions like screens, 
> services, etc. (should) work.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12526) Maintenance (demo) dataset(s)

2022-01-26 Thread Ioan Eugen Stan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482560#comment-17482560
 ] 

Ioan Eugen Stan commented on OFBIZ-12526:
-

Hello [~pierresmits] , 

I uploaded a CSV file [^ofbiz-demo-data-count-by-tables.csv] with the count for 
all the entities in the database and also the select query that I used to get 
that count (used Derby). 

To get the data I did the follwoing:

Loaded the demo data with 
{code:java}
./gradle cleanAll loadAll{code}
Ran the following Clojure code to export data from the embedded derby populated 
from demo data:
{code:java}
(ns dev.ofbiz-play
  "OFBiz related code - exploratory."
  (:require [next.jdbc :as jdbc]
            [next.jdbc.result-set :as rs]
            [clojure.data.csv :as csv]
            [clojure.java.io :as io])){code}
{code:java}
(comment  ;; open jdbc connection to OFBiz derby embedded database loaded with 
./gradle cleanAll loadAll
  (let [db {:jdbcUrl 
"jdbc:derby:/home/ieugen/proiecte/ofbiz/ofbiz-framework/runtime/data/derby/ofbiz"}
        ds (jdbc/get-datasource db)]
    (with-open [connection (jdbc/get-connection ds)]
      ;; read jdbc metadata for all tables
      (let [metadata (.getMetaData connection)
            rs (.getTables metadata nil nil nil (into-array ["TABLE" "VIEW"]))
            ;; get the table names from the metadata response 
            table-names (map :SYSTABLES/TABLE_NAME
                             (filter #(= "OFBIZ" (:SYSSCHEMAS/TABLE_SCHEM %))
                                     (rs/datafiable-result-set rs ds)))
            ;; build the data we need by counting all fields from each tables
            results (map (fn [t]
                           (let [query (str "select count(*) as COUNT from 
OFBIZ." t)
                                 data (:COUNT (first (jdbc/execute! ds 
[query])))]
                             {:table-name t
                              :sql-query query
                              :data data})) table-names)
            ;; get only values from map as a vector
            report-data (map (juxt :table-name :data :sql-query) results)
            report-header ["table_name" "data" "sql-query"]]
        (with-open [writer (io/writer "ofbiz-demo-data-count-by-tables.csv")]
          (csv/write-csv writer
                         (concat [report-header] report-data))
  0) {code}
with the dependencies listed bellow: 
deps.edn
{code:java}
{:aliases  {:dev {:extra-paths ["development/src" "development/resources"]
                  :extra-deps {org.apache.derby/derby {:mvn/version "10.15.2.0"}
                               org.clojure/clojure {:mvn/version "1.10.3"}
                               org.clojure/data.csv {:mvn/version "1.0.0"}} }} 
}{code}





 

> Maintenance (demo) dataset(s)
> -
>
> Key: OFBIZ-12526
> URL: https://issues.apache.org/jira/browse/OFBIZ-12526
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, usability, ux
> Attachments: ofbiz-demo-data-count-by-tables.csv
>
>
> Good (demo) data increases the appeal of OFBiz, making it easier for both 
> user and contributor to understand how particular functions like screens, 
> services, etc. (should) work.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12526) Maintenance (demo) dataset(s)

2022-01-26 Thread Ioan Eugen Stan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ioan Eugen Stan updated OFBIZ-12526:

Attachment: ofbiz-demo-data-count-by-tables.csv

> Maintenance (demo) dataset(s)
> -
>
> Key: OFBIZ-12526
> URL: https://issues.apache.org/jira/browse/OFBIZ-12526
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, usability, ux
> Attachments: ofbiz-demo-data-count-by-tables.csv
>
>
> Good (demo) data increases the appeal of OFBiz, making it easier for both 
> user and contributor to understand how particular functions like screens, 
> services, etc. (should) work.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12526) Maintenance (demo) dataset(s)

2022-01-26 Thread Ioan Eugen Stan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ioan Eugen Stan updated OFBIZ-12526:

Attachment: (was: ofbiz-demo-data-count-by-tables.csv)

> Maintenance (demo) dataset(s)
> -
>
> Key: OFBIZ-12526
> URL: https://issues.apache.org/jira/browse/OFBIZ-12526
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, usability, ux
> Attachments: ofbiz-demo-data-count-by-tables.csv
>
>
> Good (demo) data increases the appeal of OFBiz, making it easier for both 
> user and contributor to understand how particular functions like screens, 
> services, etc. (should) work.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12526) Maintenance (demo) dataset(s)

2022-01-26 Thread Ioan Eugen Stan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ioan Eugen Stan updated OFBIZ-12526:

Attachment: ofbiz-demo-data-count-by-tables.csv

> Maintenance (demo) dataset(s)
> -
>
> Key: OFBIZ-12526
> URL: https://issues.apache.org/jira/browse/OFBIZ-12526
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, usability, ux
> Attachments: ofbiz-demo-data-count-by-tables.csv
>
>
> Good (demo) data increases the appeal of OFBiz, making it easier for both 
> user and contributor to understand how particular functions like screens, 
> services, etc. (should) work.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Reopened] (OFBIZ-12526) Maintenance (demo) dataset(s)

2022-01-26 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reopened OFBIZ-12526:
--

Reopening as this is ongoing business.

 

> Maintenance (demo) dataset(s)
> -
>
> Key: OFBIZ-12526
> URL: https://issues.apache.org/jira/browse/OFBIZ-12526
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, usability, ux
>
> Good (demo) data increases the appeal of OFBiz, making it easier for both 
> user and contributor to understand how particular functions like screens, 
> services, etc. (should) work.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12539) Upgrade Tomcat from 9.0.54 to 9.0.58

2022-01-26 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482439#comment-17482439
 ] 

Jacques Le Roux commented on OFBIZ-12539:
-

I'm not sure we need to make new releases. Because I don't know if users 
persist sessions using the FileStore. So maybe simply a warning could be 
sufficient.

> Upgrade Tomcat from 9.0.54 to 9.0.58
> 
>
> Key: OFBIZ-12539
> URL: https://issues.apache.org/jira/browse/OFBIZ-12539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.05, 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.06, 22.01.01
>
>
> The fix for bug CVE-2020-9484 introduced a time of check, time of use 
> vulnerability that allowed a local attacker to perform actions with the 
> privileges of the user that the Tomcat process is using. This issue is only 
> exploitable when Tomcat is configured to persist sessions using the FileStore.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-12539) Upgrade Tomcat from 9.0.54 to 9.0.58

2022-01-26 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12539.
---
Fix Version/s: 18.12.06
   22.01.01
   Resolution: Fixed

> Upgrade Tomcat from 9.0.54 to 9.0.58
> 
>
> Key: OFBIZ-12539
> URL: https://issues.apache.org/jira/browse/OFBIZ-12539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.05, 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.06, 22.01.01
>
>
> The fix for bug CVE-2020-9484 introduced a time of check, time of use 
> vulnerability that allowed a local attacker to perform actions with the 
> privileges of the user that the Tomcat process is using. This issue is only 
> exploitable when Tomcat is configured to persist sessions using the FileStore.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #488: Improved: Tracking Code menu-item (OFBIZ-12540)

2022-01-26 Thread GitBox


sonarcloud[bot] commented on pull request #488:
URL: https://github.com/apache/ofbiz-framework/pull/488#issuecomment-1022146507


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=488&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=488)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=488&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=488&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #488: Improved: Tracking Code menu-item (OFBIZ-12540)

2022-01-26 Thread GitBox


PierreSmits opened a new pull request #488:
URL: https://github.com/apache/ofbiz-framework/pull/488


   Add a menu-item to create new Tracking Codes to the MainActionMenu of the 
Marketing application.
   
   modified: MarketingMenus.xml


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (OFBIZ-12540) Tracking Codes - add menu-item to MainActionMenu

2022-01-26 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12540:


 Summary: Tracking Codes - add menu-item to MainActionMenu
 Key: OFBIZ-12540
 URL: https://issues.apache.org/jira/browse/OFBIZ-12540
 Project: OFBiz
  Issue Type: Improvement
  Components: marketing/marketing
Reporter: Pierre Smits
Assignee: Pierre Smits
 Fix For: Upcoming Branch


Add a menu-item to create new Tracking Codes to the MainActionMenu of the 
Marketing application.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12539) Upgrade Tomcat from 9.0.54 to 9.0.58

2022-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482430#comment-17482430
 ] 

ASF subversion and git services commented on OFBIZ-12539:
-

Commit b16065c0bd146c719a633189c6aaf86963f8803f in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b16065c ]

Fixed: Upgrade Tomcat from 9.0.54 to 9.0.58 (OFBIZ-12539)

The fix for bug CVE-2020-9484 introduced a time of check, time of use
vulnerability that allowed a local attacker to perform actions with the
privileges of the user that the Tomcat process is using. This issue is only
exploitable when Tomcat is configured to persist sessions using the FileStore.

Note: because I'm a kind of outlaw (using deprecated Win 7) I must use node
13.14.0 and it causes me some issues, like the previous revert.
You can't have your cake and eat it


> Upgrade Tomcat from 9.0.54 to 9.0.58
> 
>
> Key: OFBIZ-12539
> URL: https://issues.apache.org/jira/browse/OFBIZ-12539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.05, 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> The fix for bug CVE-2020-9484 introduced a time of check, time of use 
> vulnerability that allowed a local attacker to perform actions with the 
> privileges of the user that the Tomcat process is using. This issue is only 
> exploitable when Tomcat is configured to persist sessions using the FileStore.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12539) Upgrade Tomcat from 9.0.54 to 9.0.58

2022-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482428#comment-17482428
 ] 

ASF subversion and git services commented on OFBIZ-12539:
-

Commit bbc5757782d99dfe59153641796b3ad5280d6fed in ofbiz-framework's branch 
refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bbc5757 ]

Fixed: Upgrade Tomcat from 9.0.54 to 9.0.58 (OFBIZ-12539)

The fix for bug CVE-2020-9484 introduced a time of check, time of use
vulnerability that allowed a local attacker to perform actions with the
privileges of the user that the Tomcat process is using. This issue is only
exploitable when Tomcat is configured to persist sessions using the 
FileStore.

Also reverts node from 13.14.0 back to 16.13.1. It accidentally slipped in with
OFBIZ-11960


> Upgrade Tomcat from 9.0.54 to 9.0.58
> 
>
> Key: OFBIZ-12539
> URL: https://issues.apache.org/jira/browse/OFBIZ-12539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.05, 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> The fix for bug CVE-2020-9484 introduced a time of check, time of use 
> vulnerability that allowed a local attacker to perform actions with the 
> privileges of the user that the Tomcat process is using. This issue is only 
> exploitable when Tomcat is configured to persist sessions using the FileStore.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies

2022-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482429#comment-17482429
 ] 

ASF subversion and git services commented on OFBIZ-11960:
-

Commit bbc5757782d99dfe59153641796b3ad5280d6fed in ofbiz-framework's branch 
refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bbc5757 ]

Fixed: Upgrade Tomcat from 9.0.54 to 9.0.58 (OFBIZ-12539)

The fix for bug CVE-2020-9484 introduced a time of check, time of use
vulnerability that allowed a local attacker to perform actions with the
privileges of the user that the Tomcat process is using. This issue is only
exploitable when Tomcat is configured to persist sessions using the 
FileStore.

Also reverts node from 13.14.0 back to 16.13.1. It accidentally slipped in with
OFBIZ-11960


> Use NPM with gradle to get external JS dependencies
> ---
>
> Key: OFBIZ-11960
> URL: https://issues.apache.org/jira/browse/OFBIZ-11960
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> As discussed 
> [here|https://lists.apache.org/thread.html/re16808eb5b1084f822c74194d23ca073dea4f4df443184f40f5f58c6%40%3Cdev.ofbiz.apache.org%3E],
>  use gradle-js-plugin to ease out managing the JavaScript dependencies. The 
> Gradle plugin allows us to automatically download the js libraries to the 
> user's system like the Gradle dependencies, so we no longer need to include 
> them with the package. It opens door to all the packages and modules 
> available at [npm registry|https://www.npmjs.com/]. Also, it can be clubbed 
> with Grunt or Gulp implementing tasks to minify external JS and CSS files 
> with the custom ones, see 
> [here|https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/faq.md#how-do-i-run-commands-provided-by-npm-packages].
> 1. Add 
> [gradle-node-plugin|https://github.com/node-gradle/gradle-node-plugin]: 
> Gradle plugin for integrating NodeJS in your build
>  2. Create [NPM|https://www.npmjs.com/] package.json with JS dependencies in 
> webapp
>  3. Use available tasks to install dependencies
>  
> [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#executing-npm-tasks]
>  
>  
> [https://github.com/node-gradle/gradle-node-plugin/blob/master/docs/usage.md#configuring-the-plugin]
>  4. Use the downloaded JS files in node_modules, updating the current path of 
> the JS files.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12539) Upgrade Tomcat from 9.0.54 to 9.0.58

2022-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482427#comment-17482427
 ] 

ASF subversion and git services commented on OFBIZ-12539:
-

Commit 40e89450aec4a937b193552b5b3a29c20873a43c in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=40e8945 ]

Fixed: Upgrade Tomcat from 9.0.54 to 9.0.58 (OFBIZ-12539)

The fix for bug CVE-2020-9484 introduced a time of check, time of use
vulnerability that allowed a local attacker to perform actions with the
privileges of the user that the Tomcat process is using. This issue is only
exploitable when Tomcat is configured to persist sessions using the FileStore.


> Upgrade Tomcat from 9.0.54 to 9.0.58
> 
>
> Key: OFBIZ-12539
> URL: https://issues.apache.org/jira/browse/OFBIZ-12539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.05, 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> The fix for bug CVE-2020-9484 introduced a time of check, time of use 
> vulnerability that allowed a local attacker to perform actions with the 
> privileges of the user that the Tomcat process is using. This issue is only 
> exploitable when Tomcat is configured to persist sessions using the FileStore.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12539) Upgrade Tomcat from 9.0.54 to 9.0.58

2022-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482412#comment-17482412
 ] 

ASF subversion and git services commented on OFBIZ-12539:
-

Commit 74b9146178481df76d4ffe8fc428ba43e0d9f939 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=74b9146 ]

Fixed: Upgrade Tomcat from 9.0.54 to 9.0.58 (OFBIZ-12539)

Reverts changes in package.json accidentally committed


> Upgrade Tomcat from 9.0.54 to 9.0.58
> 
>
> Key: OFBIZ-12539
> URL: https://issues.apache.org/jira/browse/OFBIZ-12539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.05, 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> The fix for bug CVE-2020-9484 introduced a time of check, time of use 
> vulnerability that allowed a local attacker to perform actions with the 
> privileges of the user that the Tomcat process is using. This issue is only 
> exploitable when Tomcat is configured to persist sessions using the FileStore.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12539) Upgrade Tomcat from 9.0.54 to 9.0.58

2022-01-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482403#comment-17482403
 ] 

ASF subversion and git services commented on OFBIZ-12539:
-

Commit 6ed30b76652e24162bcbc6efe4ca912ba0e31bc2 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6ed30b7 ]

Fixed: Upgrade Tomcat from 9.0.54 to 9.0.58 (OFBIZ-12539)

The fix for bug CVE-2020-9484 introduced a time of check, time of use
vulnerability that allowed a local attacker to perform actions with the
privileges of the user that the Tomcat process is using. This issue is only
exploitable when Tomcat is configured to persist sessions using the FileStore.


> Upgrade Tomcat from 9.0.54 to 9.0.58
> 
>
> Key: OFBIZ-12539
> URL: https://issues.apache.org/jira/browse/OFBIZ-12539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.05, 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> The fix for bug CVE-2020-9484 introduced a time of check, time of use 
> vulnerability that allowed a local attacker to perform actions with the 
> privileges of the user that the Tomcat process is using. This issue is only 
> exploitable when Tomcat is configured to persist sessions using the FileStore.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12539) Upgrade Tomcat from 9.0.54 to 9.0.58

2022-01-26 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12539:

Parent: OFBIZ-1525
Issue Type: Sub-task  (was: Bug)

> Upgrade Tomcat from 9.0.54 to 9.0.58
> 
>
> Key: OFBIZ-12539
> URL: https://issues.apache.org/jira/browse/OFBIZ-12539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: 18.12.05, 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> The fix for bug CVE-2020-9484 introduced a time of check, time of use 
> vulnerability that allowed a local attacker to perform actions with the 
> privileges of the user that the Tomcat process is using. This issue is only 
> exploitable when Tomcat is configured to persist sessions using the FileStore.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12539) Upgrade Tomcat from 9.0.54 to 9.0.56

2022-01-26 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-12539:
---

 Summary: Upgrade Tomcat from 9.0.54 to 9.0.56
 Key: OFBIZ-12539
 URL: https://issues.apache.org/jira/browse/OFBIZ-12539
 Project: OFBiz
  Issue Type: Bug
  Components: Gradle
Affects Versions: 18.12.05, 22.01.01
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux


The fix for bug CVE-2020-9484 introduced a time of check, time of use 
vulnerability that allowed a local attacker to perform actions with the 
privileges of the user that the Tomcat process is using. This issue is only 
exploitable when Tomcat is configured to persist sessions using the FileStore.





--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12539) Upgrade Tomcat from 9.0.54 to 9.0.58

2022-01-26 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12539:

Summary: Upgrade Tomcat from 9.0.54 to 9.0.58  (was: Upgrade Tomcat from 
9.0.54 to 9.0.56)

> Upgrade Tomcat from 9.0.54 to 9.0.58
> 
>
> Key: OFBIZ-12539
> URL: https://issues.apache.org/jira/browse/OFBIZ-12539
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: 18.12.05, 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> The fix for bug CVE-2020-9484 introduced a time of check, time of use 
> vulnerability that allowed a local attacker to perform actions with the 
> privileges of the user that the Tomcat process is using. This issue is only 
> exploitable when Tomcat is configured to persist sessions using the FileStore.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12538) Tracking Code - Forms Cleanup

2022-01-26 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12538:
-
Description: 
Cleanup of file TrackingCodeForms.xml:
 * remove commented out and blank lines
 * apply generic labels over component specifics on fields, where possible and 
available
 * apply common display types on fields, where possible

to get cleaner and more consistent code, to enhance user and contributor 
experience

 

  was:
Cleanup of file TrackingCodeForms.xml:
 * remove commented out and blank lines
 * apply generic labels over component specifics

to get cleaner code, enhance user and contributor experience

 


> Tracking Code - Forms Cleanup
> -
>
> Key: OFBIZ-12538
> URL: https://issues.apache.org/jira/browse/OFBIZ-12538
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing/marketing
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: cleanup, consistency, ux
>
> Cleanup of file TrackingCodeForms.xml:
>  * remove commented out and blank lines
>  * apply generic labels over component specifics on fields, where possible 
> and available
>  * apply common display types on fields, where possible
> to get cleaner and more consistent code, to enhance user and contributor 
> experience
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #487: Improved: TrackingCode - Forms Cleanup (OFBIZ-12538)

2022-01-26 Thread GitBox


sonarcloud[bot] commented on pull request #487:
URL: https://github.com/apache/ofbiz-framework/pull/487#issuecomment-1022050360


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=487&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=487)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=487&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=487&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #487: Improved: TrackingCode - Forms Cleanup (OFBIZ-12538)

2022-01-26 Thread GitBox


PierreSmits opened a new pull request #487:
URL: https://github.com/apache/ofbiz-framework/pull/487


   Cleanup of file TrackingCodeForms.xml:
   - remove commented out and blank lines
   - apply generic labels over component specifics on fields, where possible 
and available
   - apply common display types on fields, where possible 
   
   to get cleaner and more consistent code, to enhance user and contributor 
experience
   
   modified: TrackingCodeForms.xml


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (OFBIZ-12538) Tracking Code - Forms Cleanup

2022-01-26 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12538:


 Summary: Tracking Code - Forms Cleanup
 Key: OFBIZ-12538
 URL: https://issues.apache.org/jira/browse/OFBIZ-12538
 Project: OFBiz
  Issue Type: Improvement
  Components: marketing/marketing
Affects Versions: Upcoming Branch
Reporter: Pierre Smits
Assignee: Pierre Smits


Cleanup of file TrackingCodeForms.xml:
 * remove commented out and blank lines
 * apply generic labels over component specifics

to get cleaner code, enhance user and contributor experience

 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-7456) Introduce the option to add the new Customer/Supplier while placing the quotes in system if they don't exist already

2022-01-26 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7456.
--
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux
   Resolution: Implemented

> Introduce the option to add the new Customer/Supplier while placing the 
> quotes in system if they don't exist already
> 
>
> Key: OFBIZ-7456
> URL: https://issues.apache.org/jira/browse/OFBIZ-7456
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> On numerous occasions while placing Sales or Purchase quote in system, the 
> business is conducted first time with given party and its quite possible that 
> given party don't pre-exist in system. 
> At that point of time user could be allowed to create the party in either 
> Customer or Supplier role by asking few primary details as follows:
> # Party Name
> # Billing/Shipping Address
> Rest of the details can be later added/update with respect to added party 
> from Party screens.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)