[jira] [Updated] (OFBIZ-12548) placeholder text has been implemented but seems to do nothing
[ https://issues.apache.org/jira/browse/OFBIZ-12548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12548: Description: adding this to a form in a widget/somethingForms.xml file: Does not throw a error, but when the form is displayed, no placeholder text appears. I've checked the html code in the browser to confirm that it wasn't white placeholder text on a white background, and it does not define the placeholder property in the generated html. Are there any cases where placeholder text does work? If so, it would be nice if a working example could be added somewhere (like someone in ofbiz, or maybe in the "example" plugin) Here is a closed past issue implying that it's supposed to work now: OFBIZ-7024 was: adding this to a form in a widget/somethingForms.xml file: Does not throw a error, but when the form is displayed, no placeholder text appears. I've checked the html code in the browser to confirm that it wasn't white placeholder text on a white background, and it does not define the placeholder property in the generated html. Are there any cases where placeholder text does work? If so, it would be nice if a working example could be added somewhere (like someone in ofbiz, or maybe in the "example" plugin) Here is a closed past issue implying that it's supposed to work now: https://issues.apache.org/jira/browse/OFBIZ-7024 > placeholder text has been implemented but seems to do nothing > - > > Key: OFBIZ-12548 > URL: https://issues.apache.org/jira/browse/OFBIZ-12548 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.05 >Reporter: ddev >Priority: Major > > adding this to a form in a widget/somethingForms.xml file: > required-field="true"> > Does not throw a error, but when the form is displayed, no placeholder text > appears. I've checked the html code in the browser to confirm that it wasn't > white placeholder text on a white background, and it does not define the > placeholder property in the generated html. > Are there any cases where placeholder text does work? If so, it would be > nice if a working example could be added somewhere (like someone in ofbiz, or > maybe in the "example" plugin) > Here is a closed past issue implying that it's supposed to work now: > OFBIZ-7024 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (OFBIZ-12548) placeholder text has been implemented but seems to do nothing
ddev created OFBIZ-12548: Summary: placeholder text has been implemented but seems to do nothing Key: OFBIZ-12548 URL: https://issues.apache.org/jira/browse/OFBIZ-12548 Project: OFBiz Issue Type: Bug Affects Versions: 18.12.05 Reporter: ddev adding this to a form in a widget/somethingForms.xml file: Does not throw a error, but when the form is displayed, no placeholder text appears. I've checked the html code in the browser to confirm that it wasn't white placeholder text on a white background, and it does not define the placeholder property in the generated html. Are there any cases where placeholder text does work? If so, it would be nice if a working example could be added somewhere (like someone in ofbiz, or maybe in the "example" plugin) Here is a closed past issue implying that it's supposed to work now: https://issues.apache.org/jira/browse/OFBIZ-7024 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (OFBIZ-12547) Convert a display-entity to hyperlink if subhyperlink this empty
[
https://issues.apache.org/jira/browse/OFBIZ-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12547:
--
Attachment: OFBIZ-12547.patch
> Convert a display-entity to hyperlink if subhyperlink this empty
>
>
> Key: OFBIZ-12547
> URL: https://issues.apache.org/jira/browse/OFBIZ-12547
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-12547.patch
>
>
> When you define a display-entity you have the possibility to add an sub
> hyperlink related to the element displayed.
> {code:java}
>
> key-field-name="partyId" description="${groupName}${firstName} ${lastName}">
> description="view">...
>
> {code}
> This display the party name with a link "view" connected.
> If you when use the the name as link without a dedicate sub link, you need to
> change all the form with resolve the information to display for create an
> hyperlink
> {code:java}
>
> value-field="partyName">
> from-field="partyIdFrom"/>
>
>
>
>
> description="${partyNameValue}">..
> {code}
> We lost the advantage of the display-entity. We can suggest to improve
> display-entity with the rule :
> If the display-entity has a subhyperlink and the subhyperlink haven't
> description, the description of the link is the display-entity description.
> In the code, if a sub-hyperlink has an empty description, we convert the
> display entity as a hyperlink
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #495: Improved: List and Grid (OFBIZ-11345)
sonarcloud[bot] commented on pull request #495: URL: https://github.com/apache/ofbiz-framework/pull/495#issuecomment-1024287544 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=495=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=495=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=495=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=495=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=495=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=495=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=495=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=495=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=495=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=495=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=495=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=495=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=495) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=495=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=495=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #495: Improved: List and Grid (OFBIZ-11345)
PierreSmits opened a new pull request #495: URL: https://github.com/apache/ofbiz-framework/pull/495 According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid. Refactor various list forms into grids. Refactor various list form references in screens. modified: PerfReviewScreens.xml.xml: from form ref to grid ref PerfReviewForms.xml: from form definition with list ref to grid definition with list ref -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12547) Convert a display-entity to hyperlink if subhyperlink this empty
Nicolas Malin created OFBIZ-12547:
-
Summary: Convert a display-entity to hyperlink if subhyperlink
this empty
Key: OFBIZ-12547
URL: https://issues.apache.org/jira/browse/OFBIZ-12547
Project: OFBiz
Issue Type: Improvement
Components: framework/widget
Affects Versions: 22.01.01, Upcoming Branch
Reporter: Nicolas Malin
Assignee: Nicolas Malin
When you define a display-entity you have the possibility to add an sub
hyperlink related to the element displayed.
{code:java}
...
{code}
This display the party name with a link "view" connected.
If you when use the the name as link without a dedicate sub link, you need to
change all the form with resolve the information to display for create an
hyperlink
{code:java}
..
{code}
We lost the advantage of the display-entity. We can suggest to improve
display-entity with the rule :
If the display-entity has a subhyperlink and the subhyperlink haven't
description, the description of the link is the display-entity description.
In the code, if a sub-hyperlink has an empty description, we convert the
display entity as a hyperlink
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (OFBIZ-12546) Element condition-expr doesn't work with compound
[
https://issues.apache.org/jira/browse/OFBIZ-12546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12546:
--
Attachment: OFBIZ-12546.patch
> Element condition-expr doesn't work with compound
> -
>
> Key: OFBIZ-12546
> URL: https://issues.apache.org/jira/browse/OFBIZ-12546
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Labels: compound, widget
> Attachments: OFBIZ-12546.patch
>
>
> When you create an entity-condition in a form or grid under a compound
> element, to write a valid xml you write it with the namespace like this :
> {code:java}
>
>
>
> from-field="parameters.partyIdFrom"/>
> from-field="parameters.partyIdTo"/>
>
>
> {code}
>
> This failed when OFBiz execute the search with error {*}Invalid element with
> name [wf:condition-expr] found under a condition-list element{*}.
> The error came from the class *EntityFinderUtil.ConditionList* who analyze
> the condition-list's children with the namespace + node name instead take
> only the node name.
> {code:java}
> if ("condition-expr".equals(subElement.getNodeName())){code}
>
> To solve this issue we only check the local node name regardless from the
> namespace used.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (OFBIZ-12546) Element condition-expr doesn't work with compound
Nicolas Malin created OFBIZ-12546:
-
Summary: Element condition-expr doesn't work with compound
Key: OFBIZ-12546
URL: https://issues.apache.org/jira/browse/OFBIZ-12546
Project: OFBiz
Issue Type: Bug
Components: framework/widget
Affects Versions: 22.01.01, Upcoming Branch
Reporter: Nicolas Malin
Assignee: Nicolas Malin
When you create an entity-condition in a form or grid under a compound element,
to write a valid xml you write it with the namespace like this :
{code:java}
{code}
This failed when OFBiz execute the search with error {*}Invalid element with
name [wf:condition-expr] found under a condition-list element{*}.
The error came from the class *EntityFinderUtil.ConditionList* who analyze the
condition-list's children with the namespace + node name instead take only the
node name.
{code:java}
if ("condition-expr".equals(subElement.getNodeName())){code}
To solve this issue we only check the local node name regardless from the
namespace used.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12454) testInvoicePerShipment is broken
[
https://issues.apache.org/jira/browse/OFBIZ-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483687#comment-17483687
]
Jacques Le Roux commented on OFBIZ-12454:
-
Hi Pierre,
This is fundamentally wrong. The testIntegration Gradle task and actually all
integration tests are supposed to be run after a "gradlew cleanAll loadAll" or
at least a "gradlew cleanData loadAll". You may add new tests to prove your
cases but as long as testIntegration Gradle task is OK there are no reasons to
call what you raise a bug. Please close and create an improvement Jira to prove
your case with new integration test/s, TIA
> testInvoicePerShipment is broken
>
>
> Key: OFBIZ-12454
> URL: https://issues.apache.org/jira/browse/OFBIZ-12454
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Labels: integration-test, test-failure
>
>
> Running the test with parameters ("GZ-1000", "N") as shown in comment in
> OFBIZ-12453 (see below)
> {code:java}
> List invoices = testInvoicePerShipment("GZ-1000", "N") {code}
> results in an error (see below)
> {code:java}
> assert ServiceUtil.isSuccess(serviceResult) | | false ['shipmentId':'EMPTY',
> 'errorMessage':'No items currently set to be shipped. Cannot complete!',
> 'responseMessage':'error']
> Assertion failed:
> assert ServiceUtil.isSuccess(serviceResult)
> | |
> false ['shipmentId':'EMPTY', 'errorMessage':'No items currently set to be
> shipped. Cannot complete!', 'responseMessage':'error']
> at
> org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:415)
> at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:670)
> at
> org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipment(InvoicePerShipmentTests.groovy:137)
> at
> org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipmentSetFalse(InvoicePerShipmentTests.groovy:154)
> at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
> at
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
> at
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
> at
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
> at
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
> at org.apache.ofbiz.base.start.Start.main(Start.java:89) {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12453) testInvoicePerShipmentSetFalse work with runtime configuration data
[
https://issues.apache.org/jira/browse/OFBIZ-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483685#comment-17483685
]
Jacques Le Roux commented on OFBIZ-12453:
-
Hi Pierre,
This is fundamentally wrong. The testIntegration Gradle task and actually all
integration tests are supposed to be run after a "gradlew cleanAll loadAll" or
at least a "gradlew cleanData loadAll". You may add new tests to prove your
cases but as long as testIntegration Gradle task is OK there are no reasons to
call what you raise a bug. Please close and create an improvement Jira to prove
your case with new integration test/s, TIA
> testInvoicePerShipmentSetFalse work with runtime configuration data
> ---
>
> Key: OFBIZ-12453
> URL: https://issues.apache.org/jira/browse/OFBIZ-12453
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Labels: integration-test, test-failure
>
> The testInvoicePerShipmentSetFalse fails when the following is loaded into
> the SystemProperty table and the test is executed.
> {code:java}
> systemPropertyId="create.invoice.per.shipment"
> systemPropertyValue="Y"
> description="create invoice per shipment. Options: = Y (Invoice per
> shipment), N (Invoice per order)"/> {code}
> See
> https://github.com/apache/ofbiz-framework/blob/trunk/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/InvoicePerShipmentTests.groovy
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (OFBIZ-12496) Webapp Position overrides older entries
[ https://issues.apache.org/jira/browse/OFBIZ-12496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12496: --- Assignee: Benjamin Jugl (was: Jacques Le Roux) > Webapp Position overrides older entries > --- > > Key: OFBIZ-12496 > URL: https://issues.apache.org/jira/browse/OFBIZ-12496 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > > The Algorithm deciding where the actual position is in the menu is faulty. If > a later plugin is defined with position=1, the Party Manager that is defined > as position=1 by default is overwritten and does not appear in the menu > anymore. > I can provide a quick fix that shifts the newer app to the end of the line, > so no entry is lost. Ultimately we should find a solution that offers more > control. > One possible solution might be, to leave the current implementation but add a > functionality that enables themes to override this and establish their own > order. > What Do you think? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12496) Webapp Position overrides older entries
[ https://issues.apache.org/jira/browse/OFBIZ-12496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483673#comment-17483673 ] ASF subversion and git services commented on OFBIZ-12496: - Commit 90995f090f820888b1aec06d93a546e07448fd55 in ofbiz-framework's branch refs/heads/trunk from bjugl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=90995f0 ] Fixed: Webapp Position overrides older entries. (OFBIZ-12496) (#454) > Webapp Position overrides older entries > --- > > Key: OFBIZ-12496 > URL: https://issues.apache.org/jira/browse/OFBIZ-12496 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > > The Algorithm deciding where the actual position is in the menu is faulty. If > a later plugin is defined with position=1, the Party Manager that is defined > as position=1 by default is overwritten and does not appear in the menu > anymore. > I can provide a quick fix that shifts the newer app to the end of the line, > so no entry is lost. Ultimately we should find a solution that offers more > control. > One possible solution might be, to leave the current implementation but add a > functionality that enables themes to override this and establish their own > order. > What Do you think? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #454: Fixed: Webapp Position overrides older entries. (OFBIZ-12496)
JacquesLeRoux merged pull request #454: URL: https://github.com/apache/ofbiz-framework/pull/454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12496) Webapp Position overrides older entries
[ https://issues.apache.org/jira/browse/OFBIZ-12496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483672#comment-17483672 ] Jacques Le Roux commented on OFBIZ-12496: - Hi Benjamin, >One possible solution might be, to leave the current implementation but add a >functionality that enables themes to override this and establish their own >order. For now your fix works so I'll push it but will not close here: it's your decision to take. I'd suggest to close and create an improvement Jira. > Webapp Position overrides older entries > --- > > Key: OFBIZ-12496 > URL: https://issues.apache.org/jira/browse/OFBIZ-12496 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > > The Algorithm deciding where the actual position is in the menu is faulty. If > a later plugin is defined with position=1, the Party Manager that is defined > as position=1 by default is overwritten and does not appear in the menu > anymore. > I can provide a quick fix that shifts the newer app to the end of the line, > so no entry is lost. Ultimately we should find a solution that offers more > control. > One possible solution might be, to leave the current implementation but add a > functionality that enables themes to override this and establish their own > order. > What Do you think? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (OFBIZ-12496) Webapp Position overrides older entries
[ https://issues.apache.org/jira/browse/OFBIZ-12496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12496: --- Assignee: Jacques Le Roux (was: Benjamin Jugl) > Webapp Position overrides older entries > --- > > Key: OFBIZ-12496 > URL: https://issues.apache.org/jira/browse/OFBIZ-12496 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > > The Algorithm deciding where the actual position is in the menu is faulty. If > a later plugin is defined with position=1, the Party Manager that is defined > as position=1 by default is overwritten and does not appear in the menu > anymore. > I can provide a quick fix that shifts the newer app to the end of the line, > so no entry is lost. Ultimately we should find a solution that offers more > control. > One possible solution might be, to leave the current implementation but add a > functionality that enables themes to override this and establish their own > order. > What Do you think? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-11345) Lists and grids
[ https://issues.apache.org/jira/browse/OFBIZ-11345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483640#comment-17483640 ] Pierre Smits commented on OFBIZ-11345: -- Thanks to Daniel for his assistance to get this into the codebase. > Lists and grids > --- > > Key: OFBIZ-11345 > URL: https://issues.apache.org/jira/browse/OFBIZ-11345 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: cleanup, refactoring, widget > > According to the definition in widget-form.xsd the use of a combination of a > form with type="list" is deprecated in favour of a grid. > Refactor various list forms into grids. > Refactor various list form references in screens. -- This message was sent by Atlassian Jira (v8.20.1#820001)
