[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748965#comment-17748965 ] Michael Brohl commented on OFBIZ-12813: --- The changes for the plugins are added to the PR. > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #86: Improved: Refactoring groovy folder structure and package declaration (OFBIZ-12813)
sonarcloud[bot] commented on PR #86: URL: https://github.com/apache/ofbiz-plugins/pull/86#issuecomment-1657247436 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=86) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=86) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=86&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=86&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748960#comment-17748960 ] Michael Brohl commented on OFBIZ-12813: --- Thank you Jacques for the review and the summary of the open tasks. I am working on them as well. > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748951#comment-17748951 ] Jacques Le Roux commented on OFBIZ-12813: - The ecommerce and project apps seem to work as expected (fast try). I trust the other plugins applications are working so. > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748950#comment-17748950 ] Jacques Le Roux commented on OFBIZ-12813: - Hi Michael, After succesfully patching from your PR, here is what remains in plugins with the recap of what we said already above for framework to ease future work. Are concerned (presence of /groovyScripts/or groovyScripts): * Framework ** MyCommunicationEvents ** The groovyScripts task in build.gradle. There are other occurences of groovyScripts to check ** A reference to groovyScripts folders in LabelReferences.java * Plugins ** InvoiceAcctgTransEntry.rptdesign ** birt/webapp/ordermgr/WEB-INF/controller.xml ** EbayEmailScreens.xml ** projectmgr TaskScreens.xml contains a ref to a BSH file that should be removed > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748917#comment-17748917 ] Michael Brohl commented on OFBIZ-12813: --- I've provided pull request [https://github.com/apache/ofbiz-plugins/pull/86] for the plugins refactoring. testIntegration works, the applications are not tested yet. Help on this is welcome. > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-12813: - Assignee: Michael Brohl (was: Deepak Dixit) > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #86: Improved: Refactoring groovy folder structure and package declaration (OFBIZ-12813)
sonarcloud[bot] commented on PR #86: URL: https://github.com/apache/ofbiz-plugins/pull/86#issuecomment-1657105321 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=86) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=86&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=86) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=86&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=86&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] mbrohl opened a new pull request, #86: Improved: Refactoring groovy folder structure and package declaration (OFBIZ-12813)
mbrohl opened a new pull request, #86: URL: https://github.com/apache/ofbiz-plugins/pull/86 Moves groovy scripts to src and adds a package declaration to all of them. Work was done using automatic scripts from Wiebke Pätzold. LoadReactApp.groovy was handled manually because the license header was placed below some import statements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
