[jira] [Commented] (OFBIZ-12817) Pagination: jump to page with AJAX enabled is broken

2024-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817855#comment-17817855
 ] 

ASF subversion and git services commented on OFBIZ-12817:
-

Commit d0373f177417ef867ca8ab16c6260a8fa471ddce in ofbiz-framework's branch 
refs/heads/trunk from Florian Motteau
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d0373f1774 ]

Fixed: pagination, jump to page with AJAX enabled is broken (OFBIZ-12817 - #637)

Jump to page with AJAX enabled fetches the wrong page. 
We need to decrement the value entered by the user by one (page numbers are 
zero-indexed)

Thanks: Néréide Team :)

> Pagination: jump to page with AJAX enabled is broken
> 
>
> Key: OFBIZ-12817
> URL: https://issues.apache.org/jira/browse/OFBIZ-12817
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.08
>Reporter: Florian Motteau
>Priority: Minor
> Attachments: image-2023-05-10-08-24-49-082.png, 
> image-2023-05-10-08-26-47-399.png
>
>
> On a paginated grid/form which extends CommonDynamicGrid/CommonDynamicForm, 
> with ajaxEnabled=true, the framework builds an input allowing user to jump to 
> a specific page number.
> This input gets a onchange event that triggers a request for the content of 
> the target page, but the VIEW_INDEX parameter is off by one : when asking for 
> page 6 we fetch the content of page 5 (page numbers are zero-indexed, so the 
> value entered by the user should be decremented) :
> !image-2023-05-10-08-24-49-082.png|width=724,height=133!
> In this screenshot, the VIEW_INDEX should be set to "this.value - 1", just 
> like the non AJAX pagination widget does :
> !image-2023-05-10-08-26-47-399.png|width=671,height=76!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Fixed: Jump to page with AJAX decrease page number by one [ofbiz-framework]

2024-02-15 Thread via GitHub


JacquesLeRoux merged PR #637:
URL: https://github.com/apache/ofbiz-framework/pull/637


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (OFBIZ-12900) Have screen FindPartyClassificationGroups show Party MainActionMenu

2024-02-15 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817753#comment-17817753
 ] 

Pierre Smits commented on OFBIZ-12900:
--

Thanks Jacques for your assistance to get this into the codebase

> Have screen FindPartyClassificationGroups show Party MainActionMenu
> ---
>
> Key: OFBIZ-12900
> URL: https://issues.apache.org/jira/browse/OFBIZ-12900
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the FindPartyClassificationGroups screen in 
> PartyClassificationScreens.xml does not show the MainActionMenu of the party 
> component.
> For a consistent user experience this should be.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-12901) Upgrade node.js from v16.13.1 to v20

2024-02-15 Thread Daniel Watford (Jira)
Daniel Watford created OFBIZ-12901:
--

 Summary: Upgrade node.js from v16.13.1 to v20
 Key: OFBIZ-12901
 URL: https://issues.apache.org/jira/browse/OFBIZ-12901
 Project: OFBiz
  Issue Type: Task
  Components: example, Gradle
Affects Versions: Upcoming Branch
Reporter: Daniel Watford


We currently use Node.js 16 during the OFBiz build to:
 * retrieve javascript modules (resolved using NPM)
 * build react components as part of the example plugin.

Node 16 is now end-of-life 
([https://github.com/nodejs/Release/#end-of-life-releases)]

Explore upgrading OFBiz usage of Node.js to version 20.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Improved: Screen Classifications in Party should not show create trigger to user with only VIEW permission (OFBIZ-12892) [ofbiz-framework]

2024-02-15 Thread via GitHub


sonarcloud[bot] commented on PR #695:
URL: https://github.com/apache/ofbiz-framework/pull/695#issuecomment-1946665829

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=695)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=695=false=true)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=695=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=695=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=695)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Improved: Screen Classifications in Party should not show create trigger to user with only VIEW permission (OFBIZ-12892) [ofbiz-framework]

2024-02-15 Thread via GitHub


PierreSmits opened a new pull request, #695:
URL: https://github.com/apache/ofbiz-framework/pull/695

   When accessing 
https://demo-trunk.ofbiz.apache.org/partymgr/control/showclassgroups as a user 
with only VIEW permissions (e.g. userId = auditor) the action trigger to create 
a new Party Classification Group is shown.
   
   This should not be visible to such a user as it leads to an undesired effect 
and diminished user experience.
   
   modified:
   PartyClassificationScreens.xml - removed container having action trigger 
PartyMenus.xml - added menu-item newPartyClassificationGroup having permission 
condition


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (OFBIZ-12876) Use git checkout to retrieve ofbiz plugin sources when building docker images

2024-02-15 Thread Daniel Watford (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Watford closed OFBIZ-12876.
--
Fix Version/s: (was: 22.01.01)
   Resolution: Implemented

> Use git checkout to retrieve ofbiz plugin sources when building docker images
> -
>
> Key: OFBIZ-12876
> URL: https://issues.apache.org/jira/browse/OFBIZ-12876
> Project: OFBiz
>  Issue Type: Task
>  Components: Docker, GitHub
>Affects Versions: Upcoming Branch, 18.12.12, 22.01
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Major
> Fix For: Upcoming Branch, 18.12.12
>
>
> The docker-image github actions workflow currently builds 3 docker container 
> images for each of the branches it is configured to run against.
> The 3rd container image includes ofbiz plugins. The plugin sources are 
> retrieved using the pullAllPluginsSource gradle task. This gradle task will 
> soon be removed since it depends on a Subversion compatible interface to the 
> GitHub hosted ofbiz-plugins repository. The Subversion interface is scheduled 
> to be disabled by GitHub on the 8th January 2024.
> The github actions workflow should be altered to retrieve ofbiz plugin 
> sources using a git checkout of the ofbiz-plugins repository.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12876) Use git checkout to retrieve ofbiz plugin sources when building docker images

2024-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817738#comment-17817738
 ] 

ASF subversion and git services commented on OFBIZ-12876:
-

Commit 525ef139df658c53e5c3ec58f053ae886ec038d5 in ofbiz-framework's branch 
refs/heads/release18.12 from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=525ef139df ]

Removed unnecessary steps when building docker image with plugins (OFBIZ-12876)



> Use git checkout to retrieve ofbiz plugin sources when building docker images
> -
>
> Key: OFBIZ-12876
> URL: https://issues.apache.org/jira/browse/OFBIZ-12876
> Project: OFBiz
>  Issue Type: Task
>  Components: Docker, GitHub
>Affects Versions: Upcoming Branch, 18.12.12, 22.01
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Major
> Fix For: 22.01.01, Upcoming Branch, 18.12.12
>
>
> The docker-image github actions workflow currently builds 3 docker container 
> images for each of the branches it is configured to run against.
> The 3rd container image includes ofbiz plugins. The plugin sources are 
> retrieved using the pullAllPluginsSource gradle task. This gradle task will 
> soon be removed since it depends on a Subversion compatible interface to the 
> GitHub hosted ofbiz-plugins repository. The Subversion interface is scheduled 
> to be disabled by GitHub on the 8th January 2024.
> The github actions workflow should be altered to retrieve ofbiz plugin 
> sources using a git checkout of the ofbiz-plugins repository.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Removed unnecessary steps when building docker image with plugins (OFBIZ-12876) [ofbiz-framework]

2024-02-15 Thread via GitHub


danwatford merged PR #694:
URL: https://github.com/apache/ofbiz-framework/pull/694


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary steps when building docker image with plugins (OFBIZ-12876) [ofbiz-framework]

2024-02-15 Thread via GitHub


sonarcloud[bot] commented on PR #694:
URL: https://github.com/apache/ofbiz-framework/pull/694#issuecomment-1946583004

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=694)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [3 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=694=false=true)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=694=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=694=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=694)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Removed unnecessary steps when building docker image with plugins (OFBIZ-12876) [ofbiz-framework]

2024-02-15 Thread via GitHub


danwatford opened a new pull request, #694:
URL: https://github.com/apache/ofbiz-framework/pull/694

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (OFBIZ-12822) Improve Syntax - Swapping Dropdown and Text Field Order for French Date Time Input

2024-02-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-12822:
---

Assignee: Jacques Le Roux

> Improve Syntax - Swapping Dropdown and Text Field Order for French Date Time 
> Input
> --
>
> Key: OFBIZ-12822
> URL: https://issues.apache.org/jira/browse/OFBIZ-12822
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Maxime Flammang
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: 238402253-6f0a7f72-5e62-4bd0-baa4-c7d07ec132c2.png, 
> 238402482-9bcb5ec3-9770-4ad5-9ea8-6f99b8e348c9.png
>
>
> This improvement focuses on enhancing the syntax of Apache OFBiz by swapping 
> the order of the dropdown field and the text field for French date time 
> input. Specifically, this change applies only to the French language.
> By default, the date time input in Apache OFBiz consists of a text field 
> followed by a dropdown field for selecting the time. However, for French 
> users, it is more intuitive to have the dropdown field for selecting the time 
> appear before the text field.
> This improvement modifies the syntax to accommodate the French language, 
> ensuring a more user-friendly and natural experience for French-speaking 
> users.
> Please note that this change is language-specific and will not affect other 
> languages or locales.
> This improvement aims to align the date time input order with French user 
> expectations and contribute to a smoother user experience in Apache OFBiz.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12822) Improve Syntax - Swapping Dropdown and Text Field Order for French Date Time Input

2024-02-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12822.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks Maxime!

> Improve Syntax - Swapping Dropdown and Text Field Order for French Date Time 
> Input
> --
>
> Key: OFBIZ-12822
> URL: https://issues.apache.org/jira/browse/OFBIZ-12822
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Maxime Flammang
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 238402253-6f0a7f72-5e62-4bd0-baa4-c7d07ec132c2.png, 
> 238402482-9bcb5ec3-9770-4ad5-9ea8-6f99b8e348c9.png
>
>
> This improvement focuses on enhancing the syntax of Apache OFBiz by swapping 
> the order of the dropdown field and the text field for French date time 
> input. Specifically, this change applies only to the French language.
> By default, the date time input in Apache OFBiz consists of a text field 
> followed by a dropdown field for selecting the time. However, for French 
> users, it is more intuitive to have the dropdown field for selecting the time 
> appear before the text field.
> This improvement modifies the syntax to accommodate the French language, 
> ensuring a more user-friendly and natural experience for French-speaking 
> users.
> Please note that this change is language-specific and will not affect other 
> languages or locales.
> This improvement aims to align the date time input order with French user 
> expectations and contribute to a smoother user experience in Apache OFBiz.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12639) Upload image size issue

2024-02-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817687#comment-17817687
 ] 

Jacques Le Roux commented on OFBIZ-12639:
-

Hi Ingo,

Still interested?

> Upload image size issue
> ---
>
> Key: OFBIZ-12639
> URL: https://issues.apache.org/jira/browse/OFBIZ-12639
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product/catalog
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Priority: Major
> Attachments: 4054.png, RerenderPatch_notready.patch, test.jpeg
>
>
> I tied to uploaded an Image > 3MB and it fails as the line length > 1
> Does this security check make sense for images? Attached you will find the 
> image.
> Additional to that, the security message is missleading: For security reason 
> only valid files of supported image formats...
> Responsible code can be found in: SecuredUploads.java (line 205) & 
> DataServices.java (line 216)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12822) Improve Syntax - Swapping Dropdown and Text Field Order for French Date Time Input

2024-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817681#comment-17817681
 ] 

ASF subversion and git services commented on OFBIZ-12822:
-

Commit 210b63dc77106b20116f53d119e634c4ed09fd4d in ofbiz-framework's branch 
refs/heads/trunk from MaximeFlame
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=210b63dc77 ]

Improved: Swap dateTime field in French (OFBIZ-12822 - #640)

This improvement focuses on enhancing the syntax of Apache OFBiz by swapping 
the order of the dropdown field and the text field for French date time input. 
Specifically, this change applies only to the French language.

By default, the date time input in Apache OFBiz consists of a text field 
followed by a dropdown field for selecting the time. However, for French users, 
it is more intuitive to have the dropdown field for selecting the time appear 
before the text field.

This improvement modifies the syntax to accommodate the French language, 
ensuring a more user-friendly and natural experience for French-speaking users.

Please note that this change is language-specific and will not affect other 
languages or locales.

This improvement aims to align the date time input order with French user 
expectations and contribute to a smoother user experience in Apache OFBiz.

> Improve Syntax - Swapping Dropdown and Text Field Order for French Date Time 
> Input
> --
>
> Key: OFBIZ-12822
> URL: https://issues.apache.org/jira/browse/OFBIZ-12822
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Maxime Flammang
>Priority: Minor
> Attachments: 238402253-6f0a7f72-5e62-4bd0-baa4-c7d07ec132c2.png, 
> 238402482-9bcb5ec3-9770-4ad5-9ea8-6f99b8e348c9.png
>
>
> This improvement focuses on enhancing the syntax of Apache OFBiz by swapping 
> the order of the dropdown field and the text field for French date time 
> input. Specifically, this change applies only to the French language.
> By default, the date time input in Apache OFBiz consists of a text field 
> followed by a dropdown field for selecting the time. However, for French 
> users, it is more intuitive to have the dropdown field for selecting the time 
> appear before the text field.
> This improvement modifies the syntax to accommodate the French language, 
> ensuring a more user-friendly and natural experience for French-speaking 
> users.
> Please note that this change is language-specific and will not affect other 
> languages or locales.
> This improvement aims to align the date time input order with French user 
> expectations and contribute to a smoother user experience in Apache OFBiz.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Swap date Time field in French (OFBIZ-12822) [ofbiz-framework]

2024-02-15 Thread via GitHub


JacquesLeRoux commented on PR #640:
URL: https://github.com/apache/ofbiz-framework/pull/640#issuecomment-1946149974

   Thank you @danwatford and @MaximeFlame 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Swap date Time field in French (OFBIZ-12822) [ofbiz-framework]

2024-02-15 Thread via GitHub


JacquesLeRoux merged PR #640:
URL: https://github.com/apache/ofbiz-framework/pull/640


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: Use a version catalog [ofbiz-framework]

2024-02-15 Thread via GitHub


JacquesLeRoux commented on PR #648:
URL: https://github.com/apache/ofbiz-framework/pull/648#issuecomment-1946125631

   Hi @dtrunk90, 
   
   I remember having seen that before, but completly forgot about it. 
   Could you please update the PR, or create anew. At 1st glance, the conflicts 
seem a bit hard to resolve
   
   TIA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: findParty_Status. (OFBIZ-12677) [ofbiz-framework]

2024-02-15 Thread via GitHub


mbrohl commented on PR #531:
URL: https://github.com/apache/ofbiz-framework/pull/531#issuecomment-1945707912

   I'll check when I'm back from vacation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] OFBIZ-12900 Have screen FindPartyClassificationGroups show Party MainActionMenu [ofbiz-framework]

2024-02-15 Thread via GitHub


PierreSmits commented on PR #693:
URL: https://github.com/apache/ofbiz-framework/pull/693#issuecomment-1945700198

   Hi Jacques,
   
   Thanks for the feedback, but lets not dwell on trivialities.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improved: findParty_Status. (OFBIZ-12677) [ofbiz-framework]

2024-02-15 Thread via GitHub


JacquesLeRoux commented on PR #531:
URL: https://github.com/apache/ofbiz-framework/pull/531#issuecomment-1945687894

   Hi @mbrohl, should we close?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (OFBIZ-12900) Have screen FindPartyClassificationGroups show Party MainActionMenu

2024-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817616#comment-17817616
 ] 

ASF subversion and git services commented on OFBIZ-12900:
-

Commit 99e497df14411fbf6baac360ba28f12605426b48 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=99e497df14 ]

Improved: Have screen FindPartyClassificationGroups show Party MainActionMenu 
(OFBIZ-12900 - #693)

Currently the FindPartyClassificationGroups screen in 
PartyClassificationScreens.xml does not show the MainActionMenu of the party 
component.
For a consistent user experience this should be.

modified: PartyClassificationsScreens.xml
- added decorator-section 'pre-body', having MainActionMenu

> Have screen FindPartyClassificationGroups show Party MainActionMenu
> ---
>
> Key: OFBIZ-12900
> URL: https://issues.apache.org/jira/browse/OFBIZ-12900
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the FindPartyClassificationGroups screen in 
> PartyClassificationScreens.xml does not show the MainActionMenu of the party 
> component.
> For a consistent user experience this should be.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] OFBIZ-12900 Have screen FindPartyClassificationGroups show Party MainActionMenu [ofbiz-framework]

2024-02-15 Thread via GitHub


JacquesLeRoux merged PR #693:
URL: https://github.com/apache/ofbiz-framework/pull/693


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] OFBIZ-12900 Have screen FindPartyClassificationGroups show Party MainActionMenu [ofbiz-framework]

2024-02-15 Thread via GitHub


JacquesLeRoux commented on PR #693:
URL: https://github.com/apache/ofbiz-framework/pull/693#issuecomment-1945673892

   Hi Pierre,
   
   It' s not the real commit title we expect (type missing), but it's OK with 
me (because it's really trivial)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] OFBIZ-12900 Have screen FindPartyClassificationGroups show Party MainActionMenu [ofbiz-framework]

2024-02-15 Thread via GitHub


sonarcloud[bot] commented on PR #693:
URL: https://github.com/apache/ofbiz-framework/pull/693#issuecomment-1945654839

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=693)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=693=false=true)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=693=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=693=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=693)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (OFBIZ-12899) Install Scorecard as a GH action

2024-02-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817614#comment-17817614
 ] 

Jacques Le Roux commented on OFBIZ-12899:
-

Also, if it's the only info, we don't need to duplicate in plugins

> Install Scorecard as a GH action
> 
>
> Key: OFBIZ-12899
> URL: https://issues.apache.org/jira/browse/OFBIZ-12899
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> After reading some private emails in members and security-discuss, I decided 
> to test using Scorecard as a GH actions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] OFBIZ-12900 Have screen FindPartyClassificationGroups show Party MainActionMenu [ofbiz-framework]

2024-02-15 Thread via GitHub


PierreSmits opened a new pull request, #693:
URL: https://github.com/apache/ofbiz-framework/pull/693

   Currently the FindPartyClassificationGroups screen in 
PartyClassificationScreens.xml does not show the MainActionMenu of the party 
component. For a consistent user experience this should be.
   
   modified: PartyClassificationsScreens.xml
   - added decorator-section 'pre-body', having MainActionMenu
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (OFBIZ-12899) Install Scorecard as a GH action

2024-02-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12899:

Summary: Install Scorecard as a GH action  (was: Install Scorecard as a GH 
actions)

> Install Scorecard as a GH action
> 
>
> Key: OFBIZ-12899
> URL: https://issues.apache.org/jira/browse/OFBIZ-12899
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> After reading some private emails in members and security-discuss, I decided 
> to test using Scorecard as a GH actions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12899) Install Scorecard as a GH actions

2024-02-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817611#comment-17817611
 ] 

Jacques Le Roux commented on OFBIZ-12899:
-

It's fast (43s) but does not give much information, only this for the moment:
{quote}
Node.js 16 actions are deprecated. Please update the following actions to use 
Node.js 20: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8, 
actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8, 
github/codeql-action/upload-sarif@17573ee1cc1b9d061760f3a006fc4aac4f944fd5. For 
more information see: 
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
{quote}

I'm not quite sure we want to do that now...

> Install Scorecard as a GH actions
> -
>
> Key: OFBIZ-12899
> URL: https://issues.apache.org/jira/browse/OFBIZ-12899
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> After reading some private emails in members and security-discuss, I decided 
> to test using Scorecard as a GH actions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12899) Install Scorecard as a GH action

2024-02-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12899.
---
Resolution: Implemented

> Install Scorecard as a GH action
> 
>
> Key: OFBIZ-12899
> URL: https://issues.apache.org/jira/browse/OFBIZ-12899
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> After reading some private emails in members and security-discuss, I decided 
> to test using Scorecard as a GH actions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12899) Install Scorecard as a GH actions

2024-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817610#comment-17817610
 ] 

ASF subversion and git services commented on OFBIZ-12899:
-

Commit 872e9e64b13971f69e0eccb910d66a2a820e061e in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=872e9e64b1 ]

Improved: install Scorecard as a GH actions (OFBIZ-12899)

Dummy change in VERSION to see if it works as it's based on SARIF and CodeQL
failed because of that
Also and what about plugins ? Seems we need to put it in there too.


> Install Scorecard as a GH actions
> -
>
> Key: OFBIZ-12899
> URL: https://issues.apache.org/jira/browse/OFBIZ-12899
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> After reading some private emails in members and security-discuss, I decided 
> to test using Scorecard as a GH actions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-12900) Have screen FindPartyClassificationGroups show Party MainActionMenu

2024-02-15 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12900:


 Summary: Have screen FindPartyClassificationGroups show Party 
MainActionMenu
 Key: OFBIZ-12900
 URL: https://issues.apache.org/jira/browse/OFBIZ-12900
 Project: OFBiz
  Issue Type: Improvement
  Components: party
Reporter: Pierre Smits


Currently the FindPartyClassificationGroups screen in 
PartyClassificationScreens.xml does not show the MainActionMenu of the party 
component.

For a consistent user experience this should be.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-12899) Install Scorecard as a GH actions

2024-02-15 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-12899:
---

 Summary: Install Scorecard as a GH actions
 Key: OFBIZ-12899
 URL: https://issues.apache.org/jira/browse/OFBIZ-12899
 Project: OFBiz
  Issue Type: Task
  Components: ALL COMPONENTS
Affects Versions: Upcoming Branch
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
 Fix For: Upcoming Branch


After reading some private emails in members and security-discuss, I decided to 
test using Scorecard as a GH actions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12899) Install Scorecard as a GH actions

2024-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817609#comment-17817609
 ] 

ASF subversion and git services commented on OFBIZ-12899:
-

Commit a4157a9c3f55a4a0701c2dd60bf3a1caae06e1be in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a4157a9c3f ]

Improved: install Scorecard as a GH actions (OFBIZ-12899)

After reading some private emails in members and security-discuss MLs, I 
decided to test using Scorecard as a GH actions.

> Install Scorecard as a GH actions
> -
>
> Key: OFBIZ-12899
> URL: https://issues.apache.org/jira/browse/OFBIZ-12899
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> After reading some private emails in members and security-discuss, I decided 
> to test using Scorecard as a GH actions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)