[jira] [Commented] (OFBIZ-12904) Duplicate create trigger for PaymentGroup
[ https://issues.apache.org/jira/browse/OFBIZ-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818218#comment-17818218 ] Pierre Smits commented on OFBIZ-12904: -- Thanks Jacques, for your assistance to get this into the codebase > Duplicate create trigger for PaymentGroup > - > > Key: OFBIZ-12904 > URL: https://issues.apache.org/jira/browse/OFBIZ-12904 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The action trigger for creating a new PaymentGroup record is included in the > MainActionMenu of the component and in the action menu related to Payment > group. > The second one is superfluous. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-11839) Add CHANGELOG.adoc file
[ https://issues.apache.org/jira/browse/OFBIZ-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11839. --- Fix Version/s: 18.12.12 Resolution: Implemented > Add CHANGELOG.adoc file > --- > > Key: OFBIZ-11839 > URL: https://issues.apache.org/jira/browse/OFBIZ-11839 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.12 > > > Add new changelog.adoc file to maintain the changelog > *What is a changelog?* > A changelog is a file which contains a curated, chronologically ordered list > of notable changes for each version of a project. > ** > *Why keep a changelog?* > To make it easier for users and contributors to see precisely what notable > changes have been made between each release (or version) of the project. > ** > *Who needs a changelog?* > People do. Whether consumers or developers, the end users of software are > human beings who care about what's in the software. When the software > changes, people want to know why and how. > [https://keepachangelog.com/en/1.0.0/] > [Here|https://s.apache.org/7klg3] is the link for Dev list discussion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11839) Add CHANGELOG.adoc file
[ https://issues.apache.org/jira/browse/OFBIZ-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818214#comment-17818214 ] ASF subversion and git services commented on OFBIZ-11839: - Commit efeb87ff9c4ecaf8f368d920c307ef7520976d16 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=efeb87ff9c ] Improved: Add CHANGELOG.adoc file (OFBIZ-11839) After removing the unused for 1,4 years CHANGELOG.adoc file with commit d088f954b5e152ffbc385e63f52918e43406f132, following https://lists.apache.org/thread/0y1tcr6ffb3kt27xs160pmyqrv227sz2 this restores it. Its content links to https://ofbiz.apache.org/download.html#tabs-2 in the stable branch (currently 18.12). I'll also document how to maintain it at https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz Note: I don't know how works bootstrap, but #tabs-2 is not considering as an anchor. Moreover we use a very old version of bootstrap (bootstrap-transition.js v2.3.1, 2012) when the last version is 5.3.2. BTW we could use npm for that: https://getbootstrap.com/ > Add CHANGELOG.adoc file > --- > > Key: OFBIZ-11839 > URL: https://issues.apache.org/jira/browse/OFBIZ-11839 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Minor > > Add new changelog.adoc file to maintain the changelog > *What is a changelog?* > A changelog is a file which contains a curated, chronologically ordered list > of notable changes for each version of a project. > ** > *Why keep a changelog?* > To make it easier for users and contributors to see precisely what notable > changes have been made between each release (or version) of the project. > ** > *Who needs a changelog?* > People do. Whether consumers or developers, the end users of software are > human beings who care about what's in the software. When the software > changes, people want to know why and how. > [https://keepachangelog.com/en/1.0.0/] > [Here|https://s.apache.org/7klg3] is the link for Dev list discussion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (OFBIZ-11839) Add CHANGELOG.adoc file
[ https://issues.apache.org/jira/browse/OFBIZ-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-11839: - Assignee: Jacques Le Roux (was: Michael Brohl) Following https://lists.apache.org/thread/0y1tcr6ffb3kt27xs160pmyqrv227sz2 I'll put a CHANGELOG.adoc file linking to https://ofbiz.apache.org/download.html#tabs-2 in the stable branch (currently 18.12). I'll also document how to maintain it at https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz Note: I don't know how works bootstrap, but #tabs-2 is not considering as an anchor. Moreover we use a very old version of bootstrap (bootstrap-transition.js v2.3.1, 2012) when the last version is 5.3.2. BTW we could use npm for that: https://getbootstrap.com/ > Add CHANGELOG.adoc file > --- > > Key: OFBIZ-11839 > URL: https://issues.apache.org/jira/browse/OFBIZ-11839 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Minor > > Add new changelog.adoc file to maintain the changelog > *What is a changelog?* > A changelog is a file which contains a curated, chronologically ordered list > of notable changes for each version of a project. > ** > *Why keep a changelog?* > To make it easier for users and contributors to see precisely what notable > changes have been made between each release (or version) of the project. > ** > *Who needs a changelog?* > People do. Whether consumers or developers, the end users of software are > human beings who care about what's in the software. When the software > changes, people want to know why and how. > [https://keepachangelog.com/en/1.0.0/] > [Here|https://s.apache.org/7klg3] is the link for Dev list discussion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12781) Add docker build capability to trunk
[ https://issues.apache.org/jira/browse/OFBIZ-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818198#comment-17818198 ] Daniel Watford commented on OFBIZ-12781: Hi [~jleroux] - yes, it would seem reasonable to convert DOCKER.md to DOCKER.adoc. I've not written any asciidoc yet, but it looks like tools like GitHub render it nicely so it would make the information in DOCKER.adoc easily accessible, even if it doesn't get included in the developer manual or README. > Add docker build capability to trunk > > > Key: OFBIZ-12781 > URL: https://issues.apache.org/jira/browse/OFBIZ-12781 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > Mailing list thread: > [https://lists.apache.org/thread/pgqqxjbtylzclprd05998m2h5p8sv4nc] > > OFBIZ-12757 created an experimental branch to explore building OFBiz as a > docker image. > This ticket will apply the findings of that experiment to trunk providing: > * OFBiz sources which can be readily built as a docker container image. > * Documentation on how to build and use OFBiz as a container image. > * A GitHub actions workflow to build variants of OFBiz container images and > push those images to GitHub Packages (ghcr.io/apache/ofbiz). Variants are: > ** ofbiz-framework with no data pre-loaded > ** ofbiz-framework preloaded with demo data > ** ofbiz-framework and ofbiz-plugins with no data pre-loaded > There will be no changes to the OFBiz readme file, meaning the regular Gradle > build and launch process will be the primary and supported way that users > initially interact with OFBiz. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12901) Upgrade node.js from v16.13.1 to v20
[ https://issues.apache.org/jira/browse/OFBIZ-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford closed OFBIZ-12901. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Upgrade node.js from v16.13.1 to v20 > > > Key: OFBIZ-12901 > URL: https://issues.apache.org/jira/browse/OFBIZ-12901 > Project: OFBiz > Issue Type: Task > Components: example, Gradle >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > We currently use Node.js 16 during the OFBiz build: > * to retrieve javascript modules (resolved using NPM) > * to build react components as part of the example plugin. > * in various GiHub Actions, notably those used in the docker image builds > Node 16 is now end-of-life > ([https://github.com/nodejs/Release/#end-of-life-releases)] > Explore upgrading OFBiz usage of Node.js to version 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12901) Upgrade node.js from v16.13.1 to v20
[ https://issues.apache.org/jira/browse/OFBIZ-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818197#comment-17818197 ] ASF subversion and git services commented on OFBIZ-12901: - Commit 9b58c2ffc6f50f28eb86fc096a348b3c9f5944ef in ofbiz-framework's branch refs/heads/release18.12 from Daniel Watford [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9b58c2ffc6 ] Implemented: Upgrade GitHub Actions to versions dependent on Node.js v20 (OFBIZ-12901) (#701) Use newer versions of GitHub Actions in the various workflows to avoid those that are dependent on Node.js v16, instead preferring versions that use Node.js v20. > Upgrade node.js from v16.13.1 to v20 > > > Key: OFBIZ-12901 > URL: https://issues.apache.org/jira/browse/OFBIZ-12901 > Project: OFBiz > Issue Type: Task > Components: example, Gradle >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > We currently use Node.js 16 during the OFBiz build: > * to retrieve javascript modules (resolved using NPM) > * to build react components as part of the example plugin. > * in various GiHub Actions, notably those used in the docker image builds > Node 16 is now end-of-life > ([https://github.com/nodejs/Release/#end-of-life-releases)] > Explore upgrading OFBiz usage of Node.js to version 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12781) Add docker build capability to trunk
[ https://issues.apache.org/jira/browse/OFBIZ-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818196#comment-17818196 ] Jacques Le Roux commented on OFBIZ-12781: - Hi Daniel, Should we not transform DOCKER.md into DOCKER.adoc in order to include it in developer-manual.adoc and even maybe in README.adoc? > Add docker build capability to trunk > > > Key: OFBIZ-12781 > URL: https://issues.apache.org/jira/browse/OFBIZ-12781 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > Mailing list thread: > [https://lists.apache.org/thread/pgqqxjbtylzclprd05998m2h5p8sv4nc] > > OFBIZ-12757 created an experimental branch to explore building OFBiz as a > docker image. > This ticket will apply the findings of that experiment to trunk providing: > * OFBiz sources which can be readily built as a docker container image. > * Documentation on how to build and use OFBiz as a container image. > * A GitHub actions workflow to build variants of OFBiz container images and > push those images to GitHub Packages (ghcr.io/apache/ofbiz). Variants are: > ** ofbiz-framework with no data pre-loaded > ** ofbiz-framework preloaded with demo data > ** ofbiz-framework and ofbiz-plugins with no data pre-loaded > There will be no changes to the OFBiz readme file, meaning the regular Gradle > build and launch process will be the primary and supported way that users > initially interact with OFBiz. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12904) Duplicate create trigger for PaymentGroup
[ https://issues.apache.org/jira/browse/OFBIZ-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12904. --- Fix Version/s: Upcoming Branch Resolution: Done Thanks Pierre, I retrogaded to minor improvement, no need to backport. > Duplicate create trigger for PaymentGroup > - > > Key: OFBIZ-12904 > URL: https://issues.apache.org/jira/browse/OFBIZ-12904 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The action trigger for creating a new PaymentGroup record is included in the > MainActionMenu of the component and in the action menu related to Payment > group. > The second one is superfluous. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12904) Duplicate create trigger for PaymentGroup
[ https://issues.apache.org/jira/browse/OFBIZ-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12904: --- Assignee: Jacques Le Roux > Duplicate create trigger for PaymentGroup > - > > Key: OFBIZ-12904 > URL: https://issues.apache.org/jira/browse/OFBIZ-12904 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > > The action trigger for creating a new PaymentGroup record is included in the > MainActionMenu of the component and in the action menu related to Payment > group. > The second one is superfluous. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12904) Duplicate create trigger for PaymentGroup
[ https://issues.apache.org/jira/browse/OFBIZ-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12904: Issue Type: Improvement (was: Bug) Priority: Minor (was: Major) > Duplicate create trigger for PaymentGroup > - > > Key: OFBIZ-12904 > URL: https://issues.apache.org/jira/browse/OFBIZ-12904 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > > The action trigger for creating a new PaymentGroup record is included in the > MainActionMenu of the component and in the action menu related to Payment > group. > The second one is superfluous. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12904) Duplicate create trigger for PaymentGroup
[ https://issues.apache.org/jira/browse/OFBIZ-12904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818193#comment-17818193 ] ASF subversion and git services commented on OFBIZ-12904: - Commit fa4fc79d6231b016f3c7892e6e179b155203c550 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fa4fc79d62 ] Fixed: Duplicate create trigger for PaymentGroup (OFBIZ-12904) (#697) The action trigger for creating a new PaymentGroup record is included in the MainActionMenu of the component and in the action menu related to Payment group. The second one is superfluous. modified: AccountingMenus.xml - removed menu-item regarding creating a new PaymentGroup > Duplicate create trigger for PaymentGroup > - > > Key: OFBIZ-12904 > URL: https://issues.apache.org/jira/browse/OFBIZ-12904 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > The action trigger for creating a new PaymentGroup record is included in the > MainActionMenu of the component and in the action menu related to Payment > group. > The second one is superfluous. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user danwatford (triggered by danwatford). Head commit for run: ec2907e82ed4c81203096800f689b69d0061f45d / Daniel Watford Fixed: Specify JDK distribution to build with (OFBIZ-12901) Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7942640030 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user danwatford (triggered by danwatford). Head commit for run: 60b0f6b1cc379d3ddf4bb8337b367a9a32bdea00 / Daniel Watford Implemented: Upgrade GitHub Actions to verions dependent on Node.js v20 (OFBIZ-12901) Use newer versions of GitHub Actions in the various workflows to avoid those that are dependent on Node.js v16, instead preferring versions that use Node.js v20. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7942591106 With regards, GitHub Actions via GitBox
[jira] [Commented] (OFBIZ-12901) Upgrade node.js from v16.13.1 to v20
[ https://issues.apache.org/jira/browse/OFBIZ-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818192#comment-17818192 ] ASF subversion and git services commented on OFBIZ-12901: - Commit dad64bd1f94646bce479f178a9a5098286a3d20a in ofbiz-framework's branch refs/heads/trunk from Daniel Watford [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=dad64bd1f9 ] Implemented: Upgrade GitHub Actions to verions dependent on Node.js v20 (OFBIZ-12901) (#700) Use newer versions of GitHub Actions in the various workflows to avoid those that are dependent on Node.js v16, instead preferring versions that use Node.js v20. > Upgrade node.js from v16.13.1 to v20 > > > Key: OFBIZ-12901 > URL: https://issues.apache.org/jira/browse/OFBIZ-12901 > Project: OFBiz > Issue Type: Task > Components: example, Gradle >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > We currently use Node.js 16 during the OFBiz build: > * to retrieve javascript modules (resolved using NPM) > * to build react components as part of the example plugin. > * in various GiHub Actions, notably those used in the docker image builds > Node 16 is now end-of-life > ([https://github.com/nodejs/Release/#end-of-life-releases)] > Explore upgrading OFBiz usage of Node.js to version 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12901) Upgrade node.js from v16.13.1 to v20
[ https://issues.apache.org/jira/browse/OFBIZ-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818181#comment-17818181 ] ASF subversion and git services commented on OFBIZ-12901: - Commit 9888b854a14db366445a7345e33349d0c686c1c4 in ofbiz-framework's branch refs/heads/trunk from Daniel Watford [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9888b854a1 ] Implemented: Upgrade to node.js v20 (OFBIZ-12901) Node.js and NPM are used during the OFBiz build to retrieve module dependencies and to build some example plugin React components. Upgraded Node.js from v16 to v20 since v16 is end-of-life. > Upgrade node.js from v16.13.1 to v20 > > > Key: OFBIZ-12901 > URL: https://issues.apache.org/jira/browse/OFBIZ-12901 > Project: OFBiz > Issue Type: Task > Components: example, Gradle >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > We currently use Node.js 16 during the OFBiz build: > * to retrieve javascript modules (resolved using NPM) > * to build react components as part of the example plugin. > * in various GiHub Actions, notably those used in the docker image builds > Node 16 is now end-of-life > ([https://github.com/nodejs/Release/#end-of-life-releases)] > Explore upgrading OFBiz usage of Node.js to version 20. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12904) Duplicate create trigger for PaymentGroup
Pierre Smits created OFBIZ-12904: Summary: Duplicate create trigger for PaymentGroup Key: OFBIZ-12904 URL: https://issues.apache.org/jira/browse/OFBIZ-12904 Project: OFBiz Issue Type: Bug Components: accounting Reporter: Pierre Smits The action trigger for creating a new PaymentGroup record is included in the MainActionMenu of the component and in the action menu related to Payment group. The second one is superfluous. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12820) PaymentGroup Cancel button is shown to viewer
[ https://issues.apache.org/jira/browse/OFBIZ-12820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818132#comment-17818132 ] Pierre Smits commented on OFBIZ-12820: -- The 'Cancel' functionality is also included in the action menu for PaymentGroup, and it has conditions for permissions defined. So can be safely removed from the form. > PaymentGroup Cancel button is shown to viewer > - > > Key: OFBIZ-12820 > URL: https://issues.apache.org/jira/browse/OFBIZ-12820 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > Attachments: Screenshot from 2023-05-12 11-53-42.png > > > Currently when a user with only view permissions accesses the PaymentGroup > overview, as demonstrated in demo-trunk with userid=auditor, the action > trigger to cancel a PaymentGroup is shown. See attached image. -- This message was sent by Atlassian Jira (v8.20.10#820010)
