[jira] [Created] (OFBIZ-12908) Clean OFBiz Asciidoc documentation
Jacques Le Roux created OFBIZ-12908: --- Summary: Clean OFBiz Asciidoc documentation Key: OFBIZ-12908 URL: https://issues.apache.org/jira/browse/OFBIZ-12908 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Upcoming Branch Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: Upcoming Branch Even after INFRA-25484 a cleaning is necessary. I'll later create another INFRA issue for that. It's challenging because in nigthlies there are a lot of dirs and files in them that you can't easily refer to in the source even when using an IDE, notably for plugins. It's not the same structure. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: FinAccount Screen shows create trigger to user with VIEW permission (OFBIZ-12567) [ofbiz-framework]
sonarcloud[bot] commented on PR #703: URL: https://github.com/apache/ofbiz-framework/pull/703#issuecomment-1952958269 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=703) **Quality Gate passed** Issues ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=703=false=true) Measures ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=703=false=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=703=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=703) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: FinAccount Screen shows create trigger to user with VIEW permission (OFBIZ-12567) [ofbiz-framework]
PierreSmits opened a new pull request, #703: URL: https://github.com/apache/ofbiz-framework/pull/703 When accessing https://localhost:8443/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING as a user with only VIEW permissions (e.g. userid=auditor) the screen shows a action trigger to create something. This should not be visible to such a user as it leads to a undesired effect and diminished user experience. modified: - FinAccountScreens.xml - removed container having link target to create a new financial account - AccountMenus.xml - added menu-iitem to MainActionMenu for creating a new financial account -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12907) Move create new BillingAccount trigger to MainActionMenu
[ https://issues.apache.org/jira/browse/OFBIZ-12907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818550#comment-17818550 ] ASF subversion and git services commented on OFBIZ-12907: - Commit 8033f46c284a3a294311853c6d3d3aca7bc24ec4 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8033f46c28 ] Improved: Move create new BillingAccount trigger to MainActionMenu (OFBIZ-12907) (#702) Removes duplicated create label Also removes few trailing spaces (automated) > Move create new BillingAccount trigger to MainActionMenu > > > Key: OFBIZ-12907 > URL: https://issues.apache.org/jira/browse/OFBIZ-12907 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On CommonBillingAccountDecorator there is a action trigger to create a new > Billing Account that is visible to users with only VIEW permissions. > Moving the action trigger to the MainActionMenu with a permission condition > ensures that is only visible to the appropriate users. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12907) Move create new BillingAccount trigger to MainActionMenu
[ https://issues.apache.org/jira/browse/OFBIZ-12907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818548#comment-17818548 ] Pierre Smits commented on OFBIZ-12907: -- Thanks Jacques, for your assistance to get this into the codebase > Move create new BillingAccount trigger to MainActionMenu > > > Key: OFBIZ-12907 > URL: https://issues.apache.org/jira/browse/OFBIZ-12907 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On CommonBillingAccountDecorator there is a action trigger to create a new > Billing Account that is visible to users with only VIEW permissions. > Moving the action trigger to the MainActionMenu with a permission condition > ensures that is only visible to the appropriate users. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12907) Move create new BillingAccount trigger to MainActionMenu
[ https://issues.apache.org/jira/browse/OFBIZ-12907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12907. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Implemented Thanks Pierre > Move create new BillingAccount trigger to MainActionMenu > > > Key: OFBIZ-12907 > URL: https://issues.apache.org/jira/browse/OFBIZ-12907 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On CommonBillingAccountDecorator there is a action trigger to create a new > Billing Account that is visible to users with only VIEW permissions. > Moving the action trigger to the MainActionMenu with a permission condition > ensures that is only visible to the appropriate users. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12907) Move create new BillingAccount trigger to MainActionMenu
[ https://issues.apache.org/jira/browse/OFBIZ-12907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818544#comment-17818544 ] ASF subversion and git services commented on OFBIZ-12907: - Commit 780e9f77b5b77f12ce76aa301bf585bfe3ce1833 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=780e9f77b5 ] Improved: Move create new BillingAccount trigger to MainActionMenu (OFBIZ-12907) (#702) On CommonBillingAccountDecorator there is a action trigger to create a new Billing Account that is visible to users with only VIEW permissions. Moving the action trigger to the MainActionMenu with a permission condition ensures that is only visible to the appropriate users. modified: - BillingAccountScreens.xml: removed container with action trigger to create a new billing account - AccountingMenus.xml: added menu-item for creating a new billing account > Move create new BillingAccount trigger to MainActionMenu > > > Key: OFBIZ-12907 > URL: https://issues.apache.org/jira/browse/OFBIZ-12907 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Priority: Major > > On CommonBillingAccountDecorator there is a action trigger to create a new > Billing Account that is visible to users with only VIEW permissions. > Moving the action trigger to the MainActionMenu with a permission condition > ensures that is only visible to the appropriate users. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: Move create new BillingAccount trigger to MainActionMenu (OFBIZ-12907) [ofbiz-framework]
JacquesLeRoux merged PR #702: URL: https://github.com/apache/ofbiz-framework/pull/702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Move create new BillingAccount trigger to MainActionMenu (OFBIZ-12907) [ofbiz-framework]
sonarcloud[bot] commented on PR #702: URL: https://github.com/apache/ofbiz-framework/pull/702#issuecomment-1952816735 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=702) **Quality Gate passed** Issues ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=702=false=true) Measures ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=702=false=true) ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=702=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=702) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: Move create new BillingAccount trigger to MainActionMenu (OFBIZ-12907) [ofbiz-framework]
PierreSmits opened a new pull request, #702: URL: https://github.com/apache/ofbiz-framework/pull/702 On CommonBillingAccountDecorator there is a action trigger to create a new Billing Account that is visible to users with only VIEW permissions. Moving the action trigger to the MainActionMenu with a permission condition ensures that is only visible to the appropriate users. modified: - BillingAccountScreens.xml: removed container with action trigger to create a new billing account - AccountingMenus.xml: added menu-item for creating a new billing account Improved: Implemented: Documented: Completed: Reverted: Fixed: (OFBIZ-) Explanation Thanks: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12907) Move create new BillingAccount trigger to MainActionMenu
Pierre Smits created OFBIZ-12907: Summary: Move create new BillingAccount trigger to MainActionMenu Key: OFBIZ-12907 URL: https://issues.apache.org/jira/browse/OFBIZ-12907 Project: OFBiz Issue Type: Improvement Components: accounting Reporter: Pierre Smits On CommonBillingAccountDecorator there is a action trigger to create a new Billing Account that is visible to users with only VIEW permissions. Moving the action trigger to the MainActionMenu with a permission condition ensures that is only visible to the appropriate users. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12906) Make http client cookie spec configurable
Attila Magyar created OFBIZ-12906: - Summary: Make http client cookie spec configurable Key: OFBIZ-12906 URL: https://issues.apache.org/jira/browse/OFBIZ-12906 Project: OFBiz Issue Type: Bug Reporter: Attila Magyar The apache http client rejects cookies if the expiration date doesn't have the expected format (EEE, dd-MMM-yy HH:mm:ss z). {code} 2023-11-20 17:58:51,189 XXX WARN protocol.ResponseProcessCookies (ResponseProcessCookies.java:processCookies(130)) - Invalid cookie header: "Set-Cookie: sessionid=XXX; expires=Mon, 20 Nov 2023 23:03:51 GMT; HttpOnly; Max-Age=300; Path=/; SameSite=Lax; Secure". Invalid 'expires' attribute: Mon, 20 Nov 2023 23:03:51 GMT {code} This can be reconfigured by setting different cookiespec types: https://hc.apache.org/httpcomponents-client-4.5.x/current/httpclient/apidocs/org/apache/http/client/config/CookieSpecs.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12906) Make http client cookie spec configurable
[ https://issues.apache.org/jira/browse/OFBIZ-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Magyar closed OFBIZ-12906. - Resolution: Invalid Wrong project. > Make http client cookie spec configurable > - > > Key: OFBIZ-12906 > URL: https://issues.apache.org/jira/browse/OFBIZ-12906 > Project: OFBiz > Issue Type: Bug >Reporter: Attila Magyar >Priority: Major > > The apache http client rejects cookies if the expiration date doesn't have > the expected format (EEE, dd-MMM-yy HH:mm:ss z). > {code} > 2023-11-20 17:58:51,189 XXX WARN protocol.ResponseProcessCookies > (ResponseProcessCookies.java:processCookies(130)) - Invalid cookie header: > "Set-Cookie: sessionid=XXX; expires=Mon, 20 Nov 2023 23:03:51 GMT; HttpOnly; > Max-Age=300; Path=/; SameSite=Lax; Secure". Invalid 'expires' attribute: Mon, > 20 Nov 2023 23:03:51 GMT > {code} > This can be reconfigured by setting different cookiespec types: > https://hc.apache.org/httpcomponents-client-4.5.x/current/httpclient/apidocs/org/apache/http/client/config/CookieSpecs.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12905) Transform DOCKER.md into DOCKER.adoc
Jacques Le Roux created OFBIZ-12905: --- Summary: Transform DOCKER.md into DOCKER.adoc Key: OFBIZ-12905 URL: https://issues.apache.org/jira/browse/OFBIZ-12905 Project: OFBiz Issue Type: Improvement Components: Docker Affects Versions: Upcoming Branch Reporter: Jacques Le Roux Fix For: Upcoming Branch Transform DOCKER.md into DOCKER.adoc in order to include it in developer-manual.adoc and in README.adoc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12781) Add docker build capability to trunk
[ https://issues.apache.org/jira/browse/OFBIZ-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818386#comment-17818386 ] Jacques Le Roux commented on OFBIZ-12781: - Hi Daniel, I can handle it if you want. I have created OFBIZ-12905 for that > Add docker build capability to trunk > > > Key: OFBIZ-12781 > URL: https://issues.apache.org/jira/browse/OFBIZ-12781 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > Mailing list thread: > [https://lists.apache.org/thread/pgqqxjbtylzclprd05998m2h5p8sv4nc] > > OFBIZ-12757 created an experimental branch to explore building OFBiz as a > docker image. > This ticket will apply the findings of that experiment to trunk providing: > * OFBiz sources which can be readily built as a docker container image. > * Documentation on how to build and use OFBiz as a container image. > * A GitHub actions workflow to build variants of OFBiz container images and > push those images to GitHub Packages (ghcr.io/apache/ofbiz). Variants are: > ** ofbiz-framework with no data pre-loaded > ** ofbiz-framework preloaded with demo data > ** ofbiz-framework and ofbiz-plugins with no data pre-loaded > There will be no changes to the OFBiz readme file, meaning the regular Gradle > build and launch process will be the primary and supported way that users > initially interact with OFBiz. -- This message was sent by Atlassian Jira (v8.20.10#820010)