Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]
JacquesLeRoux commented on PR #569: URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966931877 Mmm, actually I'm not quite sure of the time between the 3 removings and restaurations. And maybe it was only a quirk then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]
JacquesLeRoux commented on PR #569: URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966914380 Pierre, was this recent? Because here there have been months between the 3 situations. BTW I see a "Restore branch" button at right of last removing reference. Anyway let's see... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-12919) Remove deprecated unused code
[ https://issues.apache.org/jira/browse/OFBIZ-12919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12919. --- Resolution: Done > Remove deprecated unused code > - > > Key: OFBIZ-12919 > URL: https://issues.apache.org/jira/browse/OFBIZ-12919 > Project: OFBiz > Issue Type: Improvement > Components: framework/base >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > It's about XslTransform.java. A part of its code was marked as deprecated > with OFBIZ-6274, ie at least 8 years ago. I confirm this part is not used at > all. > I did not spot it by chance. This was bring to my attention by codeQL as a > possible XXE. Even if in our case it's impossible since we don't use this > code. Semantic code analysis engine like codeQL are not able to discover > that, would be far too long anyway. Whatever, it's good to get rid of it now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12919) Remove deprecated unused code
[ https://issues.apache.org/jira/browse/OFBIZ-12919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821321#comment-17821321 ] ASF subversion and git services commented on OFBIZ-12919: - Commit 7af04a8473a498af01fbf28739e14d48b91351cf in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7af04a8473 ] Improved: Remove deprecated unused code (OFBIZ-12919) A part of XslTransform class code was marked as deprecated with OFBIZ-6274, ie at least 8 years ago. I confirm this part is not used at all. I did not spot it by chance. This was bring to my attention by codeQL as a possible XXE. Even if in our case it's impossible since we don't use this code. Semantic code analysis engine like codeQL are not able to discover that, would be far too long anyway. Whatever, it's good to get rid of it now. > Remove deprecated unused code > - > > Key: OFBIZ-12919 > URL: https://issues.apache.org/jira/browse/OFBIZ-12919 > Project: OFBiz > Issue Type: Improvement > Components: framework/base >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > It's about XslTransform.java. A part of its code was marked as deprecated > with OFBIZ-6274, ie at least 8 years ago. I confirm this part is not used at > all. > I did not spot it by chance. This was bring to my attention by codeQL as a > possible XXE. Even if in our case it's impossible since we don't use this > code. Semantic code analysis engine like codeQL are not able to discover > that, would be far too long anyway. Whatever, it's good to get rid of it now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-6274) Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*'
[ https://issues.apache.org/jira/browse/OFBIZ-6274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821322#comment-17821322 ] ASF subversion and git services commented on OFBIZ-6274: Commit 7af04a8473a498af01fbf28739e14d48b91351cf in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7af04a8473 ] Improved: Remove deprecated unused code (OFBIZ-12919) A part of XslTransform class code was marked as deprecated with OFBIZ-6274, ie at least 8 years ago. I confirm this part is not used at all. I did not spot it by chance. This was bring to my attention by codeQL as a possible XXE. Even if in our case it's impossible since we don't use this code. Semantic code analysis engine like codeQL are not able to discover that, would be far too long anyway. Whatever, it's good to get rid of it now. > Rename OFBiz artifacts from 'org.ofbiz.*' to org.apache.ofbiz.*' > > > Key: OFBIZ-6274 > URL: https://issues.apache.org/jira/browse/OFBIZ-6274 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit >Priority: Major > Fix For: 16.11.01 > > Attachments: FIX_LOGGING_OUPUT.patch, RENAME_OFBIZ_TO_APACHE.patch > > > Currently (a lot of) our java and other artifacts sport the name/reference > 'org.ofbiz'. This should be renamed to 'org.apache.ofbiz' to bring more > consistency across the projects under the Apache umbrella. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12919) Remove deprecated unused code
Jacques Le Roux created OFBIZ-12919: --- Summary: Remove deprecated unused code Key: OFBIZ-12919 URL: https://issues.apache.org/jira/browse/OFBIZ-12919 Project: OFBiz Issue Type: Improvement Components: framework/base Affects Versions: Upcoming Branch Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: Upcoming Branch It's about XslTransform.java. A part of its code was marked as deprecated with OFBIZ-6274, ie at least 8 years ago. I confirm this part is not used at all. I did not spot it by chance. This was bring to my attention by codeQL as a possible XXE. Even if in our case it's impossible since we don't use this code. Semantic code analysis engine like codeQL are not able to discover that, would be far too long anyway. Whatever, it's good to get rid of it now. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: Move from hard-code menu location to parameterized (OFBIZ-12918) [ofbiz-framework]
sonarcloud[bot] commented on PR #711: URL: https://github.com/apache/ofbiz-framework/pull/711#issuecomment-1966874596 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=711) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=711=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=711=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=711=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=711) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Move from hard-code menu location to parameterized (OFBIZ-12918) [ofbiz-framework]
sonarcloud[bot] commented on PR #711: URL: https://github.com/apache/ofbiz-framework/pull/711#issuecomment-1966852022 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=711) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=711=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=711=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=711=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=711) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12918) Move from hard-code menu location to parameterized
Pierre Smits created OFBIZ-12918: Summary: Move from hard-code menu location to parameterized Key: OFBIZ-12918 URL: https://issues.apache.org/jira/browse/OFBIZ-12918 Project: OFBiz Issue Type: Improvement Components: accounting Reporter: Pierre Smits Customization is a key aspect of the OFBiz (Open For Business) platform, providing businesses with a robust and adaptable base to customize their enterprise software solutions according to their unique operational requirements. The *Menus.xml file of a component, essential for designing user interfaces that are both intuitive and tailored to the specific roles and tasks of its users, plays a significant role in this context, as referenced within screen widgets and Freemarker templates. However, as customizations and the project's source code evolve over time, the likelihood of encountering merge conflicts increases significantly, especially when attempting to incorporate customizations alongside ongoing bug fixes and enhancements from the project. To improve the appeal of OFbiz and the developer experience, it is recommended to shift from fixed menu locations to a parameterized approach in our components and plugins. This change would enable developers to more seamlessly incorporate a 'custom' menu, facilitating the integration of project updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]
PierreSmits commented on PR #569: URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966627256 Apparently, @dixitdeepak didn't experience any issues when he deleted the branch re OFBIZ-12812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]
JacquesLeRoux commented on PR #569: URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966595574 OK thanks, let's wait another such case before asking ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12812) [SECURITY] Remove deprecated Apache XML-RPC related code (CVE-2023-49070)
[ https://issues.apache.org/jira/browse/OFBIZ-12812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821213#comment-17821213 ] Deepak Dixit commented on OFBIZ-12812: -- Thanks [~pierresmits] Deleted remove-xml-rpc branch from the repository > [SECURITY] Remove deprecated Apache XML-RPC related code (CVE-2023-49070) > - > > Key: OFBIZ-12812 > URL: https://issues.apache.org/jira/browse/OFBIZ-12812 > Project: OFBiz > Issue Type: Sub-task > Components: framework/service >Affects Versions: Upcoming Branch >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Fix For: Upcoming Branch > > > Apache XML-RPC is no longer maintained[1], we should remove the xml rpc > related code from trunk. > > [1] https://github.com/advisories/GHSA-6vwp-35w3-xph8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]
danwatford commented on PR #569: URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966476589 I didn't do anything deliberate to restore the branch. If it gets restored again by asfgit we can ask infra to advise. Perhaps we have to remove it in both the GitHub and ASF repositories. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]
JacquesLeRoux commented on PR #569: URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966464720 It's weird, why asfgit did restore twice this branch? Or is it someone hidden behind (w/o wanted to be hidden I guess)? Maybe you Daniel? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12812) [SECURITY] Remove deprecated Apache XML-RPC related code (CVE-2023-49070)
[ https://issues.apache.org/jira/browse/OFBIZ-12812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821204#comment-17821204 ] Pierre Smits commented on OFBIZ-12812: -- Hi [~deepak] This has been implemented and this ticket has been closed, but in the repository on GitHub the branch ([https://github.com/apache/ofbiz-framework/compare/trunk...remove-xml-rpc]) still exists. Should that not be removed from there too? > [SECURITY] Remove deprecated Apache XML-RPC related code (CVE-2023-49070) > - > > Key: OFBIZ-12812 > URL: https://issues.apache.org/jira/browse/OFBIZ-12812 > Project: OFBiz > Issue Type: Sub-task > Components: framework/service >Affects Versions: Upcoming Branch >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Fix For: Upcoming Branch > > > Apache XML-RPC is no longer maintained[1], we should remove the xml rpc > related code from trunk. > > [1] https://github.com/advisories/GHSA-6vwp-35w3-xph8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Fixed: PaymentGroup Cancell button is shown to viewer (OFBIZ-12820) [ofbiz-framework]
PierreSmits commented on PR #698: URL: https://github.com/apache/ofbiz-framework/pull/698#issuecomment-1966399061 The trigger to cancel a PaymentGroup is still available on the page of the PaymentGroup. See https://demo-trunk.ofbiz.apache.org/accounting/control/PaymentGroupOverview?paymentGroupId=9000. IMO, cancelling a PaymentGroup in an overview with less detail than available in the page of the PaymentGroup should be discouraged as accidental cancellations do happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12723) Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem entity
[ https://issues.apache.org/jira/browse/OFBIZ-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821170#comment-17821170 ] Daniel Watford commented on OFBIZ-12723: Thanks [~pierresmits] - Checked and removed through the GH PR interface at https://github.com/apache/ofbiz-framework/pull/569 > Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem > entity > --- > > Key: OFBIZ-12723 > URL: https://issues.apache.org/jira/browse/OFBIZ-12723 > Project: OFBiz > Issue Type: Improvement > Components: datamodel, product >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Trivial > Fix For: Upcoming Branch > > > Remove fields oldQuantityOnHand and oldAvailableToPromise from the > InventoryItem entity, associated view-entities, forms and services. > OFBiz currently has a maintenance service, updateOldInventoryToDetailAll, > which finds any InventoryItems where oldQuantityOnHand or > oldAvailableToPromise are populated and creates corresponding > InventoryItemDetail entities. The oldQuantityOnHand and oldAvailableToPromise > fields are then cleared. > Based on source code repository logs, were already in the data model when > OFBiz was imported into subversion 1st July 2006. > Given the column names for the fields are hard-coded in the data model as > QUANTITY_ON_HAND and AVAILABLE_TO_PROMISE, I assume these entity fields, > along with the updateOldInventoryToDetailAll service, were implemented as a > method of upgrading the data model and are no longer used. > Since these fields are no longer used, lets remove them and their related > code, (slightly) reducing the size of ofbiz' sources that need to be > maintained. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-8376) IncomeStatementListPdf.pdf fails
[ https://issues.apache.org/jira/browse/OFBIZ-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821166#comment-17821166 ] Daniel Watford commented on OFBIZ-8376: --- I think there is a bug in some of the reports that occurs when the report has no data. Perhaps this ticket should be repurposed for those cases, or a new ticket created. > IncomeStatementListPdf.pdf fails > > > Key: OFBIZ-8376 > URL: https://issues.apache.org/jira/browse/OFBIZ-8376 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > For > https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company > the PDF report at > https://localhost:8443/accounting/control/IncomeStatementListPdf.pdf fails -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-8376) IncomeStatementListPdf.pdf fails
[
https://issues.apache.org/jira/browse/OFBIZ-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821124#comment-17821124
]
Jacques Le Roux commented on OFBIZ-8376:
Just tried that again today and got this:
{code}
2024-02-27 10:27:46,135 |jsse-nio-8443-exec-9 |ScreenFopViewHandler
|E| Unable to transform FO file: org.apache.fop.apps.FOPException:
javax.xml.transform.TransformerException:
org.apache.fop.fo.ValidationException: null:93:89:
"fo:table-row" is not a valid child of "fo:table"! (See position 93:89)
javax.xml.transform.TransformerException:
org.apache.fop.fo.ValidationException: null:93:89: "fo:table-row" is not a
valid child of "fo:table"! (See position 93:89); Screen XSL:FO text was:
http://www.w3.org/1999/XSL/Format;
>
Entreprise
Company - Your Company Name Here
Nom de
lutilisateur
auditor
Date
2024-02-27 10:27:40.613
Page
de
Balance comptablefont-size="10" font-weight="bold" padding-top="10pt" padding-bottom="4pt"
>PÚriode: FY2024: 2024-01-01 00:00:00.000 - 2025-01-01
>00:00:00.000font-style="italic" padding-top="10pt" padding-bottom="4pt"
>Consolidation des donnÚes depuis la liste [Accounting department,
>Development department, A Group of Lead Owners, Development Team1, Development
>Team2, Development Team3, Development Team4, Developer1 , Developer2 , Develope
r3 , Marketing department, Sales department, Testing department, Testing Team1,
Testing Team2, TestingTeamMember1 , TestingTeamMember2 , TestingTeamMember3 ,
Accountant Group, Accounting Administrator]
D: 0font-style="italic" padding-top="10pt" padding-bottom="4pt"
>C: 0
{code}
I tried a bit but finally did not dare to dig it
> IncomeStatementListPdf.pdf fails
>
>
> Key: OFBIZ-8376
> URL: https://issues.apache.org/jira/browse/OFBIZ-8376
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> For
> https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company
> the PDF report at
> https://localhost:8443/accounting/control/IncomeStatementListPdf.pdf fails
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12567) FinAccount Screen shows create trigger to user with VIEW permission
[ https://issues.apache.org/jira/browse/OFBIZ-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821119#comment-17821119 ] Pierre Smits commented on OFBIZ-12567: -- Thanks Jacques > FinAccount Screen shows create trigger to user with VIEW permission > --- > > Key: OFBIZ-12567 > URL: https://issues.apache.org/jira/browse/OFBIZ-12567 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: finAccount, permissions, trust, user-experience > Fix For: Upcoming Branch > > > When accessing > [https://localhost:8443/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING] > as a user with only VIEW permissions (e.g. userid=auditor) the screen shows > a action trigger to create something. > This should not be visible to such a user as it leads to a undesired effect > and diminished user experience. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12567) FinAccount Screen shows create trigger to user with VIEW permission
[ https://issues.apache.org/jira/browse/OFBIZ-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12567. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Implemented Thanks for the reminder Pierre > FinAccount Screen shows create trigger to user with VIEW permission > --- > > Key: OFBIZ-12567 > URL: https://issues.apache.org/jira/browse/OFBIZ-12567 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: finAccount, permissions, trust, user-experience > Fix For: Upcoming Branch > > > When accessing > [https://localhost:8443/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING] > as a user with only VIEW permissions (e.g. userid=auditor) the screen shows > a action trigger to create something. > This should not be visible to such a user as it leads to a undesired effect > and diminished user experience. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12567) FinAccount Screen shows create trigger to user with VIEW permission
[ https://issues.apache.org/jira/browse/OFBIZ-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821090#comment-17821090 ] ASF subversion and git services commented on OFBIZ-12567: - Commit 8ef3441a7fb836c4d5a296c59eba525f67187169 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8ef3441a7f ] Improved: FinAccount Screen shows create trigger to user with VIEW permission (OFBIZ-12567) (#703) When accessing https://localhost:8443/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING as a user with only VIEW permissions (e.g. userid=auditor) the screen shows a action trigger to create something. This should not be visible to such a user as it leads to a undesired effect and diminished user experience. modified: - FinAccountScreens.xml - removed container having link target to create a new financial account - AccountMenus.xml - added menu-iitem to MainActionMenu for creating a new financial account > FinAccount Screen shows create trigger to user with VIEW permission > --- > > Key: OFBIZ-12567 > URL: https://issues.apache.org/jira/browse/OFBIZ-12567 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > Labels: finAccount, permissions, trust, user-experience > > When accessing > [https://localhost:8443/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING] > as a user with only VIEW permissions (e.g. userid=auditor) the screen shows > a action trigger to create something. > This should not be visible to such a user as it leads to a undesired effect > and diminished user experience. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: FinAccount Screen shows create trigger to user with VIEW permission (OFBIZ-12567) [ofbiz-framework]
JacquesLeRoux merged PR #703: URL: https://github.com/apache/ofbiz-framework/pull/703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-8376) IncomeStatementListPdf.pdf fails
[ https://issues.apache.org/jira/browse/OFBIZ-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821083#comment-17821083 ] Jacques Le Roux commented on OFBIZ-8376: OK, thanks Daniel > IncomeStatementListPdf.pdf fails > > > Key: OFBIZ-8376 > URL: https://issues.apache.org/jira/browse/OFBIZ-8376 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > For > https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company > the PDF report at > https://localhost:8443/accounting/control/IncomeStatementListPdf.pdf fails -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12723) Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem entity
[ https://issues.apache.org/jira/browse/OFBIZ-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821069#comment-17821069 ] Pierre Smits commented on OFBIZ-12723: -- HI [~danwatford], This has been implemented,, but in the repository on GitHub the branch ([https://github.com/apache/ofbiz-framework/tree/ofbiz-12723]) still exists. Should that not be removed from there? Best regards, Pierre > Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem > entity > --- > > Key: OFBIZ-12723 > URL: https://issues.apache.org/jira/browse/OFBIZ-12723 > Project: OFBiz > Issue Type: Improvement > Components: datamodel, product >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Trivial > Fix For: Upcoming Branch > > > Remove fields oldQuantityOnHand and oldAvailableToPromise from the > InventoryItem entity, associated view-entities, forms and services. > OFBiz currently has a maintenance service, updateOldInventoryToDetailAll, > which finds any InventoryItems where oldQuantityOnHand or > oldAvailableToPromise are populated and creates corresponding > InventoryItemDetail entities. The oldQuantityOnHand and oldAvailableToPromise > fields are then cleared. > Based on source code repository logs, were already in the data model when > OFBiz was imported into subversion 1st July 2006. > Given the column names for the fields are hard-coded in the data model as > QUANTITY_ON_HAND and AVAILABLE_TO_PROMISE, I assume these entity fields, > along with the updateOldInventoryToDetailAll service, were implemented as a > method of upgrading the data model and are no longer used. > Since these fields are no longer used, lets remove them and their related > code, (slightly) reducing the size of ofbiz' sources that need to be > maintained. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-8376) IncomeStatementListPdf.pdf fails
[ https://issues.apache.org/jira/browse/OFBIZ-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821055#comment-17821055 ] Daniel Watford commented on OFBIZ-8376: --- Hi [~jleroux] - this issue was likely resolved by the removal of the BIRT plugin since that plugin would override various PDF reports in the accounting application. I don't believe the issue was fixed by OFBIZ-12915 since the issue does not occur on the demo-next site. > IncomeStatementListPdf.pdf fails > > > Key: OFBIZ-8376 > URL: https://issues.apache.org/jira/browse/OFBIZ-8376 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > For > https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company > the PDF report at > https://localhost:8443/accounting/control/IncomeStatementListPdf.pdf fails -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-8376) IncomeStatementListPdf.pdf fails
[ https://issues.apache.org/jira/browse/OFBIZ-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821050#comment-17821050 ] Jacques Le Roux commented on OFBIZ-8376: Maybe related to OFBIZ-12915 > IncomeStatementListPdf.pdf fails > > > Key: OFBIZ-8376 > URL: https://issues.apache.org/jira/browse/OFBIZ-8376 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > For > https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company > the PDF report at > https://localhost:8443/accounting/control/IncomeStatementListPdf.pdf fails -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-8376) IncomeStatementListPdf.pdf fails
[ https://issues.apache.org/jira/browse/OFBIZ-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8376. -- Fix Version/s: Upcoming Branch Resolution: Fixed Not sure when and how this was fixed but the issue exists no more > IncomeStatementListPdf.pdf fails > > > Key: OFBIZ-8376 > URL: https://issues.apache.org/jira/browse/OFBIZ-8376 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk, Upcoming Branch >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > For > https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company > the PDF report at > https://localhost:8443/accounting/control/IncomeStatementListPdf.pdf fails -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12917) Move Create Agreement action trigger to MainActionsMenu
[ https://issues.apache.org/jira/browse/OFBIZ-12917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821043#comment-17821043 ] Pierre Smits commented on OFBIZ-12917: -- Thanks Jacques > Move Create Agreement action trigger to MainActionsMenu > --- > > Key: OFBIZ-12917 > URL: https://issues.apache.org/jira/browse/OFBIZ-12917 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > On the agreements search/find page and the agreement pages a create trigger > exists. This should move too the MainActionMenu for a unified User Experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
